tree: git://anongit.freedesktop.org/drm-intel topic/drm-misc
head: a4fce9cb782ad340ee5576a38e934e5e75832dc6
commit: a4fce9cb782ad340ee5576a38e934e5e75832dc6 [25/25] drm/prime: Take a ref on the drm_dev when exporting a dma_buf
reproduce: make htmldocs
All warnings (new ones prefixed by >>):
include/drm/drm_fb_helper.h:222: warning: Cannot understand * @DRM_FB_HELPER_DEFAULT_OPS:
on line 222 - I thought it was a doc line
>> drivers/gpu/drm/drm_prime.c:298: warning: No …
[View More]description found for parameter 'dev'
>> drivers/gpu/drm/drm_prime.c:298: warning: No description found for parameter 'exp_info'
>> drivers/gpu/drm/drm_prime.c:298: warning: Excess function parameter 'dma_buf' description in 'drm_gem_dmabuf_export'
drivers/gpu/drm/drm_prime.c:299: warning: No description found for parameter 'dev'
drivers/gpu/drm/drm_prime.c:299: warning: No description found for parameter 'exp_info'
drivers/gpu/drm/drm_prime.c:299: warning: Excess function parameter 'dma_buf' description in 'drm_gem_dmabuf_export'
vim +/dev +298 drivers/gpu/drm/drm_prime.c
282 {
283 /* nothing to be done here */
284 }
285
286 /**
287 * drm_gem_dmabuf_export - dma_buf export implementation for GEM
288 * @dma_buf: buffer to be exported
289 *
290 * This wraps dma_buf_export() for use by generic GEM drivers that are using
291 * drm_gem_dmabuf_release(). In addition to calling dma_buf_export(), we take
292 * a reference to the drm_device which is released by drm_gem_dmabuf_release().
293 *
294 * Returns the new dmabuf.
295 */
296 struct dma_buf *drm_gem_dmabuf_export(struct drm_device *dev,
297 struct dma_buf_export_info *exp_info)
> 298 {
299 struct dma_buf *dma_buf;
300
301 dma_buf = dma_buf_export(exp_info);
302 if (!IS_ERR(dma_buf))
303 drm_dev_ref(dev);
304
305 return dma_buf;
306 }
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[View Less]
https://bugs.freedesktop.org/show_bug.cgi?id=97894
Bug ID: 97894
Summary: Crash in u_transfer_unmap_vtbl when unmapping a buffer
mapped in different context
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
Severity: normal
Priority: medium
Component: Drivers/Gallium/radeonsi
Assignee: dri-devel(a)lists.freedesktop.org
…
[View More] Reporter: jlegg(a)feralinteractive.com
QA Contact: dri-devel(a)lists.freedesktop.org
Created attachment 126724
--> https://bugs.freedesktop.org/attachment.cgi?id=126724&action=edit
Apitrace reproducing issue
The following sequence of events cause a crash on radeonsi:
1. Create two contexts in the same share group
2. In one of the contexts, create and map a buffer. Then delete that context.
3. Create another context in the share group
4. Cause the buffer to be unmapped in the new context (either explicitly with
glUnmapBuffer/glUnmapNamedBuffer or implicitly via glDeleteBuffers).
The attached apitrace reproduces the issue when using an AMD R9 270, unless
environment variable LIBGL_ALWAYS_SOFTWARE is set to 1.
I reproduced this using Mesa git 36f0f0318275f65f8744ec6f9471702e2f58e6d5 and
the 12.0.3 release on x86_64 Fedora 24.
My OpenGL renderer string is Gallium 0.4 on AMD PITCAIRN (DRM 2.45.0 /
4.7.2-201.fc24.x86_64, LLVM 3.9.0).
--
You are receiving this mail because:
You are the assignee for the bug.
[View Less]
https://bugs.freedesktop.org/show_bug.cgi?id=98037
Alex Deucher <alexdeucher(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #127027|text/x-log |text/plain
mime type| |
--
You are receiving this mail because:
You are the assignee for the bug.
dma_buf_export() adds a reference to the owning module to the dmabuf (to
prevent the driver from being unloaded whilst a third party still refers
to the dmabuf). However, drm_gem_prime_export() was passing its own
THIS_MODULE (i.e. drm.ko) rather than the driver. Extract the right
owner from the device->fops instead.
v2: Use C99 initializers to zero out unset elements of
dma_buf_export_info
v3: Extract the right module from dev->fops.
Testcase: igt/vgem_basic/unload
Reported-by: Petri …
[View More]Latvala <petri.latvala(a)intel.com>
Signed-off-by: Chris Wilson <chris(a)chris-wilson.co.uk>
Cc: Petri Latvala <petri.latvala(a)intel.com>
Cc: Christian König <christian.koenig(a)amd.com>
Cc: stable(a)vger.kernel.org
Tested-by: Petri Latvala <petri.latvala(a)intel.com>
---
drivers/gpu/drm/drm_prime.c | 17 ++++++++++-------
include/drm/drmP.h | 3 ++-
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
index 57201d68cf61..80907b34d857 100644
--- a/drivers/gpu/drm/drm_prime.c
+++ b/drivers/gpu/drm/drm_prime.c
@@ -397,14 +397,17 @@ static const struct dma_buf_ops drm_gem_prime_dmabuf_ops = {
* using the PRIME helpers.
*/
struct dma_buf *drm_gem_prime_export(struct drm_device *dev,
- struct drm_gem_object *obj, int flags)
+ struct drm_gem_object *obj,
+ int flags)
{
- DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
-
- exp_info.ops = &drm_gem_prime_dmabuf_ops;
- exp_info.size = obj->size;
- exp_info.flags = flags;
- exp_info.priv = obj;
+ struct dma_buf_export_info exp_info = {
+ .exp_name = KBUILD_MODNAME, /* white lie for debug */
+ .owner = dev->driver->fops->owner,
+ .ops = &drm_gem_prime_dmabuf_ops,
+ .size = obj->size,
+ .flags = flags,
+ .priv = obj,
+ };
if (dev->driver->gem_prime_res_obj)
exp_info.resv = dev->driver->gem_prime_res_obj(obj);
diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index 0e99669159c1..81fcd553edf7 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -1012,7 +1012,8 @@ static inline int drm_debugfs_remove_files(const struct drm_info_list *files,
#endif
extern struct dma_buf *drm_gem_prime_export(struct drm_device *dev,
- struct drm_gem_object *obj, int flags);
+ struct drm_gem_object *obj,
+ int flags);
extern int drm_gem_prime_handle_to_fd(struct drm_device *dev,
struct drm_file *file_priv, uint32_t handle, uint32_t flags,
int *prime_fd);
--
2.9.3
[View Less]
https://bugs.freedesktop.org/show_bug.cgi?id=98037
--- Comment #6 from Will Lewis <minutemaidpark(a)hotmail.com> ---
Created attachment 127027
--> https://bugs.freedesktop.org/attachment.cgi?id=127027&action=edit
Xorg log
X started successfully, with output only to the attached DVI connector. xrandr
--output HDMI-0 --mode 1920x1080 failed to light up the TV through the HDMI
connector.
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.freedesktop.org/show_bug.cgi?id=98002
Bug ID: 98002
Summary: Mud rendering bug in Portal 2
Product: Mesa
Version: 12.0
Hardware: Other
OS: All
Status: NEW
Severity: normal
Priority: medium
Component: Drivers/Gallium/radeonsi
Assignee: dri-devel(a)lists.freedesktop.org
Reporter: geecko.dev(a)free.fr
QA Contact: dri-devel(a)lists.freedesktop.org
…
[View More]
Created attachment 126930
--> https://bugs.freedesktop.org/attachment.cgi?id=126930&action=edit
Screenshot
Software:
- Linux 4.7.5
- mesa 12.0.2 / llvm 3.8.1
- mesa 1d466b9 / llvm 282838
R9 Fury
See the screenshot attached. All the golden reflective surface should be dark
as shown here: https://youtu.be/A0K5EXfgJnk?t=1h19m52s
You can find an apitrace here. http://ge.tt/6mikBDf2
--
You are receiving this mail because:
You are the assignee for the bug.
[View Less]