dri-devel October 2016

dri-devel@lists.freedesktop.org

215 participants
1390 discussions

[Bug 98003] Tonga fails to boot since drm/amdgpu:exclude 5dw digest for entry
by bugzilla-daemon＠freedesktop.org 04 Oct '16

04 Oct '16

https://bugs.freedesktop.org/show_bug.cgi?id=98003 Bug ID: 98003 Summary: Tonga fails to boot since drm/amdgpu:exclude 5dw digest for entry Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: adf.lists(a)gmail.com R9285 tonga agd5f drm-next-4.9-wip since below booting from power off fails just after drm initializing. Monitor off, no logs, can SysRq. Works rebooting from a working kernel. commit 1e746dcbd1fb104b53c7b93d83e3013aa028ce8b Author: Monk Liu <Monk.Liu(a)amd.com> Date: Tue Sep 27 13:44:44 2016 +0800 drm/amdgpu:exclude 5dw digest for entry -- You are receiving this mail because: You are the assignee for the bug.

1 5

[Bug 98020] Tonga agd5f 4.9-wip WARNING: at drivers/gpu/drm/drm_irq.c:1168 drm_vblank_put+0xaa/0xb0
by bugzilla-daemon＠freedesktop.org 04 Oct '16

04 Oct '16

https://bugs.freedesktop.org/show_bug.cgi?id=98020 Bug ID: 98020 Summary: Tonga agd5f 4.9-wip WARNING: at drivers/gpu/drm/drm_irq.c:1168 drm_vblank_put+0xaa/0xb0 Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: adf.lists(a)gmail.com R9285 on current agd5f drm-next-4.9-wip I get 00s of below when running videos/games full screen. The last version of the branch didn't have this issue. No bisect, but a couple of reset --hard seem to show it started with one of the recent merges. Oct 2 20:59:18 ph4 kernel: WARNING: CPU: 2 PID: 735 at drivers/gpu/drm/drm_irq.c:1168 drm_vblank_put+0xaa/0xb0 [drm] Oct 2 20:59:18 ph4 kernel: Modules linked in: amdgpu fbcon bitblit fbcon_rotate fbcon_ccw fbcon_ud snd_hda_codec_realtek fbcon_cw snd_hda_codec_generic snd_usb_audio softcursor snd_hda_codec_hdmi font snd_hda_intel mfd_core tileblit i2c_algo_bit snd_hda_codec drm_kms_helper snd_usbmidi_lib snd_rawmidi snd_hda_core syscopyarea sysfillrect snd_hwdep sysimgblt snd_seq_device fb_sys_fops snd_pcm ttm drm snd_timer snd r8169 serio_raw e100 xhci_pci xhci_hcd soundcore i2c_piix4 mii k10temp acpi_cpufreq Oct 2 20:59:18 ph4 kernel: CPU: 2 PID: 735 Comm: Xorg Tainted: G W 4.8.0-rc8-gb97c6ee #3 Oct 2 20:59:18 ph4 kernel: Hardware name: To Be Filled By O.E.M. To Be Filled By O.E.M./970 Extreme3 R2.0, BIOS P1.60 06/05/2014 Oct 2 20:59:18 ph4 kernel: 0000000000000000 ffff88023210bc78 ffffffff812d8bcb 0000000000000000 Oct 2 20:59:18 ph4 kernel: 0000000000000000 ffff88023210bcb8 ffffffff8105d378 00000490a016ee6b Oct 2 20:59:18 ph4 kernel: ffff88023210bdb8 ffff8802320e9068 00000000ffffffea ffff8802320e9000 Oct 2 20:59:18 ph4 kernel: Call Trace: Oct 2 20:59:18 ph4 kernel: [<ffffffff812d8bcb>] dump_stack+0x4f/0x74 Oct 2 20:59:18 ph4 kernel: [<ffffffff8105d378>] __warn+0xd8/0x100 Oct 2 20:59:18 ph4 kernel: [<ffffffff8105d458>] warn_slowpath_null+0x18/0x20 Oct 2 20:59:18 ph4 kernel: [<ffffffffa015ce7a>] drm_vblank_put+0xaa/0xb0 [drm] Oct 2 20:59:18 ph4 kernel: [<ffffffffa015ce92>] drm_crtc_vblank_put+0x12/0x20 [drm] Oct 2 20:59:18 ph4 kernel: [<ffffffffa0177357>] drm_mode_page_flip_ioctl+0x1c7/0x4a0 [drm] Oct 2 20:59:18 ph4 kernel: [<ffffffffa015ba98>] drm_ioctl+0x218/0x510 [drm] Oct 2 20:59:18 ph4 kernel: [<ffffffffa0177190>] ? drm_mode_cursor2_ioctl+0x10/0x10 [drm] Oct 2 20:59:18 ph4 kernel: [<ffffffff811a4d70>] ? do_readv_writev+0x130/0x220 Oct 2 20:59:18 ph4 kernel: [<ffffffff8108127c>] ? preempt_count_add+0x7c/0xc0 Oct 2 20:59:18 ph4 kernel: [<ffffffff810812a3>] ? preempt_count_add+0xa3/0xc0 Oct 2 20:59:18 ph4 kernel: [<ffffffff815a9313>] ? _raw_write_unlock_irqrestore+0x13/0x30 Oct 2 20:59:18 ph4 kernel: [<ffffffff815a9339>] ? _raw_spin_unlock_irqrestore+0x9/0x10 Oct 2 20:59:18 ph4 kernel: [<ffffffffa035d054>] amdgpu_drm_ioctl+0x54/0x90 [amdgpu] Oct 2 20:59:18 ph4 kernel: [<ffffffff811b7e58>] do_vfs_ioctl+0x98/0x5b0 Oct 2 20:59:18 ph4 kernel: [<ffffffff811c2892>] ? __fget+0x72/0xa0 Oct 2 20:59:18 ph4 kernel: [<ffffffff811b83b7>] SyS_ioctl+0x47/0x80 Oct 2 20:59:18 ph4 kernel: [<ffffffff815a979f>] entry_SYSCALL_64_fastpath+0x17/0x93 Oct 2 20:59:18 ph4 kernel: ---[ end trace 24b073819e664cb0 ]--- Oct 2 20:59:18 ph4 kernel: ------------[ cut here ]------------ -- You are receiving this mail because: You are the assignee for the bug.

1 5

[PATCH] drm: simple_kms_helper: Handle the vblank events
by Marek Vasut 04 Oct '16

04 Oct '16

Handle the vblank events in the simple_kms_helper driver, otherwise the drm_atomic_helper flip_done event never happens. Signed-off-by: Marek Vasut <marex(a)denx.de> Cc: Noralf Trønnes <noralf(a)tronnes.org> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: David Airlie <airlied(a)linux.ie> --- drivers/gpu/drm/drm_simple_kms_helper.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c b/drivers/gpu/drm/drm_simple_kms_helper.c index 7b6d26e..3345b40 100644 --- a/drivers/gpu/drm/drm_simple_kms_helper.c +++ b/drivers/gpu/drm/drm_simple_kms_helper.c @@ -34,6 +34,23 @@ static const struct drm_encoder_funcs drm_simple_kms_encoder_funcs = { .destroy = drm_encoder_cleanup, }; +static void drm_simple_kms_crtc_begin(struct drm_crtc *crtc, + struct drm_crtc_state *state) +{ + struct drm_pending_vblank_event *event = crtc->state->event; + + if (event) { + crtc->state->event = NULL; + + spin_lock_irq(&crtc->dev->event_lock); + if (drm_crtc_vblank_get(crtc) == 0) + drm_crtc_arm_vblank_event(crtc, event); + else + drm_crtc_send_vblank_event(crtc, event); + spin_unlock_irq(&crtc->dev->event_lock); + } +} + static int drm_simple_kms_crtc_check(struct drm_crtc *crtc, struct drm_crtc_state *state) { @@ -63,6 +80,7 @@ static void drm_simple_kms_crtc_disable(struct drm_crtc *crtc) } static const struct drm_crtc_helper_funcs drm_simple_kms_crtc_helper_funcs = { + .atomic_begin = drm_simple_kms_crtc_begin, .atomic_check = drm_simple_kms_crtc_check, .disable = drm_simple_kms_crtc_disable, .enable = drm_simple_kms_crtc_enable, -- 2.9.3

3 14

[PATCH] drm/atomic-helper: add unlocked disable all outputs helper
by Lucas Stach 04 Oct '16

04 Oct '16

This adds the unlocked variant of drm_atomic_helper_disable_all(), which takes all the required modeset locks itself. This is intended to be used when shutting down the driver, without retaining any state. Signed-off-by: Lucas Stach <l.stach(a)pengutronix.de> --- drivers/gpu/drm/drm_atomic_helper.c | 43 +++++++++++++++++++++++++++++++++++++ include/drm/drm_atomic_helper.h | 1 + 2 files changed, 44 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 99365087645b..6673021ab21e 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -2435,6 +2435,49 @@ free: EXPORT_SYMBOL(drm_atomic_helper_disable_all); /** + * drm_atomic_helper_disable_all_unlocked - disable all currently active + * outputs taking the modeset locks itself + * @dev: DRM device + * + * Loops through all connectors, finding those that aren't turned off and then + * turns them off by setting their DPMS mode to OFF and deactivating the CRTC + * that they are connected to. + * + * This is used for example when shutting down the DRM device. + * + * Returns: + * 0 on success or a negative error code on failure. + */ +int drm_atomic_helper_disable_all_unlocked(struct drm_device *dev) +{ + struct drm_modeset_acquire_ctx ctx; + int err; + + drm_modeset_acquire_init(&ctx, 0); + +retry: + err = drm_modeset_lock_all_ctx(dev, &ctx); + if (err < 0) + goto unlock; + + err = drm_atomic_helper_disable_all(dev, &ctx); + if (err < 0) + goto unlock; + +unlock: + if (err == -EDEADLK) { + drm_modeset_backoff(&ctx); + goto retry; + } + + drm_modeset_drop_locks(&ctx); + drm_modeset_acquire_fini(&ctx); + + return err; +} +EXPORT_SYMBOL(drm_atomic_helper_disable_all_unlocked); + +/** * drm_atomic_helper_suspend - subsystem-level suspend helper * @dev: DRM device * diff --git a/include/drm/drm_atomic_helper.h b/include/drm/drm_atomic_helper.h index d86ae5dcd7b4..104d310c2c70 100644 --- a/include/drm/drm_atomic_helper.h +++ b/include/drm/drm_atomic_helper.h @@ -99,6 +99,7 @@ int __drm_atomic_helper_set_config(struct drm_mode_set *set, int drm_atomic_helper_disable_all(struct drm_device *dev, struct drm_modeset_acquire_ctx *ctx); +int drm_atomic_helper_disable_all_unlocked(struct drm_device *dev); struct drm_atomic_state *drm_atomic_helper_suspend(struct drm_device *dev); int drm_atomic_helper_resume(struct drm_device *dev, struct drm_atomic_state *state); -- 2.8.1

3 2

[PATCH v2 0/4] Misc changes to Rockchip PSR drivers
by zain wang 04 Oct '16

04 Oct '16

1. prevent runing enable_psr when disabled bridge 2. get sync PM when init eDP 3. detect Sink PSR state after configuring the PSR 4. switch Main-Link and eDP phy when enable/disable psr BR, - Zain Changes in v2: - add spin_lock to protect dpms_mode - misc changes Yakir Yang (1): drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR zain wang (3): drm/bridge: analogix_dp: prevent runing enable_psr when disabled bridge. drm/bridge: analogix_dp: get sync PM when init eDP drm: bridge/analogix: switch Main-link and eDP PHY when enable/disable psr drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 137 ++++++++++++++------- drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 7 +- drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 25 +++- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 8 +- 4 files changed, 125 insertions(+), 52 deletions(-) -- 1.9.1

2 3

[Bug 98037] HD6450 KMS failure
by bugzilla-daemon＠freedesktop.org 04 Oct '16

04 Oct '16

https://bugs.freedesktop.org/show_bug.cgi?id=98037 --- Comment #5 from Alex Deucher <alexdeucher(a)gmail.com> --- (In reply to Will Lewis from comment #4) > The error occurs before I even get to X. This machine boots to a console > login screen, at which point I login and potentially start X. However, > during the initial boot, I get kernel output until the radeon module gets > loaded, at which point the screen goes blank and tells me it has no signal. > > Do you want me to try to start X in the dark, so to speak, and grab the log > after rebooting? Yes please. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 98037] HD6450 KMS failure
by bugzilla-daemon＠freedesktop.org 04 Oct '16

04 Oct '16

https://bugs.freedesktop.org/show_bug.cgi?id=98037 --- Comment #4 from Will Lewis <minutemaidpark(a)hotmail.com> --- The error occurs before I even get to X. This machine boots to a console login screen, at which point I login and potentially start X. However, during the initial boot, I get kernel output until the radeon module gets loaded, at which point the screen goes blank and tells me it has no signal. Do you want me to try to start X in the dark, so to speak, and grab the log after rebooting? -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 98037] HD6450 KMS failure
by bugzilla-daemon＠freedesktop.org 04 Oct '16

04 Oct '16

https://bugs.freedesktop.org/show_bug.cgi?id=98037 --- Comment #3 from Alex Deucher <alexdeucher(a)gmail.com> --- Please attach your xorg log as well. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH v3 0/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels
by Peter Rosin 04 Oct '16

04 Oct '16

Hi! I'm back with a new attempt at getting this panel upstream. This time with the bindings in a separate commit, as I hear that is preferred. I think I covered all the pins on the panel... Cheers, Peter Gustaf Lindström (1): drm/panel: simple: add support for Sharp LQ150X1LG11 panels Peter Rosin (1): dt-bindings: display: Add Sharp LQ150X1LG11 panel binding .../bindings/display/panel/sharp,lq150x1lg11.txt | 36 ++++++++++++++++++++++ drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++ 2 files changed, 63 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt -- 2.1.4

2 5

[PATCH v8 0/4] New debugfs API for capturing CRC of frames
by Tomeu Vizoso 04 Oct '16

04 Oct '16

Hi, this series basically takes the facility for continuously capturing CRCs of frames from the i915 driver and into the DRM core. The idea is that test suites such as IGT use this information to check that frames that are exected to be identical, also have identical CRC values. Other drivers for hardware that can provide frame CRCs (including eDP panels that support self-refresh) can easily implement the new callback and provide userspace with the CRC values. Thanks, Tomeu Tomeu Vizoso (4): drm/i915/debugfs: Move out pipe CRC code drm: Add API for capturing frame CRCs drm/i915: Use new CRC debugfs API drm/i915: Put "cooked" vlank counters in frame CRC lines Documentation/gpu/drm-uapi.rst | 6 + drivers/gpu/drm/Makefile | 3 +- drivers/gpu/drm/drm_crtc.c | 29 +- drivers/gpu/drm/drm_debugfs.c | 34 +- drivers/gpu/drm/drm_debugfs_crc.c | 351 ++++++++++++ drivers/gpu/drm/drm_drv.c | 19 + drivers/gpu/drm/drm_internal.h | 16 + drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 886 +--------------------------- drivers/gpu/drm/i915/i915_drv.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 3 +- drivers/gpu/drm/i915/i915_irq.c | 83 ++- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 7 + drivers/gpu/drm/i915/intel_pipe_crc.c | 1014 +++++++++++++++++++++++++++++++++ include/drm/drm_crtc.h | 41 ++ include/drm/drm_debugfs_crc.h | 73 +++ 17 files changed, 1656 insertions(+), 914 deletions(-) create mode 100644 drivers/gpu/drm/drm_debugfs_crc.c create mode 100644 drivers/gpu/drm/i915/intel_pipe_crc.c create mode 100644 include/drm/drm_debugfs_crc.h -- 2.7.4

4 9

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel October 2016