dri-devel February 2016

dri-devel@lists.freedesktop.org

180 participants
1240 discussions

linux-next: build failure after merge of the drm-misc tree
by Stephen Rothwell 10 Feb '16

10 Feb '16

Hi all, After merging the drm-misc tree, today's linux-next build (arm multi_v7_defconfig) failed like this: In file included from drivers/gpu/drm/nouveau/nouveau_drm.c:25:0: include/linux/apple-gmux.h: In function 'apple_gmux_present': include/linux/apple-gmux.h:36:42: error: implicit declaration of function 'acpi_dev_present' [-Werror=implicit-function-declaration] return IS_ENABLED(CONFIG_APPLE_GMUX) && acpi_dev_present(GMUX_ACPI_HID); ^ Caused by commit 2413306c2566 ("apple-gmux: Add helper for presence detect") I have used the drm-misc tree from next-20160209 for today. -- Cheers, Stephen Rothwell

3 4

[PATCH 00/12] drm/tilcdc: fixes and added features from TI tree
by Jyri Sarha 10 Feb '16

10 Feb '16

Most of these patches are quite old and they have been used in TI linux for some time already. I forward ported the applicaple patches from TI tree on top of the latest drm-next, fixed checkpatch issues and tested the driver. Darren Etheridge (8): drm/tilcdc: disable console switching during pm operations drm/tilcdc: rewrite pixel clock calculation drm/tilcdc: fix kernel panic on suspend when no hdmi monitor connected drm/tilcdc: make frame_done interrupt active at all times drm/tilcdc: disable the lcd controller/dma engine when suspend invoked drm/tilcdc: fix the ping-pong dma tearing issue seen on buffer flipping drm/tilcdc: correct the dmachannel tracking logic drm/tilcdc: make frame completion interrupt always enabled Dave Gerlach (1): drm/tilcdc: adopt pinctrl support Grygorii Strashko (1): drm/tilcdc: fix build error when !CONFIG_CPU_FREQ Jyri Sarha (1): drm/tilcdc: Implement dma-buf support for tilcdc Tomi Valkeinen (1): drm/tilcdc: verify fb pitch drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 91 +++++++++++++++++++++++++++------- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 94 +++++++++++++++++++++--------------- drivers/gpu/drm/tilcdc/tilcdc_drv.h | 3 +- 3 files changed, 129 insertions(+), 59 deletions(-) -- 1.9.1

3 16

[Bug 35457] [rs690m] Graphics corruption with ati x1200
by bugzilla-daemon＠freedesktop.org 10 Feb '16

10 Feb '16

1 0

[Bug 35457] [rs690m] Graphics corruption with ati x1200
by bugzilla-daemon＠freedesktop.org 10 Feb '16

10 Feb '16

https://bugs.freedesktop.org/show_bug.cgi?id=35457 --- Comment #104 from Micha <m.st(a)mailbox.org> --- News? LOL -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH] drm: fixes crct set_mode when encoder mode_fixup is null.
by Carlos Palminha 10 Feb '16

10 Feb '16

Avoids null crash when encoders don't implement mode_fixup. Signed-off-by: Carlos Palminha <palminha(a)synopsys.com> --- drivers/gpu/drm/drm_crtc_helper.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index a02a7f9..ef3def7 100644 --- a/drivers/gpu/drm/drm_crtc_helper.c +++ b/drivers/gpu/drm/drm_crtc_helper.c @@ -328,10 +328,12 @@ bool drm_crtc_helper_set_mode(struct drm_crtc *crtc, } encoder_funcs = encoder->helper_private; - if (!(ret = encoder_funcs->mode_fixup(encoder, mode, - adjusted_mode))) { - DRM_DEBUG_KMS("Encoder fixup failed\n"); - goto done; + if (encoder_funcs->mode_fixup) { + if (!(ret = encoder_funcs->mode_fixup(encoder, mode, + adjusted_mode))) { + DRM_DEBUG_KMS("Encoder fixup failed\n"); + goto done; + } } } -- 2.5.0

2 3

[PATCH] drm: fixes when i2c encoder slave mode_fixup is null.
by Carlos Palminha 10 Feb '16

10 Feb '16

Avoid i2c slave encoder drivers to copy/paste code to implement functions that will only return true. Signed-off-by: Carlos Palminha <palminha(a)synopsys.com> --- drivers/gpu/drm/drm_encoder_slave.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_encoder_slave.c b/drivers/gpu/drm/drm_encoder_slave.c index e862907..418b94c 100644 --- a/drivers/gpu/drm/drm_encoder_slave.c +++ b/drivers/gpu/drm/drm_encoder_slave.c @@ -140,6 +140,8 @@ bool drm_i2c_encoder_mode_fixup(struct drm_encoder *encoder, const struct drm_display_mode *mode, struct drm_display_mode *adjusted_mode) { + if(!get_slave_funcs(encoder)->mode_fixup) + return true; return get_slave_funcs(encoder)->mode_fixup(encoder, mode, adjusted_mode); } EXPORT_SYMBOL(drm_i2c_encoder_mode_fixup); -- 2.5.0

3 3

[PATCH] drm: fixes when bridge mode_fixup is null.
by Carlos Palminha 10 Feb '16

10 Feb '16

Avoid drivers to copy/past code to implement functions that will only return true. --- drivers/gpu/drm/drm_bridge.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index bd93453..4133e51 100644 --- a/drivers/gpu/drm/drm_bridge.c +++ b/drivers/gpu/drm/drm_bridge.c @@ -161,6 +161,8 @@ bool drm_bridge_mode_fixup(struct drm_bridge *bridge, if (bridge->funcs->mode_fixup) ret = bridge->funcs->mode_fixup(bridge, mode, adjusted_mode); + else + return true; ret = ret && drm_bridge_mode_fixup(bridge->next, mode, adjusted_mode); -- 2.5.0

3 4

[PATCH] adv7511: Added mode_fixup function.
by Carlos Palminha 10 Feb '16

10 Feb '16

The mode_fixup is necessary when using it in a DRM FB driver pipeline. Signed-off-by: Carlos Palminha <palminha(a)synopsys.com> --- drivers/gpu/drm/i2c/adv7511.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i2c/adv7511.c b/drivers/gpu/drm/i2c/adv7511.c index 533d1e3..90082d2 100644 --- a/drivers/gpu/drm/i2c/adv7511.c +++ b/drivers/gpu/drm/i2c/adv7511.c @@ -648,6 +648,13 @@ adv7511_encoder_detect(struct drm_encoder *encoder, return status; } +static bool adv7511_encoder_mode_fixup(struct drm_encoder *encoder, + const struct drm_display_mode *mode, + struct drm_display_mode *adjusted_mode) +{ + return true; +} + static int adv7511_encoder_mode_valid(struct drm_encoder *encoder, struct drm_display_mode *mode) { @@ -754,6 +761,7 @@ static void adv7511_encoder_mode_set(struct drm_encoder *encoder, static const struct drm_encoder_slave_funcs adv7511_encoder_funcs = { .dpms = adv7511_encoder_dpms, + .mode_fixup = adv7511_encoder_mode_fixup, .mode_valid = adv7511_encoder_mode_valid, .mode_set = adv7511_encoder_mode_set, .detect = adv7511_encoder_detect, -- 2.5.0

4 7

ttm_bo_add_to_lru mystery
by Michel Dänzer 10 Feb '16

10 Feb '16

I recently came to realize that nothing seems to be ensuring that BOs which are unpinned in the amdgpu/radeon drivers get added to the TTM LRU list. I thought that should be easy enough to fix, but I ran into an issue that has me scratching my head. See the attached patch for the current debugging state, and the corresponding dmesg output below. The BO's lru member is considered empty (i.e. it's not hooked up to the LRU list) in radeon_bo_unpin, as expected. However, calling ttm_bo_add_to_lru in that case, the lru member is suddenly not considered empty (i.e. it seems to be hooked up to the LRU list, which would normally trigger the BUG_ON). And indeed, the prev/next pointers are different between the two functions. But I have no idea how they could be modified between those two points, or why else they would be seeing different values... *Any* ideas for what might be going on here would be much appreciated. [ 5.043993] &bo->tbo.lru=ffff88007c0d1918, bo->tbo.lru.prev=ffff88007c0d1918, bo->tbo.lru.next=ffff88007c0d1918 [ 5.043996] ------------[ cut here ]------------ [ 5.044004] WARNING: CPU: 3 PID: 117 at drivers/gpu/drm//ttm/ttm_bo.c:173 ttm_bo_add_to_lru+0x145/0x150 [ttm]() [ 5.044005] Modules linked in: hid_generic usbhid hid cpufreq_stats binfmt_misc cpufreq_powersave cpufreq_userspace cpufreq_conservative kvm_amd kvm irqbypass crct10dif_pclmul crc32_pclmul crc32c_intel nls_utf8 nls_cp437 vfat fat radeon(O) sha256_ssse3 sha256_generic hmac drbg ansi_cprng eeepc_wmi asus_wmi sparse_keymap rfkill evdev efi_pstore aesni_intel aes_x86_64 lrw gf128mul glue_helper ablk_helper cryptd edac_mce_amd r8169 psmouse pcspkr serio_raw snd_hda_codec_realtek snd_hda_codec_generic edac_core mii amdkfd efivars k10temp fam15h_power snd_hda_codec_hdmi amdgpu(O) ohci_pci ttm(O) snd_hda_intel xhci_pci snd_hda_codec drm_kms_helper i2c_piix4 snd_hda_core xhci_hcd drm snd_hwdep ehci_pci ohci_hcd ehci_hcd snd_pcm i2c_algo_bit sg usbcore snd_timer snd usb_common soundcore shpchp 8250_fintek [ 5.044037] wmi acpi_cpufreq video tpm_tis tpm button processor efivarfs autofs4 ext4 crc16 mbcache jbd2 dm_mod sd_mod ahci libahci libata scsi_mod [ 5.044047] CPU: 3 PID: 117 Comm: kworker/u8:7 Tainted: G W O 4.4.0+ #193 [ 5.044048] Hardware name: System manufacturer System Product Name/A88X-PRO, BIOS 1602 12/04/2014 [ 5.044066] Workqueue: radeon-crtc radeon_unpin_work_func [radeon] [ 5.044068] 0000000000000000 0000000031d3b9d6 ffff88022407bd80 ffffffff813030f4 [ 5.044070] 0000000000000000 ffff88022407bdb8 ffffffff8107a332 ffff88007c0d1868 [ 5.044071] ffff88007c0d1918 ffff88007c0d1800 ffff88007c0d1868 ffff880224cf1320 [ 5.044073] Call Trace: [ 5.044078] [<ffffffff813030f4>] dump_stack+0x44/0x60 [ 5.044080] [<ffffffff8107a332>] warn_slowpath_common+0x82/0xc0 [ 5.044082] [<ffffffff8107a47a>] warn_slowpath_null+0x1a/0x20 [ 5.044085] [<ffffffffa03260d5>] ttm_bo_add_to_lru+0x145/0x150 [ttm] [ 5.044096] [<ffffffffa073e87b>] radeon_unpin_work_func+0x8b/0x1a0 [radeon] [ 5.044098] [<ffffffff81092443>] process_one_work+0x1a3/0x3d0 [ 5.044099] [<ffffffff810926be>] worker_thread+0x4e/0x460 [ 5.044101] [<ffffffff81092670>] ? process_one_work+0x3d0/0x3d0 [ 5.044102] [<ffffffff81098848>] kthread+0xd8/0xf0 [ 5.044104] [<ffffffff81098770>] ? kthread_create_on_node+0x190/0x190 [ 5.044107] [<ffffffff815b5a4f>] ret_from_fork+0x3f/0x70 [ 5.044108] [<ffffffff81098770>] ? kthread_create_on_node+0x190/0x190 [ 5.044109] ---[ end trace 64028355474e8bbe ]--- [ 5.044110] [TTM] &bo->lru=ffff88007c0d1918, bo->lru.prev=ffff88007dcb6d18, bo->lru.next=ffff880220a748e8 -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

1 1

PROBLEM: Intel HDMI output busticated on 4.4 (regression)
by Nick Bowler 10 Feb '16

10 Feb '16

Hi, Upgrading from 4.3 to 4.4 breaks my HDMI output on my G45 machine. As soon as the intel driver is loaded, the monitor shuts off (standby mode). Inspecting /sys/class/drm/card0-HDMI-A-1/status reports "disconnected". When it is working, this attribute says "connected". There is nothing unusual printed to dmesg. Bisection pinpoints the following: 237ed86c693d8a8e4db476976aeb30df4deac74b is the first bad commit commit 237ed86c693d8a8e4db476976aeb30df4deac74b Author: Sonika Jindal <sonika.jindal(a)intel.com> Date: Tue Sep 15 09:44:20 2015 +0530 drm/i915: Check live status before reading edid [...] Signed-off-by: Shashank Sharma <shashank.sharma(a)intel.com> Signed-off-by: Sonika Jindal <sonika.jindal(a)intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.vivi(a)intel.com> Signed-off-by: Daniel Vetter <daniel.vetter(a)ffwll.ch> The commit does not revert cleanly, but this patch resolves the issue: diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index e6c035b0fc1c..8cefb9105f26 100644 --- a/drivers/gpu/drm/i915/intel_hdmi.c +++ b/drivers/gpu/drm/i915/intel_hdmi.c @@ -1393,7 +1393,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool force) intel_hdmi_unset_edid(connector); - if (intel_hdmi_set_edid(connector, live_status)) { + if (intel_hdmi_set_edid(connector, true)) { struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector); hdmi_to_dig_port(intel_hdmi)->base.type = INTEL_OUTPUT_HDMI; Let me know if you need any more info. Thanks, Nick

5 14

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel February 2016