dri-devel June 2016

dri-devel@lists.freedesktop.org

231 participants
1446 discussions

[PATCH] drm: hdlcd: Unwind the DRM setup on error conditions in the right order.
by Liviu Dudau 13 Jun '16

13 Jun '16

In hdlcd_drm_bind()/hdlcd_drm_unbind() we unwind the DRM setup in the wrong order (drm_mode_config_cleanup() before connector and encoder had a chance to cleanup their memory or before drm_dev_unregister()). The correct order should match in both functions. Reported-by: Robin Murphy <Robin.Murphy(a)arm.com> Signed-off-by: Liviu Dudau <Liviu.Dudau(a)arm.com> --- Robin, I believe this should fix your problems with HDLCD failing to allocate CMA memory and then crashing. Best … [View More]

2 2

[RESENT PATCH] bochs: ignore device if there isn't enougth memory
by Gerd Hoffmann 13 Jun '16

13 Jun '16

The qemu stdvga can be configured with a wide range of video memory, from 1 MB to 256 MB (default is 16 MB). In case it is configured with only 1 or 2 MB it isn't really usable with bochsdrm, due to depths other than 32bpp not being supported so that isn't enough memory for a reasonable sized framebuffer. So skip the device and let vgacon or vesafb+fbcon handle the it. Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> --- drivers/gpu/drm/bochs/bochs_drv.c | 7 +++++++ 1 file changed, … [View More]

1 0

[Bug 119991] New: Screen is corrupt upon resume from hybrid-sleep with Radeon HD5xxx cards
by bugzilla-daemon＠bugzilla.kernel.org 13 Jun '16

13 Jun '16

https://bugzilla.kernel.org/show_bug.cgi?id=119991 Bug ID: 119991 Summary: Screen is corrupt upon resume from hybrid-sleep with Radeon HD5xxx cards Product: Drivers Version: 2.5 Kernel Version: 4.6.1 Hardware: x86-64 OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: … [View More]

1 4

[[RESEND][PATCH v2] 2/2] dt-bindings: Add jdi lt070me05000 panel bindings
by Vinay Simha BN 13 Jun '16

13 Jun '16

Add documentation for lt070me05000 panel Cc: Archit Taneja <archit.taneja(a)gmail.com> Cc: John Stultz <john.stultz(a)linaro.org> Cc: Thierry Reding <thierry.reding(a)gmail.com> Cc: Sumit Semwal <sumit.semwal(a)linaro.org> Signed-off-by: Vinay Simha BN <simhavcs(a)gmail.com> Acked-by: Rob Herring <robh(a)kernel.org> -- v2: * incorporated rob herring and thierry reviews gpio to gpios, gpio to regulator using fixed regulators and pwm backlight is … [View More]removed, since it is controlled by dcs commands --- .../bindings/display/panel/jdi,lt070me05000.txt | 57 ++++++++++++++++++++++ 1 file changed, 57 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.txt diff --git a/Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.txt b/Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.txt new file mode 100644 index 0000000..613b76f --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.txt @@ -0,0 +1,57 @@ +JDI model LT070ME05000 1200x1920 7" DSI Panel + +Required properties: +- compatible: should be "jdi,lt070me05000" +- vddp-supply: phandle of the regulator that provides the supply voltage + Power IC supply (3-5V) +- dcdc_en-supply: phandle of the regulator that provides the supply voltage + Power IC supply enable, High active +- vcc-supply: phandle of the regulator that provides the supply voltage + IOVCC , power supply for LCM (1.8V) +- reset-gpios: phandle of gpio for reset line + This should be 8mA, gpio can be configured using mux, pinctrl, pinctrl-names + XRES, Reset, Low active +- enable-gpios: phandle of gpio for enable line + LED_EN, LED backlight enable, High active + +Example: + + vcc_1p8v: regulator-fixed@2 { + compatible = "regulator-fixed"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-name = "vcc_1p8v"; + regulator-type = "voltage"; + startup-delay-us = <0>; + gpio = <&pm8921_gpio 23 GPIO_ACTIVE_HIGH>; + enable-active-high; + regulator-boot-on; + }; + + tlmm_pinmux: pinctrl@800000 { + + dsi_panel_pinctrl: dsi-panel-pinctrl { + mux { + pins = "gpio54"; + function = "gpio"; + bias-pull-up; + drive-strength = <8>; + }; + }; + }; + + dsi0: qcom,mdss_dsi@4700000 { + panel@0 { + compatible = "jdi,lt070me05000"; + reg = <0>; + pinctrl-names = "default"; + pinctrl-0 = <&dsi_panel_pinctrl>; + + vddp-supply = <&pm8921_l17>; + dcdc_en-supply = <&pm8921_lvs7>; + vcc-supply = <&vcc_1p8v>; + + reset-gpios = <&tlmm_pinmux 54 0>; + enable-gpios = <&pm8921_gpio 36 GPIO_ACTIVE_HIGH>; + }; + }; -- 1.9.1 [View Less]

2 1

[Bug 114711] New: ubsan: "shift exponent 32 is too large" in drivers/gpu/drm/nouveau/nvkm/subdev/gpio/base.c:167:16
by bugzilla-daemon＠bugzilla.kernel.org 13 Jun '16

13 Jun '16

https://bugzilla.kernel.org/show_bug.cgi?id=114711 Bug ID: 114711 Summary: ubsan: "shift exponent 32 is too large" in drivers/gpu/drm/nouveau/nvkm/subdev/gpio/base.c:167:16 Product: Drivers Version: 2.5 Kernel Version: 4.5.0 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) … [View More] Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: peter(a)arbitrary.ch Regression: No The following message appeared during boot. Let me know if you need more information. Mar 15 12:09:22 ivy kernel: ================================================================================ Mar 15 12:09:22 ivy kernel: UBSAN: Undefined behaviour in drivers/gpu/drm/nouveau/nvkm/subdev/gpio/base.c:167:16 Mar 15 12:09:22 ivy kernel: shift exponent 32 is too large for 32-bit type 'int' Mar 15 12:09:22 ivy kernel: CPU: 3 PID: 546 Comm: systemd-udevd Not tainted 4.5.0-pege1 #1 Mar 15 12:09:22 ivy kernel: Hardware name: Hewlett-Packard HP ENVY dv6 Notebook PC/181B, BIOS F.29 10/03/2013 Mar 15 12:09:22 ivy kernel: 0000000000000000 000000000f597554 ffffffff816fcef7 0000000000000020 Mar 15 12:09:22 ivy kernel: 000000000f597554 ffff88044999f640 ffff88044999f6c8 ffffffff817952a9 Mar 15 12:09:22 ivy kernel: ffffffffc210dc40 ffffffff81795caa 0000000000000202 0000000fff003233 Mar 15 12:09:22 ivy kernel: Call Trace: Mar 15 12:09:22 ivy kernel: [<ffffffff816fcef7>] ? dump_stack+0x70/0xb9 Mar 15 12:09:22 ivy kernel: [<ffffffff817952a9>] ? ubsan_epilogue+0x9/0x40 Mar 15 12:09:22 ivy kernel: [<ffffffff81795caa>] ? __ubsan_handle_shift_out_of_bounds+0xfa/0x150 Mar 15 12:09:22 ivy kernel: [<ffffffff8111ee4e>] ? flush_work+0x2e/0x270 Mar 15 12:09:22 ivy kernel: [<ffffffffc1df0031>] ? gk104_ram_new+0x2161/0x24a0 [nouveau] Mar 15 12:09:22 ivy kernel: [<ffffffffc1df3cab>] ? nvkm_gpio_fini+0x10b/0x1f0 [nouveau] Mar 15 12:09:22 ivy kernel: [<ffffffffc1d4b31e>] ? nvkm_subdev_fini+0x9e/0x4d0 [nouveau] Mar 15 12:09:22 ivy kernel: [<ffffffff811edcdc>] ? ktime_get+0x7c/0x220 Mar 15 12:09:22 ivy kernel: [<ffffffffc1e37960>] ? nvkm_device_fini+0x80/0x340 [nouveau] Mar 15 12:09:22 ivy kernel: [<ffffffffc1e37d27>] ? nvkm_device_init+0x107/0x4f0 [nouveau] Mar 15 12:09:22 ivy kernel: [<ffffffffc1e402aa>] ? nvkm_udevice_init+0x6a/0x110 [nouveau] Mar 15 12:09:22 ivy kernel: [<ffffffffc1d48178>] ? nvkm_object_init+0x78/0x4a0 [nouveau] Mar 15 12:09:22 ivy kernel: [<ffffffffc1d431a6>] ? nvkm_ioctl_new+0x206/0x740 [nouveau] Mar 15 12:09:22 ivy kernel: [<ffffffffc1d3e4eb>] ? nvkm_client_new+0xbb/0x160 [nouveau] Mar 15 12:09:22 ivy kernel: [<ffffffffc1d3d4a0>] ? nvkm_client_notify+0xe0/0xe0 [nouveau] Mar 15 12:09:22 ivy kernel: [<ffffffffc1e40630>] ? nvkm_udevice_rd08+0x80/0x80 [nouveau] Mar 15 12:09:22 ivy kernel: [<ffffffffc1d43a86>] ? nvkm_ioctl+0x226/0x6b0 [nouveau] Mar 15 12:09:22 ivy kernel: [<ffffffff819c6b8a>] ? bus_find_device+0xaa/0x120 Mar 15 12:09:22 ivy kernel: [<ffffffffc1d3bda0>] ? nvif_object_init+0x130/0x380 [nouveau] Mar 15 12:09:22 ivy kernel: [<ffffffffc1d3c68e>] ? nvif_device_init+0xe/0x50 [nouveau] Mar 15 12:09:22 ivy kernel: [<ffffffffc1f114fb>] ? nouveau_drm_load+0x21b/0x1490 [nouveau] Mar 15 12:09:22 ivy kernel: [<ffffffff81dfb2e4>] ? _raw_spin_unlock+0x34/0x80 Mar 15 12:09:22 ivy kernel: [<ffffffff817afcc2>] ? pci_bus_read_config_word+0xb2/0x100 Mar 15 12:09:22 ivy kernel: [<ffffffff81dfb372>] ? _raw_spin_unlock_irqrestore+0x42/0x80 Mar 15 12:09:22 ivy kernel: [<ffffffffc0eb7b49>] ? drm_dev_register+0xb9/0x110 [drm] Mar 15 12:09:22 ivy kernel: [<ffffffffc0ebe62b>] ? drm_get_pci_dev+0xbb/0x640 [drm] Mar 15 12:09:22 ivy kernel: [<ffffffff817be01e>] ? __pci_set_master+0x4e/0x190 Mar 15 12:09:22 ivy kernel: [<ffffffffc1f107af>] ? nouveau_drm_probe+0x40f/0x780 [nouveau] Mar 15 12:09:22 ivy kernel: [<ffffffffc1f103a0>] ? nouveau_pmops_runtime_idle+0x2e0/0x2e0 [nouveau] Mar 15 12:09:22 ivy kernel: [<ffffffff817c90ab>] ? local_pci_probe+0x6b/0x140 Mar 15 12:09:22 ivy kernel: [<ffffffff817cc259>] ? pci_device_probe+0x149/0x1b0 Mar 15 12:09:22 ivy kernel: [<ffffffff819cb562>] ? driver_probe_device+0x1b2/0xcb0 Mar 15 12:09:22 ivy kernel: [<ffffffff819cc060>] ? driver_probe_device+0xcb0/0xcb0 Mar 15 12:09:22 ivy kernel: [<ffffffff819cc132>] ? __driver_attach+0xd2/0x180 Mar 15 12:09:22 ivy kernel: [<ffffffff819c688c>] ? bus_for_each_dev+0x8c/0x110 Mar 15 12:09:22 ivy kernel: [<ffffffff81de27fd>] ? klist_add_tail+0x3d/0x100 Mar 15 12:09:22 ivy kernel: [<ffffffff819c9be4>] ? bus_add_driver+0x2b4/0x570 Mar 15 12:09:22 ivy kernel: [<ffffffffc2382000>] ? 0xffffffffc2382000 Mar 15 12:09:22 ivy kernel: [<ffffffff819cd9b3>] ? driver_register+0xf3/0x2f0 Mar 15 12:09:22 ivy kernel: [<ffffffff81002142>] ? do_one_initcall+0xd2/0x290 Mar 15 12:09:22 ivy kernel: [<ffffffff8132a6b8>] ? do_init_module+0xf1/0x366 Mar 15 12:09:22 ivy kernel: [<ffffffff81214f28>] ? load_module+0x33a8/0x62f0 Mar 15 12:09:22 ivy kernel: [<ffffffff8120e5b0>] ? __symbol_put+0x90/0x90 Mar 15 12:09:22 ivy kernel: [<ffffffff8120c675>] ? copy_module_from_fd+0x125/0x210 Mar 15 12:09:22 ivy kernel: [<ffffffff8121805a>] ? SYSC_finit_module+0x8a/0xc0 Mar 15 12:09:22 ivy kernel: [<ffffffff81dfbcf6>] ? entry_SYSCALL_64_fastpath+0x16/0x75 Mar 15 12:09:22 ivy kernel: ================================================================================ Mar 15 12:09:22 ivy kernel: nouveau 0000:01:00.0: fb: 1024 MiB DDR3 Mar 15 12:09:22 ivy kernel: vga_switcheroo: enabled Mar 15 12:09:22 ivy kernel: [TTM] Zone kernel: Available graphics memory: 8149734 kiB Mar 15 12:09:22 ivy kernel: [TTM] Zone dma32: Available graphics memory: 2097152 kiB Mar 15 12:09:22 ivy kernel: [TTM] Initializing pool allocator Mar 15 12:09:22 ivy kernel: [TTM] Initializing DMA pool allocator Mar 15 12:09:22 ivy kernel: nouveau 0000:01:00.0: DRM: VRAM: 1024 MiB Mar 15 12:09:22 ivy kernel: nouveau 0000:01:00.0: DRM: GART: 1048576 MiB Mar 15 12:09:22 ivy kernel: nouveau 0000:01:00.0: DRM: TMDS table version 2.0 Mar 15 12:09:22 ivy kernel: nouveau 0000:01:00.0: DRM: DCB version 4.0 Mar 15 12:09:22 ivy kernel: nouveau 0000:01:00.0: DRM: DCB outp 00: 02010300 00000000 Mar 15 12:09:22 ivy kernel: nouveau 0000:01:00.0: DRM: DCB conn 00: 00000400 Mar 15 12:09:22 ivy kernel: [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). Mar 15 12:09:22 ivy kernel: [drm] Driver supports precise vblank timestamp query. Mar 15 12:09:22 ivy kernel: nouveau 0000:01:00.0: DRM: MM: using COPY0 for buffer copies Mar 15 12:09:22 ivy kernel: nouveau 0000:01:00.0: DRM: allocated 1024x768 fb: 0x60000, bo ffff8804478b7400 Mar 15 12:09:22 ivy kernel: nouveau 0000:01:00.0: fb1: nouveaufb frame buffer device Mar 15 12:09:22 ivy kernel: [drm] Initialized nouveau 1.3.1 20120801 for 0000:01:00.0 on minor 1 -- You are receiving this mail because: You are watching the assignee of the bug. [View Less]

1 2

[PATCH] drm/dsi: Add uevent callback
by Thierry Reding 13 Jun '16

13 Jun '16

From: Thierry Reding <treding(a)nvidia.com> Implement a uevent callback for devices on the MIPI DSI bus. This callback will append MODALIAS information to the uevent and allow modules to be loaded when devices are added to the bus. Signed-off-by: Thierry Reding <treding(a)nvidia.com> --- drivers/gpu/drm/drm_mipi_dsi.c | 16 ++++++++++++++++ include/drm/drm_mipi_dsi.h | 2 ++ 2 files changed, 18 insertions(+) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/… [View More]

2 2

[PATCH v2 0/7] fix bugs; enable iommu for ARM64
by Shunqian Zheng 13 Jun '16

13 Jun '16

This series patches mainly for ARM64 supporting. To do this, it first add virtual iommu slave device which DRM can attach to, convert DRM driver to use common iommu API instead of the ARM32 functions, and then use DMA API in iommu driver to map, to flush cache. The v2 patches make a lot changes vs v1, so please forget the v1. Shunqian Zheng (4): iommu/rockchip: support virtual iommu slave device ARM: dts: rockchip: add virtual iommu for display drm: rockchip: use common iommu api to … [View More]

5 20

[v1 PATCH 0/4] Rockchip Type-C and DispplayPort driver
by Chris Zhong 13 Jun '16

13 Jun '16

Hi all This series patch is for rockchip Type-C phy and DisplayPort controller driver. The USB Type-C PHY is designed to support the USB3 and DP applications. The PHY basically has two main components: USB3 and DisplyPort. USB3 operates in SuperSpeed mode and the DP can operate at RBR, HBR and HBR2 data rates. The Type-C cable orientation detection and Power Delivery (PD) is accomplished using a PD PHY or a exernal PD chip. The DP controller is compliant with DisplayPort Specification, … [View More]Version 1.3, This IP is compatible with the rockchip type-c PHY IP. There is a uCPU in DP controller, it need a firmware to work, please put the firmware file to /lib/firmware/cdn/dptx.bin. The uCPU in charge of aux communication and link training, the host use mailbox to communicate with the ucpu. The PHY driver has register a notification with extcon API, to get the alt mode from PD, the PD driver need call the devm_extcon_dev_allocate to create a extcon device and use extcon_set_state to notify PHY and DP controller. About the DP audio, cdn-dp registered 2 DAIs: 0 is I2S, 1 is SPDIF. We can reference them in simple-card. This series is based on Mark Yao's branch: https://github.com/markyzq/kernel-drm-rockchip/tree/drm-rockchip-next-2016-… I test this patches on the rk3399-evb board, with a fusb302 driver, this branch has no rk3399.dtsi, so the patch about dts is not included in this series. Changes in v1: - add extcon node description - move the registers in phy driver - remove the suffix of reset - update the licence note - init core clock to 50MHz - use extcon API - remove unused global - add some comments for magic num - change usleep_range(1000, 2000) tousleep_range(1000, 1050) - remove __func__ from dev_err - return err number when get clk failed - remove ADDR_ADJ define - use devm_clk_get(&pdev->dev, "tcpdcore") - add extcon node description - add #sound-dai-cells description - use extcon API - use hdmi-codec for the DP Asoc - do not initialize the "ret" - printk a err log when drm_of_encoder_active_endpoint_id - modify the dclk pin_pol to a single line Chris Zhong (4): Documentation: bindings: add dt doc for Rockchip USB Type-C PHY phy: Add USB Type-C PHY driver for rk3399 Documentation: bindings: add dt documentation for cdn DP controller drm/rockchip: cdn-dp: add cdn DP support for rk3399 .../bindings/display/rockchip/cdn-dp-rockchip.txt | 62 ++ .../devicetree/bindings/phy/phy-rockchip-typec.txt | 46 + drivers/gpu/drm/rockchip/Kconfig | 9 + drivers/gpu/drm/rockchip/Makefile | 1 + drivers/gpu/drm/rockchip/cdn-dp-core.c | 709 ++++++++++++++++ drivers/gpu/drm/rockchip/cdn-dp-core.h | 110 +++ drivers/gpu/drm/rockchip/cdn-dp-reg.c | 721 ++++++++++++++++ drivers/gpu/drm/rockchip/cdn-dp-reg.h | 404 +++++++++ drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 +- drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 2 + drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 2 + drivers/phy/Kconfig | 7 + drivers/phy/Makefile | 1 + drivers/phy/phy-rockchip-typec.c | 942 +++++++++++++++++++++ include/linux/phy/phy-rockchip-typec.h | 20 + 15 files changed, 3041 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/display/rockchip/cdn-dp-rockchip.txt create mode 100644 Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt create mode 100644 drivers/gpu/drm/rockchip/cdn-dp-core.c create mode 100644 drivers/gpu/drm/rockchip/cdn-dp-core.h create mode 100644 drivers/gpu/drm/rockchip/cdn-dp-reg.c create mode 100644 drivers/gpu/drm/rockchip/cdn-dp-reg.h create mode 100644 drivers/phy/phy-rockchip-typec.c create mode 100644 include/linux/phy/phy-rockchip-typec.h -- 2.6.3 [View Less]

3 5

drm/dp/mst: change MST detection scheme (v2) - reminder
by Grodzovsky, Andrey 13 Jun '16

13 Jun '16

Hi. Just a reminder with regard to this patch. Please comment if any changes are required. Thanks. -----Original Message----- From: dri-devel [mailto:dri-devel-bounces@lists.freedesktop.org] On Behalf Of dri-devel-request(a)lists.freedesktop.org Sent: Wednesday, May 18, 2016 7:10 PM To: dri-devel(a)lists.freedesktop.org Subject: dri-devel Digest, Vol 74, Issue 285 Send dri-devel mailing list submissions to dri-devel(a)lists.freedesktop.org To subscribe or unsubscribe via the World Wide Web,… [View More] visit https://lists.freedesktop.org/mailman/listinfo/dri-devel or, via email, send a message with subject or body 'help' to dri-devel-request(a)lists.freedesktop.org You can reach the person managing the list at dri-devel-owner(a)lists.freedesktop.org When replying, please edit your Subject line so it is more specific than "Re: Contents of dri-devel digest..." Today's Topics: 1. Re: [PATCH] drm: Nuke ->vblank_disable_allowed (Alex Deucher) 2. Re: [PATCH 1/2] dma-buf/fence: add fence_collection fences (Chris Wilson) 3. drm/dp/mst: change MST detection scheme (v2) (Andrey Grodzovsky) ---------------------------------------------------------------------- Message: 1 Date: Wed, 18 May 2016 17:54:50 -0400 From: Alex Deucher <alexdeucher(a)gmail.com> To: Daniel Vetter <daniel.vetter(a)ffwll.ch> Cc: Laurent Pinchart <laurent.pinchart+renesas(a)ideasonboard.com>, Intel Graphics Development <intel-gfx(a)lists.freedesktop.org>, Liviu Dudau <liviu.dudau(a)arm.com>, DRI Development <dri-devel(a)lists.freedesktop.org>, Tomi Valkeinen <tomi.valkeinen(a)ti.com>, Russell King <rmk+kernel(a)arm.linux.org.uk>, Alex Deucher <alexander.deucher(a)amd.com>, Daniel Vetter <daniel.vetter(a)intel.com> Subject: Re: [PATCH] drm: Nuke ->vblank_disable_allowed Message-ID: <CADnq5_OHpNNN7yr6QB6xf_7eObVE7hdLFJY4cjTWpH0uTsC1Bw(a)mail.gmail.com> Content-Type: text/plain; charset=UTF-8 On Wed, May 18, 2016 at 4:29 PM, Daniel Vetter <daniel.vetter(a)ffwll.ch> wrote: > This was added in > > commit 0a3e67a4caac273a3bfc4ced3da364830b1ab241 > Author: Jesse Barnes <jbarnes(a)virtuousgeek.org> > Date: Tue Sep 30 12:14:26 2008 -0700 > > drm: Rework vblank-wait handling to allow interrupt reduction. > > to stay backwards-compatible with old UMS code that didn't even tell > the kernel when it did a modeset, so that the kernel could > save/restore vblank counters. At worst this means vblanks will be > somewhat funky on a setup that very likely no one still runs. > > So let's just nuke it. > > Plan B would be to set it unconditionally in drm_vblank_init for kms > drivers, instead of in each driver separately. So if this patch breaks > anything please only restore the hunks in drmP.h and drm_irq.c, plus > add a check for DRIVER_MODESET in drm_vblank_init. > > Stumbled over this in a discussion on irc with Chris. > > v2: Remove leftover debug gunk from psr hacking (Alex). > > Cc: Chris Wilson <chris(a)chris-wilson.co.uk> > Cc: Alex Deucher <alexander.deucher(a)amd.com> > Cc: Liviu Dudau <liviu.dudau(a)arm.com> > Cc: Russell King <rmk+kernel(a)arm.linux.org.uk> > Cc: Thierry Reding <thierry.reding(a)gmail.com> > Cc: Eric Anholt <eric(a)anholt.net> > Cc: Laurent Pinchart <laurent.pinchart+renesas(a)ideasonboard.com> > Cc: Inki Dae <inki.dae(a)samsung.com> > Cc: Tomi Valkeinen <tomi.valkeinen(a)ti.com> > Cc: Mark Yao <mark.yao(a)rock-chips.com> > Cc: Sascha Hauer <s.hauer(a)pengutronix.de> > Cc: Philipp Zabel <p.zabel(a)pengutronix.de> > Signed-off-by: Daniel Vetter <daniel.vetter(a)intel.com> Seems reasonable to me. Reviewed-by: Alex Deucher <alexander.deucher(a)amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 1 - > drivers/gpu/drm/arm/hdlcd_drv.c | 1 - > drivers/gpu/drm/armada/armada_drv.c | 1 - > drivers/gpu/drm/drm_irq.c | 6 ------ > drivers/gpu/drm/exynos/exynos_drm_drv.c | 7 ------- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 1 - > drivers/gpu/drm/gma500/psb_drv.c | 1 - > drivers/gpu/drm/i915/i915_dma.c | 3 --- > drivers/gpu/drm/imx/imx-drm-core.c | 7 ------- > drivers/gpu/drm/radeon/radeon_irq_kms.c | 1 - > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 7 ------- > drivers/gpu/drm/tegra/drm.c | 1 - > drivers/gpu/drm/vc4/vc4_kms.c | 2 -- > include/drm/drmP.h | 8 -------- > 14 files changed, 47 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c > index 9266c7b69808..835a3fa8d8df 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c > @@ -219,7 +219,6 @@ int amdgpu_irq_init(struct amdgpu_device *adev) > if (r) { > return r; > } > - adev->ddev->vblank_disable_allowed = true; > > /* enable msi */ > adev->irq.msi_enabled = false; diff --git > a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c > index 2112f0b105e3..4f909378d581 100644 > --- a/drivers/gpu/drm/arm/hdlcd_drv.c > +++ b/drivers/gpu/drm/arm/hdlcd_drv.c > @@ -379,7 +379,6 @@ static int hdlcd_drm_bind(struct device *dev) > DRM_ERROR("failed to initialise vblank\n"); > goto err_vblank; > } > - drm->vblank_disable_allowed = true; > > drm_mode_config_reset(drm); > drm_kms_helper_poll_init(drm); diff --git > a/drivers/gpu/drm/armada/armada_drv.c > b/drivers/gpu/drm/armada/armada_drv.c > index 531fcb946346..cb21c0b6374a 100644 > --- a/drivers/gpu/drm/armada/armada_drv.c > +++ b/drivers/gpu/drm/armada/armada_drv.c > @@ -113,7 +113,6 @@ static int armada_drm_load(struct drm_device *dev, unsigned long flags) > goto err_comp; > > dev->irq_enabled = true; > - dev->vblank_disable_allowed = 1; > > ret = armada_fbdev_init(dev); > if (ret) > diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c > index d1b5fc20b2f8..1a0ae89087e8 100644 > --- a/drivers/gpu/drm/drm_irq.c > +++ b/drivers/gpu/drm/drm_irq.c > @@ -348,9 +348,6 @@ static void vblank_disable_fn(unsigned long arg) > unsigned int pipe = vblank->pipe; > unsigned long irqflags; > > - if (!dev->vblank_disable_allowed) > - return; > - > spin_lock_irqsave(&dev->vbl_lock, irqflags); > if (atomic_read(&vblank->refcount) == 0 && vblank->enabled) { > DRM_DEBUG("disabling vblank on crtc %u\n", pipe); @@ > -437,8 +434,6 @@ int drm_vblank_init(struct drm_device *dev, unsigned int num_crtcs) > "get_vblank_timestamp == NULL\n"); > } > > - dev->vblank_disable_allowed = false; > - > return 0; > > err: > @@ -1555,7 +1550,6 @@ static void > drm_legacy_vblank_post_modeset(struct drm_device *dev, > > if (vblank->inmodeset) { > spin_lock_irqsave(&dev->vbl_lock, irqflags); > - dev->vblank_disable_allowed = true; > drm_reset_vblank_timestamp(dev, pipe); > spin_unlock_irqrestore(&dev->vbl_lock, irqflags); > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c > b/drivers/gpu/drm/exynos/exynos_drm_drv.c > index 21c719e8e02b..2dd820e23b0c 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c > @@ -212,13 +212,6 @@ static int exynos_drm_load(struct drm_device *dev, unsigned long flags) > */ > dev->irq_enabled = true; > > - /* > - * with vblank_disable_allowed = true, vblank interrupt will be disabled > - * by drm timer once a current process gives up ownership of > - * vblank event.(after drm_vblank_put function is called) > - */ > - dev->vblank_disable_allowed = true; > - > /* init kms poll for handling hpd */ > drm_kms_helper_poll_init(dev); > > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > index 2e58dfd74ae1..33727d5d826a 100644 > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > @@ -80,7 +80,6 @@ static int fsl_dcu_load(struct drm_device *dev, unsigned long flags) > dev_err(dev->dev, "failed to initialize vblank\n"); > goto done; > } > - dev->vblank_disable_allowed = true; > > ret = fsl_dcu_drm_irq_init(dev); > if (ret < 0) > diff --git a/drivers/gpu/drm/gma500/psb_drv.c > b/drivers/gpu/drm/gma500/psb_drv.c > index 4e1c6850520e..82b8ce418b27 100644 > --- a/drivers/gpu/drm/gma500/psb_drv.c > +++ b/drivers/gpu/drm/gma500/psb_drv.c > @@ -374,7 +374,6 @@ static int psb_driver_load(struct drm_device *dev, > unsigned long flags) > > drm_irq_install(dev, dev->pdev->irq); > > - dev->vblank_disable_allowed = true; > dev->max_vblank_count = 0xffffff; /* only 24 bits of frame count */ > dev->driver->get_vblank_counter = psb_get_vblank_counter; > > diff --git a/drivers/gpu/drm/i915/i915_dma.c > b/drivers/gpu/drm/i915/i915_dma.c index a8c79f6512a4..fd06bff216ff > 100644 > --- a/drivers/gpu/drm/i915/i915_dma.c > +++ b/drivers/gpu/drm/i915/i915_dma.c > @@ -515,9 +515,6 @@ static int i915_load_modeset_init(struct > drm_device *dev) > > intel_modeset_gem_init(dev); > > - /* Always safe in the mode setting case. */ > - /* FIXME: do pre/post-mode set stuff in core KMS code */ > - dev->vblank_disable_allowed = true; > if (INTEL_INFO(dev)->num_pipes == 0) > return 0; > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c > b/drivers/gpu/drm/imx/imx-drm-core.c > index 2453fb1c68a7..1080019e7b17 100644 > --- a/drivers/gpu/drm/imx/imx-drm-core.c > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > @@ -252,13 +252,6 @@ static int imx_drm_driver_load(struct drm_device *drm, unsigned long flags) > if (ret) > goto err_kms; > > - /* > - * with vblank_disable_allowed = true, vblank interrupt will be > - * disabled by drm timer once a current process gives up ownership > - * of vblank event. (after drm_vblank_put function is called) > - */ > - drm->vblank_disable_allowed = true; > - > platform_set_drvdata(drm->platformdev, drm); > > /* Now try and bind all our sub-components */ diff --git > a/drivers/gpu/drm/radeon/radeon_irq_kms.c > b/drivers/gpu/drm/radeon/radeon_irq_kms.c > index 1e9304d1c88f..c084cadcbf21 100644 > --- a/drivers/gpu/drm/radeon/radeon_irq_kms.c > +++ b/drivers/gpu/drm/radeon/radeon_irq_kms.c > @@ -291,7 +291,6 @@ int radeon_irq_kms_init(struct radeon_device *rdev) > if (r) { > return r; > } > - rdev->ddev->vblank_disable_allowed = true; > > /* enable msi */ > rdev->msi_enabled = 0; > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > index ced1e5f93cda..09a4d429c0f0 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > @@ -217,13 +217,6 @@ static int rockchip_drm_load(struct drm_device *drm_dev, unsigned long flags) > if (ret) > goto err_kms_helper_poll_fini; > > - /* > - * with vblank_disable_allowed = true, vblank interrupt will be disabled > - * by drm timer once a current process gives up ownership of > - * vblank event.(after drm_vblank_put function is called) > - */ > - drm_dev->vblank_disable_allowed = true; > - > drm_mode_config_reset(drm_dev); > > ret = rockchip_drm_fbdev_init(drm_dev); diff --git > a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index > 679905544181..b59c3bf0df44 100644 > --- a/drivers/gpu/drm/tegra/drm.c > +++ b/drivers/gpu/drm/tegra/drm.c > @@ -180,7 +180,6 @@ static int tegra_drm_load(struct drm_device *drm, > unsigned long flags) > > /* syncpoints are used for full 32-bit hardware VBLANK counters */ > drm->max_vblank_count = 0xffffffff; > - drm->vblank_disable_allowed = true; > > err = drm_vblank_init(drm, drm->mode_config.num_crtc); > if (err < 0) > diff --git a/drivers/gpu/drm/vc4/vc4_kms.c > b/drivers/gpu/drm/vc4/vc4_kms.c index d423ba10239a..cb37751bc99f > 100644 > --- a/drivers/gpu/drm/vc4/vc4_kms.c > +++ b/drivers/gpu/drm/vc4/vc4_kms.c > @@ -207,8 +207,6 @@ int vc4_kms_load(struct drm_device *dev) > dev->mode_config.preferred_depth = 24; > dev->mode_config.async_page_flip = true; > > - dev->vblank_disable_allowed = true; > - > drm_mode_config_reset(dev); > > vc4->fbdev = drm_fbdev_cma_init(dev, 32, diff --git > a/include/drm/drmP.h b/include/drm/drmP.h index > f0d1450d4ea5..30dc7d8c403f 100644 > --- a/include/drm/drmP.h > +++ b/include/drm/drmP.h > @@ -819,14 +819,6 @@ struct drm_device { > int irq; > > /* > - * At load time, disabling the vblank interrupt won't be allowed since > - * old clients may not call the modeset ioctl and therefore misbehave. > - * Once the modeset ioctl *has* been called though, we can safely > - * disable them when unused. > - */ > - bool vblank_disable_allowed; > - > - /* > * If true, vblank interrupt will be disabled immediately when the > * refcount drops to zero, as opposed to via the vblank disable > * timer. > -- > 2.8.1 > > _______________________________________________ > dri-devel mailing list > dri-devel(a)lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel ------------------------------ Message: 2 Date: Wed, 18 May 2016 23:57:10 +0100 From: Chris Wilson <chris(a)chris-wilson.co.uk> To: Gustavo Padovan <gustavo(a)padovan.org> Cc: marcheu(a)google.com, Daniel Stone <daniels(a)collabora.com>, seanpaul(a)google.com, Daniel Vetter <daniel.vetter(a)ffwll.ch>, linux-kernel(a)vger.kernel.org, dri-devel(a)lists.freedesktop.org, laurent.pinchart(a)ideasonboard.com, Alex Deucher <alexander.deucher(a)amd.com>, Gustavo Padovan <gustavo.padovan(a)collabora.co.uk>, Christian König <christian.koenig(a)amd.com>, John Harrison <John.C.Harrison(a)Intel.com>, m.chehab(a)samsung.com Subject: Re: [PATCH 1/2] dma-buf/fence: add fence_collection fences Message-ID: <20160518225710.GA32627(a)nuc-i3427.alporthouse.com> Content-Type: text/plain; charset=us-ascii On Wed, May 18, 2016 at 05:59:52PM -0300, Gustavo Padovan wrote: > +static void collection_check_cb_func(struct fence *fence, struct > +fence_cb *cb) { > + struct fence_collection_cb *f_cb; > + struct fence_collection *collection; > + > + f_cb = container_of(cb, struct fence_collection_cb, cb); > + collection = f_cb->collection; > + > + if (atomic_dec_and_test(&collection->num_pending_fences)) > + fence_signal(&collection->base); > +} > + > +static bool fence_collection_enable_signaling(struct fence *fence) { > + struct fence_collection *collection = to_fence_collection(fence); > + int i; > + > + for (i = 0 ; i < collection->num_fences ; i++) { > + if (fence_add_callback(collection->fences[i].fence, > + &collection->fences[i].cb, > + collection_check_cb_func)) { > + atomic_dec(&collection->num_pending_fences); > + } > + } We don't always have a convenient means to preallocate an array of fences to use. Keeping a list of fences in addition to the array would be easier to user in many circumstances. Just means we need a struct fence_collection_entry { struct fence *fence; struct list_head link; }; int fence_collection_add(struct fence *_collection, struct fence *fence) { struct fence_collection *collection = to_fence_collection(_collection); struct fence_collection_entry *entry; entry = kmalloc(sizeof(*entry), GFP_KERNEL); if (!entry) return -ENOMEM; entry->fence = fence_get(fence); list_add_tail(&entry->link, &collection->fence_list); atomic_inc(&collection->num_pending_fences); return 0; } and a couple of list iterations as well as walking the arrays. (This fence_collection_add() needs to be documented to only be valid from the constructing thread before the fence is sealed for export/use.) -Chris -- Chris Wilson, Intel Open Source Technology Centre HI. ------------------------------ Message: 3 Date: Wed, 18 May 2016 18:37:10 -0400 From: Andrey Grodzovsky <Andrey.Grodzovsky(a)amd.com> To: <dri-devel(a)lists.freedesktop.org> Cc: Mykola Lysenko <Mykola.Lysenko(a)amd.com> Subject: drm/dp/mst: change MST detection scheme (v2) Message-ID: <1463611030-21448-1-git-send-email-Andrey.Grodzovsky(a)amd.com> Content-Type: text/plain; charset="UTF-8" From: Mykola Lysenko <Mykola.Lysenko(a)amd.com> 1. Get edid for all connected MST displays, not only on logical ports, in the same thread as MST topology detection is done: There are displays that have branches inside w/o logical ports. So in case another SST display connected downstream system can end-up in situation when 3 DOWN requests sent: two for ‘remote i2c read’ and one for ‘enum path resources’, making slots full. 2. Call notification callback in one place in the end of topology discovery/update: This is done to reduce number of events sent to userspace in case complex topology discovery is going, adding multiple number of connectors; 3. Remove notification callback call from short pulse interrupt processing function: This is done in order not to block interrupt processing function, in case any MST request will be made from it. Notification will be send from topology discovery/update work item. v2: This change also includes tile property set fix which caused regression in i915 driver. Reviewed-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Mykola Lysenko <Mykola.Lysenko(a)amd.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 36 +++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 27fbd79..9971c46 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_dp_mst_topology.c @@ -1159,13 +1159,9 @@ static void drm_dp_add_port(struct drm_dp_mst_branch *mstb, drm_dp_put_port(port); goto out; } - if (port->port_num >= DP_MST_LOGICAL_PORT_0) { - port->cached_edid = drm_get_edid(port->connector, &port->aux.ddc); - drm_mode_connector_set_tile_property(port->connector); - } + (*mstb->mgr->cbs->register_connector)(port->connector); } - out: /* put reference to this port */ drm_dp_put_port(port); @@ -1190,8 +1186,8 @@ static void drm_dp_update_port(struct drm_dp_mst_branch *mstb, port->ddps = conn_stat->displayport_device_plug_status; if (old_ddps != port->ddps) { + dowork = true; if (port->ddps) { - dowork = true; } else { port->available_pbn = 0; } @@ -1296,8 +1292,13 @@ static void drm_dp_check_and_send_link_address(struct drm_dp_mst_topology_mgr *m if (port->input) continue; - if (!port->ddps) + if (!port->ddps) { + if (port->cached_edid) { + kfree(port->cached_edid); + port->cached_edid = NULL; + } continue; + } if (!port->available_pbn) drm_dp_send_enum_path_resources(mgr, mstb, port); @@ -1308,6 +1309,13 @@ static void drm_dp_check_and_send_link_address(struct drm_dp_mst_topology_mgr *m drm_dp_check_and_send_link_address(mgr, mstb_child); drm_dp_put_mst_branch_device(mstb_child); } + } else if (port->pdt == DP_PEER_DEVICE_SST_SINK || + port->pdt == DP_PEER_DEVICE_DP_LEGACY_CONV) { + if (!port->cached_edid) { + port->cached_edid = + drm_get_edid(port->connector, &port->aux.ddc); + drm_mode_connector_set_tile_property(port->connector); + } } } } @@ -1327,6 +1335,8 @@ static void drm_dp_mst_link_probe_work(struct work_struct *work) drm_dp_check_and_send_link_address(mgr, mstb); drm_dp_put_mst_branch_device(mstb); } + + (*mgr->cbs->hotplug)(mgr); } static bool drm_dp_validate_guid(struct drm_dp_mst_topology_mgr *mgr, @@ -1586,7 +1596,6 @@ static void drm_dp_send_link_address(struct drm_dp_mst_topology_mgr *mgr, for (i = 0; i < txmsg->reply.u.link_addr.nports; i++) { drm_dp_add_port(mstb, mgr->dev, &txmsg->reply.u.link_addr.ports[i]); } - (*mgr->cbs->hotplug)(mgr); } } else { mstb->link_address_sent = false; @@ -2283,8 +2292,6 @@ static int drm_dp_mst_handle_up_req(struct drm_dp_mst_topology_mgr *mgr) drm_dp_update_port(mstb, &msg.u.conn_stat); DRM_DEBUG_KMS("Got CSN: pn: %d ldps:%d ddps: %d mcs: %d ip: %d pdt: %d\n", msg.u.conn_stat.port_number, msg.u.conn_stat.legacy_device_plug_status, msg.u.conn_stat.displayport_device_plug_status, msg.u.conn_stat.message_capability_status, msg.u.conn_stat.input_port, msg.u.conn_stat.peer_device_type); - (*mgr->cbs->hotplug)(mgr); - } else if (msg.req_type == DP_RESOURCE_STATUS_NOTIFY) { drm_dp_send_up_ack_reply(mgr, mgr->mst_primary, msg.req_type, seqno, false); if (!mstb) @@ -2371,10 +2378,6 @@ enum drm_connector_status drm_dp_mst_detect_port(struct drm_connector *connector case DP_PEER_DEVICE_SST_SINK: status = connector_status_connected; - /* for logical ports - cache the EDID */ - if (port->port_num >= 8 && !port->cached_edid) { - port->cached_edid = drm_get_edid(connector, &port->aux.ddc); - } break; case DP_PEER_DEVICE_DP_LEGACY_CONV: if (port->ldps) @@ -2429,10 +2432,7 @@ struct edid *drm_dp_mst_get_edid(struct drm_connector *connector, struct drm_dp_ if (port->cached_edid) edid = drm_edid_duplicate(port->cached_edid); - else { - edid = drm_get_edid(connector, &port->aux.ddc); - drm_mode_connector_set_tile_property(connector); - } + port->has_audio = drm_detect_monitor_audio(edid); drm_dp_put_port(port); return edid; -- 1.9.1 ------------------------------ Subject: Digest Footer _______________________________________________ dri-devel mailing list dri-devel(a)lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ------------------------------ End of dri-devel Digest, Vol 74, Issue 285 ****************************************** [View Less]

2 1

[PATCH] drm: fb: cma: fix memory leak
by Sudip Mukherjee 13 Jun '16

13 Jun '16

We may have a situation that the memory allocation for fbdefio fails and then the allocation for fbops may succeed as some memory has been freed somewhere. Lets free fbops also to face these rare situtation. Since kfree can handle arguments as NULL, there should not be any problem in calling both the kfree(). Signed-off-by: Sudip Mukherjee <sudip.mukherjee(a)codethink.co.uk> --- drivers/gpu/drm/drm_fb_cma_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/… [View More]

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel June 2016