https://bugs.freedesktop.org/show_bug.cgi?id=103188
Chris Wilson <chris(a)chris-wilson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|intel-gfx-bugs(a)lists.freede |dri-devel(a)lists.freedesktop
|sktop.org |.org
Resolution|--- |FIXED
QA Contact|intel-gfx-bugs(a)lists.freede |
…
[View More] |sktop.org |
Status|NEW |RESOLVED
Component|DRM/Intel |IGT
--- Comment #2 from Chris Wilson <chris(a)chris-wilson.co.uk> ---
commit 136100c2f00b590bc9485100cce012282c1217cf (HEAD, upstream/master)
Author: Jason Ekstrand <jason(a)jlekstrand.net>
Date: Tue Oct 10 13:02:20 2017 -0700
igt/syncobj_wait: Don't close the timeline early in wait_snapshot
Closing the sw_sync timeline now signals any remaining fences upon it;
but test_wait_snapshot requires the fence to continue to be busy so that
the __syncobj_wait() will return with -ETIME.
--
You are receiving this mail because:
You are the assignee for the bug.
[View Less]
The IDMAC_LOCK_EN registers on i.MX51 have a different layout, and on
i.MX53 enabling the lock feature causes bursts to get lost. Restrict
enabling the burst lock feature to i.MX6.
Reported-by: Patrick Brünn <P.Bruenn(a)beckhoff.com>
Fixes: 790cb4c7c954 ("drm/imx: lock scanout transfers for consecutive bursts")
Signed-off-by: Philipp Zabel <p.zabel(a)pengutronix.de>
---
drivers/gpu/ipu-v3/ipu-common.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/ipu-v3/…
[View More]ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c
index 6a573d21d3cc2..658fa2d3e40c2 100644
--- a/drivers/gpu/ipu-v3/ipu-common.c
+++ b/drivers/gpu/ipu-v3/ipu-common.c
@@ -405,6 +405,14 @@ int ipu_idmac_lock_enable(struct ipuv3_channel *channel, int num_bursts)
return -EINVAL;
}
+ /*
+ * IPUv3EX / i.MX51 has a different register layout, and on IPUv3M /
+ * i.MX53 channel arbitration locking doesn't seem to work properly.
+ * Allow enabling the lock feature on IPUv3H / i.MX6 only.
+ */
+ if (bursts && ipu->ipu_type != IPUV3H)
+ return -EINVAL;
+
for (i = 0; i < ARRAY_SIZE(idmac_lock_en_info); i++) {
if (channel->num == idmac_lock_en_info[i].chnum)
break;
--
2.11.0
[View Less]
Changes since last version:
* Add local definitions of new ioctls to avoid dependency on proposed
libdrm bits.
* Remove FIRST_PIXEL_OUT as that has been removed from the proposed
kernel interface
* Add tests for get_lease and list_lessees
* Fix commit message on the lease test patch
From: Christian König <christian.koenig(a)amd.com>
We need to figure out first how to correctly map them into the CPU page tables.
bug: https://bugs.freedesktop.org/show_bug.cgi?id=103138
Signed-off-by: Christian König <christian.koenig(a)amd.com>
---
drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
index e5ef10d..96ad129 100644
--- a/drivers/gpu/drm/ttm/…
[View More]ttm_page_alloc_dma.c
+++ b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
@@ -913,6 +913,7 @@ static gfp_t ttm_dma_pool_gfp_flags(struct ttm_dma_tt *ttm_dma, bool huge)
if (huge) {
gfp_flags |= GFP_TRANSHUGE;
gfp_flags &= ~__GFP_MOVABLE;
+ gfp_flags &= ~__GFP_COMP;
}
return gfp_flags;
--
2.7.4
[View Less]
https://bugs.freedesktop.org/show_bug.cgi?id=97942
--- Comment #8 from Elizabeth <elizabethx.de.la.torre.mena(a)intel.com> ---
(In reply to Humberto Israel Perez Rodriguez from comment #6)
> The following test cases failure on BXT with latest configuration
>
> igt@gem_mmap@swap-bo
> igt@gem_mmap_gtt@coherency
> igt@gem_mmap_gtt@swap-copy
> igt@gem_mmap_gtt@swap-copy-odd
> igt@gem_mmap_gtt@swap-copy-xy
Please note that:
Test igt@gem_mmap_gtt@basic-wc is being follow …
[View More]on bug 102995 also.
Test igt@gem_mmap_gtt@coherency is being follow on bug 100587.
Test igt@gem_mmap@swap-bo is being follow on bug 101701.
A different bug should be used for swap-copy* tests:
igt@gem_mmap_gtt@swap-copy
igt@gem_mmap_gtt@swap-copy-odd
igt@gem_mmap_gtt@swap-copy-xy
Also there is no track of these (swap-copy*) on CI.
Thank you.
--
You are receiving this mail because:
You are the assignee for the bug.
[View Less]
Here's another version of the DRM lease series. No changes in the code
at all:
[PATCH 4/6] drm: Add drm_object lease infrastructure [v4]
Changes in v4, suggested by Dave Airlie <airlied(a)gmail.com>
* Formatting and whitespace changes
[PATCH 6/6] drm: Add four ioctls for managing drm mode object leases
Changes for v3 suggested by Dave Airlie <airlied(a)gmail.com>
* Expand on the comment about the magic use of &drm_lease_idr_object
* Pad …
[View More]lease ioctl structures to align on 64-bit boundaries
Thanks much to Dave Airlie for his review.
-keith
[View Less]
From: Colin Ian King <colin.king(a)canonical.com>
There is a previous check to on has_aliasing_ppgtt that returns
0 if it is false, so it is impossible for has_aliasing_ppgtt to
be false on the final return of function intel_sanitize_enable_ppgtt,
so final return in the function always will return 1. Hence the
redundant ternary operator can be replaced with a return 1.
Detected by CoverityScan, CID#1357136 ("Logically dead code")
Signed-off-by: Colin Ian King <colin.king(a)…
[View More]canonical.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 4c82ceb8d318..e1a318ea4327 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -188,7 +188,7 @@ int intel_sanitize_enable_ppgtt(struct drm_i915_private *dev_priv,
return 2;
}
- return has_aliasing_ppgtt ? 1 : 0;
+ return 1;
}
static int ppgtt_bind_vma(struct i915_vma *vma,
--
2.14.1
[View Less]
The motivation of this series is to cut down unnecessary header
dependency in terms of radix tree.
Sub-systems or drivers that use radix-tree for data management
typically embed struct radix_tree_root in their data structures,
like this:
struct foo {
...
struct radix_tree_root foo_tree;
...
};
So, <linux/foo.h> needs to include <linux/radix-tree.h>,
therefore, users of <linux/foo.h> include a lot of bloat
from <linux/radix-tree.h>.
If you see …
[View More]the definition of radix_tree_root,
struct radix_tree_root {
gfp_t gfp_mask;
struct radix_tree_node __rcu *rnode;
};
it is a very simple structure.
It only depends on <linux/types.h> for gfp_t and
<linux/compiler.h> for __rcu.
By splitting out the radix_tree_root definition,
we can reduce the header file dependency.
Reducing the header dependency will help for speeding the kernel
build, suppressing unnecessary recompile of objects during
git-bisect'ing, etc.
The patch 1 is a trivial clean-up; it is just here
to avoid conflict.
The patch 2 is the main part of this series;
split out struct radix_tree_root.
The rest of the series replace <linux/radix-tree.h>
with <linux/radix-tree-root.h> where appropriate.
Please review if the idea is OK.
If it is OK, I'd like to know how to apply the series.
Perhaps, the first two for v4.15. Then, rest of series
will be sent per-subsystem for v4.16?
Or, can somebody take care of the whole series?
I checked allmodconfig for x86 and arm64.
I am expecting 0 day testing will check it too.
Masahiro Yamada (12):
radix-tree: replace <linux/spinlock.h> with <linux/spinlock_types.h>
radix-tree: split struct radix_tree_root to <linux/radix-tree-root.h>
irqdomain: replace <linux/radix-tree.h> with <linux/radix-tree-root.h>
writeback: replace <linux/radix-tree.h> with <linux/radix-tree-root.h>
iocontext.h: replace <linux/radix-tree.h> with
<linux/radix-tree-root.h>
fs: replace <linux/radix-tree.h> with <linux/radix-tree-root.h>
blkcg: replace <linux/radix-tree.h> with <linux/radix-tree-root.h>
fscache: include <linux-radix-tree.h>
sh: intc: replace <linux/radix-tree.h> with <linux/radix-tree-root.h>
net/mlx4: replace <linux/radix-tree.h> with <linux/radix-tree-root.h>
net/mlx5: replace <linux/radix-tree.h> with <linux/radix-tree-root.h>
drm/i915: replace <linux/radix-tree.h> with <linux/radix-tree-root.h>
drivers/gpu/drm/i915/i915_gem.c | 1 +
drivers/gpu/drm/i915/i915_gem_context.c | 1 +
drivers/gpu/drm/i915/i915_gem_context.h | 2 +-
drivers/gpu/drm/i915/i915_gem_execbuffer.c | 1 +
drivers/gpu/drm/i915/i915_gem_object.h | 1 +
drivers/net/ethernet/mellanox/mlx4/cq.c | 1 +
drivers/net/ethernet/mellanox/mlx4/mlx4.h | 2 +-
drivers/net/ethernet/mellanox/mlx4/qp.c | 1 +
drivers/net/ethernet/mellanox/mlx4/srq.c | 1 +
drivers/sh/intc/internals.h | 2 +-
include/linux/backing-dev-defs.h | 2 +-
include/linux/blk-cgroup.h | 2 +-
include/linux/fs.h | 2 +-
include/linux/fscache.h | 1 +
include/linux/iocontext.h | 2 +-
include/linux/irqdomain.h | 2 +-
include/linux/mlx4/device.h | 2 +-
include/linux/mlx4/qp.h | 1 +
include/linux/mlx5/driver.h | 2 +-
include/linux/mlx5/qp.h | 1 +
include/linux/radix-tree-root.h | 24 ++++++++++++++++++++++++
include/linux/radix-tree.h | 8 ++------
22 files changed, 46 insertions(+), 16 deletions(-)
create mode 100644 include/linux/radix-tree-root.h
--
2.7.4
[View Less]