dri-devel October 2017

dri-devel@lists.freedesktop.org

228 participants
1625 discussions

[Bug 103080] DC driver from drm-next-4.15-dc branch (upstream PR) not working
by bugzilla-daemon＠freedesktop.org 03 Oct '17

03 Oct '17

https://bugs.freedesktop.org/show_bug.cgi?id=103080 --- Comment #2 from Carlo Caione <carlo(a)caione.org> --- Created attachment 134643 --> https://bugs.freedesktop.org/attachment.cgi?id=134643&action=edit CONFIG_DRM_AMD_DC_PRE_VEGA kernel Oops (In reply to Harry Wentland from comment #1) > Hi Carlo, > > please pass amdgpu.dc=1 module parameter or set CONFIG_DRM_AMD_DC_PRE_VEGA > flag at build. This is interesting. When compiling with CONFIG_DRM_AMD_DC_PRE_VEGA I get a kernel Oops when connecting the HDMI cable, see the attached log. But (good news) if I revert https://cgit.freedesktop.org/~agd5f/linux/commit/?id=8f5ed2ed31944eea5c2746… I have no kernel Oops and HDMI works fine. So something is definitely wrong with that commit. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 103080] DC driver from drm-next-4.15-dc branch (upstream PR) not working
by bugzilla-daemon＠freedesktop.org 03 Oct '17

03 Oct '17

https://bugs.freedesktop.org/show_bug.cgi?id=103080 --- Comment #1 from Harry Wentland <harry.wentland(a)amd.com> --- Hi Carlo, please pass amdgpu.dc=1 module parameter or set CONFIG_DRM_AMD_DC_PRE_VEGA flag at build. With this branch we decided to only enable it by default for Vega ASICs. With anything older than Vega you'll have to force enable it. Harry -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 103080] DC driver from drm-next-4.15-dc branch (upstream PR) not working
by bugzilla-daemon＠freedesktop.org 03 Oct '17

03 Oct '17

1 0

[PATCH] drm/msm: use proper memory barriers for updating tail/head
by Rob Clark 03 Oct '17

03 Oct '17

Fixes intermittent corruption of cmdstream dump. Signed-off-by: Rob Clark <robdclark(a)gmail.com> --- drivers/gpu/drm/msm/msm_rd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_rd.c b/drivers/gpu/drm/msm/msm_rd.c index 5c087a4228ff..918c65e19964 100644 --- a/drivers/gpu/drm/msm/msm_rd.c +++ b/drivers/gpu/drm/msm/msm_rd.c @@ -120,7 +120,7 @@ static void rd_write(struct msm_rd_state *rd, const void *buf, int sz) n = min(sz, circ_space_to_end(&rd->fifo)); memcpy(fptr, ptr, n); - fifo->head = (fifo->head + n) & (BUF_SZ - 1); + smp_store_release(&fifo->head, (fifo->head + n) & (BUF_SZ - 1)); sz -= n; ptr += n; @@ -157,7 +157,7 @@ static ssize_t rd_read(struct file *file, char __user *buf, goto out; } - fifo->tail = (fifo->tail + n) & (BUF_SZ - 1); + smp_store_release(&fifo->tail, (fifo->tail + n) & (BUF_SZ - 1)); *ppos += n; wake_up_all(&rd->fifo_event); -- 2.13.5

2 3

[PATCH 0/6] drm/msm: Fixes and updates for 4.15
by Jordan Crouse 03 Oct '17

03 Oct '17

A handful of minor updates and bugfixes. Includes an UAPI change to MSM_DRM_SUBMITQUEUE_CLOSE API as suggested by Rob, a tweak to rd to dump all iova addresses from a submission and a few performance tweaks for user submissions that don't use relocs. Jordan Crouse (3): drm/msm: dump a rd GPUADDR header for all buffers in the command drm/msm: Change MSM_DRM_SUBMITQUEUE_CLOSE drm/msm: Do priority checking during submitqueue create Sharat Masetty (1): drm/msm: Fix race condition in the submit path Sushmita Susheelendra (2): drm/msm: Map command buffers to kernel only if required drm/msm: Map buffers on demand on the submit path drivers/gpu/drm/msm/adreno/a5xx_gpu.h | 8 +++- drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 17 ++++++-- drivers/gpu/drm/msm/msm_drv.c | 4 +- drivers/gpu/drm/msm/msm_gem_submit.c | 69 ++++++++++++++++--------------- drivers/gpu/drm/msm/msm_gpu.h | 1 - drivers/gpu/drm/msm/msm_rd.c | 30 +++++++------- drivers/gpu/drm/msm/msm_submitqueue.c | 25 ++++++++--- include/uapi/drm/msm_drm.h | 2 +- 8 files changed, 94 insertions(+), 62 deletions(-) -- 1.9.1

1 6

[PATCH] sync_file: Return consistent status in SYNC_IOC_FILE_INFO
by John Einar Reitan 03 Oct '17

03 Oct '17

sync_file_ioctl_fence_info has a race between filling the status of the underlying fences and the overall status of the sync_file. If fence transitions in the time frame between its sync_fill_fence_info and the later dma_fence_is_signaled for the sync_file, the returned information is inconsistent showing non-signaled underlying fences but an overall signaled state. This patch changes sync_file_ioctl_fence_info to track what has been encoded and using that as the overall sync_file status. Tested-by: Vamsidhar Reddy Gaddam <vamsidhar.gaddam(a)arm.com> Signed-off-by: John Einar Reitan <john.reitan(a)arm.com> --- drivers/dma-buf/sync_file.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/dma-buf/sync_file.c b/drivers/dma-buf/sync_file.c index 66fb40d0ebdb..ebf5764b868c 100644 --- a/drivers/dma-buf/sync_file.c +++ b/drivers/dma-buf/sync_file.c @@ -383,7 +383,7 @@ static long sync_file_ioctl_merge(struct sync_file *sync_file, return err; } -static void sync_fill_fence_info(struct dma_fence *fence, +static int sync_fill_fence_info(struct dma_fence *fence, struct sync_fence_info *info) { strlcpy(info->obj_name, fence->ops->get_timeline_name(fence), @@ -399,6 +399,8 @@ static void sync_fill_fence_info(struct dma_fence *fence, test_bit(DMA_FENCE_FLAG_TIMESTAMP_BIT, &fence->flags) ? ktime_to_ns(fence->timestamp) : ktime_set(0, 0); + + return info->status; } static long sync_file_ioctl_fence_info(struct sync_file *sync_file, @@ -408,7 +410,7 @@ static long sync_file_ioctl_fence_info(struct sync_file *sync_file, struct sync_fence_info *fence_info = NULL; struct dma_fence **fences; __u32 size; - int num_fences, ret, i; + int num_fences, ret, i, fences_status = 1; if (copy_from_user(&info, (void __user *)arg, sizeof(info))) return -EFAULT; @@ -424,8 +426,10 @@ static long sync_file_ioctl_fence_info(struct sync_file *sync_file, * sync_fence_info and return the actual number of fences on * info->num_fences. */ - if (!info.num_fences) + if (!info.num_fences) { + fences_status = dma_fence_is_signaled(sync_file->fence); goto no_fences; + } if (info.num_fences < num_fences) return -EINVAL; @@ -435,8 +439,10 @@ static long sync_file_ioctl_fence_info(struct sync_file *sync_file, if (!fence_info) return -ENOMEM; - for (i = 0; i < num_fences; i++) - sync_fill_fence_info(fences[i], &fence_info[i]); + for (i = 0; i < num_fences; i++) { + int status = sync_fill_fence_info(fences[i], &fence_info[i]); + fences_status = fences_status <= 0 ? fences_status : status; + } if (copy_to_user(u64_to_user_ptr(info.sync_fence_info), fence_info, size)) { @@ -446,7 +452,7 @@ static long sync_file_ioctl_fence_info(struct sync_file *sync_file, no_fences: sync_file_get_name(sync_file, info.name, sizeof(info.name)); - info.status = dma_fence_is_signaled(sync_file->fence); + info.status = fences_status; info.num_fences = num_fences; if (copy_to_user((void __user *)arg, &info, sizeof(info))) -- 2.13.6

1 0

[PATCH v2 2/7] drm/rockchip: dw_hdmi: add device type
by Algea Cao 03 Oct '17

03 Oct '17

To determine type of SOC, we add a parameter dev_type. Signed-off-by: Algea Cao <algea.cao(a)rock-chips.com> --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 5 +++++ include/drm/bridge/dw_hdmi.h | 10 ++++++++++ 2 files changed, 15 insertions(+) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c index 719452d..09c77f9 100644 --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c @@ -46,6 +46,7 @@ struct rockchip_hdmi { struct regmap *regmap; struct drm_encoder encoder; const struct rockchip_hdmi_chip_data *chip_data; + enum dw_hdmi_devtype dev_type; struct clk *vpll_clk; struct clk *grf_clk; }; @@ -305,6 +306,7 @@ static const struct dw_hdmi_plat_data rk3288_hdmi_drv_data = { .cur_ctr = rockchip_cur_ctr, .phy_config = rockchip_phy_config, .phy_data = &rk3288_chip_data, + .dev_type = RK3288_HDMI, }; static struct rockchip_hdmi_chip_data rk3399_chip_data = { @@ -315,6 +317,7 @@ static struct rockchip_hdmi_chip_data rk3399_chip_data = { static const struct dw_hdmi_plat_data rk3328_hdmi_drv_data = { .mode_valid = dw_hdmi_rockchip_mode_valid, + .dev_type = RK3328_HDMI, }; static const struct dw_hdmi_plat_data rk3399_hdmi_drv_data = { .mode_valid = dw_hdmi_rockchip_mode_valid, @@ -322,6 +325,7 @@ static const struct dw_hdmi_plat_data rk3399_hdmi_drv_data = { .cur_ctr = rockchip_cur_ctr, .phy_config = rockchip_phy_config, .phy_data = &rk3399_chip_data, + .dev_type = RK3399_HDMI, }; static const struct of_device_id dw_hdmi_rockchip_dt_ids[] = { @@ -360,6 +364,7 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master, plat_data = match->data; hdmi->dev = &pdev->dev; hdmi->chip_data = plat_data->phy_data; + hdmi->dev_type = plat_data->dev_type; encoder = &hdmi->encoder; encoder->possible_crtcs = drm_of_find_possible_crtcs(drm, dev->of_node); diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h index 182f832..fdb1f0a 100644 --- a/include/drm/bridge/dw_hdmi.h +++ b/include/drm/bridge/dw_hdmi.h @@ -92,6 +92,15 @@ enum dw_hdmi_phy_type { DW_HDMI_PHY_VENDOR_PHY = 0xfe, }; +enum dw_hdmi_devtype { + RK3228_HDMI, + RK3288_HDMI, + RK3328_HDMI, + RK3366_HDMI, + RK3368_HDMI, + RK3399_HDMI, +}; + struct dw_hdmi_mpll_config { unsigned long mpixelclock; struct { @@ -124,6 +133,7 @@ struct dw_hdmi_phy_ops { struct dw_hdmi_plat_data { struct regmap *regm; + enum dw_hdmi_devtype dev_type; enum drm_mode_status (*mode_valid)(struct drm_connector *connector, const struct drm_display_mode *mode); unsigned long input_bus_format; -- 2.7.4

2 1

[PATCH] MAINTAINERS: Add dri-devel as a mailing list for anything fbdev
by Daniel Vetter 03 Oct '17

03 Oct '17

fbdev is in maintenance only, except that it's still used by drm through the drm fbdev emulation, to be able to use fbcon. And people might want to sometimes extend fbcon to enable new features for drm drivers, e.g. Hans' panel orientation work. The problem is that when those patches only touch fbdev code they'll never show up on drm developer's radar, which means we end up with designs that don't really fit whell into the full stack. That happened a bit with the panel orientation work, where an fbcon patch made it into 4.14, implementing a design that won't really work on the drm side. Which means we now have to redo things, and on top coordinate 2 subsystem trees. Since fbdev is super low-volume we can prevent this in the future by simply adding the dri-devel mailing list to the fbdev subsystem. Cc: Hans de Goede <hdegoede(a)redhat.com> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie(a)samsung.com> Cc: linux-fbdev(a)vger.kernel.org Cc: dri-devel(a)lists.freedesktop.org Cc: Sean Paul <seanpaul(a)chromium.org> Cc: David Airlie <airlied(a)linux.ie> Signed-off-by: Daniel Vetter <daniel.vetter(a)intel.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ba51d0906955..af9766a32949 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5391,6 +5391,7 @@ F: drivers/net/wan/sdla.c FRAMEBUFFER LAYER M: Bartlomiej Zolnierkiewicz <b.zolnierkie(a)samsung.com> +L: dri-devel(a)lists.freedesktop.org L: linux-fbdev(a)vger.kernel.org T: git git://github.com/bzolnier/linux.git Q: http://patchwork.kernel.org/project/linux-fbdev/list/ -- 2.14.1

4 4

[PATCH v5 0/4] drm/tinydrm: drm_of_find_backlight helper
by Meghana Madhyastha 03 Oct '17

03 Oct '17

This patchset introduces some changes such as move tinydrm_of_find_backlight to drm_of.c and rename it to drm_of_find_backlight for better organizational structure. Changes in v5: -Fix kbuild errors and warnings Meghana Madhyastha (4): drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c drm/tinydrm: Add devres versions of drm_of_find_backlight drm/tinydrm: Add the dummy versions of drm_of_find_backlight functions drm/tinydrm: select BACKLIGHT_LCD_SUPPORT, BACKLIGHT_CLASS_DEVICE drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/drm_of.c | 91 ++++++++++++++++++++++++++ drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | 40 ----------- drivers/gpu/drm/tinydrm/mi0283qt.c | 3 +- include/drm/drm_of.h | 15 +++++ include/drm/tinydrm/tinydrm-helpers.h | 1 - 6 files changed, 110 insertions(+), 42 deletions(-) -- 2.7.4

4 9

[Bug 93199] IGT: Couldn't map MMIO region
by bugzilla-daemon＠freedesktop.org 02 Oct '17

02 Oct '17

https://bugs.freedesktop.org/show_bug.cgi?id=93199 --- Comment #25 from oskar(a)cetex.se --- Forgot to mention this is ubuntu 17.04 and i intel-gpu-tools are version 1.17-1 -- You are receiving this mail because: You are the assignee for the bug.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel October 2017