dri-devel October 2017

dri-devel@lists.freedesktop.org

228 participants
1625 discussions

[PULL] drm-misc-next
by Daniel Vetter 05 Oct '17

05 Oct '17

Hi Dave, drm-misc-next-2017-10-05: More drm-misc for 4.15: Cross-subsystem Changes: - bunch more simple outreachy patches (Meghana Madhyastha, Aishwarya Pant, Haneen Mohammed) - Quite a pile of static checker/cocci/spelling fixups all over. - Final driver patches+core cleanup of Noralf's new drm_gem_fb_create helper. Core Changes: - legacy DPMS docs improved - add dri-devel m-l to fbdev to catch people who try to fix fbcon-on-kms bugs in the wrong place Driver Changes: - vc4: prep … [View More]for dsi panels (Eric) Also one backmerge to catch up with 4.14. Aside: I think Sean is moving this week, if so I'll send you a -fixes pull later today since there's 1 patch there. Cheers, Daniel The following changes since commit ebec44a2456fbe5fe18aae88f6010f6878f0cb4a: BackMerge tag 'v4.14-rc3' into drm-next (2017-10-03 09:35:04 +1000) are available in the git repository at: git://anongit.freedesktop.org/git/drm-misc tags/drm-misc-next-2017-10-05 for you to fetch changes up to 5b9fbfff7644f2d3f42a6c105587b86e29ca9c48: drm: fix typo in drm_gem_get_pages() comment (2017-10-04 18:04:28 +0200) ---------------------------------------------------------------- More drm-misc for 4.15: Cross-subsystem Changes: - bunch more simple outreachy patches (Meghana Madhyastha, Aishwarya Pant, Haneen Mohammed) - Quite a pile of static checker/cocci/spelling fixups all over. - Final driver patches+core cleanup of Noralf's new drm_gem_fb_create helper. Core Changes: - legacy DPMS docs improved - add dri-devel m-l to fbdev to catch people who try to fix fbcon-on-kms bugs in the wrong place Driver Changes: - vc4: prep for dsi panels (Eric) ---------------------------------------------------------------- Aishwarya Pant (3): drm: introduce drm_dev_{get/put} functions drm/tilcdc: replace reference/unreference() with get/put drm/core: clean up references to drm_dev_unref() Colin Ian King (2): dma-buf: remove redundant initialization of sg_table drm/tve200: make two functions static Dan Carpenter (2): drm/tve200: Check for IS_ERR instead of NULL in probe drm: of: always initialize panel in drm_of_find_panel_or_bridge() Daniel Vetter (3): drm: Try to document legacy DPMS uapi a bit better Merge airlied/drm-next into drm-misc-next MAINTAINERS: Add dri-devel as a mailing list for anything fbdev Eric Anholt (2): drm/vc4: Avoid using vrefresh==0 mode in DSI htotal math. drm/vc4: Set up the DSI host at pdev probe time, not component bind. Haneen Mohammed (4): drm: Remove obsolete "This is gross" comment drm/doc: Remove todo item about "This is gross" comment drm/rockchip: Rely on the default best_encoder() behavior drm/armada: Remove unused #include <drmP.h> Jordan Crouse (1): drm: fix typo in drm_gem_get_pages() comment Meghana Madhyastha (5): drm/agpsupport: Replace "foo * bar" with "foo *bar" drm/agpsupport: Remove assignment in if condition drm/agpsupport: Move EXPORT_SYMBOL so that it immediately follows its function drm/agpsupport: Remove extra blank line drm/Documentation: Refine TODO for backlight helpers in tinydrm Noralf Trønnes (10): drm/tinydrm: Use drm_gem_framebuffer_helper drm/fsl-dcu: Use drm_gem_fb_create() drm/hisilicon/kirin: Use drm_gem_fb_create() drm/meson: Use drm_gem_fb_create() drm/mxsfb: Use drm_gem_fb_create() and drm_gem_fb_prepare_fb() drm/rcar-du: Use drm_gem_fb_create() drm/shmobile: Use drm_gem_fb_create() drm/sun4i: Use drm_gem_fb_create() drm/tve200: Use drm_gem_fb_create() and drm_gem_fb_prepare_fb() drm/fb-cma-helper: Remove unused functions Sean Paul (1): drm/rockchip: Fix uninitialized use of ret Srishti Sharma (1): drm/virtio: Replace instances of reference/unreference with get/put Thomas Meyer (1): drm/rockchip: Cocci spatch "vma_pages" Documentation/gpu/todo.rst | 17 ++-- MAINTAINERS | 1 + drivers/dma-buf/dma-buf.c | 2 +- drivers/gpu/drm/armada/armada_510.c | 1 - drivers/gpu/drm/armada/armada_drv.c | 1 - drivers/gpu/drm/armada/armada_fb.c | 1 - drivers/gpu/drm/armada/armada_fbdev.c | 1 - drivers/gpu/drm/armada/armada_gem.c | 1 - drivers/gpu/drm/drm_agpsupport.c | 45 +++++------ drivers/gpu/drm/drm_connector.c | 23 ++++++ drivers/gpu/drm/drm_drv.c | 51 +++++++----- drivers/gpu/drm/drm_fb_cma_helper.c | 77 +----------------- drivers/gpu/drm/drm_gem.c | 11 +-- drivers/gpu/drm/drm_of.c | 2 + drivers/gpu/drm/drm_pci.c | 2 +- drivers/gpu/drm/drm_prime.c | 4 +- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c | 3 +- drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 3 +- drivers/gpu/drm/meson/meson_drv.c | 3 +- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 5 +- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 3 +- drivers/gpu/drm/rockchip/cdn-dp-core.c | 9 --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 2 +- drivers/gpu/drm/rockchip/rockchip_lvds.c | 11 ++- drivers/gpu/drm/shmobile/shmob_drm_kms.c | 3 +- drivers/gpu/drm/sun4i/sun4i_framebuffer.c | 3 +- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 6 +- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 3 +- drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 5 +- drivers/gpu/drm/tinydrm/mipi-dbi.c | 5 +- drivers/gpu/drm/tinydrm/repaper.c | 5 +- drivers/gpu/drm/tinydrm/st7586.c | 5 +- drivers/gpu/drm/tve200/tve200_display.c | 7 +- drivers/gpu/drm/tve200/tve200_drv.c | 5 +- drivers/gpu/drm/vc4/vc4_dsi.c | 100 ++++++++++++++---------- drivers/gpu/drm/virtio/virtgpu_display.c | 4 +- drivers/gpu/drm/virtio/virtgpu_gem.c | 4 +- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 12 +-- include/drm/drm_drv.h | 5 +- include/drm/drm_fb_cma_helper.h | 13 --- scripts/coccinelle/api/drm-get-put.cocci | 5 ++ 42 files changed, 225 insertions(+), 246 deletions(-) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch [View Less]

1 0

[PATCH] cma: Take __GFP_NOWARN into account in cma_alloc()
by Boris Brezillon 05 Oct '17

05 Oct '17

cma_alloc() unconditionally prints an INFO message when the CMA allocation fails. Make this message conditional on the non-presence of __GFP_NOWARN in gfp_mask. Signed-off-by: Boris Brezillon <boris.brezillon(a)free-electrons.com> --- Hello, This patch aims at removing INFO messages that are displayed when the VC4 driver tries to allocate buffer objects. From the driver perspective an allocation failure is acceptable, and the driver can possibly do something to make following allocation … [View More]

4 3

[Bug 96868] AMDGPU Tonga only does 2560x1440 at 120hz, switching to 144hz causes display errors, same thing used to happen with fglrx.
by bugzilla-daemon＠freedesktop.org 04 Oct '17

04 Oct '17

https://bugs.freedesktop.org/show_bug.cgi?id=96868 --- Comment #32 from Markus-Germann(a)web.de --- I wanted to add a comment, because I'm also affected with a slightly different setup then most of the users that posted here. I have a Radeon R9 390, use an up-to-date Arch Linux (Kernel 4.13.3-1-ARCH with xf86-video-amdgpu 1.4.0) but with only a 60Hz screen with therefore a 4K/HiDPI screen (resolution 3840x2160). I also have lots of flickering and artefacts. The problem is solved setting the … [View More]

1 0

[Bug 103080] DC driver from drm-next-4.15-dc branch (upstream PR) not working
by bugzilla-daemon＠freedesktop.org 04 Oct '17

04 Oct '17

https://bugs.freedesktop.org/show_bug.cgi?id=103080 --- Comment #3 from Harry Wentland <harry.wentland(a)amd.com> --- We've got a fix incoming in a day or two for that kernel oops with the next set of DC patches. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH v2] drm/tinydrm: Replace dev_error with DRM_DEV_ERROR
by Harsha Sharma 04 Oct '17

04 Oct '17

Convert instances of dev_error to DRM_DEV_ERROR as we have DRM_DEV_ERROR variants of drm print macros. Signed-off-by: Harsha Sharma <harshasharmaiitr(a)gmail.com> --- Changes in v2: -Fix alignment issues drivers/gpu/drm/tinydrm/mi0283qt.c | 8 ++++---- drivers/gpu/drm/tinydrm/repaper.c | 26 +++++++++++++------------- drivers/gpu/drm/tinydrm/st7586.c | 6 +++--- 3 files changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/tinydrm/mi0283qt.c b/drivers/gpu/drm/… [View More]tinydrm/mi0283qt.c index 7e5bb7d..7dded50 100644 --- a/drivers/gpu/drm/tinydrm/mi0283qt.c +++ b/drivers/gpu/drm/tinydrm/mi0283qt.c @@ -31,7 +31,7 @@ static int mi0283qt_init(struct mipi_dbi *mipi) ret = regulator_enable(mipi->regulator); if (ret) { - dev_err(dev, "Failed to enable regulator %d\n", ret); + DRM_DEV_ERROR(dev, "Failed to enable regulator %d\n", ret); return ret; } @@ -42,7 +42,7 @@ static int mi0283qt_init(struct mipi_dbi *mipi) mipi_dbi_hw_reset(mipi); ret = mipi_dbi_command(mipi, MIPI_DCS_SOFT_RESET); if (ret) { - dev_err(dev, "Error sending command %d\n", ret); + DRM_DEV_ERROR(dev, "Error sending command %d\n", ret); regulator_disable(mipi->regulator); return ret; } @@ -175,13 +175,13 @@ static int mi0283qt_probe(struct spi_device *spi) mipi->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(mipi->reset)) { - dev_err(dev, "Failed to get gpio 'reset'\n"); + DRM_DEV_ERROR(dev, "Failed to get gpio 'reset'\n"); return PTR_ERR(mipi->reset); } dc = devm_gpiod_get_optional(dev, "dc", GPIOD_OUT_LOW); if (IS_ERR(dc)) { - dev_err(dev, "Failed to get gpio 'dc'\n"); + DRM_DEV_ERROR(dev, "Failed to get gpio 'dc'\n"); return PTR_ERR(dc); } diff --git a/drivers/gpu/drm/tinydrm/repaper.c b/drivers/gpu/drm/tinydrm/repaper.c index 30dc97b..bd152bb 100644 --- a/drivers/gpu/drm/tinydrm/repaper.c +++ b/drivers/gpu/drm/tinydrm/repaper.c @@ -473,7 +473,7 @@ static void repaper_get_temperature(struct repaper_epd *epd) ret = thermal_zone_get_temp(epd->thermal, &temperature); if (ret) { - dev_err(&epd->spi->dev, "Failed to get temperature (%d)\n", + DRM_DEV_ERROR(&epd->spi->dev, "Failed to get temperature (%d)\n", ret); return; } @@ -629,7 +629,7 @@ static int repaper_fb_dirty(struct drm_framebuffer *fb, mutex_unlock(&tdev->dirty_lock); if (ret) - dev_err(fb->dev->dev, "Failed to update display (%d)\n", ret); + DRM_DEV_ERROR(fb->dev->dev, "Failed to update display (%d)\n", ret); kfree(buf); return ret; @@ -703,7 +703,7 @@ static void repaper_pipe_enable(struct drm_simple_display_pipe *pipe, } if (!i) { - dev_err(dev, "timeout waiting for panel to become ready.\n"); + DRM_DEV_ERROR(dev, "timeout waiting for panel to become ready.\n"); power_off(epd); return; } @@ -725,9 +725,9 @@ static void repaper_pipe_enable(struct drm_simple_display_pipe *pipe, ret = repaper_read_val(spi, 0x0f); if (ret < 0 || !(ret & 0x80)) { if (ret < 0) - dev_err(dev, "failed to read chip (%d)\n", ret); + DRM_DEV_ERROR(dev, "failed to read chip (%d)\n", ret); else - dev_err(dev, "panel is reported broken\n"); + DRM_DEV_ERROR(dev, "panel is reported broken\n"); power_off(epd); return; } @@ -767,7 +767,7 @@ static void repaper_pipe_enable(struct drm_simple_display_pipe *pipe, /* check DC/DC */ ret = repaper_read_val(spi, 0x0f); if (ret < 0) { - dev_err(dev, "failed to read chip (%d)\n", ret); + DRM_DEV_ERROR(dev, "failed to read chip (%d)\n", ret); power_off(epd); return; } @@ -779,7 +779,7 @@ static void repaper_pipe_enable(struct drm_simple_display_pipe *pipe, } if (!dc_ok) { - dev_err(dev, "dc/dc failed\n"); + DRM_DEV_ERROR(dev, "dc/dc failed\n"); power_off(epd); return; } @@ -959,7 +959,7 @@ static int repaper_probe(struct spi_device *spi) if (IS_ERR(epd->panel_on)) { ret = PTR_ERR(epd->panel_on); if (ret != -EPROBE_DEFER) - dev_err(dev, "Failed to get gpio 'panel-on'\n"); + DRM_DEV_ERROR(dev, "Failed to get gpio 'panel-on'\n"); return ret; } @@ -967,7 +967,7 @@ static int repaper_probe(struct spi_device *spi) if (IS_ERR(epd->discharge)) { ret = PTR_ERR(epd->discharge); if (ret != -EPROBE_DEFER) - dev_err(dev, "Failed to get gpio 'discharge'\n"); + DRM_DEV_ERROR(dev, "Failed to get gpio 'discharge'\n"); return ret; } @@ -975,7 +975,7 @@ static int repaper_probe(struct spi_device *spi) if (IS_ERR(epd->reset)) { ret = PTR_ERR(epd->reset); if (ret != -EPROBE_DEFER) - dev_err(dev, "Failed to get gpio 'reset'\n"); + DRM_DEV_ERROR(dev, "Failed to get gpio 'reset'\n"); return ret; } @@ -983,7 +983,7 @@ static int repaper_probe(struct spi_device *spi) if (IS_ERR(epd->busy)) { ret = PTR_ERR(epd->busy); if (ret != -EPROBE_DEFER) - dev_err(dev, "Failed to get gpio 'busy'\n"); + DRM_DEV_ERROR(dev, "Failed to get gpio 'busy'\n"); return ret; } @@ -991,7 +991,7 @@ static int repaper_probe(struct spi_device *spi) &thermal_zone)) { epd->thermal = thermal_zone_get_zone_by_name(thermal_zone); if (IS_ERR(epd->thermal)) { - dev_err(dev, "Failed to get thermal zone: %s\n", + DRM_DEV_ERROR(dev, "Failed to get thermal zone: %s\n", thermal_zone); return PTR_ERR(epd->thermal); } @@ -1033,7 +1033,7 @@ static int repaper_probe(struct spi_device *spi) if (IS_ERR(epd->border)) { ret = PTR_ERR(epd->border); if (ret != -EPROBE_DEFER) - dev_err(dev, "Failed to get gpio 'border'\n"); + DRM_DEV_ERROR(dev, "Failed to get gpio 'border'\n"); return ret; } diff --git a/drivers/gpu/drm/tinydrm/st7586.c b/drivers/gpu/drm/tinydrm/st7586.c index b439956..14361a5 100644 --- a/drivers/gpu/drm/tinydrm/st7586.c +++ b/drivers/gpu/drm/tinydrm/st7586.c @@ -187,7 +187,7 @@ static void st7586_pipe_enable(struct drm_simple_display_pipe *pipe, mipi_dbi_hw_reset(mipi); ret = mipi_dbi_command(mipi, ST7586_AUTO_READ_CTRL, 0x9f); if (ret) { - dev_err(dev, "Error sending command %d\n", ret); + DRM_DEV_ERROR(dev, "Error sending command %d\n", ret); return; } @@ -355,13 +355,13 @@ static int st7586_probe(struct spi_device *spi) mipi->reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(mipi->reset)) { - dev_err(dev, "Failed to get gpio 'reset'\n"); + DRM_DEV_ERROR(dev, "Failed to get gpio 'reset'\n"); return PTR_ERR(mipi->reset); } a0 = devm_gpiod_get(dev, "a0", GPIOD_OUT_LOW); if (IS_ERR(a0)) { - dev_err(dev, "Failed to get gpio 'a0'\n"); + DRM_DEV_ERROR(dev, "Failed to get gpio 'a0'\n"); return PTR_ERR(a0); } -- 1.9.1 [View Less]

2 1

[PATCH 0/8] drm/tinydrm: Use vmalloc BO
by Noralf Trønnes 04 Oct '17

04 Oct '17

This patchset adds a library for vmalloc buffer objects and makes use of it in tinydrm. The reason I want to move away from the cma helper, is that it restricts which drivers to PRIME import from, since cma requires the buffer to be physically continuous. Initially I looked at udl and decided to use shmem, but have later decided against it since shmem doesn't work with fbdev deferred I/O, they both use page->lru and page->mapping. This meant adding a shadow buffer for fbdev with … [View More]increased complexity, so I fell back to the KISS principle. I'm trying to make tinydrm support drivers like simpledrm and udl, so if using vmalloc blocks those use cases, please let me know. I will do a follow up for the cma library which removes struct drm_fbdev_cma and wrappers. Noralf. Noralf Trønnes (8): drm/fb-helper: Handle function NULL argument drm: Add drm_device->fbdev pointer drm/fb-helper: Add simple init/fini functions drm/fb-helper: Add .last_close and .output_poll_changed helpers drm/gem-fb-helper: Add drm_gem_fb_debugfs_show() drm: Add vmalloc BO helper drm/tinydrm: Use drm_vmalloc_bo drm/tinydrm: Relax buffer line prefetch Documentation/gpu/drm-kms-helpers.rst | 12 + drivers/gpu/drm/Kconfig | 7 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_fb_helper.c | 223 +++++++++++++++++- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 45 ++++ drivers/gpu/drm/drm_vmalloc_bo_helper.c | 305 +++++++++++++++++++++++++ drivers/gpu/drm/tinydrm/Kconfig | 2 +- drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 134 +++-------- drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | 56 +++-- drivers/gpu/drm/tinydrm/mi0283qt.c | 8 +- drivers/gpu/drm/tinydrm/mipi-dbi.c | 12 +- drivers/gpu/drm/tinydrm/repaper.c | 12 +- drivers/gpu/drm/tinydrm/st7586.c | 14 +- include/drm/drm_device.h | 8 + include/drm/drm_fb_helper.h | 32 +++ include/drm/drm_gem_framebuffer_helper.h | 6 + include/drm/drm_vmalloc_bo_helper.h | 88 +++++++ include/drm/tinydrm/mipi-dbi.h | 2 + include/drm/tinydrm/tinydrm.h | 38 +-- 19 files changed, 811 insertions(+), 194 deletions(-) create mode 100644 drivers/gpu/drm/drm_vmalloc_bo_helper.c create mode 100644 include/drm/drm_vmalloc_bo_helper.h -- 2.7.4 [View Less]

1 8

[Bug 99841] Switching to VT freezes X only on a dual screen
by bugzilla-daemon＠freedesktop.org 04 Oct '17

04 Oct '17

https://bugs.freedesktop.org/show_bug.cgi?id=99841 mattia.b89 <mattia.b89(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #23 from mattia.b89 <mattia.b89(a)gmail.com> --- I cannot reproduce it. That patch has already been merged upstream, maybe? -- … [View More]

1 0

[PATCH] drm: use size_t variables to iterate through pages
by Jordan Crouse 04 Oct '17

04 Oct '17

drm_gem_get_pages() and drm_gem_put_pages() calculate the number of pages to operate on from obj->size which is a size_t. Use similarly sized variables to calculate and iterate through the pages to avoid possibly losing bits from the page calculation. Signed-off-by: Jordan Crouse <jcrouse(a)codeaurora.org> --- drivers/gpu/drm/drm_gem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index af62017..a8c146d … [View More]

2 1

[Bug 102796] steam not rendering correctly on VEGA 56
by bugzilla-daemon＠freedesktop.org 04 Oct '17

04 Oct '17

https://bugs.freedesktop.org/show_bug.cgi?id=102796 Bug ID: 102796 Summary: steam not rendering correctly on VEGA 56 Product: DRI Version: XOrg git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: tomenglund26(a)gmail.com im using amd-staging-4.12 … [View More]

1 4

[Bug 97059] Tahiti+DRI3+Unity+Blender corruption
by bugzilla-daemon＠freedesktop.org 04 Oct '17

04 Oct '17

https://bugs.freedesktop.org/show_bug.cgi?id=97059 Bug ID: 97059 Summary: Tahiti+DRI3+Unity+Blender corruption Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel(a)lists.freedesktop.org Reporter: eunbolt(a)gmail.com QA Contact: dri-devel(a)… [View More]

1 15

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel October 2017