dri-devel November 2017

dri-devel@lists.freedesktop.org

243 participants
1622 discussions

[PATCH 1/4] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 00h-0fh) Processors
by Christian König 03 Nov '17

03 Nov '17

From: Christian König <christian.koenig(a)amd.com> Just add the extra PCI-ID to the existing fixup. Signed-off-by: Christian König <christian.koenig(a)amd.com> --- arch/x86/pci/fixup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/pci/fixup.c b/arch/x86/pci/fixup.c index 7b6bd76..1d2238d 100644 --- a/arch/x86/pci/fixup.c +++ b/arch/x86/pci/fixup.c @@ -639,7 +639,7 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x8c10, quirk_apple_mbp_poweroff); * configuring host bridge windows using the _PRS and _SRS methods. * * But this is rarely implemented, so we manually enable a large 64bit BAR for - * PCIe device on AMD Family 15h (Models 30h-3fh) Processors here. + * PCIe device on AMD Family 15h (Models 00h-0fh, 30h-3fh) Processors here. */ static void pci_amd_enable_64bit_bar(struct pci_dev *dev) { @@ -696,5 +696,6 @@ static void pci_amd_enable_64bit_bar(struct pci_dev *dev) pci_bus_add_resource(dev->bus, res, 0); } DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_AMD, 0x141b, pci_amd_enable_64bit_bar); +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_AMD, 0x1601, pci_amd_enable_64bit_bar); #endif -- 2.7.4

1 0

[Advice Needed] splash on i.MX IPU
by Stephan Bauroth 03 Nov '17

03 Nov '17

Dear dri-devel, spec. Dear i.MX folks, I would like to display a splash screen on an i.MX6 based board from the kernel as soon as the display hardware is initialized. But I'm having trouble finding some kind of 'take this buffer and display it' function within the IPU driver. (And I see no way of specifying such thing within the device tree) I tried to trace a userspace write to /dev/fb0 to see where it ends up, but didn't succeed in finding the right entry point. I am aware of the fact that the bootloader typically displays a splash and linux then doesn't touch it, but this solution is not feasible for me, mostly because it would include duplicating the functionality of a display driver when the kernel offers a working one. Has anybody built a splash from the kernel before? Or can anyone give me a few pointers where to look for a start within the driver? Any help is appreciated. regards, Stephan

2 2

[Bug 103550] system boots really slow with 4.9.x kernel or greater (tested on 4.14 rc7)
by bugzilla-daemon＠freedesktop.org 03 Nov '17

03 Nov '17

1 0

[PATCH] drm/amdgpu/virt: don't dereference undefined 'module' struct
by Arnd Bergmann 03 Nov '17

03 Nov '17

Accessing the THIS_MODULE directly is only possible when modules are enabled, otherwise we get a build failure: drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c: In function 'amdgpu_virt_init_data_exchange': drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:331:20: error: dereferencing pointer to incomplete type 'struct module' Further, THIS_MODULE is NULL when the driver is built-in, so the code would likely cause a NULL pointer dereference. This adds an #ifdef check to avoid the compile-time error, plus a NULL pointer check before dereferencing THIS_MODULE. It might be better to find a way to avoid using the module version altogether. Fixes: 2dc8f81e4f82 ("drm/amdgpu: SR-IOV data exchange between PF&VF") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c index e97f80f86005..4e4a476593e8 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c @@ -328,9 +328,11 @@ void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev) sizeof(amdgim_vf2pf_info)); AMDGPU_FW_VRAM_VF2PF_READ(adev, driver_version, &str); +#ifdef MODULE if (THIS_MODULE->version != NULL) strcpy(str, THIS_MODULE->version); else +#endif strcpy(str, "N/A"); AMDGPU_FW_VRAM_VF2PF_WRITE(adev, driver_cert, 0); -- 2.9.0

4 3

[git pull] drm fixes for v4.14-rc8
by Dave Airlie 03 Nov '17

03 Nov '17

Hi Linus, One nouveau regression fix, Some amdgpu fixes for stable to fix hangs on some harvested Polaris GPUs A set of KASAN and regression fixes for i915, their CI system seems to be working pretty well now. Dave. The following changes since commit 0b07194bb55ed836c2cc7c22e866b87a14681984: Linux 4.14-rc7 (2017-10-29 13:58:38 -0700) are available in the git repository at: git://people.freedesktop.org/~airlied/linux tags/drm-fixes-for-v4.14-rc8 for you to fetch changes up to 9cc06965fc8b7c5592b6a1355dff2623611bfeb3: Merge branch 'drm-fixes-4.14' of git://people.freedesktop.org/~agd5f/linux into drm-fixes (2017-11-02 14:40:12 +1000) ---------------------------------------------------------------- i915, amdgpu and nouveau fixes ---------------------------------------------------------------- Ben Skeggs (1): drm/nouveau/kms/nv50: use the correct state for base channel notifier setup Chris Wilson (3): drm/i915: Hold rcu_read_lock when iterating over the radixtree (objects) drm/i915: Hold rcu_read_lock when iterating over the radixtree (vma idr) drm/i915: Check incoming alignment for unfenced buffers (on i915gm) Dave Airlie (3): Merge branch 'linux-4.14' of git://github.com/skeggsb/linux into drm-fixes Merge tag 'drm-intel-fixes-2017-11-01' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes Merge branch 'drm-fixes-4.14' of git://people.freedesktop.org/~agd5f/linux into drm-fixes Jani Nikula (1): drm/i915/edp: read edp display control registers unconditionally Leo Liu (2): drm/amdgpu: return -ENOENT from uvd 6.0 early init for harvesting drm/amdgpu: allow harvesting check for Polaris VCE Maarten Lankhorst (1): drm/i915: Do not rely on wm preservation for ILK watermarks Manasi Navare (1): drm/i915: Cancel the modeset retry work during modeset cleanup drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 4 +++ drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 12 +++---- drivers/gpu/drm/i915/i915_gem.c | 2 ++ drivers/gpu/drm/i915/i915_gem_context.c | 2 ++ drivers/gpu/drm/i915/i915_gem_execbuffer.c | 4 +++ drivers/gpu/drm/i915/intel_display.c | 19 ++++++++++- drivers/gpu/drm/i915/intel_dp.c | 13 ++++++-- drivers/gpu/drm/i915/intel_drv.h | 1 - drivers/gpu/drm/i915/intel_pm.c | 51 ++++++++++++------------------ drivers/gpu/drm/nouveau/nv50_display.c | 6 ++-- 10 files changed, 70 insertions(+), 44 deletions(-)

1 0

[PATCH libdrm] Android: update CleanSpec.mk
by Chih-Wei Huang 03 Nov '17

03 Nov '17

The libraries are moved to /vendor since commit 011fd913. Clean all old files for incremental builds. Fixes: 011fd913 (Android: move libraries to /vendor) Signed-off-by: Chih-Wei Huang <cwhuang(a)linux.org.tw> --- CleanSpec.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CleanSpec.mk b/CleanSpec.mk index 28a11db4..29d3f671 100644 --- a/CleanSpec.mk +++ b/CleanSpec.mk @@ -2,3 +2,5 @@ $(call add-clean-step, rm -rf $(PRODUCT_OUT)/obj/include/libdrm) $(call add-clean-step, rm -rf $(PRODUCT_OUT)/obj/include/freedreno) $(call add-clean-step, rm -rf $(PRODUCT_OUT)/obj/SHARED_LIBRARIES/libdrm_*intermediates) $(call add-clean-step, rm -rf $(PRODUCT_OUT)/obj/STATIC_LIBRARIES/libdrm_*intermediates) +$(call add-clean-step, rm -rf $(TARGET_OUT)/lib*/libdrm[._]*) +$(call add-clean-step, rm -rf $(TARGET_OUT_ETC)/hwdata/amdgpu.ids) -- 2.13.6

1 0

[PATCH 4.9.y 3/3] drm/bridge: adv7511: Re-write the i2c address before EDID probing
by Nhan Nguyen 03 Nov '17

03 Nov '17

From: John Stultz <john.stultz(a)linaro.org> commit 3587c856675c45809010c2cee5b21096f6e8e938 upstream. I've found that by just turning the chip on and off via the POWER_DOWN register, I end up getting i2c_transfer errors on HiKey. Investigating further, it turns out that some of the register state in hardware is getting lost, as the device registers are reset when the chip is powered down. Thus this patch simply re-writes the i2c address to the ADV7511_REG_EDID_I2C_ADDR register to ensure its properly set before we try to read the EDID data. Cc: David Airlie <airlied(a)linux.ie> Cc: Archit Taneja <architt(a)codeaurora.org> Cc: Wolfram Sang <wsa+renesas(a)sang-engineering.com> Cc: Lars-Peter Clausen <lars(a)metafoo.de> Cc: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> Cc: dri-devel(a)lists.freedesktop.org Cc: stable(a)vger.kernel.org Reviewed-by: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> Tested-by: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> Signed-off-by: John Stultz <john.stultz(a)linaro.org> Signed-off-by: Archit Taneja <architt(a)codeaurora.org> Signed-off-by: Thong Ho <thong.ho.px(a)rvc.renesas.com> Signed-off-by: Nhan Nguyen <nhan.nguyen.yb(a)renesas.com> Link: http://patchwork.freedesktop.org/patch/msgid/1484614372-15342-7-git-send-em… --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index 17b9e98..f75ab62 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -573,9 +573,17 @@ static int adv7511_get_modes(struct adv7511 *adv7511, unsigned int count; /* Reading the EDID only works if the device is powered */ - if (!adv7511->powered) + if (!adv7511->powered) { + unsigned int edid_i2c_addr = + (adv7511->i2c_main->addr << 1) + 4; + __adv7511_power_on(adv7511); + /* Reset the EDID_I2C_ADDR register as it might be cleared */ + regmap_write(adv7511->regmap, ADV7511_REG_EDID_I2C_ADDR, + edid_i2c_addr); + } + edid = drm_do_get_edid(connector, adv7511_get_edid_block, adv7511); if (!adv7511->powered) -- 2.7.4

1 0

[PATCH 4.9.y 2/3] drm/bridge: adv7511: Reuse __adv7511_power_on/off() when probing EDID
by Nhan Nguyen 03 Nov '17

03 Nov '17

From: John Stultz <john.stultz(a)linaro.org> commit 4226d9b127cf4758ba0e07931b3f0d59f1b1a50c upstream. Thus this patch changes the EDID probing logic so that we re-use the __adv7511_power_on/off() calls instead of duplciating logic. This does change behavior slightly as it adds the HPD signal pulse to the EDID probe path, but Archit has had a patch to add HPD signal pulse to the EDID probe path before, so this should address the cases where that helped. Another difference is that regcache_mark_dirty() is also called in the power off path once EDID is probed. Cc: David Airlie <airlied(a)linux.ie> Cc: Archit Taneja <architt(a)codeaurora.org> Cc: Wolfram Sang <wsa+renesas(a)sang-engineering.com> Cc: Lars-Peter Clausen <lars(a)metafoo.de> Cc: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> Cc: dri-devel(a)lists.freedesktop.org Cc: stable(a)vger.kernel.org Reviewed-by: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> Tested-by: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> Signed-off-by: John Stultz <john.stultz(a)linaro.org> Signed-off-by: Archit Taneja <architt(a)codeaurora.org> Signed-off-by: Thong Ho <thong.ho.px(a)rvc.renesas.com> Signed-off-by: Nhan Nguyen <nhan.nguyen.yb(a)renesas.com> Link: http://patchwork.freedesktop.org/patch/msgid/1484614372-15342-6-git-send-em… --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index 545ceff..17b9e98 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -573,24 +573,13 @@ static int adv7511_get_modes(struct adv7511 *adv7511, unsigned int count; /* Reading the EDID only works if the device is powered */ - if (!adv7511->powered) { - regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER, - ADV7511_POWER_POWER_DOWN, 0); - if (adv7511->i2c_main->irq) { - regmap_write(adv7511->regmap, ADV7511_REG_INT_ENABLE(0), - ADV7511_INT0_EDID_READY); - regmap_write(adv7511->regmap, ADV7511_REG_INT_ENABLE(1), - ADV7511_INT1_DDC_ERROR); - } - adv7511->current_edid_segment = -1; - } + if (!adv7511->powered) + __adv7511_power_on(adv7511); edid = drm_do_get_edid(connector, adv7511_get_edid_block, adv7511); if (!adv7511->powered) - regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER, - ADV7511_POWER_POWER_DOWN, - ADV7511_POWER_POWER_DOWN); + __adv7511_power_off(adv7511); kfree(adv7511->edid); adv7511->edid = edid; -- 2.7.4

1 0

[PATCH] drm/savage/savage_state: mark expected switch fall-throughs
by Gustavo A. R. Silva 02 Nov '17

02 Nov '17

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114735 Addresses-Coverity-ID: 114736 Addresses-Coverity-ID: 114737 Addresses-Coverity-ID: 114738 Signed-off-by: Gustavo A. R. Silva <garsilva(a)embeddedor.com> --- drivers/gpu/drm/savage/savage_state.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/savage/savage_state.c b/drivers/gpu/drm/savage/savage_state.c index 2db89be..0d13d60 100644 --- a/drivers/gpu/drm/savage/savage_state.c +++ b/drivers/gpu/drm/savage/savage_state.c @@ -299,6 +299,7 @@ static int savage_dispatch_dma_prim(drm_savage_private_t * dev_priv, case SAVAGE_PRIM_TRILIST_201: reorder = 1; prim = SAVAGE_PRIM_TRILIST; + /* fall through */ case SAVAGE_PRIM_TRILIST: if (n % 3 != 0) { DRM_ERROR("wrong number of vertices %u in TRILIST\n", @@ -436,6 +437,7 @@ static int savage_dispatch_vb_prim(drm_savage_private_t * dev_priv, case SAVAGE_PRIM_TRILIST_201: reorder = 1; prim = SAVAGE_PRIM_TRILIST; + /* fall through */ case SAVAGE_PRIM_TRILIST: if (n % 3 != 0) { DRM_ERROR("wrong number of vertices %u in TRILIST\n", @@ -557,6 +559,7 @@ static int savage_dispatch_dma_idx(drm_savage_private_t * dev_priv, case SAVAGE_PRIM_TRILIST_201: reorder = 1; prim = SAVAGE_PRIM_TRILIST; + /* fall through */ case SAVAGE_PRIM_TRILIST: if (n % 3 != 0) { DRM_ERROR("wrong number of indices %u in TRILIST\n", n); @@ -695,6 +698,7 @@ static int savage_dispatch_vb_idx(drm_savage_private_t * dev_priv, case SAVAGE_PRIM_TRILIST_201: reorder = 1; prim = SAVAGE_PRIM_TRILIST; + /* fall through */ case SAVAGE_PRIM_TRILIST: if (n % 3 != 0) { DRM_ERROR("wrong number of indices %u in TRILIST\n", n); -- 2.7.4

1 0

[PATCH] drm/via/via_dmablit: mark expected switch fall-throughs
by Gustavo A. R. Silva 02 Nov '17

02 Nov '17

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114740 Addresses-Coverity-ID: 114741 Addresses-Coverity-ID: 114742 Addresses-Coverity-ID: 114743 Signed-off-by: Gustavo A. R. Silva <garsilva(a)embeddedor.com> --- drivers/gpu/drm/via/via_dmablit.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/via/via_dmablit.c b/drivers/gpu/drm/via/via_dmablit.c index 98aae98..d3ff3ec 100644 --- a/drivers/gpu/drm/via/via_dmablit.c +++ b/drivers/gpu/drm/via/via_dmablit.c @@ -177,12 +177,14 @@ via_free_sg_info(struct pci_dev *pdev, drm_via_sg_info_t *vsg) switch (vsg->state) { case dr_via_device_mapped: via_unmap_blit_from_device(pdev, vsg); + /* fall through */ case dr_via_desc_pages_alloc: for (i = 0; i < vsg->num_desc_pages; ++i) { if (vsg->desc_pages[i] != NULL) free_page((unsigned long)vsg->desc_pages[i]); } kfree(vsg->desc_pages); + /* fall through */ case dr_via_pages_locked: for (i = 0; i < vsg->num_pages; ++i) { if (NULL != (page = vsg->pages[i])) { @@ -191,8 +193,10 @@ via_free_sg_info(struct pci_dev *pdev, drm_via_sg_info_t *vsg) put_page(page); } } + /* fall through */ case dr_via_pages_alloc: vfree(vsg->pages); + /* fall through */ default: vsg->state = dr_via_sg_init; } -- 2.7.4

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel November 2017