dri-devel November 2017

dri-devel@lists.freedesktop.org

243 participants
1622 discussions

[PATCH] drm/nouveau/bios/timing: mark expected switch fall-throughs
by Gustavo A. R. Silva 02 Nov '17

02 Nov '17

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1260018 Addresses-Coverity-ID: 1260019 Addresses-Coverity-ID: 1260022 Signed-off-by: Gustavo A. R. Silva <garsilva(a)embeddedor.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/bios/timing.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/timing.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/timing.c index 7e83c39..20ff517 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/timing.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/timing.c @@ -115,16 +115,21 @@ nvbios_timingEp(struct nvkm_bios *bios, int idx, switch (min_t(u8, *hdr, 25)) { case 25: p->timing_10_24 = nvbios_rd08(bios, data + 0x18); + /* fall through */ case 24: case 23: case 22: p->timing_10_21 = nvbios_rd08(bios, data + 0x15); + /* fall through */ case 21: p->timing_10_20 = nvbios_rd08(bios, data + 0x14); + /* fall through */ case 20: p->timing_10_CWL = nvbios_rd08(bios, data + 0x13); + /* fall through */ case 19: p->timing_10_18 = nvbios_rd08(bios, data + 0x12); + /* fall through */ case 18: case 17: p->timing_10_16 = nvbios_rd08(bios, data + 0x10); -- 2.7.4

1 0

[PATCH] drm/nouveau/devinit/nv04: mark expected switch fall-throughs
by Gustavo A. R. Silva 02 Nov '17

02 Nov '17

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 143119 Addresses-Coverity-ID: 143120 Addresses-Coverity-ID: 143121 Addresses-Coverity-ID: 143122 Addresses-Coverity-ID: 143123 Addresses-Coverity-ID: 143124 Signed-off-by: Gustavo A. R. Silva <garsilva(a)embeddedor.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv04.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv04.c b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv04.c index 158977f..c3dae05 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv04.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv04.c @@ -119,11 +119,11 @@ powerctrl_1_shift(int chip_version, int reg) switch (reg) { case 0x680520: - shift += 4; + shift += 4; /* fall through */ case 0x680508: - shift += 4; + shift += 4; /* fall through */ case 0x680504: - shift += 4; + shift += 4; /* fall through */ case 0x680500: shift += 4; } @@ -245,11 +245,11 @@ setPLL_double_highregs(struct nvkm_devinit *init, u32 reg1, switch (reg1) { case 0x680504: - shift_c040 += 2; + shift_c040 += 2; /* fall through */ case 0x680500: - shift_c040 += 2; + shift_c040 += 2; /* fall through */ case 0x680520: - shift_c040 += 2; + shift_c040 += 2; /* fall through */ case 0x680508: shift_c040 += 2; } -- 2.7.4

1 0

[pull] amdgpu dc drm-next-4.15-dc
by Alex Deucher 02 Nov '17

02 Nov '17

Hi Dave, A few fixes for DC for 4.15. The following changes since commit af9111336071ee9378e1db70ac8f4c2b7fcd17a1: Merge branch 'drm-next-4.15-dc' of git://people.freedesktop.org/~agd5f/linux into drm-next (2017-10-23 11:17:54 +1000) are available in the git repository at: git://people.freedesktop.org/~agd5f/linux drm-next-4.15-dc for you to fetch changes up to 1f3493faa8d73b0332d46ea79448b10b66fb1af0: drm/amdgpu/display: fix integer arithmetic problem (2017-11-02 13:44:41 -0400) ---------------------------------------------------------------- Andrew Jiang (1): drm/amd/display: Use constants from atom.h for HDMI caps read Arnd Bergmann (3): drm/amdgpu/display: provide ASSERT macros unconditionally drm/amdgpu/display: remove unused REG_OFFSET macro drm/amdgpu/display: fix integer arithmetic problem Drew Davenport (1): amdgpu/dc: Avoid dereferencing NULL pointer Harry Wentland (4): drm/amd/display: Don't print error when bo_pin is interrupted drm/amd/display: Use plane pointer to avoid line breaks drm/amd/display: Use single fail label in init_drm_dev drm/amd/display: Explicitly call ->reset for each object Jerry Zuo (1): drm/amd/display: Fix no display on Fiji Leo (Sunpeng) Li (2): drm/amd: Add DCE12 resource strap registers drm/amd/display: Read resource_straps from registers for DCE12 Rex Zhu (1): Revert "drm/amd/display: Match actual state during S3 resume." Shirish S (4): drm/amd/display : add high part address calculation for underlay drm/amd/display: fix high part address in dm_plane_helper_prepare_fb() drm/amd/display: check if modeset is required before adding plane drm/amd/display: fix null pointer dereference drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 116 ++++++++++----------- drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c | 2 +- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +- drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 2 +- .../amd/display/dc/dce110/dce110_hw_sequencer.c | 19 ++-- .../drm/amd/display/dc/dce120/dce120_resource.c | 19 ++-- drivers/gpu/drm/amd/display/dc/dm_services.h | 3 - drivers/gpu/drm/amd/display/dc/os_types.h | 4 - .../include/asic_reg/vega10/DC/dce_12_0_offset.h | 4 + .../include/asic_reg/vega10/DC/dce_12_0_sh_mask.h | 8 ++ 10 files changed, 95 insertions(+), 88 deletions(-)

1 0

[PATCH] drm/nouveau/bios: make const arrays hwsq_signature and edid_sig static
by Colin King 02 Nov '17

02 Nov '17

From: Colin Ian King <colin.king(a)canonical.com> Don't populate arrays hwsq_signature and edid_sig on the stack but instead make them static. Makes the object code smaller by over 190 bytes: Before: text data bss dec hex filename 35676 3312 64 39052 988c nouveau_bios.o After: text data bss dec hex filename 35319 3472 64 38855 97c7 nouveau_bios.o (gcc version 7.2.0 x86_64) Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- drivers/gpu/drm/nouveau/nouveau_bios.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c index dd6fba55ad5d..18c5f5874239 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bios.c +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c @@ -1964,7 +1964,7 @@ static int load_nv17_hw_sequencer_ucode(struct drm_device *dev, * The microcode entries are found by the "HWSQ" signature. */ - const uint8_t hwsq_signature[] = { 'H', 'W', 'S', 'Q' }; + static const uint8_t hwsq_signature[] = { 'H', 'W', 'S', 'Q' }; const int sz = sizeof(hwsq_signature); int hwsq_offset; @@ -1980,7 +1980,7 @@ uint8_t *nouveau_bios_embedded_edid(struct drm_device *dev) { struct nouveau_drm *drm = nouveau_drm(dev); struct nvbios *bios = &drm->vbios; - const uint8_t edid_sig[] = { + static const uint8_t edid_sig[] = { 0x00, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x00 }; uint16_t offset = 0; uint16_t newoffset; -- 2.14.1

1 0

[Bug 93866] Tonga: Weston-drm direct scan out corruption
by bugzilla-daemon＠freedesktop.org 02 Nov '17

02 Nov '17

https://bugs.freedesktop.org/show_bug.cgi?id=93866 Bug ID: 93866 Summary: Tonga: Weston-drm direct scan out corruption Product: DRI Version: DRI git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: adf.lists(a)gmail.com Created attachment 121287 --> https://bugs.freedesktop.org/attachment.cgi?id=121287&action=edit external picture showing corruption Testing both release and git wayland/weston on R9285. Using weston-launch from fbcon so it uses weston-drm. Apart from https://bugs.freedesktop.org/show_bug.cgi?id=93740 which can be worked around, rendering is good when compositing. If I run something that allows weston to enable direct scanout there is slight corruption. kodi and mpv are the only ways I know to do this. If I do something that changes back yo compositing the corruption goes, taking a screen shot/recording or zooming in will all "fix" the corruption. I am inferring direct scan out is happening as I can't change transparency + the man page for weston-drm says it will be used where possible. Tried going back in time with mesa to see if it ever worked, but I started hitting places where either weston wouldn't start or I always got compositing so no corruption but I could change transparency. -- You are receiving this mail because: You are the assignee for the bug.

1 2

[PATCH] drm/ttm: Downgrade pr_err to pr_debug for memory allocation failures
by Michel Dänzer 02 Nov '17

02 Nov '17

From: Michel Dänzer <michel.daenzer(a)amd.com> Memory allocation failure should generally be handled gracefully by callers. In particular, with transparent hugepage support, attempts to allocate huge pages can fail under memory pressure, but the callers fall back to allocating individual pages instead. In that case, there would be spurious [TTM] Unable to get page %u error messages in dmesg. Signed-off-by: Michel Dänzer <michel.daenzer(a)amd.com> --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 13 ++++++------- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 12 ++++++------ 2 files changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c index 4d688c8d7853..316f831ad5f0 100644 --- a/drivers/gpu/drm/ttm/ttm_page_alloc.c +++ b/drivers/gpu/drm/ttm/ttm_page_alloc.c @@ -329,7 +329,7 @@ static int ttm_page_pool_free(struct ttm_page_pool *pool, unsigned nr_free, pages_to_free = kmalloc(npages_to_free * sizeof(struct page *), GFP_KERNEL); if (!pages_to_free) { - pr_err("Failed to allocate memory for pool free operation\n"); + pr_debug("Failed to allocate memory for pool free operation\n"); return 0; } @@ -517,7 +517,7 @@ static int ttm_alloc_new_pages(struct list_head *pages, gfp_t gfp_flags, caching_array = kmalloc(max_cpages*sizeof(struct page *), GFP_KERNEL); if (!caching_array) { - pr_err("Unable to allocate table for new pages\n"); + pr_debug("Unable to allocate table for new pages\n"); return -ENOMEM; } @@ -525,7 +525,7 @@ static int ttm_alloc_new_pages(struct list_head *pages, gfp_t gfp_flags, p = alloc_pages(gfp_flags, order); if (!p) { - pr_err("Unable to get page %u\n", i); + pr_debug("Unable to get page %u\n", i); /* store already allocated pages in the pool after * setting the caching state */ @@ -625,7 +625,7 @@ static void ttm_page_pool_fill_locked(struct ttm_page_pool *pool, int ttm_flags, ++pool->nrefills; pool->npages += alloc_size; } else { - pr_err("Failed to fill pool (%p)\n", pool); + pr_debug("Failed to fill pool (%p)\n", pool); /* If we have any pages left put them to the pool. */ list_for_each_entry(p, &new_pages, lru) { ++cpages; @@ -885,8 +885,7 @@ static int ttm_get_pages(struct page **pages, unsigned npages, int flags, while (npages) { p = alloc_page(gfp_flags); if (!p) { - - pr_err("Unable to allocate page\n"); + pr_debug("Unable to allocate page\n"); return -ENOMEM; } @@ -925,7 +924,7 @@ static int ttm_get_pages(struct page **pages, unsigned npages, int flags, /* If there is any pages in the list put them back to * the pool. */ - pr_err("Failed to allocate extra pages for large request\n"); + pr_debug("Failed to allocate extra pages for large request\n"); ttm_put_pages(pages, count, flags, cstate); return r; } diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c index 96ad12906621..6b2627fe9bc1 100644 --- a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c +++ b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c @@ -463,7 +463,7 @@ static unsigned ttm_dma_page_pool_free(struct dma_pool *pool, unsigned nr_free, GFP_KERNEL); if (!pages_to_free) { - pr_err("%s: Failed to allocate memory for pool free operation\n", + pr_debug("%s: Failed to allocate memory for pool free operation\n", pool->dev_name); return 0; } @@ -755,7 +755,7 @@ static int ttm_dma_pool_alloc_new_pages(struct dma_pool *pool, caching_array = kmalloc(max_cpages*sizeof(struct page *), GFP_KERNEL); if (!caching_array) { - pr_err("%s: Unable to allocate table for new pages\n", + pr_debug("%s: Unable to allocate table for new pages\n", pool->dev_name); return -ENOMEM; } @@ -768,8 +768,8 @@ static int ttm_dma_pool_alloc_new_pages(struct dma_pool *pool, for (i = 0, cpages = 0; i < count; ++i) { dma_p = __ttm_dma_alloc_page(pool); if (!dma_p) { - pr_err("%s: Unable to get page %u\n", - pool->dev_name, i); + pr_debug("%s: Unable to get page %u\n", + pool->dev_name, i); /* store already allocated pages in the pool after * setting the caching state */ @@ -855,8 +855,8 @@ static int ttm_dma_page_pool_fill_locked(struct dma_pool *pool, struct dma_page *d_page; unsigned cpages = 0; - pr_err("%s: Failed to fill %s pool (r:%d)!\n", - pool->dev_name, pool->name, r); + pr_debug("%s: Failed to fill %s pool (r:%d)!\n", + pool->dev_name, pool->name, r); list_for_each_entry(d_page, &d_pages, page_list) { cpages++; -- 2.15.0.rc2

2 2

[PATCH] drm/ttm: Always and only destroy bo->ttm_resv in ttm_bo_release_list
by Michel Dänzer 02 Nov '17

02 Nov '17

From: Michel Dänzer <michel.daenzer(a)amd.com> Fixes a use-after-free due to a race condition in ttm_bo_cleanup_refs_and_unlock, which allows one task to reserve a BO and destroy its ttm_resv while another task is waiting for it to signal in reservation_object_wait_timeout_rcu. Fixes: 0d2bd2ae045d "drm/ttm: fix memory leak while individualizing BOs" Signed-off-by: Michel Dänzer <michel.daenzer(a)amd.com> --- drivers/gpu/drm/ttm/ttm_bo.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 379ec41d2c69..a19a0ebf32ac 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -150,8 +150,7 @@ static void ttm_bo_release_list(struct kref *list_kref) ttm_tt_destroy(bo->ttm); atomic_dec(&bo->glob->bo_count); dma_fence_put(bo->moving); - if (bo->resv == &bo->ttm_resv) - reservation_object_fini(&bo->ttm_resv); + reservation_object_fini(&bo->ttm_resv); mutex_destroy(&bo->wu_mutex); if (bo->destroy) bo->destroy(bo); @@ -406,10 +405,8 @@ static int ttm_bo_individualize_resv(struct ttm_buffer_object *bo) BUG_ON(!reservation_object_trylock(&bo->ttm_resv)); r = reservation_object_copy_fences(&bo->ttm_resv, bo->resv); - if (r) { + if (r) reservation_object_unlock(&bo->ttm_resv); - reservation_object_fini(&bo->ttm_resv); - } return r; } @@ -457,10 +454,8 @@ static void ttm_bo_cleanup_refs_or_queue(struct ttm_buffer_object *bo) if (reservation_object_test_signaled_rcu(&bo->ttm_resv, true)) { ttm_bo_del_from_lru(bo); spin_unlock(&glob->lru_lock); - if (bo->resv != &bo->ttm_resv) { + if (bo->resv != &bo->ttm_resv) reservation_object_unlock(&bo->ttm_resv); - reservation_object_fini(&bo->ttm_resv); - } ttm_bo_cleanup_memtype_use(bo); return; @@ -560,8 +555,6 @@ static int ttm_bo_cleanup_refs_and_unlock(struct ttm_buffer_object *bo, } ttm_bo_del_from_lru(bo); - if (!list_empty(&bo->ddestroy) && (bo->resv != &bo->ttm_resv)) - reservation_object_fini(&bo->ttm_resv); list_del_init(&bo->ddestroy); kref_put(&bo->list_kref, ttm_bo_ref_bug); -- 2.15.0.rc2 _______________________________________________ amd-gfx mailing list amd-gfx(a)lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

2 2

[pull] radeon, amdgpu, and ttm drm-next-4.15
by Alex Deucher 02 Nov '17

02 Nov '17

Hi Dave, Misc fixes for radeon, amdgpu, and ttm for 4.15. The following changes since commit 4a0144bfc6df1f7a89a04a3e8662f1f4375eb1fe: drm/amd/amdgpu: Remove workaround for suspend/resume in uvd7 (2017-10-25 23:09:40 -0400) are available in the git repository at: git://people.freedesktop.org/~agd5f/linux drm-next-4.15 for you to fetch changes up to 710931c2be5a784c0651111f54bd083e3681c309: drm/amd/powerplay: wrong control mode cause the fan spins faster unnecessarily (2017-11-01 23:31:13 -0400) ---------------------------------------------------------------- Christian König (2): drm/ttm: once more fix ttm_buffer_object_transfer drm/amdgpu: fix error handling in amdgpu_bo_do_create Eric Huang (2): drm/amd/powerplay: change ASIC temperature reading on Vega10 drm/amd/powerplay: fix memory leak of hardcoded pptable Evan Quan (1): drm/amd/powerplay: wrong control mode cause the fan spins faster unnecessarily Monk Liu (2): drm/ttm:fix memory leak due to individualize drm/amdgpu:add fw-vram-usage for atomfirmware Roman Kapl (1): drm/radeon: fix atombios on big endian drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 38 ++++++++++------------ drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 22 ++++++++++--- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 6 ++-- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 3 ++ drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 2 +- .../gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 4 +-- drivers/gpu/drm/radeon/atombios_dp.c | 38 ++++++++++------------ drivers/gpu/drm/ttm/ttm_bo.c | 5 ++- drivers/gpu/drm/ttm/ttm_bo_util.c | 1 + 9 files changed, 68 insertions(+), 51 deletions(-)

1 0

[Bug 196615] New: amdgpu - resume from suspend is no longer working on rx480
by bugzilla-daemon＠bugzilla.kernel.org 02 Nov '17

02 Nov '17

https://bugzilla.kernel.org/show_bug.cgi?id=196615 Bug ID: 196615 Summary: amdgpu - resume from suspend is no longer working on rx480 Product: Drivers Version: 2.5 Kernel Version: >= 4.11.3 Hardware: Intel OS: Linux Tree: Mainline Status: NEW Severity: high Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: psk(a)autistici.org Regression: No Hi! Since 4.12.4 I can no longer resume from suspend using the amdgpu driver on my rx 480. I did a bisect and it revealed the following commit being the problem: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/com… Can someone help me with fixing that? -- You are receiving this mail because: You are watching the assignee of the bug.

1 35

[PATCH v7 3/5] Documentation: Add device tree binding for Goldfish FB driver
by Aleksandar Markovic 02 Nov '17

02 Nov '17

From: Aleksandar Markovic <aleksandar.markovic(a)mips.com> Add documentation for DT binding of Goldfish FB driver. The compatible string used by OS for binding the driver is "google,goldfish-fb". Signed-off-by: Miodrag Dinic <miodrag.dinic(a)mips.com> Signed-off-by: Goran Ferenc <goran.ferenc(a)mips.com> Signed-off-by: Aleksandar Markovic <aleksandar.markovic(a)mips.com> Acked-by: Rob Herring <robh(a)kernel.org> --- .../devicetree/bindings/display/google,goldfish-fb.txt | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/google,goldfish-fb.txt diff --git a/Documentation/devicetree/bindings/display/google,goldfish-fb.txt b/Documentation/devicetree/bindings/display/google,goldfish-fb.txt new file mode 100644 index 0000000..751fa9f --- /dev/null +++ b/Documentation/devicetree/bindings/display/google,goldfish-fb.txt @@ -0,0 +1,17 @@ +Android Goldfish framebuffer + +Android Goldfish framebuffer device used by Android emulator. + +Required properties: + +- compatible : should contain "google,goldfish-fb" +- reg : <registers mapping> +- interrupts : <interrupt mapping> + +Example: + + display-controller@1f008000 { + compatible = "google,goldfish-fb"; + interrupts = <0x10>; + reg = <0x1f008000 0x100>; + }; -- 2.7.4

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel November 2017