dri-devel November 2017

dri-devel@lists.freedesktop.org

243 participants
1622 discussions

[Bug 101475] Max Core Profile for OpenGL showing 0.0
by bugzilla-daemon＠freedesktop.org 02 Nov '17

02 Nov '17

https://bugs.freedesktop.org/show_bug.cgi?id=101475 --- Comment #11 from vinf100(a)gmail.com --- Hello, sorry to reopen this thread. I am still having the same problem i.e. the max core profile is showing at 0.0. glxinfo | grep version returns: server glx version string: 1.4 client glx version string: 1.4 GLX version: 1.4 Max core profile version: 0.0 Max compat profile version: 2.1 Max GLES1 profile version: 1.1 Max GLES[23] profile version: 2.0 OpenGL version string: 2.1 Mesa 17.2.4 OpenGL shading language version string: 1.30 OpenGL ES profile version string: OpenGL ES 2.0 Mesa 17.2.4 OpenGL ES profile shading language version string: OpenGL ES GLSL ES 1.0.16 glxinfo | grep renderer: GLX_MESA_multithread_makecurrent, GLX_MESA_query_renderer, GLX_MESA_multithread_makecurrent, GLX_MESA_query_renderer, Extended renderer info (GLX_MESA_query_renderer): OpenGL renderer string: AMD REDWOOD (DRM 2.49.0 / 4.10.0-38-generic, LLVM 4.0.0) It used to show 3.3, but why does it now show the wrong version. Also, when I try to use MESA_GL_VERSION_OVERRIDE, it always fails for values above 2.1 -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 101475] Max Core Profile for OpenGL showing 0.0
by bugzilla-daemon＠freedesktop.org 02 Nov '17

02 Nov '17

https://bugs.freedesktop.org/show_bug.cgi?id=101475 --- Comment #10 from vinf100(a)gmail.com --- Hello, sorry to reopen this thread. I am still having the same problem i.e. the max core profile is showing at 0.0. glxinfo -- You are receiving this mail because: You are the assignee for the bug.

1 0

[pull] amdgpu drm-fixes-4.14
by Alex Deucher 02 Nov '17

02 Nov '17

Hi Dave, Just two small patches for stable to fix the driver failing to load on polaris cards with harvested VCE or UVD blocks. The following changes since commit d3daa2c7865cbfa830651b11c8ad1df23465b46e: drm/amd/amdgpu: Remove workaround check for UVD6 on APUs (2017-10-25 09:32:14 -0400) are available in the git repository at: git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14 for you to fetch changes up to 32bec2afa525149288e6696079bc85f747fa2138: drm/amdgpu: allow harvesting check for Polaris VCE (2017-11-01 23:37:16 -0400) ---------------------------------------------------------------- Leo Liu (2): drm/amdgpu: return -ENOENT from uvd 6.0 early init for harvesting drm/amdgpu: allow harvesting check for Polaris VCE drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 4 ++++ drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 12 ++++++------ 2 files changed, 10 insertions(+), 6 deletions(-)

1 0

[PATCH v4 0/4] Add support rockchip RGB output interface
by Sandy Huang 02 Nov '17

02 Nov '17

This patches add support rockchip RGB output, Some Rockchip CRTCs, like rv1108, can directly output parallel and serial RGB data to panel or to conversion chip. So we add this driver to probe encoder and connector to support this case. Sandy Huang (4): devicetree/bindings: display: Add doucument for RGB panels devicetree/bindings: display: Add document for rockchip RGB output drm/rockchip: Add support for Rockchip Soc RGB output interface drm/rockchip: vop: Add more RGB output interface type .../bindings/display/panel/panel-rgb.txt | 116 +++++++ .../bindings/display/rockchip/rockchip-rgb.txt | 72 +++++ drivers/gpu/drm/rockchip/Kconfig | 11 + drivers/gpu/drm/rockchip/Makefile | 1 + drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 + drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 + drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 2 + drivers/gpu/drm/rockchip/rockchip_rgb.c | 344 +++++++++++++++++++++ 8 files changed, 549 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-rgb.txt create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt create mode 100644 drivers/gpu/drm/rockchip/rockchip_rgb.c -- 2.7.4

2 5

Re: [PATCH] PM / QoS: Fix default runtime_pm device resume latency
by Geert Uytterhoeven 01 Nov '17

01 Nov '17

Hi Rafael, Tero, CC pinchartl, dri-devel On Tue, Oct 31, 2017 at 2:10 PM, Geert Uytterhoeven <geert(a)linux-m68k.org> wrote: > CC linux-renesas-soc > > On Tue, Oct 31, 2017 at 2:09 PM, Geert Uytterhoeven > <geert(a)linux-m68k.org> wrote: >> On Tue, Oct 31, 2017 at 12:27 AM, Rafael J. Wysocki <rjw(a)rjwysocki.net> wrote: >>> On Monday, October 30, 2017 11:19:08 AM CET Rafael J. Wysocki wrote: >>>> On Mon, Oct 30, 2017 at 8:10 AM, Tero Kristo <t-kristo(a)ti.com> wrote: >>>> > The recent change to the PM QoS framework to introduce a proper >>>> > no constraint value overlooked to handle the devices which don't >>>> > implement PM QoS OPS. Runtime PM is one of the more severely >>>> > impacted subsystems, failing every attempt to runtime suspend >>>> > a device. This leads into some nasty second level issues like >>>> > probe failures and increased power consumption among other things. >>>> >>>> Oh, that's bad. >>>> >>>> Sorry about breaking it and thanks for the fix! >>>> >>>> > Fix this by adding a proper return value for devices that don't >>>> > implement PM QoS implicitly. >>>> > >>>> > Fixes: 0cc2b4e5a020 ("PM / QoS: Fix device resume latency PM QoS") >>>> > Signed-off-by: Tero Kristo <t-kristo(a)ti.com> >>>> > Cc: Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> >>>> >>>> Applied. >>> >>> And pushed to Linus. >> >> I'm afraid it is not sufficient. >> >> Commit 0cc2b4e5a020fc7f ("PM / QoS: Fix device resume latency PM QoS") >> introduced two issues on Renesas platforms: >> 1. After boot up, many devices have changed their state from "suspended" >> to "active", according to /sys/kernel/debug/pm_genpd/pm_genpd_summary >> (comparing that file across boots is one of my standard tests). >> Interestingly, doing a system suspend/resume cycle restores their state >> to "suspended". >> >> 2. During system suspend, the following warning is printed on >> r8a7791/koelsch: >> >> i2c-rcar e6530000.i2c: runtime PM trying to suspend device but >> active child 3. I've just bisected a seemingly unrelated issue to the same commit. On Salvator-XS with R-Car H3, initialization of the rcar-du driver now takes more than 1 minute due to flip_done time outs, while it took 0.12s before: [ 3.015035] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [ 3.021721] [drm] No driver support for vblank timestamp query. [ 13.280738] [drm:drm_atomic_helper_wait_for_flip_done] *ERROR* [CRTC:58:crtc-3] flip_done timed out [ 23.520707] [drm:drm_atomic_helper_commit_cleanup_done] *ERROR* [CRTC:58:crtc-3] flip_done timed out [ 33.760708] [drm:drm_atomic_helper_wait_for_flip_done] *ERROR* [CRTC:58:crtc-3] flip_done timed out [ 44.000755] [drm:drm_atomic_helper_commit_cleanup_done] *ERROR* [CRTC:58:crtc-3] flip_done timed out [ 44.003597] Console: switching to colour frame buffer device 128x48 [ 54.240707] [drm:drm_atomic_helper_wait_for_flip_done] *ERROR* [CRTC:58:crtc-3] flip_done timed out [ 64.480706] [drm:drm_atomic_helper_commit_cleanup_done] *ERROR* [CRTC:58:crtc-3] flip_done timed out [ 64.544876] rcar-du feb00000.display: fb0: frame buffer device [ 64.552013] [drm] Initialized rcar-du 1.0.0 20130110 for feb00000.display on minor 0 [ 64.559873] [drm] Device feb00000.display probed >> Commit 2a9a86d5c81389cd ("PM / QoS: Fix default runtime_pm device resume >> latency") fixes the second issue, but not the first. ... nor the third. >> Reverting commits 2a9a86d5c81389cd ("PM / QoS: Fix default runtime_pm >> device resume latency") and 0cc2b4e5a020fc7f ("PM / QoS: Fix device resume >> latency PM QoS") fixes both. ... all three. >> Do you have a clue? >> Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

7 11

[PULL] drm-intel-fixes
by Rodrigo Vivi 01 Nov '17

01 Nov '17

Hi Dave, Here goes drm-intel-fixes-2017-11-01. Fixes for Stable: - Fix KBL Blank Screen (Jani) - Fix FIFO Underrun on SNB (Maarten) Other fixes: - Fix GPU Hang on i915gm (Chris) - Fix gem_tiled_pread_pwrite IGT case (Chris) - Cancel modeset retry work during modeset clean-up (Manasi) Thanks, Rodrigo. The following changes since commit 0b07194bb55ed836c2cc7c22e866b87a14681984: Linux 4.14-rc7 (2017-10-29 13:58:38 -0700) are available in the git repository at: git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2017-11-01 for you to fetch changes up to bb5cf3386327c9cb5ca3fbb85242e940751649c8: drm/i915: Check incoming alignment for unfenced buffers (on i915gm) (2017-11-01 10:28:28 -0700) ---------------------------------------------------------------- drm-intel-fixes-2017-11-01: Fixes for Stable: - Fix KBL Blank Screen (Jani) - Fix FIFO Underrun on SNB (Maarten) Other fixes: - Fix GPU Hang on i915gm (Chris) - Fix gem_tiled_pread_pwrite IGT case (Chris) - Cancel modeset retry work during modeset clean-up (Manasi) ---------------------------------------------------------------- Chris Wilson (3): drm/i915: Hold rcu_read_lock when iterating over the radixtree (objects) drm/i915: Hold rcu_read_lock when iterating over the radixtree (vma idr) drm/i915: Check incoming alignment for unfenced buffers (on i915gm) Jani Nikula (1): drm/i915/edp: read edp display control registers unconditionally Maarten Lankhorst (1): drm/i915: Do not rely on wm preservation for ILK watermarks Manasi Navare (1): drm/i915: Cancel the modeset retry work during modeset cleanup drivers/gpu/drm/i915/i915_gem.c | 2 ++ drivers/gpu/drm/i915/i915_gem_context.c | 2 ++ drivers/gpu/drm/i915/i915_gem_execbuffer.c | 4 +++ drivers/gpu/drm/i915/intel_display.c | 19 ++++++++++- drivers/gpu/drm/i915/intel_dp.c | 13 ++++++-- drivers/gpu/drm/i915/intel_drv.h | 1 - drivers/gpu/drm/i915/intel_pm.c | 51 ++++++++++++------------------ 7 files changed, 57 insertions(+), 35 deletions(-)

1 0

[pull] drm/msm: msm-next for 4.15 (take 2)
by Rob Clark 01 Nov '17

01 Nov '17

Hi Dave, Updated pull request, which adds the patch I lost from Arnd to correct a warning on armv7. Original pull req description: Updates for 4.15.. highlights include: + preemption support for a5xx[1][2] + display fixes for 8x96 (snapdragon 820) including fixes for 4k scanout (hwpipe assignment re-work to handle multiple hwpipe assigned to plane for wide scanout) + async cursor plane updates and fixes + refactor adreno_bind/hwinit.. still defer fw loading until device open, but move clk/irq/etc to probe/bind time to fix issues when fw isn't present in filesys + clk/dt bindings cleanups w/ backward compat via msm_clk_get() (dt docs part ack'ed by Rob Herring) + fw loading re-work with helper to handle either /lib/firmware/qcom/$fw or /lib/firmware/$fw.. background, we've started landing fw for some of generations in linux-firmware, but there is a preference to put fw files under 'qcom' subdirectory, which is not what was done on android or for people who copied fw from android. So now we first look in qcom subdir and then fallback to the original location. + bunch of GPU debugging enhancements, to dump full cmdline of processes that trigger faults, and to add a new debugfs to capture cmdstream of just submits that triggered faults.. both quite useful for piglit ;-) Note that first patch was also included in -fixes pr for 4.14, but including it here again was the sanest way to avoid bad merge conflicts. [1] libdrm: https://github.com/freedreno/libdrm/commits/context-priority [2] mesa: https://lists.freedesktop.org/archives/mesa-dev/2017-October/174100.html The following changes since commit 62884cd386b876638720ef88374b31a84ca7ee5f: drm: Add four ioctls for managing drm mode object leases [v7] (2017-10-25 16:31:30 +1000) are available in the git repository at: git://people.freedesktop.org/~robclark/linux drm-msm-next-2017-11-01 for you to fetch changes up to 39ae0d3e561d360e41f2a3d1c427d5d9142468da: drm/msm: use %z format modifier for printing size_t (2017-11-01 11:16:28 -0400) ---------------------------------------------------------------- Archit Taneja (5): drm/msm/hdmi: Remove mmagic_iface_clk from the 8x96 PHY clocks drm/msm/mdp5: Prepare mdp5_pipe_assign for some rework drm/msm/mdp5: Update mdp5_pipe_assign to spit out both planes drm/msm/mdp5: mdp5_crtc: Restore cursor state only if LM cursors are enabled drm/msm/mdp5: Don't use async plane update path if plane visibility changes Arnd Bergmann (1): drm/msm: use %z format modifier for printing size_t Gustavo Padovan (2): drm/msm: update cursors asynchronously through atomic drm/msm: remove mdp5_cursor_plane_funcs Jordan Crouse (9): drm/msm: Add per-instance submit queues drm/msm: Move memptrs to msm_gpu drm/msm: Support multiple ringbuffers drm/msm: Add a parameter query for the number of ringbuffers drm/msm: Shadow current pointer in the ring until command is complete drm/msm: Make the value of RB_CNTL (almost) generic drm/msm: Implement preemption for A5XX targets drm/msm: Removed unused struct_mutex_task drm/msm: dump a rd GPUADDR header for all buffers in the command Rob Clark (21): drm/msm: fix _NO_IMPLICIT fencing case drm/msm/adreno: load gpu at probe/bind time drm/msm/adreno: split out helper to load fw drm/msm/adreno: deal with linux-firmware fw paths drm/msm/mdp5: always print mdp5 version drm/msm/dsi: convert to msm_clk_get() drm/msm/edp: convert to msm_clk_get() drm/msm/hdmi: convert to msm_clk_get() dt-bindings: display: msm: update clk names drm/msm/mdp4: disable vblanks when crtc is off drm/msm/mdp5: disable vblanks when crtc is off drm/msm: show task cmdline in gpu recovery messages drm/msm: add special _get_vaddr_active() for cmdstream dumps drm/msm: split rd debugfs file drm/msm/rd: allow adding addition msg to top of dump drm/msm: preserve IOVAs in submit's bo table drm/msm: dump submits which triggered gpu hang drm/msm/mdp5: ignore planes that are not visible drm/msm/mdp5: don't use autosuspend drm/msm/mdp5: restore cursor state when enabling crtc drm/msm/atomic: switch to drm_atomic_helper_check .../devicetree/bindings/display/msm/dsi.txt | 36 +- .../devicetree/bindings/display/msm/edp.txt | 20 +- .../devicetree/bindings/display/msm/hdmi.txt | 8 +- .../devicetree/bindings/display/msm/mdp5.txt | 32 +- drivers/gpu/drm/msm/Makefile | 4 +- drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 10 +- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 10 +- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 261 +++++- drivers/gpu/drm/msm/adreno/a5xx_gpu.h | 109 ++- drivers/gpu/drm/msm/adreno/a5xx_power.c | 9 +- drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 305 +++++++ drivers/gpu/drm/msm/adreno/adreno_device.c | 78 +- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 297 ++++--- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 66 +- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 8 +- drivers/gpu/drm/msm/dsi/dsi_host.c | 30 +- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 +- drivers/gpu/drm/msm/edp/edp_ctrl.c | 22 +- drivers/gpu/drm/msm/hdmi/hdmi.c | 10 +- drivers/gpu/drm/msm/hdmi/hdmi_phy.c | 2 +- drivers/gpu/drm/msm/hdmi/hdmi_phy_8960.c | 2 +- drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c | 4 +- drivers/gpu/drm/msm/hdmi/hdmi_phy_8x74.c | 3 +- drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 7 + drivers/gpu/drm/msm/mdp/mdp5/mdp5_cmd_encoder.c | 2 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 160 ++-- drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c | 2 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c | 10 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c | 8 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_pipe.c | 71 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_pipe.h | 7 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 232 +++--- drivers/gpu/drm/msm/msm_atomic.c | 41 +- drivers/gpu/drm/msm/msm_drv.c | 83 +- drivers/gpu/drm/msm/msm_drv.h | 37 +- drivers/gpu/drm/msm/msm_fence.c | 2 +- drivers/gpu/drm/msm/msm_fence.h | 2 +- drivers/gpu/drm/msm/msm_gem.c | 33 +- drivers/gpu/drm/msm/msm_gem.h | 5 +- drivers/gpu/drm/msm/msm_gem_submit.c | 61 +- drivers/gpu/drm/msm/msm_gpu.c | 238 ++++-- drivers/gpu/drm/msm/msm_gpu.h | 51 +- drivers/gpu/drm/msm/msm_rd.c | 142 +++- drivers/gpu/drm/msm/msm_ringbuffer.c | 36 +- drivers/gpu/drm/msm/msm_ringbuffer.h | 33 +- drivers/gpu/drm/msm/msm_submitqueue.c | 152 ++++ include/dt-bindings/msm/msm-bus-ids.h | 887 +++++++++++++++++++++ include/uapi/drm/msm_drm.h | 24 + 48 files changed, 2904 insertions(+), 750 deletions(-) create mode 100644 drivers/gpu/drm/msm/adreno/a5xx_preempt.c create mode 100644 drivers/gpu/drm/msm/msm_submitqueue.c create mode 100644 include/dt-bindings/msm/msm-bus-ids.h

1 0

[PATCH hwc] drm_hwcomposer: Add HDMI connector as a valid type
by Rob Herring 01 Nov '17

01 Nov '17

From: Robert Foss <robert.foss(a)collabora.com> Accept DRM_MODE_CONNECTOR_HDMIA connector type. Look for primary DrmConnector amongst external connectors after looking for primary amongst internal ones first. Signed-off-by: Robert Foss <robert.foss(a)collabora.com> Signed-off-by: Rob Herring <robh(a)kernel.org> --- This is needed to get dev boards like DB410c to work. drmconnector.cpp | 10 +++++++++- drmconnector.h | 4 +++- drmresources.cpp | 16 ++++++++++++++-- 3 files changed, 26 insertions(+), 4 deletions(-) diff --git a/drmconnector.cpp b/drmconnector.cpp index ccb38e2f00dc..247f56bde748 100644 --- a/drmconnector.cpp +++ b/drmconnector.cpp @@ -67,11 +67,19 @@ void DrmConnector::set_display(int display) { display_ = display; } -bool DrmConnector::built_in() const { +bool DrmConnector::internal() const { return type_ == DRM_MODE_CONNECTOR_LVDS || type_ == DRM_MODE_CONNECTOR_eDP || type_ == DRM_MODE_CONNECTOR_DSI || type_ == DRM_MODE_CONNECTOR_VIRTUAL; } +bool DrmConnector::external() const { + return type_ == DRM_MODE_CONNECTOR_HDMIA; +} + +bool DrmConnector::valid_type() const { + return internal() || external(); +} + int DrmConnector::UpdateModes() { int fd = drm_->fd(); diff --git a/drmconnector.h b/drmconnector.h index e1488bb42a9a..5601e069f003 100644 --- a/drmconnector.h +++ b/drmconnector.h @@ -44,7 +44,9 @@ class DrmConnector { int display() const; void set_display(int display); - bool built_in() const; + bool internal() const; + bool external() const; + bool valid_type() const; int UpdateModes(); diff --git a/drmresources.cpp b/drmresources.cpp index 67a853c587b3..32dd37636e73 100644 --- a/drmresources.cpp +++ b/drmresources.cpp @@ -154,16 +154,28 @@ int DrmResources::Init() { break; } - if (conn->built_in() && !found_primary) { + connectors_.emplace_back(std::move(conn)); + } + + // First look for primary amongst internal connectors + for (auto &conn : connectors_) { + if (conn->internal() && !found_primary) { conn->set_display(0); found_primary = true; } else { conn->set_display(display_num); ++display_num; } + } - connectors_.emplace_back(std::move(conn)); + // Then look for primary amongst external connectors + for (auto &conn : connectors_) { + if (conn->external() && !found_primary) { + conn->set_display(0); + found_primary = true; + } } + if (res) drmModeFreeResources(res); -- 2.14.1

2 1

[PATCH hwc] drm_hwcomposer: correct handling of DRM_MODE_ROTATE_0
by Rob Herring 01 Nov '17

01 Nov '17

If the rotation property is supported for a plane, then the rotation value must be non-zero. For the case of 0 degree rotation, DRM_MODE_ROTATE_0 needs to be set. Signed-off-by: Rob Herring <robh(a)kernel.org> --- drmdisplaycompositor.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drmdisplaycompositor.cpp b/drmdisplaycompositor.cpp index 8225726df5cd..dceb78d452c4 100644 --- a/drmdisplaycompositor.cpp +++ b/drmdisplaycompositor.cpp @@ -581,6 +581,8 @@ int DrmDisplayCompositor::CommitFrame(DrmDisplayComposition *display_comp, rotation |= DRM_MODE_ROTATE_180; else if (layer.transform & DrmHwcTransform::kRotate270) rotation |= DRM_MODE_ROTATE_270; + else + rotation |= DRM_MODE_ROTATE_0; if (fence_fd < 0) { int prop_id = plane->in_fence_fd_property().id(); @@ -610,7 +612,7 @@ int DrmDisplayCompositor::CommitFrame(DrmDisplayComposition *display_comp, } // TODO: Once we have atomic test, this should fall back to GL - if (rotation && plane->rotation_property().id() == 0) { + if (rotation != DRM_MODE_ROTATE_0 && plane->rotation_property().id() == 0) { ALOGE("Rotation is not supported on plane %d", plane->id()); ret = -EINVAL; break; -- 2.14.1

2 2

[PATCH v2 1/2] drm: drm_vblank_cleanup: WARN when refcount > 0
by PrasannaKumar Muralidharan 01 Nov '17

01 Nov '17

Warn when refcount > 0 in drm_vblank_cleanup. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar(a)gmail.com> --- No change in v2. drivers/gpu/drm/drm_vblank.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c index 70f2b95..3e61aeb 100644 --- a/drivers/gpu/drm/drm_vblank.c +++ b/drivers/gpu/drm/drm_vblank.c @@ -405,6 +405,8 @@ void drm_vblank_cleanup(struct drm_device *dev) for (pipe = 0; pipe < dev->num_crtcs; pipe++) { struct drm_vblank_crtc *vblank = &dev->vblank[pipe]; + WARN_ON(atomic_read(&vblank->refcount) > 0); + WARN_ON(READ_ONCE(vblank->enabled) && drm_core_check_feature(dev, DRIVER_MODESET)); -- 2.10.0

2 10

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel November 2017