dri-devel December 2017

dri-devel@lists.freedesktop.org

236 participants
1514 discussions

[Bug 99784] AMD 7470m When VGA plugged into laptop, only one monitor working at a time
by bugzilla-daemon＠freedesktop.org 09 Dec '17

09 Dec '17

https://bugs.freedesktop.org/show_bug.cgi?id=99784 --- Comment #17 from lazanet96(a)gmail.com --- Created attachment 136058 --> https://bugs.freedesktop.org/attachment.cgi?id=136058&action=edit Workaround (Ubuntu 17.10 DRM 2.50.0 / 4.13.0-19-generic, LLVM 5.0.0) After testing new version of kernel on Ubuntu 17.10 installation (wayland + systemd) I discovered by chance that after suspend and unsuspend (systemctl suspend), internal monitor starts displaying image and everything works (for the first time with radeon driver). So as a workaround I used /etc/rc.local compatibility to trigger suspend after appropriate ring level is initialized during boot(sudo chmod +x /etc/rc.local is also required). I tested same method with 14.04 LTS with no success (so I don't know exactly what upgrade made it work). -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH v2 4/7] drm/rockchip: dw_hdmi: add inno hdmi phy ops
by Algea Cao 09 Dec '17

09 Dec '17

Because some RK chips use inno hdmi phy, such as RK3328, we add inno hdmi phy ops. Signed-off-by: Algea Cao <algea.cao(a)rock-chips.com> --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 110 +++++++++++++++++++++++++++- 1 file changed, 107 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c index 09c77f9..7658b2f 100644 --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c @@ -12,7 +12,7 @@ #include <linux/module.h> #include <linux/platform_device.h> #include <linux/regmap.h> - +#include <linux/phy/phy.h> #include <drm/drm_of.h> #include <drm/drmP.h> #include <drm/drm_crtc_helper.h> @@ -26,6 +26,18 @@ #define RK3288_HDMI_LCDC_SEL BIT(4) #define RK3399_GRF_SOC_CON20 0x6250 #define RK3399_HDMI_LCDC_SEL BIT(6) +#define RK3328_GRF_SOC_CON2 0x0408 +#define RK3328_DDC_MASK_EN ((3 << 10) | (3 << (10 + 16))) +#define RK3328_GRF_SOC_CON3 0x040c +#define RK3328_IO_CTRL_BY_HDMI (0xf0000000 | BIT(13) | BIT(12)) +#define RK3328_GRF_SOC_CON4 0x0410 +#define RK3328_IO_3V_DOMAIN (7 << (9 + 16)) +#define RK3328_IO_5V_DOMAIN ((7 << 9) | (3 << (9 + 16))) +#define RK3328_HPD_3V (BIT(8 + 16) | BIT(13 + 16)) +#define RK3228_GRF_SOC_CON2 0x0408 +#define RK3228_DDC_MASK_EN ((3 << 13) | (3 << (13 + 16))) +#define RK3228_GRF_SOC_CON6 0x0418 +#define RK3228_IO_3V_DOMAIN ((7 << 4) | (7 << (4 + 16))) #define HIWORD_UPDATE(val, mask) (val | (mask) << 16) @@ -49,10 +61,82 @@ struct rockchip_hdmi { enum dw_hdmi_devtype dev_type; struct clk *vpll_clk; struct clk *grf_clk; + struct phy *phy; }; #define to_rockchip_hdmi(x) container_of(x, struct rockchip_hdmi, x) +static int +inno_dw_hdmi_phy_init(struct dw_hdmi *dw_hdmi, void *data, + struct drm_display_mode *mode) +{ + struct rockchip_hdmi *hdmi = (struct rockchip_hdmi *)data; + + return phy_power_on(hdmi->phy); +} + +static void inno_dw_hdmi_phy_disable(struct dw_hdmi *dw_hdmi, void *data) +{ + struct rockchip_hdmi *hdmi = (struct rockchip_hdmi *)data; + + phy_power_off(hdmi->phy); +} + +static enum drm_connector_status +inno_dw_hdmi_phy_read_hpd(struct dw_hdmi *dw_hdmi, void *data) +{ + struct rockchip_hdmi *hdmi = (struct rockchip_hdmi *)data; + enum drm_connector_status status; + + status = dw_hdmi_phy_read_hpd(dw_hdmi, data); + + if (hdmi->dev_type == RK3228_HDMI) + return status; + + if (status == connector_status_connected) + regmap_write(hdmi->regmap, + RK3328_GRF_SOC_CON4, + RK3328_IO_5V_DOMAIN); + else + regmap_write(hdmi->regmap, + RK3328_GRF_SOC_CON4, + RK3328_IO_3V_DOMAIN); + return status; +} + +static int inno_dw_hdmi_init(struct rockchip_hdmi *hdmi) +{ + int ret; + + ret = clk_prepare_enable(hdmi->grf_clk); + if (ret < 0) { + dev_err(hdmi->dev, "failed to enable grfclk %d\n", ret); + return -EPROBE_DEFER; + } + if (hdmi->dev_type == RK3328_HDMI) { + /* Map HPD pin to 3V io */ + regmap_write(hdmi->regmap, + RK3328_GRF_SOC_CON4, + RK3328_IO_3V_DOMAIN | + RK3328_HPD_3V); + /* Map ddc pin to 5V io */ + regmap_write(hdmi->regmap, + RK3328_GRF_SOC_CON3, + RK3328_IO_CTRL_BY_HDMI); + regmap_write(hdmi->regmap, + RK3328_GRF_SOC_CON2, + RK3328_DDC_MASK_EN | + BIT(18)); + } else { + regmap_write(hdmi->regmap, RK3228_GRF_SOC_CON2, + RK3228_DDC_MASK_EN); + regmap_write(hdmi->regmap, RK3228_GRF_SOC_CON6, + RK3228_IO_3V_DOMAIN); + } + clk_disable_unprepare(hdmi->grf_clk); + return 0; +} + static const struct dw_hdmi_mpll_config rockchip_mpll_cfg[] = { { 27000000, { @@ -294,6 +378,12 @@ static const struct drm_encoder_helper_funcs dw_hdmi_rockchip_encoder_helper_fun .atomic_check = dw_hdmi_rockchip_encoder_atomic_check, }; +static const struct dw_hdmi_phy_ops inno_dw_hdmi_phy_ops = { + .init = inno_dw_hdmi_phy_init, + .disable = inno_dw_hdmi_phy_disable, + .read_hpd = inno_dw_hdmi_phy_read_hpd, +}; + static struct rockchip_hdmi_chip_data rk3288_chip_data = { .lcdsel_grf_reg = RK3288_GRF_SOC_CON6, .lcdsel_big = HIWORD_UPDATE(0, RK3288_HDMI_LCDC_SEL), @@ -317,6 +407,8 @@ static struct rockchip_hdmi_chip_data rk3399_chip_data = { static const struct dw_hdmi_plat_data rk3328_hdmi_drv_data = { .mode_valid = dw_hdmi_rockchip_mode_valid, + .phy_ops = &inno_dw_hdmi_phy_ops, + .phy_name = "inno_dw_hdmi_phy2", .dev_type = RK3328_HDMI, }; static const struct dw_hdmi_plat_data rk3399_hdmi_drv_data = { @@ -346,7 +438,7 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master, void *data) { struct platform_device *pdev = to_platform_device(dev); - const struct dw_hdmi_plat_data *plat_data; + struct dw_hdmi_plat_data *plat_data; const struct of_device_id *match; struct drm_device *drm = data; struct drm_encoder *encoder; @@ -361,7 +453,7 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master, return -ENOMEM; match = of_match_node(dw_hdmi_rockchip_dt_ids, pdev->dev.of_node); - plat_data = match->data; + plat_data = (struct dw_hdmi_plat_data *)match->data; hdmi->dev = &pdev->dev; hdmi->chip_data = plat_data->phy_data; hdmi->dev_type = plat_data->dev_type; @@ -383,6 +475,18 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master, return ret; } + if (hdmi->dev_type == RK3328_HDMI || hdmi->dev_type == RK3228_HDMI) { + hdmi->phy = devm_phy_get(dev, "hdmi_phy"); + if (IS_ERR(hdmi->phy)) { + ret = PTR_ERR(hdmi->phy); + dev_err(dev, "failed to get phy: %d\n", ret); + return ret; + } + plat_data->phy_data = hdmi; + ret = inno_dw_hdmi_init(hdmi); + if (ret < 0) + return ret; + } drm_encoder_helper_add(encoder, &dw_hdmi_rockchip_encoder_helper_funcs); drm_encoder_init(drm, encoder, &dw_hdmi_rockchip_encoder_funcs, DRM_MODE_ENCODER_TMDS, NULL); -- 2.7.4

2 1

[PATCH 8/8] phy: rockchip: add inno hdmi phy to makefile
by Algea Cao 09 Dec '17

09 Dec '17

Support some SOCs,such as RK3328. Signed-off-by: Algea Cao <algea.cao(a)rock-chips.com> --- drivers/phy/rockchip/Kconfig | 7 +++++++ drivers/phy/rockchip/Makefile | 1 + 2 files changed, 8 insertions(+) diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig index f5325b2..b021dc7 100644 --- a/drivers/phy/rockchip/Kconfig +++ b/drivers/phy/rockchip/Kconfig @@ -8,6 +8,13 @@ config PHY_ROCKCHIP_DP help Enable this to support the Rockchip Display Port PHY. +config PHY_ROCKCHIP_INNO_HDMI_PHY + tristate "Rockchip INNO HDMI PHY Driver" + depends on ARCH_ROCKCHIP && OF + select GENERIC_PHY + help + Enable this to support the Rockchip HDMI PHY with Innosilicon IP block. + config PHY_ROCKCHIP_EMMC tristate "Rockchip EMMC PHY Driver" depends on ARCH_ROCKCHIP && OF diff --git a/drivers/phy/rockchip/Makefile b/drivers/phy/rockchip/Makefile index bd0acdf..6c1adc0 100644 --- a/drivers/phy/rockchip/Makefile +++ b/drivers/phy/rockchip/Makefile @@ -4,3 +4,4 @@ obj-$(CONFIG_PHY_ROCKCHIP_INNO_USB2) += phy-rockchip-inno-usb2.o obj-$(CONFIG_PHY_ROCKCHIP_PCIE) += phy-rockchip-pcie.o obj-$(CONFIG_PHY_ROCKCHIP_TYPEC) += phy-rockchip-typec.o obj-$(CONFIG_PHY_ROCKCHIP_USB) += phy-rockchip-usb.o +obj-$(CONFIG_PHY_ROCKCHIP_INNO_HDMI_PHY) += phy-rockchip-inno-hdmi-phy.o \ No newline at end of file -- 2.7.4

3 3

[git pull] drm fixes for v4.15-rc3
by Dave Airlie 08 Dec '17

08 Dec '17

Hi Linus, FYI, I'm on holidays for next week, it's normally a time of the dev cycle where anything urgent happens so things should tick along nicely. I'll have some email access but no serious hw. This pull is a bit larger than I'd like but a large bunch of it is license fixes, AMD wanted to fix the licenses for a bunch of files that were missing them, Otherwise a bunch of TTM regression fix since the hugepage support, some i915 and gvt fixes, a core connector free in a safe context fix, and one bridge fix. Dave. The following changes since commit ae64f9bd1d3621b5e60d7363bc20afb46aede215: Linux 4.15-rc2 (2017-12-03 11:01:47 -0500) are available in the git repository at: git://people.freedesktop.org/~airlied/linux tags/drm-fixes-for-v4.15-rc3 for you to fetch changes up to 90eeb3aa34831ff3d031589c0c24892eb8a07e51: Merge tag 'drm-misc-fixes-2017-12-07' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-12-08 08:17:53 +1000) ---------------------------------------------------------------- i915, amdgpu + misc fixes ---------------------------------------------------------------- Alex Deucher (2): drm/amdgpu: add license to Makefiles drm/amdgpu: add license to files where it was missing Boris Brezillon (1): drm/vc4: Fix false positive WARN() backtrace on refcount_inc() usage Changbin Du (1): drm/i915/gvt: Emulate PCI expansion ROM base address register Chris Wilson (2): drm/i915: Skip switch-to-kernel-context on suspend when wedged drm/i915: Call i915_gem_init_userptr() before taking struct_mutex Christian König (2): drm/ttm: swap consecutive allocated cached pages v3 drm/ttm: swap consecutive allocated pooled pages v4 Daniel Vetter (1): drm: safely free connectors from connector_iter Dave Airlie (5): Merge branch 'drm-fixes-4.15' of git://people.freedesktop.org/~agd5f/linux into drm-fixes Merge tag 'drm-misc-fixes-2017-12-06' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes Merge tag 'exynos-drm-fixes-for-v4.15-rc3' of git://git.kernel.org/.../daeinki/drm-exynos into drm-fixes Merge tag 'drm-intel-fixes-2017-12-07' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes Merge tag 'drm-misc-fixes-2017-12-07' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes Inki Dae (2): drm/exynos: remove unnecessary descrptions drm/exynos: remove unnecessary function declaration James Ausmus (1): drm/i915/cnl: Mask previous DDI - PLL mapping Joonas Lahtinen (1): Merge tag 'gvt-fixes-2017-12-06' of https://github.com/intel/gvt-linux into drm-intel-fixes Marek Szyprowski (3): drm/exynos: Fix dma-buf import drm/exynos: gem: Drop NONCONTIG flag for buffers allocated without IOMMU drm/bridge: analogix dp: Fix runtime PM state in get_modes() callback Radhakrishna Sripada (1): Revert "drm/i915: Display WA #1133 WaFbcSkipSegments:cnl, glk" Roger He (5): drm/ttm: use NUM_PAGES_TO_ALLOC always drm/ttm: add page order in page pool drm/ttm: add set_pages_wb for handling page order more than zero drm/ttm: add page order support in ttm_pages_put drm/ttm: roundup the shrink request to prevent skip huge pool Ville Syrjälä (1): drm/i915: Fix vblank timestamp/frame counter jumps on gen2 Xiong Zhang (1): drm/i915/gvt: Limit read hw reg to active vgpu Zhenyu Wang (2): drm/i915/gvt: Don't mark vgpu context as inactive when preempted drm/i915/gvt: set max priority for gvt context Zhi Wang (1): drm/i915/gvt: Export intel_gvt_render_mmio_to_ring_id() drivers/gpu/drm/amd/acp/Makefile | 21 +++++ drivers/gpu/drm/amd/amdgpu/Makefile | 22 ++++- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 24 +++++- drivers/gpu/drm/amd/amdkfd/Makefile | 22 ++++- drivers/gpu/drm/amd/display/Makefile | 21 +++++ drivers/gpu/drm/amd/display/amdgpu_dm/Makefile | 21 +++++ drivers/gpu/drm/amd/display/dc/Makefile | 21 +++++ drivers/gpu/drm/amd/display/dc/basics/Makefile | 21 +++++ drivers/gpu/drm/amd/display/dc/bios/Makefile | 21 +++++ drivers/gpu/drm/amd/display/dc/calcs/Makefile | 21 +++++ drivers/gpu/drm/amd/display/dc/core/dc_debug.c | 22 +++++ drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 2 +- drivers/gpu/drm/amd/display/dc/dc_helper.c | 22 +++++ drivers/gpu/drm/amd/display/dc/dce/Makefile | 21 +++++ drivers/gpu/drm/amd/display/dc/dce100/Makefile | 21 +++++ .../drm/amd/display/dc/dce100/dce100_resource.c | 2 +- .../drm/amd/display/dc/dce100/dce100_resource.h | 23 +++++ drivers/gpu/drm/amd/display/dc/dce110/Makefile | 21 +++++ .../drm/amd/display/dc/dce110/dce110_resource.c | 2 +- .../display/dc/dce110/dce110_timing_generator_v.c | 23 +++++ drivers/gpu/drm/amd/display/dc/dce112/Makefile | 21 +++++ drivers/gpu/drm/amd/display/dc/dce120/Makefile | 23 ++++- drivers/gpu/drm/amd/display/dc/dce80/Makefile | 21 +++++ drivers/gpu/drm/amd/display/dc/dcn10/Makefile | 21 +++++ drivers/gpu/drm/amd/display/dc/dml/Makefile | 21 +++++ drivers/gpu/drm/amd/display/dc/gpio/Makefile | 21 +++++ drivers/gpu/drm/amd/display/dc/i2caux/Makefile | 21 +++++ .../gpu/drm/amd/display/dc/inc/hw/link_encoder.h | 22 +++++ .../gpu/drm/amd/display/dc/inc/hw/stream_encoder.h | 22 +++++ drivers/gpu/drm/amd/display/dc/irq/Makefile | 21 +++++ drivers/gpu/drm/amd/display/dc/virtual/Makefile | 21 +++++ .../gpu/drm/amd/display/modules/freesync/Makefile | 21 +++++ drivers/gpu/drm/amd/lib/Makefile | 21 +++++ drivers/gpu/drm/amd/powerplay/Makefile | 22 ++++- drivers/gpu/drm/amd/powerplay/hwmgr/Makefile | 22 ++++- .../gpu/drm/amd/powerplay/hwmgr/pp_overdriver.c | 24 +++++- drivers/gpu/drm/amd/powerplay/inc/smu72.h | 24 +++++- drivers/gpu/drm/amd/powerplay/inc/smu72_discrete.h | 24 +++++- drivers/gpu/drm/amd/powerplay/smumgr/Makefile | 22 ++++- drivers/gpu/drm/amd/scheduler/gpu_sched_trace.h | 24 +++++- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 + drivers/gpu/drm/drm_connector.c | 28 ++++++- drivers/gpu/drm/drm_mode_config.c | 2 + drivers/gpu/drm/exynos/exynos_drm_drv.c | 46 +++++----- drivers/gpu/drm/exynos/exynos_drm_drv.h | 5 -- drivers/gpu/drm/exynos/exynos_drm_gem.c | 15 ++++ drivers/gpu/drm/exynos/exynos_drm_gem.h | 2 + drivers/gpu/drm/i915/gvt/cfg_space.c | 21 +++++ drivers/gpu/drm/i915/gvt/handlers.c | 47 ++++++++--- drivers/gpu/drm/i915/gvt/mmio.h | 2 + drivers/gpu/drm/i915/gvt/scheduler.c | 22 ++++- drivers/gpu/drm/i915/i915_gem.c | 31 +++---- drivers/gpu/drm/i915/i915_reg.h | 3 - drivers/gpu/drm/i915/intel_ddi.c | 1 + drivers/gpu/drm/i915/intel_display.c | 51 +++++++---- drivers/gpu/drm/i915/intel_pm.c | 13 --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 98 ++++++++++++++++------ drivers/gpu/drm/vc4/vc4_bo.c | 3 +- include/drm/drm_connector.h | 8 ++ 60 files changed, 1087 insertions(+), 128 deletions(-)

3 2

[PATCH] drm/vc4: Release fence after signalling
by Stefan Schake 08 Dec '17

08 Dec '17

We were never releasing the initial fence reference that is obtained through dma_fence_init. Link: https://github.com/anholt/linux/issues/122 Fixes: cdec4d361323 ("drm/vc4: Expose dma-buf fences for V3D rendering.") Signed-off-by: Stefan Schake <stschake(a)gmail.com> --- drivers/gpu/drm/vc4/vc4_gem.c | 4 +++- drivers/gpu/drm/vc4/vc4_irq.c | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_gem.c b/drivers/gpu/drm/vc4/vc4_gem.c index 6c32c89..6385409 100644 --- a/drivers/gpu/drm/vc4/vc4_gem.c +++ b/drivers/gpu/drm/vc4/vc4_gem.c @@ -888,8 +888,10 @@ struct vc4_hang_state { /* If we got force-completed because of GPU reset rather than * through our IRQ handler, signal the fence now. */ - if (exec->fence) + if (exec->fence) { dma_fence_signal(exec->fence); + dma_fence_put(exec->fence); + } if (exec->bo) { for (i = 0; i < exec->bo_count; i++) { diff --git a/drivers/gpu/drm/vc4/vc4_irq.c b/drivers/gpu/drm/vc4/vc4_irq.c index 61b2e53..26eddbb 100644 --- a/drivers/gpu/drm/vc4/vc4_irq.c +++ b/drivers/gpu/drm/vc4/vc4_irq.c @@ -139,6 +139,7 @@ list_move_tail(&exec->head, &vc4->job_done_list); if (exec->fence) { dma_fence_signal_locked(exec->fence); + dma_fence_put(exec->fence); exec->fence = NULL; } vc4_submit_next_render_job(dev); -- 1.9.1

3 2

[Bug 104003] [IGT] pm_sseu@full-enable fails with assertion: gem.spinfunc
by bugzilla-daemon＠freedesktop.org 08 Dec '17

08 Dec '17

https://bugs.freedesktop.org/show_bug.cgi?id=104003 Chris Wilson <chris(a)chris-wilson.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #4 from Chris Wilson <chris(a)chris-wilson.co.uk> --- commit 39ac6b89e9e51b55886181aabd91739ea1e61adb Author: Chris Wilson <chris(a)chris-wilson.co.uk> Date: Thu Nov 30 21:31:30 2017 +0000 igt/pm_sseu: Mark requirements with igt_require Not all platforms have a readily defined media routines, so don't assert but require they exist. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104003 Signed-off-by: Chris Wilson <chris(a)chris-wilson.co.uk> Reviewed-by: Joonas Lahtinen <joonas.lahtinen(a)linux.intel.com> The test needs to be updated to run on Cannonlake, but that's another matter. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH] drm/sun4i: validate modes for HDMI
by Hans Verkuil 08 Dec '17

08 Dec '17

When I connected my cubieboard running 4.15-rc1 to my 4k display I got no picture. Some digging found that there is no check against the upper pixelclock limit of the HDMI output, so X selects a 4kp60 format at 594 MHz, which obviously won't work. The patch below adds a check for the upper bound of what this hardware can do, and it checks if the requested tmds clock can be obtained. Signed-off-by: Hans Verkuil <hans.verkuil(a)cisco.com> --- diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c index 6d19d2ac68d1..62d52102d0f7 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c @@ -211,7 +211,17 @@ static int sun4i_hdmi_get_modes(struct drm_connector *connector) static int sun4i_hdmi_mode_valid(struct drm_connector *connector, struct drm_display_mode *mode) { - if (mode->clock > 170000) + struct sun4i_hdmi *hdmi = drm_connector_to_sun4i_hdmi(connector); + unsigned long rate = mode->clock * 1000; + long rounded_rate; + + /* 165 MHz is the typical max pixelclock frequency for HDMI <= 1.2 */ + if (rate > 165000000) + return MODE_CLOCK_HIGH; + rounded_rate = clk_round_rate(hdmi->tmds_clk, rate); + if (rounded_rate < rate) + return MODE_CLOCK_LOW; + if (rounded_rate > rate) return MODE_CLOCK_HIGH; return MODE_OK; }

1 1

[Bug 103102] Cannot wake-up with an AMD RX 480 on Linux 4.13 and Linux 4.14
by bugzilla-daemon＠freedesktop.org 08 Dec '17

08 Dec '17

https://bugs.freedesktop.org/show_bug.cgi?id=103102 Bug ID: 103102 Summary: Cannot wake-up with an AMD RX 480 on Linux 4.13 and Linux 4.14 Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: freedesktop(a)psydk.org I used to suspend/resume my system on Ubuntu 17.04 and it was fine. I installed Ubuntu 17.10 that comes with Linux 4.13 and now my system cannot wake-up anymore. I submitted the bug on Ubuntu's web site. I tried Linux 4.14 but the problem was still present. Then I've been told to open a bug here. The original bug: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1720622 /var/log/kern.log shows several errors regarding amdgpu. My RX 480 is connected to one single screen with DisplayPort. The problem occurs with both wayland and xorg. -- You are receiving this mail because: You are the assignee for the bug.

1 14

[PATCH v3 00/11] drm/fb-helper: Add .last_close and .output_poll_changed helpers
by Noralf Trønnes 08 Dec '17

08 Dec '17

The helpers are applied and have reached airlied/drm-next. amd has gained another .poll_changed user since last. i915 doesn't really need the .poll_changed helper since it now does a sync and has to open code it after: drm/i915/fbdev: Serialise early hotplug events with async fbdev config vboxvideo will be re-sent when the helper functions have landed in Greg's staging tree. Noralf. Changes since version 2: - Helper functions have been applied - Add drm/amd/display: Use drm_fb_helper_poll_changed() - Rebase drm/amdgpu patch - Rebase drm/msm patch - Drop i915 patch, not applicable after: drm/i915/fbdev: Serialise early hotplug events with async fbdev config - Drop vboxvideo patch, it will be re-sent when the helper functions have reached Greg's staging tree. Changes since version 1: - drm_device.drm_fb_helper_private -> drm_device.fb_helper (Ville) Noralf Trønnes (11): drm/amd/display: Use drm_fb_helper_poll_changed() drm/amdgpu: Use drm_fb_helper_lastclose() and _poll_changed() drm/armada: Use drm_fb_helper_lastclose() and _poll_changed() drm/exynos: Use drm_fb_helper_lastclose() and _poll_changed() drm/gma500: Use drm_fb_helper_lastclose() and _poll_changed() drm/msm: Use drm_fb_helper_lastclose() and _poll_changed() drm/nouveau: Use drm_fb_helper_output_poll_changed() drm/omap: Use drm_fb_helper_lastclose() and _poll_changed() drm/radeon: Use drm_fb_helper_lastclose() and _poll_changed() drm/rockchip: Use drm_fb_helper_lastclose() and _poll_changed() drm/tegra: Use drm_fb_helper_lastclose() and _poll_changed() drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 9 ++---- drivers/gpu/drm/amd/amdgpu/amdgpu_display.h | 2 -- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 27 ------------------ drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 4 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 4 --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/armada/armada_drm.h | 1 - drivers/gpu/drm/armada/armada_drv.c | 8 ++---- drivers/gpu/drm/armada/armada_fb.c | 11 +------- drivers/gpu/drm/armada/armada_fbdev.c | 8 ------ drivers/gpu/drm/exynos/exynos_drm_drv.c | 8 ++---- drivers/gpu/drm/exynos/exynos_drm_fb.c | 2 +- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 18 ------------ drivers/gpu/drm/exynos/exynos_drm_fbdev.h | 2 -- drivers/gpu/drm/gma500/framebuffer.c | 9 +----- drivers/gpu/drm/gma500/psb_drv.c | 15 +--------- drivers/gpu/drm/msm/msm_drv.c | 18 ++---------- drivers/gpu/drm/nouveau/nouveau_display.c | 3 +- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 8 ------ drivers/gpu/drm/nouveau/nouveau_fbcon.h | 2 -- drivers/gpu/drm/nouveau/nouveau_vga.c | 3 +- drivers/gpu/drm/nouveau/nv50_display.c | 2 +- drivers/gpu/drm/omapdrm/omap_drv.c | 34 ++--------------------- drivers/gpu/drm/radeon/radeon_display.c | 9 ++---- drivers/gpu/drm/radeon/radeon_fb.c | 22 --------------- drivers/gpu/drm/radeon/radeon_kms.c | 5 ++-- drivers/gpu/drm/radeon/radeon_mode.h | 3 -- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 9 +----- drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 9 +----- drivers/gpu/drm/tegra/drm.c | 13 ++------- drivers/gpu/drm/tegra/drm.h | 4 --- drivers/gpu/drm/tegra/fb.c | 14 ---------- 32 files changed, 29 insertions(+), 259 deletions(-) -- 2.14.2

4 16

[PATCH] drm/plane: Make framebuffer refcounting the responsibility of setplane_internal callers
by Maarten Lankhorst 08 Dec '17

08 Dec '17

lock_all_ctx in setplane_internal may return -EINTR, and __setplane_internal could return -EDEADLK. Making more special cases for fb would make the code even harder to read, so the easiest solution is not taking over the fb refcount, and making callers responsible for dropping the ref. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102707 Fixes: 13736ba3b38b ("drm/legacy: Convert setplane ioctl locking to interruptible.") Testcase: kms_atomic_interruptible Signed-off-by: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> --- drivers/gpu/drm/drm_plane.c | 42 ++++++++++++++++++++---------------------- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index 37a93cdffb4a..2c90519576a3 100644 --- a/drivers/gpu/drm/drm_plane.c +++ b/drivers/gpu/drm/drm_plane.c @@ -558,11 +558,10 @@ int drm_plane_check_pixel_format(const struct drm_plane *plane, u32 format) } /* - * setplane_internal - setplane handler for internal callers + * __setplane_internal - setplane handler for internal callers * - * Note that we assume an extra reference has already been taken on fb. If the - * update fails, this reference will be dropped before return; if it succeeds, - * the previous framebuffer (if any) will be unreferenced instead. + * This function will take a reference on the new fb for the plane + * on success. * * src_{x,y,w,h} are provided in 16.16 fixed point format */ @@ -630,14 +629,12 @@ static int __setplane_internal(struct drm_plane *plane, if (!ret) { plane->crtc = crtc; plane->fb = fb; - fb = NULL; + drm_framebuffer_get(plane->fb); } else { plane->old_fb = NULL; } out: - if (fb) - drm_framebuffer_put(fb); if (plane->old_fb) drm_framebuffer_put(plane->old_fb); plane->old_fb = NULL; @@ -685,6 +682,7 @@ int drm_mode_setplane(struct drm_device *dev, void *data, struct drm_plane *plane; struct drm_crtc *crtc = NULL; struct drm_framebuffer *fb = NULL; + int ret; if (!drm_core_check_feature(dev, DRIVER_MODESET)) return -EINVAL; @@ -717,15 +715,16 @@ int drm_mode_setplane(struct drm_device *dev, void *data, } } - /* - * setplane_internal will take care of deref'ing either the old or new - * framebuffer depending on success. - */ - return setplane_internal(plane, crtc, fb, - plane_req->crtc_x, plane_req->crtc_y, - plane_req->crtc_w, plane_req->crtc_h, - plane_req->src_x, plane_req->src_y, - plane_req->src_w, plane_req->src_h); + ret = setplane_internal(plane, crtc, fb, + plane_req->crtc_x, plane_req->crtc_y, + plane_req->crtc_w, plane_req->crtc_h, + plane_req->src_x, plane_req->src_y, + plane_req->src_w, plane_req->src_h); + + if (fb) + drm_framebuffer_put(fb); + + return ret; } static int drm_mode_cursor_universal(struct drm_crtc *crtc, @@ -788,13 +787,12 @@ static int drm_mode_cursor_universal(struct drm_crtc *crtc, src_h = fb->height << 16; } - /* - * setplane_internal will take care of deref'ing either the old or new - * framebuffer depending on success. - */ ret = __setplane_internal(crtc->cursor, crtc, fb, - crtc_x, crtc_y, crtc_w, crtc_h, - 0, 0, src_w, src_h, ctx); + crtc_x, crtc_y, crtc_w, crtc_h, + 0, 0, src_w, src_h, ctx); + + if (fb) + drm_framebuffer_put(fb); /* Update successful; save new cursor position, if necessary */ if (ret == 0 && req->flags & DRM_MODE_CURSOR_MOVE) { -- 2.15.1

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel December 2017