dri-devel December 2017

dri-devel@lists.freedesktop.org

236 participants
1514 discussions

[RESEND PATCH 0/4] drm/meson: power domain init related fixes
by Neil Armstrong 08 Dec '17

08 Dec '17

On the Amlogic Gx SoCs (GXBB, GXL & GXM), the VPU power domain is initialized by the vendor U-Boot code, but running mainline U-boot has been possible on these SoCs. But lacking such init made the system lock at kernel boot. A PM Power Domain driver has been pushed at [1] to solve the main issue. The following patches : - updates the DT bindings accordingly - adds support for missing regulators and registers init Neil Armstrong (4): dt-bindings: display: amlogic,meson-vpu: Add optional power domain property dt-bindings: display: amlogic,meson-dw-hdmi: Add optional HDMI 5V regulator drm/meson: dw_hdmi: Add support for an optional external 5V regulator drm/meson: Add missing VPU init .../devicetree/bindings/display/amlogic,meson-dw-hdmi.txt | 4 ++++ .../devicetree/bindings/display/amlogic,meson-vpu.txt | 4 ++++ drivers/gpu/drm/meson/meson_drv.c | 9 +++++++++ drivers/gpu/drm/meson/meson_dw_hdmi.c | 13 +++++++++++++ drivers/gpu/drm/meson/meson_registers.h | 4 ++++ 5 files changed, 34 insertions(+) -- 2.7.4

3 9

[RFC PATCH 0/6] drm/i915: Implement HDCP
by Sean Paul 08 Dec '17

08 Dec '17

Here's the RFC for my i915 HDCP patchset. The UABI is based on what we've been using in Chrome for the past 3 years. I posted the property to the list back then, but never had a mainline driver to implement it. I do now :-) Things are mostly in place, danvet gave me some feedback that I will incorporate in v1. However, in the interest of gaining more early feedback, I'm posting this now. TODO: - Add kerneldoc for property - Fix '//' comments - Change to MIT license - Rebase on Ville's gmbus fixes (thanks Ville) - Improve documentation on drm_intel_hdcp_shim - Fix async commit locking (ie: don't use connection_mutex) - Don't change connector->state in enable, defer to worker - Add igt coverage for the feature. Thanks! Sean Sean Paul (6): drm: Add Content Protection property drm: Add some HDCP related #defines drm/i915: Add HDCP framework + base implementation drm/i915: Add function to output Aksv over GMBUS drm/i915: Implement HDCP for HDMI drm/i915: Implement HDCP for DisplayPort drivers/gpu/drm/drm_atomic.c | 8 + drivers/gpu/drm/drm_connector.c | 43 +++ drivers/gpu/drm/drm_sysfs.c | 29 ++ drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_reg.h | 85 +++++ drivers/gpu/drm/i915/intel_atomic.c | 26 +- drivers/gpu/drm/i915/intel_ddi.c | 64 ++++ drivers/gpu/drm/i915/intel_dp.c | 243 +++++++++++++- drivers/gpu/drm/i915/intel_drv.h | 53 +++ drivers/gpu/drm/i915/intel_hdcp.c | 636 ++++++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_hdmi.c | 253 ++++++++++++++ drivers/gpu/drm/i915/intel_i2c.c | 54 ++- include/drm/drm_connector.h | 16 + include/drm/drm_dp_helper.h | 17 + include/drm/drm_hdcp.h | 44 +++ include/uapi/drm/drm_mode.h | 4 + 17 files changed, 1560 insertions(+), 17 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_hdcp.c create mode 100644 include/drm/drm_hdcp.h -- 2.15.0.531.g2ccb3012c9-goog

9 27

[Bug 103168] [CI] igt@prime_mmap_coherency@write - fail - Failed assertion: !(stale)
by bugzilla-daemon＠freedesktop.org 08 Dec '17

08 Dec '17

https://bugs.freedesktop.org/show_bug.cgi?id=103168 Marta Löfstedt <marta.lofstedt(a)intel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 103168] [CI] igt@prime_mmap_coherency@write - fail - Failed assertion: !(stale)
by bugzilla-daemon＠freedesktop.org 08 Dec '17

08 Dec '17

https://bugs.freedesktop.org/show_bug.cgi?id=103168 Marta Löfstedt <marta.lofstedt(a)intel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |WORKSFORME --- Comment #5 from Marta Löfstedt <marta.lofstedt(a)intel.com> --- last seen CI_DRM_3320: 2017-11-08 / 189 runs ago I will close and archive -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 99851] [drm:.r600_ring_test [radeon]] *ERROR* radeon: ring 0 test failed (scratch(0x8504)=0xCAFEDEAD)
by bugzilla-daemon＠freedesktop.org 08 Dec '17

08 Dec '17

https://bugs.freedesktop.org/show_bug.cgi?id=99851 --- Comment #58 from intermediadc(a)hotmail.com <intermediadc(a)hotmail.com> --- (In reply to erhard_f from comment #57) > Had some time to test kernels 4.14.4 and 4.15-rc2. Sadly nothing new > concerning this issue. yes nothing change , mee to continue dont have gpu accelerations on r600 .... but on ppc world look like the emb are not effected . -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH] drm/i915: Increase max texture to 16k for gen9+
by Alex Tu 08 Dec '17

08 Dec '17

Rrefer to another patch [1] on mesa to extend width/height to 16384. For issue : - https://bugs.freedesktop.org/show_bug.cgi?id=102508 - LP: #1714178 Triple monitor display failed with Dell Dock (HiDPI) [1] https://patchwork.freedesktop.org/patch/124918/ Signed-off-by: Alex Tu <alex.tu(a)canonical.com> --- drivers/gpu/drm/i915/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 47a2f6acee50..556fa57b18b8 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -13905,7 +13905,7 @@ u32 intel_fb_pitch_limit(struct drm_i915_private *dev_priv, /* "The stride in bytes must not exceed the of the size of 8K * pixels and 32K bytes." */ - return min(8192 * cpp, 32768); + return min(16384 * cpp, 65536); } else if (gen >= 5 && !HAS_GMCH_DISPLAY(dev_priv)) { return 32*1024; } else if (gen >= 4) { @@ -14604,8 +14604,8 @@ int intel_modeset_init(struct drm_device *dev) dev->mode_config.max_width = 4096; dev->mode_config.max_height = 4096; } else { - dev->mode_config.max_width = 8192; - dev->mode_config.max_height = 8192; + dev->mode_config.max_width = 16384; + dev->mode_config.max_height = 16384; } if (IS_I845G(dev_priv) || IS_I865G(dev_priv)) { -- 2.11.0

5 7

[PULL] drm-intel-next
by Rodrigo Vivi 07 Dec '17

07 Dec '17

Hi Dave, Here goes drm-intel-next-2017-12-01. As Gustavo already pointed out, when applying this and drm-misc-next you will get the build failure. And the fix up is: - enum plane plane; + enum i9xx_plane_id plane; Changes on this tag: - Init clock gate fix (Ville) - Execlists event handling corrections (Chris, Michel) - Improvements on GPU Cache invalidation and context switch (Chris) - More perf OA changes (Lionel) - More selftests improvements and fixes (Chris, Matthew) - Clean-up on modules parameters (Chris) - Clean-up around old ringbuffer submission and hw semaphore on old platforms (Chris) - More Cannonlake stabilization effort (David, James) - Display planes clean-up and improvements (Ville) - New PMU interface for perf queries... (Tvrtko) - ... and other subsequent PMU changes and fixes (Tvrtko, Chris) - Remove success dmesg noise from rotation (Chris) - New DMC for Kabylake (Anusha) - Fixes around atomic commits (Daniel) - GuC updates and fixes (Sagar, Michal, Chris) - Couple gmbus/i2c fixes (Ville) - Use exponential backoff for all our wait_for() (Chris) - Fixes for i915/fbdev (Chris) - Backlight fixes (Arnd) - Updates on shrinker (Chris) - Make Hotplug enable more robuts (Chris) - Disable huge pages (TPH) on lack of a needed workaround (Joonas) - New GuC images for SKL, KBL, BXT (Sagar) - Add HW Workaround for Geminilake performance (Valtteri) - Fixes for PPS timings (Imre) - More IPS fixes (Maarten) - Many fixes for Display Port on gen2-gen4 (Ville) - Retry GPU reset making the recover from hang more robust (Chris) Thanks, Rodrigo.The following changes since commit 010d118c20617021025a930bc8e90f371ab99da5: drm/i915: Update DRIVER_DATE to 20171117 (2017-11-17 14:47:02 -0800) are available in the git repository at: git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-next-2017-12-01 for you to fetch changes up to d65efe7c951371fbad2c426b59bbac8bf2e60662: drm/i915: Update DRIVER_DATE to 20171201 (2017-12-01 17:07:19 -0800) ---------------------------------------------------------------- drm-intel-next-2017-12-01: - Init clock gate fix (Ville) - Execlists event handling corrections (Chris, Michel) - Improvements on GPU Cache invalidation and context switch (Chris) - More perf OA changes (Lionel) - More selftests improvements and fixes (Chris, Matthew) - Clean-up on modules parameters (Chris) - Clean-up around old ringbuffer submission and hw semaphore on old platforms (Chris) - More Cannonlake stabilization effort (David, James) - Display planes clean-up and improvements (Ville) - New PMU interface for perf queries... (Tvrtko) - ... and other subsequent PMU changes and fixes (Tvrtko, Chris) - Remove success dmesg noise from rotation (Chris) - New DMC for Kabylake (Anusha) - Fixes around atomic commits (Daniel) - GuC updates and fixes (Sagar, Michal, Chris) - Couple gmbus/i2c fixes (Ville) - Use exponential backoff for all our wait_for() (Chris) - Fixes for i915/fbdev (Chris) - Backlight fixes (Arnd) - Updates on shrinker (Chris) - Make Hotplug enable more robuts (Chris) - Disable huge pages (TPH) on lack of a needed workaround (Joonas) - New GuC images for SKL, KBL, BXT (Sagar) - Add HW Workaround for Geminilake performance (Valtteri) - Fixes for PPS timings (Imre) - More IPS fixes (Maarten) - Many fixes for Display Port on gen2-gen4 (Ville) - Retry GPU reset making the recover from hang more robust (Chris) ---------------------------------------------------------------- Anusha Srivatsa (1): drm/i915/dmc: DMC 1.04 for Kabylake Arnd Bergmann (2): drm/i915: fix intel_backlight_device_register declaration drm/i915: hide unused intel_panel_set_backlight function Chris Wilson (39): drm/i915/execlists: Listen to COMPLETE context event not ACTIVE_IDLE drm/i915/execlists: Reduce completed event mask to COMPLETE | PREEMPTED drm/i915/execlists: Assert that we don't get mixed IDLE_ACTIVE | COMPLETE events drm/i915: Pull the unconditional GPU cache invalidation into request construction drm/i915: Automatic i915_switch_context for legacy drm/i915/selftest: Make guc clients static drm/i915: Remove i915.enable_execlists module parameter drm/i915: Remove obsolete ringbuffer emission for gen8+ drm/i915: Disable semaphores on Sandybridge drm/i915: Move debugfs/i915_semaphore_status to i915_engine_info drm/i915: Remove i915.semaphores modparam drm/i915/selftests: Declare we allocated the guc clients drm/i915/selftests: Avoid drm_gem_handle_create under struct_mutex drm/i915/selftests: Use NOWARN for large allocations drm/i915: Remove success dmesg noise for intel_rotate_pages() drm/i915: Call i915_gem_init_userptr() before taking struct_mutex drm/i915: Save/restore irq state for vlv_residency_raw() drm/i915: Unwind incomplete legacy context switches drm/i915: Move mi_set_context() into the legacy ringbuffer submission drm/i915/pmu: Hide the (unsigned long)ptr cast drm/i915/selftests: Hold rpm wakeref for request + ggtt usage drm/i915/pmu: Remove conditional HOTPLUG_CPU registration drm/i915: Select DEBUG_FS for our test suite drm/i915/guc: Advance over port[0] if set and not preempting drm/i915/guc: Tidy ELSP port assignment drm/i915: Use exponential backoff for wait_for() drm/i915/fbdev: Serialise early hotplug events with async fbdev config drm/i915: Flush everything on switching to the kernel_context drm/i915: Record default HW state in the GPU error state drm/i915: Rename shrinker init/cleanup to match driver initialisation phase drm/i915: Update shrinker drm_i915_private naming convention drm/i915: Rename i915_gem_timelines_mark_idle drm/i915: Enable hotplug polling after registering the outputs drm/i915: Skip switch-to-kernel-context on suspend when wedged drm/i915: Tidy up signed/unsigned comparison drm/i915: Set fake_vma.size as well as fake_vma.node.size for capture drm/i915/selftests: Wake the device before executing requests on the GPU drm/i915: Sleep and retry a GPU reset if at first we don't succeed drm/i915: Remove unsafe i915.enable_rc6 Daniel Vetter (2): drm/i915: sync dp link status checks against atomic commmits drm/i915: remove stale comment from sanitize_encoder David Weinehall (1): drm/i915: Don't use GEN6_RC_VIDEO_FREQ on gen10+ Imre Deak (1): drm/i915: Avoid PPS HW/SW state mismatch due to rounding James Ausmus (1): drm/i915/cnl: Mask previous DDI - PLL mapping Joonas Lahtinen (1): drm/i915: Disable THP until we have a GPU read BW W/A Lionel Landwerlin (2): drm/i915/perf: replace .reg accesses with i915_mmio_reg_offset drm/i915/perf: reuse timestamp frequency from device info Maarten Lankhorst (2): drm/i915: Make ips_enabled a property depending on whether IPS is enabled, v3. drm/i915: Enable IPS with only sprite plane visible too, v4. Matthew Auld (2): drm/i915/selftests: rein in igt_write_huge drm/i915/selftests: test descending addresses Michal Wajdeczko (2): drm/i915/guc: Rename i915_guc_reg.h to intel_guc_reg.h drm/i915/guc: Use consistent name for scratch register count Michel Thierry (1): drm/i915/execlists: Delay writing to ELSP until HW has processed the previous write Rodrigo Vivi (1): drm/i915: Update DRIVER_DATE to 20171201 Sagar Arun Kamble (4): drm/i915/guc: Update header guard name of intel_guc_submission.h drm/i915/guc: Change default GuC FW for SKL to v9.33 drm/i915/guc: Change default GuC FW for BXT to v9.29 drm/i915/guc: Change default GuC FW for KBL to v9.39 Tvrtko Ursulin (17): drm/i915: Extract intel_get_cagf drm/i915/pmu: Expose a PMU interface for perf queries drm/i915/pmu: Suspend sampling when GPU is idle drm/i915: Wrap context schedule notification drm/i915: Engine busy time tracking drm/i915/pmu: Wire up engine busy stats to PMU drm/i915/pmu: Add interrupt count metric drm/i915: Convert intel_rc6_residency_us to ns drm/i915/pmu: Add RC6 residency metrics drm/i915/pmu: Drop I915_ENGINE_SAMPLE_MAX from uapi headers drm/i915/pmu: Clear the previous sample value when parking drm/i915/pmu: Only allow running on a single CPU drm/i915/pmu: Stop averaging with the previous sample drm/i915/pmu: Aggregate all RC6 states into one counter drm/i915/pmu: Return -EINVAL when selecting the inactive CPU drm/i915: Move engine->needs_cmd_parser to engine->flags drm/i915: Consolidate checks for engine stats availability Valtteri Rantala (1): drm/i915/glk: Apply WaProgramL3SqcReg1DefaultForPerf for GLK too Ville Syrjälä (21): drm/i915: Fix init_clock_gating for resume drm/i915: Add .get_hw_state() method for planes drm/i915: Redo plane sanitation during readout drm/i915: s/enum plane/enum i9xx_plane_id/ drm/i915: Use enum i9xx_plane_id for the .get_fifo_size() hooks drm/i915: Cleanup enum pipe/enum plane_id/enum i9xx_plane_id in initial fb readout drm/i915: Nuke ironlake_get_initial_plane_config() drm/i915: Switch fbc over to for_each_new_intel_plane_in_state() drm/i915: Nuke crtc->plane drm/i915: Use plane->get_hw_state() for initial plane fb readout drm/i915: Add rudimentary plane state verification drm/i915: Don't try indexed reads to alternate slave addresses drm/i915: Prevent zero length "index" write drm/i915: Disable DP audio for g4x drm/i915: Don't add the "force audio" property to DP connectors that don't support audio drm/i915: Fix has_audio readout for DDI A drm/i915: Fix deadlock in i830_disable_pipe() drm/i915: Fix vblank timestamp/frame counter jumps on gen2 drm/i915: Wait for pipe to start on i830 as well drm/i915: Pass crtc state to intel_pipe_{enable,disable}() drm/i915: Interlaced DP output doesn't work on VLV/CHV drivers/gpu/drm/i915/Kconfig.debug | 1 + drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gvt/render.c | 3 +- drivers/gpu/drm/i915/i915_cmd_parser.c | 7 +- drivers/gpu/drm/i915/i915_debugfs.c | 143 +--- drivers/gpu/drm/i915/i915_drv.c | 68 +- drivers/gpu/drm/i915/i915_drv.h | 56 +- drivers/gpu/drm/i915/i915_gem.c | 64 +- drivers/gpu/drm/i915/i915_gem_context.c | 316 +------- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 17 +- drivers/gpu/drm/i915/i915_gem_gtt.c | 11 +- drivers/gpu/drm/i915/i915_gem_render_state.c | 4 - drivers/gpu/drm/i915/i915_gem_request.c | 25 +- drivers/gpu/drm/i915/i915_gem_shrinker.c | 138 ++-- drivers/gpu/drm/i915/i915_gem_timeline.c | 6 +- drivers/gpu/drm/i915/i915_gem_timeline.h | 2 +- drivers/gpu/drm/i915/i915_gemfs.c | 3 +- drivers/gpu/drm/i915/i915_gpu_error.c | 60 +- drivers/gpu/drm/i915/i915_irq.c | 4 +- drivers/gpu/drm/i915/i915_params.c | 15 - drivers/gpu/drm/i915/i915_params.h | 3 - drivers/gpu/drm/i915/i915_pci.c | 2 + drivers/gpu/drm/i915/i915_perf.c | 86 +- drivers/gpu/drm/i915/i915_pmu.c | 865 +++++++++++++++++++++ drivers/gpu/drm/i915/i915_pmu.h | 111 +++ drivers/gpu/drm/i915/i915_reg.h | 3 + drivers/gpu/drm/i915/i915_sysfs.c | 33 +- drivers/gpu/drm/i915/intel_cdclk.c | 2 +- drivers/gpu/drm/i915/intel_csr.c | 4 +- drivers/gpu/drm/i915/intel_ddi.c | 21 +- drivers/gpu/drm/i915/intel_display.c | 810 ++++++++++--------- drivers/gpu/drm/i915/intel_dp.c | 81 +- drivers/gpu/drm/i915/intel_drv.h | 30 +- drivers/gpu/drm/i915/intel_engine_cs.c | 167 +++- drivers/gpu/drm/i915/intel_fbc.c | 35 +- drivers/gpu/drm/i915/intel_fbdev.c | 10 +- drivers/gpu/drm/i915/intel_guc.c | 3 +- drivers/gpu/drm/i915/intel_guc.h | 2 +- drivers/gpu/drm/i915/intel_guc_fw.c | 14 +- .../drm/i915/{i915_guc_reg.h => intel_guc_reg.h} | 7 +- drivers/gpu/drm/i915/intel_guc_submission.c | 38 +- drivers/gpu/drm/i915/intel_guc_submission.h | 4 +- drivers/gpu/drm/i915/intel_gvt.c | 5 - drivers/gpu/drm/i915/intel_hangcheck.c | 44 +- drivers/gpu/drm/i915/intel_i2c.c | 4 +- drivers/gpu/drm/i915/intel_lrc.c | 86 +- drivers/gpu/drm/i915/intel_lrc.h | 4 - drivers/gpu/drm/i915/intel_panel.c | 88 +-- drivers/gpu/drm/i915/intel_pipe_crc.c | 2 - drivers/gpu/drm/i915/intel_pm.c | 234 +++--- drivers/gpu/drm/i915/intel_ringbuffer.c | 624 ++++++--------- drivers/gpu/drm/i915/intel_ringbuffer.h | 174 ++++- drivers/gpu/drm/i915/intel_sprite.c | 85 +- drivers/gpu/drm/i915/intel_uc_fw.c | 2 +- drivers/gpu/drm/i915/intel_uncore.c | 3 - drivers/gpu/drm/i915/selftests/huge_pages.c | 176 +++-- drivers/gpu/drm/i915/selftests/i915_gem_context.c | 31 +- drivers/gpu/drm/i915/selftests/i915_gem_evict.c | 2 + drivers/gpu/drm/i915/selftests/i915_gem_request.c | 20 - drivers/gpu/drm/i915/selftests/i915_random.c | 2 +- drivers/gpu/drm/i915/selftests/intel_guc.c | 4 +- drivers/gpu/drm/i915/selftests/intel_hangcheck.c | 9 - include/uapi/drm/i915_drm.h | 40 + 63 files changed, 2851 insertions(+), 2063 deletions(-) create mode 100644 drivers/gpu/drm/i915/i915_pmu.c create mode 100644 drivers/gpu/drm/i915/i915_pmu.h rename drivers/gpu/drm/i915/{i915_guc_reg.h => intel_guc_reg.h} (98%)

1 0

[PATCH 1/5] drm/vblank: Do not update vblank counts if vblanks are already disabled.
by Dhinakaran Pandiyan 07 Dec '17

07 Dec '17

Updating the vblank counts requires register reads and these reads may not return meaningful values after the vblank interrupts are disabled as the device may go to low power state. An additional change would be to allow the driver to save the vblank counts before entering a low power state, but that's for the future. Also, disable vblanks after reading the HW counter in the case where _crtc_vblank_off() is disabling vblanks. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan(a)intel.com> --- drivers/gpu/drm/drm_vblank.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c index 32d9bcf5be7f..7eee82c06ed8 100644 --- a/drivers/gpu/drm/drm_vblank.c +++ b/drivers/gpu/drm/drm_vblank.c @@ -347,23 +347,14 @@ void drm_vblank_disable_and_save(struct drm_device *dev, unsigned int pipe) spin_lock_irqsave(&dev->vblank_time_lock, irqflags); /* - * Only disable vblank interrupts if they're enabled. This avoids - * calling the ->disable_vblank() operation in atomic context with the - * hardware potentially runtime suspended. - */ - if (vblank->enabled) { - __disable_vblank(dev, pipe); - vblank->enabled = false; - } - - /* - * Always update the count and timestamp to maintain the + * Update the count and timestamp to maintain the * appearance that the counter has been ticking all along until * this time. This makes the count account for the entire time * between drm_crtc_vblank_on() and drm_crtc_vblank_off(). */ drm_update_vblank_count(dev, pipe, false); - + __disable_vblank(dev, pipe); + vblank->enabled = false; spin_unlock_irqrestore(&dev->vblank_time_lock, irqflags); } @@ -1122,8 +1113,12 @@ void drm_crtc_vblank_off(struct drm_crtc *crtc) pipe, vblank->enabled, vblank->inmodeset); /* Avoid redundant vblank disables without previous - * drm_crtc_vblank_on(). */ - if (drm_core_check_feature(dev, DRIVER_ATOMIC) || !vblank->inmodeset) + * drm_crtc_vblank_on() and only disable them if they're enabled. This + * avoids calling the ->disable_vblank() operation in atomic context + * with the hardware potentially runtime suspended. + */ + if ((drm_core_check_feature(dev, DRIVER_ATOMIC) || !vblank->inmodeset) && + vblank->enabled) drm_vblank_disable_and_save(dev, pipe); wake_up(&vblank->queue); -- 2.11.0

3 6

[PULL] drm-misc-fixes
by Daniel Vetter 07 Dec '17

07 Dec '17

Hi Dave, drm-misc-fixes-2017-12-07: regression fix for vc4 + rpm stable fix for analogix bridge Of course I do a pull, 2 more patches show up. Flushed them out since you'll be out next week. Cheers, Daniel The following changes since commit a703c55004e1c5076d57e43771b3e11117796ea0: drm: safely free connectors from connector_iter (2017-12-06 10:22:55 +0100) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-fixes-2017-12-07 for you to fetch changes up to 510353a63796d467b41237ab4f136136f68c297d: drm/bridge: analogix dp: Fix runtime PM state in get_modes() callback (2017-12-07 20:12:39 +0530) ---------------------------------------------------------------- regression fix for vc4 + rpm stable fix for analogix bridge ---------------------------------------------------------------- Boris Brezillon (1): drm/vc4: Fix false positive WARN() backtrace on refcount_inc() usage Marek Szyprowski (1): drm/bridge: analogix dp: Fix runtime PM state in get_modes() callback drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 ++ drivers/gpu/drm/vc4/vc4_bo.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

1 0

[PATCH] drm/i915: add FTRACE dependency for DRM_I915_TRACE_GEM
by Arnd Bergmann 07 Dec '17

07 Dec '17

The new trace option gratuitously added a 'select TRACING' statement, which now causes build failures in other code that assumed tracepoints were only available with FTRACE: ERROR: "__tracepoint_ucsi_command" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! ERROR: "__tracepoint_ucsi_register_port" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! ERROR: "__tracepoint_ucsi_notify" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! ERROR: "__tracepoint_ucsi_reset_ppm" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! ERROR: "__tracepoint_ucsi_run_command" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! drivers/usb/dwc3/gadget.o: In function `__dwc3_prepare_one_trb': gadget.c:(.text+0x1c5): undefined reference to `__tracepoint_dwc3_prepare_trb' drivers/usb/dwc3/gadget.o: In function `__dwc3_cleanup_done_trbs': gadget.c:(.text+0x3f0): undefined reference to `__tracepoint_dwc3_complete_trb' drivers/usb/dwc3/gadget.o: In function `dwc3_gadget_ep_free_request': gadget.c:(.text+0x666): undefined reference to `__tracepoint_dwc3_free_request' This adds an explicit FTRACE dependency here, to ensure this is already the case. This matches what the other drivers have that select TRACING. Generally speaking, there is a bigger problem with CONFIG_DRM_I915_DEBUG though, it selects several other partially related symbols (DEBUGFS, I2C_CHARDEV, PREEMPT_COUNT, X86_MSR, etc that are each user-visible and that other symbols in turn depend on. This can easily lead to circular dependencies and should be avoided. I tried turning those all into 'depends on', which is normally a good strategy, but that seems to completely defeat the intention of CONFIG_DRM_I915_DEBUG. It might be better to just remove this completely, possibly replace it with a Kconfig fragment. Fixes: bccd3b831185 ("drm/i915: Use trace_printk to provide a death rattle for GEM") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- drivers/gpu/drm/i915/Kconfig.debug | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug index fa36491495b1..1a1b9732f657 100644 --- a/drivers/gpu/drm/i915/Kconfig.debug +++ b/drivers/gpu/drm/i915/Kconfig.debug @@ -18,6 +18,7 @@ config DRM_I915_WERROR config DRM_I915_DEBUG bool "Enable additional driver debugging" depends on DRM_I915 + depends on FTRACE # for DRM_I915_TRACE_GEM select DEBUG_FS select PREEMPT_COUNT select I2C_CHARDEV @@ -53,6 +54,7 @@ config DRM_I915_DEBUG_GEM config DRM_I915_TRACE_GEM bool "Insert extra ftrace output from the GEM internals" + depends on FTRACE select TRACING default n help -- 2.9.0

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel December 2017