dri-devel December 2017

dri-devel@lists.freedesktop.org

236 participants
1514 discussions

[PATCH] drm: msm: avoid false-positive -Wmaybe-uninitialized warning
by Arnd Bergmann 04 Dec '17

04 Dec '17

gcc-8 -fsanitize-coverage=trace-pc produces a false-positive warning: drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c: In function 'mdp5_plane_mode_set.isra.8': drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c:1053:3: error: 'crtc_x_r' may be used uninitialized in this function [-Werror=maybe-uninitialized] It's relatively clear from reading the source that this cannot happen, and older compilers get it right. This rearranges the code remove the two affected variables, which reliably avoids the problem. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c index be50445f9901..c50449882037 100644 --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c @@ -964,8 +964,6 @@ static int mdp5_plane_mode_set(struct drm_plane *plane, uint32_t src_x, src_y; uint32_t src_w, src_h; uint32_t src_img_w, src_img_h; - uint32_t src_x_r; - int crtc_x_r; int ret; nplanes = fb->format->num_planes; @@ -1010,9 +1008,6 @@ static int mdp5_plane_mode_set(struct drm_plane *plane, crtc_w /= 2; src_w /= 2; src_img_w /= 2; - - crtc_x_r = crtc_x + crtc_w; - src_x_r = src_x + src_w; } ret = calc_scalex_steps(plane, pix_format, src_w, crtc_w, step.x); @@ -1052,9 +1047,9 @@ static int mdp5_plane_mode_set(struct drm_plane *plane, if (right_hwpipe) mdp5_hwpipe_mode_set(mdp5_kms, right_hwpipe, fb, &step, &pe, config, hdecm, vdecm, hflip, vflip, - crtc_x_r, crtc_y, crtc_w, crtc_h, + crtc_x + crtc_w, crtc_y, crtc_w, crtc_h, src_img_w, src_img_h, - src_x_r, src_y, src_w, src_h); + src_x + src_w, src_y, src_w, src_h); plane->fb = fb; -- 2.9.0

2 2

[PATCH] arm64: dts: exynos: increase bus frequency for MHL chip
by Andrzej Hajda 04 Dec '17

04 Dec '17

sii8620 supports 1MHz clock, it allows faster transmissions and according to extensive tests allows to mitigate some obscure bugs in I2C client logic of the chip. Signed-off-by: Andrzej Hajda <a.hajda(a)samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi index 39b1ca0ef4cd..a4b1d9ba7e4b 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi @@ -778,6 +778,7 @@ &hsi2c_7 { status = "okay"; + clock-frequency = <1000000>; sii8620@39 { reg = <0x39>; -- 2.15.0

2 1

[PATCH][next] drm/i915/gvt: Add missing breaks in switch statement
by Colin King 04 Dec '17

04 Dec '17

From: Colin Ian King <colin.king(a)canonical.com> The switch statement is missing breaks for the cases of GVT_FAILSAFE_INSUFFICIENT_RESOURCE and GVT_FAILSAFE_GUEST_ERR. Add them in. Detected by CoverityScan, CID#1462416 ("Missing break in switch") Fixes: e011c6ce2b4f ("drm/i915/gvt: Add VM healthy check for workload_thread") Fixes: a33fc7a0482a ("drm/i915/gvt: enter failsafe mode when guest requires more resources") Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- drivers/gpu/drm/i915/gvt/handlers.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c index 94fc04210bac..7354ed816f92 100644 --- a/drivers/gpu/drm/i915/gvt/handlers.c +++ b/drivers/gpu/drm/i915/gvt/handlers.c @@ -174,8 +174,10 @@ void enter_failsafe_mode(struct intel_vgpu *vgpu, int reason) break; case GVT_FAILSAFE_INSUFFICIENT_RESOURCE: pr_err("Graphics resource is not enough for the guest\n"); + break; case GVT_FAILSAFE_GUEST_ERR: pr_err("GVT Internal error for the guest\n"); + break; default: break; } -- 2.14.1

1 0

[GIT PULL FOR v4.16] R-Car DU changes
by Laurent Pinchart 04 Dec '17

04 Dec '17

Hi Dave, The following changes since commit ca797d29cd63e7b71b4eea29aff3b1cefd1ecb59: Merge tag 'drm-intel-next-2017-11-17-1' of git://anongit.freedesktop.org/ drm/drm-intel into drm-next (2017-12-04 10:56:53 +1000) are available in the git repository at: git://linuxtv.org/pinchartl/media.git drm/next/du for you to fetch changes up to 401712e035c699d569dbd37024f4b21dc76cc870: drm: rcar-du: Clip planes to screen boundaries (2017-12-04 18:38:31 +0200) The series contains one patch that touches the V4L2 VSP driver. Mauro has acked it for merge through your tree, it doesn't conflict with anything scheduled for merge in v4.16 through Mauro's tree. ---------------------------------------------------------------- Fabrizio Castro (3): dt-bindings: display: rcar-du: Document R8A774[35] DU drm: rcar-du: Add R8A7743 support drm: rcar-du: Add R8A7745 support Kieran Bingham (2): drm: rcar-du: Implement system suspend/resume support drm: rcar-du: Remove unused CRTC suspend/resume functions Laurent Pinchart (4): drm: rcar-du: Don't set connector DPMS property v4l: vsp1: Start and stop DRM pipeline independently of planes drm: rcar-du: Share plane atomic check code between Gen2 and Gen3 drm: rcar-du: Clip planes to screen boundaries .../devicetree/bindings/display/renesas,du.txt | 30 +++++----- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 38 +------------ drivers/gpu/drm/rcar-du/rcar_du_drv.c | 62 +++++++++++++++- drivers/gpu/drm/rcar-du/rcar_du_drv.h | 1 + drivers/gpu/drm/rcar-du/rcar_du_lvdscon.c | 4 -- drivers/gpu/drm/rcar-du/rcar_du_plane.c | 75 ++++++++++++---- drivers/gpu/drm/rcar-du/rcar_du_plane.h | 4 ++ drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 64 ++++++---------- drivers/media/platform/vsp1/vsp1_drm.c | 37 ++++++++---- 9 files changed, 187 insertions(+), 128 deletions(-) -- Regards, Laurent Pinchart

1 0

[PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399
by Brian Norris 04 Dec '17

04 Dec '17

From: Nickey Yang <nickey.yang(a)rock-chips.com> We might include additional ports in derivative device trees, so the 'port' node should have an address, and the parent 'ports' node needs /#{addres,size}-cells. v4: * keep #{address,size}-cells in both 'ports' and 'port@0' nodes * separate from the rest of the series, since this is mostly independent of the driver refactoring Signed-off-by: Nickey Yang <nickey.yang(a)rock-chips.com> Signed-off-by: Brian Norris <briannorris(a)chromium.org> --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index d340b58ab184..c6dae25a3f23 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi @@ -1652,7 +1652,11 @@ status = "disabled"; ports { - mipi_in: port { + #address-cells = <1>; + #size-cells = <0>; + + mipi_in: port@0 { + reg = <0>; #address-cells = <1>; #size-cells = <0>; -- 2.15.0.531.g2ccb3012c9-goog

4 5

[PATCH] drm: nouveau: use correct string length
by Arnd Bergmann 04 Dec '17

04 Dec '17

gcc-8 reports drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c: In function 'nvkm_perfmon_mthd': include/linux/string.h:265:9: error: '__builtin_strncpy' specified bound 64 equals destination size [-Werror=stringop-truncation] We need one less byte or call strlcpy() to make it a nul-terminated string. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c b/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c index dde89a4a0f5b..53859b6254d6 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c @@ -462,7 +462,7 @@ nvkm_perfmon_mthd_query_domain(struct nvkm_perfmon *perfmon, args->v0.id = di; args->v0.signal_nr = nvkm_perfdom_count_perfsig(dom); - strncpy(args->v0.name, dom->name, sizeof(args->v0.name)); + strncpy(args->v0.name, dom->name, sizeof(args->v0.name) - 1); /* Currently only global counters (PCOUNTER) are implemented * but this will be different for local counters (MP). */ @@ -514,7 +514,7 @@ nvkm_perfmon_mthd_query_signal(struct nvkm_perfmon *perfmon, "/%s/%02x", dom->name, si); } else { strncpy(args->v0.name, sig->name, - sizeof(args->v0.name)); + sizeof(args->v0.name) - 1); } args->v0.signal = si; @@ -572,7 +572,7 @@ nvkm_perfmon_mthd_query_source(struct nvkm_perfmon *perfmon, args->v0.source = sig->source[si]; args->v0.mask = src->mask; - strncpy(args->v0.name, src->name, sizeof(args->v0.name)); + strncpy(args->v0.name, src->name, sizeof(args->v0.name) - 1); } if (++si < source_nr) { -- 2.9.0

1 0

[PATCH] gpu: ipu-v3: prg: avoid possible array underflow
by Arnd Bergmann 04 Dec '17

04 Dec '17

gcc-8 reports that we access an array with a negative index in an error case: drivers/gpu/ipu-v3/ipu-prg.c: In function 'ipu_prg_channel_disable': drivers/gpu/ipu-v3/ipu-prg.c:252:43: error: array subscript -22 is below array bounds of 'struct ipu_prg_channel[3]' [-Werror=array-bounds] This moves the range check in front of the dereference. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- drivers/gpu/ipu-v3/ipu-prg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/ipu-v3/ipu-prg.c b/drivers/gpu/ipu-v3/ipu-prg.c index 0013ca9f72c8..1417db856989 100644 --- a/drivers/gpu/ipu-v3/ipu-prg.c +++ b/drivers/gpu/ipu-v3/ipu-prg.c @@ -252,7 +252,7 @@ void ipu_prg_channel_disable(struct ipuv3_channel *ipu_chan) struct ipu_prg_channel *chan = &prg->chan[prg_chan]; u32 val; - if (!chan->enabled || prg_chan < 0) + if (prg_chan < 0 || !chan->enabled) return; clk_prepare_enable(prg->clk_ipg); -- 2.9.0

1 0

[Bug 103829] [CI] igt@gem_busy@close-race - fail - Failed assertion: gem_bo_busy(fd, object[0].handle)
by bugzilla-daemon＠freedesktop.org 04 Dec '17

04 Dec '17

https://bugs.freedesktop.org/show_bug.cgi?id=103829 Chris Wilson <chris(a)chris-wilson.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Chris Wilson <chris(a)chris-wilson.co.uk> --- commit 7e07894d8b0f567cb4241b5bed8a9644874ddd47 (HEAD, upstream/master) Author: Chris Wilson <chris(a)chris-wilson.co.uk> Date: Fri Dec 1 21:53:03 2017 +0000 igt/gem_busy: Replace arbitrary busy batch with indefinite spinbatch In CI, we were observing situations where the busy blt would complete before the very next instruction (in userspace) to assert that it was busy. This is entirely possible if the process was scheduled away and slept for longer than the arbitrary batch. Instead replace arbitrariness with a precise infinity. v2: Be respectful to UP! v3: Move spinbatch to owning process to avoid serialisation delays. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103829 Signed-off-by: Chris Wilson <chris(a)chris-wilson.co.uk> Reviewed-by: Joonas Lahtinen <joonas.lahtinen(a)linux.intel.com> (Hopefully) -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH v3 0/2] R-Car DU: Clip planes to screen boundaries
by Laurent Pinchart 04 Dec '17

04 Dec '17

Hello, This patch series fixes support for planes that cross the screen boundaries. The KMS API supports such a configuration, but the DU and VSP hardware doesn't. This leads to different kind of dispay artifacts or hangs. The series starts with a bit of refactoring to share existing code and make it easier to share new code. The second patch then clips planes that are either partially or fully off-screen, disabling planes that end up being completely invisible. Compared to v2, the series has been rebased on top of the latest drm+drm-misc to benefit from Ville's rework of the plane state check helper, and now actually uses the clipped source and destination rectangles (and hence passes the tests). Compared to v1, fully off-screen planes are now accepted (but obviously not shown). The patches are based on top of Dave's latest master branch. The series has been tested on a Salvator-XS board. Laurent Pinchart (2): drm: rcar-du: Share plane atomic check code between Gen2 and Gen3 drm: rcar-du: Clip planes to screen boundaries drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 3 +- drivers/gpu/drm/rcar-du/rcar_du_plane.c | 75 +++++++++++++++++++++++---------- drivers/gpu/drm/rcar-du/rcar_du_plane.h | 4 ++ drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 64 +++++++++++----------------- 4 files changed, 83 insertions(+), 63 deletions(-) -- Regards, Laurent Pinchart

2 3

[PATCH] drm/msm: Memory leak bug fix
by Sharat Masetty 04 Dec '17

04 Dec '17

This patch fixes a possible memory leak in get_pages() Prakash Kamliya (1): drm/msm: fix leak in failed get_pages drivers/gpu/drm/msm/msm_gem.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) -- 1.9.1

1 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel December 2017