dri-devel December 2017

dri-devel@lists.freedesktop.org

236 participants
1514 discussions

[RESENT PATCH] drm/panel: support Innolux P097PFG panel
by Lin Huang 04 Dec '17

04 Dec '17

Support Innolux P097PFG 9.7" 1536x2048 TFT LCD panel, it refactor Innolux P079ZCA panel driver, let it support multi panel, and add support P097PFG panel in this driver. Signed-off-by: Lin Huang <hl(a)rock-chips.com> --- drivers/gpu/drm/panel/panel-innolux-p079zca.c | 178 ++++++++++++++++++++------ 1 file changed, 136 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c index 6ba9344..a40798f 100644 --- a/drivers/gpu/drm/panel/panel-innolux-p079zca.c +++ b/drivers/gpu/drm/panel/panel-innolux-p079zca.c @@ -20,12 +20,32 @@ #include <video/mipi_display.h> +struct panel_desc { + const struct drm_display_mode *modes; + unsigned int bpc; + struct { + unsigned int width; + unsigned int height; + } size; +}; + +struct panel_desc_dsi { + struct panel_desc desc; + + unsigned long flags; + enum mipi_dsi_pixel_format format; + unsigned int lanes; +}; + struct innolux_panel { struct drm_panel base; struct mipi_dsi_device *link; + const struct panel_desc_dsi *dsi_desc; struct backlight_device *backlight; - struct regulator *supply; + struct regulator *vddi; + struct regulator *avdd; + struct regulator *avee; struct gpio_desc *enable_gpio; bool prepared; @@ -78,9 +98,9 @@ static int innolux_panel_unprepare(struct drm_panel *panel) /* T8: 80ms - 1000ms */ msleep(80); - err = regulator_disable(innolux->supply); - if (err < 0) - return err; + regulator_disable(innolux->avee); + regulator_disable(innolux->avdd); + regulator_disable(innolux->vddi); innolux->prepared = false; @@ -97,10 +117,18 @@ static int innolux_panel_prepare(struct drm_panel *panel) gpiod_set_value_cansleep(innolux->enable_gpio, 0); - err = regulator_enable(innolux->supply); + err = regulator_enable(innolux->vddi); if (err < 0) return err; + err = regulator_enable(innolux->avdd); + if (err < 0) + goto disable_vddi; + + err = regulator_enable(innolux->avee); + if (err < 0) + goto disable_avdd; + /* T2: 15ms - 1000ms */ usleep_range(15000, 16000); @@ -134,12 +162,13 @@ static int innolux_panel_prepare(struct drm_panel *panel) return 0; poweroff: - regulator_err = regulator_disable(innolux->supply); - if (regulator_err) - DRM_DEV_ERROR(panel->dev, "failed to disable regulator: %d\n", - regulator_err); - gpiod_set_value_cansleep(innolux->enable_gpio, 0); + regulator_disable(innolux->avee); +disable_avdd: + regulator_disable(innolux->avdd); +disable_vddi: + regulator_disable(innolux->vddi); + return err; } @@ -164,7 +193,7 @@ static int innolux_panel_enable(struct drm_panel *panel) return 0; } -static const struct drm_display_mode default_mode = { +static const struct drm_display_mode innolux_p079zca_mode = { .clock = 56900, .hdisplay = 768, .hsync_start = 768 + 40, @@ -177,15 +206,59 @@ static const struct drm_display_mode default_mode = { .vrefresh = 60, }; +static const struct panel_desc_dsi innolux_p079zca_panel_desc = { + .desc = { + .modes = &innolux_p079zca_mode, + .bpc = 8, + .size = { + .width = 120, + .height = 160, + }, + }, + .flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | + MIPI_DSI_MODE_LPM, + .format = MIPI_DSI_FMT_RGB888, + .lanes = 4, +}; + +static const struct drm_display_mode innolux_p097pfg_mode = { + .clock = 220000, + .hdisplay = 1536, + .hsync_start = 1536 + 100, + .hsync_end = 1536 + 100 + 24, + .htotal = 1536 + 100 + 24 + 100, + .vdisplay = 2048, + .vsync_start = 2048 + 18, + .vsync_end = 2048 + 18 + 2, + .vtotal = 2048 + 18 + 2 + 18, + .vrefresh = 60, +}; + +static const struct panel_desc_dsi innolux_p097pfg_panel_desc = { + .desc = { + .modes = &innolux_p097pfg_mode, + .bpc = 8, + .size = { + .width = 147, + .height = 196, + }, + }, + .flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | + MIPI_DSI_MODE_LPM, + .format = MIPI_DSI_FMT_RGB888, + .lanes = 8, +}; + static int innolux_panel_get_modes(struct drm_panel *panel) { struct drm_display_mode *mode; + struct innolux_panel *innolux = to_innolux_panel(panel); + const struct drm_display_mode *m = innolux->dsi_desc->desc.modes; - mode = drm_mode_duplicate(panel->drm, &default_mode); + mode = drm_mode_duplicate(panel->drm, m); if (!mode) { DRM_DEV_ERROR(panel->drm->dev, "failed to add mode %ux%ux@%u\n", - default_mode.hdisplay, default_mode.vdisplay, - default_mode.vrefresh); + m->hdisplay, m->vdisplay, m->vrefresh); return -ENOMEM; } @@ -193,9 +266,11 @@ static int innolux_panel_get_modes(struct drm_panel *panel) drm_mode_probed_add(panel->connector, mode); - panel->connector->display_info.width_mm = 120; - panel->connector->display_info.height_mm = 160; - panel->connector->display_info.bpc = 8; + panel->connector->display_info.width_mm = + innolux->dsi_desc->desc.size.width; + panel->connector->display_info.height_mm = + innolux->dsi_desc->desc.size.height; + panel->connector->display_info.bpc = innolux->dsi_desc->desc.bpc; return 1; } @@ -209,20 +284,39 @@ static const struct drm_panel_funcs innolux_panel_funcs = { }; static const struct of_device_id innolux_of_match[] = { - { .compatible = "innolux,p079zca", }, - { } + { .compatible = "innolux,p079zca", + .data = &innolux_p079zca_panel_desc + }, + { .compatible = "innolux,p097pfg", + .data = &innolux_p097pfg_panel_desc + } }; MODULE_DEVICE_TABLE(of, innolux_of_match); -static int innolux_panel_add(struct innolux_panel *innolux) +static int innolux_panel_add(struct mipi_dsi_device *dsi, + const struct panel_desc_dsi *desc) { - struct device *dev = &innolux->link->dev; + struct innolux_panel *innolux; + struct device *dev = &dsi->dev; struct device_node *np; int err; - innolux->supply = devm_regulator_get(dev, "power"); - if (IS_ERR(innolux->supply)) - return PTR_ERR(innolux->supply); + innolux = devm_kzalloc(dev, sizeof(*innolux), GFP_KERNEL); + if (!innolux) + return -ENOMEM; + + innolux->dsi_desc = desc; + innolux->vddi = devm_regulator_get_optional(dev, "power"); + if (IS_ERR(innolux->vddi)) + return PTR_ERR(innolux->vddi); + + innolux->avdd = devm_regulator_get(dev, "ppvarp"); + if (IS_ERR(innolux->avdd)) + return PTR_ERR(innolux->avdd); + + innolux->avee = devm_regulator_get(dev, "ppvarn"); + if (IS_ERR(innolux->avee)) + return PTR_ERR(innolux->avee); innolux->enable_gpio = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_HIGH); @@ -243,14 +337,16 @@ static int innolux_panel_add(struct innolux_panel *innolux) drm_panel_init(&innolux->base); innolux->base.funcs = &innolux_panel_funcs; - innolux->base.dev = &innolux->link->dev; + innolux->base.dev = dev; err = drm_panel_add(&innolux->base); if (err < 0) goto put_backlight; - return 0; + dev_set_drvdata(dev, innolux); + innolux->link = dsi; + return 0; put_backlight: put_device(&innolux->backlight->dev); @@ -267,28 +363,25 @@ static void innolux_panel_del(struct innolux_panel *innolux) static int innolux_panel_probe(struct mipi_dsi_device *dsi) { - struct innolux_panel *innolux; - int err; - - dsi->lanes = 4; - dsi->format = MIPI_DSI_FMT_RGB888; - dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | - MIPI_DSI_MODE_LPM; - innolux = devm_kzalloc(&dsi->dev, sizeof(*innolux), GFP_KERNEL); - if (!innolux) - return -ENOMEM; + const struct panel_desc_dsi *dsi_desc; + const struct of_device_id *id; + int err; - mipi_dsi_set_drvdata(dsi, innolux); + id = of_match_node(innolux_of_match, dsi->dev.of_node); + if (!id) + return -ENODEV; - innolux->link = dsi; + dsi_desc = id->data; + dsi->mode_flags = dsi_desc->flags; + dsi->format = dsi_desc->format; + dsi->lanes = dsi_desc->lanes; - err = innolux_panel_add(innolux); + err = innolux_panel_add(dsi, dsi_desc); if (err < 0) return err; - err = mipi_dsi_attach(dsi); - return err; + return mipi_dsi_attach(dsi); } static int innolux_panel_remove(struct mipi_dsi_device *dsi) @@ -326,7 +419,7 @@ static void innolux_panel_shutdown(struct mipi_dsi_device *dsi) static struct mipi_dsi_driver innolux_panel_driver = { .driver = { - .name = "panel-innolux-p079zca", + .name = "panel-innolux-dsi", .of_match_table = innolux_of_match, }, .probe = innolux_panel_probe, @@ -336,5 +429,6 @@ static struct mipi_dsi_driver innolux_panel_driver = { module_mipi_dsi_driver(innolux_panel_driver); MODULE_AUTHOR("Chris Zhong <zyw(a)rock-chips.com>"); +MODULE_AUTHOR("Lin Huang <hl(a)rock-chips.com>"); MODULE_DESCRIPTION("Innolux P079ZCA panel driver"); MODULE_LICENSE("GPL v2"); -- 2.7.4

4 4

[PATCH] drm/msm: Memory leak bug fix
by Sharat Masetty 04 Dec '17

04 Dec '17

This patch fixes a possible memory leak in get_pages() Prakash Kamliya (1): drm/msm: fix leak in failed get_pages drivers/gpu/drm/msm/msm_gem.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) -- 1.9.1

1 1

[PATCH 1/2] drm/ttm: swap consecutive allocated cached pages v2
by Christian König 04 Dec '17

04 Dec '17

When we detect consecutive allocation of pages swap them to avoid accidentally freeing them as huge page. v2: use swap Signed-off-by: Christian König <christian.koenig(a)amd.com> --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c index c82d94cbbabc..b6c5148607e9 100644 --- a/drivers/gpu/drm/ttm/ttm_page_alloc.c +++ b/drivers/gpu/drm/ttm/ttm_page_alloc.c @@ -921,6 +921,10 @@ static int ttm_get_pages(struct page **pages, unsigned npages, int flags, return -ENOMEM; } + /* Swap the pages if we detect consecutive order */ + if (i && pages[i - 1] == p - 1) + swap(p, pages[i - 1]); + pages[i++] = p; --npages; } -- 2.11.0

2 2

[PATCH 1/2] drm/ttm: swap consecutive allocated cached pages
by Christian König 04 Dec '17

04 Dec '17

When we detect consecutive allocation of pages swap them to avoid accidentally freeing them as huge page. Signed-off-by: Christian König <christian.koenig(a)amd.com> --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c index c82d94cbbabc..60401350a01a 100644 --- a/drivers/gpu/drm/ttm/ttm_page_alloc.c +++ b/drivers/gpu/drm/ttm/ttm_page_alloc.c @@ -921,6 +921,14 @@ static int ttm_get_pages(struct page **pages, unsigned npages, int flags, return -ENOMEM; } + /* Swap the pages if we detect consecutive order */ + if (i && pages[i - 1] == p - 1) { + struct page *tmp = p; + + p = pages[i - 1]; + pages[i - 1] = tmp; + } + pages[i++] = p; --npages; } -- 2.11.0

2 3

Re: d17a1d97dc ("x86/mm/kasan: don't use vmemmap_populate() to initialize shadow"): BUG: KASAN: use-after-scope in __drm_mm_interval_first
by Dmitry Vyukov 04 Dec '17

04 Dec '17

On Wed, Nov 29, 2017 at 6:21 AM, Fengguang Wu <fengguang.wu(a)intel.com> wrote: > Greetings, > > 0day kernel testing robot got the below dmesg and the first bad commit is > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > > commit d17a1d97dc208d664c91cc387ffb752c7f85dc61 > Author: Andrey Ryabinin <aryabinin(a)virtuozzo.com> > AuthorDate: Wed Nov 15 17:36:35 2017 -0800 > Commit: Linus Torvalds <torvalds(a)linux-foundation.org> > CommitDate: Wed Nov 15 18:21:05 2017 -0800 > > x86/mm/kasan: don't use vmemmap_populate() to initialize shadow > > The kasan shadow is currently mapped using vmemmap_populate() since that > provides a semi-convenient way to map pages into init_top_pgt. However, > since that no longer zeroes the mapped pages, it is not suitable for > kasan, which requires zeroed shadow memory. > > Add kasan_populate_shadow() interface and use it instead of > vmemmap_populate(). Besides, this allows us to take advantage of > gigantic pages and use them to populate the shadow, which should save us > some memory wasted on page tables and reduce TLB pressure. > > Link: http://lkml.kernel.org/r/20171103185147.2688-2-pasha.tatashin@oracle.com > Signed-off-by: Andrey Ryabinin <aryabinin(a)virtuozzo.com> > Signed-off-by: Pavel Tatashin <pasha.tatashin(a)oracle.com> > Cc: Steven Sistare <steven.sistare(a)oracle.com> > Cc: Daniel Jordan <daniel.m.jordan(a)oracle.com> > Cc: Bob Picco <bob.picco(a)oracle.com> > Cc: Michal Hocko <mhocko(a)suse.com> > Cc: Alexander Potapenko <glider(a)google.com> > Cc: Ard Biesheuvel <ard.biesheuvel(a)linaro.org> > Cc: Catalin Marinas <catalin.marinas(a)arm.com> > Cc: Christian Borntraeger <borntraeger(a)de.ibm.com> > Cc: David S. Miller <davem(a)davemloft.net> > Cc: Dmitry Vyukov <dvyukov(a)google.com> > Cc: Heiko Carstens <heiko.carstens(a)de.ibm.com> > Cc: "H. Peter Anvin" <hpa(a)zytor.com> > Cc: Ingo Molnar <mingo(a)redhat.com> > Cc: Mark Rutland <mark.rutland(a)arm.com> > Cc: Matthew Wilcox <willy(a)infradead.org> > Cc: Mel Gorman <mgorman(a)techsingularity.net> > Cc: Michal Hocko <mhocko(a)kernel.org> > Cc: Sam Ravnborg <sam(a)ravnborg.org> > Cc: Thomas Gleixner <tglx(a)linutronix.de> > Cc: Will Deacon <will.deacon(a)arm.com> > Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> > Signed-off-by: Linus Torvalds <torvalds(a)linux-foundation.org> > > a4a3ede213 mm: zero reserved and unavailable struct pages > d17a1d97dc x86/mm/kasan: don't use vmemmap_populate() to initialize shadow > 43570f0383 Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6 > 5bef2980ad Add linux-next specific files for 20171128 > +-------------------------------------------------------+------------+------------+------------+---------------+ > | | a4a3ede213 | d17a1d97dc | 43570f0383 | next-20171128 | > +-------------------------------------------------------+------------+------------+------------+---------------+ > | boot_successes | 30 | 0 | 0 | 0 | > | boot_failures | 8 | 15 | 19 | 2 | > | WARNING:at_drivers/pci/pci-sysfs.c:#pci_mmap_resource | 8 | | | | > | RIP:pci_mmap_resource | 8 | | | | > | BUG:KASAN:use-after-scope_in__drm_mm_interval_first | 0 | 15 | 19 | 2 | > +-------------------------------------------------------+------------+------------+------------+---------------+ > > [ 27.628251] AMD IOMMUv2 functionality not available on this system > [ 27.631925] drm_mm: Testing DRM range manger (struct drm_mm), with random_seed=0x248e657d max_iterations=8192 max_prime=128 > [ 27.633191] drm_mm: igt_sanitycheck - ok! > [ 79.880445] Writes: Total: 2 Max/Min: 0/0 Fail: 0 > [ 103.749567] ================================================================== > [ 103.750064] BUG: KASAN: use-after-scope in __drm_mm_interval_first+0xbb/0x1bf > [ 103.750064] Read of size 8 at addr ffff880016577c08 by task swapper/0/1 > [ 103.750064] > [ 103.750064] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.14.0-04319-gd17a1d9 #1 > [ 103.750064] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1 04/01/2014 > [ 103.750064] Call Trace: > [ 103.750064] ? dump_stack+0xd1/0x16c > [ 103.750064] ? _atomic_dec_and_lock+0x10f/0x10f > [ 103.750064] ? print_address_description+0x93/0x22e > [ 103.750064] ? __drm_mm_interval_first+0xbb/0x1bf > [ 103.750064] ? kasan_report+0x219/0x23f > [ 103.750064] ? __drm_mm_interval_first+0xbb/0x1bf > [ 103.750064] ? assert_continuous+0x13c/0x22f > [ 103.750064] ? drm_mm_replace_node+0x210/0x3ed > [ 103.750064] ? __igt_insert+0x5af/0xb3a > [ 103.750064] ? igt_bottomup+0x9e6/0x9e6 > [ 103.750064] ? kvm_clock_read+0x21/0x29 > [ 103.750064] ? kvm_sched_clock_read+0x5/0xd > [ 103.750064] ? sched_clock+0x5/0x8 > [ 103.750064] ? sched_clock_local+0x36/0xe8 > [ 103.750064] ? sched_clock_cpu+0x123/0x13f > [ 103.750064] ? rcu_irq_enter_disabled+0x8/0x8 > [ 103.750064] ? next_prime_number+0x33f/0x368 > [ 103.750064] ? rcu_note_context_switch+0x267/0x267 > [ 103.750064] ? igt_replace+0x45/0xa9 > [ 103.750064] ? test_drm_mm_init+0x112/0x164 > [ 103.750064] ? drm_kms_helper_init+0x5/0x5 > [ 103.750064] ? do_one_initcall+0xe7/0x1ef > [ 103.750064] ? initcall_blacklisted+0x15d/0x15d > [ 103.750064] ? up_read+0x2c/0x2c > [ 103.750064] ? kasan_unpoison_shadow+0xf/0x2e > [ 103.750064] ? kernel_init_freeable+0x2a8/0x33b > [ 103.750064] ? rest_init+0x24f/0x24f > [ 103.750064] ? kernel_init+0x7/0xfe > [ 103.750064] ? rest_init+0x24f/0x24f > [ 103.750064] ? ret_from_fork+0x24/0x30 > [ 103.750064] > [ 103.750064] The buggy address belongs to the page: > [ 103.750064] page:ffff88001b1e3208 count:0 mapcount:0 mapping: (null) index:0x0 > [ 103.750064] flags: 0x401fff800000() > [ 103.750064] raw: 0000401fff800000 0000000000000000 0000000000000000 00000000ffffffff Hi, I hacked a quick prototype of improvemet for KASAN for printing frame info: --- a/mm/kasan/report.c +++ b/mm/kasan/report.c @@ -289,6 +289,7 @@ static void print_shadow_for_address(const void *addr) int i; const void *shadow = kasan_mem_to_shadow(addr); const void *shadow_row; + unsigned long *ptr; shadow_row = (void *)round_down((unsigned long)shadow, SHADOW_BYTES_PER_ROW) @@ -320,6 +321,18 @@ static void print_shadow_for_address(const void *addr) shadow_row += SHADOW_BYTES_PER_ROW; } + + + ptr = (unsigned long *)((unsigned long)addr & ~7); + for (i = 0; i < 1000; i++, ptr--) { + if (*ptr == 0x41b58ab3) { + pr_err("\n"); + pr_err("frame offset: %lu\n", (unsigned long)addr - (unsigned long)ptr); + pr_err("desc: '%s'\n", (const char*)*(ptr+1)); + pr_err("func: %pS\n", (void*)*(ptr+2)); + break; + } + } } And this gave me: [ 26.763495] ================================================================== [ 26.764454] BUG: KASAN: use-after-scope in __drm_mm_interval_first+0xc0/0x1e2 [ 26.765297] Read of size 8 at addr ffff88006cb3fbe0 by task swapper/0/1 [ 26.766081] [ 26.766278] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 4.14.0-04319-gd17a1d97dc20-dirty #12 [ 26.767760] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 [ 26.769419] Call Trace: [ 26.769895] dump_stack+0xdb/0x17a [ 26.770152] ? _atomic_dec_and_lock+0x12f/0x12f [ 26.770152] ? show_regs_print_info+0x5b/0x5b [ 26.770152] ? kasan_report+0x4d/0x247 [ 26.770152] ? __drm_mm_interval_first+0xc0/0x1e2 [ 26.770152] print_address_description+0x9a/0x232 [ 26.770152] ? __drm_mm_interval_first+0xc0/0x1e2 [ 26.770152] kasan_report+0x21e/0x247 [ 26.770152] __asan_report_load8_noabort+0x14/0x16 [ 26.770152] __drm_mm_interval_first+0xc0/0x1e2 [ 26.770152] assert_continuous+0x13e/0x22f [ 26.770152] __igt_insert+0x665/0xc87 [ 26.770152] ? igt_bottomup+0xaa0/0xaa0 [ 26.770152] ? sched_clock_local+0x3c/0xfb [ 26.770152] ? find_held_lock+0x33/0x103 [ 26.770152] ? next_prime_number+0x318/0x362 [ 26.770152] ? rcu_irq_enter_disabled+0xd/0xd [ 26.770152] ? next_prime_number+0x337/0x362 [ 26.770152] igt_replace+0x4b/0xb3 [ 26.770152] test_drm_mm_init+0x118/0x172 [ 26.770152] ? drm_kms_helper_init+0xb/0xb [ 26.770152] do_one_initcall+0x10f/0x21f [ 26.770152] ? initcall_blacklisted+0x185/0x185 [ 26.770152] ? down_write_nested+0xa1/0x164 [ 26.770152] ? kasan_poison_shadow+0x2f/0x31 [ 26.770152] ? kasan_unpoison_shadow+0x14/0x35 [ 26.770152] kernel_init_freeable+0x2ae/0x339 [ 26.770152] ? rest_init+0x250/0x250 [ 26.770152] kernel_init+0xc/0x105 [ 26.770152] ? rest_init+0x250/0x250 [ 26.770152] ret_from_fork+0x24/0x30 [ 26.770152] [ 26.770152] The buggy address belongs to the page: [ 26.770152] page:ffff88007f39c5c8 count:0 mapcount:0 mapping: (null) index:0x0 [ 26.770152] flags: 0x1a01fff800000() [ 26.770152] raw: 0001a01fff800000 0000000000000000 0000000000000000 00000000ffffffff [ 26.770152] raw: ffff88007f39c5e8 ffff88007f39c5e8 0000000000000000 [ 26.770152] page dumped because: kasan: bad access detected [ 26.790299] [ 26.790299] Memory state around the buggy address: [ 26.790299] ffff88006cb3fa80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 f1 [ 26.790299] ffff88006cb3fb00: f1 f1 f1 00 f2 f2 f2 f2 f2 f2 f2 00 00 f2 f2 f2 [ 26.790299] >ffff88006cb3fb80: f2 f2 f2 f8 f8 f2 f2 f2 f2 f2 f2 f8 f8 f8 f8 f8 [ 26.790299] ^ [ 26.790299] ffff88006cb3fc00: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f2 [ 26.790299] ffff88006cb3fc80: f2 f2 f2 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 26.790299] [ 26.790299] frame offset: 232 [ 26.790299] desc: '5 32 8 3 __u 96 16 4 prng 160 16 7 state__ 224 160 3 tmp 416 224 2 mm ' [ 26.790299] func: __igt_insert+0x0/0xc87 [ 26.790299] ================================================================== That desc string is: number of local objects, then for each object: offset, size, name length, name. So that's variable tmp in __igt_insert. Looks very much like a real use-after-scope.

2 1

[PATCH 0/4] Backported amdgpu ttm deadlock fixes for 4.14
by Lyude Paul 04 Dec '17

04 Dec '17

I haven't gone to see where it started, but as of late a good number of pretty nasty deadlock issues have appeared with the kernel. Easy reproduction recipe on a laptop with i915/amdgpu prime with lockdep enabled: DRI_PRIME=1 glxinfo Additionally, some more race conditions exist that I've managed to trigger with piglit and lockdep enabled after applying these patches: ============================= WARNING: suspicious RCU usage 4.14.3Lyude-Test+ #2 Not tainted ----------------------------- ./include/linux/reservation.h:216 suspicious rcu_dereference_protected() usage! other info that might help us debug this: rcu_scheduler_active = 2, debug_locks = 1 1 lock held by ext_image_dma_b/27451: #0: (reservation_ww_class_mutex){+.+.}, at: [<ffffffffa034f2ff>] ttm_bo_unref+0x9f/0x3c0 [ttm] stack backtrace: CPU: 0 PID: 27451 Comm: ext_image_dma_b Not tainted 4.14.3Lyude-Test+ #2 Hardware name: HP HP ZBook 15 G4/8275, BIOS P70 Ver. 01.02 06/09/2017 Call Trace: dump_stack+0x8e/0xce lockdep_rcu_suspicious+0xc5/0x100 reservation_object_copy_fences+0x292/0x2b0 ? ttm_bo_unref+0x9f/0x3c0 [ttm] ttm_bo_unref+0xbd/0x3c0 [ttm] amdgpu_bo_unref+0x2a/0x50 [amdgpu] amdgpu_gem_object_free+0x4b/0x50 [amdgpu] drm_gem_object_free+0x1f/0x40 [drm] drm_gem_object_put_unlocked+0x40/0xb0 [drm] drm_gem_object_handle_put_unlocked+0x6c/0xb0 [drm] drm_gem_object_release_handle+0x51/0x90 [drm] drm_gem_handle_delete+0x5e/0x90 [drm] ? drm_gem_handle_create+0x40/0x40 [drm] drm_gem_close_ioctl+0x20/0x30 [drm] drm_ioctl_kernel+0x5d/0xb0 [drm] drm_ioctl+0x2f7/0x3b0 [drm] ? drm_gem_handle_create+0x40/0x40 [drm] ? trace_hardirqs_on_caller+0xf4/0x190 ? trace_hardirqs_on+0xd/0x10 amdgpu_drm_ioctl+0x4f/0x90 [amdgpu] do_vfs_ioctl+0x93/0x670 ? __fget+0x108/0x1f0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x23/0xc2 I've also added the relevant fixes for the issue mentioned above. Christian König (3): drm/ttm: fix ttm_bo_cleanup_refs_or_queue once more dma-buf: make reservation_object_copy_fences rcu save drm/amdgpu: reserve root PD while releasing it Michel Dänzer (1): drm/ttm: Always and only destroy bo->ttm_resv in ttm_bo_release_list drivers/dma-buf/reservation.c | 56 +++++++++++++++++++++++++--------- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 13 ++++++-- drivers/gpu/drm/ttm/ttm_bo.c | 43 +++++++++++++------------- 3 files changed, 74 insertions(+), 38 deletions(-) -- 2.14.3

3 6

[Bug 103962] (DC 4.15-rc1) [drm:gfx_v8_0_hw_fini [amdgpu]] *ERROR* KCQ disabled failed (scratch(0xC040)=0xCAFEDEAD)
by bugzilla-daemon＠freedesktop.org 04 Dec '17

04 Dec '17

https://bugs.freedesktop.org/show_bug.cgi?id=103962 Bug ID: 103962 Summary: (DC 4.15-rc1) [drm:gfx_v8_0_hw_fini [amdgpu]] *ERROR* KCQ disabled failed (scratch(0xC040)=0xCAFEDEAD) Product: DRI Version: DRI git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: taijian(a)posteo.de Created attachment 135785 --> https://bugs.freedesktop.org/attachment.cgi?id=135785&action=edit relevant dmesg output I am testing the new DC code with 4.15-rc1 on my Alienware 15R3 with an RX470 dGPU. This machine has forever had the problem that pm will not turn the dGPU off properly when it is not in use, thus causing heat and battery life issues. I had hoped that maybe the DC code would help here, but it seems to just have switched the kinds of error messages I get around. Here are the new ones, I keep getting a bunch of: [ 2.727021] [drm:dm_logger_write [amdgpu]] *ERROR* hwss_edp_wait_for_hpd_ready: wait timed out! [ 20.520195] [drm:dm_logger_write [amdgpu]] *ERROR* hwss_edp_wait_for_hpd_ready: wait timed out! and [ 36.938909] [drm:dm_logger_write [amdgpu]] *ERROR* hwss_edp_wait_for_hpd_ready: wait timed out! [ 37.087971] [drm:gfx_v8_0_ring_test_ring [amdgpu]] *ERROR* amdgpu: ring 0 test failed (scratch(0xC040)=0xCAFEDEAD) [ 37.087981] [drm:amdgpu_resume_phase2 [amdgpu]] *ERROR* resume of IP block <gfx_v8_0> failed -22 [ 37.087990] [drm:amdgpu_device_resume [amdgpu]] *ERROR* amdgpu_resume failed (-22). [ 37.087993] snd_hda_intel 0000:01:00.1: Start delayed initialization [ 37.091937] input: HDA ATI HDMI HDMI/DP,pcm=3 as /devices/pci0000:00/0000:00:01.0/0000:01:00.1/sound/card1/input21 [ 37.091967] input: HDA ATI HDMI HDMI/DP,pcm=7 as /devices/pci0000:00/0000:00:01.0/0000:01:00.1/sound/card1/input22 [ 37.092023] [drm:amdgpu_fill_buffer [amdgpu]] *ERROR* Trying to clear memory with ring turned off. [ 37.103951] [drm:amdgpu_fill_buffer [amdgpu]] *ERROR* Trying to clear memory with ring turned off. [ 37.103974] [drm:amdgpu_fill_buffer [amdgpu]] *ERROR* Trying to clear memory with ring turned off. [ 37.104058] [drm:amdgpu_fill_buffer [amdgpu]] *ERROR* Trying to clear memory with ring turned off. [ 37.125739] [drm:amdgpu_fill_buffer [amdgpu]] *ERROR* Trying to clear memory with ring turned off. [ 37.248924] [drm:amdgpu_fill_buffer [amdgpu]] *ERROR* Trying to clear memory with ring turned off. [ 37.248946] [drm:amdgpu_fill_buffer [amdgpu]] *ERROR* Trying to clear memory with ring turned off. [ 37.249070] [drm:amdgpu_fill_buffer [amdgpu]] *ERROR* Trying to clear memory with ring turned off. [ 42.269448] snd_hda_intel 0000:01:00.1: Disabling via vga_switcheroo [ 42.269517] snd_hda_intel 0000:01:00.1: Cannot lock devices! [ 42.447377] [drm:gfx_v8_0_hw_fini [amdgpu]] *ERROR* KCQ disabled failed (scratch(0xC040)=0xCAFEDEAD) [ 42.599606] [drm:gfx_v8_0_hw_fini [amdgpu]] *ERROR* KCQ disabled failed (scratch(0xC040)=0xCAFEDEAD) [ 42.749231] [drm:gfx_v8_0_hw_fini [amdgpu]] *ERROR* KCQ disabled failed (scratch(0xC040)=0xCAFEDEAD) [ 42.899207] [drm:gfx_v8_0_hw_fini [amdgpu]] *ERROR* KCQ disabled failed (scratch(0xC040)=0xCAFEDEAD) [ 43.047953] [drm:gfx_v8_0_hw_fini [amdgpu]] *ERROR* KCQ disabled failed (scratch(0xC040)=0xCAFEDEAD) [ 43.197043] [drm:gfx_v8_0_hw_fini [amdgpu]] *ERROR* KCQ disabled failed (scratch(0xC040)=0xCAFEDEAD) [ 43.344313] [drm:gfx_v8_0_hw_fini [amdgpu]] *ERROR* KCQ disabled failed (scratch(0xC040)=0xCAFEDEAD) [ 43.491648] [drm:gfx_v8_0_hw_fini [amdgpu]] *ERROR* KCQ disabled failed (scratch(0xC040)=0xCAFEDEAD) [ 43.491814] WARNING: CPU: 7 PID: 512 at drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:600 dm_suspend+0x4e/0x60 [amdgpu] [ 43.491815] Modules linked in: rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver nfs lockd grace sunrpc fscache rfcomm ccm acpi_call(O) cmac bnep arc4 ip6t_REJECT nf_reject_ipv6 xt_hl ip6t_rt joydev mousedev snd_hda_codec_hdmi nf_conntrack_ipv6 nf_defrag_ipv6 ipt_REJECT nf_reject_ipv4 xt_multiport ath10k_pci rmi_smbus ath10k_core uvcvideo rmi_core videobuf2_vmalloc videobuf2_memops videobuf2_v4l2 videobuf2_core xt_limit ath videodev xt_tcpudp snd_hda_codec_realtek btusb dell_wmi iTCO_wdt media btrtl xt_addrtype fuse snd_hda_codec_generic iTCO_vendor_support mac80211 dell_smbios wmi_bmof dell_wmi_descriptor intel_rapl nf_conntrack_ipv4 x86_pkg_temp_thermal intel_powerclamp kvm_intel nf_defrag_ipv4 snd_hda_intel xt_conntrack kvm snd_hda_codec snd_hda_core mei_me snd_hwdep nls_iso8859_1 nls_cp437 snd_pcm [ 43.491833] input_leds irqbypass vfat snd_timer intel_cstate fat snd processor_thermal_device cfg80211 psmouse led_class pcspkr i2c_i801 intel_rapl_perf mei soundcore intel_pch_thermal hci_uart intel_soc_dts_iosf wmi btbcm btqca btintel int3403_thermal bluetooth int340x_thermal_zone battery pinctrl_sunrisepoint pinctrl_intel ac ip6table_filter ecdh_generic tpm_crb acpi_als tpm_tis ip6_tables intel_lpss_acpi dell_rbtn kfifo_buf i2c_hid intel_lpss tpm_tis_core rfkill industrialio tpm intel_hid nf_conntrack_netbios_ns shpchp nf_conntrack_broadcast evdev int3400_thermal sparse_keymap acpi_pad acpi_thermal_rel mac_hid nf_nat_ftp nf_nat nf_conntrack_ftp nf_conntrack libcrc32c crc32c_generic iptable_filter sch_fq_codel coretemp msr crypto_user ip_tables x_tables ext4 crc16 mbcache jbd2 fscrypto algif_skcipher af_alg hid_generic usbhid hid dm_crypt dm_mod dax sd_mod crct10dif_pclmul crc32_pclmul crc32c_intel ghash_clmulni_intel pcbc serio_raw atkbd libps2 ahci xhci_pci aesni_intel libahci xhci_hcd libata aes_x86_64 crypto_simd usbcore glue_helper cryptd scsi_mod usb_common i8042 serio nvme nvme_core i915 amdgpu video button chash intel_gtt i2c_algo_bit drm_kms_helper syscopyarea sysfillrect sysimgblt ttm fb_sys_fops drm agpgart [ 43.491865] CPU: 7 PID: 512 Comm: kworker/7:2 Tainted: G W O 4.15.0-rc1-mainline #1 [ 43.491866] Hardware name: Alienware Alienware 15 R3/Alienware 15 R3, BIOS 1.2.0 09/14/2017 [ 43.491869] Workqueue: pm pm_runtime_work [ 43.491869] task: ffff96ecb5256ac0 task.stack: ffffa6b2c1e78000 [ 43.491884] RIP: 0010:dm_suspend+0x4e/0x60 [amdgpu] [ 43.491884] RSP: 0018:ffffa6b2c1e7bcc0 EFLAGS: 00010286 [ 43.491885] RAX: 0000000000000000 RBX: ffff96ecb5710000 RCX: 0000000000000000 [ 43.491885] RDX: 0000000000000001 RSI: 0000000000000286 RDI: 0000000000000286 [ 43.491886] RBP: 0000000000000003 R08: 0000000000000000 R09: 0000000000000495 [ 43.491886] R10: 0000000000000002 R11: ffffffff8b14836d R12: ffff96ecb5710000 [ 43.491887] R13: ffffffffc03f3840 R14: 0000000000000000 R15: ffff96ecb5485b30 [ 43.491887] FS: 0000000000000000(0000) GS:ffff96eccedc0000(0000) knlGS:0000000000000000 [ 43.491888] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 43.491888] CR2: 00007f978312d000 CR3: 000000018cc09005 CR4: 00000000003606e0 [ 43.491889] Call Trace: [ 43.491898] amdgpu_suspend+0x5f/0x150 [amdgpu] [ 43.491906] amdgpu_device_suspend+0x1f0/0x3b0 [amdgpu] [ 43.491908] ? vga_switcheroo_runtime_resume+0x50/0x50 [ 43.491915] amdgpu_pmops_runtime_suspend+0x52/0xc0 [amdgpu] [ 43.491916] pci_pm_runtime_suspend+0x5c/0x160 [ 43.491918] vga_switcheroo_runtime_suspend+0x1e/0x90 [ 43.491919] __rpm_callback+0xb6/0x1e0 [ 43.491920] ? vga_switcheroo_runtime_resume+0x50/0x50 [ 43.491921] rpm_callback+0x1f/0x70 [ 43.491922] ? vga_switcheroo_runtime_resume+0x50/0x50 [ 43.491923] rpm_suspend+0x12d/0x670 [ 43.491924] ? __update_idle_core+0x20/0xb0 [ 43.491925] ? finish_task_switch+0x75/0x200 [ 43.491926] pm_runtime_work+0x64/0xa0 [ 43.491928] process_one_work+0x1de/0x410 [ 43.491930] worker_thread+0x2b/0x3d0 [ 43.491931] ? process_one_work+0x410/0x410 [ 43.491931] kthread+0x111/0x130 [ 43.491932] ? kthread_create_worker_on_cpu+0x70/0x70 [ 43.491934] ret_from_fork+0x1f/0x30 [ 43.491935] Code: 9d 00 00 00 75 25 48 8b 7b 08 e8 0e dc e1 ff 48 8b bb a8 85 00 00 48 89 83 10 9d 00 00 be 08 00 00 00 e8 66 52 04 00 31 c0 5b c3 <0f> ff eb d7 0f 1f 40 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 [ 43.491950] ---[ end trace 8dd55f26ae92c339 ]--- [ 43.520969] amdgpu 0000:01:00.0: GPU pci config reset -- You are receiving this mail because: You are the assignee for the bug.

1 3

[Bug 103829] [CI] igt@gem_busy@close-race - fail - Failed assertion: gem_bo_busy(fd, object[0].handle)
by bugzilla-daemon＠freedesktop.org 04 Dec '17

04 Dec '17

https://bugs.freedesktop.org/show_bug.cgi?id=103829 --- Comment #2 from Jani Saarinen <jani.saarinen(a)intel.com> --- Reference: https://patchwork.freedesktop.org/series/34818/ -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH 1/2] drm/edid: quirk Oculus Rift headsets as non-desktop
by Philipp Zabel 04 Dec '17

04 Dec '17

This uses the EDID info from Oculus Rift DK1, DK2, and CV1 to mark them as non-desktop. Signed-off-by: Philipp Zabel <philipp.zabel(a)gmail.com> --- drivers/gpu/drm/drm_edid.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 5dfe14763871..80f414ff60e4 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -162,6 +162,11 @@ static const struct edid_quirk { /* HTC Vive VR Headset */ { "HVR", 0xaa01, EDID_QUIRK_NON_DESKTOP }, + + /* Oculus Rift DK1, DK2, and CV1 VR Headsets */ + { "OVR", 0x0001, EDID_QUIRK_NON_DESKTOP }, + { "OVR", 0x0003, EDID_QUIRK_NON_DESKTOP }, + { "OVR", 0x0004, EDID_QUIRK_NON_DESKTOP }, }; /* -- 2.15.1

1 1

[PATCH] drm/tilcdc: make tilcdc_mode_hvtotal() static
by Xiongwei Song 04 Dec '17

04 Dec '17

The function tilcdc_mode_hvtotal is local to the source and does not need to be in global scope, so make it static. drivers/gpu/drm/tilcdc/tilcdc_crtc.c:297:6: warning: no previous prototype for 'tilcdc_mode_hvtotal' [-Wmissing-prototypes] uint tilcdc_mode_hvtotal(const struct drm_display_mode *mode) Signed-off-by: Xiongwei Song <sxwjean(a)gmail.com> --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c index 6ef4d1a..c4804d9 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c @@ -294,7 +294,7 @@ static void tilcdc_crtc_set_clk(struct drm_crtc *crtc) LCDC_V2_CORE_CLK_EN); } -uint tilcdc_mode_hvtotal(const struct drm_display_mode *mode) +static uint tilcdc_mode_hvtotal(const struct drm_display_mode *mode) { return (uint) div_u64(1000llu * mode->htotal * mode->vtotal, mode->clock); -- 2.9.5

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel December 2017