dri-devel April 2017

dri-devel@lists.freedesktop.org

208 participants
1518 discussions

[PATCH] MAINTAINERS: meson-drm: remove useless git repository
by Neil Armstrong 04 Apr '17

04 Apr '17

Meson DRM is switching to drm-misc, so remove the freedesktop drm/meson-drm git repository from MAINTAINERS entry. Acked-by: Daniel Vetter <daniel.vetter(a)ffwll.ch> Signed-off-by: Neil Armstrong <narmstrong(a)baylibre.com> --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index d0d9ed8..8d3eb6e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4258,7 +4258,6 @@ W: http://linux-meson.com/ S: Supported F: drivers/gpu/drm/meson/ F: Documentation/devicetree/bindings/display/amlogic,meson-vpu.txt -T: git git://anongit.freedesktop.org/drm/drm-meson T: git git://anongit.freedesktop.org/drm/drm-misc DRM DRIVERS FOR EXYNOS -- 1.9.1

1 1

GSOC(Xorg)
by Christian Lockley 04 Apr '17

04 Apr '17

Hi all, I'm Christian Lockley I'm wondering if it's too late to apply for GSOC if so I understand and will apply next year. It not, is the DRM kernel janitor position still open? While I don't have kernel or graphics experience I do know C and Java. If this position is available I'd like to work on the De-midlayer drivers and/or Switch from reference/unreference to get/put projects. Linked below is a git repo of a personal project: https://github.com/clockley/watchdogd/

2 1

[drm:drm-syncobj 2/8] htmldocs: drivers/dma-buf/sync_file.c:139: warning: No description found for parameter 'fd'
by kbuild test robot 04 Apr '17

04 Apr '17

tree: git://people.freedesktop.org/~airlied/linux.git drm-syncobj head: a76c865346ca89a2c7df98f8865fbffdf2094c6f commit: 823279a8a43f87e9ba4f5c17f82b0308d9a4555e [2/8] sync_file: export some interfaces needed by drm sync objects. reproduce: make htmldocs All warnings (new ones prefixed by >>): include/linux/init.h:1: warning: no structured comments found kernel/sched/core.c:2085: warning: No description found for parameter 'rf' kernel/sched/core.c:2085: warning: Excess function parameter 'cookie' description in 'try_to_wake_up_local' include/linux/kthread.h:26: warning: Excess function parameter '...' description in 'kthread_create' kernel/sys.c:1: warning: no structured comments found include/linux/device.h:969: warning: No description found for parameter 'dma_ops' drivers/dma-buf/seqno-fence.c:1: warning: no structured comments found drivers/dma-buf/sync_file.c:114: warning: No description found for parameter 'type' drivers/dma-buf/sync_file.c:114: warning: No description found for parameter 'flags' >> drivers/dma-buf/sync_file.c:139: warning: No description found for parameter 'fd' include/linux/iio/iio.h:597: warning: No description found for parameter 'trig_readonly' include/linux/iio/trigger.h:151: warning: No description found for parameter 'indio_dev' include/linux/iio/trigger.h:151: warning: No description found for parameter 'trig' include/linux/device.h:970: warning: No description found for parameter 'dma_ops' drivers/regulator/core.c:1467: warning: Excess function parameter 'ret' description in 'regulator_dev_lookup' include/drm/drm_drv.h:438: warning: No description found for parameter 'open' include/drm/drm_drv.h:438: warning: No description found for parameter 'preclose' include/drm/drm_drv.h:438: warning: No description found for parameter 'postclose' include/drm/drm_drv.h:438: warning: No description found for parameter 'lastclose' include/drm/drm_drv.h:438: warning: No description found for parameter 'set_busid' include/drm/drm_drv.h:438: warning: No description found for parameter 'irq_handler' include/drm/drm_drv.h:438: warning: No description found for parameter 'irq_preinstall' include/drm/drm_drv.h:438: warning: No description found for parameter 'irq_postinstall' include/drm/drm_drv.h:438: warning: No description found for parameter 'irq_uninstall' include/drm/drm_drv.h:438: warning: No description found for parameter 'debugfs_init' include/drm/drm_drv.h:438: warning: No description found for parameter 'debugfs_cleanup' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_open_object' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_close_object' include/drm/drm_drv.h:438: warning: No description found for parameter 'prime_handle_to_fd' include/drm/drm_drv.h:438: warning: No description found for parameter 'prime_fd_to_handle' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_prime_export' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_prime_import' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_prime_pin' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_prime_unpin' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_prime_res_obj' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_prime_get_sg_table' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_prime_import_sg_table' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_prime_vmap' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_prime_vunmap' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_prime_mmap' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_vm_ops' include/drm/drm_drv.h:438: warning: No description found for parameter 'major' include/drm/drm_drv.h:438: warning: No description found for parameter 'minor' include/drm/drm_drv.h:438: warning: No description found for parameter 'patchlevel' include/drm/drm_drv.h:438: warning: No description found for parameter 'name' include/drm/drm_drv.h:438: warning: No description found for parameter 'desc' include/drm/drm_drv.h:438: warning: No description found for parameter 'date' include/drm/drm_drv.h:438: warning: No description found for parameter 'driver_features' include/drm/drm_drv.h:438: warning: No description found for parameter 'ioctls' include/drm/drm_drv.h:438: warning: No description found for parameter 'num_ioctls' include/drm/drm_drv.h:438: warning: No description found for parameter 'fops' include/drm/drm_color_mgmt.h:1: warning: no structured comments found drivers/gpu/drm/drm_fb_cma_helper.c:557: warning: Excess function parameter 'num_crtc' description in 'drm_fbdev_cma_init' drivers/gpu/drm/drm_fb_cma_helper.c:558: warning: Excess function parameter 'num_crtc' description in 'drm_fbdev_cma_init' drivers/gpu/drm/i915/intel_lpe_audio.c:342: warning: No description found for parameter 'pipe' drivers/gpu/drm/i915/intel_lpe_audio.c:342: warning: No description found for parameter 'dp_output' drivers/gpu/drm/i915/intel_lpe_audio.c:342: warning: No description found for parameter 'link_rate' drivers/gpu/drm/i915/intel_lpe_audio.c:343: warning: No description found for parameter 'pipe' drivers/gpu/drm/i915/intel_lpe_audio.c:343: warning: No description found for parameter 'dp_output' drivers/gpu/drm/i915/intel_lpe_audio.c:343: warning: No description found for parameter 'link_rate' drivers/media/dvb-core/dvb_frontend.h:677: warning: No description found for parameter 'refcount' Documentation/core-api/assoc_array.rst:13: WARNING: Enumerated list ends without a blank line; unexpected unindent. Documentation/doc-guide/sphinx.rst:110: ERROR: Unknown target name: "sphinx c domain". kernel/sched/fair.c:7616: WARNING: Inline emphasis start-string without end-string. kernel/time/timer.c:1200: ERROR: Unexpected indentation. kernel/time/timer.c:1202: ERROR: Unexpected indentation. kernel/time/timer.c:1203: WARNING: Block quote ends without a blank line; unexpected unindent. include/linux/wait.h:122: WARNING: Block quote ends without a blank line; unexpected unindent. include/linux/wait.h:125: ERROR: Unexpected indentation. include/linux/wait.h:127: WARNING: Block quote ends without a blank line; unexpected unindent. kernel/time/hrtimer.c:990: WARNING: Block quote ends without a blank line; unexpected unindent. kernel/signal.c:322: WARNING: Inline literal start-string without end-string. include/linux/iio/iio.h:219: ERROR: Unexpected indentation. include/linux/iio/iio.h:220: WARNING: Block quote ends without a blank line; unexpected unindent. include/linux/iio/iio.h:226: WARNING: Definition list ends without a blank line; unexpected unindent. drivers/iio/industrialio-core.c:639: ERROR: Unknown target name: "iio_val". drivers/iio/industrialio-core.c:646: ERROR: Unknown target name: "iio_val". drivers/message/fusion/mptbase.c:5051: WARNING: Definition list ends without a blank line; unexpected unindent. drivers/tty/serial/serial_core.c:1898: WARNING: Definition list ends without a blank line; unexpected unindent. include/linux/regulator/driver.h:271: ERROR: Unknown target name: "regulator_regmap_x_voltage". include/linux/spi/spi.h:369: ERROR: Unexpected indentation. drivers/usb/core/message.c:478: ERROR: Unexpected indentation. drivers/usb/core/message.c:479: WARNING: Block quote ends without a blank line; unexpected unindent. Documentation/driver-api/usb.rst:623: ERROR: Unknown target name: "usb_type". Documentation/driver-api/usb.rst:623: ERROR: Unknown target name: "usb_dir". Documentation/driver-api/usb.rst:623: ERROR: Unknown target name: "usb_recip". Documentation/driver-api/usb.rst:689: ERROR: Unknown target name: "usbdevfs_urb_type". sound/soc/soc-core.c:2670: ERROR: Unknown target name: "snd_soc_daifmt". sound/core/jack.c:312: ERROR: Unknown target name: "snd_jack_btn". WARNING: dvipng command 'dvipng' cannot be run (needed for math display), check the imgmath_dvipng setting vim +/fd +139 drivers/dma-buf/sync_file.c 24a367348 drivers/dma-buf/sync_file.c Daniel Vetter 2016-12-09 108 * sync_file or NULL in case of error. d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 109 */ 9860b6f0b drivers/dma-buf/sync_file.c Dave Airlie 2017-04-03 110 struct sync_file *sync_file_create(struct dma_fence *fence, 9860b6f0b drivers/dma-buf/sync_file.c Dave Airlie 2017-04-03 111 uint32_t type, 9860b6f0b drivers/dma-buf/sync_file.c Dave Airlie 2017-04-03 112 uint32_t flags) d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 113 { d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 @114 struct sync_file *sync_file; d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 115 9860b6f0b drivers/dma-buf/sync_file.c Dave Airlie 2017-04-03 116 sync_file = sync_file_alloc(type, flags); d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 117 if (!sync_file) d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 118 return NULL; d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 119 f54d18670 drivers/dma-buf/sync_file.c Chris Wilson 2016-10-25 120 sync_file->fence = dma_fence_get(fence); a02b9dc90 drivers/dma-buf/sync_file.c Gustavo Padovan 2016-08-05 121 041916a77 drivers/dma-buf/sync_file.c Gustavo Padovan 2016-06-03 122 snprintf(sync_file->name, sizeof(sync_file->name), "%s-%s%llu-%d", d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 123 fence->ops->get_driver_name(fence), d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 124 fence->ops->get_timeline_name(fence), fence->context, d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 125 fence->seqno); d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 126 d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 127 return sync_file; d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 128 } d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 129 EXPORT_SYMBOL(sync_file_create); d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 130 823279a8a drivers/dma-buf/sync_file.c Dave Airlie 2017-04-04 131 /** 823279a8a drivers/dma-buf/sync_file.c Dave Airlie 2017-04-04 132 * sync_file_fdget - get a reference to the file and return sync_file. 823279a8a drivers/dma-buf/sync_file.c Dave Airlie 2017-04-04 133 * @fd - file descriptor pointing at a sync_file. 823279a8a drivers/dma-buf/sync_file.c Dave Airlie 2017-04-04 134 * 823279a8a drivers/dma-buf/sync_file.c Dave Airlie 2017-04-04 135 * Returns the corresponding sync_file object. 823279a8a drivers/dma-buf/sync_file.c Dave Airlie 2017-04-04 136 */ 823279a8a drivers/dma-buf/sync_file.c Dave Airlie 2017-04-04 137 struct sync_file *sync_file_fdget(int fd) d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 138 { d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 @139 struct file *file = fget(fd); d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 140 d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 141 if (!file) d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 142 return NULL; :::::: The code at line 139 was first introduced by commit :::::: d4cab38e153d62ecd502645390c0289c1b8337df staging/android: prepare sync_file for de-staging :::::: TO: Gustavo Padovan <gustavo.padovan(a)collabora.co.uk> :::::: CC: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[PATCH] drm/amdgpu: Fix a NULL deref in amdgpu_vm_add_prt_cb()
by Dan Carpenter 04 Apr '17

04 Apr '17

We accidentally dereference "cb" if the kmalloc() fails. Fixes: 451bc8eb8fe6 ("drm/amdgpu: fix PRT teardown on VM fini v3") Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index 0235d7933efd..45a1bcfc41f7 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c @@ -1518,7 +1518,7 @@ static void amdgpu_vm_add_prt_cb(struct amdgpu_device *adev, if (fence) dma_fence_wait(fence, false); - amdgpu_vm_prt_put(cb->adev); + amdgpu_vm_prt_put(adev); } else { cb->adev = adev; if (!fence || dma_fence_add_callback(fence, &cb->cb,

4 3

[git pull] drm fixes for v4.11-rc6
by Dave Airlie 04 Apr '17

04 Apr '17

Hi Linus, I'm going to be away for the latter part of this week, and early next week, so I probably won't get to dequeue any more fixes before -rc6, if anyone has any urgent fixes they can get Daniel's help and maybe send them to you direct, I don't know of anything that is that urgent, hopefully I won't have a pile of stuff for rc7 and maintainers are a bit more weary of what they send me. This is just mostly stuff that missed rc5, from vmwgfx and msm drivers. Dave. The following changes since commit a71c9a1c779f2499fb2afc0553e543f18aff6edf: Linux 4.11-rc5 (2017-04-02 17:23:54 -0700) are available in the git repository at: git://people.freedesktop.org/~airlied/linux tags/drm-fixes-for-v4.11-rc6 for you to fetch changes up to 130e35e4bbceb2c04ff0ad9b1a0bcef7acc11498: Merge branch 'msm-fixes-4.11-rc6' of git://people.freedesktop.org/~robclark/linux into drm-fixes (2017-04-04 10:13:40 +1000) ---------------------------------------------------------------- vmwgfx and msm fixes ---------------------------------------------------------------- Archit Taneja (2): drm/msm/dsi: Fix bug in dsi_mgr_phy_enable drm/msm/mdp5: Update SSPP_MAX value Arnd Bergmann (1): drm/msm: adreno: fix build error without debugfs Dave Airlie (2): Merge branch 'vmwgfx-fixes-4.11' of git://people.freedesktop.org/~thomash/linux into drm-fixes Merge branch 'msm-fixes-4.11-rc6' of git://people.freedesktop.org/~robclark/linux into drm-fixes Jordan Crouse (3): drm/msm: Fix wrong pointer check in a5xx_destroy drm/msm: Don't allow zero sized buffer objects drm/msm: Make sure to detach the MMU during GPU cleanup Li Qiang (1): drm/vmwgfx: fix integer overflow in vmw_surface_define_ioctl() Murray McAllister (2): drm/vmwgfx: NULL pointer dereference in vmw_surface_define_ioctl() drm/vmwgfx: avoid calling vzalloc with a 0 size in vmw_get_cap_3d_ioctl() Thomas Hellstrom (4): drm/vmwgfx: Type-check lookups of fence objects drm/ttm, drm/vmwgfx: Relax permission checking when opening surfaces drm/ttm: Avoid calling drm_ht_remove from atomic context drm/vmwgfx: Remove getparam error message Vinay Simha BN (1): drm/msm/hdmi: redefinitions of macros not required drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 6 ++- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 29 ++++++++---- drivers/gpu/drm/msm/dsi/dsi_manager.c | 2 +- drivers/gpu/drm/msm/hdmi/hdmi_audio.c | 7 --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_pipe.h | 3 +- drivers/gpu/drm/msm/msm_gem.c | 6 +++ drivers/gpu/drm/msm/msm_gpu.c | 3 -- drivers/gpu/drm/ttm/ttm_object.c | 14 +++--- drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 79 ++++++++++++++++++++------------ drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 4 +- drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 4 +- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 31 ++++++------- include/drm/ttm/ttm_object.h | 5 +- 13 files changed, 112 insertions(+), 81 deletions(-)

1 0

[drm:drm-syncobj 2/8] drivers/dma-buf/sw_sync.c:318:37: sparse: not enough arguments for function sync_file_create
by kbuild test robot 04 Apr '17

04 Apr '17

tree: git://people.freedesktop.org/~airlied/linux.git drm-syncobj head: af9b558e5436d76fde927fd1f68cc35adec4d6ea commit: e9069d711a815ca17b9bf687b935ae8383b4565e [2/8] sync_file: add type/flags to sync file object creation. reproduce: # apt-get install sparse git checkout e9069d711a815ca17b9bf687b935ae8383b4565e make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) include/linux/compiler.h:264:8: sparse: attribute 'no_sanitize_address': unknown attribute >> drivers/dma-buf/sw_sync.c:318:37: sparse: not enough arguments for function sync_file_create drivers/dma-buf/sw_sync.c: In function 'sw_sync_ioctl_create_fence': drivers/dma-buf/sw_sync.c:318:14: error: too few arguments to function 'sync_file_create' sync_file = sync_file_create(&pt->base); ^~~~~~~~~~~~~~~~ In file included from drivers/dma-buf/sw_sync.c:21:0: include/linux/sync_file.h:56:19: note: declared here struct sync_file *sync_file_create(struct dma_fence *fence, uint32_t type, uint32_t flags); ^~~~~~~~~~~~~~~~ vim +318 drivers/dma-buf/sw_sync.c 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 302 struct sw_sync_create_fence_data data; 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 303 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 304 if (fd < 0) 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 305 return fd; 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 306 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 307 if (copy_from_user(&data, (void __user *)arg, sizeof(data))) { 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 308 err = -EFAULT; 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 309 goto err; 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 310 } 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 311 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 312 pt = sync_pt_create(obj, sizeof(*pt), data.value); 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 313 if (!pt) { 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 314 err = -ENOMEM; 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 315 goto err; 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 316 } 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 317 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 @318 sync_file = sync_file_create(&pt->base); f54d1867 drivers/dma-buf/sw_sync.c Chris Wilson 2016-10-25 319 dma_fence_put(&pt->base); 4592bfcd drivers/dma-buf/sw_sync.c Gustavo Padovan 2016-10-26 320 if (!sync_file) { 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 321 err = -ENOMEM; 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 322 goto err; 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 323 } 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 324 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 325 data.fence = fd; 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 326 if (copy_to_user((void __user *)arg, &data, sizeof(data))) { :::::: The code at line 318 was first introduced by commit :::::: 1867a23b13b25d0a228b0509ade20fb977dcb601 staging/android: move sw_sync related code to sw_sync.c :::::: TO: Gustavo Padovan <gustavo.padovan(a)collabora.co.uk> :::::: CC: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[drm:drm-syncobj 2/8] htmldocs: drivers/dma-buf/sync_file.c:81: warning: No description found for parameter 'type'
by kbuild test robot 04 Apr '17

04 Apr '17

tree: git://people.freedesktop.org/~airlied/linux.git drm-syncobj head: af9b558e5436d76fde927fd1f68cc35adec4d6ea commit: e9069d711a815ca17b9bf687b935ae8383b4565e [2/8] sync_file: add type/flags to sync file object creation. reproduce: make htmldocs All warnings (new ones prefixed by >>): include/linux/init.h:1: warning: no structured comments found kernel/sched/core.c:2085: warning: No description found for parameter 'rf' kernel/sched/core.c:2085: warning: Excess function parameter 'cookie' description in 'try_to_wake_up_local' include/linux/kthread.h:26: warning: Excess function parameter '...' description in 'kthread_create' kernel/sys.c:1: warning: no structured comments found include/linux/device.h:969: warning: No description found for parameter 'dma_ops' drivers/dma-buf/seqno-fence.c:1: warning: no structured comments found >> drivers/dma-buf/sync_file.c:81: warning: No description found for parameter 'type' >> drivers/dma-buf/sync_file.c:81: warning: No description found for parameter 'flags' include/linux/iio/iio.h:597: warning: No description found for parameter 'trig_readonly' include/linux/iio/trigger.h:151: warning: No description found for parameter 'indio_dev' include/linux/iio/trigger.h:151: warning: No description found for parameter 'trig' include/linux/device.h:970: warning: No description found for parameter 'dma_ops' drivers/regulator/core.c:1467: warning: Excess function parameter 'ret' description in 'regulator_dev_lookup' include/drm/drm_drv.h:438: warning: No description found for parameter 'open' include/drm/drm_drv.h:438: warning: No description found for parameter 'preclose' include/drm/drm_drv.h:438: warning: No description found for parameter 'postclose' include/drm/drm_drv.h:438: warning: No description found for parameter 'lastclose' include/drm/drm_drv.h:438: warning: No description found for parameter 'set_busid' include/drm/drm_drv.h:438: warning: No description found for parameter 'irq_handler' include/drm/drm_drv.h:438: warning: No description found for parameter 'irq_preinstall' include/drm/drm_drv.h:438: warning: No description found for parameter 'irq_postinstall' include/drm/drm_drv.h:438: warning: No description found for parameter 'irq_uninstall' include/drm/drm_drv.h:438: warning: No description found for parameter 'debugfs_init' include/drm/drm_drv.h:438: warning: No description found for parameter 'debugfs_cleanup' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_open_object' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_close_object' include/drm/drm_drv.h:438: warning: No description found for parameter 'prime_handle_to_fd' include/drm/drm_drv.h:438: warning: No description found for parameter 'prime_fd_to_handle' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_prime_export' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_prime_import' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_prime_pin' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_prime_unpin' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_prime_res_obj' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_prime_get_sg_table' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_prime_import_sg_table' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_prime_vmap' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_prime_vunmap' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_prime_mmap' include/drm/drm_drv.h:438: warning: No description found for parameter 'gem_vm_ops' include/drm/drm_drv.h:438: warning: No description found for parameter 'major' include/drm/drm_drv.h:438: warning: No description found for parameter 'minor' include/drm/drm_drv.h:438: warning: No description found for parameter 'patchlevel' include/drm/drm_drv.h:438: warning: No description found for parameter 'name' include/drm/drm_drv.h:438: warning: No description found for parameter 'desc' include/drm/drm_drv.h:438: warning: No description found for parameter 'date' include/drm/drm_drv.h:438: warning: No description found for parameter 'driver_features' include/drm/drm_drv.h:438: warning: No description found for parameter 'ioctls' include/drm/drm_drv.h:438: warning: No description found for parameter 'num_ioctls' include/drm/drm_drv.h:438: warning: No description found for parameter 'fops' include/drm/drm_color_mgmt.h:1: warning: no structured comments found drivers/gpu/drm/drm_fb_cma_helper.c:557: warning: Excess function parameter 'num_crtc' description in 'drm_fbdev_cma_init' drivers/gpu/drm/drm_fb_cma_helper.c:558: warning: Excess function parameter 'num_crtc' description in 'drm_fbdev_cma_init' drivers/gpu/drm/i915/intel_lpe_audio.c:342: warning: No description found for parameter 'pipe' drivers/gpu/drm/i915/intel_lpe_audio.c:342: warning: No description found for parameter 'dp_output' drivers/gpu/drm/i915/intel_lpe_audio.c:342: warning: No description found for parameter 'link_rate' drivers/gpu/drm/i915/intel_lpe_audio.c:343: warning: No description found for parameter 'pipe' drivers/gpu/drm/i915/intel_lpe_audio.c:343: warning: No description found for parameter 'dp_output' drivers/gpu/drm/i915/intel_lpe_audio.c:343: warning: No description found for parameter 'link_rate' drivers/media/dvb-core/dvb_frontend.h:677: warning: No description found for parameter 'refcount' Documentation/core-api/assoc_array.rst:13: WARNING: Enumerated list ends without a blank line; unexpected unindent. Documentation/doc-guide/sphinx.rst:110: ERROR: Unknown target name: "sphinx c domain". kernel/sched/fair.c:7616: WARNING: Inline emphasis start-string without end-string. kernel/time/timer.c:1200: ERROR: Unexpected indentation. kernel/time/timer.c:1202: ERROR: Unexpected indentation. kernel/time/timer.c:1203: WARNING: Block quote ends without a blank line; unexpected unindent. include/linux/wait.h:122: WARNING: Block quote ends without a blank line; unexpected unindent. include/linux/wait.h:125: ERROR: Unexpected indentation. include/linux/wait.h:127: WARNING: Block quote ends without a blank line; unexpected unindent. kernel/time/hrtimer.c:990: WARNING: Block quote ends without a blank line; unexpected unindent. kernel/signal.c:322: WARNING: Inline literal start-string without end-string. include/linux/iio/iio.h:219: ERROR: Unexpected indentation. include/linux/iio/iio.h:220: WARNING: Block quote ends without a blank line; unexpected unindent. include/linux/iio/iio.h:226: WARNING: Definition list ends without a blank line; unexpected unindent. drivers/iio/industrialio-core.c:639: ERROR: Unknown target name: "iio_val". drivers/iio/industrialio-core.c:646: ERROR: Unknown target name: "iio_val". drivers/message/fusion/mptbase.c:5051: WARNING: Definition list ends without a blank line; unexpected unindent. drivers/tty/serial/serial_core.c:1898: WARNING: Definition list ends without a blank line; unexpected unindent. include/linux/regulator/driver.h:271: ERROR: Unknown target name: "regulator_regmap_x_voltage". include/linux/spi/spi.h:369: ERROR: Unexpected indentation. drivers/usb/core/message.c:478: ERROR: Unexpected indentation. drivers/usb/core/message.c:479: WARNING: Block quote ends without a blank line; unexpected unindent. Documentation/driver-api/usb.rst:623: ERROR: Unknown target name: "usb_type". Documentation/driver-api/usb.rst:623: ERROR: Unknown target name: "usb_dir". Documentation/driver-api/usb.rst:623: ERROR: Unknown target name: "usb_recip". Documentation/driver-api/usb.rst:689: ERROR: Unknown target name: "usbdevfs_urb_type". sound/soc/soc-core.c:2670: ERROR: Unknown target name: "snd_soc_daifmt". sound/core/jack.c:312: ERROR: Unknown target name: "snd_jack_btn". WARNING: dvipng command 'dvipng' cannot be run (needed for math display), check the imgmath_dvipng setting vim +/type +81 drivers/dma-buf/sync_file.c d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 65 wake_up_all(&sync_file->wq); d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 66 } d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 67 d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 68 /** c240a714a drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 69 * sync_file_create() - creates a sync file d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 70 * @fence: fence to add to the sync_fence d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 71 * 24a367348 drivers/dma-buf/sync_file.c Daniel Vetter 2016-12-09 72 * Creates a sync_file containg @fence. This function acquires and additional 24a367348 drivers/dma-buf/sync_file.c Daniel Vetter 2016-12-09 73 * reference of @fence for the newly-created &sync_file, if it succeeds. The 24a367348 drivers/dma-buf/sync_file.c Daniel Vetter 2016-12-09 74 * sync_file can be released with fput(sync_file->file). Returns the 24a367348 drivers/dma-buf/sync_file.c Daniel Vetter 2016-12-09 75 * sync_file or NULL in case of error. d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 76 */ e9069d711 drivers/dma-buf/sync_file.c Dave Airlie 2017-04-03 77 struct sync_file *sync_file_create(struct dma_fence *fence, e9069d711 drivers/dma-buf/sync_file.c Dave Airlie 2017-04-03 78 uint32_t type, e9069d711 drivers/dma-buf/sync_file.c Dave Airlie 2017-04-03 79 uint32_t flags) d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 80 { d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 @81 struct sync_file *sync_file; d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 82 e9069d711 drivers/dma-buf/sync_file.c Dave Airlie 2017-04-03 83 sync_file = sync_file_alloc(type, flags); d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 84 if (!sync_file) d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 85 return NULL; d4cab38e1 drivers/staging/android/sync_file.c Gustavo Padovan 2016-04-28 86 f54d18670 drivers/dma-buf/sync_file.c Chris Wilson 2016-10-25 87 sync_file->fence = dma_fence_get(fence); a02b9dc90 drivers/dma-buf/sync_file.c Gustavo Padovan 2016-08-05 88 041916a77 drivers/dma-buf/sync_file.c Gustavo Padovan 2016-06-03 89 snprintf(sync_file->name, sizeof(sync_file->name), "%s-%s%llu-%d", :::::: The code at line 81 was first introduced by commit :::::: d4cab38e153d62ecd502645390c0289c1b8337df staging/android: prepare sync_file for de-staging :::::: TO: Gustavo Padovan <gustavo.padovan(a)collabora.co.uk> :::::: CC: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[PATCH 00/19] wire acquire ctx through legacy modeset paths
by Daniel Vetter 04 Apr '17

04 Apr '17

Hi all, This is something I kinda had on my todo list ever since atomic landed. The legacy_backoff() hack really doesn't work if you need to acquire additional locks, which does restrict drivers in how they handle and protect legacy paths, and kinda forces us to be overzealous with taking locks for legacy paths, just in case. This patch set here fixes this, with 2 huge exceptions: - get/set_property calls aren't fixed. The locking in there is a mess and needs some serious attention. My goal would be that for atomic we take no lock at all, and entirely rely upon the magic of drm_modeset_lock and atomic to just grab the minimal set required to update a property. - fbdev emulation helpers. It abused the modeset_lock_all bkl as its own lock, which prevents us from pushing it down just around the (atomic) modeset calls, and hence from switching over to handling the acquire context in an explicit fashion. Thierry started to fix this with the addition of proper locking for fbdev emulation, but it needs a pile more work. Survived light testing with full ww mutex debugging, I'll rely on CI to catch the remaining mixups :-) Cheers, Daniel Daniel Vetter (19): drm: Wire up proper acquire ctx for plane functions drm: Add acquire ctx parameter to ->update_plane drm: drm_plane_force_disable is not for atomic drivers drm: Add acquire ctx parameter to ->plane_disable drm/atomic-helper: remove backoff hack from disable/update_plane drm/vmwgfx: Drop the cursor locking hack drm/tegra: Don't use modeset_lock_crtc drm/tilcdc: Drop calls to modeset_lock_crtc drm: Make drm_modeset_lock_crtc internal drm: Roll out acquire context for the page_flip ioctl drm: Add acquire ctx parameter to ->page_flip(_target) drm/atomic-helper: remove backoff hack from page_flip drm: simplify the locking in the GETCRTC ioctl drm: Remove drm_modeset_(un)lock_crtc drm: Remove drm_modeset_legacy_acquire_ctx and crtc->acquire_ctx drm: Restrict drm_mode_set_config_internal to non-atomic drivers drm: Add explicit acquire ctx handling around ->set_config drm: Add acquire ctx parameter to ->set_config drm/atomic-helper: Remove the backoff hack from set_config drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 6 +- drivers/gpu/drm/armada/armada_crtc.c | 3 +- drivers/gpu/drm/armada/armada_overlay.c | 6 +- drivers/gpu/drm/bochs/bochs_kms.c | 3 +- drivers/gpu/drm/drm_atomic.c | 14 --- drivers/gpu/drm/drm_atomic_helper.c | 132 +++++----------------------- drivers/gpu/drm/drm_crtc.c | 61 ++++++++----- drivers/gpu/drm/drm_crtc_helper.c | 4 +- drivers/gpu/drm/drm_modeset_lock.c | 102 --------------------- drivers/gpu/drm/drm_plane.c | 87 ++++++++++++++---- drivers/gpu/drm/drm_plane_helper.c | 11 ++- drivers/gpu/drm/gma500/gma_display.c | 7 +- drivers/gpu/drm/gma500/gma_display.h | 3 +- drivers/gpu/drm/i915/intel_display.c | 9 +- drivers/gpu/drm/i915/intel_pipe_crc.c | 2 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 8 +- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 7 +- drivers/gpu/drm/nouveau/dispnv04/overlay.c | 18 ++-- drivers/gpu/drm/nouveau/nouveau_display.c | 3 +- drivers/gpu/drm/nouveau/nouveau_display.h | 4 +- drivers/gpu/drm/radeon/radeon_display.c | 8 +- drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 3 +- drivers/gpu/drm/shmobile/shmob_drm_plane.c | 8 +- drivers/gpu/drm/tegra/dc.c | 8 +- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 12 +-- drivers/gpu/drm/udl/udl_modeset.c | 3 +- drivers/gpu/drm/vc4/vc4_crtc.c | 5 +- drivers/gpu/drm/vc4/vc4_plane.c | 6 +- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 25 ------ drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 3 +- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 6 +- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 6 +- include/drm/drm_atomic_helper.h | 15 ++-- include/drm/drm_crtc.h | 18 ++-- include/drm/drm_crtc_helper.h | 3 +- include/drm/drm_modeset_lock.h | 5 -- include/drm/drm_plane.h | 7 +- include/drm/drm_plane_helper.h | 6 +- 39 files changed, 265 insertions(+), 380 deletions(-) -- 2.11.0

11 51

[drm:drm-syncobj 2/8] drivers//dma-buf/sw_sync.c:318:14: error: too few arguments to function 'sync_file_create'
by kbuild test robot 04 Apr '17

04 Apr '17

tree: git://people.freedesktop.org/~airlied/linux.git drm-syncobj head: af9b558e5436d76fde927fd1f68cc35adec4d6ea commit: e9069d711a815ca17b9bf687b935ae8383b4565e [2/8] sync_file: add type/flags to sync file object creation. config: x86_64-rhel (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: git checkout e9069d711a815ca17b9bf687b935ae8383b4565e # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers//dma-buf/sw_sync.c: In function 'sw_sync_ioctl_create_fence': >> drivers//dma-buf/sw_sync.c:318:14: error: too few arguments to function 'sync_file_create' sync_file = sync_file_create(&pt->base); ^~~~~~~~~~~~~~~~ In file included from drivers//dma-buf/sw_sync.c:21:0: include/linux/sync_file.h:56:19: note: declared here struct sync_file *sync_file_create(struct dma_fence *fence, uint32_t type, uint32_t flags); ^~~~~~~~~~~~~~~~ vim +/sync_file_create +318 drivers//dma-buf/sw_sync.c 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 312 pt = sync_pt_create(obj, sizeof(*pt), data.value); 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 313 if (!pt) { 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 314 err = -ENOMEM; 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 315 goto err; 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 316 } 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 317 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 @318 sync_file = sync_file_create(&pt->base); f54d1867 drivers/dma-buf/sw_sync.c Chris Wilson 2016-10-25 319 dma_fence_put(&pt->base); 4592bfcd drivers/dma-buf/sw_sync.c Gustavo Padovan 2016-10-26 320 if (!sync_file) { 1867a23b drivers/staging/android/sw_sync.c Gustavo Padovan 2016-05-31 321 err = -ENOMEM; :::::: The code at line 318 was first introduced by commit :::::: 1867a23b13b25d0a228b0509ade20fb977dcb601 staging/android: move sw_sync related code to sw_sync.c :::::: TO: Gustavo Padovan <gustavo.padovan(a)collabora.co.uk> :::::: CC: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[Bug 195159] nouveau incorrect ACPI usgage results in ACPI Error : AE_AML_PACKAGE_LIMIT
by bugzilla-daemon＠bugzilla.kernel.org 03 Apr '17

03 Apr '17

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2017