dri-devel June 2017

dri-devel@lists.freedesktop.org

228 participants
1479 discussions

[Bug 101254] VDPAU videos don't start playing with r600 gallium driver
by bugzilla-daemon＠freedesktop.org 07 Jun '17

07 Jun '17

https://bugs.freedesktop.org/show_bug.cgi?id=101254 --- Comment #15 from Marek Olšák <maraeo(a)gmail.com> --- It's the real fix. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH] drm/pl111: Fix offset calculation for the primary plane.
by Eric Anholt 07 Jun '17

07 Jun '17

If src_x/y were nonzero, we failed to shift them down by 16 to get the pixel offset. The recent CMA helper function gets it right. Signed-off-by: Eric Anholt <eric(a)anholt.net> Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111") Reported-by: Mircea Carausu <mircea.carausu(a)broadcom.com> --- drivers/gpu/drm/pl111/pl111_display.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c index 3e0a4fa73ddb..c6ca4f1bbd49 100644 --- a/drivers/gpu/drm/pl111/pl111_display.c +++ b/drivers/gpu/drm/pl111/pl111_display.c @@ -50,17 +50,6 @@ irqreturn_t pl111_irq(int irq, void *data) return status; } -static u32 pl111_get_fb_offset(struct drm_plane_state *pstate) -{ - struct drm_framebuffer *fb = pstate->fb; - struct drm_gem_cma_object *obj = drm_fb_cma_get_gem_obj(fb, 0); - - return (obj->paddr + - fb->offsets[0] + - fb->format->cpp[0] * pstate->src_x + - fb->pitches[0] * pstate->src_y); -} - static int pl111_display_check(struct drm_simple_display_pipe *pipe, struct drm_plane_state *pstate, struct drm_crtc_state *cstate) @@ -73,7 +62,7 @@ static int pl111_display_check(struct drm_simple_display_pipe *pipe, return -EINVAL; if (fb) { - u32 offset = pl111_get_fb_offset(pstate); + u32 offset = drm_fb_cma_get_gem_addr(fb, pstate, 0); /* FB base address must be dword aligned. */ if (offset & 3) @@ -249,7 +238,7 @@ static void pl111_display_update(struct drm_simple_display_pipe *pipe, struct drm_framebuffer *fb = pstate->fb; if (fb) { - u32 addr = pl111_get_fb_offset(pstate); + u32 addr = drm_fb_cma_get_gem_addr(fb, pstate, 0); writel(addr, priv->regs + CLCD_UBAS); } -- 2.11.0

2 2

[PATCH -next] drm: pl111: select DRM_PANEL
by Randy Dunlap 07 Jun '17

07 Jun '17

From: Randy Dunlap <rdunlap(a)infradead.org> The drm pl111 driver uses drm_panel interfaces so it should select DRM_PANEL to fix build errors. drivers/built-in.o: In function `pl111_connector_destroy': pl111_connector.c:(.text+0xc7285): undefined reference to `drm_panel_detach' Signed-off-by: Randy Dunlap <rdunlap(a)infradead.org> --- drivers/gpu/drm/pl111/Kconfig | 1 + 1 file changed, 1 insertion(+) --- linux-next-20170606.orig/drivers/gpu/drm/pl111/Kconfig +++ linux-next-20170606/drivers/gpu/drm/pl111/Kconfig @@ -3,6 +3,7 @@ config DRM_PL111 depends on DRM depends on ARM || ARM64 || COMPILE_TEST depends on COMMON_CLK + select DRM_PANEL select DRM_KMS_HELPER select DRM_KMS_CMA_HELPER select DRM_GEM_CMA_HELPER

2 1

[PATCH for 4.12] cec: race fix: don't return -ENONET in cec_receive()
by Hans Verkuil 07 Jun '17

07 Jun '17

When calling CEC_RECEIVE do not check if the adapter is configured. Typically CEC_RECEIVE is called after a select() and if that indicates that there are messages in the receive queue, then you should always be able to dequeue a message. The race condition here is that a message has been received and is queued, so select() tells userspace that a message is available. But before the application calls CEC_RECEIVE the adapter is unconfigured (e.g. the HDMI cable is removed). Now select will always report that there is a message, but calling CEC_RECEIVE will always return -ENONET because the adapter is no longer configured and so will never actually dequeue the message. There is really no need for this check, and in fact the ENONET error code was never documented for CEC_RECEIVE. This may have been a left-over of old code that was never updated. Signed-off-by: Hans Verkuil <hans.verkuil(a)cisco.com> Cc: <stable(a)vger.kernel.org> # for v4.10 and up --- drivers/media/cec/cec-api.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/media/cec/cec-api.c b/drivers/media/cec/cec-api.c index 1359c3977101..f7eb4c54a354 100644 --- a/drivers/media/cec/cec-api.c +++ b/drivers/media/cec/cec-api.c @@ -272,16 +272,10 @@ static long cec_receive(struct cec_adapter *adap, struct cec_fh *fh, bool block, struct cec_msg __user *parg) { struct cec_msg msg = {}; - long err = 0; + long err; if (copy_from_user(&msg, parg, sizeof(msg))) return -EFAULT; - mutex_lock(&adap->lock); - if (!adap->is_configured && fh->mode_follower < CEC_MODE_MONITOR) - err = -ENONET; - mutex_unlock(&adap->lock); - if (err) - return err; err = cec_receive_msg(fh, &msg, block); if (err) -- 2.11.0

1 0

[PATCH] drm/atmel-hlcdc: Fix panel registration
by Boris Brezillon 07 Jun '17

07 Jun '17

Attach the panel-bridge created by drm_panel_bridge_add() to the parallel RGB encoder. Fixes: 96160a8071b2 ("drm/atmel-hlcdc: Replace the panel usage with drm_panel_bridge.") Signed-off-by: Boris Brezillon <boris.brezillon(a)free-electrons.com> --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c index 340ef962aa81..dfdd18763b0a 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c @@ -59,8 +59,6 @@ static int atmel_hlcdc_attach_endpoint(struct drm_device *dev, bridge = drm_panel_bridge_add(panel, DRM_MODE_CONNECTOR_Unknown); if (IS_ERR(bridge)) return PTR_ERR(bridge); - - return 0; } if (bridge) { -- 2.7.4

3 2

[Bug 101309] [GLK] ["MIPI" igt@kms_frontbuffer_tracking@basic]
by bugzilla-daemon＠freedesktop.org 07 Jun '17

07 Jun '17

https://bugs.freedesktop.org/show_bug.cgi?id=101309 Bug ID: 101309 Summary: [GLK] ["MIPI" igt@kms_frontbuffer_tracking@basic] Product: DRI Version: XOrg git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: IGT Assignee: dri-devel(a)lists.freedesktop.org Reporter: maria.g.perez.ibarra(a)intel.com Created attachment 131727 --> https://bugs.freedesktop.org/attachment.cgi?id=131727&action=edit dmesg.log ==Bug detailed description== -------------------------------------------------- this test is failing in GLK with the following configuration igt@kms_frontbuffer_tracking@basic ==Steps to reproduce== -------------------------------------------------- ./kms_frontbuffer_tracking --r basic ==Actual results== -------------------------------------------------- Subtest basic: FAIL (0.787s) (kms_frontbuffer_tracking:2158) igt-core-DEBUG: Exiting with status code 99 (kms_frontbuffer_tracking:2158) igt-debugfs-DEBUG: Opening debugfs directory '/sys/kernel/debug/dri/0' (kms_frontbuffer_tracking:2158) igt-kms-DEBUG: VT: original mode 0x0 restored (kms_frontbuffer_tracking:2158) igt-debugfs-DEBUG: Opening debugfs directory '/sys/kernel/debug/dri/0' Software ====================================== kernel version : 4.12.0-rc3-0af3152-madhav-0001-drm-cold-boot-g0af3152-dirty architecture : x86_64 os version : Ubuntu 17.04 os codename : zesty kernel driver : i915 bios revision : 49.61 bios release date : 05/27/2017 ksc : 1.25 ====================================== Graphic drivers ====================================== libdrm : 2.4.80 cairo : 1.15.5 intel-gpu-tools (tag) : intel-gpu-tools-1.18-209-g26c266fe intel-gpu-tools (commit) : 26c266fe ====================================== Hardware ====================================== platform : Geminilake motherboard model : Geminilake motherboard id : GLKRVP1DDR4(05) cpu family id : 6 cpu information : Genuine Intel(R) CPU @ 1.10GHz gpu card : Intel Corporation Device 3184 (rev 01) (prog-if 00 [VGA controller]) memory ram : 3.43 GB max memory ram : 16 GB cpu thread : 4 cpu core : 4 cpu model : 122 socket : Other hard drive : 447GiB (480GB) displays connected : DSI-1 ====================================== Firmware ====================================== dmc fw loaded : yes dmc version : 1.4 guc fw loaded : NONE ==Attachments== -------------------------------------------------- dmesg.log -- You are receiving this mail because: You are the assignee for the bug.

1 1

[PATCH] drm/meson: Fix driver bind when only CVBS is available
by Neil Armstrong 07 Jun '17

07 Jun '17

While introducing HDMI support, component matching on connectors node were bypassed since no driver would actually bind on the DT node. But when only a CVBS connector is present, only a single node is found in the graph, but ignored and a NULL match table is given to the component code. This code permits bypassing the components framework by binding directly the DRM driver when no components needs to be loaded. Fixes: a41e82e6c457 ("drm/meson: Add support for components") Signed-off-by: Neil Armstrong <narmstrong(a)baylibre.com> --- drivers/gpu/drm/meson/meson_drv.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c index 75382f5..10b227d 100644 --- a/drivers/gpu/drm/meson/meson_drv.c +++ b/drivers/gpu/drm/meson/meson_drv.c @@ -152,7 +152,7 @@ static bool meson_vpu_has_available_connectors(struct device *dev) .max_register = 0x1000, }; -static int meson_drv_bind(struct device *dev) +static int meson_drv_bind_master(struct device *dev, bool has_components) { struct platform_device *pdev = to_platform_device(dev); struct meson_drm *priv; @@ -233,10 +233,12 @@ static int meson_drv_bind(struct device *dev) if (ret) goto free_drm; - ret = component_bind_all(drm->dev, drm); - if (ret) { - dev_err(drm->dev, "Couldn't bind all components\n"); - goto free_drm; + if (has_components) { + ret = component_bind_all(drm->dev, drm); + if (ret) { + dev_err(drm->dev, "Couldn't bind all components\n"); + goto free_drm; + } } ret = meson_plane_create(priv); @@ -276,6 +278,11 @@ static int meson_drv_bind(struct device *dev) return ret; } +static int meson_drv_bind(struct device *dev) +{ + return meson_drv_bind_master(dev, true); +} + static void meson_drv_unbind(struct device *dev) { struct drm_device *drm = dev_get_drvdata(dev); @@ -357,6 +364,9 @@ static int meson_drv_probe(struct platform_device *pdev) count += meson_probe_remote(pdev, &match, np, remote); } + if (count && !match) + return meson_drv_bind_master(&pdev->dev, false); + /* If some endpoints were found, initialize the nodes */ if (count) { dev_info(&pdev->dev, "Queued %d outputs on vpu\n", count); -- 1.9.1

2 2

[PATCH] drm/imx: ipuv3-plane: use fb local variable instead of state->fb
by Philipp Zabel 07 Jun '17

07 Jun '17

We already have a local variable assigned to state->fb, use it. Signed-off-by: Philipp Zabel <p.zabel(a)pengutronix.de> --- drivers/gpu/drm/imx/ipuv3-plane.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c index d63e853a03006..a9292e3d3c437 100644 --- a/drivers/gpu/drm/imx/ipuv3-plane.c +++ b/drivers/gpu/drm/imx/ipuv3-plane.c @@ -525,8 +525,8 @@ static void ipu_plane_atomic_update(struct drm_plane *plane, ipu_prg_channel_configure(ipu_plane->ipu_ch, axi_id, drm_rect_width(&state->src) >> 16, drm_rect_height(&state->src) >> 16, - state->fb->pitches[0], - state->fb->format->format, &eba); + fb->pitches[0], + fb->format->format, &eba); } if (old_state->fb && !drm_atomic_crtc_needs_modeset(crtc_state)) { @@ -553,11 +553,11 @@ static void ipu_plane_atomic_update(struct drm_plane *plane, ipu_dp_set_global_alpha(ipu_plane->dp, true, 0, true); break; case IPU_DP_FLOW_SYNC_FG: - ics = ipu_drm_fourcc_to_colorspace(state->fb->format->format); + ics = ipu_drm_fourcc_to_colorspace(fb->format->format); ipu_dp_setup_channel(ipu_plane->dp, ics, IPUV3_COLORSPACE_UNKNOWN); /* Enable local alpha on partial plane */ - switch (state->fb->format->format) { + switch (fb->format->format) { case DRM_FORMAT_ARGB1555: case DRM_FORMAT_ABGR1555: case DRM_FORMAT_RGBA5551: @@ -587,10 +587,10 @@ static void ipu_plane_atomic_update(struct drm_plane *plane, ipu_cpmem_set_resolution(ipu_plane->ipu_ch, drm_rect_width(&state->src) >> 16, drm_rect_height(&state->src) >> 16); - ipu_cpmem_set_fmt(ipu_plane->ipu_ch, state->fb->format->format); + ipu_cpmem_set_fmt(ipu_plane->ipu_ch, fb->format->format); ipu_cpmem_set_high_priority(ipu_plane->ipu_ch); ipu_idmac_set_double_buffer(ipu_plane->ipu_ch, 1); - ipu_cpmem_set_stride(ipu_plane->ipu_ch, state->fb->pitches[0]); + ipu_cpmem_set_stride(ipu_plane->ipu_ch, fb->pitches[0]); ipu_cpmem_set_axi_id(ipu_plane->ipu_ch, axi_id); switch (fb->format->format) { case DRM_FORMAT_YUV420: @@ -644,8 +644,7 @@ static void ipu_plane_atomic_update(struct drm_plane *plane, ipu_cpmem_set_format_passthrough(ipu_plane->alpha_ch, 8); ipu_cpmem_set_high_priority(ipu_plane->alpha_ch); ipu_idmac_set_double_buffer(ipu_plane->alpha_ch, 1); - ipu_cpmem_set_stride(ipu_plane->alpha_ch, - state->fb->pitches[1]); + ipu_cpmem_set_stride(ipu_plane->alpha_ch, fb->pitches[1]); ipu_cpmem_set_burstsize(ipu_plane->alpha_ch, 16); ipu_cpmem_set_buffer(ipu_plane->alpha_ch, 0, alpha_eba); ipu_cpmem_set_buffer(ipu_plane->alpha_ch, 1, alpha_eba); -- 2.11.0

1 0

[Bug 101254] VDPAU videos don't start playing with r600 gallium driver
by bugzilla-daemon＠freedesktop.org 07 Jun '17

07 Jun '17

https://bugs.freedesktop.org/show_bug.cgi?id=101254 --- Comment #14 from joeri.exelmans(a)gmail.com --- With the patch, VDPAU works again. Is it a fix or does it simply disable a feature? -- You are receiving this mail because: You are the assignee for the bug.

1 0

[git pull] vmwgfx-fixes-4.12
by Thomas Hellstrom 07 Jun '17

07 Jun '17

Dave, A bunch of fixes for vmwgfx 4.12 regressions and older stuff. In the latter case either trivial, cc'd stable or requiring backports for stable. The following changes since commit e5b4ab1ffbe2553ee278cb1b6bcb671a31d86518: Merge tag 'drm-misc-fixes-2017-06-02' of git://anongit.freedesktop.org/git/drm-misc into drm-fixes (2017-06-06 16:52:15 +1000) are available in the git repository at: git://people.freedesktop.org/~thomash/linux vmwgfx-fixes-4.12 for you to fetch changes up to 1929e6610bddf0cc44f0859fc72d4016cba0c1fa: drm/vmwgfx: Bump driver minor and date (2017-06-07 14:46:15 +0200) ---------------------------------------------------------------- Colin Ian King (1): drm/vmwgfx: fix spelling mistake "exeeds" -> "exceeds" Dan Carpenter (1): drm/vmwgfx: Handle vmalloc() failure in vmw_local_fifo_reserve() Sinclair Yeh (5): drm/vmwgfx: Don't create proxy surface for cursor drm/vmwgfx: Make sure backup_handle is always valid drm/vmwgfx: Make sure to update STDU when FB is updated drm/vmwgfx: Fix large topology crash drm/vmwgfx: Remove unused legacy cursor functions Thomas Hellstrom (1): drm/vmwgfx: Bump driver minor and date Vladis Dronov (1): drm/vmwgfx: limit the number of mip levels in vmw_gb_surface_define_ioctl() drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 4 +- drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c | 2 + drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 115 +------------------------------- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 15 ----- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 27 ++++++-- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 23 ++++--- 6 files changed, 42 insertions(+), 144 deletions(-)

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel June 2017