dri-devel June 2017

dri-devel@lists.freedesktop.org

228 participants
1479 discussions

[PATCH -fixes 1/9] drm/vmwgfx: limit the number of mip levels in vmw_gb_surface_define_ioctl()
by Thomas Hellstrom 07 Jun '17

07 Jun '17

From: Vladis Dronov <vdronov(a)redhat.com> The 'req->mip_levels' parameter in vmw_gb_surface_define_ioctl() is a user-controlled 'uint32_t' value which is used as a loop count limit. This can lead to a kernel lockup and DoS. Add check for 'req->mip_levels'. References: https://bugzilla.redhat.com/show_bug.cgi?id=1437431 Cc: <stable(a)vger.kernel.org> Signed-off-by: Vladis Dronov <vdronov(a)redhat.com> Reviewed-by: Sinclair Yeh <syeh(a)vmware.com> --- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c index 7681341..baf03d4 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c @@ -1279,6 +1279,9 @@ int vmw_gb_surface_define_ioctl(struct drm_device *dev, void *data, if (req->multisample_count != 0) return -EINVAL; + if (req->mip_levels > DRM_VMW_MAX_MIP_LEVELS) + return -EINVAL; + if (unlikely(vmw_user_surface_size == 0)) vmw_user_surface_size = ttm_round_pot(sizeof(*user_srf)) + 128; -- 2.7.4

1 8

[Bug 101254] VDPAU videos don't start playing with r600 gallium driver
by bugzilla-daemon＠freedesktop.org 07 Jun '17

07 Jun '17

https://bugs.freedesktop.org/show_bug.cgi?id=101254 --- Comment #13 from Marek Olšák <maraeo(a)gmail.com> --- Created attachment 131771 --> https://bugs.freedesktop.org/attachment.cgi?id=131771&action=edit possible fix Can you try this patch? -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 101254] VDPAU videos don't start playing with r600 gallium driver
by bugzilla-daemon＠freedesktop.org 07 Jun '17

07 Jun '17

https://bugs.freedesktop.org/show_bug.cgi?id=101254 --- Comment #12 from joeri.exelmans(a)gmail.com --- Okay, I found the (series of) commits that break VDPAU in Kodi and mpv. They were added to the master branch on 2017-05-15 11:01:33 (GMT), all authored by Marek Olšák <marek.olsak(a)amd.com>. This is the last commit that works: https://cgit.freedesktop.org/mesa/mesa/commit/?id=42fe45b45161e9c9d71443692… Summary: gallium/radeon: require both WRITE and FLUSH_EXPLICIT in buffer_flush_region Next there are a number of commits, all by Marek Olšák that won't compile because an include is missing: https://cgit.freedesktop.org/mesa/mesa/commit/?id=8b5485957e19287f7e694e7e8… Summary: gallium/radeon: unwrap a context if we get a wrapped one https://cgit.freedesktop.org/mesa/mesa/commit/?id=e11f7e1d5996532228c6494ff… Summary: gallium/radeon: handle TC_TRANSFER_MAP_THREADED_UNSYNC https://cgit.freedesktop.org/mesa/mesa/commit/?id=93d549b2af84158f25842fd08… Summary: gallium/radeon: handle other map buffer flags from the threaded context The next commit fixes the missing include and hence compiles, but has the bug that this thread is about: https://cgit.freedesktop.org/mesa/mesa/commit/?id=b4fc399c088f77a8e42674270… Summary: gallium/radeon: subclass threaded_resource -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH][drm-next] drm/nouveau: fix non-ANSI function declaration of nouveau_pmops_runtime
by Colin King 07 Jun '17

07 Jun '17

From: Colin Ian King <colin.king(a)canonical.com> Give function nouveau_pmops_runtime a void argument to make it an ANSI function declaration. Fixes sparse warning: warning: non-ANSI function declaration of function 'nouveau_pmops_runtime' Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index 7acd1cf8c5a6..90757af9bc73 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drm.c +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c @@ -727,7 +727,7 @@ nouveau_pmops_thaw(struct device *dev) } bool -nouveau_pmops_runtime() +nouveau_pmops_runtime(void) { if (nouveau_runtime_pm == -1) return nouveau_is_optimus() || nouveau_is_v1_dsm(); -- 2.11.0

1 0

[Bug 101254] VDPAU videos don't start playing with r600 gallium driver
by bugzilla-daemon＠freedesktop.org 07 Jun '17

07 Jun '17

https://bugs.freedesktop.org/show_bug.cgi?id=101254 --- Comment #11 from H4nN1baL <reizemberk(a)gmail.com> --- I use mpv 0.25.0-9-g18703b55d until an update of padoka PPA broke vdpau. After that I have been recompiling ffmpeg and mpv regularly to see if any updates fix the issue, but so far all the results have been unfruitful. I even did some downgrades to mpv, but I also did not succeed. The only thing that I not tried is to use an older version of ffmpeg compiled with the old vdpau API (--enable-gpl --enable-version3) with an mpv version prior to this: https://github.com/mpv-player/mpv/commit/f59371de2170141fc28540d03c4e7ecc62… -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH v2] drm/imx: imx-ldb: Accept drm_of_find_panel_or_bridge failure
by Leonard Crestez 07 Jun '17

07 Jun '17

Not having an endpoint bound in DT should not cause a failure here, there are fallbacks. So explicitly accept a missing endpoint. This behavior change was introduced by refactoring in drm_of parsing code and it should not require dts changes. In particular this fixes imx6qdl-sabreauto boards. Link: https://lists.freedesktop.org/archives/dri-devel/2017-May/141233.html Fixes: ebc944613567 ("drm: convert drivers to use drm_of_find_panel_or_bridge") Signed-off-by: Leonard Crestez <leonard.crestez(a)nxp.com> --- This relies on drm_of_find_panel_or_bridge returning -ENODEV specifically if no remote is found for the endpoint. This behavior can be seen by looking at the code but is not otherwise obviously guaranteed. Perhaps this should be explicitly mentioned in that function's documentation? Changes since v1: * Fix returning if ret is 0. drivers/gpu/drm/imx/imx-ldb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c index 8fb801f..8b05ecb 100644 --- a/drivers/gpu/drm/imx/imx-ldb.c +++ b/drivers/gpu/drm/imx/imx-ldb.c @@ -673,7 +673,7 @@ static int imx_ldb_bind(struct device *dev, struct device *master, void *data) ret = drm_of_find_panel_or_bridge(child, imx_ldb->lvds_mux ? 4 : 2, 0, &channel->panel, &channel->bridge); - if (ret) + if (ret && ret != -ENODEV) return ret; /* panel ddc only if there is no bridge */ -- 2.7.4

2 2

Kernel panic on nouveau during boot on NVIDIA NV118 (GM108)
by Chris Chiu 07 Jun '17

07 Jun '17

We are working with new desktop that have the NVIDIA NV118 chipset. During boot, the display becomes unusable at the point where the nouveau driver loads. We have reproduced on 4.8, 4.11 and linux master (4.12-rc3). Dmesg log is attached. Is this a known issue? Anything we can do to help? Thanks

4 4

[Bug 101254] VDPAU videos don't start playing with r600 gallium driver
by bugzilla-daemon＠freedesktop.org 07 Jun '17

07 Jun '17

https://bugs.freedesktop.org/show_bug.cgi?id=101254 --- Comment #10 from joeri.exelmans(a)gmail.com --- Edited summary, changed component Drivers/Gallium/radeonsi -> Drivers/Gallium/r600 -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 101254] VDPAU videos don't start playing with r600 gallium driver
by bugzilla-daemon＠freedesktop.org 07 Jun '17

07 Jun '17

https://bugs.freedesktop.org/show_bug.cgi?id=101254 joeri.exelmans(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Drivers/Gallium/radeonsi |Drivers/Gallium/r600 Version|unspecified |git -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 101254] VDPAU videos don't start playing with r600 gallium driver
by bugzilla-daemon＠freedesktop.org 07 Jun '17

07 Jun '17

https://bugs.freedesktop.org/show_bug.cgi?id=101254 joeri.exelmans(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|VDPAU videos take forever |VDPAU videos don't start |to start in different |playing with r600 gallium |applications |driver -- You are receiving this mail because: You are the assignee for the bug.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel June 2017