dri-devel September 2017

dri-devel@lists.freedesktop.org

210 participants
1526 discussions

[Bug 101747] Steam-Game Turmoil, Segfault on start
by bugzilla-daemon＠freedesktop.org 14 Sep '17

14 Sep '17

https://bugs.freedesktop.org/show_bug.cgi?id=101747 Bug ID: 101747 Summary: Steam-Game Turmoil, Segfault on start Product: Mesa Version: 13.0 Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel(a)lists.freedesktop.org Reporter: richard.llom(a)gmail.com QA Contact: dri-devel(a)lists.freedesktop.org Turmoil: http://store.steampowered.com/app/361280/Turmoil/ Crashes on startup (see terminal output below) Judging from this forum thread: http://steamcommunity.com/app/361280/discussions/0/135511027313938924/ It is working under mesa+intel, but not under mesa+radeonsi. Terminal output: $ ./run.sh ./runner: /usr/lib32/libcrypto.so.1.0.0: no version information available (required by ./runner) ./runner: /usr/lib32/libssl.so.1.0.0: no version information available (required by ./runner) *************************************** * YoYo Games Linux Runner V1.3 * *************************************** CommandLine: -game game.unx ExeName= /run/media/richard/mmedia/Steam/steamapps/common/Turmoil/runner MemoryManager allocated: 1722124 *************************************** * YoYo Games Runner v1.0(999)[r32908] * *************************************** RunnerLoadGame: game.unx RunnerLoadGame() - assets/game.unx Checking if INIFile assets/options.ini Exists assets/options.ini file contents: [Linux] DisplayName="TurmoilSteam" NewDebugger=0 INI DisplayName=TurmoilSteam Reading File assets/game.unx Loaded File assets/game.unx(40091152) IFF wad found Get Resolution Get Header Information InitGMLFunctions HighScore..SavePrePend /home/richard/.config/TurmoilSteam/ Game..Math..Graphic..Action..File..Resource..Interaction..3D..Particle..Misc..DS..Sound..Physics..Gamepad..GAMEPAD: Initialising Ubuntu support GAMEPAD: 4 axis values (last) at 0xf7778580 GAMEPAD: 4 axis values (last) at 0xf7778560 GAMEPAD: 4 axis values (last) at 0xf7778540 GAMEPAD: 4 axis values (last) at 0xf7778520 Buffers..Networking..Shaders..Steam being initialised with appId 361280 Steam_Init Steam - SteamAPI_RestartAppIfNecessary szCmd: /bin/sh -c '"/home/richard/.local/share/Steam/steam.sh" "steam://run/361280"' & Steam - Restart required Steam_Init SteamInit failed with no msg InitPushFunctions...YoYo..Fini Code_Load() VARI_Load() got 51 global variables got 898 instance variables got 171 local variables ID_STRG Steam restarting via client Running Steam on chakra 2017.02 64-bit STEAM_RUNTIME is enabled automatically ./run.sh: line 3: 8130 Segmentation fault (core dumped) LD_LIBRARY_PATH=./lib:$LD_LIBRARY_PATH ./runner -- You are receiving this mail because: You are the assignee for the bug.

1 3

Resizeable PCI BAR support V8
by Christian König 14 Sep '17

14 Sep '17

Hi everyone, This is the eighth incarnation of this set of patches. It enables device drivers to resize and most likely also relocate the PCI BAR of devices they manage to allow the CPU to access all of the device local memory at once. This is very useful for GFX device drivers where the default PCI BAR is only about 256MB in size for compatibility reasons, but the device easily have multiple gigabyte of local memory. Some changes since the last version: 1. Rebased on Linus current master tree, going to rebase on 4.13-rc1 as soon as that is out. 2. Some more documentation on how to use the new functionality in drivers. 3. Only re-enable decoding when everything looks good. 4. Rename the new amdgpu function to better match what it is doing. Bjorn what's you'r feeling on getting this into 4.14? Regards, Christian.

4 12

[PATCH libdrm 1/4] amdgpu: add sync_file import and export functions
by Marek Olšák 14 Sep '17

14 Sep '17

From: Marek Olšák <marek.olsak(a)amd.com> --- amdgpu/amdgpu.h | 30 ++++++++++++++++++++++++++++++ amdgpu/amdgpu_cs.c | 20 ++++++++++++++++++++ 2 files changed, 50 insertions(+) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index 238b1aa..b44b9b6 100644 --- a/amdgpu/amdgpu.h +++ b/amdgpu/amdgpu.h @@ -1383,6 +1383,36 @@ int amdgpu_cs_import_syncobj(amdgpu_device_handle dev, uint32_t *syncobj); /** + * Export kernel sync object to a sync_file. + * + * \param dev - \c [in] device handle + * \param syncobj - \c [in] sync object handle + * \param sync_file_fd - \c [out] sync_file file descriptor. + * + * \return 0 on success\n + * <0 - Negative POSIX Error code + * + */ +int amdgpu_cs_syncobj_export_sync_file(amdgpu_device_handle dev, + uint32_t syncobj, + int *sync_file_fd); + +/** + * Import kernel sync object from a sync_file. + * + * \param dev - \c [in] device handle + * \param syncobj - \c [in] sync object handle + * \param sync_file_fd - \c [in] sync_file file descriptor. + * + * \return 0 on success\n + * <0 - Negative POSIX Error code + * + */ +int amdgpu_cs_syncobj_import_sync_file(amdgpu_device_handle dev, + uint32_t syncobj, + int sync_file_fd); + +/** * Submit raw command submission to kernel * * \param dev - \c [in] device handle diff --git a/amdgpu/amdgpu_cs.c b/amdgpu/amdgpu_cs.c index dfba875..4a05536 100644 --- a/amdgpu/amdgpu_cs.c +++ b/amdgpu/amdgpu_cs.c @@ -635,6 +635,26 @@ int amdgpu_cs_import_syncobj(amdgpu_device_handle dev, return drmSyncobjFDToHandle(dev->fd, shared_fd, handle); } +int amdgpu_cs_syncobj_export_sync_file(amdgpu_device_handle dev, + uint32_t syncobj, + int *sync_file_fd) +{ + if (NULL == dev) + return -EINVAL; + + return drmSyncobjExportSyncFile(dev->fd, syncobj, sync_file_fd); +} + +int amdgpu_cs_syncobj_import_sync_file(amdgpu_device_handle dev, + uint32_t syncobj, + int sync_file_fd) +{ + if (NULL == dev) + return -EINVAL; + + return drmSyncobjImportSyncFile(dev->fd, syncobj, sync_file_fd); +} + int amdgpu_cs_submit_raw(amdgpu_device_handle dev, amdgpu_context_handle context, amdgpu_bo_list_handle bo_list_handle, -- 2.7.4

2 4

[PATCH 1/2] drm/fsl-dcu: Fix DCU pixel clock issue in suspend/resume functions
by Alison Wang 14 Sep '17

14 Sep '17

As there is not corresponding clk_prepare_enable() for fsl_dev->pix_clk in previous contexts, clk_disable_unprepare() for fsl_dcu->pix_clk in suspend function will fail. This patch will add clk_prepare_enable() for fsl_dev->pix_clk in previous contexts and resume function to fix the issue. This patch is verified on LS1021ATWR board. Signed-off-by: Alison Wang <alison.wang(a)nxp.com> --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c index 58e9e0601a61..875b0fdc4274 100644 --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c @@ -230,6 +230,12 @@ static int fsl_dcu_drm_pm_resume(struct device *dev) return ret; } + ret = clk_prepare_enable(fsl_dev->pix_clk); + if (ret < 0) { + dev_err(dev, "failed to enable dcu pix clk\n"); + return ret; + } + if (fsl_dev->tcon) fsl_tcon_bypass_enable(fsl_dev->tcon); fsl_dcu_drm_init_planes(fsl_dev->drm); @@ -351,6 +357,12 @@ static int fsl_dcu_drm_probe(struct platform_device *pdev) goto disable_clk; } + ret = clk_prepare_enable(fsl_dev->pix_clk); + if (ret < 0) { + dev_err(dev, "failed to enable dcu pix clk\n"); + return ret; + } + fsl_dev->tcon = fsl_tcon_init(dev); drm = drm_dev_alloc(driver, dev); -- 2.14.1

1 1

[PATCH v2 3/3] drm: Remove assignment in if condition
by Meghana Madhyastha 14 Sep '17

14 Sep '17

Move the assignment so that it happens before the if condition. This results in syntax which is easier to read. Found by checkpath.pl Signed-off-by: Meghana Madhyastha <meghana.madhyastha(a)gmail.com> --- drivers/gpu/drm/drm_agpsupport.c | 31 ++++++++++++++++++------------- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_agpsupport.c b/drivers/gpu/drm/drm_agpsupport.c index 993e486..737f028 100644 --- a/drivers/gpu/drm/drm_agpsupport.c +++ b/drivers/gpu/drm/drm_agpsupport.c @@ -100,7 +100,8 @@ int drm_agp_acquire(struct drm_device *dev) return -ENODEV; if (dev->agp->acquired) return -EBUSY; - if (!(dev->agp->bridge = agp_backend_acquire(dev->pdev))) + dev->agp->bridge = agp_backend_acquire(dev->pdev); + if (!dev->agp->bridge) return -ENODEV; dev->agp->acquired = 1; return 0; @@ -200,12 +201,14 @@ int drm_agp_alloc(struct drm_device *dev, struct drm_agp_buffer *request) if (!dev->agp || !dev->agp->acquired) return -EINVAL; - if (!(entry = kzalloc(sizeof(*entry), GFP_KERNEL))) + entry = kzalloc(sizeof(*entry), GFP_KERNEL); + if (!entry) return -ENOMEM; pages = (request->size + PAGE_SIZE - 1) / PAGE_SIZE; type = (u32) request->type; - if (!(memory = agp_allocate_memory(dev->agp->bridge, pages, type))) { + memory = agp_allocate_memory(dev->agp->bridge, pages, type); + if (!memory) { kfree(entry); return -ENOMEM; } @@ -272,9 +275,8 @@ int drm_agp_unbind(struct drm_device *dev, struct drm_agp_binding *request) if (!dev->agp || !dev->agp->acquired) return -EINVAL; - if (!(entry = drm_agp_lookup_entry(dev, request->handle))) - return -EINVAL; - if (!entry->bound) + entry = drm_agp_lookup_entry(dev, request->handle); + if (!entry || !entry->bound) return -EINVAL; ret = drm_unbind_agp(entry->memory); if (ret == 0) @@ -313,12 +315,12 @@ int drm_agp_bind(struct drm_device *dev, struct drm_agp_binding *request) if (!dev->agp || !dev->agp->acquired) return -EINVAL; - if (!(entry = drm_agp_lookup_entry(dev, request->handle))) - return -EINVAL; - if (entry->bound) + entry = drm_agp_lookup_entry(dev, request->handle); + if (!entry || entry->bound) return -EINVAL; page = (request->offset + PAGE_SIZE - 1) / PAGE_SIZE; - if ((retcode = drm_bind_agp(entry->memory, page))) + retcode = drm_bind_agp(entry->memory, page); + if (retcode) return retcode; entry->bound = dev->agp->base + (page << PAGE_SHIFT); DRM_DEBUG("base = 0x%lx entry->bound = 0x%lx\n", @@ -356,7 +358,8 @@ int drm_agp_free(struct drm_device *dev, struct drm_agp_buffer *request) if (!dev->agp || !dev->agp->acquired) return -EINVAL; - if (!(entry = drm_agp_lookup_entry(dev, request->handle))) + entry = drm_agp_lookup_entry(dev, request->handle); + if (!entry) return -EINVAL; if (entry->bound) drm_unbind_agp(entry->memory); @@ -394,11 +397,13 @@ struct drm_agp_head *drm_agp_init(struct drm_device *dev) { struct drm_agp_head *head = NULL; - if (!(head = kzalloc(sizeof(*head), GFP_KERNEL))) + head = kzalloc(sizeof(*head), GFP_KERNEL); + if (!head) return NULL; head->bridge = agp_find_bridge(dev->pdev); if (!head->bridge) { - if (!(head->bridge = agp_backend_acquire(dev->pdev))) { + head->bridge = agp_backend_acquire(dev->pdev); + if (!head->bridge) { kfree(head); return NULL; } -- 2.7.4

3 2

[Bug 102552] Null dereference due to not checking return value of util_format_description
by bugzilla-daemon＠freedesktop.org 14 Sep '17

14 Sep '17

https://bugs.freedesktop.org/show_bug.cgi?id=102552 Bug ID: 102552 Summary: Null dereference due to not checking return value of util_format_description Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: All Status: NEW Severity: enhancement Priority: medium Component: Drivers/Gallium/r600 Assignee: dri-devel(a)lists.freedesktop.org Reporter: pauk.denis(a)gmail.com QA Contact: dri-devel(a)lists.freedesktop.org In case unsupported format util_format_description return NULL, and dereference will produce segffault. -- You are receiving this mail because: You are the assignee for the bug.

1 9

[Bug 102714] Kodi 17.1 broken in TAHITI
by bugzilla-daemon＠freedesktop.org 14 Sep '17

14 Sep '17

https://bugs.freedesktop.org/show_bug.cgi?id=102714 Bug ID: 102714 Summary: Kodi 17.1 broken in TAHITI Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: major Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel(a)lists.freedesktop.org Reporter: jrch2k10(a)gmail.com QA Contact: dri-devel(a)lists.freedesktop.org Hi, Guys I just realized kodi 17.1 is broken on mesa git when you enable Advanced Shaders and try to set on videos any option like bicubic or lanczos OS: ArchLinux latest updates Kernels tested: amd-staging-4.12 linux-mainline-4.13 Driver: AMDGPU My GLXINFO: name of display: :0 display: :0 screen: 0 direct rendering: Yes Extended renderer info (GLX_MESA_query_renderer): Vendor: X.Org (0x1002) Device: AMD Radeon HD 7900 Series (TAHITI / DRM 3.18.0 / 4.13.0-mainline, LLVM 6.0.0) (0x679a) Version: 17.3.0 Accelerated: yes Video memory: 2952MB Unified memory: no Preferred profile: core (0x1) Max core profile version: 4.5 Max compat profile version: 3.0 Max GLES1 profile version: 1.1 Max GLES[23] profile version: 3.1 OpenGL vendor string: X.Org OpenGL renderer string: AMD Radeon HD 7900 Series (TAHITI / DRM 3.18.0 / 4.13.0-mainline, LLVM 6.0.0) OpenGL core profile version string: 4.5 (Core Profile) Mesa 17.3.0-devel (git-74d2456491) OpenGL core profile shading language version string: 4.50 OpenGL core profile context flags: (none) OpenGL core profile profile mask: core profile OpenGL version string: 3.0 Mesa 17.3.0-devel (git-74d2456491) OpenGL shading language version string: 1.30 OpenGL context flags: (none) OpenGL ES profile version string: OpenGL ES 3.1 Mesa 17.3.0-devel (git-74d2456491) OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.10 Fail OUTPUT: LLVM triggered Diagnostic Handler: Illegal instruction detected: VOP* instruction uses the constant bus more than once %VGPR11<def> = V_MADMK_F32 %SGPR3, 1077936128, %VGPR17, %EXEC<imp-use> LLVM triggered Diagnostic Handler: Illegal instruction detected: VOP* instruction uses the constant bus more than once %VGPR10<def> = V_MADMK_F32 %SGPR2, 1077936128, %VGPR14, %EXEC<imp-use> LLVM failed to compile shader Tyvm, for your hard work -- You are receiving this mail because: You are the assignee for the bug.

1 3

[PATCH v2 2/3] drm: Replace "foo * bar" with "foo *bar"
by Meghana Madhyastha 13 Sep '17

13 Sep '17

This replaces all instances of foo * bar with foo *bar in drm_agpsupport.c. This is so that it adheres to standard C syntax for pointers. Signed-off-by: Meghana Madhyastha <meghana.madhyastha(a)gmail.com> --- drivers/gpu/drm/drm_agpsupport.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_agpsupport.c b/drivers/gpu/drm/drm_agpsupport.c index 928248e..993e486 100644 --- a/drivers/gpu/drm/drm_agpsupport.c +++ b/drivers/gpu/drm/drm_agpsupport.c @@ -94,7 +94,7 @@ int drm_agp_info_ioctl(struct drm_device *dev, void *data, * Verifies the AGP device hasn't been acquired before and calls * \c agp_backend_acquire. */ -int drm_agp_acquire(struct drm_device * dev) +int drm_agp_acquire(struct drm_device *dev) { if (!dev->agp) return -ENODEV; @@ -133,7 +133,7 @@ int drm_agp_acquire_ioctl(struct drm_device *dev, void *data, * * Verifies the AGP device has been acquired and calls \c agp_backend_release. */ -int drm_agp_release(struct drm_device * dev) +int drm_agp_release(struct drm_device *dev) { if (!dev->agp || !dev->agp->acquired) return -EINVAL; @@ -159,7 +159,7 @@ int drm_agp_release_ioctl(struct drm_device *dev, void *data, * Verifies the AGP device has been acquired but not enabled, and calls * \c agp_enable. */ -int drm_agp_enable(struct drm_device * dev, struct drm_agp_mode mode) +int drm_agp_enable(struct drm_device *dev, struct drm_agp_mode mode) { if (!dev->agp || !dev->agp->acquired) return -EINVAL; @@ -241,8 +241,8 @@ int drm_agp_alloc_ioctl(struct drm_device *dev, void *data, * * Walks through drm_agp_head::memory until finding a matching handle. */ -static struct drm_agp_mem *drm_agp_lookup_entry(struct drm_device * dev, - unsigned long handle) +static struct drm_agp_mem *drm_agp_lookup_entry(struct drm_device *dev, + unsigned long handle) { struct drm_agp_mem *entry; -- 2.7.4

3 2

[PATCH v2 1/3] drm: Move EXPORT_SYMBOL so that it immediately follows its function
by Meghana Madhyastha 13 Sep '17

13 Sep '17

EXPORT_SYMBOL(foo) should immediately follow its function/variable. This coding style is preferred. Found by checkpath.pl. Signed-off-by: Meghana Madhyastha <meghana.madhyastha(a)gmail.com> --- drivers/gpu/drm/drm_agpsupport.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/drm_agpsupport.c b/drivers/gpu/drm/drm_agpsupport.c index c899534..928248e 100644 --- a/drivers/gpu/drm/drm_agpsupport.c +++ b/drivers/gpu/drm/drm_agpsupport.c @@ -70,7 +70,6 @@ int drm_agp_info(struct drm_device *dev, struct drm_agp_info *info) return 0; } - EXPORT_SYMBOL(drm_agp_info); int drm_agp_info_ioctl(struct drm_device *dev, void *data, @@ -106,7 +105,6 @@ int drm_agp_acquire(struct drm_device * dev) dev->agp->acquired = 1; return 0; } - EXPORT_SYMBOL(drm_agp_acquire); /** @@ -171,7 +169,6 @@ int drm_agp_enable(struct drm_device * dev, struct drm_agp_mode mode) dev->agp->enabled = 1; return 0; } - EXPORT_SYMBOL(drm_agp_enable); int drm_agp_enable_ioctl(struct drm_device *dev, void *data, @@ -373,7 +370,6 @@ int drm_agp_free(struct drm_device *dev, struct drm_agp_buffer *request) EXPORT_SYMBOL(drm_agp_free); - int drm_agp_free_ioctl(struct drm_device *dev, void *data, struct drm_file *file_priv) { -- 2.7.4

3 2

[PATCH v2 0/3] drm: Code cleanup
by Meghana Madhyastha 13 Sep '17

13 Sep '17

These patches fix the checkpath warnings and errors in drm_agpsupport.c changes in v2: -Changed the commit subject prefix to follow the style used in drm. -Combine multiple redundant if conditions to a single condition in patch 3. Meghana Madhyastha (3): drm: Move EXPORT_SYMBOL so that it immediately follows its function drm: Replace "foo * bar" with "foo *bar" drm: Remove assignment in if condition drivers/gpu/drm/drm_agpsupport.c | 45 ++++++++++++++++++++-------------------- 1 file changed, 23 insertions(+), 22 deletions(-) -- 2.7.4

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2017