dri-devel September 2017

dri-devel@lists.freedesktop.org

210 participants
1526 discussions

[radeon-alex:amd-staging-drm-next 638/1021] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:1031:18: error: 'drm_atomic_helper_crtc_set_property' undeclared here (not in a function)
by kbuild test robot 13 Sep '17

13 Sep '17

tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next head: 43dd6fde5df450938568885249b836eb376e2ad6 commit: 13caa908431faa8016f21d3bca700adf0b8382c5 [638/1021] drm/amd/display: fix drm_edid.h inclusion config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 6.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 13caa908431faa8016f21d3bca700adf0b8382c5 # save the attached .config to linux build tree make.cross ARCH=ia64 Note: the radeon-alex/amd-staging-drm-next HEAD 43dd6fde5df450938568885249b836eb376e2ad6 builds fine. It only hurts bisectibility. All error/warnings (new ones prefixed by >>): In file included from include/linux/kernel.h:10:0, from include/linux/list.h:8, from include/linux/agp_backend.h:33, from include/drm/drmP.h:35, from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:29: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c: In function 'fill_rects_from_plane_state': drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:279:11: error: 'DRM_ROTATE_0' undeclared (first use in this function) case BIT(DRM_ROTATE_0): ^ include/linux/bitops.h:6:28: note: in definition of macro 'BIT' #define BIT(nr) (1UL << (nr)) ^~ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:279:11: note: each undeclared identifier is reported only once for each function it appears in case BIT(DRM_ROTATE_0): ^ include/linux/bitops.h:6:28: note: in definition of macro 'BIT' #define BIT(nr) (1UL << (nr)) ^~ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:282:11: error: 'DRM_ROTATE_90' undeclared (first use in this function) case BIT(DRM_ROTATE_90): ^ include/linux/bitops.h:6:28: note: in definition of macro 'BIT' #define BIT(nr) (1UL << (nr)) ^~ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:285:11: error: 'DRM_ROTATE_180' undeclared (first use in this function) case BIT(DRM_ROTATE_180): ^ include/linux/bitops.h:6:28: note: in definition of macro 'BIT' #define BIT(nr) (1UL << (nr)) ^~ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:288:11: error: 'DRM_ROTATE_270' undeclared (first use in this function) case BIT(DRM_ROTATE_270): ^ include/linux/bitops.h:6:28: note: in definition of macro 'BIT' #define BIT(nr) (1UL << (nr)) ^~ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c: At top level: >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:1031:18: error: 'drm_atomic_helper_crtc_set_property' undeclared here (not in a function) .set_property = drm_atomic_helper_crtc_set_property, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:1304:10: error: 'drm_atomic_helper_connector_dpms' undeclared here (not in a function) .dpms = drm_atomic_helper_connector_dpms, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:1308:18: error: 'drm_atomic_helper_connector_set_property' undeclared here (not in a function) .set_property = drm_atomic_helper_connector_set_property, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:1558:18: error: 'drm_atomic_helper_plane_set_property' undeclared here (not in a function) .set_property = drm_atomic_helper_plane_set_property, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c: In function 'amdgpu_dm_plane_init': >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:1721:5: error: incompatible type for argument 7 of 'drm_universal_plane_init' aplane->base.type, NULL); ^~~~~~ In file included from include/drm/drm_crtc.h:45:0, from include/drm/drmP.h:69, from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:29: include/drm/drm_plane.h:548:5: note: expected 'const uint64_t * {aka const long long unsigned int *}' but argument is of type 'enum drm_plane_type' int drm_universal_plane_init(struct drm_device *dev, ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/uapi/linux/posix_types.h:4:0, from include/uapi/linux/types.h:13, from include/linux/types.h:5, from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:26: include/linux/stddef.h:7:14: error: incompatible type for argument 8 of 'drm_universal_plane_init' #define NULL ((void *)0) ^ >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:1721:24: note: in expansion of macro 'NULL' aplane->base.type, NULL); ^~~~ In file included from include/drm/drm_crtc.h:45:0, from include/drm/drmP.h:69, from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:29: include/drm/drm_plane.h:548:5: note: expected 'enum drm_plane_type' but argument is of type 'void *' int drm_universal_plane_init(struct drm_device *dev, ^~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:1714:9: error: too few arguments to function 'drm_universal_plane_init' res = drm_universal_plane_init( ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/drm/drm_crtc.h:45:0, from include/drm/drmP.h:69, from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:29: include/drm/drm_plane.h:548:5: note: declared here int drm_universal_plane_init(struct drm_device *dev, ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:1731:5: error: incompatible type for argument 7 of 'drm_universal_plane_init' aplane->base.type, NULL); ^~~~~~ In file included from include/drm/drm_crtc.h:45:0, from include/drm/drmP.h:69, from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:29: include/drm/drm_plane.h:548:5: note: expected 'const uint64_t * {aka const long long unsigned int *}' but argument is of type 'enum drm_plane_type' int drm_universal_plane_init(struct drm_device *dev, ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/uapi/linux/posix_types.h:4:0, from include/uapi/linux/types.h:13, from include/linux/types.h:5, from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:26: include/linux/stddef.h:7:14: error: incompatible type for argument 8 of 'drm_universal_plane_init' #define NULL ((void *)0) ^ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:1731:24: note: in expansion of macro 'NULL' aplane->base.type, NULL); ^~~~ In file included from include/drm/drm_crtc.h:45:0, from include/drm/drmP.h:69, from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:29: include/drm/drm_plane.h:548:5: note: expected 'enum drm_plane_type' but argument is of type 'void *' int drm_universal_plane_init(struct drm_device *dev, ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:1724:9: error: too few arguments to function 'drm_universal_plane_init' res = drm_universal_plane_init( ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/drm/drm_crtc.h:45:0, from include/drm/drmP.h:69, from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:29: include/drm/drm_plane.h:548:5: note: declared here int drm_universal_plane_init(struct drm_device *dev, ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:1741:5: error: incompatible type for argument 7 of 'drm_universal_plane_init' aplane->base.type, NULL); ^~~~~~ In file included from include/drm/drm_crtc.h:45:0, from include/drm/drmP.h:69, from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:29: include/drm/drm_plane.h:548:5: note: expected 'const uint64_t * {aka const long long unsigned int *}' but argument is of type 'enum drm_plane_type' int drm_universal_plane_init(struct drm_device *dev, ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/uapi/linux/posix_types.h:4:0, from include/uapi/linux/types.h:13, from include/linux/types.h:5, from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:26: include/linux/stddef.h:7:14: error: incompatible type for argument 8 of 'drm_universal_plane_init' #define NULL ((void *)0) ^ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:1741:24: note: in expansion of macro 'NULL' aplane->base.type, NULL); ^~~~ In file included from include/drm/drm_crtc.h:45:0, from include/drm/drmP.h:69, from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:29: include/drm/drm_plane.h:548:5: note: expected 'enum drm_plane_type' but argument is of type 'void *' int drm_universal_plane_init(struct drm_device *dev, ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:1734:9: error: too few arguments to function 'drm_universal_plane_init' res = drm_universal_plane_init( ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/drm/drm_crtc.h:45:0, from include/drm/drmP.h:69, from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c:29: include/drm/drm_plane.h:548:5: note: declared here int drm_universal_plane_init(struct drm_device *dev, ^~~~~~~~~~~~~~~~~~~~~~~~ vim +/drm_atomic_helper_crtc_set_property +1031 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_types.c 80be23c5 Harry Wentland 2017-09-12 1024 80be23c5 Harry Wentland 2017-09-12 1025 /* Implemented only the options currently availible for the driver */ 80be23c5 Harry Wentland 2017-09-12 1026 static const struct drm_crtc_funcs amdgpu_dm_crtc_funcs = { 80be23c5 Harry Wentland 2017-09-12 1027 .reset = drm_atomic_helper_crtc_reset, 80be23c5 Harry Wentland 2017-09-12 1028 .destroy = amdgpu_dm_crtc_destroy, efc93186 Harry Wentland 2017-01-14 1029 .gamma_set = drm_atomic_helper_legacy_gamma_set, 80be23c5 Harry Wentland 2017-09-12 1030 .set_config = drm_atomic_helper_set_config, efc93186 Harry Wentland 2017-01-14 @1031 .set_property = drm_atomic_helper_crtc_set_property, 80be23c5 Harry Wentland 2017-09-12 1032 .page_flip = amdgpu_atomic_helper_page_flip, 80be23c5 Harry Wentland 2017-09-12 1033 .atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state, 80be23c5 Harry Wentland 2017-09-12 1034 .atomic_destroy_state = drm_atomic_helper_crtc_destroy_state, 80be23c5 Harry Wentland 2017-09-12 1035 }; 80be23c5 Harry Wentland 2017-09-12 1036 :::::: The code at line 1031 was first introduced by commit :::::: efc9318604422c771b1c14f7db2e748278b3ccc3 drm/amd/display: Use atomic helpers for gamma :::::: TO: Harry Wentland <harry.wentland(a)amd.com> :::::: CC: Alex Deucher <alexander.deucher(a)amd.com> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[PATCH] drivers:gpu:Use ARRAY_SIZE() for the size calculation of the array.
by Allen Pais 13 Sep '17

13 Sep '17

Signed-off-by: Allen Pais <allen.lkml(a)gmail.com> --- drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c index 4395a4f..0487936 100644 --- a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c +++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c @@ -274,7 +274,7 @@ static const struct pctl_data pctl0_data[] = { {0x135, 0x12a810}, {0x149, 0x7a82c} }; -#define PCTL0_DATA_LEN (sizeof(pctl0_data)/sizeof(pctl0_data[0])) +#define PCTL0_DATA_LEN (ARRAY_SIZE(pctl0_data)) #define PCTL0_RENG_EXEC_END_PTR 0x151 #define PCTL0_STCTRL_REG_SAVE_RANGE0_BASE 0xa640 @@ -310,7 +310,7 @@ static const struct pctl_data pctl1_data[] = { {0x1f0, 0x5000a7f6}, {0x1f1, 0x5000a7e4} }; -#define PCTL1_DATA_LEN (sizeof(pctl1_data)/sizeof(pctl1_data[0])) +#define PCTL1_DATA_LEN (ARRAY_SIZE(pctl1_data)) #define PCTL1_RENG_EXEC_END_PTR 0x1f1 #define PCTL1_STCTRL_REG_SAVE_RANGE0_BASE 0xa000 -- 2.7.4

2 1

[Bug 102655] [CI][HSW] igt@gem_flink_race@flink_close - Failed assertion: obj_count == 0
by bugzilla-daemon＠freedesktop.org 13 Sep '17

13 Sep '17

https://bugs.freedesktop.org/show_bug.cgi?id=102655 Chris Wilson <chris(a)chris-wilson.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marta.lofstedt(a)intel.com --- Comment #3 from Chris Wilson <chris(a)chris-wilson.co.uk> --- *** Bug 102696 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH] drm/radeon: Fix guard on radeon trace header
by Chuck Ebbert 13 Sep '17

13 Sep '17

It's been that way for years... --- a/drivers/gpu/drm/radeon/radeon_trace.h +++ b/drivers/gpu/drm/radeon/radeon_trace.h @@ -1,5 +1,5 @@ #if !defined(_RADEON_TRACE_H) || defined(TRACE_HEADER_MULTI_READ) -#define _RADEON_TRACE_H_ +#define _RADEON_TRACE_H #include <linux/stringify.h> #include <linux/types.h>

1 0

[PATCH 00/23] drm/etnaviv: support performance counters
by Christian Gmeiner 13 Sep '17

13 Sep '17

In a perfect world we would be able to read GPU registers of interest via the command stream with a 'read-register' command/package. For perf counters it is a must to read them synchronized with the GPU to put the values in relation to a draw command. As Vivante GPUs do not provide this functionality we need to emulate it in software. We need to support three different kind of perf register types: 1) normal register This is the easierst case where we can simply read the register and we are done. 2) debug register We need to configure the mux register and then read the debug register value. 3) pipeline register We need to 'iterate' over all pixel pipes and sum up the values. The 'iteration' is done by select the pipe of interest via HI_CLOCK_CONTROL_DEBUG_PIXEL_PIPE. There is also need to configure the mux register. Allowing the userspace to do it all by its own feels quite error prone and not future-proof. Thats why the kernel exports all performance domains and their signals to the userspace via two new ioctls. So the kernel knows all performance counters and how to sample them. At the moment all performacne domains and signals get exported to all gpu pipe types, but that can be changed in follow-up patches. struct drm_etnaviv_gem_submit was extended to include so-called performance monitor requests (pmrs). A request defines what domain and signal should be sampled (pre/post draw cmdbuffer) and where to store the result. The whole series can be found here: https://github.com/austriancoder/linux/tree/perfmon-v4 The used libdrm and mesa branches to test this feature can be found here: https://github.com/austriancoder/libdrm/commits/perfmon-v4 https://github.com/austriancoder/mesa/commits/perfmon-v4 GALLIUM_HUD=help will report following queries names: fps cpu cpu0 cpu1 cpu2 cpu3 prims-emitted draw-calls rs-operations hi-total-cyles hi-idle-cyles hi-axi-cycles-read-request-stalled hi-axi-cycles-write-request-stalled hi-axi-cycles-write-data-stalled pe-pixel-count-killed-by-color-pipe pe-pixel-count-killed-by-depth-pipe pe-pixel-count-drawn-by-color-pipe pe-pixel-count-drawn-by-depth-pipe pe-pixels-rendered-2d sh-shader-cycles sh-ps-inst-counter sh-rendered-pixel-counter sh-vs-inst-counter sh-rendered-vertice-counter sh-vtx-branch-inst-counter sh-vtx-texld-inst-counter sh-plx-branch-inst-counter sh-plx-texld-inst-counter pa-input-vtx-counter pa-input-prim-counter pa-putput-prim-counter pa-depth-clipped-counter pa-trivial-rejected-counter pa-culled-counter se-culled-triangle-count se-culled-lines-count ra-valid-pixel-count ra-total-quad-count ra-valid-quad-count-after-early-z ra-total-primitive-count ra-pipe-cache-miss-counter ra-prefetch-cache-miss-counter ra-pculled-quad-count tx-total-bilinear-requests tx-total-trilinear-requests tx-total-discarded-texutre-requests tx-total-texutre-requests tx-mem-read-count tx-mem-read-in-8b-count tx-cache-miss-count tx-cache-hit-texel-count tx-cache-miss-texel-count mc-total-read-req-8b-from-pipeline mc-total-read-req-8b-from-ip mc-total-write-req-8b-from-pipeline Changes v1 -> v2: - reworked events - reworked uapi - reworked enumeration of domains and signals - process sync point with a work item to keep irq as fast as possible - prevent GPU hang when reading pixel pipeline perf values - all SH perf counters are accessed via perf_reg_read(..) Changes v2 -> v3: - reworked alloc_event(..) - fixed pmr flag validation Changes v3 -> v4: - cherry picked the correct commits (patches 03 and 04) Happy reviewing! Christian Gmeiner (23): drm/etnaviv: use bitmap to keep track of events drm/etnaviv: make it possible to allocate multiple events drm/etnaviv: add infrastructure to query perf counter drm/etnaviv: add uapi for perfmon feature drm/etnaviv: add internal representation of perfmon_request drm/etnaviv: extend etnaviv_gpu_cmdbuf_new(..) with nr_pmrs drm/etnaviv: add performance monitor request validation drm/etnaviv: copy pmrs from userspace drm/etnaviv: add performance monitor request processing drm/etnaviv: add 'sync point' support drm/etnaviv: clear alloced event drm/etnaviv: use 'sync points' for performance monitor requests drm/etnaviv: add HI perf domain drm/etnaviv: add PE perf domain drm/etnaviv: add SH perf domain drm/etnaviv: add PA perf domain drm/etnaviv: add SE perf domain drm/etnaviv: add RA perf domain drm/etnaviv: add TX perf domain drm/etnaviv: add MC perf domain drm/etnaviv: need to disable clock gating when doing profiling drm/etnaviv: enable debug registers on demand drm/etnaviv: submit supports performance monitor requests drivers/gpu/drm/etnaviv/Makefile | 3 +- drivers/gpu/drm/etnaviv/etnaviv_buffer.c | 36 +++ drivers/gpu/drm/etnaviv/etnaviv_cmdbuf.c | 15 +- drivers/gpu/drm/etnaviv/etnaviv_cmdbuf.h | 6 +- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 39 ++- drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1 + drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 69 +++- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 216 ++++++++++--- drivers/gpu/drm/etnaviv/etnaviv_gpu.h | 13 +- drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 451 +++++++++++++++++++++++++++ drivers/gpu/drm/etnaviv/etnaviv_perfmon.h | 48 +++ include/uapi/drm/etnaviv_drm.h | 43 ++- 12 files changed, 883 insertions(+), 57 deletions(-) create mode 100644 drivers/gpu/drm/etnaviv/etnaviv_perfmon.c create mode 100644 drivers/gpu/drm/etnaviv/etnaviv_perfmon.h -- 2.13.5

2 29

[PATCH 1/2] drm/dp/mst: Sideband message transaction to power up/down nodes
by Dhinakaran Pandiyan 13 Sep '17

13 Sep '17

The POWER_DOWN_PHY and POWER_UP_PHY sideband message transactions allow the source to reqest any node in a mst path or a whole path to be powered down or up. This allows drivers to target a specific sink in the MST topology, an improvement over just power managing the imediate downstream device. Secondly, since the request-reply protocol waits for an ACK, we can be sure that a downstream sink has enough time to respond to a power up/down request. Cc: Lyude <lyude(a)redhat.com> Cc: Ville Syrjälä <ville.syrjala(a)linux.intel.com> Cc: Harry Wentland <harry.wentland(a)amd.com> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan(a)intel.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 73 +++++++++++++++++++++++++++++++++++ include/drm/drm_dp_mst_helper.h | 2 + 2 files changed, 75 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 41b492f99955..a9f12708a046 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_dp_mst_topology.c @@ -294,6 +294,12 @@ static void drm_dp_encode_sideband_req(struct drm_dp_sideband_msg_req_body *req, memcpy(&buf[idx], req->u.i2c_write.bytes, req->u.i2c_write.num_bytes); idx += req->u.i2c_write.num_bytes; break; + + case DP_POWER_DOWN_PHY: + case DP_POWER_UP_PHY: + buf[idx] = (req->u.port_num.port_number & 0xf) << 4; + idx++; + break; } raw->cur_len = idx; } @@ -538,6 +544,22 @@ static bool drm_dp_sideband_parse_query_payload_ack(struct drm_dp_sideband_msg_r return false; } + +static bool drm_dp_sideband_parse_power_updown_phy_ack(struct drm_dp_sideband_msg_rx *raw, + struct drm_dp_sideband_msg_reply_body *repmsg) +{ + int idx = 1; + + repmsg->u.port_number.port_number = (raw->msg[idx] >> 4) & 0xf; + idx++; + if (idx > raw->curlen) { + DRM_DEBUG_KMS("power up/down phy parse length fail %d %d\n", + idx, raw->curlen); + return false; + } + return true; +} + static bool drm_dp_sideband_parse_reply(struct drm_dp_sideband_msg_rx *raw, struct drm_dp_sideband_msg_reply_body *msg) { @@ -567,6 +589,9 @@ static bool drm_dp_sideband_parse_reply(struct drm_dp_sideband_msg_rx *raw, return drm_dp_sideband_parse_enum_path_resources_ack(raw, msg); case DP_ALLOCATE_PAYLOAD: return drm_dp_sideband_parse_allocate_payload_ack(raw, msg); + case DP_POWER_DOWN_PHY: + case DP_POWER_UP_PHY: + return drm_dp_sideband_parse_power_updown_phy_ack(raw, msg); default: DRM_ERROR("Got unknown reply 0x%02x\n", msg->req_type); return false; @@ -693,6 +718,22 @@ static int build_allocate_payload(struct drm_dp_sideband_msg_tx *msg, int port_n return 0; } +static int build_power_updown_phy(struct drm_dp_sideband_msg_tx *msg, + int port_num, bool power_up) +{ + struct drm_dp_sideband_msg_req_body req; + + if (power_up) + req.req_type = DP_POWER_UP_PHY; + else + req.req_type = DP_POWER_DOWN_PHY; + + req.u.port_num.port_number = port_num; + drm_dp_encode_sideband_req(&req, msg); + msg->path_msg = true; + return 0; +} + static int drm_dp_mst_assign_payload_id(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_vcpi *vcpi) { @@ -1724,6 +1765,38 @@ static int drm_dp_payload_send_msg(struct drm_dp_mst_topology_mgr *mgr, return ret; } +int drm_dp_send_power_updown_phy(struct drm_dp_mst_topology_mgr *mgr, + struct drm_dp_mst_port *port, bool power_up) +{ + struct drm_dp_sideband_msg_tx *txmsg; + int len, ret; + + txmsg = kzalloc(sizeof(*txmsg), GFP_KERNEL); + if (!txmsg) + return -ENOMEM; + + port = drm_dp_get_validated_port_ref(mgr, port); + if (!port) + return -EINVAL; + + txmsg->dst = port->parent; + len = build_power_updown_phy(txmsg, port->port_num, power_up); + drm_dp_queue_down_tx(mgr, txmsg); + + ret = drm_dp_mst_wait_tx_reply(port->parent, txmsg); + if (ret > 0) { + if (txmsg->reply.reply_type == 1) + ret = -EINVAL; + else + ret = 0; + } + kfree(txmsg); + drm_dp_put_port(port); + + return 0; +} +EXPORT_SYMBOL(drm_dp_send_power_updown_phy); + static int drm_dp_create_payload_step1(struct drm_dp_mst_topology_mgr *mgr, int id, struct drm_dp_payload *payload) diff --git a/include/drm/drm_dp_mst_helper.h b/include/drm/drm_dp_mst_helper.h index d55abb75f29a..7f78d26a0766 100644 --- a/include/drm/drm_dp_mst_helper.h +++ b/include/drm/drm_dp_mst_helper.h @@ -631,5 +631,7 @@ int drm_dp_atomic_find_vcpi_slots(struct drm_atomic_state *state, int drm_dp_atomic_release_vcpi_slots(struct drm_atomic_state *state, struct drm_dp_mst_topology_mgr *mgr, int slots); +int drm_dp_send_power_updown_phy(struct drm_dp_mst_topology_mgr *mgr, + struct drm_dp_mst_port *port, bool power_up); #endif -- 2.11.0

6 20

[PATCH 1/2] etnaviv: fix submit error path
by Lucas Stach 13 Sep '17

13 Sep '17

If the gpu submit fails, bail out to avoid accessing a potentially unititalized fence. CC: stable(a)vger.kernel.org #4.12+ Signed-off-by: Lucas Stach <l.stach(a)pengutronix.de> --- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c index 6463fc2c736f..b95362186f9c 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c @@ -445,8 +445,10 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data, cmdbuf->user_size = ALIGN(args->stream_size, 8); ret = etnaviv_gpu_submit(gpu, submit, cmdbuf); - if (ret == 0) - cmdbuf = NULL; + if (ret) + goto out; + + cmdbuf = NULL; if (args->flags & ETNA_SUBMIT_FENCE_FD_OUT) { /* -- 2.11.0

1 1

[PATCHv3 0/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support
by Hans Verkuil 13 Sep '17

13 Sep '17

From: Hans Verkuil <hans.verkuil(a)cisco.com> This patch series adds support for the DisplayPort CEC-Tunneling-over-AUX feature. This patch series is based on the current pre-4.14-rc1 mainline which has all the needed cec 4.14 patches merged. This patch series has been tested with my NUC7i5BNK and a Samsung USB-C to HDMI adapter. Please note this comment at the start of drm_dp_cec.c: ---------------------------------------------------------------------- Unfortunately it turns out that we have a chicken-and-egg situation here. Quite a few active (mini-)DP-to-HDMI or USB-C-to-HDMI adapters have a converter chip that supports CEC-Tunneling-over-AUX (usually the Parade PS176), but they do not wire up the CEC pin, thus making CEC useless. Sadly there is no way for this driver to know this. What happens is that a /dev/cecX device is created that is isolated and unable to see any of the other CEC devices. Quite literally the CEC wire is cut (or in this case, never connected in the first place). I suspect that the reason so few adapters support this is that this tunneling protocol was never supported by any OS. So there was no easy way of testing it, and no incentive to correctly wire up the CEC pin. Hopefully by creating this driver it will be easier for vendors to finally fix their adapters and test the CEC functionality. I keep a list of known working adapters here: https://hverkuil.home.xs4all.nl/cec-status.txt Please mail me (hverkuil(a)xs4all.nl) if you find an adapter that works and is not yet listed there. ---------------------------------------------------------------------- I really hope that this work will provide an incentive for vendors to finally connect the CEC pin. It's a shame that there are so few adapters that work (I found only two USB-C to HDMI adapters that work, and no (mini-)DP to HDMI adapters at all). Note that a colleague who actually knows his way around a soldering iron modified an UpTab DisplayPort-to-HDMI adapter for me, hooking up the CEC pin. And after that change it worked. I also received confirmation that this really is a chicken-and-egg situation: it is because there is no CEC support for this feature in any OS that they do not hook up the CEC pin. So hopefully if this gets merged there will be an incentive for vendors to make adapters where this actually works. It is a very nice feature for HTPC boxes. I've added Imre and Ville. It would be great if this can go in for 4.15. Changes since v2: - Use the new CEC_CAP_DEFAULTS define - Replace 'if (!IS_ERR_OR_NULL(aux->cec_adap)) {' in drm_dp_cec_configure_adapter() by just 'if (aux->cec_adap) {'. Changes since v1: - Incorporated Sean's review comments in patch 1/3. Regards, Hans Hans Verkuil (3): drm: add support for DisplayPort CEC-Tunneling-over-AUX drm-kms-helpers.rst: document the DP CEC helpers drm/i915: add DisplayPort CEC-Tunneling-over-AUX support Documentation/gpu/drm-kms-helpers.rst | 9 + drivers/gpu/drm/Kconfig | 10 ++ drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_dp_cec.c | 301 ++++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_dp.c | 18 +- include/drm/drm_dp_helper.h | 24 +++ 6 files changed, 359 insertions(+), 4 deletions(-) create mode 100644 drivers/gpu/drm/drm_dp_cec.c -- 2.14.1

2 6

[PATCH] drm/ttm: fix memory leak while individualizing BOs
by Christian König 13 Sep '17

13 Sep '17

From: Christian König <christian.koenig(a)amd.com> We need to free the reservation object before we take the BO from the delayed delete list. Signed-off-by: Christian König <christian.koenig(a)amd.com> --- drivers/gpu/drm/ttm/ttm_bo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index bee77d3..d79607a 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -557,6 +557,8 @@ static int ttm_bo_cleanup_refs_and_unlock(struct ttm_buffer_object *bo, } ttm_bo_del_from_lru(bo); + if (!list_empty(&bo->ddestroy) && (bo->resv != &bo->ttm_resv)) + reservation_object_fini(&bo->ttm_resv); list_del_init(&bo->ddestroy); kref_put(&bo->list_kref, ttm_bo_ref_bug); -- 2.7.4

2 1

[PATCH v3 0/6] Exynos-gsc: Support the hardware rotation limits
by Hoegeun Kwon 13 Sep '17

13 Sep '17

Hello all, The gscaler has hardware rotation limits. So this patch set support the rotate hardware limits of gsc. To avoid problems with bisectability, patches 1~4 must be merged and then merged 5 and 6. Changes for V3: - Fixed of_match_node() to of_device_get_match_data() in drm gsc driver. - Added hardware rotation limits for gsc driver of v4l2. - Added the remove unnecessary compatible for DT document and Exynos dts. Changes for V2: - Added the interface info in binding document. - Added clean name of compatible in Exynos dts. - Added maximum supported picture size hardcoded into driver. Best regards, Hoegeun Hoegeun Kwon (6): [media] exynos-gsc: Add compatible for Exynos 5250 and 5420 specific version ARM: dts: exynos: Add clean name of compatible. drm/exynos/gsc: Add hardware rotation limits [media] exynos-gsc: Add hardware rotation limits [media] exynos-gsc: Remove unnecessary compatible ARM: dts: exynos: Remove unnecessary compatible .../devicetree/bindings/media/exynos5-gsc.txt | 7 +- arch/arm/boot/dts/exynos5250.dtsi | 8 +- arch/arm/boot/dts/exynos5420.dtsi | 4 +- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 93 ++++++++++++++------- drivers/media/platform/exynos-gsc/gsc-core.c | 96 +++++++++++++++++++--- include/uapi/drm/exynos_drm.h | 2 + 6 files changed, 159 insertions(+), 51 deletions(-) -- 1.9.1

4 13

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2017