dri-devel January 2018

dri-devel@lists.freedesktop.org

226 participants
1677 discussions

[PATCH v2 00/12] drm/sun4i: Add A83T HDMI support
by Jernej Skrabec 15 Jan '18

15 Jan '18

This patch series implements support for A83T DW HDMI and PHY. Contrary to v1 series, this one is based on latest linux-next, since all needed patches were merged. While exactly this combination of HDMI controller and PHY is not common in Allwinner SoCs, this patch series nevertheless makes groundwork for other SoCs, which have same DW HDMI IP block, but different PHYs, like H3 and H5. Please take a look. Best regards, Jernej Changes from v1: - Collected ACKs - Separated bindings for controller and PHY - Split driver into two parts - controller and PHY - HDMI PHY driver now uses regmap for writes - added defines for PHY registers and bits - updated DT entries to accomodate new bindings - removed already merged clock patch - reworked first clock patch according to comments - added new clock patch which changes NKMP formula - split TCON patch in two, one for quirk and one for new compatible - reworked patch which exports DW HDMI PHY functions: - remove "gen2" from some function names - removed parameter from dw_hdmi_phy_reset() - added address parameter to dw_hdmi_phy_i2c_set_addr() - updated most of commit messages Jernej Skrabec (12): clk: sunxi-ng: Mask nkmp factors when setting register clk: sunxi-ng: Change formula for NKMP PLLs drm/bridge/synopsys: dw-hdmi: Enable workaround for v1.32a drm/bridge/synopsys: dw-hdmi: Export some PHY related functions drm/bridge/synopsys: dw-hdmi: Add deinit callback dt-bindings: display: sun4i-drm: Add A83T HDMI pipeline drm/sun4i: Add has_channel_0 TCON quirk drm/sun4i: Add support for A83T second TCON drm/sun4i: Add support for A83T second DE2 mixer drm/sun4i: Implement A83T HDMI driver ARM: dts: sun8i: a83t: Add HDMI display pipeline ARM: dts: sun8i: a83t: Enable HDMI on BananaPi M3 .../bindings/display/sunxi/sun4i-drm.txt | 197 +++++++++++++- arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts | 25 ++ arch/arm/boot/dts/sun8i-a83t.dtsi | 119 +++++++- drivers/clk/sunxi-ng/ccu_nkmp.c | 27 +- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 55 ++-- drivers/gpu/drm/sun4i/Kconfig | 9 + drivers/gpu/drm/sun4i/Makefile | 4 + drivers/gpu/drm/sun4i/sun4i_tcon.c | 46 +++- drivers/gpu/drm/sun4i/sun4i_tcon.h | 1 + drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 183 +++++++++++++ drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h | 51 ++++ drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c | 302 +++++++++++++++++++++ drivers/gpu/drm/sun4i/sun8i_mixer.c | 11 + include/drm/bridge/dw_hdmi.h | 12 + 14 files changed, 993 insertions(+), 49 deletions(-) create mode 100644 drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c create mode 100644 drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h create mode 100644 drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c -- 2.15.1

6 18

[PATCH v3 0/7] drm/tinydrm: Cleanup
by Noralf Trønnes 15 Jan '18

15 Jan '18

Fix a few things that came up during the tinydrm review but wasn't addressed at the time. Noralf. Changes since version 2: - s/mipi_dbi_por_conditional/mipi_dbi_poweron_reset_conditional/ - Add sleep after soft reset to comply with spec. - Remove reset msleep from mi0283qt following the previous change. - Use (ret == 1) to test for display is ON, no reset. - Add patch to change hard reset active time. Changes since version 1: - Add mipi_dbi_enable_flush() instead of the pipe enable helper mipi_dbi_pipe_enable() that doesn't really fit anymore. - Add common poweron-reset functionality. - Use drm_mode_copy() instead of direct assignment Noralf Trønnes (7): drm/tinydrm/mi0283qt: Use common include order drm/tinydrm/mi0283qt: Remove ili9341.h drm/tinydrm/mipi-dbi: Add mipi_dbi_enable_flush() drm/tinydrm/mipi-dbi: Add poweron-reset functions drm/tinydrm/mi0283qt: Let the display pipe handle power drm/tinydrm: Embed the mode in tinydrm_connector drm/tinydrm/mipi-dbi: Change reset active time drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 34 ++++----- drivers/gpu/drm/tinydrm/ili9225.c | 6 +- drivers/gpu/drm/tinydrm/mi0283qt.c | 106 ++++++++++++---------------- drivers/gpu/drm/tinydrm/mipi-dbi.c | 101 ++++++++++++++++++++++---- drivers/gpu/drm/tinydrm/st7586.c | 15 ++-- drivers/gpu/drm/tinydrm/st7735r.c | 10 +-- include/drm/tinydrm/ili9341.h | 54 -------------- include/drm/tinydrm/mipi-dbi.h | 5 +- 8 files changed, 154 insertions(+), 177 deletions(-) delete mode 100644 include/drm/tinydrm/ili9341.h -- 2.15.1

2 11

[PATCH] fix drm-get-put.cocci warnings
by Julia Lawall 15 Jan '18

15 Jan '18

From: Fengguang Wu <fengguang.wu(a)intel.com> Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and drm_*_unreference() helpers. Generated by: scripts/coccinelle/api/drm-get-put.cocci Signed-off-by: Fengguang Wu <fengguang.wu(a)intel.com> Signed-off-by: Julia Lawall <julia.lawall(a)lip6.fr> --- tree: https://github.com/thierryreding/linux for-4.16/work head: 6c86494bb2f670293f6137b0a4b3c53c8886eba4 commit: 34f022b2d11f91a323d3e7d15893d480646f3fad [149/161] WIP nouveau_gem.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) --- a/drivers/gpu/drm/nouveau/nouveau_gem.c +++ b/drivers/gpu/drm/nouveau/nouveau_gem.c @@ -296,7 +296,7 @@ nouveau_gem_ioctl_new(struct drm_device } /* drop reference from allocate - handle holds it now */ - drm_gem_object_unreference_unlocked(&nvbo->gem); + drm_gem_object_put_unlocked(&nvbo->gem); return ret; } @@ -365,7 +365,7 @@ validate_fini_no_ticket(struct validate_ list_del(&nvbo->entry); nvbo->reserved_by = NULL; ttm_bo_unreserve(&nvbo->bo); - drm_gem_object_unreference_unlocked(&nvbo->gem); + drm_gem_object_put_unlocked(&nvbo->gem); } } @@ -411,14 +411,14 @@ retry: nvbo = nouveau_gem_object(gem); if (nvbo == res_bo) { res_bo = NULL; - drm_gem_object_unreference_unlocked(gem); + drm_gem_object_put_unlocked(gem); continue; } if (nvbo->reserved_by && nvbo->reserved_by == file_priv) { NV_PRINTK(err, cli, "multiple instances of buffer %d on " "validation list\n", b->handle); - drm_gem_object_unreference_unlocked(gem); + drm_gem_object_put_unlocked(gem); ret = -EINVAL; break; } @@ -969,7 +969,7 @@ nouveau_gem_ioctl_cpu_prep(struct drm_de ret = lret; nouveau_bo_sync_for_cpu(nvbo); - drm_gem_object_unreference_unlocked(gem); + drm_gem_object_put_unlocked(gem); return ret; } @@ -988,7 +988,7 @@ nouveau_gem_ioctl_cpu_fini(struct drm_de nvbo = nouveau_gem_object(gem); nouveau_bo_sync_for_device(nvbo); - drm_gem_object_unreference_unlocked(gem); + drm_gem_object_put_unlocked(gem); return 0; } @@ -1005,7 +1005,7 @@ nouveau_gem_ioctl_info(struct drm_device return -ENOENT; ret = nouveau_gem_info(file_priv, gem, req); - drm_gem_object_unreference_unlocked(gem); + drm_gem_object_put_unlocked(gem); return ret; } @@ -1153,7 +1153,7 @@ out: return err; unref: - drm_gem_object_unreference(&nvbo->gem); + drm_gem_object_put(&nvbo->gem); unref_bo: nouveau_bo_ref(NULL, &nvbo); free_sgt:

2 2

[PATCH 0/3] drm/tegra: Add support for fence FDs
by Thierry Reding 15 Jan '18

15 Jan '18

From: Thierry Reding <treding(a)nvidia.com> This set of patches adds support for fences to Tegra DRM and complements the fence FD support for Nouveau. Technically this isn't necessary for a fence-based synchronization loop with Nouveau because the KMS core takes care of all that, but engines behind host1x can use the IOCTL extensions provided here to emit fence FDs that in turn can be used to synchronize their jobs with either the scanout engine or the GPU. See the following link for the Nouveau fence FD support series: https://patchwork.freedesktop.org/series/36361/ Thierry Mikko Perttunen (3): gpu: host1x: Add support for DMA fences drm/tegra: Add sync file support to submit interface drm/tegra: Support for sync file-based fences in submit drivers/gpu/drm/tegra/drm.c | 82 ++++++++++++--- drivers/gpu/host1x/Kconfig | 1 + drivers/gpu/host1x/Makefile | 1 + drivers/gpu/host1x/dev.h | 12 ++- drivers/gpu/host1x/fence.c | 202 +++++++++++++++++++++++++++++++++++++ drivers/gpu/host1x/fence.h | 28 +++++ drivers/gpu/host1x/hw/channel_hw.c | 36 +++++-- drivers/gpu/host1x/intr.c | 11 +- drivers/gpu/host1x/intr.h | 8 +- drivers/gpu/host1x/syncpt.c | 2 + include/linux/host1x.h | 12 ++- include/uapi/drm/tegra_drm.h | 10 +- 12 files changed, 376 insertions(+), 29 deletions(-) create mode 100644 drivers/gpu/host1x/fence.c create mode 100644 drivers/gpu/host1x/fence.h -- 2.15.1

3 9

[git pull] amdkfd fixes for 4.16
by Oded Gabbay 15 Jan '18

15 Jan '18

Hi Dave, a couple of minor fixes for 4.16: - fix NULL pointer dereference - fix compiler warning on large define values - remove unnecessary call to execute_queues_cpsch Thanks, Oded The following changes since commit 9be712ef4612268c28b9f1e2d850d3ceab06ef66: Merge tag 'drm/tegra/for-4.16-rc1-fixes' of git://anongit.freedesktop.org/tegra/linux into drm-next (2018-01-12 11:46:19 +1000) are available in the Git repository at: git://people.freedesktop.org/~gabbayo/linux tags/drm-amdkfd-next-fixes-2018-01-15 for you to fetch changes up to 2e3dca53654ddc51bada4cee4ca32d0d266fc9dd: drm/amdkfd: Fix potential NULL pointer dereferences (2018-01-10 17:15:09 -0600) ---------------------------------------------------------------- Gustavo A. R. Silva (1): drm/amdkfd: Fix potential NULL pointer dereferences Oded Gabbay (1): drm/amdkfd: add ull suffix to 64bit defines Yong Zhao (2): drm/amdkfd: Fix return value 0 when execute_queues_cpsch fails drm/amdkfd: don't always call execute_queues_cpsch() drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 12 ++++++------ drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 6 +++--- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 8 +++++++- 3 files changed, 16 insertions(+), 10 deletions(-)

1 0

[Bug 99321] Videoplaying applications hangs on latest r600
by bugzilla-daemon＠freedesktop.org 15 Jan '18

15 Jan '18

https://bugs.freedesktop.org/show_bug.cgi?id=99321 Bug ID: 99321 Summary: Videoplaying applications hangs on latest r600 Product: Mesa Version: 13.0 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 Assignee: dri-devel(a)lists.freedesktop.org Reporter: krnlbg(a)gmail.com QA Contact: dri-devel(a)lists.freedesktop.org Hello. After updating to Fedora 25 applications that play videos started to hang periodically. Firefox, Chrome, Steam and mpv are affected when play video. Also I found that this can happen in 2d native games like Crimsonland. 3D games works just fine. I can't find any logs related to this problem and the only manifestation of this is that the process goes into "futex_wait_queue_me" status and can only be killed. One thing I noticed: starting mpv with --vo=x11 solves the problem. (default is --vo=opengl). It is 100% reproducible for me. I think the problem is driver related because I tried putting my ssd into another pc with Intel graphics and everything was working just fine. More info in redhat bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1401479 I don't know how to get more information but i'm willing to try if somebody suggests me. My Hardware: AMD Phenom(tm) II X4 975 Processor AMD Radeon 6850 GPU with r600g driver -- You are receiving this mail because: You are the assignee for the bug.

1 3

[PATCH] dma-buf/sw_sync: fix document of sw_sync_create_fence_data
by Shawn Guo 15 Jan '18

15 Jan '18

The structure should really be sw_sync_create_fence_data rather than sw_sync_ioctl_create_fence which is the function name. Signed-off-by: Shawn Guo <shawn.guo(a)linaro.org> --- drivers/dma-buf/sw_sync.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma-buf/sw_sync.c b/drivers/dma-buf/sw_sync.c index 24f83f9eeaed..7779bdbd18d1 100644 --- a/drivers/dma-buf/sw_sync.c +++ b/drivers/dma-buf/sw_sync.c @@ -43,14 +43,14 @@ * timelines. * * Fences can be created with SW_SYNC_IOC_CREATE_FENCE ioctl with struct - * sw_sync_ioctl_create_fence as parameter. + * sw_sync_create_fence_data as parameter. * * To increment the timeline counter, SW_SYNC_IOC_INC ioctl should be used * with the increment as u32. This will update the last signaled value * from the timeline and signal any fence that has a seqno smaller or equal * to it. * - * struct sw_sync_ioctl_create_fence + * struct sw_sync_create_fence_data * @value: the seqno to initialise the fence with * @name: the name of the new sync point * @fence: return the fd of the new sync_file with the created fence -- 1.9.1

2 1

[Bug 104631] Requesting a New Account for libdrm
by bugzilla-daemon＠freedesktop.org 15 Jan '18

15 Jan '18

https://bugs.freedesktop.org/show_bug.cgi?id=104631 Bug ID: 104631 Summary: Requesting a New Account for libdrm Product: DRI Version: XOrg git Hardware: Other OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: libdrm Assignee: dri-devel(a)lists.freedesktop.org Reporter: david1.zhou(a)amd.com Created attachment 136720 --> https://bugs.freedesktop.org/attachment.cgi?id=136720&action=edit GPG and SSH public key Hi, I'm David from AMD and I'd like to apply for a freedesktop account for my contributions to libdrm. my real name: Chunming Zhou my email address: david1.zhou(a)amd.com my preferred account name: Chunming-Zhou my SSH public key and GPG public key are attached. Please tell me if you need additional info or if you have questions. Thank you, David Zhou -- You are receiving this mail because: You are the assignee for the bug.

1 1

[PATCH] drm/panel: lvds: Handle the optional regulator case properly
by Maxime Ripard 15 Jan '18

15 Jan '18

The devm_regulator_get_optional function, unlike it was assumed in the commit a1c55bccf600 ("drm/panel: lvds: Add support for the power-supply property"), is actually returning an error pointer with -ENODEV instead of NULL when there's no regulator to find. Make sure we handle that case properly. Fixes: a1c55bccf600 ("drm/panel: lvds: Add support for the power-supply property") Signed-off-by: Maxime Ripard <maxime.ripard(a)free-electrons.com> --- drivers/gpu/drm/panel/panel-lvds.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c index 57e38a9e7ab4..9f46e7095c0e 100644 --- a/drivers/gpu/drm/panel/panel-lvds.c +++ b/drivers/gpu/drm/panel/panel-lvds.c @@ -215,8 +215,13 @@ static int panel_lvds_probe(struct platform_device *pdev) lvds->supply = devm_regulator_get_optional(lvds->dev, "power"); if (IS_ERR(lvds->supply)) { ret = PTR_ERR(lvds->supply); - dev_err(lvds->dev, "failed to request regulator: %d\n", ret); - return ret; + + if (ret != -ENODEV) { + dev_err(lvds->dev, "failed to request regulator: %d\n", ret); + return ret; + } else { + lvds->supply = NULL; + } } /* Get GPIOs and backlight controller. */ -- 2.14.3

3 7

[PATCH] drm/sun4i: Fix error code in sun4i_tcon_bind()
by Dan Carpenter 15 Jan '18

15 Jan '18

We accidentally passed the wrong variable to PTR_ERR(). Fixes: a0c1214e4764 ("drm/sun4i: Add LVDS support") Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c index b78fed809992..3c15cf24b503 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c @@ -902,7 +902,7 @@ static int sun4i_tcon_bind(struct device *dev, struct device *master, has_lvds_alt = false; } else { dev_err(dev, "Couldn't get the LVDS PLL\n"); - return PTR_ERR(tcon->lvds_rst); + return PTR_ERR(tcon->lvds_pll); } } else { has_lvds_alt = true;

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2018