dri-devel January 2018

dri-devel@lists.freedesktop.org

226 participants
1677 discussions

[Bug 104295] Launching counter strike global offensive fails after update from 17.2 to 17.3
by bugzilla-daemon＠freedesktop.org 02 Jan '18

02 Jan '18

https://bugs.freedesktop.org/show_bug.cgi?id=104295 Bug ID: 104295 Summary: Launching counter strike global offensive fails after update from 17.2 to 17.3 Product: Mesa Version: 17.3 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel(a)lists.freedesktop.org Reporter: kaspar.tint(a)gmail.com QA Contact: dri-devel(a)lists.freedesktop.org Created attachment 136230 --> https://bugs.freedesktop.org/attachment.cgi?id=136230&action=edit CS:GO coredump As mentioned in the summary, CS:GO does not launch anymore after mesa update. I have attached a core dump with this bug report. I could notice that most of it was referring to radeonsi so that's why I turned here. If I am wrong and you have nothing to do here then close this ticket. This issue appears every time when I open CS:GO. The game window is created after launch, it's black for ~2 seconds and then quits. -- You are receiving this mail because: You are the assignee for the bug.

1 8

[GIT PULL] omapdrm fix for 4.15
by Tomi Valkeinen 02 Jan '18

02 Jan '18

Hi Dave, Please pull an omapdrm fix for 4.15, if it's not too late. Tomi The following changes since commit 03bfd4e19b935adb8be4f7342f13395fb7f11096: Merge tag 'drm-intel-fixes-2017-12-22-1' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes (2017-12-28 05:20:07 +1000) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git tags/omapdrm-4.15-fixes for you to fetch changes up to df29c9db8ace4497a61f3b3d33c2b8a7fd4b7b8e: omapdrm/dss/hdmi4_cec: fix interrupt handling (2018-01-02 14:20:10 +0200) ---------------------------------------------------------------- omapdrm fixes for 4.15 * Fix OMAP4 HDMI CEC interrupt handling and a possible buffer overflow ---------------------------------------------------------------- Hans Verkuil (1): omapdrm/dss/hdmi4_cec: fix interrupt handling drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c | 46 +++++++-------------------------- 1 file changed, 9 insertions(+), 37 deletions(-) -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

1 0

[PATCH v2] drm/ttm: check the return value of kzalloc
by Xiongwei Song 02 Jan '18

02 Jan '18

In the function ttm_page_alloc_init, kzalloc call is made for variable _manager, we need to check its return value, it may return NULL. Signed-off-by: Xiongwei Song <sxwjean(a)gmail.com> --- v1->v2: delete kfree _manager --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c index b5ba6441489f..583d73edb7df 100644 --- a/drivers/gpu/drm/ttm/ttm_page_alloc.c +++ b/drivers/gpu/drm/ttm/ttm_page_alloc.c @@ -1007,6 +1007,10 @@ int ttm_page_alloc_init(struct ttm_mem_global *glob, unsigned max_pages) pr_info("Initializing pool allocator\n"); _manager = kzalloc(sizeof(*_manager), GFP_KERNEL); + if (!_manager) { + ret = -ENOMEM; + goto out; + } ttm_page_pool_init_locked(&_manager->wc_pool, GFP_HIGHUSER, "wc", 0); @@ -1041,6 +1045,8 @@ int ttm_page_alloc_init(struct ttm_mem_global *glob, unsigned max_pages) ttm_pool_mm_shrink_init(_manager); return 0; +out: + return ret; } void ttm_page_alloc_fini(void) -- 2.15.1

2 1

nouveau. swiotlb: coherent allocation failed for device 0000:01:00.0 size=2097152
by Mike Galbraith 02 Jan '18

02 Jan '18

Greetings, Kernel bound workloads seem to trigger the below for whatever reason. I only see this when beating up NFS. There was a kworker wakeup latency issue, but with a bandaid applied to fix that up, I can still trigger this. [ 1313.811031] nouveau 0000:01:00.0: swiotlb buffer is full (sz: 2097152 bytes) [ 1313.811035] swiotlb: coherent allocation failed for device 0000:01:00.0 size=2097152 [ 1313.811038] CPU: 6 PID: 3026 Comm: Xorg Tainted: G E 4.15.0.g1291a0d5-master #355 [ 1313.811040] Hardware name: MEDION MS-7848/MS-7848, BIOS M7848W08.20C 09/23/2013 [ 1313.811041] Call Trace: [ 1313.811049] dump_stack+0x7c/0xb6 [ 1313.811053] swiotlb_alloc_coherent+0x13f/0x150 [ 1313.811060] ttm_dma_pool_alloc_new_pages+0x106/0x3c0 [ttm] [ 1313.811066] ttm_dma_pool_get_pages+0x10a/0x1e0 [ttm] [ 1313.811070] ttm_dma_populate+0x21f/0x2f0 [ttm] [ 1313.811075] ttm_tt_bind+0x2f/0x60 [ttm] [ 1313.811079] ttm_bo_handle_move_mem+0x51f/0x580 [ttm] [ 1313.811084] ? ttm_bo_handle_move_mem+0x5/0x580 [ttm] [ 1313.811088] ttm_bo_validate+0x10c/0x120 [ttm] [ 1313.811092] ? ttm_bo_validate+0x5/0x120 [ttm] [ 1313.811106] ? drm_mode_setcrtc+0x20e/0x540 [drm] [ 1313.811109] ttm_bo_init_reserved+0x290/0x490 [ttm] [ 1313.811114] ttm_bo_init+0x52/0xb0 [ttm] [ 1313.811141] ? nv10_bo_put_tile_region+0x60/0x60 [nouveau] [ 1313.811163] nouveau_bo_new+0x465/0x5e0 [nouveau] [ 1313.811184] ? nv10_bo_put_tile_region+0x60/0x60 [nouveau] [ 1313.811203] nouveau_gem_new+0x66/0x110 [nouveau] [ 1313.811223] ? nouveau_gem_new+0x110/0x110 [nouveau] [ 1313.811241] nouveau_gem_ioctl_new+0x48/0xc0 [nouveau] [ 1313.811249] drm_ioctl_kernel+0x64/0xb0 [drm] [ 1313.811257] drm_ioctl+0x2a4/0x360 [drm] [ 1313.811276] ? nouveau_gem_new+0x110/0x110 [nouveau] [ 1313.811285] ? drm_ioctl+0x5/0x360 [drm] [ 1313.811304] nouveau_drm_ioctl+0x50/0xb0 [nouveau] [ 1313.811308] do_vfs_ioctl+0x90/0x690 [ 1313.811311] ? do_vfs_ioctl+0x5/0x690 [ 1313.811313] SyS_ioctl+0x3b/0x70 [ 1313.811316] entry_SYSCALL_64_fastpath+0x1f/0x91 [ 1313.811320] RIP: 0033:0x7f3234746227 [ 1313.811321] RSP: 002b:00007ffc3ace0408 EFLAGS: 00003246 ORIG_RAX: 0000000000000010 [ 1313.811324] RAX: ffffffffffffffda RBX: 00000000025515d0 RCX: 00007f3234746227 [ 1313.811325] RDX: 00007ffc3ace0460 RSI: 00000000c0306480 RDI: 000000000000000b [ 1313.811326] RBP: 0000000000824120 R08: 0000000002548f80 R09: 00000000025490d0 [ 1313.811328] R10: 0000000000000000 R11: 0000000000003246 R12: 000000000000093d [ 1313.811329] R13: 0000000002aff74c R14: 0000000000824150 R15: 0000000000000000

5 9

[PATCH] staging: vboxvideo adapt to new TTM interface
by Roger He 02 Jan '18

02 Jan '18

Fixes interface change done in the following commit: eb86c98 drm/ttm: use an operation ctx for ttm_tt_populate in ttm_bo_driver i missed this driver because it is in staging dir. Signed-off-by: Roger He <Hongbo.He(a)amd.com> --- drivers/staging/vboxvideo/vbox_ttm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vboxvideo/vbox_ttm.c b/drivers/staging/vboxvideo/vbox_ttm.c index 231c89e..55f14c9 100644 --- a/drivers/staging/vboxvideo/vbox_ttm.c +++ b/drivers/staging/vboxvideo/vbox_ttm.c @@ -213,9 +213,10 @@ static struct ttm_tt *vbox_ttm_tt_create(struct ttm_bo_device *bdev, return tt; } -static int vbox_ttm_tt_populate(struct ttm_tt *ttm) +static int vbox_ttm_tt_populate(struct ttm_tt *ttm, + struct ttm_operation_ctx *ctx) { - return ttm_pool_populate(ttm); + return ttm_pool_populate(ttm, ctx); } static void vbox_ttm_tt_unpopulate(struct ttm_tt *ttm) -- 2.7.4

4 4

[PATCH] drm/ttm: optimize errors checking and free _manager when finishing
by Xiongwei Song 02 Jan '18

02 Jan '18

In the function ttm_page_alloc_init, kzalloc call is made for variable _manager, we need to check its return value, it may return NULL. In the function ttm_page_alloc_fini, we need to call kfree for variable _manager, instead of make _manager NULL directly. Signed-off-by: Xiongwei Song <sxwjean(a)gmail.com> --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c index b5ba6441489f..e20a0b8e352b 100644 --- a/drivers/gpu/drm/ttm/ttm_page_alloc.c +++ b/drivers/gpu/drm/ttm/ttm_page_alloc.c @@ -1007,6 +1007,10 @@ int ttm_page_alloc_init(struct ttm_mem_global *glob, unsigned max_pages) pr_info("Initializing pool allocator\n"); _manager = kzalloc(sizeof(*_manager), GFP_KERNEL); + if (!_manager) { + ret = -ENOMEM; + goto out; + } ttm_page_pool_init_locked(&_manager->wc_pool, GFP_HIGHUSER, "wc", 0); @@ -1034,13 +1038,17 @@ int ttm_page_alloc_init(struct ttm_mem_global *glob, unsigned max_pages) &glob->kobj, "pool"); if (unlikely(ret != 0)) { kobject_put(&_manager->kobj); - _manager = NULL; - return ret; + goto out_free_mgr; } ttm_pool_mm_shrink_init(_manager); return 0; +out_free_mgr: + kfree(_manager); + _manager = NULL; +out: + return ret; } void ttm_page_alloc_fini(void) @@ -1055,6 +1063,7 @@ void ttm_page_alloc_fini(void) ttm_page_pool_free(&_manager->pools[i], FREE_ALL_PAGES, true); kobject_put(&_manager->kobj); + kfree(_manager); _manager = NULL; } -- 2.15.1

3 2

[PATCH] drivers: gpu: drm: Fix warning for incomplete Declarations in client.c
by Vaibhav Kothari 02 Jan '18

02 Jan '18

This patch fixes the Sparse Warning "symbol was not declared. Should it be static?" in nvkm/core/client.c Signed-off-by: Vaibhav Kothari <vaibhavddit(a)gmail.com> --- drivers/gpu/drm/nouveau/nvkm/core/client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/core/client.c b/drivers/gpu/drm/nouveau/nvkm/core/client.c index ac67120..0c8c55c 100644 --- a/drivers/gpu/drm/nouveau/nvkm/core/client.c +++ b/drivers/gpu/drm/nouveau/nvkm/core/client.c @@ -60,7 +60,7 @@ nvkm_uclient_new(const struct nvkm_oclass *oclass, void *argv, u32 argc, return 0; } -const struct nvkm_sclass +static const struct nvkm_sclass nvkm_uclient_sclass = { .oclass = NVIF_CLASS_CLIENT, .minver = 0, -- 2.7.4

1 0

[GIT PULL] imx-drm format modifier support
by Philipp Zabel 02 Jan '18

02 Jan '18

Hi Dave, Happy New Year! Please consider merging this tag, which adds format modifier support to allow direct scanout from Vivante tiled buffers on i.MX6QP SoCs. To improve build coverage, ipu-v3 can now be enabled under COMPILE_TEST. regards Philipp The following changes since commit 1291a0d5049dbc06baaaf66a9ff3f53db493b19b: Linux 4.15-rc4 (2017-12-17 18:59:59 -0800) are available in the git repository at: git://git.pengutronix.de/git/pza/linux.git tags/imx-drm-next-2018-01-02 for you to fetch changes up to 4cfea3c1f2718d945ca44c1aaac47d8d513c4478: gpu: ipu-v3: allow to build with COMPILE_TEST (2017-12-19 12:49:11 +0100) ---------------------------------------------------------------- drm/imx: format modifier support - Add tiled prefetch support to PRE - Add format modifier support to PRG and imx-drm-core - Use runtime PM to control PRG clock - Allow building ipu-v3 under COMPILE_TEST ---------------------------------------------------------------- Lucas Stach (5): gpu: ipu-v3: prg: switch to runtime PM gpu: ipu-v3: pre: add tiled prefetch support gpu: ipu-v3: prg: add modifier support drm/imx: add FB modifier support drm/imx: advertise supported plane format modifiers Philipp Zabel (1): gpu: ipu-v3: allow to build with COMPILE_TEST drivers/gpu/drm/imx/imx-drm-core.c | 1 + drivers/gpu/drm/imx/ipuv3-plane.c | 102 ++++++++++++++++++++++++++++++++++--- drivers/gpu/ipu-v3/Kconfig | 4 +- drivers/gpu/ipu-v3/ipu-cpmem.c | 1 + drivers/gpu/ipu-v3/ipu-ic.c | 1 + drivers/gpu/ipu-v3/ipu-pre.c | 29 +++++++++-- drivers/gpu/ipu-v3/ipu-prg.c | 84 +++++++++++++++++++++--------- drivers/gpu/ipu-v3/ipu-prv.h | 4 +- include/video/imx-ipu-v3.h | 2 +- 9 files changed, 189 insertions(+), 39 deletions(-)

1 0

[Bug 102909] radeon 0000:03:00.0: ring 0 stalled for more than 10000msec
by bugzilla-daemon＠freedesktop.org 02 Jan '18

02 Jan '18

1 0

linux-next: build failure after merge of the drm tree
by Stephen Rothwell 02 Jan '18

02 Jan '18

Hi all, After merging the drm tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:219:6: error: redefinition of 'dm_dp_mst_dc_sink_create' void dm_dp_mst_dc_sink_create(struct drm_connector *connector) ^ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:183:6: note: previous definition of 'dm_dp_mst_dc_sink_create' was here void dm_dp_mst_dc_sink_create(struct drm_connector *connector) ^ Caused by commit 391ef035200f ("drm/amd/display: Fix rehook MST display not light back on") automatically mergeing badly with commit becd0875f439 ("drm/amd/display: Fix rehook MST display not light back on") from Linus' tree. I applied this merge fix patch (to remove the second copy of dm_dp_mst_dc_sink_create): From: Stephen Rothwell <sfr(a)canb.auug.org.au> Date: Tue, 2 Jan 2018 12:43:32 +1100 Subject: [PATCH] drm/amd/display: fix mismerge of identical patches Signed-off-by: Stephen Rothwell <sfr(a)canb.auug.org.au> --- .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 36 ---------------------- 1 file changed, 36 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c index 7ace4dd302c1..f3d87f418d2e 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c @@ -216,42 +216,6 @@ void dm_dp_mst_dc_sink_create(struct drm_connector *connector) &aconnector->base, aconnector->edid); } -void dm_dp_mst_dc_sink_create(struct drm_connector *connector) -{ - struct amdgpu_dm_connector *aconnector = to_amdgpu_dm_connector(connector); - struct edid *edid; - struct dc_sink *dc_sink; - struct dc_sink_init_data init_params = { - .link = aconnector->dc_link, - .sink_signal = SIGNAL_TYPE_DISPLAY_PORT_MST }; - - edid = drm_dp_mst_get_edid(connector, &aconnector->mst_port->mst_mgr, aconnector->port); - - if (!edid) { - drm_mode_connector_update_edid_property( - &aconnector->base, - NULL); - return; - } - - aconnector->edid = edid; - - dc_sink = dc_link_add_remote_sink( - aconnector->dc_link, - (uint8_t *)aconnector->edid, - (aconnector->edid->extensions + 1) * EDID_LENGTH, - &init_params); - - dc_sink->priv = aconnector; - aconnector->dc_sink = dc_sink; - - amdgpu_dm_add_sink_to_freesync_module( - connector, aconnector->edid); - - drm_mode_connector_update_edid_property( - &aconnector->base, aconnector->edid); -} - static int dm_dp_mst_get_modes(struct drm_connector *connector) { struct amdgpu_dm_connector *aconnector = to_amdgpu_dm_connector(connector); -- 2.15.0 -- Cheers, Stephen Rothwell

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2018