dri-devel October 2018

dri-devel@lists.freedesktop.org

277 participants
1898 discussions

[git pull] drm fixes for 4.19-rc7 (part 2)
by Dave Airlie 05 Oct '18

05 Oct '18

Hey Greg, I was meant to take today off so sent the pull yesterday, but some more stuff came in and I'd rather not sit on it, Two fixes for amdgpu: one corrects a use of process->mm one fix for display code race condition that can result in a crash Two core fixes: One for a use-after-free in the leasing code One for a cma/fbdev crash. Thanks, Dave. drm-fixes-2018-10-05: amdgpu and two core fixes The following changes since commit d8938c981f58ee344687b7910a611ac345960045: Merge branch … [View More]

2 1

[PATCH v3 0/5] Fix legacy DPMS changes with MST
by Lyude Paul 04 Oct '18

04 Oct '18

Next version of https://patchwork.freedesktop.org/series/49877/ This fixes some rather silly bugs regarding DPMS On->Off changes failing for connectors which were just recently destroyed. Lyude Paul (5): drm/atomic_helper: Disallow new modesets on unregistered connectors drm/nouveau: Fix nv50_mstc->best_encoder() drm/i915: Leave intel_conn->mst_port set, use mst_port_gone instead drm/i915: Skip vcpi allocation for MSTB ports that are gone drm/i915: Fix … [View More]

1 5

[Bug 105911] DVI-D monitor connected to DVI-I output not detected (regression from kernel 4.14.32 to kernel 4.16.0 using graphic core)
by bugzilla-daemon＠freedesktop.org 04 Oct '18

04 Oct '18

https://bugs.freedesktop.org/show_bug.cgi?id=105911 --- Comment #13 from tnmailinglists(a)gmail.com --- I now booted with amdgpu.dc_log=1 and found the following in my log when DC is on (I'm currently on 4.15.0.36): [ 1.479998] [drm] DC: create_links: connectors_num: physical:4, virtual:0 [ 1.480001] [drm] Connector[0] description:signal 32 [ 1.480029] [drm] Connector[1] description:signal 4 [ 1.480031] [drm] dce110_link_encoder_construct: Failed to get encoder_cap_info from VBIOS … [View More]

1 0

[PATCH 00/18] atomic helper cleanups
by Daniel Vetter 04 Oct '18

04 Oct '18

Hi all, Here's a pile of atomic helper cleanups. Big chunk is shredding the transitional helpers, I don't think they're useful anymore. armada is converted, vboxvideo is getting converted as we speak for 4.20, anything that's left is probably better to just move over to a simple display pipe driver. Also some other related cleanups and driver patches mixed in, some (reworked) resends. Comments very much welcome, as usual. Thanks, Daniel Daniel Vetter (17): drm/amdgpu: Remove default … [View More]best_encoder hook from DC drm/atomic-helper: Unexport drm_atomic_helper_best_encoder drm: Extract drm_atomic_state_helper.[hc] drm/vmwgfx: Remove confused comment from vmw_du_connector_atomic_set_property drm/vmwgfx: Don't look at state->allow_modeset drm/atomic: Improve docs for drm_atomic_state->allow_modeset drm/vmwgfx: Add FIXME comments for customer page_flip handlers drm/arcpgu: Drop transitional hooks drm/atmel: Drop transitional hooks drm/arcpgu: Use drm_atomic_helper_shutdown drm/msm: Use drm_atomic_helper_shutdown drm/sti: Use drm_atomic_helper_shutdown drm/vc4: Use drm_atomic_helper_shutdown drm/zte: Use drm_atomic_helper_shutdown drm: Remove transitional helpers drm: Unexport drm_plane_helper_check_update drm: Unexport primary plane helpers Thomas Hellstrom (1): drm/vmwgfx: Fix vmw_du_cursor_plane_atomic_check Documentation/gpu/drm-kms-helpers.rst | 19 +- drivers/gpu/drm/Makefile | 3 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 +- drivers/gpu/drm/arc/arcpgu_crtc.c | 3 - drivers/gpu/drm/arc/arcpgu_drv.c | 1 + .../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 2 - drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 - drivers/gpu/drm/drm_atomic_helper.c | 590 +---------------- drivers/gpu/drm/drm_atomic_state_helper.c | 601 ++++++++++++++++++ drivers/gpu/drm/drm_crtc_helper.c | 115 ---- drivers/gpu/drm/drm_plane_helper.c | 331 +--------- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 - drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c | 1 - drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 1 - drivers/gpu/drm/msm/msm_drv.c | 1 + drivers/gpu/drm/sti/sti_cursor.c | 1 - drivers/gpu/drm/sti/sti_drv.c | 6 +- drivers/gpu/drm/sti/sti_gdp.c | 1 - drivers/gpu/drm/sti/sti_hqvdp.c | 1 - drivers/gpu/drm/vc4/vc4_drv.c | 3 + drivers/gpu/drm/vc4/vc4_plane.c | 1 - drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 38 +- drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 1 - drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 3 +- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 2 +- drivers/gpu/drm/zte/zx_drm_drv.c | 1 + drivers/gpu/drm/zte/zx_plane.c | 1 - include/drm/drm_atomic.h | 10 +- include/drm/drm_atomic_helper.h | 46 +- include/drm/drm_atomic_state_helper.h | 80 +++ include/drm/drm_crtc_helper.h | 6 - include/drm/drm_plane_helper.h | 35 - 32 files changed, 767 insertions(+), 1154 deletions(-) create mode 100644 drivers/gpu/drm/drm_atomic_state_helper.c create mode 100644 include/drm/drm_atomic_state_helper.h -- 2.19.0.rc2 [View Less]

7 45

[PATCH v2] drm/scheduler: remove timeout work_struct from drm_sched_job
by Nayan Deshmukh 04 Oct '18

04 Oct '18

having a delayed work item per job is redundant as we only need one per scheduler to track the time out the currently executing job. v2: the first element of the ring mirror list is the currently executing job so we don't need a additional variable for it Signed-off-by: Nayan Deshmukh <nayan26deshmukh(a)gmail.com> Suggested-by: Christian König <christian.koenig(a)amd.com> --- drivers/gpu/drm/scheduler/sched_main.c | 28 +++++++++++++++------------- include/drm/gpu_scheduler.h … [View More] | 6 +++--- 2 files changed, 18 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index 9ca741f3a0bc..88f6cff136f2 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -197,19 +197,16 @@ static void drm_sched_job_finish(struct work_struct *work) * manages to find this job as the next job in the list, the fence * signaled check below will prevent the timeout to be restarted. */ - cancel_delayed_work_sync(&s_job->work_tdr); + cancel_delayed_work_sync(&sched->work_tdr); spin_lock(&sched->job_list_lock); /* queue TDR for next job */ + list_del(&s_job->node); if (sched->timeout != MAX_SCHEDULE_TIMEOUT && - !list_is_last(&s_job->node, &sched->ring_mirror_list)) { - struct drm_sched_job *next = list_next_entry(s_job, node); - - if (!dma_fence_is_signaled(&next->s_fence->finished)) - schedule_delayed_work(&next->work_tdr, sched->timeout); + !list_empty(&sched->ring_mirror_list)) { + schedule_delayed_work(&sched->work_tdr, sched->timeout); } /* remove job from ring_mirror_list */ - list_del(&s_job->node); spin_unlock(&sched->job_list_lock); dma_fence_put(&s_job->s_fence->finished); @@ -236,16 +233,21 @@ static void drm_sched_job_begin(struct drm_sched_job *s_job) if (sched->timeout != MAX_SCHEDULE_TIMEOUT && list_first_entry_or_null(&sched->ring_mirror_list, struct drm_sched_job, node) == s_job) - schedule_delayed_work(&s_job->work_tdr, sched->timeout); + schedule_delayed_work(&sched->work_tdr, sched->timeout); spin_unlock(&sched->job_list_lock); } static void drm_sched_job_timedout(struct work_struct *work) { - struct drm_sched_job *job = container_of(work, struct drm_sched_job, - work_tdr.work); + struct drm_gpu_scheduler *sched; + struct drm_sched_job *job; + + sched = container_of(work, struct drm_gpu_scheduler, work_tdr.work); + job = list_first_entry_or_null(&sched->ring_mirror_list, + struct drm_sched_job, node); - job->sched->ops->timedout_job(job); + if (job) + job->sched->ops->timedout_job(job); } /** @@ -315,7 +317,7 @@ void drm_sched_job_recovery(struct drm_gpu_scheduler *sched) s_job = list_first_entry_or_null(&sched->ring_mirror_list, struct drm_sched_job, node); if (s_job && sched->timeout != MAX_SCHEDULE_TIMEOUT) - schedule_delayed_work(&s_job->work_tdr, sched->timeout); + schedule_delayed_work(&sched->work_tdr, sched->timeout); list_for_each_entry_safe(s_job, tmp, &sched->ring_mirror_list, node) { struct drm_sched_fence *s_fence = s_job->s_fence; @@ -384,7 +386,6 @@ int drm_sched_job_init(struct drm_sched_job *job, INIT_WORK(&job->finish_work, drm_sched_job_finish); INIT_LIST_HEAD(&job->node); - INIT_DELAYED_WORK(&job->work_tdr, drm_sched_job_timedout); return 0; } @@ -575,6 +576,7 @@ int drm_sched_init(struct drm_gpu_scheduler *sched, INIT_LIST_HEAD(&sched->ring_mirror_list); spin_lock_init(&sched->job_list_lock); atomic_set(&sched->hw_rq_count, 0); + INIT_DELAYED_WORK(&sched->work_tdr, drm_sched_job_timedout); atomic_set(&sched->num_jobs, 0); atomic64_set(&sched->job_id_count, 0); diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h index daec50f887b3..d87b268f1781 100644 --- a/include/drm/gpu_scheduler.h +++ b/include/drm/gpu_scheduler.h @@ -175,8 +175,6 @@ struct drm_sched_fence *to_drm_sched_fence(struct dma_fence *f); * finished to remove the job from the * @drm_gpu_scheduler.ring_mirror_list. * @node: used to append this struct to the @drm_gpu_scheduler.ring_mirror_list. - * @work_tdr: schedules a delayed call to @drm_sched_job_timedout after the timeout - * interval is over. * @id: a unique id assigned to each job scheduled on the scheduler. * @karma: increment on every hang caused by this job. If this exceeds the hang * limit of the scheduler then the job is marked guilty and will not @@ -195,7 +193,6 @@ struct drm_sched_job { struct dma_fence_cb finish_cb; struct work_struct finish_work; struct list_head node; - struct delayed_work work_tdr; uint64_t id; atomic_t karma; enum drm_sched_priority s_priority; @@ -259,6 +256,8 @@ struct drm_sched_backend_ops { * finished. * @hw_rq_count: the number of jobs currently in the hardware queue. * @job_id_count: used to assign unique id to the each job. + * @work_tdr: schedules a delayed call to @drm_sched_job_timedout after the + * timeout interval is over. * @thread: the kthread on which the scheduler which run. * @ring_mirror_list: the list of jobs which are currently in the job queue. * @job_list_lock: lock to protect the ring_mirror_list. @@ -278,6 +277,7 @@ struct drm_gpu_scheduler { wait_queue_head_t job_scheduled; atomic_t hw_rq_count; atomic64_t job_id_count; + struct delayed_work work_tdr; struct task_struct *thread; struct list_head ring_mirror_list; spinlock_t job_list_lock; -- 2.14.3 [View Less]

3 8

[PATCH 1/3] drm/i915: Restore vblank interrupts earlier
by Ville Syrjala 04 Oct '18

04 Oct '18

From: Ville Syrjälä <ville.syrjala(a)linux.intel.com> Plane sanitation needs vblank interrupts (on account of CxSR disable). So let's restore vblank interrupts earlier. v2: Make it actually build Cc: stable(a)vger.kernel.org Cc: Dennis <dennis.nezic(a)utoronto.ca> Tested-by: Dennis <dennis.nezic(a)utoronto.ca> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105637 Fixes: b1e01595a66d ("drm/i915: Redo plane sanitation during readout") Signed-off-by: Ville Syrjälä <… [View More]

3 15

[git pull] drm fixes for 4.19-rc7
by Dave Airlie 04 Oct '18

04 Oct '18

Hi Greg, Nothing too much happening at this point, 3 i915 fixes: compressed error handling zlib fix compiler warning cleanup and a minor code cleanup 2 tda9950: Two fixes for the HDMI CEC 1 exynos: A fix required for IOMMU interaction. Thanks, Dave. drm-fixes-2018-10-04: drm exynos, tda9950 and intel fixes The following changes since commit 17b57b1883c1285f3d0dc2266e8f79286a7bef38: Linux 4.19-rc6 (2018-09-30 07:15:35 -0700) are available in the Git repository at: git://anongit.… [View More]

2 1

[PATCH libdrm] libdrm: Allow dynamic drm majors on linux
by Thomas Hellstrom 04 Oct '18

04 Oct '18

To determine whether a device node is a drm device node or not, the code currently compares the node's major number to the static drm major device number. This breaks the standalone vmwgfx driver on XWayland dri clients, https://cgit.freedesktop.org/mesa/vmwgfx and any future attempt to introduce dynamic device numbers for drm. So instead of checking for the device major, instead check for the presence of the /sys/dev/char/<major>:<minor>/device/drm directory. Signed-off-by: … [View More]Thomas Hellstrom <thellstrom(a)vmware.com> --- xf86drm.c | 31 +++++++++++++++++++++++-------- 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/xf86drm.c b/xf86drm.c index 7807dce9..4cfc5d3e 100644 --- a/xf86drm.c +++ b/xf86drm.c @@ -2761,6 +2761,21 @@ char *drmGetDeviceNameFromFd(int fd) return strdup(name); } +static bool +drmNodeIsDRM(int maj, int min) +{ +#ifdef __linux__ + char path[64]; + struct stat sbuf; + + snprintf(path, sizeof(path), "/sys/dev/char/%d:%d/device/drm", + maj, min); + return stat(path, &sbuf) == 0; +#else + return maj == DRM_MAJOR; +#endif +} + int drmGetNodeTypeFromFd(int fd) { struct stat sbuf; @@ -2772,7 +2787,7 @@ int drmGetNodeTypeFromFd(int fd) maj = major(sbuf.st_rdev); min = minor(sbuf.st_rdev); - if (maj != DRM_MAJOR || !S_ISCHR(sbuf.st_mode)) { + if (!drmNodeIsDRM(maj, min) || !S_ISCHR(sbuf.st_mode)) { errno = EINVAL; return -1; } @@ -2837,7 +2852,7 @@ static char *drmGetMinorNameForFD(int fd, int type) maj = major(sbuf.st_rdev); min = minor(sbuf.st_rdev); - if (maj != DRM_MAJOR || !S_ISCHR(sbuf.st_mode)) + if (!drmNodeIsDRM(maj, min) || !S_ISCHR(sbuf.st_mode)) return NULL; snprintf(buf, sizeof(buf), "/sys/dev/char/%d:%d/device/drm", maj, min); @@ -2871,7 +2886,7 @@ static char *drmGetMinorNameForFD(int fd, int type) maj = major(sbuf.st_rdev); min = minor(sbuf.st_rdev); - if (maj != DRM_MAJOR || !S_ISCHR(sbuf.st_mode)) + if (!drmNodeIsDRM(maj, min) || !S_ISCHR(sbuf.st_mode)) return NULL; switch (type) { @@ -3731,7 +3746,7 @@ process_device(drmDevicePtr *device, const char *d_name, maj = major(sbuf.st_rdev); min = minor(sbuf.st_rdev); - if (maj != DRM_MAJOR || !S_ISCHR(sbuf.st_mode)) + if (!drmNodeIsDRM(maj, min) || !S_ISCHR(sbuf.st_mode)) return -1; subsystem_type = drmParseSubsystemType(maj, min); @@ -3845,7 +3860,7 @@ int drmGetDevice2(int fd, uint32_t flags, drmDevicePtr *device) maj = major(sbuf.st_rdev); min = minor(sbuf.st_rdev); - if (maj != DRM_MAJOR || !S_ISCHR(sbuf.st_mode)) + if (!drmNodeIsDRM(maj, min) || !S_ISCHR(sbuf.st_mode)) return -EINVAL; node_type = drmGetMinorType(min); @@ -3911,7 +3926,7 @@ int drmGetDevice2(int fd, uint32_t flags, drmDevicePtr *device) maj = major(sbuf.st_rdev); min = minor(sbuf.st_rdev); - if (maj != DRM_MAJOR || !S_ISCHR(sbuf.st_mode)) + if (!drmNodeIsDRM(maj, min) || !S_ISCHR(sbuf.st_mode)) return -EINVAL; subsystem_type = drmParseSubsystemType(maj, min); @@ -4071,7 +4086,7 @@ char *drmGetDeviceNameFromFd2(int fd) maj = major(sbuf.st_rdev); min = minor(sbuf.st_rdev); - if (maj != DRM_MAJOR || !S_ISCHR(sbuf.st_mode)) + if (!drmNodeIsDRM(maj, min) || !S_ISCHR(sbuf.st_mode)) return NULL; snprintf(path, sizeof(path), "/sys/dev/char/%d:%d", maj, min); @@ -4097,7 +4112,7 @@ char *drmGetDeviceNameFromFd2(int fd) maj = major(sbuf.st_rdev); min = minor(sbuf.st_rdev); - if (maj != DRM_MAJOR || !S_ISCHR(sbuf.st_mode)) + if (!drmNodeIsDRM(maj, min) || !S_ISCHR(sbuf.st_mode)) return NULL; node_type = drmGetMinorType(min); -- 2.18.0.rc1 [View Less]

9 24

[Bug 103791] Tearing after screen wakeup/on
by bugzilla-daemon＠freedesktop.org 04 Oct '18

04 Oct '18

https://bugs.freedesktop.org/show_bug.cgi?id=103791 Bug ID: 103791 Summary: Tearing after screen wakeup/on Product: DRI Version: XOrg git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: denisgolovan(a)yandex.ru Hi Sometimes after screen wakeup/turning on I start to … [View More]

1 23

[Bug 105744] randomly flashing screen with RX 580
by bugzilla-daemon＠freedesktop.org 04 Oct '18

04 Oct '18

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel October 2018