dri-devel December 2018

dri-devel@lists.freedesktop.org

283 participants
2020 discussions

[Bug 108920] [AMDGPU][TAHITI XT] linux unable to boot since rc3 rebase
by bugzilla-daemon＠freedesktop.org 03 Dec '18

03 Dec '18

https://bugs.freedesktop.org/show_bug.cgi?id=108920 Bug ID: 108920 Summary: [AMDGPU][TAHITI XT] linux unable to boot since rc3 rebase Product: DRI Version: DRI git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: blocker Priority: highest Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: sylvain.bertrand(a)gmail.com did my weekly update of the 3D stack, and with a today git user space linux rc3 is not able to boot and linux from last week(rc1) is fine (branch amd-staging-drm-next) Yes, I can bisect -- You are receiving this mail because: You are the assignee for the bug.

2 4

[PATCH 0/8] drm: Add COLOR_ENCODING and COLOR_RANGE plane properties
by Ville Syrjala 03 Dec '18

03 Dec '18

From: Ville Syrjälä <ville.syrjala(a)linux.intel.com> Here's a refresh of Jyri's COLOR_ENCODING and COLOR_RANGE properties, and the i915 implementation I did on top. I tossed in a few core updates as well: plane state dump, and the BT.2020 constant luminance variant. Apparently nouveau is already exposing a "iturbt_709" bool property which allows one to choose between BT.601 and BT.709 encodings, but given that we want at least BT.2020 in addition I don't think that property is good enough. Trying to implement it, and somehow extend it beyond BT.601 vs. BT.709 seems like wasted effort. Hence I think we should just ignore it and move on. My userspace implementation in the form of intel ddx XV_COLORSPACE attribute: https://patchwork.freedesktop.org/patch/204696/ Cc: Harry Wentland <harry.wentland(a)amd.com> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: Daniel Stone <daniel(a)fooishbar.org> Cc: Russell King - ARM Linux <linux(a)armlinux.org.uk> Cc: Ilia Mirkin <imirkin(a)alum.mit.edu> Cc: Hans Verkuil <hverkuil(a)xs4all.nl> Cc: Uma Shankar <uma.shankar(a)intel.com> Cc: Shashank Sharma <shashank.sharma(a)intel.com> Jyri Sarha (1): drm: Add optional COLOR_ENCODING and COLOR_RANGE properties to drm_plane Ville Syrjälä (7): drm: Add BT.2020 constant luminance enum value for the COLOR_ENCODING property drm/atomic: Include color encoding/range in plane state dump drm/i915: Correctly handle limited range YCbCr data on VLV/CHV drm/i915: Fix plane YCbCr->RGB conversion for GLK drm/i915: Add support for the YCbCr COLOR_ENCODING property drm/i915: Change the COLOR_ENCODING prop default value to BT.709 drm/i915: Add support for the YCbCr COLOR_RANGE property drivers/gpu/drm/drm_atomic.c | 12 ++++ drivers/gpu/drm/drm_color_mgmt.c | 108 ++++++++++++++++++++++++++++ drivers/gpu/drm/drm_crtc_internal.h | 2 + drivers/gpu/drm/i915/i915_reg.h | 24 ++++++- drivers/gpu/drm/i915/intel_display.c | 25 +++++++ drivers/gpu/drm/i915/intel_drv.h | 2 + drivers/gpu/drm/i915/intel_sprite.c | 134 ++++++++++++++++++++++++++++------- include/drm/drm_color_mgmt.h | 20 ++++++ include/drm/drm_plane.h | 8 +++ 9 files changed, 309 insertions(+), 26 deletions(-) -- 2.13.6

10 38

[PATCH] drm/omap: fix bus_flags for panel-dpi
by Tomi Valkeinen 03 Dec '18

03 Dec '18

panel-dpi used to convey the bus-flags via the videomode, but recent changes changed the use of videomode to DRM's drm_display_mode which does not contain bus-flags. This broke panel-dpi, which didn't explicitly store the bus-flags into dssdev->bus_flags. Fix this by setting dssdev->bus_flags. Also change the bus_flags type to u32, as that is the type used in the DRM framework, and we would get a warning with drm_bus_flags_from_videomode() otherwise. Fixes: 3fbda31e814868d8477ddf52d74b7b8f596578e8 ("drm/omap: Split mode fixup and mode set from encoder enable") Signed-off-by: Tomi Valkeinen <tomi.valkeinen(a)ti.com> Reported-by: H. Nikolaus Schaller <hns(a)goldelico.com> --- drivers/gpu/drm/omapdrm/displays/panel-dpi.c | 1 + drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c index 1f8161b041be..465120809eb3 100644 --- a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c +++ b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c @@ -177,6 +177,7 @@ static int panel_dpi_probe(struct platform_device *pdev) dssdev->type = OMAP_DISPLAY_TYPE_DPI; dssdev->owner = THIS_MODULE; dssdev->of_ports = BIT(0); + drm_bus_flags_from_videomode(&ddata->vm, &dssdev->bus_flags); omapdss_display_init(dssdev); omapdss_device_register(dssdev); diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h index 1f698a95a94a..33e15cb77efa 100644 --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h @@ -432,7 +432,7 @@ struct omap_dss_device { const struct omap_dss_driver *driver; const struct omap_dss_device_ops *ops; unsigned long ops_flags; - unsigned long bus_flags; + u32 bus_flags; /* helper variable for driver suspend/resume */ bool activate_after_resume; -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

2 1

[PATCH] drm/amdgpu: NULL check before some freeing functions is not needed.
by Thomas Meyer 03 Dec '18

03 Dec '18

NULL check before some freeing functions is not needed. Signed-off-by: Thomas Meyer <thomas(a)m3y3r.de> --- diff -u -p a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c @@ -816,6 +816,5 @@ out: void amdgpu_acpi_fini(struct amdgpu_device *adev) { unregister_acpi_notifier(&adev->acpi_nb); - if (adev->atif) - kfree(adev->atif); + kfree(adev->atif); }

2 1

[Bug 198669] New: Driver crash at radeon_ring_backup+0xd3/0x140 [radeon]
by bugzilla-daemon＠bugzilla.kernel.org 03 Dec '18

03 Dec '18

https://bugzilla.kernel.org/show_bug.cgi?id=198669 Bug ID: 198669 Summary: Driver crash at radeon_ring_backup+0xd3/0x140 [radeon] Product: Drivers Version: 2.5 Kernel Version: 4.13.0-32-generic x86_64 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: high Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: roger(a)beardandsandals.co.uk Regression: No This is a resilience bug in the driver. When trying to recover from a GPU stall radeon_ring_backup causes a paging violation. [ 488.507091] BUG: unable to handle kernel paging request at ffffb406c1891ffc [ 488.507176] IP: radeon_ring_backup+0xd3/0x140 [radeon] The GPU stall is caused by a hardware problem triggered by vibration. N.B. This bug is not abput the hardware problem. It is about the drivers resilience when trying to recover from it. It is very similar to bug #62721 reported 4 years ago. However this is occurring using with the driver in the 4.13.0 kernel. Here os the dmesg output. [ 139.457873] rfkill: input handler disabled [ 468.102340] radeon 0000:02:00.0: ring 0 stalled for more than 10256msec [ 468.102346] radeon 0000:02:00.0: GPU lockup (current fence id 0x0000000000001bdb last fence id 0x0000000000001bdc on ring 0) ... Similar lines removed [ 487.558156] radeon 0000:02:00.0: ring 0 stalled for more than 29712msec [ 487.558161] radeon 0000:02:00.0: GPU lockup (current fence id 0x0000000000001bdb last fence id 0x0000000000001bdc on ring 0) [ 488.070157] radeon 0000:02:00.0: ring 0 stalled for more than 30224msec [ 488.070162] radeon 0000:02:00.0: GPU lockup (current fence id 0x0000000000001bdb last fence id 0x0000000000001bdc on ring 0) [ 488.507091] BUG: unable to handle kernel paging request at ffffb406c1891ffc [ 488.507176] IP: radeon_ring_backup+0xd3/0x140 [radeon] [ 488.507195] PGD 236d37067 [ 488.507196] P4D 236d37067 [ 488.507207] PUD 0 [ 488.507234] Oops: 0000 [#1] SMP PTI [ 488.507248] Modules linked in: rfcomm bnep bonding binfmt_misc btusb btrtl btbcm btintel intel_powerclamp joydev coretemp kvm_intel kvm input_leds bluetooth ecdh_generic arc4 ath9k ath9k_common ath9k_hw ath mac80211 irqbypass snd_seq_midi snd_seq_midi_event intel_cstate snd_hda_codec_realtek snd_hda_codec_generic snd_hda_codec_hdmi snd_rawmidi cfg80211 snd_hda_intel snd_hda_codec snd_hda_core snd_hwdep serio_raw snd_pcm snd_seq snd_seq_device snd_timer snd lpc_ich shpchp i7core_edac mac_hid i5500_temp soundcore tpm_infineon asus_atk0110 nfsd auth_rpcgss nfs_acl lockd grace sunrpc parport_pc ppdev lp parport ip_tables x_tables autofs4 amdkfd amd_iommu_v2 radeon i2c_algo_bit ttm drm_kms_helper hid_generic syscopyarea uas sysfillrect usbhid sysimgblt firewire_ohci fb_sys_fops usb_storage pata_acpi hid [ 488.507500] psmouse firewire_core r8169 drm crc_itu_t mii [ 488.507523] CPU: 7 PID: 2073 Comm: gnome-shell Tainted: G I 4.13.0-32-generic #35-Ubuntu [ 488.507554] Hardware name: System manufacturer System Product Name/P6T SE, BIOS 0403 05/19/2009 [ 488.507584] task: ffff9e0cb6191600 task.stack: ffffb402c3724000 [ 488.507619] RIP: 0010:radeon_ring_backup+0xd3/0x140 [radeon] [ 488.507639] RSP: 0018:ffffb402c3727c00 EFLAGS: 00010246 [ 488.507658] RAX: ffff9e0c6f300000 RBX: 0000000000037ba1 RCX: 0000000000000000 [ 488.507682] RDX: 0000000000000000 RSI: ffffb406c1891ffc RDI: 00000000000dee84 [ 488.507707] RBP: ffffb402c3727c28 R08: 00000000000269a8 R09: 00000000000b2c44 [ 488.507731] R10: ffffdc5046bd0000 R11: ffff9e0cfffd1d00 R12: ffffb402c3727c68 [ 488.507756] R13: ffff9e0ceafc9538 R14: ffff9e0ceafc9558 R15: 00000000ffffffff [ 488.507780] FS: 00007fdc82a60ac0(0000) GS:ffff9e0cf73c0000(0000) knlGS:0000000000000000 [ 488.507808] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 488.507828] CR2: ffffb406c1891ffc CR3: 00000001f632a000 CR4: 00000000000006e0 [ 488.507853] Call Trace: [ 488.507875] radeon_gpu_reset+0xc0/0x330 [radeon] [ 488.507895] ? dma_fence_wait_timeout+0x38/0xf0 [ 488.507912] ? reservation_object_wait_timeout_rcu+0x14f/0x2d0 [ 488.507946] radeon_gem_handle_lockup.part.4+0xe/0x20 [radeon] [ 488.507979] radeon_gem_wait_idle_ioctl+0x9c/0x100 [radeon] [ 488.508012] ? radeon_gem_busy_ioctl+0x80/0x80 [radeon] [ 488.508040] drm_ioctl_kernel+0x5d/0xb0 [drm] [ 488.508063] drm_ioctl+0x31b/0x3d0 [drm] [ 488.508091] ? radeon_gem_busy_ioctl+0x80/0x80 [radeon] [ 488.508111] ? futex_wake+0x8f/0x180 [ 488.508134] radeon_drm_ioctl+0x4f/0x90 [radeon] [ 488.508153] do_vfs_ioctl+0xa5/0x610 [ 488.509723] ? entry_SYSCALL_64_after_hwframe+0x118/0x168 [ 488.511292] ? entry_SYSCALL_64_after_hwframe+0x111/0x168 [ 488.512853] ? entry_SYSCALL_64_after_hwframe+0x10a/0x168 [ 488.514405] ? entry_SYSCALL_64_after_hwframe+0x103/0x168 [ 488.515956] ? entry_SYSCALL_64_after_hwframe+0xfc/0x168 [ 488.517499] ? entry_SYSCALL_64_after_hwframe+0xf5/0x168 [ 488.519040] ? entry_SYSCALL_64_after_hwframe+0xee/0x168 [ 488.520572] ? entry_SYSCALL_64_after_hwframe+0xe7/0x168 [ 488.522095] ? entry_SYSCALL_64_after_hwframe+0xe0/0x168 [ 488.523598] SyS_ioctl+0x79/0x90 [ 488.525088] ? entry_SYSCALL_64_after_hwframe+0xa1/0x168 [ 488.526579] entry_SYSCALL_64_fastpath+0x33/0xa3 [ 488.528065] RIP: 0033:0x7fdc7fb65ef7 [ 488.529553] RSP: 002b:00007ffd23064578 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 [ 488.531081] RAX: ffffffffffffffda RBX: 00007ffd230645c0 RCX: 00007fdc7fb65ef7 [ 488.532581] RDX: 00007ffd230645c0 RSI: 0000000040086464 RDI: 000000000000000c [ 488.534078] RBP: 00007ffd230645c0 R08: 0000000000000000 R09: 0000000800000000 [ 488.535556] R10: 00007ffd230645d0 R11: 0000000000000246 R12: 0000000040086464 [ 488.537031] R13: 000000000000000c R14: 00007ffd230646e8 R15: 000055d8a7b62200 [ 488.538511] Code: 48 85 c0 49 89 04 24 74 62 8d 53 ff 48 8d 3c 95 04 00 00 00 31 d2 eb 04 49 8b 04 24 49 8b 76 08 41 8d 4f 01 45 89 ff 4a 8d 34 be <8b> 36 89 34 10 41 23 4e 54 48 83 c2 04 48 39 d7 41 89 cf 75 d8 [ 488.541900] RIP: radeon_ring_backup+0xd3/0x140 [radeon] RSP: ffffb402c3727c00 [ 488.543656] CR2: ffffb406c1891ffc [ 488.552481] ---[ end trace e6e07e03d7738a24 ]--- Various versions of this crash seem to be have been reported over the last few years but none successfully closed. For further diagnostics see https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1746232 Roger -- You are receiving this mail because: You are watching the assignee of the bug.

1 18

[GIT PULL] drm/imx: update image-convert with fixes for multi-tiled scaling
by Philipp Zabel 03 Dec '18

03 Dec '18

Hi Dave, please consider merging this update for the ipu-v3 mem2mem image conversion code together with a few small cleanups and fixes. regards Philipp The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a: Linux 4.20-rc1 (2018-11-04 15:37:52 -0800) are available in the Git repository at: git://git.pengutronix.de/git/pza/linux.git tags/imx-drm-next-2018-12-03 for you to fetch changes up to 97c78f4d07e5033717c08b650462b3087ecfe8e8: drm/imx: ipuv3-plane: add IDMAC timeout warning (2018-11-05 14:56:04 +0100) ---------------------------------------------------------------- drm/imx: update image-convert with fixes for multi-tiled scaling Update the ipu-v3 mem2mem image-convert code, with some fixes for race conditions, alignment issues, and visual artifacts due to tile alignment and scaling factor issues when scaling images larger than hardware limitations in multiple tiles. This will allow the V4L2 mem2mem scaler driver to write output images larger than 1024x1024 pixels. Also switch drm/imx source files to SPDX license identifiers, constify struct clk_ops in imx-tve, and add a timeout warning to the busy wait in ipu_plane_disable(). ---------------------------------------------------------------- Fabio Estevam (1): drm/imx: Switch to SPDX identifier Julia Lawall (1): drm/imx: imx-tve: constify clk_ops structure Philipp Zabel (15): gpu: ipu-v3: ipu-ic: allow to manually set resize coefficients gpu: ipu-v3: image-convert: prepare for per-tile configuration gpu: ipu-v3: image-convert: calculate per-tile resize coefficients gpu: ipu-v3: image-convert: reconfigure IC per tile gpu: ipu-v3: image-convert: store tile top/left position gpu: ipu-v3: image-convert: calculate tile dimensions and offsets outside fill_image gpu: ipu-v3: image-convert: move tile alignment helpers gpu: ipu-v3: image-convert: select optimal seam positions gpu: ipu-v3: image-convert: fix debug output for varying tile sizes gpu: ipu-v3: image-convert: relax alignment restrictions gpu: ipu-v3: image-convert: fix bytesperline adjustment gpu: ipu-v3: image-convert: add some ASCII art to the exposition gpu: ipu-v3: image-convert: disable double buffering if necessary gpu: ipu-v3: image-convert: allow three rows or columns drm/imx: ipuv3-plane: add IDMAC timeout warning Steve Longerbeam (7): gpu: ipu-cpmem: add WARN_ON_ONCE() for unaligned dma buffers gpu: ipu-v3: Add chroma plane offset overrides to ipu_cpmem_set_image() gpu: ipu-v3: image-convert: Prevent race between run and unprepare gpu: ipu-v3: image-convert: Only wait for abort completion if active run gpu: ipu-v3: image-convert: Allow reentrancy into abort gpu: ipu-v3: image-convert: Remove need_abort flag gpu: ipu-v3: image-convert: Catch unaligned tile offsets drivers/gpu/drm/imx/dw_hdmi-imx.c | 5 +- drivers/gpu/drm/imx/imx-drm-core.c | 11 +- drivers/gpu/drm/imx/imx-ldb.c | 10 +- drivers/gpu/drm/imx/imx-tve.c | 12 +- drivers/gpu/drm/imx/ipuv3-crtc.c | 10 +- drivers/gpu/drm/imx/ipuv3-plane.c | 18 +- drivers/gpu/drm/imx/parallel-display.c | 10 +- drivers/gpu/ipu-v3/ipu-cpmem.c | 52 +++-- drivers/gpu/ipu-v3/ipu-ic.c | 52 +++-- drivers/gpu/ipu-v3/ipu-image-convert.c | 1019 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------- include/video/imx-ipu-v3.h | 9 + 11 files changed, 940 insertions(+), 268 deletions(-)

1 0

[PATCH v2] drm/meson: Fix an Alpha Primary Plane bug on Meson GXL/GXM SoCs
by Neil Armstrong 03 Dec '18

03 Dec '18

On the Amlogic GXL & GXM SoCs, a bug occurs on the primary plane when alpha is used where the alpha is not aligned with the pixel content. The woraround Amlogic implemented is to reset the OSD1 plane hardware block each time the plane is (re)enabled, solving the issue. In the reset, we still need to save the content of 2 registers which depends on the status of the plane, in addition to reload the scaler conversion matrix at the same time. Signed-off-by: Neil Armstrong <narmstrong(a)baylibre.com> --- Changes since v1 at [1]: - Fix flickering and shaking by moving reset when plane is disabled [1] https://patchwork.freedesktop.org/patch/263550/ drivers/gpu/drm/meson/meson_plane.c | 12 ++++++++++++ drivers/gpu/drm/meson/meson_viu.c | 27 +++++++++++++++++++++++++++ drivers/gpu/drm/meson/meson_viu.h | 1 + 3 files changed, 40 insertions(+) diff --git a/drivers/gpu/drm/meson/meson_plane.c b/drivers/gpu/drm/meson/meson_plane.c index 12a47b4f65a5..8e27f275ece8 100644 --- a/drivers/gpu/drm/meson/meson_plane.c +++ b/drivers/gpu/drm/meson/meson_plane.c @@ -79,6 +79,7 @@ struct meson_plane { struct drm_plane base; struct meson_drm *priv; + bool enabled; }; #define to_meson_plane(x) container_of(x, struct meson_plane, base) @@ -303,6 +304,15 @@ static void meson_plane_atomic_update(struct drm_plane *plane, priv->viu.osd1_stride = fb->pitches[0]; priv->viu.osd1_height = fb->height; + if (!meson_plane->enabled) { + /* Reset OSD1 before enabling it on GXL+ SoCs */ + if (meson_vpu_is_compatible(priv, "amlogic,meson-gxm-vpu") || + meson_vpu_is_compatible(priv, "amlogic,meson-gxl-vpu")) + meson_viu_osd1_reset(priv); + + meson_plane->enabled = true; + } + spin_unlock_irqrestore(&priv->drm->event_lock, flags); } @@ -316,6 +326,8 @@ static void meson_plane_atomic_disable(struct drm_plane *plane, writel_bits_relaxed(VPP_OSD1_POSTBLEND, 0, priv->io_base + _REG(VPP_MISC)); + meson_plane->enabled = false; + } static const struct drm_plane_helper_funcs meson_plane_helper_funcs = { diff --git a/drivers/gpu/drm/meson/meson_viu.c b/drivers/gpu/drm/meson/meson_viu.c index 2dffb987ec65..0ba87ff95530 100644 --- a/drivers/gpu/drm/meson/meson_viu.c +++ b/drivers/gpu/drm/meson/meson_viu.c @@ -296,6 +296,33 @@ static void meson_viu_load_matrix(struct meson_drm *priv) true); } +/* VIU OSD1 Reset as workaround for GXL+ Alpha OSD Bug */ +void meson_viu_osd1_reset(struct meson_drm *priv) +{ + uint32_t osd1_fifo_ctrl_stat, osd1_ctrl_stat2; + + /* Save these 2 registers state */ + osd1_fifo_ctrl_stat = readl_relaxed( + priv->io_base + _REG(VIU_OSD1_FIFO_CTRL_STAT)); + osd1_ctrl_stat2 = readl_relaxed( + priv->io_base + _REG(VIU_OSD1_CTRL_STAT2)); + + /* Reset OSD1 */ + writel_bits_relaxed(BIT(0), BIT(0), + priv->io_base + _REG(VIU_SW_RESET)); + writel_bits_relaxed(BIT(0), 0, + priv->io_base + _REG(VIU_SW_RESET)); + + /* Rewrite these registers state lost in the reset */ + writel_relaxed(osd1_fifo_ctrl_stat, + priv->io_base + _REG(VIU_OSD1_FIFO_CTRL_STAT)); + writel_relaxed(osd1_ctrl_stat2, + priv->io_base + _REG(VIU_OSD1_CTRL_STAT2)); + + /* Reload the conversion matrix */ + meson_viu_load_matrix(priv); +} + void meson_viu_init(struct meson_drm *priv) { uint32_t reg; diff --git a/drivers/gpu/drm/meson/meson_viu.h b/drivers/gpu/drm/meson/meson_viu.h index 073b1910bd1b..0f84bddd2ff0 100644 --- a/drivers/gpu/drm/meson/meson_viu.h +++ b/drivers/gpu/drm/meson/meson_viu.h @@ -59,6 +59,7 @@ #define OSD_REPLACE_EN BIT(14) #define OSD_REPLACE_SHIFT 6 +void meson_viu_osd1_reset(struct meson_drm *priv); void meson_viu_init(struct meson_drm *priv); #endif /* __MESON_VIU_H */ -- 2.19.2

2 2

[Bug 108689] new version of intel_gpu_top lost option of output log to stdio or file
by bugzilla-daemon＠freedesktop.org 03 Dec '18

03 Dec '18

https://bugs.freedesktop.org/show_bug.cgi?id=108689 Tvrtko Ursulin <tvrtko.ursulin(a)linux.intel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|medium |low Severity|major |enhancement Status|NEEDINFO |NEW Whiteboard| |ReadyForDev --- Comment #4 from Tvrtko Ursulin <tvrtko.ursulin(a)linux.intel.com> --- Sorry it slipped from my radar. We could add some form of non-interactive stdio output I guess, shouldn't be too difficult. Will see how it fits against the higher priority work. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH v3] backlight: pwm_bl: Fix brightness levels for non-DT case.
by Enric Balletbo i Serra 03 Dec '18

03 Dec '18

Commit '88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED linearly to human eye")' allows the possibility to compute a default brightness table when there isn't the brightness-levels property in the DT. Unfortunately the changes made broke the pwm backlight for the non-DT boards. Usually, the non-DT boards don't pass the brightness levels via platform data, instead, it sets the max_brightness in their platform data and the driver calculates the level without a table. The offending patch assumed that when there is no brightness levels table we should create one, but this is clearly wrong for the non-DT case. After this patch the code handles the DT and the non-DT case taking in consideration also if max_brightness is set or not. Fixes: 88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED linearly to human eye") Cc: <stable(a)vger.kernel.org> Reported-by: Robert Jarzmik <robert.jarzmik(a)free.fr> Signed-off-by: Enric Balletbo i Serra <enric.balletbo(a)collabora.com> Tested-by: Robert Jarzmik <robert.jarzmik(a)free.fr> Acked-by: Daniel Thompson <daniel.thompson(a)linaro.org> --- Changes in v3: - Fixed some typos in commit message. - Removed ' in Fixes tag. Changes in v2: - Rebase on top of mainline - Add Tested-by and Acked-by tags. drivers/video/backlight/pwm_bl.c | 41 +++++++++++++++++++++++++++----- 1 file changed, 35 insertions(+), 6 deletions(-) diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c index 678b27063198..f9ef0673a083 100644 --- a/drivers/video/backlight/pwm_bl.c +++ b/drivers/video/backlight/pwm_bl.c @@ -562,7 +562,30 @@ static int pwm_backlight_probe(struct platform_device *pdev) goto err_alloc; } - if (!data->levels) { + if (data->levels) { + /* + * For the DT case, only when brightness levels is defined + * data->levels is filled. For the non-DT case, data->levels + * can come from platform data, however is not usual. + */ + for (i = 0; i <= data->max_brightness; i++) { + if (data->levels[i] > pb->scale) + pb->scale = data->levels[i]; + + pb->levels = data->levels; + } + } else if (!data->max_brightness) { + /* + * If no brightness levels are provided and max_brightness is + * not set, use the default brightness table. For the DT case, + * max_brightness is set to 0 when brightness levels is not + * specified. For the non-DT case, max_brightness is usually + * set to some value. + */ + + /* Get the PWM period (in nanoseconds) */ + pwm_get_state(pb->pwm, &state); + ret = pwm_backlight_brightness_default(&pdev->dev, data, state.period); if (ret < 0) { @@ -570,13 +593,19 @@ static int pwm_backlight_probe(struct platform_device *pdev) "failed to setup default brightness table\n"); goto err_alloc; } - } - for (i = 0; i <= data->max_brightness; i++) { - if (data->levels[i] > pb->scale) - pb->scale = data->levels[i]; + for (i = 0; i <= data->max_brightness; i++) { + if (data->levels[i] > pb->scale) + pb->scale = data->levels[i]; - pb->levels = data->levels; + pb->levels = data->levels; + } + } else { + /* + * That only happens for the non-DT case, where platform data + * sets the max_brightness value. + */ + pb->scale = data->max_brightness; } pb->lth_brightness = data->lth_brightness * (state.period / pb->scale); -- 2.19.1

3 2

[PATCH] udlfb: fix potential NULL pointer dereference in dlfb_usb_probe
by Wen Yang 03 Dec '18

03 Dec '18

This patch fixes a possible null pointer dereference in dlfb_usb_probe, detected by the semantic patch deref_null.cocci, with the following warning: drivers/video/fbdev/udlfb.c:1704:11-15: ERROR: dlfb is NULL but dereferenced. The following code has potential null pointer references: 1597 /* usb initialization */ 1598 dlfb = kzalloc(sizeof(*dlfb), GFP_KERNEL); 1599 if (!dlfb) { ... 1601 goto error; 1602 } ... 1703 error: 1704 if (dlfb->info) { 1705 dlfb_ops_destroy(dlfb->info); 1706 } else if (dlfb) { 1707 usb_put_dev(dlfb->udev); 1708 kfree(dlfb); 1709 } Signed-off-by: Wen Yang <wen.yang99(a)zte.com.cn> CC: Bernie Thompson <bernie(a)plugable.com> CC: Bartlomiej Zolnierkiewicz <b.zolnierkie(a)samsung.com> CC: linux-fbdev(a)vger.kernel.org CC: dri-devel(a)lists.freedesktop.org CC: linux-kernel(a)vger.kernel.org --- drivers/video/fbdev/udlfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c index 070026a7e55a..df37cfaa2362 100644 --- a/drivers/video/fbdev/udlfb.c +++ b/drivers/video/fbdev/udlfb.c @@ -1701,7 +1701,7 @@ static int dlfb_usb_probe(struct usb_interface *intf, return 0; error: - if (dlfb->info) { + if (dlfb && dlfb->info) { dlfb_ops_destroy(dlfb->info); } else if (dlfb) { usb_put_dev(dlfb->udev); -- 2.19.1

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel December 2018