dri-devel March 2018

dri-devel@lists.freedesktop.org

263 participants
1856 discussions

[PATCH 0/3] drm/vc4: Improve alpha format plane support
by Stefan Schake 07 Mar '18

07 Mar '18

This series improves the handling of alpha formats with the VC4 HVS compositor. Alpha formats are marked as premultiplied as is standard for DRM. Further fix a display corruption issue when planes with per-pixel alpha try blending from the (nonexistent) background by selectively enabling a black background color fill. This series follows the changes suggested by Eric Anholt in a previous patch discussion: https://patchwork.freedesktop.org/patch/207667/ A simple test program for the display … [View More]

3 9

[PATCH 0/3] Analogix DP fixes for Chromebook2 Peach-Pit (Exynos5420)
by Marek Szyprowski 07 Mar '18

07 Mar '18

Hi! Last week I was asked to comment a patch "[PATCH v3 05/43] drm/bridge: analogix_dp: Don't power bridge in analogix_dp_bind": https://patchwork.kernel.org/patch/10193493/ That patch does almost the opposite to my initial fix "[PATCH v2] drm/bridge: analogix_dp: Keep PHY powered between driver bind/unbind": https://patchwork.kernel.org/patch/10242493/ I did some further investigation based on the proposed "[PATCH v3 00/43] DRM Rockchip rk3399 (Kevin)" patchset: https://lists.freedesktop.… [View More]

3 7

[RFC][PATCH] libdrm: gralloc_handle.h: Fix build issue with Android
by John Stultz 07 Mar '18

07 Mar '18

In trying to integrate the new gralloc_handle.h with the drm_hwcomposer, I started seeing the following compilation errors: In file included from external/drm_hwcomposer/platformdrmgeneric.cpp:28: external/libdrm/android/gralloc_handle.h:108:9: error: cannot initialize return object of type 'native_handle_t *' (aka 'native_handle *') with an lvalue of type 'struct gralloc_handle_t *' return handle; ^~~~~~ 1 error generated. This seems to be due to the … [View More]

2 1

Re: [PATCH v2] Fixing arbitrary kernel leak in case FBIOGETCMAP_SPARC in sbusfb_ioctl_helper().
by Mathieu Malaterre 07 Mar '18

07 Mar '18

Hi Peter, On Wed, Jan 31, 2018 at 3:57 PM, Peter Malone <peter.malone(a)gmail.com> wrote: > Fixing arbitrary kernel leak in case FBIOGETCMAP_SPARC in > sbusfb_ioctl_helper(). > > 'index' is defined as an int in sbusfb_ioctl_helper(). > We retrieve this from the user: > if (get_user(index, &c->index) || > __get_user(count, &c->count) || > __get_user(ured, &c->red) || > __get_user(ugreen, &c->green) || > __get_user(… [View More]

3 3

[Bug 42941] New: Resume from suspend to memory leaves display blank on Lenovo Ideapad U455
by bugzilla-daemon＠bugzilla.kernel.org 07 Mar '18

07 Mar '18

https://bugzilla.kernel.org/show_bug.cgi?id=42941 Summary: Resume from suspend to memory leaves display blank on Lenovo Ideapad U455 Product: Power Management Version: 2.5 Kernel Version: 3.3.0-rc7+ Platform: All OS/Version: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Hibernation/Suspend AssignedTo: power-management_other(a)… [View More]kernel-bugs.osdl.org ReportedBy: e-mail(a)date.by CC: drivers_video-dri(a)kernel-bugs.osdl.org Regression: No Created an attachment (id=72610) --> (https://bugzilla.kernel.org/attachment.cgi?id=72610) dmesg output Hardware: Lenovo Ideapad U455 laptop with AMD Athlon Neo processor and two video cards: Radeon HD 3200 and Radeon HD 4500. Description: when system resumes from suspend to memory (`echo mem > /sys/power/state`) system resumes fine as i can log into it via ssh and display turns on, but the display stays black showing nothing. However it's possible to make display show a picture by switching video cards with vga_switcheroo. Steps to reproduce attached dmesg log (see my comments below): [1]# mount -t debugfs none /sys/kernel/debug [2]# cat /sys/kernel/debug/vgaswitcheroo/switch 0:IGD:+:Pwr:0000:01:05.0 1:DIS: :Pwr:0000:02:00.0 [3]# echo mem > /sys/power/state [4]# cat /sys/kernel/debug/vgaswitcheroo/switch 0:IGD:+:Pwr:0000:01:05.0 1:DIS: :Pwr:0000:02:00.0 [5]# echo DIS > /sys/kernel/debug/vgaswitcheroo/switch [6]# echo IGD > /sys/kernel/debug/vgaswitcheroo/switch [7]# cat /sys/kernel/debug/vgaswitcheroo/switch 0:IGD:+:Pwr:0000:01:05.0 1:DIS: :Off:0000:02:00.0 [8]# echo mem > /sys/power/state [9]# cat /sys/kernel/debug/vgaswitcheroo/switch 0:IGD:+:Pwr:0000:01:05.0 1:DIS: :Off:0000:02:00.0 [10]# echo DIS > /sys/kernel/debug/vgaswitcheroo/switch [11]# echo IGD > /sys/kernel/debug/vgaswitcheroo/switch Comments: [2] This shows the state of the video cards before suspend. [3] Suspend worked fine, but display was blank after resume. [4] This shows the state of the video cards after resume. [5] That command made display to show the picture. [7] This shows the state of the video cards before second suspend, when only IGD card was active. [8] Suspend worked fine, but resume took a lot of time: PM: resume devices took 82.256 seconds ------------[ cut here ]------------ WARNING: at kernel/power/suspend_test.c:53 suspend_test_finish+0x86/0x90() Hardware name: 20046 Component: resume devices, time: 82256 Modules linked in: btusb bluetooth snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device snd_pcm_oss snd_mixer_oss ipv6 ext2 mbcache cpufreq_ondemand powernow_k8 freq_table mperf lp parport_pc parport fuse radeon brcmsmac ttm mac80211 drm_kms_helper joydev snd_hda_codec_hdmi ohci_hcd snd_hda_codec_conexant brcmutil ssb snd_hda_intel drm mmc_core snd_hda_codec sp5100_tco cfg80211 sg ideapad_laptop agpgart psmouse atl1c thermal snd_hwdep processor video crc8 thermal_sys pcmcia snd_pcm snd_timer cordic rtc_cmos pcmcia_core shpchp sparse_keymap evdev ehci_hcd i2c_piix4 snd k8temp i2c_algo_bit bcma rfkill i2c_core serio_raw soundcore snd_page_alloc battery ac hwmon button loop btrfs [last unloaded: pcmcia_rsrc] Pid: 1834, comm: bash Not tainted 3.3.0-rc7+ #36 Call Trace: [<ffffffff8103fe3f>] warn_slowpath_common+0x7f/0xc0 [<ffffffff8103ff36>] warn_slowpath_fmt+0x46/0x50 [<ffffffff8107fc96>] suspend_test_finish+0x86/0x90 [<ffffffff8107f9a1>] suspend_devices_and_enter+0x101/0x1e0 [<ffffffff8107fb51>] enter_state+0xd1/0x110 [<ffffffff8107e4c7>] state_store+0xb7/0x130 [<ffffffff812623cf>] kobj_attr_store+0xf/0x30 [<ffffffff811b0d22>] sysfs_write_file+0xf2/0x180 [<ffffffff81149793>] vfs_write+0xb3/0x180 [<ffffffff81149aba>] sys_write+0x4a/0x90 [<ffffffff8153f829>] system_call_fastpath+0x16/0x1b ---[ end trace 6802c35567ce73fa ]--- PM: Finishing wakeup. [9] This shows the state of the video cards after second resume. [10] That command turned display off and that's what appeared in dmesg output: radeon: switched on radeon 0000:02:00.0: enabling device (0000 -> 0003) radeon 0000:02:00.0: Wait for MC idle timedout ! radeon 0000:02:00.0: Wait for MC idle timedout ! [drm] PCIE GART of 512M enabled (table at 0x0000000000040000). radeon 0000:02:00.0: WB enabled [drm] fence driver on ring 0 use gpu addr 0x20000c00 and cpu addr 0xffff8800a4523c00 [drm:r600_ring_test] *ERROR* radeon: ring 0 test failed (scratch(0x8500)=0xFFFFFFFF) [drm:rv770_resume] *ERROR* r600 startup failed on resume fbcon: Remapping primary device, fb1, to tty 1-63 radeon: switched off [11] That command made display to show the picture. Notes: * I have read Documentation/power/basic-pm-debugging.txt and made all described tests and all of them were successful. * I have tried different quirks with `pm-suspend --quirk-*`, but none of them helped. -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching someone on the CC list of the bug. [View Less]

1 3

[Bug 105359] kms_frontbuffer_tracking - FBC disabled
by bugzilla-daemon＠freedesktop.org 07 Mar '18

07 Mar '18

https://bugs.freedesktop.org/show_bug.cgi?id=105359 --- Comment #6 from Marta Löfstedt <marta.lofstedt(a)intel.com> --- I now found this to be even stranger than anticipated: checking the i915_FBC_state while running kms tests I have ended up way to many states for this to be sane: After reboot: FBC enabled Compressing: yes after killing lightdm: FBC disabled: framebuffer not tiled or fenced after running some kms tests: FBC disabled: frontbuffer write or FBC disabled: no suitable … [View More]

1 0

[PATCH] drm/mali-dp: Fix malidp_atomic_commit_hw_done() for event sending.
by Liviu Dudau 07 Mar '18

07 Mar '18

Mali DP hardware has a 'go' bit (config_valid) for making the new scene parameters active at the next page flip. The problem with the current code is that the driver first sets this bit and then proceeds to wait for confirmation from the hardware that the configuration has been updated before arming the vblank event. As config_valid is actually asserted by the hardware after the vblank event, during the prefetch phase, when we get to arming the vblank event we are going to send it at the next … [View More]vblank, in effect halving the vblank rate from the userspace perspective. Fix it by sending the userspace event from the IRQ handler, when we handle the config_valid interrupt, which syncs with the time when the hardware is active with the new parameters. Reported-by: Alexandru-Cosmin Gheorghe <alexandru-cosmin.gheorghe(a)arm.com> Signed-off-by: Liviu Dudau <liviu.dudau(a)arm.com> --- drivers/gpu/drm/arm/malidp_drv.c | 27 ++++++++++++--------------- drivers/gpu/drm/arm/malidp_drv.h | 1 + drivers/gpu/drm/arm/malidp_hw.c | 12 +++++++++--- 3 files changed, 22 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c index d88a3b9d59cc..7be5d48eefd0 100644 --- a/drivers/gpu/drm/arm/malidp_drv.c +++ b/drivers/gpu/drm/arm/malidp_drv.c @@ -185,27 +185,26 @@ static int malidp_set_and_wait_config_valid(struct drm_device *drm) static void malidp_atomic_commit_hw_done(struct drm_atomic_state *state) { - struct drm_pending_vblank_event *event; struct drm_device *drm = state->dev; struct malidp_drm *malidp = drm->dev_private; + malidp->event = malidp->crtc.state->event; + malidp->crtc.state->event = NULL; + + /* + * if we have an event to deliver to userspace, make sure + * the vblank is enabled as we are sending it from the IRQ + * handler. + */ + if (malidp->event) + drm_crtc_vblank_get(&malidp->crtc); + if (malidp->crtc.enabled) { /* only set config_valid if the CRTC is enabled */ - if (malidp_set_and_wait_config_valid(drm)) + if (malidp_set_and_wait_config_valid(drm) < 0) DRM_DEBUG_DRIVER("timed out waiting for updated configuration\n"); } - event = malidp->crtc.state->event; - if (event) { - malidp->crtc.state->event = NULL; - - spin_lock_irq(&drm->event_lock); - if (drm_crtc_vblank_get(&malidp->crtc) == 0) - drm_crtc_arm_vblank_event(&malidp->crtc, event); - else - drm_crtc_send_vblank_event(&malidp->crtc, event); - spin_unlock_irq(&drm->event_lock); - } drm_atomic_helper_commit_hw_done(state); } @@ -232,8 +231,6 @@ static void malidp_atomic_commit_tail(struct drm_atomic_state *state) malidp_atomic_commit_hw_done(state); - drm_atomic_helper_wait_for_vblanks(drm, state); - pm_runtime_put(drm->dev); drm_atomic_helper_cleanup_planes(drm, state); diff --git a/drivers/gpu/drm/arm/malidp_drv.h b/drivers/gpu/drm/arm/malidp_drv.h index e0d12c9fc6b8..c2375bb49619 100644 --- a/drivers/gpu/drm/arm/malidp_drv.h +++ b/drivers/gpu/drm/arm/malidp_drv.h @@ -22,6 +22,7 @@ struct malidp_drm { struct malidp_hw_device *dev; struct drm_crtc crtc; wait_queue_head_t wq; + struct drm_pending_vblank_event *event; atomic_t config_valid; u32 core_id; }; diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_hw.c index 2bfb542135ac..8abd335ec313 100644 --- a/drivers/gpu/drm/arm/malidp_hw.c +++ b/drivers/gpu/drm/arm/malidp_hw.c @@ -782,9 +782,15 @@ static irqreturn_t malidp_de_irq(int irq, void *arg) /* first handle the config valid IRQ */ dc_status = malidp_hw_read(hwdev, hw->map.dc_base + MALIDP_REG_STATUS); if (dc_status & hw->map.dc_irq_map.vsync_irq) { - /* we have a page flip event */ - atomic_set(&malidp->config_valid, 1); malidp_hw_clear_irq(hwdev, MALIDP_DC_BLOCK, dc_status); + /* do we have a page flip event? */ + if (malidp->event != NULL) { + spin_lock(&drm->event_lock); + drm_crtc_send_vblank_event(&malidp->crtc, malidp->event); + malidp->event = NULL; + spin_unlock(&drm->event_lock); + } + atomic_set(&malidp->config_valid, 1); ret = IRQ_WAKE_THREAD; } @@ -794,7 +800,7 @@ static irqreturn_t malidp_de_irq(int irq, void *arg) mask = malidp_hw_read(hwdev, MALIDP_REG_MASKIRQ); status &= mask; - if (status & de->vsync_irq) + if ((status & de->vsync_irq) && malidp->crtc.enabled) drm_crtc_handle_vblank(&malidp->crtc); malidp_hw_clear_irq(hwdev, MALIDP_DE_BLOCK, status); -- 2.16.2 [View Less]

2 3

[Bug 105324] R9 285 weston hangs since drm/amd/pp: Fix bug that dpm level was not really locked
by bugzilla-daemon＠freedesktop.org 07 Mar '18

07 Mar '18

https://bugs.freedesktop.org/show_bug.cgi?id=105324 Bug ID: 105324 Summary: R9 285 weston hangs since drm/amd/pp: Fix bug that dpm level was not really locked Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: adf.lists(a)… [View More]

1 1

[PULL] drm-misc-fixes
by Gustavo Padovan 07 Mar '18

07 Mar '18

Hi Dave, Only a few sun4i fixes this week. Please pull. Regards, Gustavo drm-misc-fixes-2018-03-07: sun4i fixes on clk, division by zero and LVDS. The following changes since commit 9a191b114906457c4b2494c474f58ae4142d4e67: virtio-gpu: fix ioctl and expose the fixed status to userspace. (2018-02-27 08:37:58 +0100) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-fixes-2018-03-07 for you to fetch changes up to … [View More]

1 0

[Bug 57496] Artefacts when playing OpenGL games
by bugzilla-daemon＠freedesktop.org 07 Mar '18

07 Mar '18

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel March 2018