dri-devel March 2018

dri-devel@lists.freedesktop.org

263 participants
1856 discussions

[PATCH] drm/rockchip: vop: Init vskiplines in scl_vop_cal_scale()
by Jeffy Chen 01 Mar '18

01 Mar '18

Currently we are calling scl_vop_cal_scale() to get vskiplines for yrgb and cbcr. So the cbcr's vskiplines might be an unexpected value if the second scl_vop_cal_scale() didn't update it. Init vskiplines in scl_vop_cal_scale() to avoid that. Signed-off-by: Jeffy Chen <jeffy.chen(a)rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 7715853ef90a..9b03c51903ab 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -259,6 +259,9 @@ static uint16_t scl_vop_cal_scale(enum scale_mode mode, uint32_t src, { uint16_t val = 1 << SCL_FT_DEFAULT_FIXPOINT_SHIFT; + if (vskiplines) + *vskiplines = 0; + if (is_horizontal) { if (mode == SCALE_UP) val = GET_SCL_FT_BIC(src, dst); @@ -299,7 +302,7 @@ static void scl_vop_cal_scl_fac(struct vop *vop, const struct vop_win_data *win, uint16_t vsu_mode; uint16_t lb_mode; uint32_t val; - int vskiplines = 0; + int vskiplines; if (dst_w > 3840) { DRM_DEV_ERROR(vop->dev, "Maximum dst width (3840) exceeded\n"); -- 2.11.0

3 2

[PATCH v2] drm/panel: simple: Add TVC S9700RTWV43TR-01B 800x480 panel support
by Jyri Sarha 01 Mar '18

01 Mar '18

Add support for TVC S9700RTWV43TR-01B 800x480 panel found on TI's AM335X-EVM. Signed-off-by: Jyri Sarha <jsarha(a)ti.com> Reviewed-by: Tomi Valkeinen <tomi.valkeinen(a)ti.com> --- The only change is added "Reviewed-by: Tomi Valkeinen <tomi.valkeinen(a)ti.com>". Who is going to pick this up? The first version of the patch can be found here: https://lists.freedesktop.org/archives/dri-devel/2018-February/166902.html drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 5591984..3b0ba9f 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1962,6 +1962,29 @@ static const struct panel_desc tpk_f10a_0102 = { }, }; +static const struct drm_display_mode tvc_s9700rtwv43tr_01b_mode = { + .clock = 3000, + .hdisplay = 800, + .hsync_start = 800 + 39, + .hsync_end = 800 + 39 + 47, + .htotal = 800 + 39 + 47 + 39, + .vdisplay = 480, + .vsync_start = 480 + 13, + .vsync_end = 480 + 13 + 2, + .vtotal = 480 + 13 + 2 + 29, + .vrefresh = 62, +}; + +static const struct panel_desc tvc_s9700rtwv43tr_01b = { + .modes = &tvc_s9700rtwv43tr_01b_mode, + .num_modes = 1, + .bpc = 8, + .size = { + .width = 155, + .height = 90, + }, +}; + static const struct display_timing urt_umsh_8596md_timing = { .pixelclock = { 33260000, 33260000, 33260000 }, .hactive = { 800, 800, 800 }, @@ -2214,6 +2237,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "tpk,f10a-0102", .data = &tpk_f10a_0102, }, { + .compatible = "tvc,s9700rtwv43tr-01b", + .data = &tvc_s9700rtwv43tr_01b, + }, { .compatible = "urt,umsh-8596md-t", .data = &urt_umsh_8596md_parallel, }, { -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

3 3

[PATCH] drm/sun4i: Fix dclk_set_phase
by Giulio Benetti 01 Mar '18

01 Mar '18

Phase value is not shifted before writing. Shift left of 28 bits to fit right bits Signed-off-by: Giulio Benetti <giulio.benetti(a)micronovasrl.com> --- drivers/gpu/drm/sun4i/sun4i_dotclock.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_dotclock.c b/drivers/gpu/drm/sun4i/sun4i_dotclock.c index 023f39b..e36004f 100644 --- a/drivers/gpu/drm/sun4i/sun4i_dotclock.c +++ b/drivers/gpu/drm/sun4i/sun4i_dotclock.c @@ -132,10 +132,13 @@ static int sun4i_dclk_get_phase(struct clk_hw *hw) static int sun4i_dclk_set_phase(struct clk_hw *hw, int degrees) { struct sun4i_dclk *dclk = hw_to_dclk(hw); + u32 val = degrees / 120; + + val <<= 28; regmap_update_bits(dclk->regmap, SUN4I_TCON0_IO_POL_REG, GENMASK(29, 28), - degrees / 120); + val); return 0; } -- 2.7.4

2 1

UBSAN warning in nouveau_bios.c:1528:8
by Meelis Roos 01 Mar '18

01 Mar '18

This is the first time I have tried UBSAN on this specific machine (onboard nforce 420 with HP BIOS on Nance mainboard). nouveau seems to be working fine but gives this UBSAN warning: [ 7.953957] nouveau 0000:00:0d.0: NVIDIA C61 (04c000a2) [ 7.965101] nouveau 0000:00:0d.0: bios: version 05.61.32.25.02 [ 7.966141] nouveau 0000:00:0d.0: fb: 128 MiB of unknown memory type [ 8.015336] [TTM] Zone kernel: Available graphics memory: 952564 kiB [ 8.015339] [TTM] Initializing pool allocator [ 8.015344] [TTM] Initializing DMA pool allocator [ 8.015370] nouveau 0000:00:0d.0: DRM: VRAM: 125 MiB [ 8.015372] nouveau 0000:00:0d.0: DRM: GART: 512 MiB [ 8.015377] nouveau 0000:00:0d.0: DRM: TMDS table version 1.1 [ 8.015379] nouveau 0000:00:0d.0: DRM: DCB version 3.0 [ 8.015382] nouveau 0000:00:0d.0: DRM: DCB outp 00: 01000310 00000023 [ 8.015385] nouveau 0000:00:0d.0: DRM: DCB outp 01: 00110204 98830003 [ 8.015386] ================================================================================ [ 8.015423] UBSAN: Undefined behaviour in drivers/gpu/drm/nouveau/nouveau_bios.c:1528:8 [ 8.015455] shift exponent -1 is negative [ 8.015482] CPU: 1 PID: 148 Comm: systemd-udevd Not tainted 4.16.0-rc3-00167-g97ace515f014 #1 [ 8.015483] Hardware name: HP-Pavilion RT589AA-ABU t3709.uk/Nance, BIOS 5.02 11/26/2006 [ 8.015485] Call Trace: [ 8.015496] dump_stack+0x5a/0x99 [ 8.015500] ubsan_epilogue+0x9/0x40 [ 8.015503] __ubsan_handle_shift_out_of_bounds+0x124/0x160 [ 8.015506] ? _dev_info+0x67/0x90 [ 8.015509] ? dev_printk_emit+0x49/0x70 [ 8.015632] parse_dcb_entry+0x91e/0xd90 [nouveau] [ 8.015712] ? parse_bit_M_tbl_entry+0x150/0x150 [nouveau] [ 8.015791] olddcb_outp_foreach+0x66/0xa0 [nouveau] [ 8.015870] nouveau_bios_init+0x23a/0x2250 [nouveau] [ 8.015950] ? nouveau_ttm_init+0x3a4/0x710 [nouveau] [ 8.016029] nouveau_drm_load+0x229/0xf10 [nouveau] [ 8.016033] ? sysfs_do_create_link_sd+0xa6/0x170 [ 8.016067] drm_dev_register+0x1b7/0x330 [drm] [ 8.016070] ? pci_enable_device_flags+0x160/0x1f0 [ 8.016091] drm_get_pci_dev+0xee/0x2e0 [drm] [ 8.016172] nouveau_drm_probe+0x1dd/0x270 [nouveau] [ 8.016175] pci_device_probe+0x113/0x1d0 [ 8.016178] driver_probe_device+0x375/0x720 [ 8.016180] __driver_attach+0xeb/0x150 [ 8.016181] ? driver_probe_device+0x720/0x720 [ 8.016183] bus_for_each_dev+0x84/0xe0 [ 8.016186] bus_add_driver+0x19f/0x340 [ 8.016188] driver_register+0x67/0x110 [ 8.016190] ? 0xffffffffc0cfb000 [ 8.016193] do_one_initcall+0x66/0x210 [ 8.016197] do_init_module+0xa7/0x2a9 [ 8.016199] load_module+0x2548/0x3d30 [ 8.016202] ? __symbol_put+0x60/0x60 [ 8.016205] ? kernel_read_file+0x21b/0x390 [ 8.016208] ? kernel_read_file_from_fd+0x52/0x90 [ 8.016210] SYSC_finit_module+0x124/0x150 [ 8.016212] do_syscall_64+0x7a/0x1f0 [ 8.016214] ? page_fault+0x2f/0x50 [ 8.016217] entry_SYSCALL_64_after_hwframe+0x3d/0xa2 [ 8.016219] RIP: 0033:0x7f2e47b82e19 [ 8.016220] RSP: 002b:00007ffdcdc157b8 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 [ 8.016223] RAX: ffffffffffffffda RBX: 00005638b23c7250 RCX: 00007f2e47b82e19 [ 8.016224] RDX: 0000000000000000 RSI: 00007f2e4788d0ed RDI: 0000000000000019 [ 8.016225] RBP: 00007f2e4788d0ed R08: 0000000000000000 R09: 0000000000000000 [ 8.016226] R10: 0000000000000019 R11: 0000000000000246 R12: 0000000000000000 [ 8.016227] R13: 00005638b23c2ce0 R14: 0000000000020000 R15: 00005638b23c7250 [ 8.016228] ================================================================================ [ 8.016299] nouveau 0000:00:0d.0: DRM: DCB conn 00: 0000 [ 8.016301] nouveau 0000:00:0d.0: DRM: DCB conn 01: 1131 [ 8.016302] nouveau 0000:00:0d.0: DRM: DCB conn 02: 0110 [ 8.016304] nouveau 0000:00:0d.0: DRM: DCB conn 03: 0111 [ 8.016305] nouveau 0000:00:0d.0: DRM: DCB conn 04: 0113 [ 8.016626] nouveau 0000:00:0d.0: DRM: Saving VGA fonts [ 8.052781] nouveau 0000:00:0d.0: DRM: DCB type 4 not known [ 8.052784] nouveau 0000:00:0d.0: DRM: Unknown-1 has no encoders, removing [ 8.053728] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [ 8.053729] [drm] Driver supports precise vblank timestamp query. [ 8.055836] nouveau 0000:00:0d.0: DRM: MM: using M2MF for buffer copies [ 8.084488] nouveau 0000:00:0d.0: DRM: allocated 1280x1024 fb: 0x9000, bo 0000000050f4b5d0 [ 8.084678] fbcon: nouveaufb (fb0) is primary device [ 8.193959] Console: switching to colour frame buffer device 160x64 [ 8.195378] nouveau 0000:00:0d.0: fb0: nouveaufb frame buffer device [ 8.212083] [drm] Initialized nouveau 1.3.1 20120801 for 0000:00:0d.0 on minor 0 -- Meelis Roos (mroos(a)linux.ee)

1 0

[PATCH] drm/sun4i: link in front-end code if needed
by Arnd Bergmann 01 Mar '18

01 Mar '18

When the base sun4i DRM driver is built-in but the back-end is a loadable module, we run into a link error: drivers/gpu/drm/sun4i/sun4i_drv.o: In function `sun4i_drv_probe': sun4i_drv.c:(.text+0x60c): undefined reference to `sun4i_frontend_of_table' The dependency is a bit tricky, the best workaround I have come up with is to use a Makefile hack to to interpret both CONFIG_DRM_SUN4I_BACKEND=m and CONFIG_DRM_SUN4I_BACKEND=y as a directive to build the front-end the same way as the main module. Fixes: dd0421f47505 ("drm/sun4i: Add a driver for the display frontend") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- drivers/gpu/drm/sun4i/Makefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/Makefile b/drivers/gpu/drm/sun4i/Makefile index 582607c0c488..db14e023256b 100644 --- a/drivers/gpu/drm/sun4i/Makefile +++ b/drivers/gpu/drm/sun4i/Makefile @@ -25,6 +25,9 @@ obj-$(CONFIG_DRM_SUN4I) += sun4i-tcon.o obj-$(CONFIG_DRM_SUN4I) += sun4i_tv.o obj-$(CONFIG_DRM_SUN4I) += sun6i_drc.o -obj-$(CONFIG_DRM_SUN4I_BACKEND) += sun4i-backend.o sun4i-frontend.o +obj-$(CONFIG_DRM_SUN4I_BACKEND) += sun4i-backend.o +ifdef CONFIG_DRM_SUN4I_BACKEND +obj-$(CONFIG_DRM_SUN4I) += sun4i-frontend.o +endif obj-$(CONFIG_DRM_SUN4I_HDMI) += sun4i-drm-hdmi.o obj-$(CONFIG_DRM_SUN8I_MIXER) += sun8i-mixer.o -- 2.9.0

3 5

[PULL] drm-intel-fixes
by Rodrigo Vivi 01 Mar '18

01 Mar '18

Hi Dave, I have these same patches stashed since last week, but last week I wasn't confident that CI was happy with these ones so I decided to hold on. Now after running multiple times with and without the patches applied I see that it was only a fix on test case, which is now catching old bugs So I'm now convinced that these patches here are good to go. And no new fix this week. Here goes drm-intel-fixes-2018-02-28: - 2 display fixes: audio av_enc_map overflow check, and Cannonlake PLL related register offset. - 3 gem fixes: Clear for in-fence out-fence, fix for clearing exec_flags on execbuf failure, and add back global seqno to tracepoints that had been removed recently by other fence related patch. Thanks, Rodrigo. The following changes since commit 4a3928c6f8a53fa1aed28ccba227742486e8ddcb: Linux 4.16-rc3 (2018-02-25 18:50:41 -0800) are available in the git repository at: git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2018-02-28 for you to fetch changes up to fa89782b4f9c40d40e3f7d9ad7ef14e0bb0c3ca0: drm/i915: Make global seqno known in i915_gem_request_execute tracepoint (2018-02-28 11:10:48 -0800) ---------------------------------------------------------------- - 2 display fixes: audio av_enc_map overflow check, and Cannonlake PLL related register offset. - 3 gem fixes: Clear for in-fence out-fence, fix for clearing exec_flags on execbuf failure, and add back global seqno to tracepoints that had been removed recently by other fence related patch. ---------------------------------------------------------------- Chris Wilson (1): drm/i915: Clear the in-use marker on execbuf failure Daniele Ceraolo Spurio (1): drm/i915: Fix rsvd2 mask when out-fence is returned Jani Nikula (1): drm/i915/audio: fix check for av_enc_map overflow Mahesh Kumar (1): drm/i915/cnl: Fix PORT_TX_DW5/7 register address Tvrtko Ursulin (1): drm/i915: Make global seqno known in i915_gem_request_execute tracepoint drivers/gpu/drm/i915/i915_gem_execbuffer.c | 4 +++- drivers/gpu/drm/i915/i915_gem_request.c | 4 ++-- drivers/gpu/drm/i915/i915_reg.h | 4 ++-- drivers/gpu/drm/i915/intel_audio.c | 6 +++--- 4 files changed, 10 insertions(+), 8 deletions(-)

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel March 2018