4.9-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dhinakaran Pandiyan <dhinakaran.pandiyan(a)intel.com>
commit bdcc02cf1bb508fc700df7662f55058f651f2621 upstream.
Entry corresponding to 220 us setup time was missing. I am not aware of
any specific bug this fixes, but this could potentially result in enabling
PSR on a panel with a higher setup time requirement than supported by the
hardware.
I verified the value is present in eDP spec …
[View More]versions 1.3, 1.4 and 1.4a.
Fixes: 6608804b3d7f ("drm/dp: Add drm_dp_psr_setup_time()")
Cc: stable(a)vger.kernel.org
Cc: Ville Syrjälä <ville.syrjala(a)linux.intel.com>
Cc: Jose Roberto de Souza <jose.souza(a)intel.com>
Cc: dri-devel(a)lists.freedesktop.org
Reviewed-by: José Roberto de Souza <jose.souza(a)intel.com>
Reviewed-by: Tarun Vyas <tarun.vyas(a)intel.com>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan(a)intel.com>
Signed-off-by: Jani Nikula <jani.nikula(a)intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180511195145.3829-3-dhinaka…
Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
---
drivers/gpu/drm/drm_dp_helper.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -1065,6 +1065,7 @@ int drm_dp_psr_setup_time(const u8 psr_c
static const u16 psr_setup_time_us[] = {
PSR_SETUP_TIME(330),
PSR_SETUP_TIME(275),
+ PSR_SETUP_TIME(220),
PSR_SETUP_TIME(165),
PSR_SETUP_TIME(110),
PSR_SETUP_TIME(55),
[View Less]
match_string() returns the index of an array for a matching string,
which can be used instead of open coded variant.
Cc: Ben Skeggs <bskeggs(a)redhat.com>
Cc: David Airlie <airlied(a)linux.ie>
Cc: dri-devel(a)lists.freedesktop.org
Cc: nouveau(a)lists.freedesktop.org
Signed-off-by: Yisheng Xie <xieyisheng1(a)huawei.com>
---
v2:
- handle err case before normal case - per Andy
drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 …
[View More]deletions(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
index 6d99f11..67ba2ac 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
@@ -644,16 +644,13 @@ static int nv17_tv_create_resources(struct drm_encoder *encoder,
int i;
if (nouveau_tv_norm) {
- for (i = 0; i < num_tv_norms; i++) {
- if (!strcmp(nv17_tv_norm_names[i], nouveau_tv_norm)) {
- tv_enc->tv_norm = i;
- break;
- }
- }
-
- if (i == num_tv_norms)
+ i = match_string(nv17_tv_norm_names,
+ num_tv_norms, nouveau_tv_norm);
+ if (i < 0)
NV_WARN(drm, "Invalid TV norm setting \"%s\"\n",
nouveau_tv_norm);
+ else
+ tv_enc->tv_norm = i;
}
drm_mode_create_tv_properties(dev, num_tv_norms, nv17_tv_norm_names);
--
1.7.12.4
[View Less]
Adopt the SPDX license identifier headers to ease license compliance
management.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo(a)collabora.com>
---
drivers/gpu/drm/bridge/analogix-anx78xx.c | 24 ++++++++---------------
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix-anx78xx.c
index b49043866be6..54d7e7981bed 100644
--- a/drivers/gpu/drm/bridge/analogix-anx78xx.c
+++ b/drivers/gpu/drm/…
[View More]bridge/analogix-anx78xx.c
@@ -1,19 +1,11 @@
-/*
- * Copyright(c) 2016, Analogix Semiconductor.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 and
- * only version 2 as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * Based on anx7808 driver obtained from chromeos with copyright:
- * Copyright(c) 2013, Google Inc.
- *
- */
+// SPDX-License-Identifier: GPL-2.0
+// Driver for ANX78xx SlimPort transmitter.
+//
+// Copyright (C) 2016 Analogix Semiconductor.
+// Copyright (C) 2016 Google, Inc.
+//
+// Author: Enric Balletbo i Serra <enric.balletbo(a)collabora.com>
+
#include <linux/delay.h>
#include <linux/err.h>
#include <linux/interrupt.h>
--
2.17.1
[View Less]
https://bugs.freedesktop.org/show_bug.cgi?id=106589
Bug ID: 106589
Summary: HP w2207 monitor not waking from sleep
Product: DRI
Version: unspecified
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
Severity: normal
Priority: medium
Component: DRM/AMDgpu
Assignee: dri-devel(a)lists.freedesktop.org
Reporter: tseewald(a)gmail.com
Created attachment 139653
--&…
[View More]gt; https://bugs.freedesktop.org/attachment.cgi?id=139653&action=edit
dmesg on 4.17-rc6
Problem:
After allowing both of my monitors to go to sleep, my HP w2207 is no longer
detected as being connected to the computer, and cannot be woken up. Its
display cable must be removed and reinserted into my AMD gpu for it to be
detected.
Expected:
The monitor, like my other samsung, will wake up and the OS will see it as
connected.
Why I think this is possible to fix in software:
The problem does not occur when using my 660Ti with Nvidia's 390.x driver.
Hardware:
GPU: RX 560 4GB
Monitor 1: HP w2207 (Affected)
Monitor 2: Samsung S23A700 (*Not* affected)
I have tried DVI->DVI and DVI->HDMI cables with the HP w2207, no change in
behavior.
The monitor will not wake even when it is the only monitor connected.
I have tested another monitor (an ancient 4:3 dell) in conjunction with the
S23A700, and both wake normally.
Software:
Mesa version: 18.0
X11 version: 1.19.6
Kernel commandline: See attachment for one example (I have tried disabling
amdgpu.dpm and amdgpu.dc to no effect)
EDID: See attachments
Kernel config: see attachments
The only dmesg output before and after the sleep is:
[drm] SADs count is: -2, don't need to read it
[drm] SADs count is: -2, don't need to read it
Kernels tested:
4.16.9
4.16.10
4.17-rc6
amd-drm-staging-next (current as of May 18th 2018)
No changes between any of them.
I also see that the kernel renames the display after a reconnect, I'm not sure
if that is normal either.
e.g.
At boot: card1-HDMI-A-3
After unplugging/replugging: card1-HDMI-A-4
Please let me know what additional information or troubleshooting steps you
would like me to take.
Thanks for your time.
--
You are receiving this mail because:
You are the assignee for the bug.
[View Less]
This is initial version of a6xx support for the Adreno a6xx GPU
family as found on the sdm845 SoC. This code is ahead of most of the rest of
the sdm845 code that would be needed to actually bring up a device and it is
definitely far in advance of any user side support for the a6xx GPU so this is
mainly just a chance to look over the code structure and get a feel for the
direction that the hardware is going in.
The a6xx GPU is an iteration of the a5xx family so most of the GPU side code
looks …
[View More]pretty close to the same except for the usual register differences. The
big different is in power control. On the a5xx there was a rudimentary device
called the GMU that did some basic power stuff but left most of the complexity
to the kernel. On the a6xx the power complexity is being moved to a component
called the GMU (graphics management unit).
This stack has a number of dependencies that are in various stages of being
merged:
https://patchwork.kernel.org/patch/10286375/ - dev_pm_opp_get_of_node()
https://patchwork.kernel.org/patch/10333575/ - command DB
https://patchwork.kernel.org/patch/10301163/ - pm_runtime ops for arm-smmu
[v4 - Add clock parsing helper function and use it for GPU and GMU. Update
recommended clock gating settings. Fix a bug in the CMD DB parser. Update
register values from updated database ]
[v3 - fix inverted register definition for GMU_SPTPRAC_CLK_STATUS; fix incorrect
register check in a5xx_gmu_gx_is_on(), use dev_pm_opp_get_of_node() from
Rajendra and Viresh to read the qcom,level from the device tree; read qcom,level
from the DT to get the voltage level to pass to the GMU, fix issues
identified by smatch]
[v2 - addressed comments from Lucas Stach; added pm_runtime_get_supplier calls
for accesses to the GMU IOMMU; moved to SPDX headers for new files]
*** BLURB HERE ***
Jordan Crouse (2):
drm/msm: Add a helper function to parse clock names
drm/msm: Add A6XX device support
Sharat Masetty (1):
drm/msm: Add generated headers for A6XX
drivers/gpu/drm/msm/Makefile | 3 +
drivers/gpu/drm/msm/adreno/a6xx.xml.h | 1784 ++++++++++++++++++++
drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1174 +++++++++++++
drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 162 ++
drivers/gpu/drm/msm/adreno/a6xx_gmu.xml.h | 382 +++++
drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 807 +++++++++
drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 60 +
drivers/gpu/drm/msm/adreno/a6xx_hfi.c | 435 +++++
drivers/gpu/drm/msm/adreno/a6xx_hfi.h | 127 ++
drivers/gpu/drm/msm/adreno/adreno_device.c | 12 +
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
drivers/gpu/drm/msm/adreno/adreno_gpu.h | 4 +
drivers/gpu/drm/msm/msm_drv.c | 57 +
drivers/gpu/drm/msm/msm_drv.h | 4 +
drivers/gpu/drm/msm/msm_gpu.c | 62 +-
drivers/gpu/drm/msm/msm_gpu.h | 2 +-
16 files changed, 5024 insertions(+), 53 deletions(-)
create mode 100644 drivers/gpu/drm/msm/adreno/a6xx.xml.h
create mode 100644 drivers/gpu/drm/msm/adreno/a6xx_gmu.c
create mode 100644 drivers/gpu/drm/msm/adreno/a6xx_gmu.h
create mode 100644 drivers/gpu/drm/msm/adreno/a6xx_gmu.xml.h
create mode 100644 drivers/gpu/drm/msm/adreno/a6xx_gpu.c
create mode 100644 drivers/gpu/drm/msm/adreno/a6xx_gpu.h
create mode 100644 drivers/gpu/drm/msm/adreno/a6xx_hfi.c
create mode 100644 drivers/gpu/drm/msm/adreno/a6xx_hfi.h
--
2.17.0
[View Less]
https://bugzilla.kernel.org/show_bug.cgi?id=199917
Bug ID: 199917
Summary: Stack dump with amdgpu.dc=1 the instant FreeSync is
enabled in the connected display.
Product: Drivers
Version: 2.5
Kernel Version: 4.17.0-041700-generic
Hardware: All
OS: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: Video(DRI - non Intel)
…
[View More] Assignee: drivers_video-dri(a)kernel-bugs.osdl.org
Reporter: nicholas.johnson(a)outlook.com.au
Regression: No
Created attachment 276315
--> https://bugzilla.kernel.org/attachment.cgi?id=276315&action=edit
dmesg output and the error starts on the line with "Jun 4 13:26" in it
My hardware:
Dell XPS 9370 (i7-8650U, 16GB RAM) - although should be reproducible on any
system with two Thunderbolt 3 ports.
Gigabyte Aorus Thunderbolt Gaming Box external graphics with AMD Radeon R9 Nano
installed - should be reproducible with any R9 Fury (Fiji) series.
VBIOS is UEFI GOP, laptop BIOS up to date
Monitor is Samsung U32E850R with FreeSync support - although any FreeSync
monitor should be sufficient.
4.17 kernel enables amdgpu.dc=1 by default, but on previous kernels, you have
to pass it explicitly.
There is a separate bug with getting the GPU posted when on Thunderbolt - ATOM
BIOS loop. However, trying again with the other Thunderbolt port on the
computer than the one with which you first attempted, works.
Once approved, I can mess around with Xorg conf (seriously, why does Xorg have
to be so difficult?) and get the lightdm / Cinnamon running on the external GPU
with Intel graphics ignored. This is with FreeSync disabled in the monitor
settings. No issues, no errors in dmesg. However, when I enable FreeSync in the
monitor menu, when the video signal returns, dmesg has spewed a barrage of
errors, as attached in the file (starting from the line containing "Jun 4
13:26" - search without quotes. That line was when I first enabled FreeSync.
Passing amdgpu.dc=0 eliminates this particular problem. There are a lot more
problems for AMD to fix, though.
It is unknown of yet if this error is specific to Thunderbolt only, or if it
also happens with the same Radeon GPU installed inside of a desktop. Either
way, the AMDGPU DC is not ready for prime time, and should not have been
enabled by default until tested properly.
--
You are receiving this mail because:
You are watching the assignee of the bug.
[View Less]