dri-devel July 2018

dri-devel@lists.freedesktop.org

277 participants
1883 discussions

[v7 00/13] drm/msm: Capture and dump the GPU crash state
by Jordan Crouse 12 Oct '18

12 Oct '18

This is revision t implementing a GPU crash state for drm/msm (https://patchwork.freedesktop.org/series/36097/). This patchset fixes a few things that the build bot found. The object of this code is to store and provide enough information to debug software and hardware issues on the Adreno hardware in a semi human-readable format that can also be parsed by scripts. THe full set of changes here capture basic information about the GPU, the status and contents of the ringbuffers, a snapshot of the current register state and the active buffers from the hanging submit. The data is printed with devcoredump. For example, after a hang you can get the data from /sys/class/devcoredump/devcdX/data where X is a unique number. v7: Add EXPORT_SYMBOL for __drm_puts_coredump and use %zd to print a size_t variable for the bo dump thanks to the ever vigilant zero one bot. v6: Add drm_puts() and use it in the appropriate place. Clean up a few minor bugs here and there. v5: Fix symbol error in i915_gpu_error.c thanks to 01 dot org bot. Added open/release functions for the show debugfs file to get the state per Chris Wilson. Slightly modified the register output format to be more YAML friendly also per Chris. v4: Add buffer dump for the active submit. Fix refcount issue with devcoredump. Change header for a5xx registers to registers-hlsq because I'm told YAML requires unique tags. v3: Make recommended changes to ascii85 per Chris Wilson. Use devcoredump to dump crash states as suggested by Bjorn Andersson and add a new drm_print facility to facilitate that. Remove the now obsolete 'crash' debugfs node. Add documentation for the crash dump output. v2: Convert output to yaml, use ascii85 to dump ringbuffer contents. Jordan Crouse (13): include: Move ascii85 functions from i915 to linux/ascii85.h drm: drm_printer: Add printer for devcoredump drm: Add drm_puts() to complement drm_printf() drm: Add a -puts() function for the seq_file printer drm: Add put callback for the coredump printer drm/msm/gpu: Capture the state of the GPU drm/msm/gpu: Convert the GPU show function to use the GPU state drm/msm/gpu: Rearrange the code that collects the task during a hang drm/msm/gpu: Capture the GPU state on a GPU hang drm/msm/adreno: Convert the show/crash file format drm/msm/adreno: Add ringbuffer data to the GPU state drm/msm/adreno: Add a5xx specific registers for the GPU state drm/msm/gpu: Add the buffer objects from the submit to the crash dump Documentation/gpu/drm-msm-crash-dump.txt | 58 ++++++ drivers/gpu/drm/drm_print.c | 132 +++++++++++++ drivers/gpu/drm/i915/i915_gpu_error.c | 34 +--- drivers/gpu/drm/msm/Kconfig | 1 + drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 30 +-- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 22 ++- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 242 +++++++++++++++++++++-- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 184 +++++++++++++++-- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 10 +- drivers/gpu/drm/msm/msm_debugfs.c | 93 ++++++++- drivers/gpu/drm/msm/msm_gpu.c | 143 +++++++++++++- drivers/gpu/drm/msm/msm_gpu.h | 67 ++++++- include/drm/drm_print.h | 33 ++++ include/linux/ascii85.h | 39 ++++ 14 files changed, 988 insertions(+), 100 deletions(-) create mode 100644 Documentation/gpu/drm-msm-crash-dump.txt create mode 100644 include/linux/ascii85.h -- 2.17.1

6 29

[Bug 105712] intel-gpu-overlay is showing insane power consumption amounts
by bugzilla-daemon＠freedesktop.org 11 Oct '18

11 Oct '18

https://bugs.freedesktop.org/show_bug.cgi?id=105712 Bug ID: 105712 Summary: intel-gpu-overlay is showing insane power consumption amounts Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: IGT Assignee: dri-devel(a)lists.freedesktop.org Reporter: leozinho29_eu(a)hotmail.com Created attachment 138312 --> https://bugs.freedesktop.org/attachment.cgi?id=138312&action=edit Screenshot showing intel-gpu-overlay in Xnest The program intel-gpu-overlay from intel-gpu-tools is showing very high numbers of power consumption. It is showing values as high as 60 GW of power (60000000000000 mW). Comparing the values to versions that were OK previously (intel-gpu-tools 1.18 shows proper values), it appears that there are many additional numbers that should be in the decimal places, so that 60000000000000 mW would be 6000,0000000000 mW, or 6 W (which, usually, is the maximum I've seen so far). This is happening both with intel-gpu-tools 1.22 and with the latest git (c2ee9077). -- chipset: Intel Core i3-6100U -- system architecture: 64-bit -- xf86-video-intel: 2:2.99.917+git20171229-1 -- xserver: 2:1.19.6-1ubuntu3 -- mesa: 18.1.0-devel (git-903e9952fb) -- libdrm: 2.4.91-2 -- kernel: 4.16.0-rc6 -- Linux distribution: Xubuntu 18.04 (Development branch) -- Machine or mobo model: Lenovo Ideapad 310-14ISK 80UG -- Display connector: eDP and VGA -- You are receiving this mail because: You are the assignee for the bug.

1 12

[Bug 102380] intel_gpu_top: Test requirement not met in function drm_open_driver_master, file drmtest.c:391:
by bugzilla-daemon＠freedesktop.org 11 Oct '18

11 Oct '18

https://bugs.freedesktop.org/show_bug.cgi?id=102380 Bug ID: 102380 Summary: intel_gpu_top: Test requirement not met in function drm_open_driver_master, file drmtest.c:391: Product: DRI Version: unspecified Hardware: All OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: IGT Assignee: dri-devel(a)lists.freedesktop.org Reporter: mqajjhfn(a)10mail.org After upgraded intel_gpu_tools to 19.1 I can't run intel_gpu_top from terminal inside dektop session: Test requirement not met in function drm_open_driver_master, file drmtest.c:391: Test requirement: drmSetMaster(fd) == 0 Can't become DRM master, please check if no other DRM client is running. Last errno: 22, Invalid argument SKIP (-1.000s) It works when switching to different Virtual Console. It worked with 1.16 version I used before. See also: https://bbs.archlinux.org/viewtopic.php?pid=1732114 -- You are receiving this mail because: You are the assignee for the bug.

1 2

[Bug 102401] New: 4.2 RC5
by bugzilla-daemon＠bugzilla.kernel.org 10 Oct '18

10 Oct '18

https://bugzilla.kernel.org/show_bug.cgi?id=102401 Bug ID: 102401 Summary: 4.2 RC5 Product: Drivers Version: 2.5 Kernel Version: Radeon Displayport Audio Warping Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: contrib(a)kliznoe.com Regression: No I'm having issues with Linux 4.2 RC5 with the Displayport audio being deeper then normal. Doesn't seem to happen with 4.1.3 with a backported patch from https://bugzilla.kernel.org/attachment.cgi?id=183611 -- You are receiving this mail because: You are watching the assignee of the bug.

1 20

[Bug 106519] Is it normal that the 4K video on the Vega 56 GPU played with loud turbine noise, 200% load of the desktop Core i7 CPU and at the same time playable with jerks and dropping frames?
by bugzilla-daemon＠freedesktop.org 09 Oct '18

09 Oct '18

https://bugs.freedesktop.org/show_bug.cgi?id=106519 Bug ID: 106519 Summary: Is it normal that the 4K video on the Vega 56 GPU played with loud turbine noise, 200% load of the desktop Core i7 CPU and at the same time playable with jerks and dropping frames? Product: DRI Version: XOrg git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: mikhail.v.gavrilov(a)gmail.com Created attachment 139566 --> https://bugs.freedesktop.org/attachment.cgi?id=139566&action=edit htop and xsensors Is it normal that the 4K video on the Vega 56 GPU played with loud turbine noise, 200% load of the desktop Core i7 CPU and at the same time playable with jerks and dropping frames? $ mpv --hwdec=vaapi Downloads/WE\ GOT\ INTEL\'S\ PROTOTYPE\ GRAPHICS\ CARD.webm Playing: Downloads/WE GOT INTEL'S PROTOTYPE GRAPHICS CARD.webm (+) Video --vid=1 (*) (vp9 3840x2160 29.970fps) Failed to open VDPAU backend libvdpau_nvidia.so: cannot open shared object file: No such file or directory VO: [gpu] 3840x2160 yuv420p V: 00:00:19 / 00:14:44 (2%) Dropped: 24 Exiting... (Quit) -- You are receiving this mail because: You are the assignee for the bug.

1 27

[DPU PATCH] drm/msm/dsi: configure VCO rate for 10nm PLL driver
by Abhinav Kumar 08 Oct '18

08 Oct '18

Currenty the VCO rate in the 10nm PLL driver relies on the parent rate which is not configured. Configure the VCO rate to 19.2 Mhz as required by the 10nm PLL driver. Signed-off-by: Abhinav Kumar <abhinavk(a)codeaurora.org> --- drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c index c4c37a7..fb485cb 100644 --- a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c +++ b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c @@ -39,6 +39,8 @@ #define DSI_PIXEL_PLL_CLK 1 #define NUM_PROVIDED_CLKS 2 +#define VCO_REF_CLK_RATE 19200000 + struct dsi_pll_regs { u32 pll_prop_gain_rate; u32 pll_lockdet_rate; @@ -316,7 +318,7 @@ static int dsi_pll_10nm_vco_set_rate(struct clk_hw *hw, unsigned long rate, parent_rate); pll_10nm->vco_current_rate = rate; - pll_10nm->vco_ref_clk_rate = parent_rate; + pll_10nm->vco_ref_clk_rate = VCO_REF_CLK_RATE; dsi_pll_setup_config(pll_10nm); -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

2 1

[Bug 104289] [regression][vega10] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring sdma0 timeout on exiting Hitman
by bugzilla-daemon＠freedesktop.org 08 Oct '18

08 Oct '18

https://bugs.freedesktop.org/show_bug.cgi?id=104289 Bug ID: 104289 Summary: [regression][vega10] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring sdma0 timeout on exiting Hitman Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: vedran(a)miletic.net Vega 10, amd-staging-drm-next 4021f6f628ee6cd621a22e768f7f3ae94f330790, when exiting Hitman 2016 (but not Xonotic) I get. It's a regression and it's reliably reproducible. [ 5261.568646] WARNING: CPU: 0 PID: 25480 at drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1641 amdgpu_vm_bo_update_mapping+0x3dd/0x3f0 [amdgpu] [ 5261.568648] Modules linked in: rfcomm fuse xt_CHECKSUM ipt_MASQUERADE nf_nat_masquerade_ipv4 tun nf_conntrack_netbios_ns nf_conntrack_broadcast xt_CT ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 xt_conntrack ip_set nfnetlink ebtable_nat ebtable_broute bridge stp llc ip6table_nat nf_conntrack_ipv6 nf_defrag_ipv6 nf_nat_ipv6 ip6table_mangle ip6table_raw ip6table_security iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack devlink libcrc32c iptable_mangle iptable_raw iptable_security ebtable_filter ebtables ip6table_filter ip6_tables cmac bnep sunrpc vfat fat arc4 iwlmvm mac80211 snd_hda_codec_realtek snd_hda_codec_hdmi snd_hda_codec_generic snd_hda_intel iwlwifi snd_hda_codec edac_mce_amd btusb snd_hda_core btrtl btbcm kvm btintel snd_hwdep bluetooth snd_seq irqbypass snd_seq_device [ 5261.568665] cfg80211 crct10dif_pclmul snd_pcm joydev mxm_wmi wmi_bmof crc32_pclmul snd_timer ecdh_generic ghash_clmulni_intel snd rfkill soundcore ccp sp5100_tco pcspkr shpchp i2c_piix4 k10temp wmi acpi_cpufreq binfmt_misc amdgpu chash i2c_algo_bit gpu_sched drm_kms_helper ttm drm crc32c_intel alx hid_holtek_mouse mdio [ 5261.568675] CPU: 0 PID: 25480 Comm: gallium_drv:0 Not tainted 4.15.0-rc2+ #27 [ 5261.568676] Hardware name: Gigabyte Technology Co., Ltd. X399 AORUS Gaming 7/X399 AORUS Gaming 7, BIOS F2 08/31/2017 [ 5261.568676] task: 0000000045d1804c task.stack: 00000000e1257dad [ 5261.568694] RIP: 0010:amdgpu_vm_bo_update_mapping+0x3dd/0x3f0 [amdgpu] [ 5261.568694] RSP: 0018:ffffa3c751d83998 EFLAGS: 00010212 [ 5261.568695] RAX: ffff9875fd962a58 RBX: ffff987a9942e000 RCX: ffff987a73d86550 [ 5261.568695] RDX: ffffa3c744e4e000 RSI: ffff9875fd962a58 RDI: ffff987a73d86560 [ 5261.568696] RBP: ffff987a73d80000 R08: 0000000000000002 R09: 0000000000000000 [ 5261.568696] R10: 0000000000001ffb R11: 0000000000001ff9 R12: 0000000000001b0e [ 5261.568697] R13: ffff987a73d86560 R14: 0000000000101a00 R15: 0000000000000000 [ 5261.568698] FS: 00007fcd9f7fe700(0000) GS:ffff987a9de00000(0000) knlGS:0000000000000000 [ 5261.568698] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 5261.568698] CR2: 00007f2581124010 CR3: 00000008011ad000 CR4: 00000000003406f0 [ 5261.568699] Call Trace: [ 5261.568705] ? _cond_resched+0x15/0x40 [ 5261.568706] ? __ww_mutex_lock.isra.2+0x42/0x640 [ 5261.568721] ? amdgpu_vm_free_mapping.isra.23+0x20/0x20 [amdgpu] [ 5261.568736] amdgpu_vm_clear_freed+0xbb/0x190 [amdgpu] [ 5261.568751] amdgpu_gem_object_close+0x19c/0x210 [amdgpu] [ 5261.568760] ? drm_gem_object_release_handle+0x2c/0x90 [drm] [ 5261.568764] drm_gem_object_release_handle+0x2c/0x90 [drm] [ 5261.568769] ? drm_gem_object_handle_put_unlocked+0xb0/0xb0 [drm] [ 5261.568771] idr_for_each+0x48/0xe0 [ 5261.568776] drm_gem_release+0x1c/0x30 [drm] [ 5261.568780] drm_release+0x342/0x3b0 [drm] [ 5261.568783] __fput+0xcd/0x1d0 [ 5261.568785] task_work_run+0x81/0xa0 [ 5261.568787] do_exit+0x2de/0xba0 [ 5261.568792] ? drm_ioctl_kernel+0x59/0xb0 [drm] [ 5261.568793] do_group_exit+0x3a/0xa0 [ 5261.568794] get_signal+0x26c/0x570 [ 5261.568796] do_signal+0x36/0x610 [ 5261.568798] ? do_vfs_ioctl+0xa1/0x610 [ 5261.568800] ? SyS_futex+0x12d/0x180 [ 5261.568802] exit_to_usermode_loop+0x69/0xa0 [ 5261.568803] syscall_return_slowpath+0xbf/0xd0 [ 5261.568804] entry_SYSCALL_64_fastpath+0x7b/0x7d [ 5261.568805] RIP: 0033:0x7fceb27696dc [ 5261.568805] RSP: 002b:00007fcd9f7fd620 EFLAGS: 00000246 ORIG_RAX: 00000000000000ca [ 5261.568806] RAX: fffffffffffffe00 RBX: 0000000008bc2028 RCX: 00007fceb27696dc [ 5261.568806] RDX: 0000000000000000 RSI: 0000000000000080 RDI: 0000000008bc2050 [ 5261.568807] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000008020100 [ 5261.568807] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000008bc2000 [ 5261.568807] R13: 0000000001687f40 R14: 0000000000000000 R15: 0000000008bc2050 [ 5261.568808] Code: ff 74 16 f0 ff 0f 0f 88 db e5 14 00 75 0b 89 04 24 e8 e8 1f f8 d1 8b 04 24 48 8b 54 24 38 48 8b 5c 24 08 48 89 13 e9 0b fd ff ff <0f> ff eb 88 e8 1a 15 a7 d1 66 2e 0f 1f 84 00 00 00 00 00 0f 1f [ 5261.568822] ---[ end trace 700e4f5bfa6fddf4 ]--- [ 5261.569536] WARNING: CPU: 0 PID: 25480 at drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1641 amdgpu_vm_bo_update_mapping+0x3dd/0x3f0 [amdgpu] [ 5261.569538] Modules linked in: rfcomm fuse xt_CHECKSUM ipt_MASQUERADE nf_nat_masquerade_ipv4 tun nf_conntrack_netbios_ns nf_conntrack_broadcast xt_CT ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 xt_conntrack ip_set nfnetlink ebtable_nat ebtable_broute bridge stp llc ip6table_nat nf_conntrack_ipv6 nf_defrag_ipv6 nf_nat_ipv6 ip6table_mangle ip6table_raw ip6table_security iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack devlink libcrc32c iptable_mangle iptable_raw iptable_security ebtable_filter ebtables ip6table_filter ip6_tables cmac bnep sunrpc vfat fat arc4 iwlmvm mac80211 snd_hda_codec_realtek snd_hda_codec_hdmi snd_hda_codec_generic snd_hda_intel iwlwifi snd_hda_codec edac_mce_amd btusb snd_hda_core btrtl btbcm kvm btintel snd_hwdep bluetooth snd_seq irqbypass snd_seq_device [ 5261.569552] cfg80211 crct10dif_pclmul snd_pcm joydev mxm_wmi wmi_bmof crc32_pclmul snd_timer ecdh_generic ghash_clmulni_intel snd rfkill soundcore ccp sp5100_tco pcspkr shpchp i2c_piix4 k10temp wmi acpi_cpufreq binfmt_misc amdgpu chash i2c_algo_bit gpu_sched drm_kms_helper ttm drm crc32c_intel alx hid_holtek_mouse mdio [ 5261.569558] CPU: 0 PID: 25480 Comm: gallium_drv:0 Tainted: G W 4.15.0-rc2+ #27 [ 5261.569559] Hardware name: Gigabyte Technology Co., Ltd. X399 AORUS Gaming 7/X399 AORUS Gaming 7, BIOS F2 08/31/2017 [ 5261.569559] task: 0000000045d1804c task.stack: 00000000e1257dad [ 5261.569572] RIP: 0010:amdgpu_vm_bo_update_mapping+0x3dd/0x3f0 [amdgpu] [ 5261.569574] RSP: 0018:ffffa3c751d83998 EFLAGS: 00010216 [ 5261.569575] RAX: ffff987a86601258 RBX: ffff987a9942e000 RCX: ffff987a73d86550 [ 5261.569575] RDX: 0000000000000004 RSI: ffff987a86601258 RDI: ffffa3c744d7f300 [ 5261.569575] RBP: ffff987a73d80000 R08: 0000000000001018 R09: 0000000000000004 [ 5261.569576] R10: 0000000000030000 R11: 000000000000100d R12: 0000000000000e0e [ 5261.569576] R13: ffff987a73d86560 R14: 000000000013f000 R15: 0000000000000000 [ 5261.569577] FS: 00007fcd9f7fe700(0000) GS:ffff987a9de00000(0000) knlGS:0000000000000000 [ 5261.569577] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 5261.569579] CR2: 00007f2581124010 CR3: 00000001bbe09000 CR4: 00000000003406f0 [ 5261.569579] Call Trace: [ 5261.569581] ? _cond_resched+0x15/0x40 [ 5261.569582] ? __ww_mutex_lock.isra.2+0x42/0x640 [ 5261.569595] ? amdgpu_vm_free_mapping.isra.23+0x20/0x20 [amdgpu] [ 5261.569609] amdgpu_vm_clear_freed+0xbb/0x190 [amdgpu] [ 5261.569623] amdgpu_gem_object_close+0x19c/0x210 [amdgpu] [ 5261.569629] ? drm_gem_object_release_handle+0x2c/0x90 [drm] [ 5261.569633] drm_gem_object_release_handle+0x2c/0x90 [drm] [ 5261.569637] ? drm_gem_object_handle_put_unlocked+0xb0/0xb0 [drm] [ 5261.569638] idr_for_each+0x48/0xe0 [ 5261.569642] drm_gem_release+0x1c/0x30 [drm] [ 5261.569646] drm_release+0x342/0x3b0 [drm] [ 5261.569649] __fput+0xcd/0x1d0 [ 5261.569650] task_work_run+0x81/0xa0 [ 5261.569651] do_exit+0x2de/0xba0 [ 5261.569655] ? drm_ioctl_kernel+0x59/0xb0 [drm] [ 5261.569656] do_group_exit+0x3a/0xa0 [ 5261.569657] get_signal+0x26c/0x570 [ 5261.569658] do_signal+0x36/0x610 [ 5261.569659] ? do_vfs_ioctl+0xa1/0x610 [ 5261.569660] ? SyS_futex+0x12d/0x180 [ 5261.569662] exit_to_usermode_loop+0x69/0xa0 [ 5261.569662] syscall_return_slowpath+0xbf/0xd0 [ 5261.569663] entry_SYSCALL_64_fastpath+0x7b/0x7d [ 5261.569664] RIP: 0033:0x7fceb27696dc [ 5261.569664] RSP: 002b:00007fcd9f7fd620 EFLAGS: 00000246 ORIG_RAX: 00000000000000ca [ 5261.569665] RAX: fffffffffffffe00 RBX: 0000000008bc2028 RCX: 00007fceb27696dc [ 5261.569665] RDX: 0000000000000000 RSI: 0000000000000080 RDI: 0000000008bc2050 [ 5261.569665] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000008020100 [ 5261.569666] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000008bc2000 [ 5261.569666] R13: 0000000001687f40 R14: 0000000000000000 R15: 0000000008bc2050 [ 5261.569667] Code: ff 74 16 f0 ff 0f 0f 88 db e5 14 00 75 0b 89 04 24 e8 e8 1f f8 d1 8b 04 24 48 8b 54 24 38 48 8b 5c 24 08 48 89 13 e9 0b fd ff ff <0f> ff eb 88 e8 1a 15 a7 d1 66 2e 0f 1f 84 00 00 00 00 00 0f 1f [ 5261.569681] ---[ end trace 700e4f5bfa6fddf5 ]--- [ 5261.569753] WARNING: CPU: 0 PID: 25480 at drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1641 amdgpu_vm_bo_update_mapping+0x3dd/0x3f0 [amdgpu] [ 5261.569754] Modules linked in: rfcomm fuse xt_CHECKSUM ipt_MASQUERADE nf_nat_masquerade_ipv4 tun nf_conntrack_netbios_ns nf_conntrack_broadcast xt_CT ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 xt_conntrack ip_set nfnetlink ebtable_nat ebtable_broute bridge stp llc ip6table_nat nf_conntrack_ipv6 nf_defrag_ipv6 nf_nat_ipv6 ip6table_mangle ip6table_raw ip6table_security iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack devlink libcrc32c iptable_mangle iptable_raw iptable_security ebtable_filter ebtables ip6table_filter ip6_tables cmac bnep sunrpc vfat fat arc4 iwlmvm mac80211 snd_hda_codec_realtek snd_hda_codec_hdmi snd_hda_codec_generic snd_hda_intel iwlwifi snd_hda_codec edac_mce_amd btusb snd_hda_core btrtl btbcm kvm btintel snd_hwdep bluetooth snd_seq irqbypass snd_seq_device [ 5261.569766] cfg80211 crct10dif_pclmul snd_pcm joydev mxm_wmi wmi_bmof crc32_pclmul snd_timer ecdh_generic ghash_clmulni_intel snd rfkill soundcore ccp sp5100_tco pcspkr shpchp i2c_piix4 k10temp wmi acpi_cpufreq binfmt_misc amdgpu chash i2c_algo_bit gpu_sched drm_kms_helper ttm drm crc32c_intel alx hid_holtek_mouse mdio [ 5261.569772] CPU: 0 PID: 25480 Comm: gallium_drv:0 Tainted: G W 4.15.0-rc2+ #27 [ 5261.569772] Hardware name: Gigabyte Technology Co., Ltd. X399 AORUS Gaming 7/X399 AORUS Gaming 7, BIOS F2 08/31/2017 [ 5261.569773] task: 0000000045d1804c task.stack: 00000000e1257dad [ 5261.569785] RIP: 0010:amdgpu_vm_bo_update_mapping+0x3dd/0x3f0 [amdgpu] [ 5261.569787] RSP: 0018:ffffa3c751d83998 EFLAGS: 00010212 [ 5261.569787] RAX: ffff987a86604258 RBX: ffff987a9942e000 RCX: ffff987a73d86550 [ 5261.569788] RDX: 0000000000000004 RSI: ffff987a86604258 RDI: ffffa3c744d83700 [ 5261.569788] RBP: ffff987a73d80000 R08: 0000000000000c18 R09: 0000000000000004 [ 5261.569788] R10: 0000000000030000 R11: 0000000000000c0d R12: 0000000000000ace [ 5261.569789] R13: ffff987a73d86560 R14: 0000000000151400 R15: 0000000000000000 [ 5261.569789] FS: 00007fcd9f7fe700(0000) GS:ffff987a9de00000(0000) knlGS:0000000000000000 [ 5261.569790] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 5261.569792] CR2: 00007f2581124010 CR3: 00000001bbe09000 CR4: 00000000003406f0 [ 5261.569792] Call Trace: [ 5261.569794] ? _cond_resched+0x15/0x40 [ 5261.569795] ? __ww_mutex_lock.isra.2+0x42/0x640 [ 5261.569807] ? amdgpu_vm_free_mapping.isra.23+0x20/0x20 [amdgpu] [ 5261.569819] amdgpu_vm_clear_freed+0xbb/0x190 [amdgpu] [ 5261.569833] amdgpu_gem_object_close+0x19c/0x210 [amdgpu] [ 5261.569839] ? drm_gem_object_release_handle+0x2c/0x90 [drm] [ 5261.569842] drm_gem_object_release_handle+0x2c/0x90 [drm] [ 5261.569846] ? drm_gem_object_handle_put_unlocked+0xb0/0xb0 [drm] [ 5261.569847] idr_for_each+0x48/0xe0 [ 5261.569851] drm_gem_release+0x1c/0x30 [drm] [ 5261.569854] drm_release+0x342/0x3b0 [drm] [ 5261.569857] __fput+0xcd/0x1d0 [ 5261.569858] task_work_run+0x81/0xa0 [ 5261.569859] do_exit+0x2de/0xba0 [ 5261.569864] ? drm_ioctl_kernel+0x59/0xb0 [drm] [ 5261.569865] do_group_exit+0x3a/0xa0 [ 5261.569866] get_signal+0x26c/0x570 [ 5261.569867] do_signal+0x36/0x610 [ 5261.569868] ? do_vfs_ioctl+0xa1/0x610 [ 5261.569869] ? SyS_futex+0x12d/0x180 [ 5261.569870] exit_to_usermode_loop+0x69/0xa0 [ 5261.569871] syscall_return_slowpath+0xbf/0xd0 [ 5261.569872] entry_SYSCALL_64_fastpath+0x7b/0x7d [ 5261.569872] RIP: 0033:0x7fceb27696dc [ 5261.569873] RSP: 002b:00007fcd9f7fd620 EFLAGS: 00000246 ORIG_RAX: 00000000000000ca [ 5261.569873] RAX: fffffffffffffe00 RBX: 0000000008bc2028 RCX: 00007fceb27696dc [ 5261.569874] RDX: 0000000000000000 RSI: 0000000000000080 RDI: 0000000008bc2050 [ 5261.569874] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000008020100 [ 5261.569874] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000008bc2000 [ 5261.569875] R13: 0000000001687f40 R14: 0000000000000000 R15: 0000000008bc2050 [ 5261.569875] Code: ff 74 16 f0 ff 0f 0f 88 db e5 14 00 75 0b 89 04 24 e8 e8 1f f8 d1 8b 04 24 48 8b 54 24 38 48 8b 5c 24 08 48 89 13 e9 0b fd ff ff <0f> ff eb 88 e8 1a 15 a7 d1 66 2e 0f 1f 84 00 00 00 00 00 0f 1f [ 5261.569890] ---[ end trace 700e4f5bfa6fddf6 ]--- [ 5271.969130] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring sdma0 timeout, last signaled seq=135113, last emitted seq=135115 [ 5271.969137] [drm] No hardware hang detected. Did some blocks stall? -- You are receiving this mail because: You are the assignee for the bug.

1 16

[PATCH v2 0/3] ARM: OMAP1: ams-delta: Complete driver gpiod migration
by Janusz Krzysztofik 08 Oct '18

08 Oct '18

This is a follow up of initial submission of a series consisted of 6 changes, 3 of which have been already applied or reworkeed. V2 changelog: [PATCH 1/6] ARM: OMAP1: ams-delta: add GPIO lookup tables - already in mainline, commit 68e62a15a914 [PATCH 2/6] Input: ams_delta_serio: use GPIO lookup table - reworked and submitted as a series, already in linux-omap, commit 68e62a15a914 ("ARM: OMAP1: ams-delta: drop GPIO lookup table for serio device") followed by 9 more [PATCH 3/6] ASoC: ams_delta: use GPIO lookup table - already in mainline, commit d65777d1a2cd [PATCH 4/6] fbdev: omapfb: lcd_ams_delta: use GPIO lookup table - resubmitting as [PATCH v2 1/3 v2] v2: Remove problematic error code conversion no longer needed if used on top of commit d08605a64e67 ("ARM: OMAP1: ams-delta: move late devices back to init_machine") and commit 8853daf3b4ac ("gpiolib: Defer on non-DT find_chip_by_name() failure") already in linux-next [PATCH 5/6] mtd: rawnand: ams-delta: use GPIO lookup table - resubmitting as [PATCH v2 2/3 v4] v2: Fix handling of devm_gpiod_get_optional() return values - thanks to Andy Shevchenko. v3: Remove problematic error code conversion no longer needed if used on top of commit d08605a64e67 ("ARM: OMAP1: ams-delta: move late devices back to init_machine") and commit 8853daf3b4ac ("gpiolib: Defer on non-DT find_chip_by_name() failure") already in linux-next - thanks to Boris Brezillon v4: fix style issue - thanks to Boris Brezillon [PATCH 6/6] ARM: OMAP1: ams-delta: make board header file local to mach-omap1 - resending as [PATCH v2 3/3] Dependency on commit 8853daf3b4ac ("gpiolib: Defer on non-DT find_chip_by_name() failure") is not critical - it is not needed for clean build or run, it only prevents from potential future changes to driver initializaton order during device_initcall. I'm submitting the three patches in series because the last one depends on the other two. Thanks, Janusz

6 15

[PATCH] udlfb: handle unplug properly
by Mikulas Patocka 08 Oct '18

08 Oct '18

The udlfb driver maintained an open count and cleaned up itself when the count reached zero. But the console is also counted in the reference count - so, if the user unplugged the device, the open count would not drop to zero and the driver stayed loaded with console attached. If the user re-plugged the adapter, it would create a device /dev/fb1, show green screen and the access to the console would be lost. The framebuffer subsystem has reference counting on its own - in order to fix the unplug bug, we rely the framebuffer reference counting. When the user unplugs the adapter, we call unregister_framebuffer unconditionally. unregister_framebuffer will unbind the console, wait until all users stop using the framebuffer and then call the fb_destroy method. The fb_destroy cleans up the USB driver. This patch makes the following changes: * Drop dlfb->kref and rely on implicit framebuffer reference counting instead. * dlfb_usb_disconnect calls unregister_framebuffer, the rest of driver cleanup is done in the function dlfb_ops_destroy. dlfb_ops_destroy will be called by the framebuffer subsystem when no processes have the framebuffer open or mapped. * We don't use workqueue during initialization, but initialize directly from dlfb_usb_probe. The workqueue could race with dlfb_usb_disconnect and this racing would produce various kinds of memory corruption. * We use usb_get_dev and usb_put_dev to make sure that the USB subsystem doesn't free the device under us. Signed-off-by: Mikulas Patocka <mpatocka(a)redhat.com> --- drivers/video/fbdev/udlfb.c | 141 +++++++++++--------------------------------- include/video/udlfb.h | 3 2 files changed, 37 insertions(+), 107 deletions(-) Index: linux-4.17.10/drivers/video/fbdev/udlfb.c =================================================================== --- linux-4.17.10.orig/drivers/video/fbdev/udlfb.c 2018-07-27 11:41:12.000000000 +0200 +++ linux-4.17.10/drivers/video/fbdev/udlfb.c 2018-07-27 14:44:47.000000000 +0200 @@ -916,8 +916,6 @@ static int dlfb_ops_open(struct fb_info dlfb->fb_count++; - kref_get(&dlfb->kref); - if (fb_defio && (info->fbdefio == NULL)) { /* enable defio at last moment if not disabled by client */ @@ -940,14 +938,17 @@ static int dlfb_ops_open(struct fb_info return 0; } -/* - * Called when all client interfaces to start transactions have been disabled, - * and all references to our device instance (dlfb_data) are released. - * Every transaction must have a reference, so we know are fully spun down - */ -static void dlfb_free(struct kref *kref) +static void dlfb_ops_destroy(struct fb_info *info) { - struct dlfb_data *dlfb = container_of(kref, struct dlfb_data, kref); + struct dlfb_data *dlfb = info->par; + + if (info->cmap.len != 0) + fb_dealloc_cmap(&info->cmap); + if (info->monspecs.modedb) + fb_destroy_modedb(info->monspecs.modedb); + vfree(info->screen_base); + + fb_destroy_modelist(&info->modelist); while (!list_empty(&dlfb->deferred_free)) { struct dlfb_deferred_free *d = list_entry(dlfb->deferred_free.next, struct dlfb_deferred_free, list); @@ -957,40 +958,13 @@ static void dlfb_free(struct kref *kref) } vfree(dlfb->backing_buffer); kfree(dlfb->edid); + usb_put_dev(dlfb->udev); kfree(dlfb); -} - -static void dlfb_free_framebuffer(struct dlfb_data *dlfb) -{ - struct fb_info *info = dlfb->info; - - if (info) { - unregister_framebuffer(info); - - if (info->cmap.len != 0) - fb_dealloc_cmap(&info->cmap); - if (info->monspecs.modedb) - fb_destroy_modedb(info->monspecs.modedb); - vfree(info->screen_base); - - fb_destroy_modelist(&info->modelist); - - dlfb->info = NULL; - - /* Assume info structure is freed after this point */ - framebuffer_release(info); - } - /* ref taken in probe() as part of registering framebfufer */ - kref_put(&dlfb->kref, dlfb_free); + /* Assume info structure is freed after this point */ + framebuffer_release(info); } -static void dlfb_free_framebuffer_work(struct work_struct *work) -{ - struct dlfb_data *dlfb = container_of(work, struct dlfb_data, - free_framebuffer_work.work); - dlfb_free_framebuffer(dlfb); -} /* * Assumes caller is holding info->lock mutex (for open and release at least) */ @@ -1000,10 +974,6 @@ static int dlfb_ops_release(struct fb_in dlfb->fb_count--; - /* We can't free fb_info here - fbmem will touch it when we return */ - if (dlfb->virtualized && (dlfb->fb_count == 0)) - schedule_delayed_work(&dlfb->free_framebuffer_work, HZ); - if ((dlfb->fb_count == 0) && (info->fbdefio)) { fb_deferred_io_cleanup(info); kfree(info->fbdefio); @@ -1013,8 +983,6 @@ static int dlfb_ops_release(struct fb_in dev_dbg(info->dev, "release, user=%d count=%d\n", user, dlfb->fb_count); - kref_put(&dlfb->kref, dlfb_free); - return 0; } @@ -1172,6 +1140,7 @@ static struct fb_ops dlfb_ops = { .fb_blank = dlfb_ops_blank, .fb_check_var = dlfb_ops_check_var, .fb_set_par = dlfb_ops_set_par, + .fb_destroy = dlfb_ops_destroy, }; @@ -1615,12 +1584,13 @@ success: return true; } -static void dlfb_init_framebuffer_work(struct work_struct *work); - static int dlfb_usb_probe(struct usb_interface *intf, const struct usb_device_id *id) { + int i; + const struct device_attribute *attr; struct dlfb_data *dlfb; + struct fb_info *info; int retval = -ENOMEM; struct usb_device *usbdev = interface_to_usbdev(intf); @@ -1631,10 +1601,9 @@ static int dlfb_usb_probe(struct usb_int goto error; } - kref_init(&dlfb->kref); /* matching kref_put in usb .disconnect fn */ INIT_LIST_HEAD(&dlfb->deferred_free); - dlfb->udev = usbdev; + dlfb->udev = usb_get_dev(usbdev); usb_set_intfdata(intf, dlfb); dev_dbg(&intf->dev, "console enable=%d\n", console); @@ -1657,42 +1626,6 @@ static int dlfb_usb_probe(struct usb_int } - if (!dlfb_alloc_urb_list(dlfb, WRITES_IN_FLIGHT, MAX_TRANSFER)) { - retval = -ENOMEM; - dev_err(&intf->dev, "unable to allocate urb list\n"); - goto error; - } - - kref_get(&dlfb->kref); /* matching kref_put in free_framebuffer_work */ - - /* We don't register a new USB class. Our client interface is dlfbev */ - - /* Workitem keep things fast & simple during USB enumeration */ - INIT_DELAYED_WORK(&dlfb->init_framebuffer_work, - dlfb_init_framebuffer_work); - schedule_delayed_work(&dlfb->init_framebuffer_work, 0); - - return 0; - -error: - if (dlfb) { - - kref_put(&dlfb->kref, dlfb_free); /* last ref from kref_init */ - - /* dev has been deallocated. Do not dereference */ - } - - return retval; -} - -static void dlfb_init_framebuffer_work(struct work_struct *work) -{ - int i, retval; - struct fb_info *info; - const struct device_attribute *attr; - struct dlfb_data *dlfb = container_of(work, struct dlfb_data, - init_framebuffer_work.work); - /* allocates framebuffer driver structure, not framebuffer memory */ info = framebuffer_alloc(0, &dlfb->udev->dev); if (!info) { @@ -1706,17 +1639,22 @@ static void dlfb_init_framebuffer_work(s dlfb->ops = dlfb_ops; info->fbops = &dlfb->ops; + INIT_LIST_HEAD(&info->modelist); + + if (!dlfb_alloc_urb_list(dlfb, WRITES_IN_FLIGHT, MAX_TRANSFER)) { + retval = -ENOMEM; + dev_err(&intf->dev, "unable to allocate urb list\n"); + goto error; + } + + /* We don't register a new USB class. Our client interface is dlfbev */ + retval = fb_alloc_cmap(&info->cmap, 256, 0); if (retval < 0) { dev_err(info->device, "cmap allocation failed: %d\n", retval); goto error; } - INIT_DELAYED_WORK(&dlfb->free_framebuffer_work, - dlfb_free_framebuffer_work); - - INIT_LIST_HEAD(&info->modelist); - retval = dlfb_setup_modes(dlfb, info, NULL, 0); if (retval != 0) { dev_err(info->device, @@ -1760,10 +1698,16 @@ static void dlfb_init_framebuffer_work(s dev_name(info->dev), info->var.xres, info->var.yres, ((dlfb->backing_buffer) ? info->fix.smem_len * 2 : info->fix.smem_len) >> 10); - return; + return 0; error: - dlfb_free_framebuffer(dlfb); + if (dlfb->info) { + dlfb_ops_destroy(dlfb->info); + } else if (dlfb) { + usb_put_dev(dlfb->udev); + kfree(dlfb); + } + return retval; } static void dlfb_usb_disconnect(struct usb_interface *intf) @@ -1791,20 +1735,9 @@ static void dlfb_usb_disconnect(struct u for (i = 0; i < ARRAY_SIZE(fb_device_attrs); i++) device_remove_file(info->dev, &fb_device_attrs[i]); device_remove_bin_file(info->dev, &edid_attr); - unlink_framebuffer(info); } - usb_set_intfdata(intf, NULL); - dlfb->udev = NULL; - - /* if clients still have us open, will be freed on last close */ - if (dlfb->fb_count == 0) - schedule_delayed_work(&dlfb->free_framebuffer_work, 0); - - /* release reference taken by kref_init in probe() */ - kref_put(&dlfb->kref, dlfb_free); - - /* consider dlfb_data freed */ + unregister_framebuffer(info); } static struct usb_driver dlfb_driver = { Index: linux-4.17.10/include/video/udlfb.h =================================================================== --- linux-4.17.10.orig/include/video/udlfb.h 2018-07-27 11:41:12.000000000 +0200 +++ linux-4.17.10/include/video/udlfb.h 2018-07-27 14:20:54.000000000 +0200 @@ -36,12 +36,9 @@ struct dlfb_data { struct usb_device *udev; struct fb_info *info; struct urb_list urbs; - struct kref kref; char *backing_buffer; int fb_count; bool virtualized; /* true when physical usb device not present */ - struct delayed_work init_framebuffer_work; - struct delayed_work free_framebuffer_work; atomic_t usb_active; /* 0 = update virtual buffer, but no usb traffic */ atomic_t lost_pixels; /* 1 = a render op failed. Need screen refresh */ char *edid; /* null until we read edid from hw or get from sysfs */

2 1

[PATCH] video: fbdev: add the dependency of broadsheetfb in Kconfig
by Jia-Ju Bai 08 Oct '18

08 Oct '18

broadsheetfb is a platform driver and it should not be used on x86. It should be used only by single ARM PXA board, so adding the dependency in Kconfig. Signed-off-by: Jia-Ju Bai <baijiaju1990(a)gmail.com> --- drivers/video/fbdev/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index d94254263ea5..ec91d7a2d8b8 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -2241,7 +2241,7 @@ config FB_MX3 config FB_BROADSHEET tristate "E-Ink Broadsheet/Epson S1D13521 controller support" - depends on FB + depends on FB && (ARCH_PXA || COMPILE_TEST) select FB_SYS_FILLRECT select FB_SYS_COPYAREA select FB_SYS_IMAGEBLIT -- 2.17.0

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel July 2018