dri-devel July 2018

dri-devel@lists.freedesktop.org

277 participants
1883 discussions

[PATCH] drm/atmel-hlcdc: Replace drm_dev_unref with drm_dev_put
by Thomas Zimmermann 01 Jul '18

01 Jul '18

This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann <contact(a)tzimmermann.org> --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c index 843cac222e60..fedbfa333bb0 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c @@ -763,7 +763,7 @@ static int atmel_hlcdc_dc_drm_probe(struct platform_device *pdev) ret = atmel_hlcdc_dc_load(ddev); if (ret) - goto err_unref; + goto err_put; ret = drm_dev_register(ddev, 0); if (ret) @@ -774,8 +774,8 @@ static int atmel_hlcdc_dc_drm_probe(struct platform_device *pdev) err_unload: atmel_hlcdc_dc_unload(ddev); -err_unref: - drm_dev_unref(ddev); +err_put: + drm_dev_put(ddev); return ret; } @@ -786,7 +786,7 @@ static int atmel_hlcdc_dc_drm_remove(struct platform_device *pdev) drm_dev_unregister(ddev); atmel_hlcdc_dc_unload(ddev); - drm_dev_unref(ddev); + drm_dev_put(ddev); return 0; } -- 2.14.4

1 0

[PATCH] drm/arc: Replace drm_dev_unref with drm_dev_put
by Thomas Zimmermann 01 Jul '18

01 Jul '18

This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann <contact(a)tzimmermann.org> --- drivers/gpu/drm/arc/arcpgu_drv.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/arc/arcpgu_drv.c b/drivers/gpu/drm/arc/arcpgu_drv.c index f067de4e1e82..27d426bf7d01 100644 --- a/drivers/gpu/drm/arc/arcpgu_drv.c +++ b/drivers/gpu/drm/arc/arcpgu_drv.c @@ -204,7 +204,7 @@ static int arcpgu_probe(struct platform_device *pdev) ret = arcpgu_load(drm); if (ret) - goto err_unref; + goto err_put; ret = drm_dev_register(drm, 0); if (ret) @@ -215,8 +215,8 @@ static int arcpgu_probe(struct platform_device *pdev) err_unload: arcpgu_unload(drm); -err_unref: - drm_dev_unref(drm); +err_put: + drm_dev_put(drm); return ret; } @@ -227,7 +227,7 @@ static int arcpgu_remove(struct platform_device *pdev) drm_dev_unregister(drm); arcpgu_unload(drm); - drm_dev_unref(drm); + drm_dev_put(drm); return 0; } -- 2.14.4

1 0

[Bug 200383] New: amdgpu: some stacktrace from kernel log, dc110_stream_encoder_update_hdmi_info_packets
by bugzilla-daemon＠bugzilla.kernel.org 01 Jul '18

01 Jul '18

https://bugzilla.kernel.org/show_bug.cgi?id=200383 Bug ID: 200383 Summary: amdgpu: some stacktrace from kernel log, dc110_stream_encoder_update_hdmi_info_packets Product: Drivers Version: 2.5 Kernel Version: 4.17.2 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: farmboy0(a)googlemail.com Regression: No Happened after system locked up hard on next boot. Not sure anything is not working atm though. Jul 1 12:33:35 kernel: [ 25.976326] WARNING: CPU: 5 PID: 2342 at drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:132 generic_reg_update_ex+0x101/0x150 Jul 1 12:33:35 kernel: [ 25.976327] Modules linked in: Jul 1 12:33:35 kernel: [ 25.976330] CPU: 5 PID: 2342 Comm: kwin_wayland Tainted: G W 4.17.2 #1 Jul 1 12:33:35 kernel: [ 25.976331] Hardware name: Micro-Star International Co., Ltd. MS-7A31/X370 XPOWER GAMING TITANIUM (MS-7A31), BIOS 1.90 09/19/2017 Jul 1 12:33:35 kernel: [ 25.976333] RIP: 0010:generic_reg_update_ex+0x101/0x150 Jul 1 12:33:35 kernel: [ 25.976333] RSP: 0018:ffffb7aec3f77840 EFLAGS: 00010246 Jul 1 12:33:35 kernel: [ 25.976335] RAX: ffffb7aec3f77860 RBX: ffff9d5bbd2bbb00 RCX: 0000000000000000 Jul 1 12:33:35 kernel: [ 25.976335] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff9d5bbd2c0480 Jul 1 12:33:35 kernel: [ 25.976336] RBP: ffffb7aec3f778a8 R08: 0000000000000000 R09: 0000000000000000 Jul 1 12:33:35 kernel: [ 25.976336] R10: 0000000000000001 R11: 0000000000000001 R12: 0000000000000000 Jul 1 12:33:35 kernel: [ 25.976337] R13: 0000000000000000 R14: 0000000000000000 R15: ffff9d5b7ac64000 Jul 1 12:33:35 kernel: [ 25.976338] FS: 00007f727ad961c0(0000) GS:ffff9d5bbe740000(0000) knlGS:0000000000000000 Jul 1 12:33:35 kernel: [ 25.976338] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 Jul 1 12:33:35 kernel: [ 25.976339] CR2: 00007f72698ae218 CR3: 00000007e5e0a000 CR4: 00000000003406e0 Jul 1 12:33:35 kernel: [ 25.976340] Call Trace: Jul 1 12:33:35 kernel: [ 25.976345] dce110_stream_encoder_update_hdmi_info_packets+0x3e4/0x5f0 Jul 1 12:33:35 kernel: [ 25.976348] dce110_apply_ctx_to_hw+0x647/0x8d0 Jul 1 12:33:35 kernel: [ 25.976350] dc_commit_state+0x2c0/0x5b0 Jul 1 12:33:35 kernel: [ 25.976352] ? set_freesync_on_streams.part.7+0xcb/0x2e0 Jul 1 12:33:35 kernel: [ 25.976353] ? mod_freesync_set_user_enable+0x165/0x1b0 Jul 1 12:33:35 kernel: [ 25.976355] amdgpu_dm_atomic_commit_tail+0x327/0xde0 Jul 1 12:33:35 kernel: [ 25.976358] ? wait_for_common+0x14b/0x190 Jul 1 12:33:35 kernel: [ 25.976359] ? wait_for_common+0x14b/0x190 Jul 1 12:33:35 kernel: [ 25.976361] commit_tail+0x3a/0x70 Jul 1 12:33:35 kernel: [ 25.976363] drm_atomic_helper_commit+0x121/0x130 Jul 1 12:33:35 kernel: [ 25.976365] drm_mode_atomic_ioctl+0x86a/0xa40 Jul 1 12:33:35 kernel: [ 25.976367] ? __drm_mode_object_add+0x8e/0xc0 Jul 1 12:33:35 kernel: [ 25.976368] ? mutex_lock+0xe/0x30 Jul 1 12:33:35 kernel: [ 25.976369] ? drm_atomic_set_property+0x520/0x520 Jul 1 12:33:35 kernel: [ 25.976370] drm_ioctl_kernel+0x76/0xd0 Jul 1 12:33:35 kernel: [ 25.976372] drm_ioctl+0x31e/0x3b0 Jul 1 12:33:35 kernel: [ 25.976373] ? drm_atomic_set_property+0x520/0x520 Jul 1 12:33:35 kernel: [ 25.976375] amdgpu_drm_ioctl+0x5d/0xa0 Jul 1 12:33:35 kernel: [ 25.976378] do_vfs_ioctl+0xb0/0x620 Jul 1 12:33:35 kernel: [ 25.976379] ksys_ioctl+0x92/0xa0 Jul 1 12:33:35 kernel: [ 25.976381] __x64_sys_ioctl+0x16/0x20 Jul 1 12:33:35 kernel: [ 25.976383] do_syscall_64+0x4a/0x100 Jul 1 12:33:35 kernel: [ 25.976385] entry_SYSCALL_64_after_hwframe+0x49/0xbe Jul 1 12:33:35 kernel: [ 25.976387] RIP: 0033:0x7f7277bff317 Jul 1 12:33:35 kernel: [ 25.976387] RSP: 002b:00007fff610317d8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 Jul 1 12:33:35 kernel: [ 25.976388] RAX: ffffffffffffffda RBX: 000055b6db2b07c0 RCX: 00007f7277bff317 Jul 1 12:33:35 kernel: [ 25.976389] RDX: 00007fff61031830 RSI: 00000000c03864bc RDI: 0000000000000033 Jul 1 12:33:35 kernel: [ 25.976389] RBP: 00007fff61031830 R08: 000055b6daa2a230 R09: 0000000000000000 Jul 1 12:33:35 kernel: [ 25.976390] R10: 0000000000000002 R11: 0000000000000246 R12: 00000000c03864bc Jul 1 12:33:35 kernel: [ 25.976390] R13: 0000000000000033 R14: 000055b6db2416b0 R15: 000055b6db2a1ed0 Jul 1 12:33:35 kernel: [ 25.976391] Code: 7f 18 89 da 48 8b 07 ff 50 08 48 8b 74 24 18 65 48 33 34 25 28 00 00 00 89 d8 75 35 48 83 c4 50 5b 41 5c 41 5d 5d c3 0f 0b eb bb <0f> 0b e9 44 ff ff ff 41 8b 0c 24 41 89 c0 49 83 c4 08 45 8b 2c Jul 1 12:33:35 kernel: [ 25.976411] ---[ end trace 38f1d57c974dc64d ]--- Jul 1 12:33:35 kernel: [ 25.979253] WARNING: CPU: 5 PID: 2342 at drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:132 generic_reg_update_ex+0x101/0x150 Jul 1 12:33:35 kernel: [ 25.979254] Modules linked in: Jul 1 12:33:35 kernel: [ 25.979255] CPU: 5 PID: 2342 Comm: kwin_wayland Tainted: G W 4.17.2 #1 Jul 1 12:33:35 kernel: [ 25.979256] Hardware name: Micro-Star International Co., Ltd. MS-7A31/X370 XPOWER GAMING TITANIUM (MS-7A31), BIOS 1.90 09/19/2017 Jul 1 12:33:35 kernel: [ 25.979256] RIP: 0010:generic_reg_update_ex+0x101/0x150 Jul 1 12:33:35 kernel: [ 25.979257] RSP: 0018:ffffb7aec3f77758 EFLAGS: 00010246 Jul 1 12:33:35 kernel: [ 25.979258] RAX: ffffb7aec3f77778 RBX: ffff9d5bbd2bbb00 RCX: 0000000000000000 Jul 1 12:33:35 kernel: [ 25.979258] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff9d5bbd2c0480 Jul 1 12:33:35 kernel: [ 25.979258] RBP: ffffb7aec3f777c0 R08: 0000000000000000 R09: 0000000000000000 Jul 1 12:33:35 kernel: [ 25.979259] R10: 0000000000000001 R11: 0000000000000000 R12: 0000000000000000 Jul 1 12:33:35 kernel: [ 25.979259] R13: 0000000000000000 R14: ffff9d5bbd680400 R15: ffff9d5bbd2c0480 Jul 1 12:33:35 kernel: [ 25.979260] FS: 00007f727ad961c0(0000) GS:ffff9d5bbe740000(0000) knlGS:0000000000000000 Jul 1 12:33:35 kernel: [ 25.979260] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 Jul 1 12:33:35 kernel: [ 25.979261] CR2: 00007f72698ae218 CR3: 00000007e5e0a000 CR4: 00000000003406e0 Jul 1 12:33:35 kernel: [ 25.979261] Call Trace: Jul 1 12:33:35 kernel: [ 25.979262] ? generic_reg_update_ex+0xe0/0x150 Jul 1 12:33:35 kernel: [ 25.979264] dce110_stream_encoder_update_hdmi_info_packets+0x3e4/0x5f0 Jul 1 12:33:35 kernel: [ 25.979266] ? dce110_link_encoder_connect_dig_be_to_fe+0xa7/0xf0 Jul 1 12:33:35 kernel: [ 25.979267] dce110_enable_stream+0x5d/0xf0 Jul 1 12:33:35 kernel: [ 25.979268] core_link_enable_stream+0x213/0xd00 Jul 1 12:33:35 kernel: [ 25.979270] ? dce110_stream_encoder_update_hdmi_info_packets+0x37b/0x5f0 Jul 1 12:33:35 kernel: [ 25.979271] dce110_apply_ctx_to_hw+0x894/0x8d0 Jul 1 12:33:35 kernel: [ 25.979272] dc_commit_state+0x2c0/0x5b0 Jul 1 12:33:35 kernel: [ 25.979273] ? set_freesync_on_streams.part.7+0xcb/0x2e0 Jul 1 12:33:35 kernel: [ 25.979274] ? mod_freesync_set_user_enable+0x165/0x1b0 Jul 1 12:33:35 kernel: [ 25.979275] amdgpu_dm_atomic_commit_tail+0x327/0xde0 Jul 1 12:33:35 kernel: [ 25.979276] ? wait_for_common+0x14b/0x190 Jul 1 12:33:35 kernel: [ 25.979277] ? wait_for_common+0x14b/0x190 Jul 1 12:33:35 kernel: [ 25.979279] commit_tail+0x3a/0x70 Jul 1 12:33:35 kernel: [ 25.979280] drm_atomic_helper_commit+0x121/0x130 Jul 1 12:33:35 kernel: [ 25.979281] drm_mode_atomic_ioctl+0x86a/0xa40 Jul 1 12:33:35 kernel: [ 25.979282] ? __drm_mode_object_add+0x8e/0xc0 Jul 1 12:33:35 kernel: [ 25.979283] ? mutex_lock+0xe/0x30 Jul 1 12:33:35 kernel: [ 25.979284] ? drm_atomic_set_property+0x520/0x520 Jul 1 12:33:35 kernel: [ 25.979285] drm_ioctl_kernel+0x76/0xd0 Jul 1 12:33:35 kernel: [ 25.979286] drm_ioctl+0x31e/0x3b0 Jul 1 12:33:35 kernel: [ 25.979287] ? drm_atomic_set_property+0x520/0x520 Jul 1 12:33:35 kernel: [ 25.979288] amdgpu_drm_ioctl+0x5d/0xa0 Jul 1 12:33:35 kernel: [ 25.979289] do_vfs_ioctl+0xb0/0x620 Jul 1 12:33:35 kernel: [ 25.979290] ksys_ioctl+0x92/0xa0 Jul 1 12:33:35 kernel: [ 25.979291] __x64_sys_ioctl+0x16/0x20 Jul 1 12:33:35 kernel: [ 25.979292] do_syscall_64+0x4a/0x100 Jul 1 12:33:35 kernel: [ 25.979293] entry_SYSCALL_64_after_hwframe+0x49/0xbe Jul 1 12:33:35 kernel: [ 25.979294] RIP: 0033:0x7f7277bff317 Jul 1 12:33:35 kernel: [ 25.979294] RSP: 002b:00007fff610317d8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 Jul 1 12:33:35 kernel: [ 25.979295] RAX: ffffffffffffffda RBX: 000055b6db2b07c0 RCX: 00007f7277bff317 Jul 1 12:33:35 kernel: [ 25.979295] RDX: 00007fff61031830 RSI: 00000000c03864bc RDI: 0000000000000033 Jul 1 12:33:35 kernel: [ 25.979295] RBP: 00007fff61031830 R08: 000055b6daa2a230 R09: 0000000000000000 Jul 1 12:33:35 kernel: [ 25.979296] R10: 0000000000000002 R11: 0000000000000246 R12: 00000000c03864bc Jul 1 12:33:35 kernel: [ 25.979296] R13: 0000000000000033 R14: 000055b6db2416b0 R15: 000055b6db2a1ed0 Jul 1 12:33:35 kernel: [ 25.979297] Code: 7f 18 89 da 48 8b 07 ff 50 08 48 8b 74 24 18 65 48 33 34 25 28 00 00 00 89 d8 75 35 48 83 c4 50 5b 41 5c 41 5d 5d c3 0f 0b eb bb <0f> 0b e9 44 ff ff ff 41 8b 0c 24 41 89 c0 49 83 c4 08 45 8b 2c Jul 1 12:33:35 kernel: [ 25.979311] ---[ end trace 38f1d57c974dc64e ]--- Jul 1 12:33:35 kernel: [ 25.980138] WARNING: CPU: 4 PID: 2342 at drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:132 generic_reg_update_ex+0x101/0x150 Jul 1 12:33:35 kernel: [ 25.980138] Modules linked in: Jul 1 12:33:35 kernel: [ 25.980142] CPU: 4 PID: 2342 Comm: kwin_wayland Tainted: G W 4.17.2 #1 Jul 1 12:33:35 kernel: [ 25.980142] Hardware name: Micro-Star International Co., Ltd. MS-7A31/X370 XPOWER GAMING TITANIUM (MS-7A31), BIOS 1.90 09/19/2017 Jul 1 12:33:35 kernel: [ 25.980143] RIP: 0010:generic_reg_update_ex+0x101/0x150 Jul 1 12:33:35 kernel: [ 25.980144] RSP: 0018:ffffb7aec3f77900 EFLAGS: 00010246 Jul 1 12:33:35 kernel: [ 25.980144] RAX: ffffb7aec3f77920 RBX: ffff9d5bbd2bbb00 RCX: 0000000000000000 Jul 1 12:33:35 kernel: [ 25.980145] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff9d5bbd2c0480 Jul 1 12:33:35 kernel: [ 25.980145] RBP: ffffb7aec3f77968 R08: 0000000000000000 R09: 0000000000000000 Jul 1 12:33:35 kernel: [ 25.980145] R10: 0000000000000001 R11: 0000000000000001 R12: 0000000000000000 Jul 1 12:33:35 kernel: [ 25.980146] R13: 0000000000000000 R14: ffff9d54c4576000 R15: ffff9d5bbae6c220 Jul 1 12:33:35 kernel: [ 25.980146] FS: 00007f727ad961c0(0000) GS:ffff9d5bbe700000(0000) knlGS:0000000000000000 Jul 1 12:33:35 kernel: [ 25.980147] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 Jul 1 12:33:35 kernel: [ 25.980148] CR2: 000055bf7be70398 CR3: 00000007e5e0a000 CR4: 00000000003406e0 Jul 1 12:33:35 kernel: [ 25.980149] Call Trace: Jul 1 12:33:35 kernel: [ 25.980151] ? program_clock_v6+0x96/0xe0 Jul 1 12:33:35 kernel: [ 25.980154] dce110_stream_encoder_update_hdmi_info_packets+0x3e4/0x5f0 Jul 1 12:33:35 kernel: [ 25.980156] dc_stream_adjust_vmin_vmax+0xc0/0xe0 Jul 1 12:33:35 kernel: [ 25.980157] set_freesync_on_streams.part.7+0xcb/0x2e0 Jul 1 12:33:35 kernel: [ 25.980158] mod_freesync_notify_mode_change+0xf7/0x180 Jul 1 12:33:35 kernel: [ 25.980160] amdgpu_dm_atomic_commit_tail+0x4f8/0xde0 Jul 1 12:33:35 kernel: [ 25.980162] ? wait_for_common+0x14b/0x190 Jul 1 12:33:35 kernel: [ 25.980162] ? wait_for_common+0x14b/0x190 Jul 1 12:33:35 kernel: [ 25.980166] commit_tail+0x3a/0x70 Jul 1 12:33:35 kernel: [ 25.980167] drm_atomic_helper_commit+0x121/0x130 Jul 1 12:33:35 kernel: [ 25.980168] drm_mode_atomic_ioctl+0x86a/0xa40 Jul 1 12:33:35 kernel: [ 25.980169] ? __drm_mode_object_add+0x8e/0xc0 Jul 1 12:33:35 kernel: [ 25.980170] ? mutex_lock+0xe/0x30 Jul 1 12:33:35 kernel: [ 25.980172] ? drm_atomic_set_property+0x520/0x520 Jul 1 12:33:35 kernel: [ 25.980173] drm_ioctl_kernel+0x76/0xd0 Jul 1 12:33:35 kernel: [ 25.980176] drm_ioctl+0x31e/0x3b0 Jul 1 12:33:35 kernel: [ 25.980178] ? drm_atomic_set_property+0x520/0x520 Jul 1 12:33:35 kernel: [ 25.980179] amdgpu_drm_ioctl+0x5d/0xa0 Jul 1 12:33:35 kernel: [ 25.980180] do_vfs_ioctl+0xb0/0x620 Jul 1 12:33:35 kernel: [ 25.980181] ksys_ioctl+0x92/0xa0 Jul 1 12:33:35 kernel: [ 25.980182] __x64_sys_ioctl+0x16/0x20 Jul 1 12:33:35 kernel: [ 25.980184] do_syscall_64+0x4a/0x100 Jul 1 12:33:35 kernel: [ 25.980185] entry_SYSCALL_64_after_hwframe+0x49/0xbe Jul 1 12:33:35 kernel: [ 25.980186] RIP: 0033:0x7f7277bff317 Jul 1 12:33:35 kernel: [ 25.980187] RSP: 002b:00007fff610317d8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 Jul 1 12:33:35 kernel: [ 25.980190] RAX: ffffffffffffffda RBX: 000055b6db2b07c0 RCX: 00007f7277bff317 Jul 1 12:33:35 kernel: [ 25.980190] RDX: 00007fff61031830 RSI: 00000000c03864bc RDI: 0000000000000033 Jul 1 12:33:35 kernel: [ 25.980190] RBP: 00007fff61031830 R08: 000055b6daa2a230 R09: 0000000000000000 Jul 1 12:33:35 kernel: [ 25.980191] R10: 0000000000000002 R11: 0000000000000246 R12: 00000000c03864bc Jul 1 12:33:35 kernel: [ 25.980191] R13: 0000000000000033 R14: 000055b6db2416b0 R15: 000055b6db2a1ed0 Jul 1 12:33:35 kernel: [ 25.980192] Code: 7f 18 89 da 48 8b 07 ff 50 08 48 8b 74 24 18 65 48 33 34 25 28 00 00 00 89 d8 75 35 48 83 c4 50 5b 41 5c 41 5d 5d c3 0f 0b eb bb <0f> 0b e9 44 ff ff ff 41 8b 0c 24 41 89 c0 49 83 c4 08 45 8b 2c Jul 1 12:33:35 kernel: [ 25.980212] ---[ end trace 38f1d57c974dc64f ]--- -- You are receiving this mail because: You are watching the assignee of the bug.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel July 2018