dri-devel July 2018

dri-devel@lists.freedesktop.org

277 participants
1883 discussions

[PATCH v3] gpu: drm: gma500: Change return type to vm_fault_t
by Souptick Joarder 03 Jul '18

03 Jul '18

Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type. Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t") Previously vm_insert_{pfn,mixed} returns err which driver mapped into VM_FAULT_* type. The new function vmf_insert_{pfn,mixed} will replace this inefficiency by returning VM_FAULT_* type. vmf_error() is the newly introduce inline function in 4.17-rc6. Signed-off-by: Souptick Joarder <jrdr.linux(a)gmail.com> Reviewed-by: Matthew Wilcox <mawilcox(a)microsoft.com> --- v2: updated the change log v3: Fixed kbuild error drivers/gpu/drm/gma500/framebuffer.c | 14 +++++--------- drivers/gpu/drm/gma500/gem.c | 27 ++++++++++----------------- drivers/gpu/drm/gma500/psb_drv.h | 3 ++- 3 files changed, 17 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c index cb0a2ae..632aadb 100644 --- a/drivers/gpu/drm/gma500/framebuffer.c +++ b/drivers/gpu/drm/gma500/framebuffer.c @@ -111,7 +111,7 @@ static int psbfb_pan(struct fb_var_screeninfo *var, struct fb_info *info) return 0; } -static int psbfb_vm_fault(struct vm_fault *vmf) +static vm_fault_t psbfb_vm_fault(struct vm_fault *vmf) { struct vm_area_struct *vma = vmf->vma; struct psb_framebuffer *psbfb = vma->vm_private_data; @@ -120,7 +120,7 @@ static int psbfb_vm_fault(struct vm_fault *vmf) int page_num; int i; unsigned long address; - int ret; + vm_fault_t ret = VM_FAULT_SIGBUS; unsigned long pfn; unsigned long phys_addr = (unsigned long)dev_priv->stolen_base + psbfb->gtt->offset; @@ -133,18 +133,14 @@ static int psbfb_vm_fault(struct vm_fault *vmf) for (i = 0; i < page_num; i++) { pfn = (phys_addr >> PAGE_SHIFT); - ret = vm_insert_mixed(vma, address, + ret = vmf_insert_mixed(vma, address, __pfn_to_pfn_t(pfn, PFN_DEV)); - if (unlikely((ret == -EBUSY) || (ret != 0 && i > 0))) + if (unlikely(ret & VM_FAULT_ERROR)) break; - else if (unlikely(ret != 0)) { - ret = (ret == -ENOMEM) ? VM_FAULT_OOM : VM_FAULT_SIGBUS; - return ret; - } address += PAGE_SIZE; phys_addr += PAGE_SIZE; } - return VM_FAULT_NOPAGE; + return ret; } static void psbfb_vm_open(struct vm_area_struct *vma) diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c index 1312397..e7be5c9 100644 --- a/drivers/gpu/drm/gma500/gem.c +++ b/drivers/gpu/drm/gma500/gem.c @@ -134,12 +134,13 @@ int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev, * vma->vm_private_data points to the GEM object that is backing this * mapping. */ -int psb_gem_fault(struct vm_fault *vmf) +vm_fault_t psb_gem_fault(struct vm_fault *vmf) { struct vm_area_struct *vma = vmf->vma; struct drm_gem_object *obj; struct gtt_range *r; - int ret; + int err; + vm_fault_t ret; unsigned long pfn; pgoff_t page_offset; struct drm_device *dev; @@ -158,9 +159,10 @@ int psb_gem_fault(struct vm_fault *vmf) /* For now the mmap pins the object and it stays pinned. As things stand that will do us no harm */ if (r->mmapping == 0) { - ret = psb_gtt_pin(r); - if (ret < 0) { - dev_err(dev->dev, "gma500: pin failed: %d\n", ret); + err = psb_gtt_pin(r); + if (err < 0) { + dev_err(dev->dev, "gma500: pin failed: %d\n", err); + ret = vmf_error(err); goto fail; } r->mmapping = 1; @@ -175,18 +177,9 @@ int psb_gem_fault(struct vm_fault *vmf) pfn = (dev_priv->stolen_base + r->offset) >> PAGE_SHIFT; else pfn = page_to_pfn(r->pages[page_offset]); - ret = vm_insert_pfn(vma, vmf->address, pfn); - + ret = vmf_insert_pfn(vma, vmf->address, pfn); fail: mutex_unlock(&dev_priv->mmap_mutex); - switch (ret) { - case 0: - case -ERESTARTSYS: - case -EINTR: - return VM_FAULT_NOPAGE; - case -ENOMEM: - return VM_FAULT_OOM; - default: - return VM_FAULT_SIGBUS; - } + + return ret; } diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h index e8300f5..93d2f40 100644 --- a/drivers/gpu/drm/gma500/psb_drv.h +++ b/drivers/gpu/drm/gma500/psb_drv.h @@ -21,6 +21,7 @@ #define _PSB_DRV_H_ #include <linux/kref.h> +#include <linux/mm_types.h> #include <drm/drmP.h> #include <drm/drm_global.h> @@ -749,7 +750,7 @@ extern int psb_gem_get_aperture(struct drm_device *dev, void *data, struct drm_file *file); extern int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev, struct drm_mode_create_dumb *args); -extern int psb_gem_fault(struct vm_fault *vmf); +extern vm_fault_t psb_gem_fault(struct vm_fault *vmf); /* psb_device.c */ extern const struct psb_ops psb_chip_ops; -- 1.9.1

1 3

[PATCH] drm/via: mark expected switch fall-throughs
by Gustavo A. R. Silva 03 Jul '18

03 Jul '18

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <gustavo(a)embeddedor.com> --- drivers/gpu/drm/via/via_dmablit.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/via/via_dmablit.c b/drivers/gpu/drm/via/via_dmablit.c index 345bda4..8bf3a7c 100644 --- a/drivers/gpu/drm/via/via_dmablit.c +++ b/drivers/gpu/drm/via/via_dmablit.c @@ -177,12 +177,14 @@ via_free_sg_info(struct pci_dev *pdev, drm_via_sg_info_t *vsg) switch (vsg->state) { case dr_via_device_mapped: via_unmap_blit_from_device(pdev, vsg); + /* fall through */ case dr_via_desc_pages_alloc: for (i = 0; i < vsg->num_desc_pages; ++i) { if (vsg->desc_pages[i] != NULL) free_page((unsigned long)vsg->desc_pages[i]); } kfree(vsg->desc_pages); + /* fall through */ case dr_via_pages_locked: for (i = 0; i < vsg->num_pages; ++i) { if (NULL != (page = vsg->pages[i])) { @@ -191,8 +193,10 @@ via_free_sg_info(struct pci_dev *pdev, drm_via_sg_info_t *vsg) put_page(page); } } + /* fall through */ case dr_via_pages_alloc: vfree(vsg->pages); + /* fall through */ default: vsg->state = dr_via_sg_init; } -- 2.7.4

1 0

[PATCH 1/2] drm/panel: Augment the TPO TPG110 bindings
by Linus Walleij 02 Jul '18

02 Jul '18

The TPO TPG110 bindings were using the DPI bindings (popular in the fbdev subsystem) but this misses the finer points learned in the DRM subsystem. We need to augment the bindings for proper DRM integration: the timings are expressed by the hardware, not put into the device tree. Old device trees with the DPI info will continue to work, but no known deployments exist. Cc: devicetree(a)vger.kernel.org Signed-off-by: Linus Walleij <linus.walleij(a)linaro.org> --- .../bindings/display/panel/tpo,tpg110.txt | 34 ++++++++----------- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt b/Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt index f5e3c6f2095a..0e918076d55e 100644 --- a/Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt +++ b/Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt @@ -1,26 +1,32 @@ TPO TPG110 Panel ================ -This binding builds on the DPI bindings, adding a few properties -as a superset of a DPI. See panel-dpi.txt for the required DPI -bindings. +This panel driver can driver a variety of panels. It requires +a few GPIO lines for control of its reset line and custom serial +protocol. Required properties: -- compatible : "tpo,tpg110" +- compatible : one of: + "ste,nomadik-nhk15-display", "tpo,tpg110" + "tpo,tpg110" - grestb-gpios : panel reset GPIO - scen-gpios : serial control enable GPIO - scl-gpios : serial control clock line GPIO - sda-gpios : serial control data line GPIO +- width-mm : see display/panel/panel-common.txt +- height-mm : see display/panel/panel-common.txt -Required nodes: -- Video port for DPI input, see panel-dpi.txt -- Panel timing for DPI setup, see panel-dpi.txt +The device node can contain one 'port' child node with one child +'endpoint' node, according to the bindings defined in +media/video-interfaces.txt. This node should describe panel's video bus. Example ------- panel { - compatible = "tpo,tpg110", "panel-dpi"; + compatible = "tpo,tpg110"; + width-mm = <116>; + height-mm = <87>; grestb-gpios = <&stmpe_gpio44 5 GPIO_ACTIVE_LOW>; scen-gpios = <&gpio0 6 GPIO_ACTIVE_LOW>; scl-gpios = <&gpio0 5 GPIO_ACTIVE_HIGH>; @@ -32,16 +38,4 @@ panel { remote-endpoint = <&nomadik_clcd_pads>; }; }; - - panel-timing { - clock-frequency = <33200000>; - hactive = <800>; - hback-porch = <216>; - hfront-porch = <40>; - hsync-len = <1>; - vactive = <480>; - vback-porch = <35>; - vfront-porch = <10>; - vsync-len = <1>; - }; }; -- 2.17.1

4 6

XFX Vega 64 crashing on Linux-4.17.3
by F. Heitkamp 02 Jul '18

02 Jul '18

Hi, I have a XFX Radeon VEGA 64, and a SuperMicro H11SSL-NC. I have been using the kernel.org 4.17.3 tree. I can run gnome-shell for awhile but the box eventually crashes. The VEGA fans go full blast and the machine becomes unresponsive. This is with my own "home brew" linux and also with Debian. I did try with a Fedora 28 live CD and it did not crash with it. I left it running for a fairly long time. Anyone have an ideas? This is what the kernel spits out: amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> mpt3sas_cm0: scan devices: complete [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> PM: suspend exit [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <gfx> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <gfx> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) NFS: nfs4_reclaim_open_state: Lock reclaim failed! NFS: nfs4_reclaim_open_state: Lock reclaim failed! NFS: nfs4_reclaim_open_state: Lock reclaim failed! NFS: nfs4_reclaim_open_state: Lock reclaim failed! NFS: nfs4_reclaim_open_state: Lock reclaim failed! NFS: nfs4_reclaim_open_state: Lock reclaim failed! NFS: nfs4_reclaim_open_state: Lock reclaim failed! NFS: nfs4_reclaim_open_state: Lock reclaim failed! NFS: nfs4_reclaim_open_state: Lock reclaim failed! NFS: nfs4_reclaim_open_state: Lock reclaim failed! amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> Message from[drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) syslogd@nfsrootamdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) at Jul 2 12:31amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> :15 ... kerne[drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> l:Disabling IRQ [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> #9 [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> audit: type=1130 audit(1530549079.225:147): pid=1 uid=0 auid=4294967295 ses=4294967295 subj=kernel msg='' [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) audit: type=1131 audit(1530549079.225:148): pid=1 uid=0 auid=4294967295 ses=4294967295 subj=kernel msg='' amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma1> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <sdma0> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu 0000:23:00.0: couldn't schedule ib on ring <gfx> [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) amdgpu: [powerplay] Failed message: 0x24, input parameter: 0x1, error code: 0xffffffff amdgpu: [powerplay] Failed message: 0x22, input parameter: 0x7, error code: 0xffffffff amdgpu: [powerplay] Failed message: 0x25, input parameter: 0x3, error code: 0xffffffff amdgpu: [powerplay] Failed message: 0x9, input parameter: 0xf4, error code: 0xffffffff amdgpu: [powerplay] Failed message: 0xa, input parameter: 0x901000, error code: 0xffffffff amdgpu: [powerplay] Failed message: 0xe, input parameter: 0x0, error code: 0xffffffff amdgpu: [powerplay] Failed message: 0x42, input parameter: 0x0, error code: 0xffffffff amdgpu: [powerplay] Failed message: 0x24, input parameter: 0x1, error code: 0xffffffff BUG: unable to handle kernel NULL pointer dereference at 0000000000000008 PGD 811277067 P4D 811277067 PUD 8180a5067 PMD 0 Oops: 0000 [#1] SMP Modules linked in: auth_rpcgss nfsv4 dns_resolver nfs lockd grace sunrpc fscache af_packet sd_mod hid_ge4 CPU: 27 PID: 1496 Comm: X Tainted: G T 4.17.3 #80 Hardware name: Supermicro Super Server/H11SSL-NC, BIOS 1.0a 02/22/2018 RIP: 0010:apply_min_clocks+0x1a/0x180 [amdgpu] RSP: 0018:ffffb8300785b958 EFLAGS: 00010202 RAX: 000000000000ffff RBX: ffff973b535f8000 RCX: 0000000000000001 RDX: ffffb8300785b9a0 RSI: ffff973b535f8000 RDI: 0000000000000000 RBP: ffffb8300785ba18 R08: 0000000000000000 R09: 000000000000ffff R10: 0000000000027cb8 R11: 0000000000000001 R12: ffff973b535f8000 R13: 0000ffff0000ffff R14: ffff973b51032800 R15: 0000000000000006 FS: 00007fa645231a80(0000) GS:ffff97435e640000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000008 CR3: 000000081802f000 CR4: 00000000003406e0 Call Trace: dce110_apply_ctx_to_hw+0x1cc/0x9c0 [amdgpu] ? pp_dpm_dispatch_tasks+0x5b/0x80 [amdgpu] ? amdgpu_pm_compute_clocks+0x94/0x540 [amdgpu] dc_commit_state+0x2e4/0x530 [amdgpu] ? set_freesync_on_streams.part.6+0x48/0x240 [amdgpu] ? mod_freesync_set_user_enable+0x109/0x120 [amdgpu] amdgpu_dm_atomic_commit_tail+0x33d/0xcd0 [amdgpu] ? _cond_resched+0x10/0x40 ? wait_for_common+0x28/0x150 ? _cond_resched+0x10/0x40 ? wait_for_common+0x28/0x150 commit_tail+0x38/0x60 [drm_kms_helper] drm_atomic_helper_commit+0xf7/0x100 [drm_kms_helper] drm_atomic_helper_set_config+0x7b/0x90 [drm_kms_helper] ? mutex_lock+0x9/0x30 __drm_mode_set_config_internal+0x62/0x110 [drm] drm_mode_setcrtc+0x3e7/0x570 [drm] ? drm_mode_getcrtc+0x160/0x160 [drm] drm_ioctl_kernel+0x56/0xb0 [drm] drm_ioctl+0x293/0x330 [drm] ? drm_mode_getcrtc+0x160/0x160 [drm] amdgpu_drm_ioctl+0x44/0x80 [amdgpu] do_vfs_ioctl+0x96/0x610 ? security_file_ioctl+0x36/0x50 ksys_ioctl+0x6b/0x80 __x64_sys_ioctl+0x11/0x20 do_syscall_64+0x65/0x1b0 ? prepare_exit_to_usermode+0x7a/0xa0 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x7fa644315f37 RSP: 002b:00007ffd14996078 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007ffd149960cc RCX: 00007fa644315f37 RDX: 00007ffd149960b0 RSI: 00000000c06864a2 RDI: 000000000000000c RBP: 00007ffd149960b0 R08: 0000000000000000 R09: 0000000002c9aa70 R10: 00007ffd149961c0 R11: 0000000000000246 R12: 00000000c06864a2 R13: 000000000000000c R14: 0000000000000000 R15: 0000000000000000 Code: fd 48 81 c4 88 00 00 00 5b 5d 41 5c 41 5d 41 5e c3 53 48 89 f3 48 83 ec 10 48 8b be b8 3c 00 00 84 RIP: apply_min_clocks+0x1a/0x180 [amdgpu] RSP: ffffb8300785b958 CR2: 0000000000000008 ---[ end trace fe88a3c0b5a9e565 ]--- CTRL-A Z for help | 115200 8N1 | NOR | Minicom 2.7.1 | VT102 | Online 2:55 | ttyUSB0

1 0

[PATCH] drm/msm: Disable mdp5 crtc when there are no active planes
by Sean Paul 02 Jul '18

02 Jul '18

Unlike other compositors, we don't get a crtc disable from weston when the cable is unplugged. As such, when the cable is re-plugged the kernel doesn't detect an enable/mode change and initiates a simple plane update instead of a modeset. This patch clears the mode when all planes are off. Signed-off-by: Sean Paul <seanpaul(a)chromium.org> --- Sorry for the wide distribution, I'm not 100% on whether this is the right place to fix this. Is this expected behavior from weston? Once we have solid fill support, it seems reasonable that a crtc might be left on if no planes are active (for blanking the screen, etc). However, hotplug is currently borked, so I don't want to just leave it as-is if this should be handled in the kernel. Suggestions welcome! Sean drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c index 63dcc39b5efd..e89e46a4014e 100644 --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c @@ -645,7 +645,7 @@ static int mdp5_crtc_atomic_check(struct drm_crtc *crtc, /* bail out early if there aren't any planes */ if (!cnt) - return 0; + return drm_atomic_set_mode_for_crtc(state, NULL); hw_cfg = mdp5_cfg_get_hw_config(mdp5_kms->cfg); -- Sean Paul, Software Engineer, Google / Chromium OS

1 0

[PATCH v3 0/9] drm/vc4: Add support for the transposer IP
by Boris Brezillon 02 Jul '18

02 Jul '18

Hello, This is the third version of this series adding writeback support to the VC4 display engine. This version is based on drm-misc-next and include a bunch of modifications to the core that I had to add to make it work on VC4. Not much has changed in this v3, just a few minor fixes/cleanup/rework and the addition of one patch to make commit->atomic_commit() optional. See the changelog in each patch you want more details. Regards, Boris Boris Brezillon (9): drm/atomic: Avoid connector to writeback_connector casts drm/connector: Pass a drm_connector_state to ->atomic_commit() drm/connector: Make ->atomic_commit() optional drm/vc4: Use wait_for_flip_done() instead of wait_for_vblanks() drm/crtc: Add a generic infrastructure to fake VBLANK events drm/atomic: Call fake_vblank() from the generic commit_tail() helpers drm/vc4: Call drm_atomic_helper_fake_vblank() in the commit path drm/vc4: Add support for the transposer block ARM: dts: bcm283x: Add Transposer block .../devicetree/bindings/display/brcm,bcm-vc4.txt | 6 + arch/arm/boot/dts/bcm283x.dtsi | 6 + drivers/gpu/drm/drm_atomic.c | 4 +- drivers/gpu/drm/drm_atomic_helper.c | 47 +- drivers/gpu/drm/vc4/Makefile | 1 + drivers/gpu/drm/vc4/vc4_crtc.c | 138 ++++-- drivers/gpu/drm/vc4/vc4_debugfs.c | 1 + drivers/gpu/drm/vc4/vc4_drv.c | 1 + drivers/gpu/drm/vc4/vc4_drv.h | 7 + drivers/gpu/drm/vc4/vc4_kms.c | 11 +- drivers/gpu/drm/vc4/vc4_txp.c | 477 +++++++++++++++++++++ include/drm/drm_atomic_helper.h | 1 + include/drm/drm_crtc.h | 23 + include/drm/drm_modeset_helper_vtables.h | 6 +- include/drm/drm_writeback.h | 6 + 15 files changed, 699 insertions(+), 36 deletions(-) create mode 100644 drivers/gpu/drm/vc4/vc4_txp.c -- 2.14.1

4 16

Regression: no display with Vega 56 AMD GPU bisected to commit bfdec2340478
by Jeremy Cline 02 Jul '18

02 Jul '18

Hi folks, A Fedora user, Mikhail (CCed), reported[0] a regression with their Vega 56 AMD GPU introduced by bfdec2340478 ("drm/amd/display: Implement dm_pp_get_clock_levels_by_type_with_latency"). The symptom is that nothing is displayed and looking at the logs (attached to the Bugzilla), I see gnome-shell is failing with "Failed to set CRTC mode 3840x2160: Invalid argument". The problem persists through 4.18 RC2 so it's not fixed by 10dd2b865393 ("drm/amd/display: Fix wrong latency assignment for VEGA clock levels"). I see a couple "if (!dm_pp_get_clock_levels_by_type_with_latency)" blocks which would no longer be unconditionally run, but I don't know enough to even guess at the problem. [0] https://bugzilla.redhat.com/show_bug.cgi?id=1592110 Regards, Jeremy

1 0

Re: Plane transitional helper prototypes mismatch their methods
by Russell King - ARM Linux 02 Jul '18

02 Jul '18

Ping. On Mon, Jun 25, 2018 at 04:52:16PM +0100, Russell King - ARM Linux wrote: > Hi, > > Currently, the transitional plane helpers have prototypes that > do not have the drm_modeset_acquire_ctx argument: > > int drm_plane_helper_update(struct drm_plane *plane, struct drm_crtc *crtc, > struct drm_framebuffer *fb, > int crtc_x, int crtc_y, > unsigned int crtc_w, unsigned int crtc_h, > uint32_t src_x, uint32_t src_y, > uint32_t src_w, uint32_t src_h); > int drm_plane_helper_disable(struct drm_plane *plane); > > However, the helper methods have this as the last argument: > > int (*update_plane)(struct drm_plane *plane, > struct drm_crtc *crtc, struct drm_framebuffer *fb, > int crtc_x, int crtc_y, > unsigned int crtc_w, unsigned int crtc_h, > uint32_t src_x, uint32_t src_y, > uint32_t src_w, uint32_t src_h, > struct drm_modeset_acquire_ctx *ctx); > int (*disable_plane)(struct drm_plane *plane, > struct drm_modeset_acquire_ctx *ctx); > > Are these transitional helpers supposed to be plugged into these > methods directly? Looking back in the history, the following commit > to i915 seems to suggest that they were designed to be plugged > directly into these methods: > > commit ea2c67bb4affa84080c616920f3899f123786e56 > Author: Matt Roper <matthew.d.roper(a)intel.com> > Date: Tue Dec 23 10:41:52 2014 -0800 > > drm/i915: Move to atomic plane helpers (v9) > > It seems easy to add this argument to drm_plane_helper_update() as > it has no current users, but the drm_plane_helper_disable() > transitional helper seems to be used extensively by what are > otherwise fully atomic modeset drivers, despite being described as > only a transitional helper. > > drivers/gpu/drm/arm/hdlcd_crtc.c: drm_plane_helper_disable(plane); > drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c: drm_plane_helper_disable(plane); > drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c: drm_plane_helper_disable(plane); > drivers/gpu/drm/arc/arcpgu_crtc.c: drm_plane_helper_disable(plane); > drivers/gpu/drm/sti/sti_hqvdp.c: drm_plane_helper_disable(drm_plane); > drivers/gpu/drm/sti/sti_gdp.c: drm_plane_helper_disable(drm_plane); > drivers/gpu/drm/sti/sti_cursor.c: drm_plane_helper_disable(drm_plane); > drivers/gpu/drm/vc4/vc4_plane.c: drm_plane_helper_disable(plane); > drivers/gpu/drm/zte/zx_plane.c: drm_plane_helper_disable(plane); > > Are these drivers buggy using the transitional helper, which won't do > anything but change the state of that single plane, leaving the CRTC, > encoders, bridges, etc all active? > > -- > RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up > According to speedtest.net: 8.21Mbps down 510kbps up -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up

2 3

trouble with kernel 4.17.3 amdgpu
by F. Heitkamp 02 Jul '18

02 Jul '18

1 0

[PATCH] drm/atomic-helper: Use old/new state in drm_atomic_helper_commit_planes_on_crtc()
by Ville Syrjala 02 Jul '18

02 Jul '18

From: Ville Syrjälä <ville.syrjala(a)linux.intel.com> Update drm_atomic_helper_commit_planes_on_crtc() to use explicit old/new states instead of relying on obj->state. Signed-off-by: Ville Syrjälä <ville.syrjala(a)linux.intel.com> --- drivers/gpu/drm/drm_atomic_helper.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index e022cacdae34..8008a7de2e10 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -2342,11 +2342,13 @@ drm_atomic_helper_commit_planes_on_crtc(struct drm_crtc_state *old_crtc_state) const struct drm_crtc_helper_funcs *crtc_funcs; struct drm_crtc *crtc = old_crtc_state->crtc; struct drm_atomic_state *old_state = old_crtc_state->state; + struct drm_crtc_state *new_crtc_state = + drm_atomic_get_new_crtc_state(old_state, crtc); struct drm_plane *plane; unsigned plane_mask; plane_mask = old_crtc_state->plane_mask; - plane_mask |= crtc->state->plane_mask; + plane_mask |= new_crtc_state->plane_mask; crtc_funcs = crtc->helper_private; if (crtc_funcs && crtc_funcs->atomic_begin) @@ -2355,6 +2357,8 @@ drm_atomic_helper_commit_planes_on_crtc(struct drm_crtc_state *old_crtc_state) drm_for_each_plane_mask(plane, crtc->dev, plane_mask) { struct drm_plane_state *old_plane_state = drm_atomic_get_old_plane_state(old_state, plane); + struct drm_plane_state *new_plane_state = + drm_atomic_get_new_plane_state(old_state, plane); const struct drm_plane_helper_funcs *plane_funcs; plane_funcs = plane->helper_private; @@ -2362,13 +2366,14 @@ drm_atomic_helper_commit_planes_on_crtc(struct drm_crtc_state *old_crtc_state) if (!old_plane_state || !plane_funcs) continue; - WARN_ON(plane->state->crtc && plane->state->crtc != crtc); + WARN_ON(new_plane_state->crtc && + new_plane_state->crtc != crtc); - if (drm_atomic_plane_disabling(old_plane_state, plane->state) && + if (drm_atomic_plane_disabling(old_plane_state, new_plane_state) && plane_funcs->atomic_disable) plane_funcs->atomic_disable(plane, old_plane_state); - else if (plane->state->crtc || - drm_atomic_plane_disabling(old_plane_state, plane->state)) + else if (new_plane_state->crtc || + drm_atomic_plane_disabling(old_plane_state, new_plane_state)) plane_funcs->atomic_update(plane, old_plane_state); } -- 2.16.4

3 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel July 2018