dri-devel July 2018

dri-devel@lists.freedesktop.org

277 participants
1883 discussions

[Bug 106707] [CI] igt@gem_exec_schedule@deep-* - fail - Failed assertion: __vgem_fence_signal(fd, fence) == 0
by bugzilla-daemon＠freedesktop.org 23 Jul '18

23 Jul '18

https://bugs.freedesktop.org/show_bug.cgi?id=106707 --- Comment #10 from Martin Peres <martin.peres(a)free.fr> --- New bug created: https://bugs.freedesktop.org/show_bug.cgi?id=107341 However, I would also like to documented that we can also see this bug in GLK: https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_74/fi-glk-dsi/igt@gem_exec_… https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_76/fi-glk-dsi/igt@gem_exec_… https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_76/fi-glk-dsi/igt@gem_exec_… (gem_exec_schedule:1158) igt_vgem-CRITICAL: Test assertion failure function vgem_fence_signal, file ../lib/igt_vgem.c:193: (gem_exec_schedule:1158) igt_vgem-CRITICAL: Failed assertion: __vgem_fence_signal(fd, fence) == 0 (gem_exec_schedule:1158) igt_vgem-CRITICAL: error: -110 != 0 Subtest deep-bsd failed. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 106707] [CI] igt@gem_exec_schedule@deep-* - fail - Failed assertion: __vgem_fence_signal(fd, fence) == 0
by bugzilla-daemon＠freedesktop.org 23 Jul '18

23 Jul '18

https://bugs.freedesktop.org/show_bug.cgi?id=106707 --- Comment #9 from Martin Peres <martin.peres(a)free.fr> --- (In reply to Chris Wilson from comment #8) > (In reply to Martin Peres from comment #7) > > (In reply to Chris Wilson from comment #6) > > > (In reply to Martin Peres from comment #5) > > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4519/fi-kbl-8809g/ > > > > igt@amdgpu_amd_prime@amd-to-i915.html > > > > > > > > (amd_prime:4831) igt_vgem-CRITICAL: Test assertion failure function > > > > vgem_fence_signal, file ../lib/igt_vgem.c:193: > > > > (amd_prime:4831) igt_vgem-CRITICAL: Failed assertion: > > > > __vgem_fence_signal(fd, fence) == 0 > > > > (amd_prime:4831) igt_vgem-CRITICAL: error: -110 != 0 > > > > Subtest amd-to-i915 failed. > > > > > > Not a common problem. These are individual test setups that are just too > > > slow on CI. > > > > Not sure I understand your explanation. Can you rephrase? > > > > Also, what would you suggest I do for this issue? Should I create a new bug? > > It's a separate issue for the amdgpu_amd_prime test. We need to tune the > setup to run within 10s or use a sw_sync fence instead of a vgem plug. Thanks! I will create a new IGT bug then :) -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 106707] [CI] igt@gem_exec_schedule@deep-* - fail - Failed assertion: __vgem_fence_signal(fd, fence) == 0
by bugzilla-daemon＠freedesktop.org 23 Jul '18

23 Jul '18

1 0

[PATCH] drm/atomic: Initialize variables in drm_atomic_helper_async_check() to make gcc happy
by Boris Brezillon 23 Jul '18

23 Jul '18

drm_atomic_helper_async_check() declares the plane, old_plane_state and new_plane_state variables to iterate over all planes of the atomic state and make sure only one plane is enabled. Unfortunately gcc is not smart enough to figure out that the check on n_planes is enough to guarantee that plane, new_plane_state and old_plane_state are initialized. Explicitly initialized those variables to NULL to make gcc happy. Fixes: fef9df8b5945 ("drm/atomic: initial support for asynchronous plane update") Signed-off-by: Boris Brezillon <boris.brezillon(a)bootlin.com> --- drivers/gpu/drm/drm_atomic_helper.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index f7ccfebd3ca8..80be74df7ba6 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -1538,8 +1538,9 @@ int drm_atomic_helper_async_check(struct drm_device *dev, { struct drm_crtc *crtc; struct drm_crtc_state *crtc_state; - struct drm_plane *plane; - struct drm_plane_state *old_plane_state, *new_plane_state; + struct drm_plane *plane = NULL; + struct drm_plane_state *old_plane_state = NULL; + struct drm_plane_state *new_plane_state = NULL; const struct drm_plane_helper_funcs *funcs; int i, n_planes = 0; -- 2.14.1

2 2

[PATCH v3 0/5] Implement CRC and Add necessary infrastructure
by Haneen Mohammed 23 Jul '18

23 Jul '18

This patchset implement CRC debugfs API and add the necessary infrastructure required to enable to compute and add CRCs entries. 1. add functions to map/unmap buffers to kernel address space. 2. map/unmap buffers in the prepare/cleanup_fb hooks. 3. compute crc using crc32 on the visible portion of the buffer with appropriate synchronization methods. Haneen Mohammed (5): drm/vkms: Add functions to map/unmap GEM backing storage drm/vkms: map/unmap buffers in [prepare/cleanup]_fb hooks drm/vkms: Add atomic_helper_check_plane_state drm/vkms: subclass CRTC state drm/vkms: Implement CRC debugfs API drivers/gpu/drm/vkms/Makefile | 2 +- drivers/gpu/drm/vkms/vkms_crc.c | 66 ++++++++++++++++++ drivers/gpu/drm/vkms/vkms_crtc.c | 109 +++++++++++++++++++++++++++--- drivers/gpu/drm/vkms/vkms_drv.c | 1 + drivers/gpu/drm/vkms/vkms_drv.h | 41 +++++++++++ drivers/gpu/drm/vkms/vkms_gem.c | 80 +++++++++++++++++++++- drivers/gpu/drm/vkms/vkms_plane.c | 74 ++++++++++++++++++++ 7 files changed, 360 insertions(+), 13 deletions(-) create mode 100644 drivers/gpu/drm/vkms/vkms_crc.c -- 2.17.1

2 8

etnaviv oops on imx6dl/2G, works fine on imx6s/512M
by Michal Vokáč 23 Jul '18

23 Jul '18

Ahoj, I encountered an error in etnaviv driver on one of my two very similar SBCs. They have the same board design but slightly different HW configuration. SW configuration/setup is the same for both. Including kernel configuration. 1. is based on i.MX6S, single core, 512MB RAM, parallel LCD. 2. is based on i.MX6DL, dual core, 2GB RAM, HDMI display. System No.1 boots OK. I can run kmscube and HW acceleration works. System No.2 does not boot until I disable etnaviv driver in the kernel. When digging deeper where the problem might be I found those two threads [1],[2]. None of these apply to me. CMA is enabled and I do not specify fixed CMA regions in DT. I get the same results on v4.18-rc2 and on v4.18-rc5. Relevant parts of boot log: [ 0.000000] Memory: 1984044K/2097152K available (11264K kernel code, 738K rwdata, 2672K rodata, 1024K init, 426K bss, 113108K reserved, 0K cma-reserved, 262144K highmem) [ 0.000000] Virtual kernel memory layout: [ 0.000000] vector : 0xffff0000 - 0xffff1000 ( 4 kB) [ 0.000000] fixmap : 0xffc00000 - 0xfff00000 (3072 kB) [ 0.000000] vmalloc : 0xf0800000 - 0xff800000 ( 240 MB) [ 0.000000] lowmem : 0x80000000 - 0xf0000000 (1792 MB) [ 0.000000] pkmap : 0x7fe00000 - 0x80000000 ( 2 MB) [ 0.000000] .text : 0x(ptrval) - 0x(ptrval) (12256 kB) [ 0.000000] .init : 0x(ptrval) - 0x(ptrval) (1024 kB) [ 0.000000] .data : 0x(ptrval) - 0x(ptrval) ( 739 kB) [ 0.000000] .bss : 0x(ptrval) - 0x(ptrval) ( 427 kB) [... snip ...] [ 8.973561] etnaviv etnaviv: bound 130000.gpu (ops gpu_ops) [ 8.979464] etnaviv etnaviv: bound 134000.gpu (ops gpu_ops) [ 8.985105] etnaviv-gpu 130000.gpu: model: GC880, revision: 5106 [ 8.997639] etnaviv-gpu 130000.gpu: command buffer outside valid memory window [ 9.005465] etnaviv-gpu 134000.gpu: model: GC320, revision: 5007 [ 9.018325] etnaviv-gpu 134000.gpu: command buffer outside valid memory window [ 9.026767] [drm] Initialized etnaviv 1.2.0 20151214 for etnaviv on minor 0 [ 9.035510] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [ 9.042138] [drm] No driver support for vblank timestamp query. [ 9.048363] imx-drm display-subsystem: bound imx-ipuv3-crtc.2 (ops ipu_crtc_ops) [ 9.055948] imx-drm display-subsystem: bound imx-ipuv3-crtc.3 (ops ipu_crtc_ops) [ 9.063409] [drm] Cannot find any crtc or sizes [ 9.068354] [drm] Initialized imx-drm 1.0.0 20120507 for display-subsystem on minor 1 [ 9.076283] imx-ipuv3 2400000.ipu: IPUv3H probed [... snip ...] [ 9.215731] Unable to handle kernel paging request at virtual address f0c01ff4 [ 9.234977] pgd = (ptrval) [ 9.237694] [f0c01ff4] *pgd=7c944811, *pte=00000000, *ppte=00000000 [ 9.244028] Internal error: Oops: 807 [#1] PREEMPT SMP ARM [ 9.249530] CPU: 1 PID: 35 Comm: kworker/1:1 Not tainted 4.18.0-rc5-00011-g750c9aa-dirty #2 [ 9.263533] Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree) [ 9.263555] Workqueue: pm pm_runtime_work [ 9.276113] PC is at etnaviv_buffer_end+0x290/0x2e8 [ 9.276124] LR is at 0xf0c02000 [ 9.285960] pc : [<805d4e50>] lr : [<f0c02000>] psr: 80000013 [ 9.285965] sp : ec4bbdb0 ip : f0c02000 fp : ec4bbdcc [ 9.285970] r10: 00000000 r9 : ec220800 r8 : ec92e000 [ 9.285975] r7 : 00000002 r6 : f0c02000 r5 : fffffff0 r4 : eca11c10 [ 9.285983] r3 : 00000034 r2 : f0c01ff0 r1 : 10000000 r0 : fca40000 [ 9.294001] Flags: Nzcv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none [ 9.294007] Control: 10c5387d Table: 1000404a DAC: 00000051 [ 9.294013] Process kworker/1:1 (pid: 35, stack limit = 0x(ptrval)) [ 9.294020] Stack: (0xec4bbdb0 to 0xec4bc000) [ 9.294029] bda0: eca11c10 eca11c1c 252538f9 00000002 [ 9.309515] bdc0: ec4bbde4 ec4bbdd0 805dc7d8 805d4bcc ec208c10 ec92e198 ec4bbdf4 ec4bbde8 [ 9.319963] bde0: 805fcb2c 805dc780 ec4bbe2c ec4bbdf8 80609f38 805fcafc ec128080 ec167340 [ 9.333018] be00: ec4bbe84 ec208c10 00000000 ec208c88 80609e80 00000008 00000000 81103d00 [ 9.333028] be20: ec4bbe64 ec4bbe30 805febc8 80609e8c ec128000 eedd7280 ec167340 ec208c10 [ 9.333039] be40: 80609e80 81103d00 00000000 00000008 00000000 81103d00 ec4bbe84 ec4bbe68 [ 9.345657] be60: 805fed04 805feb04 ec208c10 80609e80 81103d00 00000000 ec4bbedc ec4bbe88 [ 9.345667] be80: 805ffb74 805fece0 81106548 8016eeb4 ffffe000 0000000a ec4bbec4 ec4bbea8 [ 9.345678] bea0: 80154030 80174120 ec208c88 93cd5b28 eedd6e00 ec208cc4 ec208c88 eedd6e00 [ 9.357689] bec0: eedd9200 00000000 811b3e50 00000000 ec4bbef4 ec4bbee0 806003e0 805ffa2c [ 9.357698] bee0: ec208cc4 ec216d80 ec4bbf34 ec4bbef8 80142080 80600368 80154030 80174120 [ 9.357710] bf00: eedd6e00 eedd6e00 eedd6e00 ec216d80 eedd6e00 ec216d94 eedd6e18 ffffe000 [ 9.370243] bf20: 00000008 81103d00 ec4bbf74 ec4bbf38 80142450 80141e7c 80b7bc04 80de6d64 [ 9.370252] bf40: 811b37ba eedd6e00 8014882c ec3b7dc0 ec214300 00000000 ec4ba000 ec216d80 [ 9.370262] bf60: 801423f4 ec169e84 ec4bbfac ec4bbf78 80148b60 80142400 ec3b7ddc ec3b7ddc [ 9.384706] bf80: 00000000 ec214300 801489f4 00000000 00000000 00000000 00000000 00000000 [ 9.384720] bfa0: 00000000 ec4bbfb0 801010e8 80148a00 00000000 00000000 00000000 00000000 [ 9.398470] bfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 9.398479] bfe0: 00000000 00000000 00000000 00000000 00000013 00000000 00000000 00000000 [ 9.398508] [<805d4e50>] (etnaviv_buffer_end) from [<805dc7d8>] (etnaviv_gpu_rpm_suspend+0x64/0x8c) [ 9.412593] [<805dc7d8>] (etnaviv_gpu_rpm_suspend) from [<805fcb2c>] (pm_generic_runtime_suspend+0x3c/0x48) [ 9.428952] [<805fcb2c>] (pm_generic_runtime_suspend) from [<80609f38>] (genpd_runtime_suspend+0xb8/0x26c) [ 9.428968] [<80609f38>] (genpd_runtime_suspend) from [<805febc8>] (__rpm_callback+0xd0/0x1dc) [ 9.442973] [<805febc8>] (__rpm_callback) from [<805fed04>] (rpm_callback+0x30/0x90) [ 9.442985] [<805fed04>] (rpm_callback) from [<805ffb74>] (rpm_suspend+0x154/0x6c4) [ 9.442998] [<805ffb74>] (rpm_suspend) from [<806003e0>] (pm_runtime_work+0x84/0xa0) [ 9.459353] [<806003e0>] (pm_runtime_work) from [<80142080>] (process_one_work+0x210/0x584) [ 9.459367] [<80142080>] (process_one_work) from [<80142450>] (worker_thread+0x5c/0x5a8) [ 9.476068] [<80142450>] (worker_thread) from [<80148b60>] (kthread+0x16c/0x174) [ 9.476080] [<80148b60>] (kthread) from [<801010e8>] (ret_from_fork+0x14/0x2c) [ 9.476088] Exception stack(0xec4bbfb0 to 0xec4bbff8) [ 9.492440] bfa0: 00000000 00000000 00000000 00000000 [ 9.506537] bfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 9.506544] bfe0: 00000000 00000000 00000000 00000000 00000013 00000000 [ 9.506556] Code: e5946144 e2833004 e0862005 e584314c (e5820004) [ 9.522969] ---[ end trace 0c5910ecf0b034f8 ]--- [ 9.548650] Unable to handle kernel paging request at virtual address f0e43ff4 [ 9.562131] pgd = (ptrval) [ 9.579448] [f0e43ff4] *pgd=7cdff811 [ 9.596554] , *pte=00000000 [ 9.612046] , *ppte=00000000 [ 9.641974] Internal error: Oops: 807 [#2] PREEMPT SMP ARM [ 9.655812] CPU: 1 PID: 18 Comm: kworker/1:0 Tainted: G D 4.18.0-rc5-00011-g750c9aa-dirty #2 [ 9.655816] Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree) [ 9.655837] Workqueue: pm pm_runtime_work [ 9.686025] PC is at etnaviv_buffer_end+0x290/0x2e8 [ 9.686035] LR is at 0xf0e44000 [ 9.698309] pc : [<805d4e50>] lr : [<f0e44000>] psr: 80000113 [ 9.713875] sp : ec169db0 ip : f0e44000 fp : ec169dcc [ 9.713881] r10: 00000000 r9 : ec220b00 r8 : ec92e000 [ 9.713886] r7 : 00000002 r6 : f0e44000 r5 : fffffff0 r4 : eca12010 [ 9.713892] r3 : 00000034 r2 : f0e43ff0 r1 : 10000000 r0 : fcd00000 [ 9.713901] Flags: Nzcv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none [ 9.729470] Control: 10c5387d Table: 1000404a DAC: 00000051 [ 9.729477] Process kworker/1:0 (pid: 18, stack limit = 0x(ptrval)) [ 9.729482] Stack: (0xec169db0 to 0xec16a000) [ 9.729491] 9da0: eca12010 eca1201c 38fd2c6b 00000002 [ 9.742203] 9dc0: ec169de4 ec169dd0 805dc7d8 805d4bcc ec208e10 ec92e198 ec169df4 ec169de8 [ 9.752821] 9de0: 805fcb2c 805dc780 ec169e2c ec169df8 80609f38 805fcafc ec169e34 ec169e08 [ 9.752830] 9e00: 80161a18 ec208e10 00000000 ec208e88 80609e80 00000008 00000000 81103d00 [ 9.752840] 9e20: ec169e64 ec169e30 805febc8 80609e8c 801535b0 80161950 ec96f2c0 ec208e10 [ 9.767457] 9e40: 80609e80 81103d00 00000000 00000008 00000000 81103d00 ec169e84 ec169e68 [ 9.767467] 9e60: 805fed04 805feb04 ec208e10 80609e80 81103d00 00000000 ec169edc ec169e88 [ 9.767476] 9e80: 805ffb74 805fece0 81106548 8016eeb4 ffffe000 0000000a ec169ec4 ec169ea8 [ 9.777577] 9ea0: 80154030 80174120 ec208e88 93cd5b28 eedd6e00 ec208ec4 ec208e88 eedd6e00 [ 9.788547] 9ec0: eedd9200 00000000 811b3e50 00000000 ec169ef4 ec169ee0 806003e0 805ffa2c [ 9.797695] 9ee0: ec208ec4 ec0ef680 ec169f34 ec169ef8 80142080 80600368 eedd6e00 eedd6e00 [ 9.806061] 9f00: eedd6e18 eedd6e18 eedd6e44 ec0ef680 eedd6e00 ec0ef694 eedd6e18 ffffe000 [ 9.821371] 9f20: 00000008 81103d00 ec169f74 ec169f38 80142450 80141e7c 80b7bc04 80de6d64 [ 9.832340] 9f40: 811b37ba eedd6e00 8014882c ec0fd580 ec0fd500 00000000 ec168000 ec0ef680 [ 9.848606] 9f60: 801423f4 ec11dd7c ec169fac ec169f78 80148b60 80142400 ec0fd59c ec0fd59c [ 9.848616] 9f80: 00000000 ec0fd500 801489f4 00000000 00000000 00000000 00000000 00000000 [ 9.848626] 9fa0: 00000000 ec169fb0 801010e8 80148a00 00000000 00000000 00000000 00000000 [ 9.858464] 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 9.868915] 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 00000000 00000000 [ 9.877991] [<805d4e50>] (etnaviv_buffer_end) from [<805dc7d8>] (etnaviv_gpu_rpm_suspend+0x64/0x8c) [ 9.878009] [<805dc7d8>] (etnaviv_gpu_rpm_suspend) from [<805fcb2c>] (pm_generic_runtime_suspend+0x3c/0x48) [ 9.890021] [<805fcb2c>] (pm_generic_runtime_suspend) from [<80609f38>] (genpd_runtime_suspend+0xb8/0x26c) [ 9.900468] [<80609f38>] (genpd_runtime_suspend) from [<805febc8>] (__rpm_callback+0xd0/0x1dc) [ 9.913520] [<805febc8>] (__rpm_callback) from [<805fed04>] (rpm_callback+0x30/0x90) [ 9.913532] [<805fed04>] (rpm_callback) from [<805ffb74>] (rpm_suspend+0x154/0x6c4) [ 9.913544] [<805ffb74>] (rpm_suspend) from [<806003e0>] (pm_runtime_work+0x84/0xa0) [ 9.927988] [<806003e0>] (pm_runtime_work) from [<80142080>] (process_one_work+0x210/0x584) [ 9.928005] [<80142080>] (process_one_work) from [<80142450>] (worker_thread+0x5c/0x5a8) [ 9.940023] [<80142450>] (worker_thread) from [<80148b60>] (kthread+0x16c/0x174) [ 9.952553] [<80148b60>] (kthread) from [<801010e8>] (ret_from_fork+0x14/0x2c) [ 9.966639] Exception stack(0xec169fb0 to 0xec169ff8) [ 9.966647] 9fa0: 00000000 00000000 00000000 00000000 [ 9.966658] 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 9.981800] 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 [ 9.998159] Code: e5946144 e2833004 e0862005 e584314c (e5820004) [ 9.998213] ---[ end trace 0c5910ecf0b034f9 ]--- The system does not make it to the login promt but it seems kernel is running as I see a LED with a heart-beat trigger flashing. Any idea what might be wrong? How to further debug this? Thanks in advance, Michal [1] https://lists.freedesktop.org/archives/etnaviv/2017-November/001242.html [2] https://lists.freedesktop.org/archives/dri-devel/2017-July/145934.html

2 2

[PATCH 00/10] Improve crc-core driver interface
by Mahesh Kumar 23 Jul '18

23 Jul '18

This series improves crc-core <-> driver interface. This series adds following functionality in the crc-core - Now control node will print all the available sources if implemented by driver along with current source. - Setting of sorce will fail if provided source is not supported - cleanup of crtc_crc_open function first allocate memory before enabling CRC generation - Don't block open() call instead wait in crc read call. Following IGT will fail due to crc-core <-> driver interface change igt@kms_pipe_crc_basic@bad-source <now setting bad-source itself will fail> ig@kms_pipe_crc_basic@nonblocking-crc-pipe-X ig@kms_pipe_crc_basic@nonblocking-crc-pipe-X-frame-sequence In nonblocking crc tests we'll get lesser crc's due to skipping crc AMD/Rockchip/rcar code path is not validated and may need inputs Cc: dri-devel(a)lists.freedesktop.org Mahesh Kumar (10): drm: crc: Introduce verify_crc_source callback drm: crc: Introduce get_crc_sources callback drm/rockchip/crc: Implement verify_crc_source callback drm/amdgpu_dm/crc: Implement verify_crc_source callback drm/rcar-du/crc: Implement verify_crc_source callback drm/i915/crc: implement verify_crc_source callback drm/i915/crc: implement get_crc_sources callback drm/crc: Cleanup crtc_crc_open function Revert "drm: crc: Wait for a frame before returning from open()" drm/rcar-du/crc: Implement get_crc_sources callback drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 7 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 20 ++- drivers/gpu/drm/drm_debugfs_crc.c | 92 +++++++----- drivers/gpu/drm/i915/intel_display.c | 2 + drivers/gpu/drm/i915/intel_drv.h | 9 +- drivers/gpu/drm/i915/intel_pipe_crc.c | 119 ++++++++++++++- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 165 ++++++++++++++++++--- drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 3 + drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 26 +++- include/drm/drm_crtc.h | 41 ++++- 11 files changed, 407 insertions(+), 78 deletions(-) -- 2.16.2

2 11

[PATCH v3] drm: Replace NULL with error value in drm_prime_pages_to_sg
by Oleksandr Andrushchenko 23 Jul '18

23 Jul '18

From: Oleksandr Andrushchenko <oleksandr_andrushchenko(a)epam.com> Dan Carpenter has reported that there is the following static checker warning: drivers/gpu/drm/drm_prime.c:317 drm_gem_map_dma_buf() warn: 'sgt' can also be NULL 314 sgt = obj->dev->driver->gem_prime_get_sg_table(obj); 315 316 if (!IS_ERR(sgt)) { 317 if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir, Problematic functions are xen_drm_front_gem_get_sg_table and drm_gem_cma_prime_get_sg_table. Fix those by replacing NULL with error value. Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko(a)epam.com> Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- drivers/gpu/drm/drm_gem_cma_helper.c | 4 ++-- drivers/gpu/drm/xen/xen_drm_front_gem.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c index 80a5115c3846..1d2ced882b66 100644 --- a/drivers/gpu/drm/drm_gem_cma_helper.c +++ b/drivers/gpu/drm/drm_gem_cma_helper.c @@ -436,7 +436,7 @@ struct sg_table *drm_gem_cma_prime_get_sg_table(struct drm_gem_object *obj) sgt = kzalloc(sizeof(*sgt), GFP_KERNEL); if (!sgt) - return NULL; + return ERR_PTR(-ENOMEM); ret = dma_get_sgtable(obj->dev->dev, sgt, cma_obj->vaddr, cma_obj->paddr, obj->size); @@ -447,7 +447,7 @@ struct sg_table *drm_gem_cma_prime_get_sg_table(struct drm_gem_object *obj) out: kfree(sgt); - return NULL; + return ERR_PTR(ret); } EXPORT_SYMBOL_GPL(drm_gem_cma_prime_get_sg_table); diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c index c85bfe7571cb..47ff019d3aef 100644 --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c @@ -179,7 +179,7 @@ struct sg_table *xen_drm_front_gem_get_sg_table(struct drm_gem_object *gem_obj) struct xen_gem_object *xen_obj = to_xen_gem_obj(gem_obj); if (!xen_obj->pages) - return NULL; + return ERR_PTR(-ENOMEM); return drm_prime_pages_to_sg(xen_obj->pages, xen_obj->num_pages); } -- 2.18.0

2 3

[PATCH] drm/etnaviv: try harder to dump core
by Russell King 23 Jul '18

23 Jul '18

Try a bit harder to produce a devcoredump when things go wrong. If we fail to allocate the memory for a dump including the actual bo contents, omit the bos and try again. Capturing some information from the GPU is better than having no information. Signed-off-by: Russell King <rmk+kernel(a)armlinux.org.uk> --- drivers/gpu/drm/etnaviv/etnaviv_dump.c | 30 ++++++++++++++++++++++-------- 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_dump.c b/drivers/gpu/drm/etnaviv/etnaviv_dump.c index 48aef6cf6a42..c9987bc38acc 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_dump.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_dump.c @@ -129,6 +129,7 @@ void etnaviv_core_dump(struct etnaviv_gpu *gpu) unsigned int n_obj, n_bomap_pages; size_t file_size, mmu_size; __le64 *bomap, *bomap_start; + bool bos = true; /* Only catch the first event, or when manually re-armed */ if (!etnaviv_dump_core) @@ -137,6 +138,7 @@ void etnaviv_core_dump(struct etnaviv_gpu *gpu) mmu_size = etnaviv_iommu_dump_size(gpu->mmu); +again: /* We always dump registers, mmu, ring and end marker */ n_obj = 4; n_bomap_pages = 0; @@ -159,9 +161,12 @@ void etnaviv_core_dump(struct etnaviv_gpu *gpu) continue; obj = vram->object; - file_size += obj->base.size; n_bomap_pages += obj->base.size >> PAGE_SHIFT; - n_obj++; + + if (bos) { + file_size += obj->base.size; + n_obj++; + } } /* If we have any buffer objects, add a bomap object */ @@ -177,6 +182,11 @@ void etnaviv_core_dump(struct etnaviv_gpu *gpu) iter.start = __vmalloc(file_size, GFP_KERNEL | __GFP_NOWARN | __GFP_NORETRY, PAGE_KERNEL); if (!iter.start) { + if (bos) { + dev_warn(gpu->dev, "devcoredump too big, trying without bos\n"); + bos = false; + goto again; + } dev_warn(gpu->dev, "failed to allocate devcoredump file\n"); return; } @@ -234,14 +244,18 @@ void etnaviv_core_dump(struct etnaviv_gpu *gpu) *bomap++ = cpu_to_le64(page_to_phys(*pages++)); } - iter.hdr->iova = cpu_to_le64(vram->iova); + if (bos) { + iter.hdr->iova = cpu_to_le64(vram->iova); - vaddr = etnaviv_gem_vmap(&obj->base); - if (vaddr) - memcpy(iter.data, vaddr, obj->base.size); + vaddr = etnaviv_gem_vmap(&obj->base); + dev_crit(gpu->dev, "Copying object %p ops %pS vaddr %p to %p size %zu\n", + obj, obj->ops, vaddr, iter.data, obj->base.size); + if (vaddr) + memcpy(iter.data, vaddr, obj->base.size); - etnaviv_core_dump_header(&iter, ETDUMP_BUF_BO, iter.data + - obj->base.size); + etnaviv_core_dump_header(&iter, ETDUMP_BUF_BO, iter.data + + obj->base.size); + } } etnaviv_core_dump_header(&iter, ETDUMP_BUF_END, iter.data); -- 2.7.4

2 1

[Bug 106670] AMD GPU Error, random lockup, Ryzen 2500U Vega 8 GPU
by bugzilla-daemon＠freedesktop.org 23 Jul '18

23 Jul '18

https://bugs.freedesktop.org/show_bug.cgi?id=106670 Michel Dänzer <michel(a)daenzer.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #7 from Michel Dänzer <michel(a)daenzer.net> --- (In reply to JerryD from comment #6) > I used grubby to add to my kernel boot command 'idle=nomwait' and the > problem seems resolved. The mwait instruction is known to possibly hang > threads on some earlier released ryzen chips as documented in the AMD Errata. Thanks for the follow-up, resolving accordingly. -- You are receiving this mail because: You are the assignee for the bug.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel July 2018