dri-devel July 2018

dri-devel@lists.freedesktop.org

277 participants
1883 discussions

[PATCH] drm: mxsfb: fix runtime PM handling
by Anson Huang 13 Jul '18

13 Jul '18

As display power domain is combined with lcdif node on some i.MX platforms like i.MX6SL, when lcdif driver is enabled, the mxsfb_load is called to enable runtime pm, and a pair of pm_runtime_get_sync and pm_runtime_put_sync are also called, that will cause generic power domain driver to disable lcdif power domain and lcdif is no longer working, the lcdif power should ONLY be turned off when display is disabled, so move the pm_runtime_put_sync to mxsfb_unload and remove the pm_runtime_get_sync in mxsfb_unload as well, in this way, when display is enabled, the lcdif power will be always ON until the display is disabled. Signed-off-by: Anson Huang <Anson.Huang(a)nxp.com> --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c index ffe5137..1ba179b 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c @@ -235,7 +235,6 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags) pm_runtime_get_sync(drm->dev); ret = drm_irq_install(drm, platform_get_irq(pdev, 0)); - pm_runtime_put_sync(drm->dev); if (ret < 0) { dev_err(drm->dev, "Failed to install IRQ handler\n"); @@ -264,6 +263,7 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags) err_irq: drm_panel_detach(mxsfb->panel); err_vblank: + pm_runtime_put_sync(drm->dev); pm_runtime_disable(drm->dev); return ret; @@ -279,7 +279,6 @@ static void mxsfb_unload(struct drm_device *drm) drm_kms_helper_poll_fini(drm); drm_mode_config_cleanup(drm); - pm_runtime_get_sync(drm->dev); drm_irq_uninstall(drm); pm_runtime_put_sync(drm->dev); -- 2.7.4

5 8

[PATCH v2] drm/client: Fix double free in error path
by Noralf Trønnes 13 Jul '18

13 Jul '18

This fixes a static checker warning: drivers/gpu/drm/drm_client.c:289 drm_client_buffer_create() error: double free of 'buffer' Extend drm_client_buffer_delete() to handle the case when there's no dumb buffer attached and drop the extra kfree. Fixes: c76f0f7cb546 ("drm: Begin an API for in-kernel clients") Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com> Cc: Daniel Vetter <daniel.vetter(a)ffwll.ch> Signed-off-by: Noralf Trønnes <noralf(a)tronnes.org> Reviewed-by: Daniel Vetter <daniel.vetter(a)ffwll.ch> --- Changes since version 1: - Let drm_client_buffer_delete() handle all freeing (Daniel Vetter) drivers/gpu/drm/drm_client.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c index 9b142f58d489..baff50a4c234 100644 --- a/drivers/gpu/drm/drm_client.c +++ b/drivers/gpu/drm/drm_client.c @@ -218,7 +218,9 @@ static void drm_client_buffer_delete(struct drm_client_buffer *buffer) if (buffer->gem) drm_gem_object_put_unlocked(buffer->gem); - drm_mode_destroy_dumb(dev, buffer->handle, buffer->client->file); + if (buffer->handle) + drm_mode_destroy_dumb(dev, buffer->handle, buffer->client->file); + kfree(buffer); } @@ -243,7 +245,7 @@ drm_client_buffer_create(struct drm_client_dev *client, u32 width, u32 height, u dumb_args.bpp = drm_format_plane_cpp(format, 0) * 8; ret = drm_mode_create_dumb(dev, &dumb_args, client->file); if (ret) - goto err_free; + goto err_delete; buffer->handle = dumb_args.handle; buffer->pitch = dumb_args.pitch; @@ -276,8 +278,6 @@ drm_client_buffer_create(struct drm_client_dev *client, u32 width, u32 height, u err_delete: drm_client_buffer_delete(buffer); -err_free: - kfree(buffer); return ERR_PTR(ret); } -- 2.15.1

1 1

[PATCH] video: fbdev: via: hide unused procfs helpers
by YueHaibing 13 Jul '18

13 Jul '18

When CONFIG_PROC_FS isn't set, gcc warning this: drivers/video/fbdev/via/viafbdev.c:1471:12: warning: ‘viafb_sup_odev_proc_show’ defined but not used [-Wunused-function] static int viafb_sup_odev_proc_show(struct seq_file *m, void *v) ^ fix this by adding #ifdef around it. Signed-off-by: YueHaibing <yuehaibing(a)huawei.com> --- drivers/video/fbdev/via/viafbdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/via/viafbdev.c b/drivers/video/fbdev/via/viafbdev.c index d2f7850..edca3e0 100644 --- a/drivers/video/fbdev/via/viafbdev.c +++ b/drivers/video/fbdev/via/viafbdev.c @@ -1468,12 +1468,14 @@ static const struct file_operations viafb_vt1636_proc_fops = { #endif /* CONFIG_FB_VIA_DIRECT_PROCFS */ +#ifdef CONFIG_PROC_FS static int viafb_sup_odev_proc_show(struct seq_file *m, void *v) { via_odev_to_seq(m, supported_odev_map[ viaparinfo->shared->chip_info.gfx_chip_name]); return 0; } +#endif static ssize_t odev_update(const char __user *buffer, size_t count, u32 *odev) { -- 2.7.0

1 1

[Bug 107183] Enabling Glamor takes half a second
by bugzilla-daemon＠freedesktop.org 13 Jul '18

13 Jul '18

https://bugs.freedesktop.org/show_bug.cgi?id=107183 Bug ID: 107183 Summary: Enabling Glamor takes half a second Product: DRI Version: XOrg git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: DRM/Radeon Assignee: dri-devel(a)lists.freedesktop.org Reporter: pmenzel+bugs.freedesktop(a)molgen.mpg.de Created attachment 140548 --> https://bugs.freedesktop.org/attachment.cgi?id=140548&action=edit X.Org X Server 1.20.0 log The X.Org X Server start up takes well over a second on an ASRock E350M1. Debian Sid/unstable with Linux 4.18-rc4+ is used. Looking at the log, there is half a second delay right below. ``` [ 78.639] X.Org X Server 1.20.0 X Protocol Version 11, Revision 0 […] [ 78.796] (II) Module glamoregl: vendor="X.Org Foundation" [ 78.796] compiled for 1.20.0, module version = 1.0.1 [ 78.796] ABI class: X.Org ANSI C Emulation, version 0.4 [ 79.294] (II) RADEON(0): glamor X acceleration enabled on AMD PALM (DRM 2.50.0 / 4.18.0-rc4-00832-g217000c98815, LLVM 6.0.1) […] ``` -- You are receiving this mail because: You are the assignee for the bug.

1 7

[PATCH] drm/stm: Replace drm_dev_unref with drm_dev_put
by Thomas Zimmermann 13 Jul '18

13 Jul '18

This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann <tzimmermann(a)suse.de> Acked-by: Philippe Cornu <philippe.cornu(a)st.com> --- drivers/gpu/drm/stm/drv.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/stm/drv.c b/drivers/gpu/drm/stm/drv.c index 8698e08313e1..f2021b23554d 100644 --- a/drivers/gpu/drm/stm/drv.c +++ b/drivers/gpu/drm/stm/drv.c @@ -148,16 +148,16 @@ static int stm_drm_platform_probe(struct platform_device *pdev) ret = drv_load(ddev); if (ret) - goto err_unref; + goto err_put; ret = drm_dev_register(ddev, 0); if (ret) - goto err_unref; + goto err_put; return 0; -err_unref: - drm_dev_unref(ddev); +err_put: + drm_dev_put(ddev); return ret; } @@ -170,7 +170,7 @@ static int stm_drm_platform_remove(struct platform_device *pdev) drm_dev_unregister(ddev); drv_unload(ddev); - drm_dev_unref(ddev); + drm_dev_put(ddev); return 0; } -- 2.18.0

2 1

[PATCH] drm/sti: Replace drm_dev_unref with drm_dev_put
by Thomas Zimmermann 13 Jul '18

13 Jul '18

This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann <tzimmermann(a)suse.de> Acked-by: Benjamin Gaignard <benjamin.gaignard(a)linaro.org> --- drivers/gpu/drm/sti/sti_drv.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c index 90c46b49c931..832fc43960ee 100644 --- a/drivers/gpu/drm/sti/sti_drv.c +++ b/drivers/gpu/drm/sti/sti_drv.c @@ -224,7 +224,7 @@ static int sti_bind(struct device *dev) ret = sti_init(ddev); if (ret) - goto err_drm_dev_unref; + goto err_drm_dev_put; ret = component_bind_all(ddev->dev, ddev); if (ret) @@ -248,8 +248,8 @@ static int sti_bind(struct device *dev) drm_mode_config_cleanup(ddev); err_cleanup: sti_cleanup(ddev); -err_drm_dev_unref: - drm_dev_unref(ddev); +err_drm_dev_put: + drm_dev_put(ddev); return ret; } @@ -259,7 +259,7 @@ static void sti_unbind(struct device *dev) drm_dev_unregister(ddev); sti_cleanup(ddev); - drm_dev_unref(ddev); + drm_dev_put(ddev); } static const struct component_master_ops sti_ops = { -- 2.18.0

2 1

[GIT PULL] Armada DRM fixes fixes
by Russell King 13 Jul '18

13 Jul '18

Hi David, The following changes since commit 29dcea88779c856c7dc92040a0c01233263101d4: Linux 4.17 (2018-06-03 14:15:21 -0700) are available in the git repository at: git://git.armlinux.org.uk/~rmk/linux-arm.git drm-armada-fixes for you to fetch changes up to 92298c1cd8e8a6b56322b602ad72b54e6237631d: drm/armada: fix irq handling (2018-07-09 11:32:58 +0100) ---------------------------------------------------------------- Russell King (2): drm/armada: fix colorkey mode property drm/armada: fix irq handling drivers/gpu/drm/armada/armada_crtc.c | 12 ++++++++++-- drivers/gpu/drm/armada/armada_hw.h | 1 + drivers/gpu/drm/armada/armada_overlay.c | 30 ++++++++++++++++++++++-------- 3 files changed, 33 insertions(+), 10 deletions(-)

1 0

[PATCH] backlight: adp8860: Mark expected switch fall-through
by Gustavo A. R. Silva 13 Jul '18

13 Jul '18

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <gustavo(a)embeddedor.com> --- drivers/video/backlight/adp8860_bl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c index 16119bd..f1dc41c 100644 --- a/drivers/video/backlight/adp8860_bl.c +++ b/drivers/video/backlight/adp8860_bl.c @@ -690,6 +690,7 @@ static int adp8860_probe(struct i2c_client *client, switch (ADP8860_MANID(reg_val)) { case ADP8863_MANUFID: data->gdwn_dis = !!pdata->gdwn_dis; + /* fall through */ case ADP8860_MANUFID: data->en_ambl_sens = !!pdata->en_ambl_sens; break; -- 2.7.4

4 4

[PULL] drm-misc-fixes
by Maarten Lankhorst 13 Jul '18

13 Jul '18

Hi Dave, A single fix for building sun4i for v4.18-rc5. drm-misc-fixes-2018-07-13: Fixes for v4.18-rc5: - Single fix for a build error when the driver is builtin, but the backend is a loadable module. The following changes since commit 44f9a4b0dc7563669772198e5b226cab58a00167: drm/bridge/sii8620: Fix link mode selection (2018-07-04 16:27:51 +0200) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-fixes-2018-07-13 for you to fetch changes up to 3156b53c2e2fadafa1a16412a8791b38f94b5bdc: drm/sun4i: link in front-end code if needed (2018-07-09 09:54:33 +0200) ---------------------------------------------------------------- Fixes for v4.18-rc5: - Single fix for a build error when the driver is builtin, but the backend is a loadable module. ---------------------------------------------------------------- Arnd Bergmann (1): drm/sun4i: link in front-end code if needed drivers/gpu/drm/sun4i/Makefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)

1 0

[PATCH 0/3] ARM: imx: Make DRM_MXSFB and FB_MXS coexist
by Leonard Crestez 13 Jul '18

13 Jul '18

Some imx boards have new drm-style bindings for lcdif devices but using them requires rebuilding the kernel with FB_MXS=n DRM_MXSFB=y. It is relatively easy to allow both drivers to coexist by renaming drm/mxsfb to "mxsfb-drm" and making the old fbdev driver return -ENODEV instead of -ENOENT when it fails to find the display node. This makes display on imx6sx-sdb "just work" with both styles of bindings. In order to test the old bindings I locally reverted commit 7caa59e0d40c ("ARM: dts: imx6sx-sdb: Convert from fbdev to drm bindings") Leonard Crestez (3): drm: mxsfb: Change driver.name to mxsfb-drm fbdev: mxsfb: Return ENODEV on missing display node ARM: imx_v6_v7_defconfig: Enable DRM_MXSFB arch/arm/configs/imx_v6_v7_defconfig | 2 ++ drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 +- drivers/video/fbdev/mxsfb.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) -- 2.17.1

6 21

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel July 2018