dri-devel July 2018

dri-devel@lists.freedesktop.org

277 participants
1883 discussions

[PATCH] drm/sun4i: fix build failure with CONFIG_DRM_SUN8I_MIXER=m
by Arnd Bergmann 09 Jul '18

09 Jul '18

Having DRM_SUN4I built-in but DRM_SUN8I_MIXER as a loadable module results in a link error, as we try to access a symbol from the sun8i_tcon_top.ko module: ERROR: "sun8i_tcon_top_of_table" [drivers/gpu/drm/sun4i/sun8i-drm-hdmi.ko] undefined! ERROR: "sun8i_tcon_top_of_table" [drivers/gpu/drm/sun4i/sun4i-drm.ko] undefined! This solves the problem by making DRM_SUN8I_MIXER a 'bool' symbol, building the sun8i_tcon_top module the same way as the core sun4i-drm module whenever DRM_SUN8I_MIXER is enabled, or not building it at all otherwise. Alternatively, we could always build sun8i_tcon_top.ko along with sun4-drm.ko and detach it from the mixer module, I could not tell which way is more appropriate here. Fixes: 57e23de02f48 ("drm/sun4i: DW HDMI: Expand algorithm for possible crtcs") Fixes: ef0cf6441fbb ("drm/sun4i: Add support for traversing graph with TCON TOP") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- drivers/gpu/drm/sun4i/Kconfig | 2 +- drivers/gpu/drm/sun4i/Makefile | 4 +++- drivers/gpu/drm/sun4i/sun4i_drv.c | 3 ++- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/sun4i/Kconfig b/drivers/gpu/drm/sun4i/Kconfig index 156a865c3e6d..709461deb1c0 100644 --- a/drivers/gpu/drm/sun4i/Kconfig +++ b/drivers/gpu/drm/sun4i/Kconfig @@ -60,7 +60,7 @@ config DRM_SUN8I_DW_HDMI selected the module will be called sun8i_dw_hdmi. config DRM_SUN8I_MIXER - tristate "Support for Allwinner Display Engine 2.0 Mixer" + bool "Support for Allwinner Display Engine 2.0 Mixer" default MACH_SUN8I help Choose this option if you have an Allwinner SoC with the diff --git a/drivers/gpu/drm/sun4i/Makefile b/drivers/gpu/drm/sun4i/Makefile index cd27d02c94e2..11de3cd52dae 100644 --- a/drivers/gpu/drm/sun4i/Makefile +++ b/drivers/gpu/drm/sun4i/Makefile @@ -39,4 +39,6 @@ endif obj-$(CONFIG_DRM_SUN4I_HDMI) += sun4i-drm-hdmi.o obj-$(CONFIG_DRM_SUN6I_DSI) += sun6i-dsi.o obj-$(CONFIG_DRM_SUN8I_DW_HDMI) += sun8i-drm-hdmi.o -obj-$(CONFIG_DRM_SUN8I_MIXER) += sun8i-mixer.o sun8i_tcon_top.o +ifdef CONFIG_DRM_SUN8I_MIXER +obj-$(CONFIG_DRM_SUN4I) += sun8i-mixer.o sun8i_tcon_top.o +endif diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c index 6ddf4eaccb40..7551dcb34c71 100644 --- a/drivers/gpu/drm/sun4i/sun4i_drv.c +++ b/drivers/gpu/drm/sun4i/sun4i_drv.c @@ -216,7 +216,8 @@ static bool sun4i_drv_node_is_tcon_with_ch0(struct device_node *node) static bool sun4i_drv_node_is_tcon_top(struct device_node *node) { - return !!of_match_node(sun8i_tcon_top_of_table, node); + return IS_ENABLED(CONFIG_DRM_SUN8I_MIXER) && + !!of_match_node(sun8i_tcon_top_of_table, node); } static int compare_of(struct device *dev, void *data) diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c index 3459b9ec56c9..b18c8f175dba 100644 --- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c @@ -44,7 +44,8 @@ sun8i_dw_hdmi_mode_valid(struct drm_connector *connector, static bool sun8i_dw_hdmi_node_is_tcon_top(struct device_node *node) { - return !!of_match_node(sun8i_tcon_top_of_table, node); + return IS_ENABLED(CONFIG_DRM_SUN8I_MIXER) && + !!of_match_node(sun8i_tcon_top_of_table, node); } static u32 sun8i_dw_hdmi_find_possible_crtcs(struct drm_device *drm, -- 2.9.0

4 5

[PATCH v1] gpu: host1x: Skip IOMMU initialization if firewall is enabled
by Dmitry Osipenko 09 Jul '18

09 Jul '18

Host1x's CDMA can't access the command buffers if IOMMU and Host1x firewall are enabled in the kernels config because firewall doesn't map the copied buffer into IOVA space. Fix this by skipping IOMMU initialization if firewall is enabled as firewall merges sparse cmdbufs into a single contiguous buffer and hence IOMMU isn't needed in this case. Signed-off-by: Dmitry Osipenko <digetx(a)gmail.com> --- drivers/gpu/host1x/dev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c index f1d5f76e9c33..d88073e7d22d 100644 --- a/drivers/gpu/host1x/dev.c +++ b/drivers/gpu/host1x/dev.c @@ -218,6 +218,9 @@ static int host1x_probe(struct platform_device *pdev) return err; } + if (IS_ENABLED(CONFIG_TEGRA_HOST1X_FIREWALL)) + goto skip_iommu; + host->group = iommu_group_get(&pdev->dev); if (host->group) { struct iommu_domain_geometry *geometry; -- 2.17.0

2 2

[PATCH] gpu: host1x: Check whether size of unpin isn't 0
by Dmitry Osipenko 09 Jul '18

09 Jul '18

Only gather pins are mapped by the Host1x driver, regular BO relocations are not. Check whether size of unpin isn't 0, otherwise IOVA allocation at 0x0 could be erroneously released. Signed-off-by: Dmitry Osipenko <digetx(a)gmail.com> --- drivers/gpu/host1x/job.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/host1x/job.c b/drivers/gpu/host1x/job.c index e2f4a4d93d20..527a1cddb14f 100644 --- a/drivers/gpu/host1x/job.c +++ b/drivers/gpu/host1x/job.c @@ -569,7 +569,8 @@ void host1x_job_unpin(struct host1x_job *job) for (i = 0; i < job->num_unpins; i++) { struct host1x_job_unpin_data *unpin = &job->unpins[i]; - if (!IS_ENABLED(CONFIG_TEGRA_HOST1X_FIREWALL) && host->domain) { + if (!IS_ENABLED(CONFIG_TEGRA_HOST1X_FIREWALL) && + unpin->size && host->domain) { iommu_unmap(host->domain, job->addr_phys[i], unpin->size); free_iova(&host->iova, -- 2.18.0

2 1

[PATCH] drm/amdgpu/acp: Fix slab-out-of-bounds in mfd_add_device in acp_hw_init
by Daniel Kurtz 09 Jul '18

09 Jul '18

Commit 51f7415039d4 ("drm/amd/amdgpu: creating two I2S instances for stoney/cz") added support for the "BT_I2S" ACP i2s channel. As part of this change, one additional acp resource was added, but the "num_resource" count was accidentally incremented by 2. This incorrect count eventually causes mfd_add_device() to try to access an invalid memory address (the location of non-existent resource 5. This fault was detected by running a KASAN enabled kernel, which produced the following splat at boot: [ 6.612987] ================================================================== [ 6.613509] BUG: KASAN: slab-out-of-bounds in mfd_add_device+0x4bc/0x7a7 [ 6.613509] Read of size 8 at addr ffff880107d4dc58 by task swapper/0/1 [ 6.613509] [ 6.613509] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.14.33 #349 [ 6.613509] Hardware name: Google Grunt/Grunt, BIOS Google_Grunt.10543.0.2018_04_03_1812 04/02/2018 [ 6.613509] Call Trace: [ 6.613509] dump_stack+0x4d/0x63 [ 6.613509] print_address_description+0x80/0x2d6 [ 6.613509] ? mfd_add_device+0x4bc/0x7a7 [ 6.613509] kasan_report+0x255/0x295 [ 6.613509] mfd_add_device+0x4bc/0x7a7 [ 6.613509] ? kasan_kmalloc+0x99/0xa8 [ 6.613509] ? mfd_add_devices+0x58/0xe4 [ 6.613509] ? __kmalloc+0x154/0x178 [ 6.613509] mfd_add_devices+0xa5/0xe4 [ 6.613509] acp_hw_init+0x92e/0xc4a [ 6.613509] amdgpu_device_init+0x1dfb/0x22a2 [ 6.613509] ? kmalloc_order+0x53/0x5d [ 6.613509] ? kmalloc_order_trace+0x23/0xb3 [ 6.613509] amdgpu_driver_load_kms+0xce/0x267 [ 6.613509] drm_dev_register+0x169/0x2fb [ 6.613509] amdgpu_pci_probe+0x217/0x242 [ 6.613509] pci_device_probe+0x101/0x18e [ 6.613509] driver_probe_device+0x1dd/0x419 [ 6.613509] ? ___might_sleep+0x80/0x1b6 [ 6.613509] __driver_attach+0x9f/0xc9 [ 6.613509] ? driver_probe_device+0x419/0x419 [ 6.613509] bus_for_each_dev+0xbc/0xe1 [ 6.613509] bus_add_driver+0x189/0x2c0 [ 6.613509] driver_register+0x108/0x156 [ 6.613509] ? ttm_init+0x67/0x67 [ 6.613509] do_one_initcall+0xb2/0x161 [ 6.613509] kernel_init_freeable+0x25a/0x308 [ 6.613509] ? rest_init+0xcc/0xcc [ 6.613509] kernel_init+0x11/0x10d [ 6.613509] ? rest_init+0xcc/0xcc [ 6.613509] ret_from_fork+0x22/0x40 [ 6.613509] [ 6.613509] Allocated by task 1: [ 6.613509] save_stack+0x46/0xce [ 6.613509] kasan_kmalloc+0x99/0xa8 [ 6.613509] kmem_cache_alloc_trace+0x11a/0x13e [ 6.613509] acp_hw_init+0x210/0xc4a [ 6.613509] amdgpu_device_init+0x1dfb/0x22a2 [ 6.613509] amdgpu_driver_load_kms+0xce/0x267 [ 6.613509] drm_dev_register+0x169/0x2fb [ 6.613509] amdgpu_pci_probe+0x217/0x242 [ 6.613509] pci_device_probe+0x101/0x18e [ 6.613509] driver_probe_device+0x1dd/0x419 [ 6.613509] __driver_attach+0x9f/0xc9 [ 6.613509] bus_for_each_dev+0xbc/0xe1 [ 6.613509] bus_add_driver+0x189/0x2c0 [ 6.613509] driver_register+0x108/0x156 [ 6.613509] do_one_initcall+0xb2/0x161 [ 6.613509] kernel_init_freeable+0x25a/0x308 [ 6.613509] kernel_init+0x11/0x10d [ 6.613509] ret_from_fork+0x22/0x40 [ 6.613509] [ 6.613509] Freed by task 0: [ 6.613509] (stack is not available) [ 6.613509] [ 6.613509] The buggy address belongs to the object at ffff880107d4db08 [ 6.613509] which belongs to the cache kmalloc-512 of size 512 [ 6.613509] The buggy address is located 336 bytes inside of [ 6.613509] 512-byte region [ffff880107d4db08, ffff880107d4dd08) [ 6.613509] The buggy address belongs to the page: [ 6.613509] page:ffffea00041f5300 count:1 mapcount:0 mapping: (null) index:0x0 compound_mapcount: 0 [ 6.613509] flags: 0x8000000000008100(slab|head) [ 6.613509] raw: 8000000000008100 0000000000000000 0000000000000000 0000000100120012 [ 6.613509] raw: ffffea0004208520 ffff88010b001680 ffff88010b002cc0 0000000000000000 [ 6.613509] page dumped because: kasan: bad access detected [ 6.613509] [ 6.613509] Memory state around the buggy address: [ 6.613509] ffff880107d4db00: fc 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 6.613509] ffff880107d4db80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 6.613509] >ffff880107d4dc00: 00 00 00 00 00 00 00 00 00 fc fc fc fc fc fc fc [ 6.613509] ^ [ 6.613509] ffff880107d4dc80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc [ 6.613509] ffff880107d4dd00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc [ 6.613509] ================================================================== Fixes: 51f7415039d4 ("drm/amd/amdgpu: creating two I2S instances for stoney/cz") Signed-off-by: Daniel Kurtz <djkurtz(a)chromium.org> --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c index 20f20079935b..42f0d60cf3f4 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c @@ -402,7 +402,7 @@ static int acp_hw_init(void *handle) adev->acp.acp_res[4].end = adev->acp.acp_res[4].start; adev->acp.acp_cell[0].name = "acp_audio_dma"; - adev->acp.acp_cell[0].num_resources = 6; + adev->acp.acp_cell[0].num_resources = 5; adev->acp.acp_cell[0].resources = &adev->acp.acp_res[0]; adev->acp.acp_cell[0].platform_data = &adev->asic_type; adev->acp.acp_cell[0].pdata_size = sizeof(adev->asic_type); -- 2.17.0.484.g0c8726318c-goog

4 6

[Bug 199269] New: amdgpu/DC on Kaveri results in corrupt color output on HDMI
by bugzilla-daemon＠bugzilla.kernel.org 09 Jul '18

09 Jul '18

https://bugzilla.kernel.org/show_bug.cgi?id=199269 Bug ID: 199269 Summary: amdgpu/DC on Kaveri results in corrupt color output on HDMI Product: Drivers Version: 2.5 Kernel Version: 4.16 Hardware: x86-64 OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: linux(a)bernd-steinhauser.de Regression: No Created attachment 275079 --> https://bugzilla.kernel.org/attachment.cgi?id=275079&action=edit dmesg messages I'm running amdgpu on my Kaveri for quite some time and it works fine. Nothing changed with kernel 4.16 there. For a test, I tried it with activated DC as well: CONFIG_DRM_AMDGPU=y # CONFIG_DRM_AMDGPU_SI is not set CONFIG_DRM_AMDGPU_CIK=y # CONFIG_DRM_AMDGPU_USERPTR is not set # CONFIG_DRM_AMDGPU_GART_DEBUGFS is not set CONFIG_DRM_AMD_ACP=y CONFIG_DRM_AMD_DC=y CONFIG_DRM_AMD_DC_PRE_VEGA=y It did boot fine with this config and on the DVI output, the image looked normal. However, on the HDMI output, there was a pink/purple tint as if green was missing in the output. In the dmsg output, I can find these messages (full output attached): Apr 02 15:36:44 orionis kernel: [drm:construct] *ERROR* construct: Invalid Connector ObjectID from Adapter Service for connector index:1! type 0 expected 3 Apr 02 15:36:44 orionis kernel: [drm:construct] *ERROR* construct: Invalid Connector ObjectID from Adapter Service for connector index:3! type 0 expected 3 Apr 02 15:36:44 orionis kernel: [drm:construct] *ERROR* construct: Invalid Connector ObjectID from Adapter Service for connector index:5! type 0 expected 3 There is also this, but I don't know if it could be related: Apr 02 15:36:44 orionis kernel: ACPI BIOS Error (bug): Failure looking up [\_SB.ALIB], AE_NOT_FOUND (20180105/psargs-364) Apr 02 15:36:44 orionis kernel: ACPI Error: Method parse/execution failed \_SB.PCI0.VGA.ATC0, AE_NOT_FOUND (20180105/psparse-550) Apr 02 15:36:44 orionis kernel: ACPI Error: Method parse/execution failed \_SB.PCI0.VGA.ATCS, AE_NOT_FOUND (20180105/psparse-550) Apart from that, there didn't seem to be any error messages that could be related to drm at a first glance. -- You are receiving this mail because: You are watching the assignee of the bug.

1 1

[Bug 106355] Strange artifacts when using Chromium with hardware acceleration
by bugzilla-daemon＠freedesktop.org 08 Jul '18

08 Jul '18

https://bugs.freedesktop.org/show_bug.cgi?id=106355 --- Comment #6 from Norbert Klar <klarnorbert(a)gmail.com> --- Fixed, after update to 18.1.3. Thanks whoever fixed this. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 200387] New: amdgpu uses unusually high memory
by bugzilla-daemon＠bugzilla.kernel.org 08 Jul '18

08 Jul '18

https://bugzilla.kernel.org/show_bug.cgi?id=200387 Bug ID: 200387 Summary: amdgpu uses unusually high memory Product: Drivers Version: 2.5 Kernel Version: 4.16.18, 4.17.3, 4.18.0-rc2 Hardware: x86-64 OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: felix(a)feldspaten.org Regression: No Created attachment 277107 --> https://bugzilla.kernel.org/attachment.cgi?id=277107&action=edit Config file for 4.17.3. Hi there, I'm experiencing some out-of-memory issues while running Cities:Skylines using the amdgpu driver. Trying to run a new game cases a complete system-freeze running any Kernel that runs the amdgpu driver instead of a rather old Kernel using the amdgpu-pro driver. The memory is the system related main memory, not the GPU memory. System details: I'm running Ubuntu Mate 16.04 with a custom build 4.17.3 Kernel (Find config attached) AMD FX-8350 32 GB RAM Radeon RX470 Sample Main Memory usage. Kernel 4.4 with amdgpu-pro driver - RAM Usage after 1 Minute: 2.4 GB Kernel 4.17.3 with amdgpu driver - RAM Usage after 1 Minute: 13 GB Kernel 4.16.18 with amdgpu driver - RAM Usage after 1 Minute: 13 GB Kernel 4.18.0-rc2 with amdgpu driver - RAM Usage after 1 Minute: 13 GB I get similar results with running Stardew Valley (Factor two difference, clearly measurable) Find attached the config file for the 4.17.3 Kernel. Other kernels have been build using this config file and the default suggestions for any unconfigured parameter. Greetings, Felix -- You are receiving this mail because: You are watching the assignee of the bug.

1 30

[PATCH libdrm 0/3] Enable more formats in modetest
by Hyun Kwon 08 Jul '18

08 Jul '18

Hi, This is a reminder of previously submitted patch [1]. The set is just rebased on the lastet master branch, but nothing still changed. This set adds more formats for modetest, including fixes for 10bit RGB formats and adding 422/444 YUV formats. Thanks, -hyun [1] https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg219340.html Hyun Kwon (3): tests: util: pattern: Use 64bit RGB samples modetest: Add support for YUV422 and YUV444 tests: util: Add support for YUV422 and YUV444 tests/modetest/buffers.c | 29 ++++++++++++++++++++++++++--- tests/util/format.c | 4 ++++ tests/util/pattern.c | 22 ++++++++++++++++++---- 3 files changed, 48 insertions(+), 7 deletions(-) -- 2.7.4

1 3

[Bug 199621] New: iMac 2009, Mobility Radeon HD 4670: black screen on boot
by bugzilla-daemon＠bugzilla.kernel.org 07 Jul '18

07 Jul '18

https://bugzilla.kernel.org/show_bug.cgi?id=199621 Bug ID: 199621 Summary: iMac 2009, Mobility Radeon HD 4670: black screen on boot Product: Drivers Version: 2.5 Kernel Version: 4.15.0-20 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: floe(a)butterbrot.org Regression: No I'm running Ubuntu 18.04 on a old-ish iMac from 2009. As soon as the kernel modesetting kicks in, I only get a black screen. This is not a duplicate of https://bugzilla.kernel.org/show_bug.cgi?id=100301 - if I try to enable the screen via sysfs or xrandr, I get the following oops in dmesg: May 4 09:17:19 igor01 kernel: [ 1193.227376] ------------[ cut here ]------------ May 4 09:17:19 igor01 kernel: [ 1193.227377] unknown DP link BW code 0, using 162000 May 4 09:17:19 igor01 kernel: [ 1193.227401] WARNING: CPU: 1 PID: 915 at /build/linux-5s7Xkn/linux-4.15.0/drivers/gpu/drm/drm_dp_helper.c:157 drm_dp_bw_code_to_link_rate+0x41/0x50 [drm_kms_helper] May 4 09:17:19 igor01 kernel: [ 1193.227401] Modules linked in: rfcomm ccm bnep snd_hda_codec_cirrus snd_hda_codec_generic applesmc input_polldev arc4 coretemp kvm_intel kvm irqbypass uvcvideo videobuf2_vmalloc joydev input_leds btusb btrtl btbcm btintel videobuf2_memops videobuf2_v4l2 bluetooth ecdh_generic videobuf2_core videodev media ath9k ath9k_common ath9k_hw ath mac80211 cfg80211 snd_hda_codec_hdmi snd_hda_inte l snd_hda_codec snd_hda_core snd_hwdep snd_pcm snd_seq_midi snd_seq_midi_event snd_rawmidi shpchp snd_seq snd_seq_device snd_timer snd soundcore apple_bl mac_hid sch_fq_codel parport_pc ppdev lp parport ip_table s x_tables autofs4 hid_appleir uas usb_storage hid_generic usbhid hid pata_acpi radeon i2c_algo_bit ttm firewire_ohci drm_kms_helper syscopyarea sysfillrect firewire_core sysimgblt crc_itu_t forcedeth fb_sys_fop s May 4 09:17:19 igor01 kernel: [ 1193.227454] ahci drm libahci i2c_nforce2 May 4 09:17:19 igor01 kernel: [ 1193.227459] CPU: 1 PID: 915 Comm: Xorg Tainted: G W 4.15.0-20-generic #21-Ubuntu May 4 09:17:19 igor01 kernel: [ 1193.227460] Hardware name: Apple Inc. iMac10,1/Mac-F2268DC8, BIOS IM101.88Z.00CC.B00.0909031926 09/03/09 May 4 09:17:19 igor01 kernel: [ 1193.227467] RIP: 0010:drm_dp_bw_code_to_link_rate+0x41/0x50 [drm_kms_helper] May 4 09:17:19 igor01 kernel: [ 1193.227469] RSP: 0018:ffff9e06415e7ad8 EFLAGS: 00010282 May 4 09:17:19 igor01 kernel: [ 1193.227471] RAX: 0000000000000000 RBX: ffff8f00362f1000 RCX: 0000000000000006 May 4 09:17:19 igor01 kernel: [ 1193.227472] RDX: 0000000000000007 RSI: 0000000000000096 RDI: ffff8f003fd16490 May 4 09:17:19 igor01 kernel: [ 1193.227474] RBP: ffff9e06415e7ae0 R08: 0000000000000001 R09: 0000000000000fe6 May 4 09:17:19 igor01 kernel: [ 1193.227475] R10: 0000000000000040 R11: 0000000000000000 R12: 000000000000fde8 May 4 09:17:19 igor01 kernel: [ 1193.227477] R13: ffff8f00362f1000 R14: 0000000000000018 R15: ffff8f002b0bddc4 May 4 09:17:19 igor01 kernel: [ 1193.227479] FS: 00007f9d8d3c9600(0000) GS:ffff8f003fd00000(0000) knlGS:0000000000000000 May 4 09:17:19 igor01 kernel: [ 1193.227481] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 May 4 09:17:19 igor01 kernel: [ 1193.227482] CR2: 00007f9d8d3e2000 CR3: 0000000233cac000 CR4: 00000000000406e0 May 4 09:17:19 igor01 kernel: [ 1193.227483] Call Trace: May 4 09:17:19 igor01 kernel: [ 1193.227513] radeon_dp_get_dp_link_config+0x45/0x150 [radeon] May 4 09:17:19 igor01 kernel: [ 1193.227542] radeon_dp_mode_valid_helper+0x4e/0xb0 [radeon] May 4 09:17:19 igor01 kernel: [ 1193.227558] ? drm_mode_connector_list_update+0x113/0x180 [drm] May 4 09:17:19 igor01 kernel: [ 1193.227581] radeon_dp_mode_valid+0xcd/0xd0 [radeon] May 4 09:17:19 igor01 kernel: [ 1193.227589] drm_helper_probe_single_connector_modes+0x418/0x710 [drm_kms_helper] May 4 09:17:19 igor01 kernel: [ 1193.227607] drm_mode_getconnector+0x15d/0x340 [drm] May 4 09:17:19 igor01 kernel: [ 1193.227610] ? import_iovec+0x3a/0xe0 May 4 09:17:19 igor01 kernel: [ 1193.227627] ? drm_mode_connector_property_set_ioctl+0x60/0x60 [drm] May 4 09:17:19 igor01 kernel: [ 1193.227641] drm_ioctl_kernel+0x5f/0xb0 [drm] May 4 09:17:19 igor01 kernel: [ 1193.227655] drm_ioctl+0x31b/0x3d0 [drm] May 4 09:17:19 igor01 kernel: [ 1193.227672] ? drm_mode_connector_property_set_ioctl+0x60/0x60 [drm] May 4 09:17:19 igor01 kernel: [ 1193.227691] radeon_drm_ioctl+0x4f/0x90 [radeon] May 4 09:17:19 igor01 kernel: [ 1193.227694] do_vfs_ioctl+0xa8/0x630 May 4 09:17:19 igor01 kernel: [ 1193.227696] ? __sys_recvmsg+0x80/0x90 May 4 09:17:19 igor01 kernel: [ 1193.227699] SyS_ioctl+0x79/0x90 May 4 09:17:19 igor01 kernel: [ 1193.227701] ? SyS_clock_gettime+0x88/0xb0 May 4 09:17:19 igor01 kernel: [ 1193.227704] do_syscall_64+0x73/0x130 May 4 09:17:19 igor01 kernel: [ 1193.227706] entry_SYSCALL_64_after_hwframe+0x3d/0xa2 May 4 09:17:19 igor01 kernel: [ 1193.227708] RIP: 0033:0x7f9d8a7c25d7 May 4 09:17:19 igor01 kernel: [ 1193.227709] RSP: 002b:00007fff59e6d978 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 May 4 09:17:19 igor01 kernel: [ 1193.227712] RAX: ffffffffffffffda RBX: 0000559d87d158d0 RCX: 00007f9d8a7c25d7 May 4 09:17:19 igor01 kernel: [ 1193.227713] RDX: 00007fff59e6d9b0 RSI: 00000000c05064a7 RDI: 000000000000000c May 4 09:17:19 igor01 kernel: [ 1193.227715] RBP: 00007fff59e6d9b0 R08: 0000000000000001 R09: 0000000000000000 May 4 09:17:19 igor01 kernel: [ 1193.227716] R10: 0000000000000000 R11: 0000000000000246 R12: 00000000c05064a7 May 4 09:17:19 igor01 kernel: [ 1193.227718] R13: 000000000000000c R14: 000000000000000c R15: 00007fff59e6d9b0 May 4 09:17:19 igor01 kernel: [ 1193.227719] Code: 3d 08 00 74 2d 40 80 ff 06 b8 d0 78 02 00 74 22 55 40 0f b6 f7 48 c7 c7 b8 0b 12 c0 48 89 e5 48 83 ec 08 89 45 fc e8 8f f0 77 c9 <0f> 0b 8b 45 fc c9 c3 f3 c3 66 0f 1f 44 00 00 66 66 66 66 90 55 May 4 09:17:19 igor01 kernel: [ 1193.227764] ---[ end trace d2b3e21bce6f63f8 ]--- Best, Florian -- You are receiving this mail because: You are watching the assignee of the bug.

1 9

[PATCH v5 0/7] Add tda998x (HDMI) support to atmel-hlcdc
by Peter Rosin 07 Jul '18

07 Jul '18

Hi! I naively thought that since there was support for both nxp,tda19988 (in the tda998x driver) and the atmel-hlcdc, things would be a smooth ride. But it wasn't, so I started looking around and realized I had to fix things. In v1 and v2 I fixed things by making the atmel-hlcdc driver a master component, but now I fix things by making the tda998x driver a bridge instead. This was after a suggestion from Boris Brezillon the atmel-hlcdc maintainer), so there was some risk of bias ... but after comparing what was needed, I too find the bridge approach more direct. In v4, an issue was noted by Russell King in that the tda998x device might be unbound with shattering results for the main drm device. This is of course a real problem and it needs to be fixed. I have submitted a series [1] that tries to do that. However, since there are currently *10* other bridges (analogix-anx78xx, adv7511, megachips_stdp*, nxp-ptn3460, parade-ps8622, sii902x, sii9234, sil-sii8620, tc358767 and ti-tfp410) with exactly the same problem (they are all I2C devices that might be unexpectedly unbound without safety-net, at least that is how I read it), I think it should be ok to add one more and then fix them all instead of holding this series hostage. Apparently people don't go around and unbind I2C devices all that often... In addition to the above, our PCB interface between the SAMA5D3 and the HDMI encoder is only using 16 bits, and this has to be described somewhere, or the atmel-hlcdc driver have no chance of selecting the correct output mode. Since I have similar problems with a ds90c185 lvds encoder I added patches to override the atmel-hlcdc output format via DT properties compatible with the media video-interface binding and things start to play together. Anyway, this series solves some real issues for my HW. Also, is it perhaps possible that patches 1-3 can be taken independently from 4-7? There is no hard dependency between the two parts of this series. Patches 1-3 have the relevant tags and should be uncontroversial... Cheers, Peter Changes since v4 https://lkml.org/lkml/2018/4/23/92 - added reviewed-by from Rob to patch 2/7 - dropped patch 8, since the issue noted by Russell King is not present when working with components as tilcdc currently do when handling tda998x Changes since v3 https://lkml.org/lkml/2018/4/19/736 - moved the meat of the drm_of_media_bus_fmt function from patch 3/7 to a driver-local atmel_hlcdc_of_bus_fmt function, and squashed with patch 4/7 (this is now patch 3/8). - patch 3/8 now parses and stores the DT bus format together with the encoder in a reintroduced struct atmel_hlcdc_rgb_output instead of allocating a separate encoder-indexed array for the bus formats. - patch 5/8 is new and splits tda988x_encoder_dpms into a pair of functions to enable/disable separately. This fits better with both the current code and for the followup drm_bridge patch (7/8). - adjust patch 6/8 and 7/8 to the above simplification. - added patch 8/8 that removes component master code from tilcdc. Changes since v2 https://lkml.org/lkml/2018/4/17/385 - patch 2/7 fixed spelling and added an example - patch 4/7 parse the DT up front and store the result indexed by encoder - old patch 5/6 and 6/6 dropped - patch 5-7/7 are new and makes the tda998x driver a drm_bridge Changes since v1 https://lkml.org/lkml/2018/4/9/294 - added reviewed-by from Rob to patch 1/6 - patch 2/6 changed so that the bus format override is in the endpoint DT node, and follows the binding of media video-interfaces. - patch 3/6 is new, it adds drm_of_media_bus_fmt which parses above media video-interface binding (partially). - patch 4/6 now makes use of the above helper (and also fixes problems with the 3/5 patch from v1 when no override was specified). - do not mention unrelated connector display_info details in the cover letter and commit messages. [1] https://lkml.org/lkml/2018/5/16/380 Peter Rosin (7): dt-bindings: display: bridge: lvds-transmitter: add ti,ds90c185 dt-bindings: display: atmel: optional video-interface of endpoints drm/atmel-hlcdc: support bus-width (12/16/18/24) in endpoint nodes drm/i2c: tda998x: find the drm_device via the drm_connector drm/i2c: tda998x: split tda998x_encoder_dpms into enable/disable drm/i2c: tda998x: split encoder and component functions from the work drm/i2c: tda998x: register as a drm bridge .../devicetree/bindings/display/atmel/hlcdc-dc.txt | 26 ++ .../bindings/display/bridge/lvds-transmitter.txt | 8 +- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 70 ++++-- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 1 + drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 67 +++++- drivers/gpu/drm/i2c/tda998x_drv.c | 268 ++++++++++++++++----- 6 files changed, 351 insertions(+), 89 deletions(-) -- 2.11.0

4 16

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel July 2018