dri-devel September 2018

dri-devel@lists.freedesktop.org

276 participants
1899 discussions

[PATCH v2] drm: Clarify DRM_MODE_REFLECT_X/Y documentation
by Alexandru Gheorghe 11 Sep '18

11 Sep '18

DRM_MODE_REFLECT_X and DRM_MODE_REFLECT_Y meaning seems a bit unclear to me, so try to clarify that with a bit of ascii graphics. Changes since v1: - Move the ascii graphics in the kerneldoc where all plane properties are already documented and make sure it's properly rendered, suggestested by Daniel Vetter. Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe(a)arm.com> --- drivers/gpu/drm/drm_blend.c | 22 ++++++++++++++++++++++ include/uapi/drm/drm_mode.h | 3 ++- 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_blend.c b/drivers/gpu/drm/drm_blend.c index 402b62d3f072..92f75c5c93ac 100644 --- a/drivers/gpu/drm/drm_blend.c +++ b/drivers/gpu/drm/drm_blend.c @@ -101,6 +101,28 @@ * Without this property the rectangle is only scaled, but not rotated or * reflected. * + * Possbile values: + * + * "rotate-<degrees>": + * Signals that a drm plane is rotated <degrees> degrees in counter + * clockwise direction. + * + * "reflect-<axis>": + * Signals that the contents of a drm plane is reflected along the + * <axis> axis, in the same way as mirroring. + * + * reflect-x:: + * + * |o | | o| + * | | -> | | + * | v| |v | + * + * reflect-y:: + * + * |o | | ^| + * | | -> | | + * | v| |o | + * * zpos: * Z position is set up with drm_plane_create_zpos_immutable_property() and * drm_plane_create_zpos_property(). It controls the visibility of overlapping diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h index 8d67243952f4..d3e0fe31efc5 100644 --- a/include/uapi/drm/drm_mode.h +++ b/include/uapi/drm/drm_mode.h @@ -186,8 +186,9 @@ extern "C" { /* * DRM_MODE_REFLECT_<axis> * - * Signals that the contents of a drm plane is reflected in the <axis> axis, + * Signals that the contents of a drm plane is reflected along the <axis> axis, * in the same way as mirroring. + * See kerneldoc chapter "Plane Composition Properties" for more details. * * This define is provided as a convenience, looking up the property id * using the name->prop id lookup is the preferred method. -- 2.18.0

4 6

[PATCH v2 00/13] udmabuf: misc fixes.
by Gerd Hoffmann 11 Sep '18

11 Sep '18

v2: review updates, add three new patches. Gerd Hoffmann (13): udmabuf: sort headers, drop uapi/ path prefix udmabuf: improve map_udmabuf error handling udmabuf: use pgoff_t for pagecount udmabuf: constify udmabuf_ops udmabuf: constify udmabuf_create args udmabuf: add MEMFD_CREATE dependency udmabuf: rework limits udmabuf: improve udmabuf_create error handling udmabuf: use EBADFD in case we didn't got a memfd udmabuf: use ENOTTY for invalid ioctls udmabuf: drop WARN_ON() check. udmabuf: use sizeof(variable) instead of sizeof(type) udmabuf: add documentation include/uapi/linux/udmabuf.h | 50 +++++++++++++++++-- drivers/dma-buf/udmabuf.c | 93 +++++++++++++++++++----------------- Documentation/driver-api/dma-buf.rst | 8 ++++ drivers/dma-buf/Kconfig | 1 + 4 files changed, 104 insertions(+), 48 deletions(-) -- 2.9.3

3 18

[PATCH] etnaviv: setup missing dma_mask
by Eugeniy Paltsev 11 Sep '18

11 Sep '18

As for today etnaviv device doesn't setup dma_mask. The etnaviv device is a virtual device not represented in DT so missing dma_mask isn't setup by generic plaform code (by of_dma_configure function). Missing dma_mask causes fails in some dma cache ops functions. For example it causes fails on map_* operations in generic dma_noncoherent_ops and dma_direct_ops. We faced with this behaviour after switching ARC to generic dma_noncoherent cache ops using. So fix this by setting dma_mask via dma_coerce_mask_and_coherent() Reviewed-by: Christoph Hellwig <hch(a)lst.de> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev(a)synopsys.com> --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c index 540b59fb4103..69d80937e021 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c @@ -593,7 +593,7 @@ static int etnaviv_pdev_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct component_match *match = NULL; - dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32)); + dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); if (!dev->platform_data) { struct device_node *core_node; -- 2.14.4

1 1

[Bug 107001] hard system freeze with mesa 18.1.x on AMD RX 580
by bugzilla-daemon＠freedesktop.org 11 Sep '18

11 Sep '18

https://bugs.freedesktop.org/show_bug.cgi?id=107001 --- Comment #3 from claude(a)mathr.co.uk --- So, I got some freezes with Linux 4.18.5 and Mesa 18.0.5 (the version of Mesa that I assumed was bug free), and so far (24 hours uptime) no freezes with Linux 4.18.7 and Mesa 18.1.7-1. The Linux change log mentions some fixes for various deadlocks, perhaps I was just unlucky that some Mesa versions were more likely than others to trigger these Linux bugs on my system. I'll leave this open for another week or so of testing. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 107154] [drm] GPU recovery disabled.
by bugzilla-daemon＠freedesktop.org 11 Sep '18

11 Sep '18

https://bugs.freedesktop.org/show_bug.cgi?id=107154 Bug ID: 107154 Summary: [drm] GPU recovery disabled. Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: freedesktop.org(a)nentwig.biz Hi! This is a surprisingly long standing problem with a RX 460, more precisely since 4.15 all the way up to 4.18 AMD staging DRM next [1]. After resuming from sleep (echo -n mem > /sys/power/state) amdgpu is dead (always, reliably). Here's what dmesg has to say about it: [Sun Jul 8 11:01:17 2018] PM: suspend exit [Sun Jul 8 11:01:19 2018] [drm:gfx_v8_0_ring_test_ib [amdgpu]] *ERROR* amdgpu: IB test timed out. [Sun Jul 8 11:01:19 2018] [drm:amdgpu_ib_ring_tests [amdgpu]] *ERROR* amdgpu: failed testing IB on GFX ring (-110). [Sun Jul 8 11:01:19 2018] [drm:process_one_work] *ERROR* ib ring test failed (-110). [Sun Jul 8 11:01:28 2018] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring gfx timeout, last signaled seq=864, last emitted seq=868 [Sun Jul 8 11:01:28 2018] [drm] GPU recovery disabled. >From ealier versions: [ 42.802559] PM: suspend exit [ 42.824332] amdgpu 0000:41:00.0: GPU fault detected: 147 0x0bd84802 [ 42.824338] amdgpu 0000:41:00.0: VM_CONTEXT1_PROTECTION_FAULT_ADDR 0x0034F97B [ 42.824341] amdgpu 0000:41:00.0: VM_CONTEXT1_PROTECTION_FAULT_STATUS 0x0C048002 [ 42.824345] amdgpu 0000:41:00.0: VM fault (0x02, vmid 6) at page 3471739, read from 'TC0' (0x54433000) (72) [ 52.956306] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring gfx timeout, last signaled seq=1287, last emitted seq=1289 [ 52.956316] [drm] IP block:gfx_v8_0 is hung! [ 52.956362] [drm] GPU recovery disabled. I've also seen fault 146 but other than that it mostly looks the same. 4.14-lts (with dc=0) works fine. RX 460, Zenith Extreme, 1950x. [1] arch linux AUR; this versioning is a bit confusing, it may actually already be the 4.19 branch, latest commit is3838e387fd1eb17bfcf6ff7d443d931adb5cb41b -- You are receiving this mail because: You are the assignee for the bug.

1 11

backlight - chicken and egg challenge
by Sam Ravnborg 11 Sep '18

11 Sep '18

Hi all. When working on the DRM driver for Atmel LCDC the first approach was to use a MFD driver, that had two sub-drivers: - PWM dirver - DRM driver Feedback was that the PWM feature was too small to warrant a MFD driver. (There was no consencus on this, but I anyway went ahead). So the new approch is much simpler (from a code point of view): DRM Driver that has one sub-driver - PWM driver The PWM driver uses registers in the same memory range as the DRM driver, so the two drivers uses the same regmap. The PWM driver is located in pwm/ The DRM driver is located in gpu/drm/atmel The DRM driver uses platform_device_register_data() to register the sub-device/driver. I have yet to see it work, but I think this is the right way to do it. This all looked fine until reality kicked in. There is the following dependency chain (=> depends on): DRM Driver => Panel => Backlight => PWM => DRM Driver The DRM Driver rely indirectly on the DRM driver, which it not OK. So the open question is how to fix this dependency challenge? 1) Drop the generic backlight driver and implement all pwm/backlight handling in the driver. 2) Re-introduce the MFD driver. 3) ? Any good ideas? Sam

4 4

[PATCH 1/4] fbdev: Drop FBINFO_CAN_FORCE_OUTPUT flag
by Daniel Vetter 11 Sep '18

11 Sep '18

This was only added for the drm's fbdev emulation support, so that it would try harder to show the Oops. Unfortunately this never really worked reliably, and in practice ended up pushing the real Oops off the screen due to plentyfull locking, sleep-while-atomic and other issues. So we removed all that support from the fbdev emulation a while back. Aside: We've also removed the kgdb support, for similar reasons. Since it's such a small patch I figured I don't split this up into the usual 3-phase removal. Cc: Ben Skeggs <bskeggs(a)redhat.com> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie(a)samsung.com> Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: Hans de Goede <hdegoede(a)redhat.com> Cc: Daniel Vetter <daniel.vetter(a)ffwll.ch> Cc: Alexander Kapshuk <alexander.kapshuk(a)gmail.com> Cc: Kees Cook <keescook(a)chromium.org> Cc: Thierry Reding <treding(a)nvidia.com> Cc: David Lechner <david(a)lechnology.com> Cc: nouveau(a)lists.freedesktop.org Cc: linux-fbdev(a)vger.kernel.org Signed-off-by: Daniel Vetter <daniel.vetter(a)intel.com> --- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 1 - drivers/staging/vboxvideo/vbox_fb.c | 3 +-- drivers/video/fbdev/core/fbcon.c | 1 - include/linux/fb.h | 4 ---- 4 files changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c index 844498c4267c..20a260887be3 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c @@ -379,7 +379,6 @@ nouveau_fbcon_create(struct drm_fb_helper *helper, info->flags = FBINFO_DEFAULT | FBINFO_HWACCEL_COPYAREA | FBINFO_HWACCEL_FILLRECT | FBINFO_HWACCEL_IMAGEBLIT; - info->flags |= FBINFO_CAN_FORCE_OUTPUT; info->fbops = &nouveau_fbcon_sw_ops; info->fix.smem_start = fb->nvbo->bo.mem.bus.base + fb->nvbo->bo.mem.bus.offset; diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbox_fb.c index 43c39eca4ae1..034f8ffa8f20 100644 --- a/drivers/staging/vboxvideo/vbox_fb.c +++ b/drivers/staging/vboxvideo/vbox_fb.c @@ -155,8 +155,7 @@ static int vboxfb_create(struct drm_fb_helper *helper, * The last flag forces a mode set on VT switches even if the kernel * does not think it is needed. */ - info->flags = FBINFO_DEFAULT | FBINFO_CAN_FORCE_OUTPUT | - FBINFO_MISC_ALWAYS_SETPAR; + info->flags = FBINFO_DEFAULT | FBINFO_MISC_ALWAYS_SETPAR; info->fbops = &vboxfb_ops; /* diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index 5fb156bdcf4e..2b5bb52b1798 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -1104,7 +1104,6 @@ static void fbcon_init(struct vc_data *vc, int init) if (p->userfont) charcnt = FNTCHARCNT(p->fontdata); - vc->vc_panic_force_write = !!(info->flags & FBINFO_CAN_FORCE_OUTPUT); vc->vc_can_do_color = (fb_get_color_depth(&info->var, &info->fix)!=1); vc->vc_complement_mask = vc->vc_can_do_color ? 0x7700 : 0x0800; if (charcnt == 256) { diff --git a/include/linux/fb.h b/include/linux/fb.h index aa74a228bb92..fa8c6f9c9c3a 100644 --- a/include/linux/fb.h +++ b/include/linux/fb.h @@ -457,10 +457,6 @@ struct fb_tile_ops { */ #define FBINFO_BE_MATH 0x100000 -/* report to the VT layer that this fb driver can accept forced console - output like oopses */ -#define FBINFO_CAN_FORCE_OUTPUT 0x200000 - struct fb_info { atomic_t count; int node; -- 2.18.0

5 12

Re: [PATCH 00/20] drm/cma-helper drivers: Use drm_fbdev_generic_setup()
by Noralf Trønnes 11 Sep '18

11 Sep '18

Cc: dri-devel and Sam (sorry about the slip) Den 10.09.2018 14.53, skrev Noralf Trønnes: > > Den 08.09.2018 15.46, skrev Noralf Trønnes: >> This patchset moves the drivers using the CMA helper fully over to the >> generic fbdev emulation. The unused fbdev code is removed from the CMA >> helper. > > Maxime asked for context so I'm replying to all: > > This is the base for this patchset which added > drm_fb_helper_generic_probe, > it was applied in July (now in 4.19): > > drm: Add generic fbdev emulation > https://patchwork.freedesktop.org/series/45848/ > > Noralf. > >> Noralf. >> >> Noralf Trønnes (20): >> drm/fb-helper: Improve error reporting in setup >> drm/arc: Use drm_fbdev_generic_setup() >> drm/fsl-dcu: Use drm_fbdev_generic_setup() >> drm/hisilicon/kirin: Use drm_fbdev_generic_setup() >> drm/meson: Use drm_fbdev_generic_setup() >> drm/mxsfb: Use drm_fbdev_generic_setup() >> drm/rcar-du: Use drm_fbdev_generic_setup() >> drm/arm/hdlcd: Use drm_fbdev_generic_setup() >> drm/arm/mali: Use drm_fbdev_generic_setup() >> drm/atmel-hlcdc: Use drm_fbdev_generic_setup() >> drm/imx: Use drm_fbdev_generic_setup() >> drm/pl111: Use drm_fbdev_generic_setup() >> drm/sti: Use drm_fbdev_generic_setup() >> drm/stm: Use drm_fbdev_generic_setup() >> drm/sun4i: Use drm_fbdev_generic_setup() >> drm/tilcdc: Use drm_fbdev_generic_setup() >> drm/tve200: Use drm_fbdev_generic_setup() >> drm/vc4: Use drm_fbdev_generic_setup() >> drm/zte: Use drm_fbdev_generic_setup() >> drm/cma-helper: Remove unused fbdev code >> >> drivers/gpu/drm/Kconfig | 4 - >> drivers/gpu/drm/arc/arcpgu.h | 4 - >> drivers/gpu/drm/arc/arcpgu_drv.c | 33 +----- >> drivers/gpu/drm/arm/hdlcd_drv.c | 11 +- >> drivers/gpu/drm/arm/malidp_drv.c | 11 +- >> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 7 +- >> drivers/gpu/drm/drm_fb_cma_helper.c | 151 >> ------------------------ >> drivers/gpu/drm/drm_fb_helper.c | 8 +- >> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 25 +--- >> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h | 1 - >> drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 38 +----- >> drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.h | 4 - >> drivers/gpu/drm/imx/imx-drm-core.c | 19 +-- >> drivers/gpu/drm/meson/meson_drv.c | 19 +-- >> drivers/gpu/drm/meson/meson_drv.h | 1 - >> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 26 +--- >> drivers/gpu/drm/mxsfb/mxsfb_drv.h | 1 - >> drivers/gpu/drm/pl111/pl111_drv.c | 6 +- >> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 34 +----- >> drivers/gpu/drm/rcar-du/rcar_du_drv.h | 3 - >> drivers/gpu/drm/rcar-du/rcar_du_kms.c | 21 ---- >> drivers/gpu/drm/sti/sti_drv.c | 8 +- >> drivers/gpu/drm/stm/drv.c | 11 +- >> drivers/gpu/drm/sun4i/sun4i_drv.c | 12 +- >> drivers/gpu/drm/sun4i/sun4i_framebuffer.c | 12 +- >> drivers/gpu/drm/sun4i/sun4i_framebuffer.h | 3 +- >> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 11 +- >> drivers/gpu/drm/tve200/tve200_drv.c | 14 +-- >> drivers/gpu/drm/vc4/vc4_drv.c | 5 +- >> drivers/gpu/drm/vc4/vc4_kms.c | 6 - >> drivers/gpu/drm/zte/zx_drm_drv.c | 15 +-- >> include/drm/drm_fb_cma_helper.h | 24 ---- >> 32 files changed, 56 insertions(+), 492 deletions(-) >> >

1 0

[PATCH 00/10] udmabuf: misc fixes.
by Gerd Hoffmann 11 Sep '18

11 Sep '18

Gerd Hoffmann (10): udmabuf: sort headers, drop uapi/ path prefix udmabuf: improve map_udmabuf error handling udmabuf: use pgoff_t for pagecount udmabuf: constify udmabuf_ops udmabuf: constify udmabuf_create args udmabuf: add MEMFD_CREATE dependency udmabuf: rework limits udmabuf: improve udmabuf_create error handling udmabuf: use EBADFD in case we didn't got a memfd udmabuf: use ENOTTY for invalid ioctls drivers/dma-buf/udmabuf.c | 84 +++++++++++++++++++++++++---------------------- drivers/dma-buf/Kconfig | 1 + 2 files changed, 46 insertions(+), 39 deletions(-) -- 2.9.3

3 19

[PATCH 4.19 regression fix 1/2] staging: vboxvideo: Fix IRQs no longer working
by Hans de Goede 11 Sep '18

11 Sep '18

Commit 1daddbc8dec5 ("staging: vboxvideo: Update driver to use drm_dev_register.") replaced the obsolere drm_get_pci_dev() with normal pci probe and remove functions. But the new vbox_pci_probe() is missing a pci_enable_device() call, causing interrupts to not be delivered. This causes resizes of the vm window to not get seen by the drm/kms code. This commit adds the missing pci_enable_device() call, fixing this. Fixes: 1daddbc8dec5 ("staging: vboxvideo: Update driver to use ...") Cc: Fabio Rafael da Rosa <fdr(a)pid42.net> Cc: Nicholas Mc Guire <der.herr(a)hofr.at> Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> --- drivers/staging/vboxvideo/vbox_drv.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/vboxvideo/vbox_drv.c b/drivers/staging/vboxvideo/vbox_drv.c index da92c493f157..69cc508af1bc 100644 --- a/drivers/staging/vboxvideo/vbox_drv.c +++ b/drivers/staging/vboxvideo/vbox_drv.c @@ -59,6 +59,11 @@ static int vbox_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) ret = PTR_ERR(dev); goto err_drv_alloc; } + + ret = pci_enable_device(pdev); + if (ret) + goto err_pci_enable; + dev->pdev = pdev; pci_set_drvdata(pdev, dev); @@ -75,6 +80,8 @@ static int vbox_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) err_drv_dev_register: vbox_driver_unload(dev); err_vbox_driver_load: + pci_disable_device(pdev); + err_pci_enable: drm_dev_put(dev); err_drv_alloc: return ret; -- 2.19.0.rc0

4 9

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2018