dri-devel September 2018

dri-devel@lists.freedesktop.org

276 participants
1899 discussions

[PATCH] drm/amdgpu: Fix wornings while make xmldocs
by Masanari Iida 07 Sep '18

07 Sep '18

This patch fixes following wornings. ./drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:3011: warning: Excess function parameter 'dev' description in 'amdgpu_vm_get_task_info' ./drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:3012: warning: Function parameter or member 'adev' not described in 'amdgpu_vm_get_task_info' ./drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:3012: warning: Excess function parameter 'dev' description in 'amdgpu_vm_get_task_info' Signed-off-by: Masanari Iida <standby24x7(a)gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index b17771dd5ce7..861718e2be7a 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c @@ -3002,7 +3002,7 @@ int amdgpu_vm_ioctl(struct drm_device *dev, void *data, struct drm_file *filp) /** * amdgpu_vm_get_task_info - Extracts task info for a PASID. * - * @dev: drm device pointer + * @adev: drm device pointer * @pasid: PASID identifier for VM * @task_info: task_info to fill. */ -- 2.19.0.rc2

2 1

[PATCH libdrm] xf86drm: Add signed32 rectangle
by Deepak Rawat 07 Sep '18

07 Sep '18

With drm subsystem using struct drm_rect to manage rectangular area this export it to user-space. Currently used by drm_mode_atomic blob property FB_DAMAGE_CLIPS. Signed-off-by: Deepak Rawat <drawat(a)vmware.com> --- include/drm/drm_mode.h | 19 +++++++++++++++++++ xf86drmMode.h | 2 ++ 2 files changed, 21 insertions(+) diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h index 5f9fadbd..9e7bdc26 100644 --- a/include/drm/drm_mode.h +++ b/include/drm/drm_mode.h @@ -855,6 +855,25 @@ struct drm_mode_revoke_lease { __u32 lessee_id; }; +/** + * struct drm_mode_rect - two dimensional rectangle + * @x1: horizontal starting coordinate (inclusive) + * @y1: vertical starting coordinate (inclusive) + * @x2: horizontal ending coordinate (exclusive) + * @y2: vertical ending coordinate (exclusive) + * + * With drm subsystem using struct drm_rect to manage rectangular area this + * export it to user-space. + * + * Currently used by drm_mode_atomic blob property FB_DAMAGE_CLIPS. + */ +struct drm_mode_rect { + __s32 x1; + __s32 y1; + __s32 x2; + __s32 y2; +}; + #if defined(__cplusplus) } #endif diff --git a/xf86drmMode.h b/xf86drmMode.h index 3cd27aee..a066e2b8 100644 --- a/xf86drmMode.h +++ b/xf86drmMode.h @@ -338,6 +338,8 @@ typedef struct _drmModePlaneRes { uint32_t *planes; } drmModePlaneRes, *drmModePlaneResPtr; +typedef struct drm_mode_rect drmModeRect, *drmModeRectPtr; + extern void drmModeFreeModeInfo( drmModeModeInfoPtr ptr ); extern void drmModeFreeResources( drmModeResPtr ptr ); extern void drmModeFreeFB( drmModeFBPtr ptr ); -- 2.17.1

2 1

[Bug 103199] [CI] igt@drv_missed_irq - fail - Failed assertion: missed_rings == expect_rings
by bugzilla-daemon＠freedesktop.org 07 Sep '18

07 Sep '18

https://bugs.freedesktop.org/show_bug.cgi?id=103199 Chris Wilson <chris(a)chris-wilson.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #5 from Chris Wilson <chris(a)chris-wilson.co.uk> --- (In reply to Chris Wilson from comment #4) > (In reply to Martin Peres from comment #3) > > https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_93/fi-icl-u/ > > igt(a)drv_missed_irq.html > > > > (drv_missed_irq:1510) CRITICAL: Test assertion failure function > > __real_main96, file ../tests/drv_missed_irq.c:159: > > (drv_missed_irq:1510) CRITICAL: Failed assertion: missed_rings == > > expect_rings > > (drv_missed_irq:1510) CRITICAL: Last errno: 9, Bad file descriptor > > (drv_missed_irq:1510) CRITICAL: error: 0 != 0x57 > > Test drv_missed_irq failed. > > icl is a different class of bug -- icl can't fake missed interrupts at all. commit 5f521722a2a2391d693afccdf6e12be2754382d8 (HEAD -> drm-intel-next-queued, drm-intel/drm-intel-next-queued) Author: Chris Wilson <chris(a)chris-wilson.co.uk> Date: Fri Sep 7 12:28:51 2018 +0100 drm/i915: Missed interrupt simulation is no more, tell the world Using the guc, we cannot disable the user interrupt generation as we use it for driving submission. And from Icelake, we no longer have the ability to individually mask interrupt generation from each engine, disabling our ability to fake missed interrupts. In both cases, report back to userspace that the missed interrupt generator is no longer available. Signed-off-by: Chris Wilson <chris(a)chris-wilson.co.uk> Cc: Mika Kuoppala <mika.kuoppala(a)linux.intel.com> Reviewed-by: Mika Kuoppala <mika.kuoppala(a)linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20180907112856.28242-1-chris@… -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH v4 1/4] clk: sunxi-ng: Enable DE2_CCU for SUN8I and SUN50I
by Jagan Teki 07 Sep '18

07 Sep '18

Allwinner SoC like SUN8I and SUN50I has DE2 CCU so enable them as default. Signed-off-by: Jagan Teki <jagan(a)amarulasolutions.com> --- Changes for v4, v3: - none Changes for v2: - Enable for MACH_SUN8I drivers/clk/sunxi-ng/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig index 826674d090fd..e20182aa9748 100644 --- a/drivers/clk/sunxi-ng/Kconfig +++ b/drivers/clk/sunxi-ng/Kconfig @@ -63,6 +63,8 @@ config SUN8I_V3S_CCU config SUN8I_DE2_CCU bool "Support for the Allwinner SoCs DE2 CCU" + default MACH_SUN8I || (ARM64 && ARCH_SUNXI) + depends on DRM_SUN4I && (MACH_SUN8I || (ARM64 && ARCH_SUNXI)) config SUN8I_R40_CCU bool "Support for the Allwinner R40 CCU" -- 2.18.0.321.gffc6fa0e3

3 14

[PATCH] locking: Fix mutex debug call and ww_mutex doc
by Thomas Hellstrom 07 Sep '18

07 Sep '18

Commit 08295b3b5bee ("Implement an algorithm choice for Wound-Wait mutexes") introduced a reference in the documentation to a function that was removed in an earlier commit. It also forgot to remove a call to debug_mutex_add_waiter() which is now unconditionally called by __mutex_add_waiter(). Fix those issues. Fixes: 08295b3b5bee ("Implement an algorithm choice for Wound-Wait mutexes") Signed-off-by: Thomas Hellstrom <thellstrom(a)vmware.com> --- kernel/locking/mutex.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/locking/mutex.c b/kernel/locking/mutex.c index 1a81a1257b3f..3f8a35104285 100644 --- a/kernel/locking/mutex.c +++ b/kernel/locking/mutex.c @@ -389,7 +389,7 @@ static bool __ww_mutex_wound(struct mutex *lock, /* * wake_up_process() paired with set_current_state() * inserts sufficient barriers to make sure @owner either sees - * it's wounded in __ww_mutex_lock_check_stamp() or has a + * it's wounded in __ww_mutex_check_kill() or has a * wakeup pending to re-read the wounded state. */ if (owner != current) @@ -946,7 +946,6 @@ __mutex_lock_common(struct mutex *lock, long state, unsigned int subclass, } debug_mutex_lock_common(lock, &waiter); - debug_mutex_add_waiter(lock, &waiter, current); lock_contended(&lock->dep_map, ip); -- 2.18.0.rc1

2 1

[PULL] drm-intel-next
by Joonas Lahtinen 07 Sep '18

07 Sep '18

Hi Dave, Here's the first batch of changes for v4.20. Nothing too special. Notable things are more Icelake enabling/fixing patches and PPGTT enabling for some older platforms. Icelake is still behind alpha_support flag as we have the code in upstream but extensive testing is pending hardware availability. Now, after summer vacations are over, next kernel versions will probably absorb the queue of features that are in the flight. Note the backmerge of drm-next-4.19. I also intend to backmerge -rc2 after this for the BITS_PER_TYPE patches that Chris wants. There are some extra tags generated, just ignore those, Tooling should handle this pull just nicely. Regards, Joonas --- drm-intel-next-2018-09-06-2: Merge tag 'gvt-next-2018-09-04' drm-intel-next-2018-09-06-1: UAPI Changes: - GGTT coherency GETPARAM: GGTT has turned out to be non-coherent for some platforms, which we've failed to communicate to userspace so far. SNA was modified to do extra flushing on non-coherent GGTT access, while Mesa will mitigate by always requiring WC mapping (which is non-coherent anyway). - Neuter Resource Streamer uAPI: There never really were users for the feature, so neuter it while keeping the interface bits for compatibility. This is a long due item from past. Cross-subsystem Changes: - Backmerge of branch drm-next-4.19 for DP_DPCD_REV_14 changes Core Changes: - None Driver Changes: - A load of Icelake (ICL) enabling patches (Paulo, Manasi) - Enabled full PPGTT for IVB,VLV and HSW (Chris) - Bugzilla #107113: Distribute DDB based on display resolutions (Mahesh) - Bugzillas #100023,#107476,#94921: Support limited range DP displays (Jani) - Bugzilla #107503: Increase LSPCON timeout (Fredrik) - Avoid boosting GPU due to an occasional stall in interactive workloads (Chris) - Apply GGTT coherency W/A only for affected systems instead of all (Chris) - Fix for infinite link training loop for faulty USB-C MST hubs (Nathan) - Keep KMS functional on Gen4 and earlier when GPU is wedged (Chris) - Stop holding ppGTT reference from closed VMAs (Chris) - Clear error registers after error capture (Lionel) - Various Icelake fixes (Anusha, Jyoti, Ville, Tvrtko) - Add missing Coffeelake (CFL) PCI IDs (Rodrigo) - Flush execlists tasklet directly from reset-finish (Chris) - Fix LPE audio runtime PM (Chris) - Fix detection of out of range surface positions (GLK/CNL) (Ville) - Remove wait-for-idle for PSR2 (Dhinakaran) - Power down existing display hardware resources when display is disabled (Chris) - Don't allow runtime power management if RC6 doesn't exist (Chris) - Add debugging checks for runtime power management paths (Imre) - Increase symmetry in display power init/fini paths (Imre) - Isolate GVT specific macros from i915_reg.h (Lucas) - Increase symmetry in power management enable/disable paths (Chris) - Increase IP disable timeout to 100 ms to avoid DRM_ERROR (Imre) - Fix memory leak from HDMI HDCP write function (Brian, Rodrigo) - Reject Y/Yf tiling on interlaced modes (Ville) - Use a cached mapping for the physical HWS on older gens (Chris) - Force slow path of writing relocations to buffer if unable to write to userspace (Chris) - Do a full device reset after being wedged (Chris) - Keep forcewake counts over reset (in case of debugfs user) (Imre, Chris) - Avoid false-positive errors from power wells during init (Imre) - Reset engines forcibly in exchange of declaring whole device wedged (Mika) - Reduce context HW ID lifetime in preparation for Icelake (Chris) - Attempt to recover from module load failures (Chris) - Keep select interrupts over a reset to avoid missing/losing them (Chris) - GuC submission backend improvements (Jakub) - Terminate context images with BB_END (Chris, Lionel) - Make GCC evaluate GGTT view struct size assertions again (Ville) - Add selftest to exercise suspend/hibernate code-paths for GEM (Chris) - Use a full emulation of a user ppgtt context in selftests (Chris) - Exercise resetting in the middle of a wait-on-fence in selftests (Chris) - Fix coherency issues on selftests for Baytrail (Chris) - Various other GEM fixes / self-test updates (Chris, Matt) - GuC doorbell self-tests (Daniele) - PSR mode control through debugfs for IGTs (Maarten) - Degrade expected WM latency errors to DRM_DEBUG_KMS (Chris) - Cope with errors better in MST link training (Dhinakaran) - Fix WARN on KBL external displays (Azhar) - Power well code cleanups (Imre) - Fixes to PSR debugging (Dhinakaran) - Make forcewake errors louder for easier catching in CI (WARNs) (Chris) - Fortify tiling code against programmer errors (Chris) - Bunch of fixes for CI exposed corner cases (multiple authors, mostly Chris) The following changes since commit 500775074f88d9cf5416bed2ca19592812d62c41: Merge branch 'drm-next-4.19' of git://people.freedesktop.org/~agd5f/linux into drm-next (2018-07-20 14:54:31 +1000) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-next-2018-09-06-2 for you to fetch changes up to a28957b8f10be714f076fb3981a3b1a0318c48c2: drm/i915: Update DRIVER_DATE to 20180906 (2018-09-06 16:54:43 +0300) ---------------------------------------------------------------- Merge tag 'gvt-next-2018-09-04' ---------------------------------------------------------------- Animesh Manna (1): drm/i915/icl: Update FIA supported lane count for hpd. Anusha Srivatsa (4): drm/i915/dsc: Add missing _MMIO() from PPS registers drm/i915/icl: Add TBT checks for PLL calculations drm/i915/icl: Set TBT IO in Aux transaction drm/i915: Do not redefine the has_csr parameter. Azhar Shaikh (2): drm/i915: Fix assert_plane() warning on bootup with external display drm/i915/psr: Add PSR mode/revision to debugfs Chris Wilson (68): drm/i915/gtt: Enable full-ppgtt by default everywhere drm/i915/gtt: Full ppgtt everywhere, no excuses drm/i915: Suppress assertion for i915_ggtt_disable_guc drm/i915: Only force GGTT coherency w/a on required chipsets drm/i915: Pull unpin map into vma release drm/i915: Show stack (by WARN) for hitting forcewake errors drm/i915: Skip repeated calls to i915_gem_set_wedged() drm/i915: Avoid computing tile_row_size() for untiled objects drm/i915: Mark up object tiling-and-stride getters as const drm/i915: Protect guc_fini_wq() against module load abort drm/i915: Restore sane defaults for KMS on GEM error load drm/i915: Don't disable the GPU for older gen on wedging drm/i915/selftests: Use a full emulation of a user ppgtt context drm/i915/selftests: Exercise resetting in the middle of a wait-on-fence drm/i915: Eliminate use of PAGE_SIZE as a virtual alignment drm/i915: Remove superfluous GEN8_LR_CONTEXT_ALIGN drm/i915: Drop unneed i915 parameter from intel_ring_pin() drm/i915: Downgrade Gen9 Plane WM latency error drm/i915: Kick waiters on resetting legacy rings drm/i915/selftests: Replace opencoded clflush with drm_clflush_virt_range drm/i915: Interactive RPS mode drm/i95: Mark GGTT as incoherent for gen10+ drm/i915/execlists: Terminate the context image with BB_END drm/i915: Drop stray clearing of rps->last_adj drm/i915/lpe: Mark LPE audio runtime pm as "no callbacks" drm/i915: Unconditionally clear the pm/guc GT IIR upon acking drm/i915: Clear all residual RPS events on disabling interrupts drm/i915: Stop dropping irq around resets drm/i915/selftests: Unconditionally do a chipset flush before emit_bb_start drm/i915: Pull seqno started checks together drm/i915: Warn if we hit the timeout for wait-for-idle drm/i915: Unmask user interrupts writes into HWSP on snb/ivb/vlv/hsw drm/i915: Remove extra waiter kick on legacy resets drm/i915: Restore user forcewake domains across suspend drm/i915/selftests: Hold rpm for unparking drm/i915: Bump priority of clean up work drm/i915: Cleanup gt powerstate from gem drm/i915: Restrict gen6_reset_rps_interrupts to gen6+ drm/i915: Kick waiters on resetting legacy rings drm/i915: Disable runtime-pm using lowlevel functions if !HAS_RC6 drm/i915: Clear stop-engine for a pardoned reset drm/i915: Only skip connector output for disable_display drm/i915: Remove useless error return from intel_init_mocs_engine() drm/i915: Stop holding a ref to the ppgtt from each vma drm/i915: Introduce intel_runtime_pm_disable to pair intel_runtime_pm_enable drm/i915/execlists: Include reset depth in traces drm/i915/audio: Hook up component bindings even if displays are disabled drm/i915: Correct CSB probing for engine state dumper drm/i915/execlists: Flush tasklet directly from reset-finish drm/i915/ringbuffer: Delay after invalidating gen6+ xcs drm/i915: Keep physical cursors pinned while in use drm/i915/selftests: Add a simple exerciser for suspend/hibernate drm/i915: Determine uses-full-ppgtt from context for execbuf drm/i915: Do a full device reset after being wedged drm/i915: Flag any possible writes for a GTT fault drm/i915: Force the slow path after a user-write error drm/i915: Early rejection of buffer allocations larger than RAM drm/i915: Forcibly flush unwanted requests in drop-caches drm/i915: Fix up FORCE_GPU_RELOC (debug) to flush CPU write domains drm/i915: Combine cleanup_status_page() drm/i915: Use a cached mapping for the physical HWS drm/i915: Double check we didn't miss an unclaimed register access drm/i915/ringbuffer: Move double invalidate to after pd flush drm/i915: Pull intel_uncore_arm_unclaimed_mmio_detection() under the spinlock drm/i915: Be defensive and don't assume PSR has any commit to sync against drm/i915: Reduce context HW ID lifetime drm/i915: Attach the pci match data to the device upon creation drm/i915: Move final cleanup of drm_i915_private to i915_driver_destroy Daniele Ceraolo Spurio (1): drm/i915/selftests: ring all doorbells in igt_guc_doorbells Dhinakaran Pandiyan (11): drm/i915/mst: Do not retrain new links drm/i915/mst: Continue state updates even if AUX writes fail. drm/i915/psr: Print PSR_STATUS when PSR idle wait times out. drm/i915/psr: Add missing check for I915_PSR_DEBUG_IRQ bit drm/i915/psr: Mask PSR irq bits when re-enabling interrupts. drm/i915: Add a small wrapper to check for CCS modifiers. drm/i915: Rename PLANE_CTL_DECOMPRESSION_ENABLE drm/i915/psr: Remove wait_for_idle() for PSR2 drm/i915/psr: Rewrite comments in intel_psr_wait_for_idle() drm/i915: Clean up skl_plane_has_planar() drm/i915: Do not advertize support for NV12 on ICL yet. Fredrik Schön (1): drm/i915: Increase LSPCON timeout Gwan-gyeong Mun (1): drm/i915: Fix typo in i915_drm_resume() Imre Deak (17): drm/i915/icl: Fix power well anonymous union initializers drm/i915: Rename intel_power_domains_fini() to intel_power_domains_fini_hw() drm/i915/vlv: Remove redundant power well ID asserts drm/i915: Constify power well descriptors drm/i915/vlv: Use power well CTL IDX instead of ID drm/i915/ddi: Use power well CTL IDX instead of ID drm/i915: Remove redundant power well IDs drm/i915: Make power well ID names more uniform drm/i915: Use existing power well IDs where possible drm/i915/icl: Add missing power gate enums drm/i915: Fix PM refcounting w/o DMC firmware drm/i915: Refactor intel_display_set_init_power() logic drm/i915: Verify power domains after enabling them drm/i915: Simplify condition to keep DMC active during S0ix drm/i915: Don't check power domains state in intel_power_domains_init_hw() drm/i915/dp_mst: Fix enabling pipe clock for all streams drm/i915/bdw: Increase IPS disable timeout to 100ms Jakub Bartmiński (5): drm/i915/guc: Avoid wasting memory on incorrect GuC pin bias drm/i915/guc: Do not partition WOPCM if GuC is not used drm/i915/guc: Move the pin bias value from GuC to GGTT drm/i915: Remove unnecessary ggtt_offset_bias from i915_gem_context drm/i915: Add a fault injection point to WOPCM init Jan-Marek Glogowski (1): drm/i915: Re-apply "Perform link quality check, unconditionally during long pulse" Jani Nikula (1): drm/i915: set DP Main Stream Attribute for color range on DDI platforms Joonas Lahtinen (7): drm/i915: Update DRIVER_DATE to 20180830 drm/i915: Update DRIVER_DATE to 20180830 drm/i915: Update DRIVER_DATE to 20180903 drm/i915: Update DRIVER_DATE to 20180906 drm/i915: Update DRIVER_DATE to 20180906 Merge tag 'gvt-next-2018-09-04' of https://github.com/intel/gvt-linux into drm-intel-next-queued drm/i915: Update DRIVER_DATE to 20180906 Jyoti Yadav (1): drm/i915/intel_csr.c Fix DMC FW Loading issue on ICL. Lionel Landwerlin (3): drm/i915: clear error registers after error capture drm/i915/perf: simplify configure all context function drm/i915/perf: reuse intel_lrc ctx regs macro Lucas De Marchi (5): drm/i915/icl: move has_resource_streamer to GEN11_FEATURES drm/i915: kill resource streamer support drm/i915: make PCH_GMBUS* definitions private to gvt drm/i915/gvt: use its own define for gpio drm/i915: remove confusing GPIO vs PCH_GPIO Maarten Lankhorst (2): drm/i915: Allow control of PSR at runtime through debugfs, v6 drm/i915/psr: Add debugfs support to force a downgrade to PSR1 mode. Mahesh Kumar (2): drm/i915: ddb_size is of u16 type drm/i915/skl: distribute DDB based on panel resolution Manasi Navare (5): drm/i915/icl: Add remaining registers and bitfields for MG PHY DDI drm/i915/icl: Implement voltage swing programming sequence for MG PHY DDI drm/i915/icl: Implement HSDIV_RATIO of MG_CLKTOP2_HSCLKCTL_PORT reg as separate divider value defines drm/i915/icl: Get DDI clock for ICL for MG PLL and TBT PLL drm/i915/dsc: Fix PPS register definition macros for 2nd VDSC engine Matthew Auld (1): drm/i915/gtt: remove px_page Michał Winiarski (1): drm/i915/kvmgt: Fix compilation error Mika Kuoppala (3): Revert "drm/i915/icl: WaEnableFloatBlendOptimization" drm/i915: Expose retry count to per gen reset logic drm/i915: Force reset on unready engine Nathan Ciobanu (3): drm/i915/dp: Limit link training clock recovery loop drm/i915/dp: Refactor max_vswing_tries variable drm/i915/dp: Improve clock recovery loop limit comment Paulo Zanoni (13): drm/i915/icl: compute the TBT PLL registers drm/i915/icl: implement icl_digital_port_connected() drm/i915/icl: store the port type for TC ports drm/i915/icl: program MG_DP_MODE drm/i915/icl: toggle PHY clock gating around link training drm/i915/icl: don't set CNL_DDI_CLOCK_REG_ACCESS_ON anymore drm/i915: inline skl_copy_ddb_for_pipe() to its only caller drm/i915/icl: avoid unclaimed PLANE_NV12_BUF_CFG register drm/i915/icl: account for context save/restore removed bits drm/i915/icl: implement the tc/legacy HPD {dis,}connect flows drm/i915: WARN() if we can't lookup_power_well() drm/i915: use for_each_power_well in lookup_power_well() drm/i915: move lookup_power_well() up Rodrigo Vivi (7): drm/i915: Remove unused "ret" variable. drm/i915: Fix psr sink status report. Merge drm/drm-next into drm-intel-next-queued drm/i915/cfl: Add a new CFL PCI ID. drm/i915: Free write_buf that we allocated with kzalloc. drm/i915: introduce dp_to_i915() helper drm/i915: Use dp_to_i915 on intel_psr.c Tvrtko Ursulin (2): drm/i915: Explicitly mark Global GTT address spaces drm/i915/icl: Fix context RPCS programming Ville Syrjälä (5): drm/i915: Fix glk/cnl display w/a #1175 drm/i915: Fix gtt_view asserts drm/i915: Don't pass plane to .check_plane() drm/i915: Reject compressed Y/Yf with interlaced modes drm/i915: Fix ICL+ HDMI clock readout Zhao Yan (2): drm/i915/gvt: add a fastpath for cmd parsing on MI_NOOP drm/i915/gvt: only copy the first page for restore inhibit context Zhenyu Wang (3): drm/i915/gvt: make dma map/unmap kvmgt functions as static drm/i915/gvt: Fix function comment doc errors drm/i915/gvt: Move some MMIO definitions to reg.h drivers/gpu/drm/i915/Kconfig.debug | 12 + drivers/gpu/drm/i915/gvt/cfg_space.c | 12 + drivers/gpu/drm/i915/gvt/cmd_parser.c | 11 +- drivers/gpu/drm/i915/gvt/display.c | 1 + drivers/gpu/drm/i915/gvt/edid.c | 9 + drivers/gpu/drm/i915/gvt/gtt.c | 9 +- drivers/gpu/drm/i915/gvt/gvt.c | 3 +- drivers/gpu/drm/i915/gvt/handlers.c | 34 +- drivers/gpu/drm/i915/gvt/kvmgt.c | 10 +- drivers/gpu/drm/i915/gvt/mmio.c | 3 +- drivers/gpu/drm/i915/gvt/mmio_context.c | 13 - drivers/gpu/drm/i915/gvt/mmio_context.h | 3 + drivers/gpu/drm/i915/gvt/opregion.c | 1 - drivers/gpu/drm/i915/gvt/page_track.c | 2 + drivers/gpu/drm/i915/gvt/reg.h | 18 + drivers/gpu/drm/i915/gvt/scheduler.c | 64 +- drivers/gpu/drm/i915/i915_debugfs.c | 114 ++- drivers/gpu/drm/i915/i915_drv.c | 194 ++-- drivers/gpu/drm/i915/i915_drv.h | 79 +- drivers/gpu/drm/i915/i915_gem.c | 65 +- drivers/gpu/drm/i915/i915_gem.h | 6 - drivers/gpu/drm/i915/i915_gem_context.c | 232 +++-- drivers/gpu/drm/i915/i915_gem_context.h | 26 +- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 43 +- drivers/gpu/drm/i915/i915_gem_gtt.c | 52 +- drivers/gpu/drm/i915/i915_gem_gtt.h | 23 +- drivers/gpu/drm/i915/i915_gem_object.h | 10 +- drivers/gpu/drm/i915/i915_irq.c | 40 +- drivers/gpu/drm/i915/i915_pci.c | 16 +- drivers/gpu/drm/i915/i915_perf.c | 55 +- drivers/gpu/drm/i915/i915_reg.h | 731 +++++++------- drivers/gpu/drm/i915/i915_request.c | 9 +- drivers/gpu/drm/i915/i915_request.h | 39 +- drivers/gpu/drm/i915/i915_vma.c | 9 +- drivers/gpu/drm/i915/i915_vma.h | 10 +- drivers/gpu/drm/i915/intel_atomic_plane.c | 6 +- drivers/gpu/drm/i915/intel_audio.c | 3 - drivers/gpu/drm/i915/intel_breadcrumbs.c | 6 +- drivers/gpu/drm/i915/intel_csr.c | 33 +- drivers/gpu/drm/i915/intel_ddi.c | 244 ++++- drivers/gpu/drm/i915/intel_device_info.h | 2 +- drivers/gpu/drm/i915/intel_display.c | 199 ++-- drivers/gpu/drm/i915/intel_display.h | 28 +- drivers/gpu/drm/i915/intel_dp.c | 534 +++++++++-- drivers/gpu/drm/i915/intel_dp_link_training.c | 25 +- drivers/gpu/drm/i915/intel_dp_mst.c | 14 +- drivers/gpu/drm/i915/intel_dpll_mgr.c | 62 +- drivers/gpu/drm/i915/intel_dpll_mgr.h | 1 + drivers/gpu/drm/i915/intel_drv.h | 45 +- drivers/gpu/drm/i915/intel_engine_cs.c | 93 +- drivers/gpu/drm/i915/intel_guc.c | 102 +- drivers/gpu/drm/i915/intel_guc.h | 12 +- drivers/gpu/drm/i915/intel_guc_ads.c | 2 +- drivers/gpu/drm/i915/intel_guc_ct.c | 7 +- drivers/gpu/drm/i915/intel_guc_fwif.h | 1 + drivers/gpu/drm/i915/intel_guc_log.c | 2 +- drivers/gpu/drm/i915/intel_guc_submission.c | 35 +- drivers/gpu/drm/i915/intel_guc_submission.h | 4 + drivers/gpu/drm/i915/intel_hangcheck.c | 2 +- drivers/gpu/drm/i915/intel_hdcp.c | 6 +- drivers/gpu/drm/i915/intel_hdmi.c | 19 +- drivers/gpu/drm/i915/intel_huc.c | 2 +- drivers/gpu/drm/i915/intel_i2c.c | 16 +- drivers/gpu/drm/i915/intel_lpe_audio.c | 4 +- drivers/gpu/drm/i915/intel_lrc.c | 159 +++- drivers/gpu/drm/i915/intel_lrc.h | 2 - drivers/gpu/drm/i915/intel_lrc_reg.h | 2 +- drivers/gpu/drm/i915/intel_lspcon.c | 2 +- drivers/gpu/drm/i915/intel_mocs.c | 11 +- drivers/gpu/drm/i915/intel_mocs.h | 2 +- drivers/gpu/drm/i915/intel_pm.c | 202 ++-- drivers/gpu/drm/i915/intel_psr.c | 277 ++++-- drivers/gpu/drm/i915/intel_ringbuffer.c | 124 +-- drivers/gpu/drm/i915/intel_ringbuffer.h | 39 +- drivers/gpu/drm/i915/intel_runtime_pm.c | 1003 +++++++++++++------- drivers/gpu/drm/i915/intel_sprite.c | 13 +- drivers/gpu/drm/i915/intel_uc_fw.c | 2 +- drivers/gpu/drm/i915/intel_uncore.c | 176 ++-- drivers/gpu/drm/i915/intel_uncore.h | 1 + drivers/gpu/drm/i915/intel_wopcm.c | 6 + drivers/gpu/drm/i915/intel_workarounds.c | 3 - drivers/gpu/drm/i915/selftests/huge_pages.c | 11 +- drivers/gpu/drm/i915/selftests/i915_gem.c | 221 +++++ .../gpu/drm/i915/selftests/i915_gem_coherency.c | 38 +- drivers/gpu/drm/i915/selftests/i915_gem_object.c | 22 +- .../gpu/drm/i915/selftests/i915_live_selftests.h | 1 + drivers/gpu/drm/i915/selftests/intel_guc.c | 38 + drivers/gpu/drm/i915/selftests/intel_hangcheck.c | 101 +- drivers/gpu/drm/i915/selftests/intel_uncore.c | 2 +- drivers/gpu/drm/i915/selftests/mock_context.c | 11 +- drivers/gpu/drm/i915/selftests/mock_gtt.c | 2 + include/drm/i915_pciids.h | 1 + include/uapi/drm/i915_drm.h | 22 + 93 files changed, 4051 insertions(+), 1910 deletions(-) create mode 100644 drivers/gpu/drm/i915/selftests/i915_gem.c

1 0

[PATCH v4 00/11] arm64: allwinner: Add A64 DE2 HDMI support
by Icenowy Zheng 07 Sep '18

07 Sep '18

Allwinner A64 has display engine pipeline like other Allwinner SOC's A83T/H3/H5. A64 behaviour similar to Allwinner A83T where Mixer0 => TCON0 => LVDS/RGB/MIPI-DSI Mixer1 => TCON1 => HDMI as per Display System Block Diagram from the A64 user manual. This patchset adds support for the two display pipelines, and enables the HDMI output on several boards. The first pipeline is not enabled in this patchset yet, although it's added. Icenowy Zheng (2): clk: sunxi-ng: a64: Add max. rate constraint to video PLLs dt-bindings: sun4i-drm: add HDMI VCC supply property for sun8i-dw-hdmi Jagan Teki (8): clk: sunxi-ng: a64: Add minimal rate for video PLLs dt-bindings: display: Add compatible for A64 DE2 display pipeline drm/sun4i: Add support for A64 mixers drm/sun4i: Add support for A64 display engine dt-bindings: display: Add compatible for A64 HDMI dt-bindings: clock: sun50i-a64-ccu: Add PLL_VIDEO0 macro arm64: dts: allwinner: a64: Add display pipeline arm64: dts: allwinner: a64: Enable HDMI output on A64 boards w/ HDMI Jernej Skrabec (1): drm/sun4i: Add support for HDMI voltage regulator .../bindings/display/sunxi/sun4i-drm.txt | 9 + .../dts/allwinner/sun50i-a64-bananapi-m64.dts | 34 ++++ .../dts/allwinner/sun50i-a64-nanopi-a64.dts | 34 ++++ .../dts/allwinner/sun50i-a64-olinuxino.dts | 34 ++++ .../dts/allwinner/sun50i-a64-orangepi-win.dts | 34 ++++ .../boot/dts/allwinner/sun50i-a64-pine64.dts | 34 ++++ .../allwinner/sun50i-a64-sopine-baseboard.dts | 34 ++++ arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 170 ++++++++++++++++++ drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 48 ++--- drivers/clk/sunxi-ng/ccu-sun50i-a64.h | 4 +- drivers/gpu/drm/sun4i/sun4i_drv.c | 1 + drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 17 +- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h | 2 + drivers/gpu/drm/sun4i/sun8i_mixer.c | 24 +++ include/dt-bindings/clock/sun50i-a64-ccu.h | 1 + 15 files changed, 456 insertions(+), 24 deletions(-) -- 2.18.0

6 33

[PATCH] bochs: convert to drm_fb_helper_fbdev_setup/teardown
by Peter Wu 07 Sep '18

07 Sep '18

Currently unloading bochs_drm (after unbinding the vtconsole) results in a warning about a leaked connector: [drm:drm_mode_config_cleanup] *ERROR* connector Virtual-3 leaked! While investigating a potential fix I noticed that a lot of open-coded functionality is already implemented elsewhere, so start converting it: bochs_fbdev_init -> drm_fb_helper_fbdev_setup: trivial (similar impl). bochs_fbdev_fini -> drm_fb_helper_fbdev_teardown: requires unembedding "struct drm_framebuffer" from "struct bochs_framebuffer". Unembedding drm_framebuffer is made easy using drm_gem_fbdev_fb_create which can replace bochs_fbdev_destroy and custom routines in bochs_mm.c. For this to work, the GEM object is moved into "drm_framebuffer". After that, "bochs_framebuffer" is no longer needed and therefore removed. Remove the unused "size" and "initialized" fields from fb, the latter is not necessary as drm_fb_helper_fbdev_teardown can be called even if bochsfb_create fails. This theory was tested by returning early and late (just before drm_gem_fbdev_fb_create). Both scenarios fail gracefully although the latter seems to leak the object from bochsfb_create_object (not a regression). Guess on the reason for the encoder leak: drm_framebuffer_cleanup was previously used, but did not destroy much. drm_fb_helper_fbdev_teardown is now used and calls drm_framebuffer_remove which does a bit more work. Tested with 'echo 0 > /sys/class/vtconsole/vtcon1/bind; rmmod bochs_drm' and also with Xorg + fbdev (startx -> xterm). The latter triggered a warning in ttm_bo_vm_open that existed before, see https://lkml.kernel.org/r/1464000533-13140-4-git-send-email-mstaudt@suse.de Signed-off-by: Peter Wu <peter(a)lekensteyn.nl> --- drivers/gpu/drm/bochs/bochs.h | 19 ++----- drivers/gpu/drm/bochs/bochs_fbdev.c | 79 +++++++---------------------- drivers/gpu/drm/bochs/bochs_kms.c | 7 +-- drivers/gpu/drm/bochs/bochs_mm.c | 74 --------------------------- 4 files changed, 22 insertions(+), 157 deletions(-) diff --git a/drivers/gpu/drm/bochs/bochs.h b/drivers/gpu/drm/bochs/bochs.h index 375bf92cd04f..8514a84fbdbe 100644 --- a/drivers/gpu/drm/bochs/bochs.h +++ b/drivers/gpu/drm/bochs/bochs.h @@ -51,11 +51,6 @@ enum bochs_types { BOCHS_UNKNOWN, }; -struct bochs_framebuffer { - struct drm_framebuffer base; - struct drm_gem_object *obj; -}; - struct bochs_device { /* hw */ void __iomem *mmio; @@ -88,15 +83,11 @@ struct bochs_device { /* fbdev */ struct { - struct bochs_framebuffer gfb; + struct drm_framebuffer *fb; struct drm_fb_helper helper; - int size; - bool initialized; } fb; }; -#define to_bochs_framebuffer(x) container_of(x, struct bochs_framebuffer, base) - struct bochs_bo { struct ttm_buffer_object bo; struct ttm_placement placement; @@ -148,15 +139,9 @@ int bochs_dumb_create(struct drm_file *file, struct drm_device *dev, int bochs_dumb_mmap_offset(struct drm_file *file, struct drm_device *dev, uint32_t handle, uint64_t *offset); -int bochs_framebuffer_init(struct drm_device *dev, - struct bochs_framebuffer *gfb, - const struct drm_mode_fb_cmd2 *mode_cmd, - struct drm_gem_object *obj); int bochs_bo_pin(struct bochs_bo *bo, u32 pl_flag, u64 *gpu_addr); int bochs_bo_unpin(struct bochs_bo *bo); -extern const struct drm_mode_config_funcs bochs_mode_funcs; - /* bochs_kms.c */ int bochs_kms_init(struct bochs_device *bochs); void bochs_kms_fini(struct bochs_device *bochs); @@ -164,3 +149,5 @@ void bochs_kms_fini(struct bochs_device *bochs); /* bochs_fbdev.c */ int bochs_fbdev_init(struct bochs_device *bochs); void bochs_fbdev_fini(struct bochs_device *bochs); + +extern const struct drm_mode_config_funcs bochs_mode_funcs; diff --git a/drivers/gpu/drm/bochs/bochs_fbdev.c b/drivers/gpu/drm/bochs/bochs_fbdev.c index 14eb8d0d5a00..8f4d6c052f7b 100644 --- a/drivers/gpu/drm/bochs/bochs_fbdev.c +++ b/drivers/gpu/drm/bochs/bochs_fbdev.c @@ -6,6 +6,7 @@ */ #include "bochs.h" +#include <drm/drm_gem_framebuffer_helper.h> /* ---------------------------------------------------------------------- */ @@ -13,9 +14,7 @@ static int bochsfb_mmap(struct fb_info *info, struct vm_area_struct *vma) { struct drm_fb_helper *fb_helper = info->par; - struct bochs_device *bochs = - container_of(fb_helper, struct bochs_device, fb.helper); - struct bochs_bo *bo = gem_to_bochs_bo(bochs->fb.gfb.obj); + struct bochs_bo *bo = gem_to_bochs_bo(fb_helper->fb->obj[0]); return ttm_fbdev_mmap(vma, &bo->bo); } @@ -101,19 +100,20 @@ static int bochsfb_create(struct drm_fb_helper *helper, /* init fb device */ info = drm_fb_helper_alloc_fbi(helper); - if (IS_ERR(info)) + if (IS_ERR(info)) { + DRM_ERROR("Failed to allocate fbi: %ld\n", PTR_ERR(info)); return PTR_ERR(info); + } info->par = &bochs->fb.helper; - ret = bochs_framebuffer_init(bochs->dev, &bochs->fb.gfb, &mode_cmd, gobj); - if (ret) - return ret; - - bochs->fb.size = size; + fb = drm_gem_fbdev_fb_create(bochs->dev, sizes, 0, gobj, NULL); + if (IS_ERR(fb)) { + DRM_ERROR("Failed to create framebuffer: %ld\n", PTR_ERR(fb)); + return PTR_ERR(fb); + } /* setup helper */ - fb = &bochs->fb.gfb.base; bochs->fb.helper.fb = fb; strcpy(info->fix.id, "bochsdrmfb"); @@ -130,27 +130,6 @@ static int bochsfb_create(struct drm_fb_helper *helper, drm_vma_offset_remove(&bo->bo.bdev->vma_manager, &bo->bo.vma_node); info->fix.smem_start = 0; info->fix.smem_len = size; - - bochs->fb.initialized = true; - return 0; -} - -static int bochs_fbdev_destroy(struct bochs_device *bochs) -{ - struct bochs_framebuffer *gfb = &bochs->fb.gfb; - - DRM_DEBUG_DRIVER("\n"); - - drm_fb_helper_unregister_fbi(&bochs->fb.helper); - - if (gfb->obj) { - drm_gem_object_unreference_unlocked(gfb->obj); - gfb->obj = NULL; - } - - drm_framebuffer_unregister_private(&gfb->base); - drm_framebuffer_cleanup(&gfb->base); - return 0; } @@ -158,41 +137,17 @@ static const struct drm_fb_helper_funcs bochs_fb_helper_funcs = { .fb_probe = bochsfb_create, }; +const struct drm_mode_config_funcs bochs_mode_funcs = { + .fb_create = drm_gem_fb_create, +}; + int bochs_fbdev_init(struct bochs_device *bochs) { - int ret; - - drm_fb_helper_prepare(bochs->dev, &bochs->fb.helper, - &bochs_fb_helper_funcs); - - ret = drm_fb_helper_init(bochs->dev, &bochs->fb.helper, 1); - if (ret) - return ret; - - ret = drm_fb_helper_single_add_all_connectors(&bochs->fb.helper); - if (ret) - goto fini; - - drm_helper_disable_unused_functions(bochs->dev); - - ret = drm_fb_helper_initial_config(&bochs->fb.helper, 32); - if (ret) - goto fini; - - return 0; - -fini: - drm_fb_helper_fini(&bochs->fb.helper); - return ret; + return drm_fb_helper_fbdev_setup(bochs->dev, &bochs->fb.helper, + &bochs_fb_helper_funcs, 32, 1); } void bochs_fbdev_fini(struct bochs_device *bochs) { - if (bochs->fb.initialized) - bochs_fbdev_destroy(bochs); - - if (bochs->fb.helper.fbdev) - drm_fb_helper_fini(&bochs->fb.helper); - - bochs->fb.initialized = false; + drm_fb_helper_fbdev_teardown(bochs->dev); } diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c index 233980a78591..c7e575511d2f 100644 --- a/drivers/gpu/drm/bochs/bochs_kms.c +++ b/drivers/gpu/drm/bochs/bochs_kms.c @@ -35,14 +35,12 @@ static int bochs_crtc_mode_set_base(struct drm_crtc *crtc, int x, int y, { struct bochs_device *bochs = container_of(crtc, struct bochs_device, crtc); - struct bochs_framebuffer *bochs_fb; struct bochs_bo *bo; u64 gpu_addr = 0; int ret; if (old_fb) { - bochs_fb = to_bochs_framebuffer(old_fb); - bo = gem_to_bochs_bo(bochs_fb->obj); + bo = gem_to_bochs_bo(old_fb->obj[0]); ret = ttm_bo_reserve(&bo->bo, true, false, NULL); if (ret) { DRM_ERROR("failed to reserve old_fb bo\n"); @@ -55,8 +53,7 @@ static int bochs_crtc_mode_set_base(struct drm_crtc *crtc, int x, int y, if (WARN_ON(crtc->primary->fb == NULL)) return -EINVAL; - bochs_fb = to_bochs_framebuffer(crtc->primary->fb); - bo = gem_to_bochs_bo(bochs_fb->obj); + bo = gem_to_bochs_bo(crtc->primary->fb->obj[0]); ret = ttm_bo_reserve(&bo->bo, true, false, NULL); if (ret) return ret; diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c index 39cd08416773..cdbc3ca3ec51 100644 --- a/drivers/gpu/drm/bochs/bochs_mm.c +++ b/drivers/gpu/drm/bochs/bochs_mm.c @@ -457,77 +457,3 @@ int bochs_dumb_mmap_offset(struct drm_file *file, struct drm_device *dev, drm_gem_object_unreference_unlocked(obj); return 0; } - -/* ---------------------------------------------------------------------- */ - -static void bochs_user_framebuffer_destroy(struct drm_framebuffer *fb) -{ - struct bochs_framebuffer *bochs_fb = to_bochs_framebuffer(fb); - - drm_gem_object_unreference_unlocked(bochs_fb->obj); - drm_framebuffer_cleanup(fb); - kfree(fb); -} - -static const struct drm_framebuffer_funcs bochs_fb_funcs = { - .destroy = bochs_user_framebuffer_destroy, -}; - -int bochs_framebuffer_init(struct drm_device *dev, - struct bochs_framebuffer *gfb, - const struct drm_mode_fb_cmd2 *mode_cmd, - struct drm_gem_object *obj) -{ - int ret; - - drm_helper_mode_fill_fb_struct(dev, &gfb->base, mode_cmd); - gfb->obj = obj; - ret = drm_framebuffer_init(dev, &gfb->base, &bochs_fb_funcs); - if (ret) { - DRM_ERROR("drm_framebuffer_init failed: %d\n", ret); - return ret; - } - return 0; -} - -static struct drm_framebuffer * -bochs_user_framebuffer_create(struct drm_device *dev, - struct drm_file *filp, - const struct drm_mode_fb_cmd2 *mode_cmd) -{ - struct drm_gem_object *obj; - struct bochs_framebuffer *bochs_fb; - int ret; - - DRM_DEBUG_DRIVER("%dx%d, format %c%c%c%c\n", - mode_cmd->width, mode_cmd->height, - (mode_cmd->pixel_format) & 0xff, - (mode_cmd->pixel_format >> 8) & 0xff, - (mode_cmd->pixel_format >> 16) & 0xff, - (mode_cmd->pixel_format >> 24) & 0xff); - - if (mode_cmd->pixel_format != DRM_FORMAT_XRGB8888) - return ERR_PTR(-ENOENT); - - obj = drm_gem_object_lookup(filp, mode_cmd->handles[0]); - if (obj == NULL) - return ERR_PTR(-ENOENT); - - bochs_fb = kzalloc(sizeof(*bochs_fb), GFP_KERNEL); - if (!bochs_fb) { - drm_gem_object_unreference_unlocked(obj); - return ERR_PTR(-ENOMEM); - } - - ret = bochs_framebuffer_init(dev, bochs_fb, mode_cmd, obj); - if (ret) { - drm_gem_object_unreference_unlocked(obj); - kfree(bochs_fb); - return ERR_PTR(ret); - } - return &bochs_fb->base; -} - -const struct drm_mode_config_funcs bochs_mode_funcs = { - .fb_create = bochs_user_framebuffer_create, -}; -- 2.18.0

4 4

[Bug 106225] Kernel panic after modesetting (not on every boot) on ryzen 5 2400g
by bugzilla-daemon＠freedesktop.org 07 Sep '18

07 Sep '18

https://bugs.freedesktop.org/show_bug.cgi?id=106225 Bug ID: 106225 Summary: Kernel panic after modesetting (not on every boot) on ryzen 5 2400g Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: f.pinamartins(a)gmail.com Created attachment 139081 --> https://bugs.freedesktop.org/attachment.cgi?id=139081&action=edit journaltcl log file On a new Ryzen 5 2400G build, I am using linux-4.16.3 (Arch Linux). On some boots (~1 out of every 3) I get a kernel panic after modesetting occurs. I have attached the relevant systemd logfile (for the entire boot process). I am not sure what component is failing, but I suspect AMDGPU, since it happens suspiciously after modesetting. If it matters, the mainboard is a Gigabyte "AB350N-Gaminig Wifi", with the latest available BIOS as of writing (BIOS F23d 04/17/2018). Please advise if more information is required. -- You are receiving this mail because: You are the assignee for the bug.

1 38

[PATCH -next] drm/virtio: Remove set but not used variable 'bo'
by YueHaibing 07 Sep '18

07 Sep '18

Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/virtio/virtgpu_display.c: In function 'virtio_gpu_framebuffer_init': drivers/gpu/drm/virtio/virtgpu_display.c:78:28: warning: variable 'bo' set but not used [-Wunused-but-set-variable] struct virtio_gpu_object *bo; ^ Signed-off-by: YueHaibing <yuehaibing(a)huawei.com> --- drivers/gpu/drm/virtio/virtgpu_display.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c index 9f1e0a6..0379d68 100644 --- a/drivers/gpu/drm/virtio/virtgpu_display.c +++ b/drivers/gpu/drm/virtio/virtgpu_display.c @@ -75,12 +75,9 @@ struct drm_gem_object *obj) { int ret; - struct virtio_gpu_object *bo; vgfb->base.obj[0] = obj; - bo = gem_to_virtio_gpu_obj(obj); - drm_helper_mode_fill_fb_struct(dev, &vgfb->base, mode_cmd); ret = drm_framebuffer_init(dev, &vgfb->base, &virtio_gpu_fb_funcs);

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2018