dri-devel January 2019

dri-devel@lists.freedesktop.org

279 participants
2022 discussions

linux-next: build warnings after merge of the drm-intel tree
by Stephen Rothwell 07 Jan '19

07 Jan '19

Hi all, After merging the drm-intel tree, today's linux-next build (x86_64 allmodconfig) produced these warnings: In file included from include/linux/printk.h:7, from include/linux/kernel.h:14, from include/asm-generic/bug.h:18, from arch/x86/include/asm/bug.h:83, from include/linux/bug.h:5, from include/linux/mmdebug.h:5, from include/linux/gfp.h:5, from include/linux/slab.h:… [View More]

1 0

[Bug 109178] Keyboard backlight on Samsung Np900X5N not working due to not loading samsung-laptop.ko module
by bugzilla-daemon＠freedesktop.org 07 Jan '19

07 Jan '19

https://bugs.freedesktop.org/show_bug.cgi?id=109178 Jan <jv1(a)home.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|NOTOURBUG |FIXED --- Comment #11 from Jan <jv1(a)home.nl> --- Just for the sake of record I found the solution: The (UEFI based) kernel creates /sys/firmware/efi/efivars with the variable: KBDBacklitLvl-5af56f53-985c-47d5-920c-… [View More]

1 0

[PATCH v2 0/3] drm/exynos: rotator: Add support for s5pv210
by Paweł Chmiel 07 Jan '19

07 Jan '19

This patchset adds support for s5pv210 soc, into Samsung DRM Rotator driver. Currently only NV12 and XRGB8888 formats are supported. It was tested by using simple tool from https://www.spinics.net/lists/linux-samsung-soc/msg60498.html Changes from v1: - fixed order of chipsets in documentation and removed ordering from it Paweł Chmiel (3): drm/exynos: rotator: Add support for s5pv210 dt-bindings: gpu: samsung-rotator: Document s5pv210 support ARM: dts: s5pv210: Add node for … [View More]

3 6

[PULL] topic/drmp-cleanup for drm-misc-next and drm-intel-next-queued
by Jani Nikula 07 Jan '19

07 Jan '19

Hi Sean, Maarten & Maxime - I embarked on removing drmP.h includes from i915, but that requires a bunch of drm header cleanup to add relevant includes and forward declarations. Due to the timing, propagating the patches back to i915 would take eons, so Daniel suggested a topic branch to be merged both to drm-misc-next and drm-intel-next-queued. So here it is, with $(git merge-base drm-misc-next drm-intel-next-queued) as the starting point. The topic branch has been part of drm-tip since, … [View More]

2 1

[PULL] drm-misc-next
by Maxime Ripard 07 Jan '19

07 Jan '19

Hi Dave, Daniel, Here is the first PR for 5.1 for drm-misc-next. This is my first PR ever for drm-misc, so please let me know if I screwed up somehow :) Thanks! Maxime drm-misc-next-2019-01-07-1: drm-misc-next for 5.1: UAPI Changes: Cross-subsystem Changes: - Turn dma-buf fence sequence numbers into 64 bit numbers Core Changes: - Move to a common helper for the DP MST hotplug for radeon, i915 and amdgpu - i2c improvements for drm_dp_mst - Removal of drm_syncobj_cb - … [View More]Introduction of an helper to create and attach the TV margin properties Driver Changes: - Improve cache flushes for v3d - Reflection support for vc4 - HDMI overscan support for vc4 - Add implicit fencing support for rockchip and sun4i - Switch to generic fbdev emulation for virtio The following changes since commit 0b258ed1a219a9776e8f6967eb34837ae0332e64: drm: revert "expand replace_fence to support timeline point v2" (2018-12-05 11:01:11 +0100) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-next-2019-01-07-1 for you to fetch changes up to 1c95f662fceeb8ae2f34e3de9478e21fd31f09dd: Merge tag 'topic/drmp-cleanup-2019-01-02' of git://anongit.freedesktop.org/drm/drm-intel into drm-misc-next (2019-01-07 16:43:24 +0100) ---------------------------------------------------------------- drm-misc-next for 5.1: UAPI Changes: Cross-subsystem Changes: - Turn dma-buf fence sequence numbers into 64 bit numbers Core Changes: - Move to a common helper for the DP MST hotplug for radeon, i915 and amdgpu - i2c improvements for drm_dp_mst - Removal of drm_syncobj_cb - Introduction of an helper to create and attach the TV margin properties Driver Changes: - Improve cache flushes for v3d - Reflection support for vc4 - HDMI overscan support for vc4 - Add implicit fencing support for rockchip and sun4i - Switch to generic fbdev emulation for virtio ---------------------------------------------------------------- Archit Taneja (1): MAINTAINERS: drm: Remove myself as drm-bridge maintainer Boris Brezillon (7): drm/vc4: Fix negative X/Y positioning on SAND planes drm/vc4: Add support for X/Y reflection drm/connector: Fix drm_mode_create_tv_properties() doc drm/connector: Clarify the unit of TV margins drm/connector: Allow creation of margin props alone drm/vc4: Take margin setup into account when updating planes drm/vc4: Attach margin props to the HDMI connector Brajeswar Ghosh (1): drm/drm_drv.c: Remove duplicate header Chris Wilson (1): drm: Reorder set_property_atomic to avoid returning with an active ww_ctx Christian König (4): drm/v3d: fix broken build dma-buf: make fence sequence numbers 64 bit v2 drm/etnaviv: fix for 64bit seqno change drm/syncobj: remove drm_syncobj_cb and cleanup Dan Carpenter (2): drm: Fix an error pointer dereference() drm/ati_pcigart: Fix error code in drm_ati_pcigart_init() Daniel Vetter (3): drm/dp-mst-helper: Remove hotplug callback drm/qxl: Don't set the dpms hook drm/xen: Don't set the dpms hook Eric Anholt (6): drm/v3d: Document cache flushing ABI. drm/v3d: Drop unused v3d_flush_caches(). drm/v3d: Don't bother flushing L1TD at job start. drm/v3d: Drop the wait for L2T flush to complete. drm/v3d: Stop trying to flush L2C on V3D 3.3+ drm/v3d: Invalidate the caches from the outside in. Gerd Hoffmann (3): drm/qxl: add spice-devel list to MAINTAINERS drm/virtio: switch to generic fbdev emulation drm/bochs: add edid present check Heiko Stuebner (1): drm/rockchip: Add implicit fencing support for planes Jani Nikula (5): drm: un-inline drm_legacy_findmap() drm: include kernel.h and agp_backend.h from intel-gtt.h drm: include idr.h from drm_file.h drm: include types.h from drm_hdcp.h drm: forward declare struct drm_file in drm_syncobj.h Kuninori Morimoto (1): drm: dw-hdmi-i2s: convert to SPDX identifiers Lyude Paul (3): drm/dp_mst: Fix memory leak in drm_dp_mst_topology_mgr_destroy() drm/dp_mst: Remove bogus conditional in drm_dp_update_payload_part1() drm/dp_mst: Refactor drm_dp_update_payload_part1() Maxime Ripard (1): Merge tag 'topic/drmp-cleanup-2019-01-02' of git://anongit.freedesktop.org/drm/drm-intel into drm-misc-next Mika Kuoppala (1): drm/i915: Compile fix for 64b dma-fence seqno Rob Clark (1): drm/atomic: integrate modeset lock with private objects Sam Ravnborg (1): drm: move DRM_IF_VERSION to drm_internal.h Shayenne da Luz Moura (2): drm: Rename crtc_idr as object_idr to KMS cleanups drm: Remove complete task from TODO documentation Ville Syrjälä (2): drm/dp/mst: Configure no_stop_bit correctly for remote i2c xfers drm/dp/mst: Validate REMOTE_I2C_READ harder Yangtao Li (1): dma-buf: Change to use DEFINE_SHOW_ATTRIBUTE macro YueHaibing (2): drm/ast: Remove set but not used variable 'bo' drm: Fix error handling in drm_legacy_addctx emersion (1): drm/vkms: set preferred depth to 24 Documentation/gpu/todo.rst | 3 - MAINTAINERS | 2 +- drivers/dma-buf/dma-buf.c | 12 +- drivers/dma-buf/dma-fence.c | 2 +- drivers/dma-buf/sw_sync.c | 2 +- drivers/dma-buf/sync_debug.c | 16 +- drivers/dma-buf/sync_file.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c | 2 +- .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 9 - drivers/gpu/drm/ast/ast_fb.c | 2 - drivers/gpu/drm/ati_pcigart.c | 7 +- drivers/gpu/drm/bochs/bochs_hw.c | 7 + .../gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c | 5 +- drivers/gpu/drm/drm_atomic.c | 19 +- drivers/gpu/drm/drm_bufs.c | 11 ++ drivers/gpu/drm/drm_connector.c | 91 +++++++--- drivers/gpu/drm/drm_context.c | 15 +- drivers/gpu/drm/drm_dp_mst_topology.c | 109 +++++++----- drivers/gpu/drm/drm_drv.c | 1 - drivers/gpu/drm/drm_internal.h | 2 + drivers/gpu/drm/drm_lease.c | 6 +- drivers/gpu/drm/drm_mode_config.c | 5 +- drivers/gpu/drm/drm_mode_object.c | 13 +- drivers/gpu/drm/drm_modeset_lock.c | 8 + drivers/gpu/drm/drm_syncobj.c | 91 ++++------ drivers/gpu/drm/etnaviv/etnaviv_gem.c | 2 +- drivers/gpu/drm/i915/i915_gem.c | 4 +- drivers/gpu/drm/i915/i915_gem_context.c | 8 +- drivers/gpu/drm/i915/i915_request.c | 12 +- drivers/gpu/drm/i915/i915_sw_fence.c | 2 +- drivers/gpu/drm/i915/intel_dp_mst.c | 10 -- drivers/gpu/drm/i915/intel_engine_cs.c | 2 +- drivers/gpu/drm/i915/intel_lrc.c | 6 +- drivers/gpu/drm/i915/selftests/intel_hangcheck.c | 14 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 2 +- drivers/gpu/drm/nouveau/dispnv50/disp.c | 8 - drivers/gpu/drm/qxl/qxl_display.c | 1 - drivers/gpu/drm/r128/r128_cce.c | 5 +- drivers/gpu/drm/radeon/radeon_dp_mst.c | 9 - drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 + drivers/gpu/drm/tegra/hub.c | 2 +- drivers/gpu/drm/v3d/v3d_drv.h | 1 - drivers/gpu/drm/v3d/v3d_gem.c | 62 ++----- drivers/gpu/drm/vc4/vc4_crtc.c | 43 +++++ drivers/gpu/drm/vc4/vc4_drv.h | 3 + drivers/gpu/drm/vc4/vc4_hdmi.c | 16 ++ drivers/gpu/drm/vc4/vc4_kms.c | 3 +- drivers/gpu/drm/vc4/vc4_plane.c | 128 ++++++++++++-- drivers/gpu/drm/vgem/vgem_fence.c | 4 +- drivers/gpu/drm/virtio/virtgpu_display.c | 1 - drivers/gpu/drm/virtio/virtgpu_drv.c | 9 +- drivers/gpu/drm/virtio/virtgpu_drv.h | 14 -- drivers/gpu/drm/virtio/virtgpu_fb.c | 191 --------------------- drivers/gpu/drm/virtio/virtgpu_kms.c | 8 - drivers/gpu/drm/vkms/vkms_drv.c | 1 + drivers/gpu/drm/xen/xen_drm_front_conn.c | 1 - include/drm/drmP.h | 2 - include/drm/drm_atomic.h | 37 +++- include/drm/drm_connector.h | 4 +- include/drm/drm_dp_mst_helper.h | 2 - include/drm/drm_file.h | 1 + include/drm/drm_hdcp.h | 2 + include/drm/drm_legacy.h | 14 +- include/drm/drm_mode_config.h | 23 ++- include/drm/drm_syncobj.h | 23 +-- include/drm/intel-gtt.h | 3 + include/linux/dma-fence.h | 22 ++- include/uapi/drm/v3d_drm.h | 8 + 68 files changed, 579 insertions(+), 580 deletions(-) -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [View Less]

1 0

"flip_done timed out" messages causing huge increase in boot time
by Daniel Kamil Kozar 07 Jan '19

07 Jan '19

Hello. After upgrading the kernel to 4.20, I noticed that the boot time increased from about 5 seconds to 25 seconds. My machine is an Asus K53SV with an Intel i7-2630QM, i.e. Sandy Bridge. I have an external display connected to it via HDMI. If the display is unplugged when booting the machine, the boot time stays at its old value. The kernel log shows two messages like this : [ 15.747206] [drm:drm_atomic_helper_wait_for_flip_done [drm_kms_helper]] *ERROR* [CRTC:39:pipe A] flip_done timed … [View More]

2 4

[PATCH] video: offb: Pass actual name in offb_init_palette_hacks
by Mathieu Malaterre 07 Jan '19

07 Jan '19

This is a partial revert of commit 5c63e407aaab ("fbdev: Convert to using %pOFn instead of device_node.name"). This is the minimal work to get a Mac Mini G4 back to a bootable state. The function offb_init_palette_hacks would need to handle the case where `name` has been set to NULL. Cc: Rob Herring <robh(a)kernel.org> Fixes: 5c63e407aaab ("fbdev: Convert to using %pOFn instead of device_node.name") Cc: stable(a)vger.kernel.org # v4.19+ Signed-off-by: Mathieu Malaterre <malat(a)debian.… [View More]

2 4

[PATCH 1/1] drm/prime: Use sg_dma_len() macro to get sg's length
by Vivek Gautam 07 Jan '19

07 Jan '19

After mapping a sg list we should use sg_dma_address(), and sg_dma_len() macros to access sg->address and sg->length. Fix the same for sg->length in drm_prime_sg_to_page_addr_arrays(). Signed-off-by: Vivek Gautam <vivek.gautam(a)codeaurora.org> --- This came while debugging one dmabuf import issue that we are seeing on sdm845 target. The dmabuf which is prepared by video (venus in this case), is imported by drm device. The import call flow looks like follows: … [View More]drm_gem_prime_import() - drm_gem_prime_import_dev() - dma_buf_attach() & dma_buf_map_attachment() - From dma_buf_map_attachment() - vb2_dma_sg_dmabuf_ops_map() - dma_map_sg(): this updates the sg->nents. >From debugging, the sg table mapping results in sg's 'nents' to be less that the original nents. Now drm device prepares the page information based on this sg table, and messes up with the mappings, and we start seeing random crashes as below from drm's memory space. Although this change isn't helping to fix the issue currently, but this fix seems the right thing to do. One thing to notice is that, if we restore the sg->nents to sg->orig_nents in vb2_dma_sg_dmabuf_ops_map(), we don't see the below corruptions. Any pointers on this will be highly appreciated. Thanks. ------ [ 338.070558] Unable to handle kernel paging request at virtual address 0000400000000038 [ 338.078751] Mem abort info: [ 338.081671] ESR = 0x96000004 [ 338.084860] Exception class = DABT (current EL), IL = 32 bits [ 338.090972] SET = 0, FnV = 0 [ 338.094139] EA = 0, S1PTW = 0 [ 338.097393] Data abort info: [ 338.100375] ISV = 0, ISS = 0x00000004 [ 338.104362] CM = 0, WnR = 0 [ 338.107446] [0000400000000038] address between user and kernel address ranges [ 338.114801] Internal error: Oops: 96000004 [#1] PREEMPT SMP [ 338.120527] Modules linked in: rfcomm uinput cdc_ether venus_dec venus_enc usbnet videobuf2_dma_sg videobuf2_memops hci_uart btqca bluetooth r8152 mii ath10k_snoc venus_core ath10k_core v4l2_mem2mem videobuf2_v4l2 videobuf2_common ath mac80211 ecdh_generic qcom_q6v5_mss lzo lzo_compress qcom_q6v5_adsp qcom_common qcom_q6v5 zram bridge stp llc ipt_MASQUERADE fuse snd_seq_dummy snd_seq snd_seq_device cfg80211 joydev [ 338.158192] CPU: 4 PID: 3235 Comm: chrome Tainted: G W 4.19.0 #2 [ 338.165700] Hardware name: Google Cheza (rev1) (DT) [ 338.170720] pstate: 80400009 (Nzcv daif +PAN -UAO) [ 338.175660] pc : drm_mm_insert_node_in_range+0xfc/0x348 [ 338.181035] lr : drm_mm_insert_node_in_range+0x24/0x348 [ 338.186407] sp : ffffff8013033b30 [ 338.189816] x29: ffffff8013033bd0 x28: ffffff8008591894 [ 338.195275] x27: 0000000000000010 x26: 0000000000000000 [ 338.200734] x25: 0000000000000000 x24: ffffffffffffffff [ 338.206194] x23: 0000000000000000 x22: ffffffc0f48b7e08 [ 338.211656] x21: 0000000000000000 x20: 000000000000005d [ 338.217118] x19: 0000000000000000 x18: 0000000000000000 [ 338.222581] x17: 0000000000000000 x16: 0000000000000000 [ 338.228046] x15: 0000000000000000 x14: 0000000000000000 [ 338.233511] x13: 0000000000000001 x12: ffffffc0b1da7200 [ 338.238978] x11: 0000000000000010 x10: 0000000000000010 [ 338.244437] x9 : 0000000000000008 x8 : 0000400000000000 [ 338.249898] x7 : 0000000000000000 x6 : ffffffffffffffff [ 338.255361] x5 : 0000000000000000 x4 : 0000000000000000 [ 338.260823] x3 : 0000000000000000 x2 : 000000000000005d [ 338.266285] x1 : ffffffc0b1da7100 x0 : ffffffc0b0215800 [ 338.271748] Process chrome (pid: 3235, stack limit = 0x000000000900f416) [ 338.278628] Call trace: [ 338.281151] drm_mm_insert_node_in_range+0xfc/0x348 [ 338.286168] msm_gem_map_vma+0x60/0xdc [ 338.290022] msm_gem_get_iova+0xb4/0xf4 [ 338.293967] msm_ioctl_gem_info+0x90/0xdc [ 338.298089] drm_ioctl_kernel+0xa8/0xe8 [ 338.302043] drm_ioctl+0x218/0x384 [ 338.305547] drm_compat_ioctl+0xd8/0xe8 [ 338.309503] __arm64_compat_sys_ioctl+0x134/0x20c [ 338.314339] el0_svc_common+0xa0/0xf0 [ 338.318108] el0_svc_compat_handler+0x2c/0x38 [ 338.322588] el0_svc_compat+0x8/0x18 [ 338.326274] Code: f94066c8 aa1f03e0 321d03e9 321c03ea (f9401d0b) [ 338.332538] ---[ end trace 5c09e60869887d87 ]--- [ 338.354633] Kernel panic - not syncing: Fatal exception [ 338.360018] SMP: stopping secondary CPUs [ 338.364179] Kernel Offset: disabled [ 338.367779] CPU features: 0x0,22802a18 [ 338.371643] Memory Limit: none ------ drivers/gpu/drm/drm_prime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c index 231e3f6d5f41..0d9b1c43523a 100644 --- a/drivers/gpu/drm/drm_prime.c +++ b/drivers/gpu/drm/drm_prime.c @@ -945,7 +945,7 @@ int drm_prime_sg_to_page_addr_arrays(struct sg_table *sgt, struct page **pages, index = 0; for_each_sg(sgt->sgl, sg, sgt->nents, count) { - len = sg->length; + len = sg_dma_length(sg); page = sg_page(sg); addr = sg_dma_address(sg); -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation [View Less]

3 5

[PATCH v2 13/14] drm/tinydrm: do not reply on drmP.h from drm_gem_cma_helper.h
by Sam Ravnborg 07 Jan '19

07 Jan '19

drmP.h was the only header file in the past and a lot of files rely on that drmP.h defines everything. The goal is to one day to delete drmP.h and as a step towards this it will no longer be included in the headers files in include/drm/ To prepare tinydrm/ for this add dependencies that othwewise was pulled in by drmP.h from drm_gem_cma_helper.h To avoid that tinydrm.h became "include everything", push include files to the individual drivers. Signed-off-by: Sam Ravnborg <sam(a)ravnborg.… [View More]org> Cc: "Noralf Trønnes" <noralf(a)tronnes.org> Cc: David Airlie <airlied(a)linux.ie> Cc: Eric Anholt <eric(a)anholt.net> Cc: David Lechner <david(a)lechnology.com> Cc: Daniel Vetter <daniel.vetter(a)ffwll.ch> --- drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 3 +++ drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 3 +++ drivers/gpu/drm/tinydrm/hx8357d.c | 1 + drivers/gpu/drm/tinydrm/ili9225.c | 2 ++ drivers/gpu/drm/tinydrm/ili9341.c | 1 + drivers/gpu/drm/tinydrm/mi0283qt.c | 1 + drivers/gpu/drm/tinydrm/mipi-dbi.c | 3 +++ drivers/gpu/drm/tinydrm/repaper.c | 1 + drivers/gpu/drm/tinydrm/st7586.c | 1 + drivers/gpu/drm/tinydrm/st7735r.c | 1 + 10 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm/tinydrm/core/tinydrm-core.c b/drivers/gpu/drm/tinydrm/core/tinydrm-core.c index 01a6f2d42440..aeb93eadb047 100644 --- a/drivers/gpu/drm/tinydrm/core/tinydrm-core.c +++ b/drivers/gpu/drm/tinydrm/core/tinydrm-core.c @@ -10,11 +10,14 @@ #include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_crtc_helper.h> +#include <drm/drm_drv.h> #include <drm/drm_fb_helper.h> #include <drm/drm_gem_framebuffer_helper.h> +#include <drm/drm_print.h> #include <drm/tinydrm/tinydrm.h> #include <linux/device.h> #include <linux/dma-buf.h> +#include <linux/module.h> /** * DOC: overview diff --git a/drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c b/drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c index eacfc0ec8ff1..d4576d6e8ce4 100644 --- a/drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c +++ b/drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c @@ -9,8 +9,11 @@ #include <drm/drm_atomic_helper.h> #include <drm/drm_crtc_helper.h> +#include <drm/drm_drv.h> #include <drm/drm_gem_framebuffer_helper.h> #include <drm/drm_modes.h> +#include <drm/drm_print.h> +#include <drm/drm_vblank.h> #include <drm/tinydrm/tinydrm.h> struct tinydrm_connector { diff --git a/drivers/gpu/drm/tinydrm/hx8357d.c b/drivers/gpu/drm/tinydrm/hx8357d.c index 81a2bbeb25d4..3ae11aa4b73b 100644 --- a/drivers/gpu/drm/tinydrm/hx8357d.c +++ b/drivers/gpu/drm/tinydrm/hx8357d.c @@ -16,6 +16,7 @@ #include <linux/property.h> #include <linux/spi/spi.h> +#include <drm/drm_drv.h> #include <drm/drm_gem_cma_helper.h> #include <drm/drm_gem_framebuffer_helper.h> #include <drm/drm_modeset_helper.h> diff --git a/drivers/gpu/drm/tinydrm/ili9225.c b/drivers/gpu/drm/tinydrm/ili9225.c index 78f7c2d1b449..b0ad58b97227 100644 --- a/drivers/gpu/drm/tinydrm/ili9225.c +++ b/drivers/gpu/drm/tinydrm/ili9225.c @@ -20,7 +20,9 @@ #include <linux/spi/spi.h> #include <video/mipi_display.h> +#include <drm/drm_drv.h> #include <drm/drm_fb_cma_helper.h> +#include <drm/drm_fourcc.h> #include <drm/drm_gem_cma_helper.h> #include <drm/drm_gem_framebuffer_helper.h> #include <drm/tinydrm/mipi-dbi.h> diff --git a/drivers/gpu/drm/tinydrm/ili9341.c b/drivers/gpu/drm/tinydrm/ili9341.c index 51395bdc6ca2..bcdf10906ade 100644 --- a/drivers/gpu/drm/tinydrm/ili9341.c +++ b/drivers/gpu/drm/tinydrm/ili9341.c @@ -15,6 +15,7 @@ #include <linux/property.h> #include <linux/spi/spi.h> +#include <drm/drm_drv.h> #include <drm/drm_gem_cma_helper.h> #include <drm/drm_gem_framebuffer_helper.h> #include <drm/drm_modeset_helper.h> diff --git a/drivers/gpu/drm/tinydrm/mi0283qt.c b/drivers/gpu/drm/tinydrm/mi0283qt.c index 3fa62e77c30b..97805ca37a04 100644 --- a/drivers/gpu/drm/tinydrm/mi0283qt.c +++ b/drivers/gpu/drm/tinydrm/mi0283qt.c @@ -17,6 +17,7 @@ #include <linux/regulator/consumer.h> #include <linux/spi/spi.h> +#include <drm/drm_drv.h> #include <drm/drm_gem_cma_helper.h> #include <drm/drm_gem_framebuffer_helper.h> #include <drm/drm_modeset_helper.h> diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c index 3a05e56f9b0d..10294e1283dd 100644 --- a/drivers/gpu/drm/tinydrm/mipi-dbi.c +++ b/drivers/gpu/drm/tinydrm/mipi-dbi.c @@ -10,14 +10,17 @@ */ #include <linux/debugfs.h> +#include <linux/delay.h> #include <linux/dma-buf.h> #include <linux/gpio/consumer.h> #include <linux/module.h> #include <linux/regulator/consumer.h> #include <linux/spi/spi.h> +#include <drm/drm_drv.h> #include <drm/drm_fb_cma_helper.h> #include <drm/drm_gem_cma_helper.h> +#include <drm/drm_fourcc.h> #include <drm/drm_gem_framebuffer_helper.h> #include <drm/tinydrm/mipi-dbi.h> #include <drm/tinydrm/tinydrm-helpers.h> diff --git a/drivers/gpu/drm/tinydrm/repaper.c b/drivers/gpu/drm/tinydrm/repaper.c index 54d6fe0f37ce..b2a8f894946a 100644 --- a/drivers/gpu/drm/tinydrm/repaper.c +++ b/drivers/gpu/drm/tinydrm/repaper.c @@ -26,6 +26,7 @@ #include <linux/spi/spi.h> #include <linux/thermal.h> +#include <drm/drm_drv.h> #include <drm/drm_fb_cma_helper.h> #include <drm/drm_gem_cma_helper.h> #include <drm/drm_gem_framebuffer_helper.h> diff --git a/drivers/gpu/drm/tinydrm/st7586.c b/drivers/gpu/drm/tinydrm/st7586.c index a6a8a1081b73..bf518167760a 100644 --- a/drivers/gpu/drm/tinydrm/st7586.c +++ b/drivers/gpu/drm/tinydrm/st7586.c @@ -17,6 +17,7 @@ #include <linux/spi/spi.h> #include <video/mipi_display.h> +#include <drm/drm_drv.h> #include <drm/drm_fb_cma_helper.h> #include <drm/drm_gem_cma_helper.h> #include <drm/drm_gem_framebuffer_helper.h> diff --git a/drivers/gpu/drm/tinydrm/st7735r.c b/drivers/gpu/drm/tinydrm/st7735r.c index b39779e0dcd8..9bc93d5a0401 100644 --- a/drivers/gpu/drm/tinydrm/st7735r.c +++ b/drivers/gpu/drm/tinydrm/st7735r.c @@ -14,6 +14,7 @@ #include <linux/spi/spi.h> #include <video/mipi_display.h> +#include <drm/drm_drv.h> #include <drm/drm_gem_cma_helper.h> #include <drm/drm_gem_framebuffer_helper.h> #include <drm/tinydrm/mipi-dbi.h> -- 2.12.0 [View Less]

3 2

[PATCH v2 14/14] drm: remove drmP.h from drm_gem_cma_helper.h
by Sam Ravnborg 07 Jan '19

07 Jan '19

With all dependencies fixed we can now remove drmP.h from drm_gem_cma_helper.h. It is replaced by the include files required, or forward declarations as appropritate. Signed-off-by: Sam Ravnborg <sam(a)ravnborg.org> Cc: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> Cc: Maxime Ripard <maxime.ripard(a)bootlin.com> Cc: Sean Paul <sean(a)poorly.run> Cc: David Airlie <airlied(a)linux.ie> Cc: Daniel Vetter <daniel(a)ffwll.ch> --- include/drm/… [View More]

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2019