dri-devel January 2019

dri-devel@lists.freedesktop.org

279 participants
2022 discussions

[PATCH v2 11/14] drm/arc: do not reply on drmP.h from drm_gem_cma_helper.h
by Sam Ravnborg 07 Jan '19

07 Jan '19

drmP.h was the only header file in the past and a lot of files rely on that drmP.h defines everything. The goal is to one day to delete drmP.h and as a step towards this it will no longer be included in the headers files in include/drm/ To prepare arc/ for this add dependencies that othwewise was pulled in by drmP.h from drm_gem_cma_helper.h Signed-off-by: Sam Ravnborg <sam(a)ravnborg.org> Cc: Alexey Brodkin <abrodkin(a)synopsys.com> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: David Airlie <airlied(a)linux.ie> --- drivers/gpu/drm/arc/arcpgu_crtc.c | 2 ++ drivers/gpu/drm/arc/arcpgu_drv.c | 6 ++++++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/arc/arcpgu_crtc.c b/drivers/gpu/drm/arc/arcpgu_crtc.c index 62f51f70606d..155ab177ce0b 100644 --- a/drivers/gpu/drm/arc/arcpgu_crtc.c +++ b/drivers/gpu/drm/arc/arcpgu_crtc.c @@ -16,8 +16,10 @@ #include <drm/drm_atomic_helper.h> #include <drm/drm_crtc_helper.h> +#include <drm/drm_device.h> #include <drm/drm_fb_cma_helper.h> #include <drm/drm_gem_cma_helper.h> +#include <drm/drm_vblank.h> #include <drm/drm_plane_helper.h> #include <linux/clk.h> #include <linux/platform_data/simplefb.h> diff --git a/drivers/gpu/drm/arc/arcpgu_drv.c b/drivers/gpu/drm/arc/arcpgu_drv.c index 206a76abf771..39a79f5718c4 100644 --- a/drivers/gpu/drm/arc/arcpgu_drv.c +++ b/drivers/gpu/drm/arc/arcpgu_drv.c @@ -16,12 +16,18 @@ #include <linux/clk.h> #include <drm/drm_crtc_helper.h> +#include <drm/drm_device.h> +#include <drm/drm_debugfs.h> +#include <drm/drm_drv.h> #include <drm/drm_fb_cma_helper.h> #include <drm/drm_fb_helper.h> #include <drm/drm_gem_cma_helper.h> #include <drm/drm_gem_framebuffer_helper.h> #include <drm/drm_atomic_helper.h> +#include <linux/dma-mapping.h> +#include <linux/module.h> #include <linux/of_reserved_mem.h> +#include <linux/platform_device.h> #include "arcpgu.h" #include "arcpgu_regs.h" -- 2.12.0

2 1

[PATCH v2 09/14] drm: remove include of drmP.h from drm_encoder_slave.h
by Sam Ravnborg 07 Jan '19

07 Jan '19

No further changes required. Signed-off-by: Sam Ravnborg <sam(a)ravnborg.org> Cc: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> Cc: Maxime Ripard <maxime.ripard(a)bootlin.com> Cc: Sean Paul <sean(a)poorly.run> Cc: David Airlie <airlied(a)linux.ie> Cc: Daniel Vetter <daniel(a)ffwll.ch> --- include/drm/drm_encoder_slave.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/drm/drm_encoder_slave.h b/include/drm/drm_encoder_slave.h index 1107b4b1c599..a09864f6d684 100644 --- a/include/drm/drm_encoder_slave.h +++ b/include/drm/drm_encoder_slave.h @@ -27,7 +27,6 @@ #ifndef __DRM_ENCODER_SLAVE_H__ #define __DRM_ENCODER_SLAVE_H__ -#include <drm/drmP.h> #include <drm/drm_crtc.h> #include <drm/drm_encoder.h> -- 2.12.0

2 1

[PATCH v2 05/14] drm: make drm_file.h self contained
by Sam Ravnborg 07 Jan '19

07 Jan '19

drm_file.h embed struct idr, so this file need to know the full type definition. With this change users of drm_file.h are no longer forced to include idr.h - a file they usually get from drmP.h This makes it simpler to remove drmP.h includes Signed-off-by: Sam Ravnborg <sam(a)ravnborg.org> Cc: Jani Nikula <jani.nikula(a)intel.com> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> Cc: Maxime Ripard <maxime.ripard(a)bootlin.com> Cc: Sean Paul <sean(a)poorly.run> Cc: David Airlie <airlied(a)linux.ie> --- include/drm/drm_file.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h index 84ac79219e4c..bbdb74c3d7ff 100644 --- a/include/drm/drm_file.h +++ b/include/drm/drm_file.h @@ -30,6 +30,7 @@ #ifndef _DRM_FILE_H_ #define _DRM_FILE_H_ +#include <linux/idr.h> #include <linux/types.h> #include <linux/completion.h> -- 2.12.0

2 1

[PATCH v2 04/14] drm: make drm_framebuffer.h self contained
by Sam Ravnborg 07 Jan '19

07 Jan '19

Add forward declaration and pull in include file to make drm_framebuffer.h self contained. While add it order include files alphabetically. The use of TASK_COMM_LEN is the reason for including sched.h. I could not see any good way to avoid this dependency, and users of drm_framebuffer.comm already use TASK_COMM_LEN to check for length etc. Signed-off-by: Sam Ravnborg <sam(a)ravnborg.org> Cc: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> Cc: Maxime Ripard <maxime.ripard(a)bootlin.com> Cc: Sean Paul <sean(a)poorly.run> Cc: David Airlie <airlied(a)linux.ie> Cc: Daniel Vetter <daniel(a)ffwll.ch> --- include/drm/drm_framebuffer.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/drm/drm_framebuffer.h b/include/drm/drm_framebuffer.h index c94acedfb08e..f639ed527943 100644 --- a/include/drm/drm_framebuffer.h +++ b/include/drm/drm_framebuffer.h @@ -23,13 +23,16 @@ #ifndef __DRM_FRAMEBUFFER_H__ #define __DRM_FRAMEBUFFER_H__ -#include <linux/list.h> #include <linux/ctype.h> +#include <linux/list.h> +#include <linux/sched.h> + #include <drm/drm_mode_object.h> struct drm_framebuffer; struct drm_file; struct drm_device; +struct drm_clip_rect; /** * struct drm_framebuffer_funcs - framebuffer hooks -- 2.12.0

2 1

[Bug 199139] New: System freezes (kernel, amdgpu NULL pointer dereference) when video enters powersafe state
by bugzilla-daemon＠bugzilla.kernel.org 07 Jan '19

07 Jan '19

https://bugzilla.kernel.org/show_bug.cgi?id=199139 Bug ID: 199139 Summary: System freezes (kernel, amdgpu NULL pointer dereference) when video enters powersafe state Product: Drivers Version: 2.5 Kernel Version: 4.15.10 Hardware: x86-64 OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: wirch.eduard(a)gmail.com Regression: No Created attachment 274807 --> https://bugzilla.kernel.org/attachment.cgi?id=274807&action=edit kernel-4.15.config [1.] Summary: System freezes (kernel, amdgpu NULL pointer dereference) when video enters powersafe state [2.] Detailed: When using lightdm/xfwm: locking the screen makes lightdm to switch video to power safe mode. The system does not recover from this state any more. [3.] Keywords: amdgpu 4.15 power management [4.] Kernel information [4.1.] Kernel version (from /proc/version): Linux version 4.15.10-1-MANJARO (builduser@development) (gcc version 7.3.0 (GCC)) #1 SMP PREEMPT Thu Mar 15 19:50:50 UTC 2018 [4.2.] kernel-4.15.config file attached [5.] Most recent kernel version which did not have the bug: 4.14.27-1-MANJARO [6.] Kernel output: kernel: BUG: unable to handle kernel NULL pointer dereference at 0000000000000000 kernel: IP: dce110_vblank_set+0x4f/0xb0 [amdgpu] kernel: PGD e70545067 P4D e70545067 PUD fd2b24067 PMD 0 kernel: Oops: 0000 [#1] PREEMPT SMP NOPTI kernel: Modules linked in: cmac rfcomm fuse ipt_MASQUERADE nf_nat_masquerade_ipv4 nf_conntrack_netlink nfnetlink xfrm_user xfrm_algo iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 xt_addrtype iptable_filter xt_conntrack nf_nat nf_conntrack libcrc32c crc32c_generic br_netfilter bridge stp llc overlay bnep amdkfd amd_iommu_v2 arc4 amdgpu iwlmvm nls_> kernel: snd agpgart syscopyarea sysfillrect sysimgblt soundcore fb_sys_fops aesni_intel sp5100_tco aes_x86_64 crypto_simd glue_helper cryptd pcspkr i2c_piix4 k10temp shpchp rtc_cmos evdev wmi mac_hid gpio_amdpt pinctrl_amd acpi_cpufreq crypto_user ip_tables x_tables ext4 crc16 mbcache jbd2 fscrypto sr_mod cdrom hid_generic usbhid hid ahci xhci_pci crc32c_i> kernel: CPU: 10 PID: 1113 Comm: xfwm4 Not tainted 4.15.10-1-MANJARO #1 kernel: Hardware name: To Be Filled By O.E.M. To Be Filled By O.E.M./X370 Taichi, BIOS P3.30 01/15/2018 kernel: RIP: 0010:dce110_vblank_set+0x4f/0xb0 [amdgpu] kernel: RSP: 0018:ffffb37007f87bc0 EFLAGS: 00010002 kernel: RAX: ffffa22c4ffbc000 RBX: 0000000000000001 RCX: 0000000000000000 kernel: RDX: 0000000000000000 RSI: 000000000000000c RDI: 0000000000000000 kernel: RBP: ffffa22dd38e37c0 R08: 0000000000000000 R09: 0000000000000000 kernel: R10: 0000000000000000 R11: 0000000000000000 R12: ffffa22c92d2aa00 kernel: R13: ffffffffc0ebcc40 R14: ffffa22c86c68000 R15: ffffb37007f87d90 kernel: FS: 00007f9f5aa9d980(0000) GS:ffffa22e1ee80000(0000) knlGS:0000000000000000 kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 kernel: CR2: 0000000000000000 CR3: 0000000e7ab7e000 CR4: 00000000003406e0 kernel: Call Trace: kernel: amdgpu_dm_set_crtc_irq_state+0x31/0x60 [amdgpu] kernel: amdgpu_irq_update+0x55/0x90 [amdgpu] kernel: drm_vblank_enable+0x84/0x100 [drm] kernel: drm_vblank_get+0x8d/0xb0 [drm] kernel: drm_wait_vblank_ioctl+0x12a/0x660 [drm] kernel: ? unix_stream_recvmsg+0x53/0x70 kernel: ? drm_legacy_modeset_ctl_ioctl+0x100/0x100 [drm] kernel: drm_ioctl_kernel+0x5b/0xb0 [drm] kernel: drm_ioctl+0x2d5/0x370 [drm] kernel: ? drm_legacy_modeset_ctl_ioctl+0x100/0x100 [drm] kernel: ? do_iter_write+0xdc/0x190 kernel: ? vfs_writev+0xb9/0x110 kernel: amdgpu_drm_ioctl+0x49/0x80 [amdgpu] kernel: do_vfs_ioctl+0xa4/0x630 kernel: ? __sys_recvmsg+0x4e/0x90 kernel: ? __sys_recvmsg+0x7d/0x90 kernel: SyS_ioctl+0x74/0x80 kernel: do_syscall_64+0x74/0x190 kernel: entry_SYSCALL_64_after_hwframe+0x3d/0xa2 kernel: RIP: 0033:0x7f9f570f2d87 kernel: RSP: 002b:00007fff29a4ed78 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 kernel: RAX: ffffffffffffffda RBX: 00007fff29a4eda0 RCX: 00007f9f570f2d87 kernel: RDX: 00007fff29a4eda0 RSI: 00000000c018643a RDI: 000000000000000c kernel: RBP: 00000000010a9590 R08: 0000000000800105 R09: 0000000000000000 kernel: R10: 0000000000000000 R11: 0000000000000246 R12: 00000000c018643a kernel: R13: 0000000000801290 R14: 0000000001194810 R15: 0000000000000000 kernel: Code: e8 a7 1f 04 00 83 e8 4e 0f b6 d0 48 89 d0 48 c1 e0 05 48 01 d0 48 c1 e0 05 49 03 86 60 01 00 00 84 db 48 8b b8 78 02 00 00 74 18 <48> 8b 07 be 02 00 00 00 48 8b 80 d8 00 00 00 e8 5d 34 be fd 84 kernel: RIP: dce110_vblank_set+0x4f/0xb0 [amdgpu] RSP: ffffb37007f87bc0 kernel: CR2: 0000000000000000 kernel: ---[ end trace 53fc1155564badc6 ]--- kernel: note: xfwm4[1113] exited with preempt_count 3 blueman-mechanism[1683]: Exiting kernel: [drm] {3840x2160, 4000x2222@533250Khz} [8.] Environment [8.1.] Software. Output of the ver_linux script: Linux anton 4.15.10-1-MANJARO #1 SMP PREEMPT Thu Mar 15 19:50:50 UTC 2018 x86_64 GNU/Linux GNU C 7.3.0 GNU Make 4.2.1 Binutils 2.29.1 Util-linux 2.31.1 Mount 2.31.1 Module-init-tools 24 E2fsprogs 1.44.0 Jfsutils 1.1.15 Reiserfsprogs 3.6.27 Xfsprogs 4.15.1 Pcmciautils 018 PPP 2.4.7 Nfs-utils 3.1.1 Linux C Library 2.26 Dynamic linker (ldd) 2.26 Linux C++ Library 6.0.24 Procps 3.3.12 Net-tools 2.10 Kbd 2.0.4 Console-tools 2.0.4 Sh-utils 8.29 Udev 238 Wireless-tools 30 Modules Loaded acpi_cpufreq aesni_intel aes_x86_64 agpgart ahci amdgpu amd_iommu_v2 amdkfd arc4 bluetooth bnep bridge br_netfilter btbcm btintel btrtl btusb ccp cdrom cfg80211 chash cmac crc16 crc32c_generic crc32c_intel crc32_pclmul crct10dif_pclmul cryptd crypto_simd crypto_user dca drm drm_kms_helper ecdh_generic edac_mce_amd evdev ext4 fat fb_sys_fops fscrypto fuse ghash_clmulni_intel glue_helper gpio_amdpt hid hid_generic i2c_algo_bit i2c_piix4 igb input_leds iptable_filter iptable_nat ip_tables ipt_MASQUERADE irqbypass iwlmvm iwlwifi jbd2 k10temp kvm led_class libahci libata libcrc32c llc mac80211 mac_hid mbcache mousedev mxm_wmi nf_conntrack nf_conntrack_ipv4 nf_conntrack_netlink nf_defrag_ipv4 nf_nat nf_nat_ipv4 nf_nat_masquerade_ipv4 nfnetlink nls_cp437 nls_iso8859_1 overlay pcbc pcspkr pinctrl_amd pps_core ptp rfcomm rfkill rng_core rtc_cmos scsi_mod shpchp snd snd_hda_codec snd_hda_codec_generic snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_core snd_hda_intel snd_hwdep snd_pcm snd_timer soundcore sp5100_tco sr_mod stp syscopyarea sysfillrect sysimgblt ttm usb_common usbcore usbhid vfat wmi wmi_bmof xfrm_algo xfrm_user xhci_hcd xhci_pci x_tables xt_addrtype xt_conntrack [8.2.] Processor information vendor_id : AuthenticAMD cpu family : 23 model : 1 model name : AMD Ryzen 7 1800X Eight-Core Processor stepping : 1 microcode : 0x8001129 cpu MHz : 1844.566 cache size : 512 KB physical id : 0 siblings : 16 core id : 7 cpu cores : 8 apicid : 15 initial apicid : 15 fpu : yes fpu_exception : yes cpuid level : 13 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc cpuid extd_apicid aperfmperf pni pclmulqdq monitor ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw skinit wdt tce topoext perfctr_core perfctr_nb bpext perfctr_llc mwaitx cpb hw_pstate sme vmmcall fsgsbase bmi1 avx2 smep bmi2 rdseed adx smap clflushopt sha_ni xsaveopt xsavec xgetbv1 xsaves clzero irperf xsaveerptr arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif overflow_recov succor smca bugs : sysret_ss_attrs null_seg spectre_v1 spectre_v2 bogomips : 7202.78 TLB size : 2560 4K pages clflush size : 64 cache_alignment : 64 address sizes : 43 bits physical, 48 bits virtual power management: ts ttp tm hwpstate eff_freq_ro [13] [14] [8.3.] Module information (from /proc/modules): cmac 16384 1 - Live 0x0000000000000000 rfcomm 86016 16 - Live 0x0000000000000000 fuse 118784 5 - Live 0x0000000000000000 ipt_MASQUERADE 16384 1 - Live 0x0000000000000000 nf_nat_masquerade_ipv4 16384 1 ipt_MASQUERADE, Live 0x0000000000000000 nf_conntrack_netlink 49152 0 - Live 0x0000000000000000 nfnetlink 16384 2 nf_conntrack_netlink, Live 0x0000000000000000 xfrm_user 45056 1 - Live 0x0000000000000000 xfrm_algo 16384 1 xfrm_user, Live 0x0000000000000000 iptable_nat 16384 1 - Live 0x0000000000000000 nf_conntrack_ipv4 16384 3 - Live 0x0000000000000000 nf_defrag_ipv4 16384 1 nf_conntrack_ipv4, Live 0x0000000000000000 nf_nat_ipv4 16384 1 iptable_nat, Live 0x0000000000000000 xt_addrtype 16384 2 - Live 0x0000000000000000 iptable_filter 16384 1 - Live 0x0000000000000000 xt_conntrack 16384 1 - Live 0x0000000000000000 nf_nat 36864 2 nf_nat_masquerade_ipv4,nf_nat_ipv4, Live 0x0000000000000000 nf_conntrack 155648 7 ipt_MASQUERADE,nf_nat_masquerade_ipv4,nf_conntrack_netlink,nf_conntrack_ipv4,nf_nat_ipv4,xt_conntrack,nf_nat, Live 0x0000000000000000 libcrc32c 16384 2 nf_nat,nf_conntrack, Live 0x0000000000000000 crc32c_generic 16384 0 - Live 0x0000000000000000 br_netfilter 24576 0 - Live 0x0000000000000000 bridge 188416 1 br_netfilter, Live 0x0000000000000000 stp 16384 1 bridge, Live 0x0000000000000000 llc 16384 2 bridge,stp, Live 0x0000000000000000 overlay 86016 0 - Live 0x0000000000000000 bnep 24576 2 - Live 0x0000000000000000 arc4 16384 2 - Live 0x0000000000000000 amdkfd 151552 1 - Live 0x0000000000000000 amd_iommu_v2 20480 1 amdkfd, Live 0x0000000000000000 amdgpu 3104768 7 - Live 0x0000000000000000 nls_iso8859_1 16384 1 - Live 0x0000000000000000 nls_cp437 20480 1 - Live 0x0000000000000000 vfat 20480 1 - Live 0x0000000000000000 iwlmvm 425984 0 - Live 0x0000000000000000 fat 77824 1 vfat, Live 0x0000000000000000 snd_hda_codec_realtek 110592 1 - Live 0x0000000000000000 mac80211 909312 1 iwlmvm, Live 0x0000000000000000 snd_hda_codec_generic 86016 1 snd_hda_codec_realtek, Live 0x0000000000000000 edac_mce_amd 28672 0 - Live 0x0000000000000000 chash 16384 1 amdgpu, Live 0x0000000000000000 snd_hda_codec_hdmi 57344 1 - Live 0x0000000000000000 btusb 53248 0 - Live 0x0000000000000000 input_leds 16384 0 - Live 0x0000000000000000 ttm 118784 1 amdgpu, Live 0x0000000000000000 iwlwifi 315392 1 iwlmvm, Live 0x0000000000000000 btrtl 16384 1 btusb, Live 0x0000000000000000 snd_hda_intel 45056 5 - Live 0x0000000000000000 btbcm 16384 1 btusb, Live 0x0000000000000000 btintel 16384 1 btusb, Live 0x0000000000000000 kvm 704512 0 - Live 0x0000000000000000 mousedev 24576 0 - Live 0x0000000000000000 led_class 16384 2 iwlmvm,input_leds, Live 0x0000000000000000 drm_kms_helper 200704 1 amdgpu, Live 0x0000000000000000 bluetooth 634880 41 rfcomm,bnep,btusb,btrtl,btbcm,btintel, Live 0x0000000000000000 snd_hda_codec 151552 4 snd_hda_codec_realtek,snd_hda_codec_generic,snd_hda_codec_hdmi,snd_hda_intel, Live 0x0000000000000000 irqbypass 16384 1 kvm, Live 0x0000000000000000 crct10dif_pclmul 16384 0 - Live 0x0000000000000000 crc32_pclmul 16384 0 - Live 0x0000000000000000 ecdh_generic 24576 2 bluetooth, Live 0x0000000000000000 cfg80211 741376 3 iwlmvm,mac80211,iwlwifi, Live 0x0000000000000000 drm 466944 7 amdgpu,ttm,drm_kms_helper, Live 0x0000000000000000 igb 245760 0 - Live 0x0000000000000000 snd_hda_core 94208 5 snd_hda_codec_realtek,snd_hda_codec_generic,snd_hda_codec_hdmi,snd_hda_intel,snd_hda_codec, Live 0x0000000000000000 mxm_wmi 16384 0 - Live 0x0000000000000000 wmi_bmof 16384 0 - Live 0x0000000000000000 snd_hwdep 20480 1 snd_hda_codec, Live 0x0000000000000000 ghash_clmulni_intel 16384 0 - Live 0x0000000000000000 ptp 20480 1 igb, Live 0x0000000000000000 snd_pcm 135168 4 snd_hda_codec_hdmi,snd_hda_intel,snd_hda_codec,snd_hda_core, Live 0x0000000000000000 pcbc 16384 0 - Live 0x0000000000000000 pps_core 20480 1 ptp, Live 0x0000000000000000 i2c_algo_bit 16384 2 amdgpu,igb, Live 0x0000000000000000 agpgart 49152 2 ttm,drm, Live 0x0000000000000000 dca 16384 1 igb, Live 0x0000000000000000 syscopyarea 16384 1 drm_kms_helper, Live 0x0000000000000000 snd_timer 36864 1 snd_pcm, Live 0x0000000000000000 rfkill 28672 5 bluetooth,cfg80211, Live 0x0000000000000000 sysfillrect 16384 1 drm_kms_helper, Live 0x0000000000000000 ccp 81920 0 - Live 0x0000000000000000 sysimgblt 16384 1 drm_kms_helper, Live 0x0000000000000000 aesni_intel 188416 2 - Live 0x0000000000000000 snd 98304 18 snd_hda_codec_realtek,snd_hda_codec_generic,snd_hda_codec_hdmi,snd_hda_intel,snd_hda_codec,snd_hwdep,snd_pcm,snd_timer, Live 0x0000000000000000 aes_x86_64 20480 1 aesni_intel, Live 0x0000000000000000 fb_sys_fops 16384 1 drm_kms_helper, Live 0x0000000000000000 rng_core 16384 1 ccp, Live 0x0000000000000000 soundcore 16384 1 snd, Live 0x0000000000000000 crypto_simd 16384 1 aesni_intel, Live 0x0000000000000000 glue_helper 16384 1 aesni_intel, Live 0x0000000000000000 cryptd 28672 3 ghash_clmulni_intel,aesni_intel,crypto_simd, Live 0x0000000000000000 shpchp 40960 0 - Live 0x0000000000000000 sp5100_tco 16384 0 - Live 0x0000000000000000 i2c_piix4 24576 0 - Live 0x0000000000000000 k10temp 16384 0 - Live 0x0000000000000000 pcspkr 16384 0 - Live 0x0000000000000000 rtc_cmos 24576 1 - Live 0x0000000000000000 evdev 20480 9 - Live 0x0000000000000000 wmi 28672 2 mxm_wmi,wmi_bmof, Live 0x0000000000000000 mac_hid 16384 0 - Live 0x0000000000000000 pinctrl_amd 28672 0 - Live 0x0000000000000000 gpio_amdpt 16384 0 - Live 0x0000000000000000 acpi_cpufreq 24576 0 - Live 0x0000000000000000 crypto_user 16384 0 - Live 0x0000000000000000 ip_tables 28672 2 iptable_nat,iptable_filter, Live 0x0000000000000000 x_tables 45056 5 ipt_MASQUERADE,xt_addrtype,iptable_filter,xt_conntrack,ip_tables, Live 0x0000000000000000 ext4 712704 1 - Live 0x0000000000000000 crc16 16384 2 bluetooth,ext4, Live 0x0000000000000000 mbcache 16384 1 ext4, Live 0x0000000000000000 jbd2 122880 1 ext4, Live 0x0000000000000000 fscrypto 32768 1 ext4, Live 0x0000000000000000 sr_mod 28672 0 - Live 0x0000000000000000 cdrom 69632 1 sr_mod, Live 0x0000000000000000 hid_generic 16384 0 - Live 0x0000000000000000 usbhid 57344 0 - Live 0x0000000000000000 hid 131072 2 hid_generic,usbhid, Live 0x0000000000000000 ahci 40960 0 - Live 0x0000000000000000 xhci_pci 16384 0 - Live 0x0000000000000000 crc32c_intel 24576 1 - Live 0x0000000000000000 libahci 40960 1 ahci, Live 0x0000000000000000 xhci_hcd 258048 1 xhci_pci, Live 0x0000000000000000 libata 278528 2 ahci,libahci, Live 0x0000000000000000 usbcore 286720 4 btusb,usbhid,xhci_pci,xhci_hcd, Live 0x0000000000000000 scsi_mod 258048 2 sr_mod,libata, Live 0x0000000000000000 usb_common 16384 1 usbcore, Live 0x0000000000000000 [8.4.] Loaded driver and hardware information (/proc/ioports, /proc/iomem) /proc/ioports: 0000-0000 : PCI Bus 0000:00 0000-0000 : dma1 0000-0000 : pic1 0000-0000 : timer0 0000-0000 : timer1 0000-0000 : keyboard 0000-0000 : PNP0800:00 0000-0000 : keyboard 0000-0000 : rtc0 0000-0000 : dma page reg 0000-0000 : pic2 0000-0000 : dma2 0000-0000 : fpu 0000-0000 : pnp 00:03 0000-0000 : pnp 00:03 0000-0000 : pnp 00:03 0000-0000 : pnp 00:03 0000-0000 : PCI Bus 0000:00 0000-0000 : PCI Bus 0000:00 0000-0000 : pnp 00:04 0000-0000 : pnp 00:04 0000-0000 : pnp 00:04 0000-0000 : pnp 00:04 0000-0000 : ACPI PM1a_EVT_BLK 0000-0000 : ACPI PM1a_CNT_BLK 0000-0000 : ACPI PM_TMR 0000-0000 : ACPI CPU throttle 0000-0000 : ACPI GPE0_BLK 0000-0000 : pnp 00:04 0000-0000 : pnp 00:04 0000-0000 : pnp 00:04 0000-0000 : piix4_smbus 0000-0000 : pnp 00:04 0000-0000 : pnp 00:04 0000-0000 : pnp 00:04 0000-0000 : pnp 00:04 0000-0000 : pnp 00:04 0000-0000 : pnp 00:04 0000-0000 : pnp 00:04 0000-0000 : pnp 00:04 0000-0000 : pnp 00:04 0000-0000 : pnp 00:04 0000-0000 : pnp 00:04 0000-0000 : smba_idx 0000-0000 : pnp 00:04 0000-0000 : PCI conf1 0000-0000 : PCI Bus 0000:00 0000-0000 : PCI Bus 0000:03 0000-0000 : PCI Bus 0000:04 0000-0000 : PCI Bus 0000:07 0000-0000 : PCI Bus 0000:08 0000-0000 : PCI Bus 0000:0b 0000-0000 : 0000:0b:00.0 0000-0000 : PCI Bus 0000:06 0000-0000 : 0000:06:00.0 0000-0000 : ahci 0000-0000 : 0000:06:00.0 0000-0000 : ahci 0000-0000 : 0000:06:00.0 0000-0000 : ahci 0000-0000 : 0000:06:00.0 0000-0000 : ahci 0000-0000 : 0000:06:00.0 0000-0000 : ahci 0000-0000 : PCI Bus 0000:0e 0000-0000 : 0000:0e:00.0 /proc/iomem: 0000000-00000000 : Reserved 00000000-00000000 : System RAM 00000000-00000000 : Reserved 00000000-00000000 : PCI Bus 0000:00 00000000-00000000 : PCI Bus 0000:00 00000000-00000000 : Video ROM 00000000-00000000 : System ROM 00000000-00000000 : System RAM 00000000-00000000 : Reserved 00000000-00000000 : System RAM 00000000-00000000 : Reserved 00000000-00000000 : System RAM 00000000-00000000 : ACPI Non-volatile Storage 00000000-00000000 : Reserved 00000000-00000000 : Unknown E820 type 00000000-00000000 : System RAM 00000000-00000000 : Reserved 00000000-00000000 : PCI Bus 0000:00 00000000-00000000 : PCI Bus 0000:0e 00000000-00000000 : 0000:0e:00.0 00000000-00000000 : 0000:0e:00.0 00000000-00000000 : PCI MMCONFIG 0000 [bus 00-3f] 00000000-00000000 : Reserved 00000000-00000000 : pnp 00:00 00000000-00000000 : Reserved 00000000-00000000 : PCI Bus 0000:03 00000000-00000000 : PCI Bus 0000:04 00000000-00000000 : PCI Bus 0000:07 00000000-00000000 : PCI Bus 0000:08 00000000-00000000 : PCI Bus 0000:0b 00000000-00000000 : 0000:0b:00.0 00000000-00000000 : igb 00000000-00000000 : 0000:0b:00.0 00000000-00000000 : igb 00000000-00000000 : PCI Bus 0000:09 00000000-00000000 : 0000:09:00.0 00000000-00000000 : iwlwifi 00000000-00000000 : PCI Bus 0000:06 00000000-00000000 : 0000:06:00.0 00000000-00000000 : ahci 00000000-00000000 : 0000:03:00.1 00000000-00000000 : 0000:03:00.1 00000000-00000000 : ahci 00000000-00000000 : 0000:03:00.0 00000000-00000000 : xhci-hcd 00000000-00000000 : PCI Bus 0000:11 00000000-00000000 : 0000:11:00.3 00000000-00000000 : xhci-hcd 00000000-00000000 : 0000:11:00.2 00000000-00000000 : ccp 00000000-00000000 : 0000:11:00.2 00000000-00000000 : ccp 00000000-00000000 : PCI Bus 0000:12 00000000-00000000 : 0000:12:00.3 00000000-00000000 : ICH HD audio 00000000-00000000 : 0000:12:00.2 00000000-00000000 : ahci 00000000-00000000 : PCI Bus 0000:0e 00000000-00000000 : 0000:0e:00.0 00000000-00000000 : 0000:0e:00.1 00000000-00000000 : ICH HD audio 00000000-00000000 : PCI Bus 0000:01 00000000-00000000 : 0000:01:00.0 00000000-00000000 : nvme 00000000-00000000 : Reserved 00000000-00000000 : Reserved 00000000-00000000 : amd_iommu 00000000-00000000 : IOAPIC 0 00000000-00000000 : IOAPIC 1 00000000-00000000 : Reserved 00000000-00000000 : pnp 00:04 00000000-00000000 : Reserved 00000000-00000000 : AMDIF030:00 00000000-00000000 : AMDIF030:00 00000000-00000000 : Reserved 00000000-00000000 : HPET 0 00000000-00000000 : PNP0103:00 00000000-00000000 : Reserved 00000000-00000000 : Reserved 00000000-00000000 : AMDI0030:00 00000000-00000000 : pnp 00:04 00000000-00000000 : Reserved 00000000-00000000 : Reserved 00000000-00000000 : PCI Bus 0000:00 00000000-00000000 : Reserved 00000000-00000000 : Local APIC 00000000-00000000 : pnp 00:04 00000000-00000000 : Reserved 00000000-00000000 : pnp 00:04 00000000-00000000 : System RAM 00000000-00000000 : Kernel code 00000000-00000000 : Kernel data 00000000-00000000 : Kernel bss 00000000-00000000 : RAM buffer [8.5.] PCI information ('lspci -vvv' as root): attached 'pci.info' [8.6.] SCSI information (from /proc/scsi/scsi): Attached devices: Host: scsi5 Channel: 00 Id: 00 Lun: 00 Vendor: HL-DT-ST Model: DVDRAM GH24NSD1 Rev: LG00 Type: CD-ROM ANSI SCSI revision: 05 [8.7.] Output of dmidecode: attached as dmidecode.info -- You are receiving this mail because: You are watching the assignee of the bug.

1 24

[PATCH] drm/omap: fix typo
by Matteo Croce 07 Jan '19

07 Jan '19

Fix spelling mistake: "lenght" -> "length" Signed-off-by: Matteo Croce <mcroce(a)redhat.com> --- drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c index 813ba42f2753..e384b95ad857 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c @@ -708,7 +708,7 @@ int hdmi4_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp, else acore.i2s_cfg.justification = HDMI_AUDIO_JUSTIFY_RIGHT; /* - * The I2S input word length is twice the lenght given in the IEC-60958 + * The I2S input word length is twice the length given in the IEC-60958 * status word. If the word size is greater than * 20 bits, increment by one. */ -- 2.20.1

1 0

[PATCH libdrm] amdgpu: Allow amdgpu device creation without merging fds.
by Bas Nieuwenhuizen 07 Jan '19

07 Jan '19

For radv we want to be able to pass in a master fd and be sure that the created libdrm_amdgpu device also uses that master fd, so we can use it for prioritized submission. radv does all interaction with other APIs/processes with dma-bufs, so we should not need the functionality in libdrm_amdgpu to only have a single fd for a device in the process. Signed-off-by: Bas Nieuwenhuizen <bas(a)basnieuwenhuizen.nl> --- amdgpu/amdgpu-symbol-check | 1 + amdgpu/amdgpu.h | 37 ++++++++++++++++++++++++ amdgpu/amdgpu_device.c | 59 ++++++++++++++++++++++++-------------- 3 files changed, 76 insertions(+), 21 deletions(-) diff --git a/amdgpu/amdgpu-symbol-check b/amdgpu/amdgpu-symbol-check index 6f5e0f95..bbf48985 100755 --- a/amdgpu/amdgpu-symbol-check +++ b/amdgpu/amdgpu-symbol-check @@ -56,6 +56,7 @@ amdgpu_cs_wait_fences amdgpu_cs_wait_semaphore amdgpu_device_deinitialize amdgpu_device_initialize +amdgpu_device_initialize2 amdgpu_find_bo_by_cpu_mapping amdgpu_get_marketing_name amdgpu_query_buffer_size_alignment diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index dc51659a..e5ed39bb 100644 --- a/amdgpu/amdgpu.h +++ b/amdgpu/amdgpu.h @@ -66,6 +66,13 @@ struct drm_amdgpu_info_hw_ip; */ #define AMDGPU_QUERY_FENCE_TIMEOUT_IS_ABSOLUTE (1 << 0) +/** + * Uses in amdgpu_device_initialize2(), meaning that the passed in fd should + * not be deduplicated against other libdrm_amdgpu devices referring to the + * same kernel device. + */ +#define AMDGPU_DEVICE_DEDICATED_FD (1 << 0) + /*--------------------------------------------------------------------------*/ /* ----------------------------- Enums ------------------------------------ */ /*--------------------------------------------------------------------------*/ @@ -526,6 +533,36 @@ int amdgpu_device_initialize(int fd, uint32_t *minor_version, amdgpu_device_handle *device_handle); +/** + * + * \param fd - \c [in] File descriptor for AMD GPU device + * received previously as the result of + * e.g. drmOpen() call. + * For legacy fd type, the DRI2/DRI3 + * authentication should be done before + * calling this function. + * \param flags - \c [in] Bitmask of flags for device creation. + * \param major_version - \c [out] Major version of library. It is assumed + * that adding new functionality will cause + * increase in major version + * \param minor_version - \c [out] Minor version of library + * \param device_handle - \c [out] Pointer to opaque context which should + * be passed as the first parameter on each + * API call + * + * + * \return 0 on success\n + * <0 - Negative POSIX Error code + * + * + * \sa amdgpu_device_deinitialize() +*/ +int amdgpu_device_initialize2(int fd, + uint32_t flags, + uint32_t *major_version, + uint32_t *minor_version, + amdgpu_device_handle *device_handle); + /** * * When access to such library does not needed any more the special diff --git a/amdgpu/amdgpu_device.c b/amdgpu/amdgpu_device.c index 362494b1..b4bf3f76 100644 --- a/amdgpu/amdgpu_device.c +++ b/amdgpu/amdgpu_device.c @@ -100,7 +100,8 @@ static void amdgpu_device_free_internal(amdgpu_device_handle dev) pthread_mutex_lock(&fd_mutex); while (*node != dev && (*node)->next) node = &(*node)->next; - *node = (*node)->next; + if (*node == dev) + *node = (*node)->next; pthread_mutex_unlock(&fd_mutex); close(dev->fd); @@ -144,6 +145,16 @@ drm_public int amdgpu_device_initialize(int fd, uint32_t *major_version, uint32_t *minor_version, amdgpu_device_handle *device_handle) +{ + return amdgpu_device_initialize2(fd, 0, major_version, minor_version, + device_handle); +} + +drm_public int amdgpu_device_initialize2(int fd, + uint32_t flags, + uint32_t *major_version, + uint32_t *minor_version, + amdgpu_device_handle *device_handle) { struct amdgpu_device *dev; drmVersionPtr version; @@ -164,26 +175,28 @@ drm_public int amdgpu_device_initialize(int fd, return r; } - for (dev = fd_list; dev; dev = dev->next) - if (fd_compare(dev->fd, fd) == 0) - break; - - if (dev) { - r = amdgpu_get_auth(dev->fd, &flag_authexist); - if (r) { - fprintf(stderr, "%s: amdgpu_get_auth (2) failed (%i)\n", - __func__, r); + if (!(flags & AMDGPU_DEVICE_DEDICATED_FD)) { + for (dev = fd_list; dev; dev = dev->next) + if (fd_compare(dev->fd, fd) == 0) + break; + + if (dev) { + r = amdgpu_get_auth(dev->fd, &flag_authexist); + if (r) { + fprintf(stderr, "%s: amdgpu_get_auth (2) failed (%i)\n", + __func__, r); + pthread_mutex_unlock(&fd_mutex); + return r; + } + if ((flag_auth) && (!flag_authexist)) { + dev->flink_fd = fcntl(fd, F_DUPFD_CLOEXEC, 0); + } + *major_version = dev->major_version; + *minor_version = dev->minor_version; + amdgpu_device_reference(device_handle, dev); pthread_mutex_unlock(&fd_mutex); - return r; - } - if ((flag_auth) && (!flag_authexist)) { - dev->flink_fd = fcntl(fd, F_DUPFD_CLOEXEC, 0); + return 0; } - *major_version = dev->major_version; - *minor_version = dev->minor_version; - amdgpu_device_reference(device_handle, dev); - pthread_mutex_unlock(&fd_mutex); - return 0; } dev = calloc(1, sizeof(struct amdgpu_device)); @@ -265,8 +278,12 @@ drm_public int amdgpu_device_initialize(int fd, *major_version = dev->major_version; *minor_version = dev->minor_version; *device_handle = dev; - dev->next = fd_list; - fd_list = dev; + + if (!(flags & AMDGPU_DEVICE_DEDICATED_FD)) { + dev->next = fd_list; + fd_list = dev; + } + pthread_mutex_unlock(&fd_mutex); return 0; -- 2.19.2

3 5

[PATCH] v2 bakclight: fix missing checks in ambient_light_zone_store
by Aditya Pakki 07 Jan '19

07 Jan '19

In adp8870_bl_ambient_light_zone_store, set, clear, and write can return an error but are not checked. The fix adds a check for these cases and returns -1 to match the return type (ssize_t). Signed-off-by: Aditya Pakki <pakki001(a)umn.edu> --- drivers/video/backlight/adp8870_bl.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/video/backlight/adp8870_bl.c b/drivers/video/backlight/adp8870_bl.c index 8d50e0299578..56a640587a82 100644 --- a/drivers/video/backlight/adp8870_bl.c +++ b/drivers/video/backlight/adp8870_bl.c @@ -800,10 +800,14 @@ static ssize_t adp8870_bl_ambient_light_zone_store(struct device *dev, if (val == 0) { /* Enable automatic ambient light sensing */ - adp8870_set_bits(data->client, ADP8870_MDCR, CMP_AUTOEN); + ret = adp8870_set_bits(data->client, ADP8870_MDCR, CMP_AUTOEN); + if (ret < 0) + goto adp8870_bl_err; } else if ((val > 0) && (val < 6)) { /* Disable automatic ambient light sensing */ - adp8870_clr_bits(data->client, ADP8870_MDCR, CMP_AUTOEN); + ret = adp8870_clr_bits(data->client, ADP8870_MDCR, CMP_AUTOEN); + if (ret < 0) + goto adp8870_bl_err; /* Set user supplied ambient light zone */ mutex_lock(&data->lock); @@ -811,12 +815,18 @@ static ssize_t adp8870_bl_ambient_light_zone_store(struct device *dev, if (!ret) { reg_val &= ~(CFGR_BLV_MASK << CFGR_BLV_SHIFT); reg_val |= (val - 1) << CFGR_BLV_SHIFT; - adp8870_write(data->client, ADP8870_CFGR, reg_val); + ret = adp8870_write(data->client, ADP8870_CFGR, + reg_val); } mutex_unlock(&data->lock); + if (ret < 0) + goto adp8870_bl_err; } return count; + +adp8870_bl_err: + return -1; } static DEVICE_ATTR(ambient_light_zone, 0664, adp8870_bl_ambient_light_zone_show, -- 2.17.1

2 2

[PATCH v4 0/3] CRTC background color
by Matt Roper 07 Jan '19

07 Jan '19

Fourth version of the series previously posted here: https://lists.freedesktop.org/archives/intel-gfx/2018-November/181939.html Code-wise, this version mainly just drops the bgcolor_changed flag. Most of the changes here are just to the kerneldoc: clarifying the interaction of background color with crtc degamma/csc/gamma, and why having a non-opaque background color might actually make sense for very specific use cases (memory writeback connectors). As before, the first patch in this series is just an Intel-specific bugfix that is unrelated to the ABI change and thus can be merged immediately after review. The second and third patches need a pointer to the ready, reviewed userspace that's going to use this (I believe ChromeOS pretty much has this ready, but I don't have a link to their patches yet). I heard there's also someone working on adding support for this to Weston, but I'm not sure what the status of that work is. Matt Roper (3): drm/i915: Force background color to black for gen9+ (v2) drm: Add CRTC background color property (v4) drm/i915/gen9+: Add support for pipe background color (v4) drivers/gpu/drm/drm_atomic_uapi.c | 4 ++++ drivers/gpu/drm/drm_blend.c | 28 ++++++++++++++++++++++--- drivers/gpu/drm/drm_mode_config.c | 6 ++++++ drivers/gpu/drm/i915/i915_debugfs.c | 9 ++++++++ drivers/gpu/drm/i915/i915_reg.h | 6 ++++++ drivers/gpu/drm/i915/intel_display.c | 40 ++++++++++++++++++++++++++++++++++++ include/drm/drm_blend.h | 1 + include/drm/drm_crtc.h | 12 +++++++++++ include/drm/drm_mode_config.h | 5 +++++ include/uapi/drm/drm_mode.h | 28 +++++++++++++++++++++++++ 10 files changed, 136 insertions(+), 3 deletions(-) -- 2.14.5

3 5

[PATCH v4 03/11] vga-switcheroo: make PCI dependency explicit
by Sinan Kaya 07 Jan '19

07 Jan '19

This driver depends on the PCI infrastructure but the dependency has not been explicitly called out. Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") Signed-off-by: Sinan Kaya <okaya(a)kernel.org> Reviewed-by: Lukas Wunner <lukas(a)wunner.de> Acked-by: Daniel Vetter <daniel.vetter(a)ffwll.ch> --- drivers/gpu/vga/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/vga/Kconfig b/drivers/gpu/vga/Kconfig index b677e5d524e6..d5f1d8e1c6f8 100644 --- a/drivers/gpu/vga/Kconfig +++ b/drivers/gpu/vga/Kconfig @@ -21,6 +21,7 @@ config VGA_SWITCHEROO bool "Laptop Hybrid Graphics - GPU switching support" depends on X86 depends on ACPI + depends on PCI select VGA_ARB help Many laptops released in 2008/9/10 have two GPUs with a multiplexer -- 2.19.0

3 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2019