dri-devel January 2019

dri-devel@lists.freedesktop.org

279 participants
2022 discussions

[Bug 108591] [CI][DRMTIP] igt@gem_tiled_fence_blits@normal - fail - Failed assertion: linear[i] == start_val
by bugzilla-daemon＠freedesktop.org 04 Jan '19

04 Jan '19

https://bugs.freedesktop.org/show_bug.cgi?id=108591 Martin Peres <martin.peres(a)free.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #11 from Martin Peres <martin.peres(a)free.fr> --- (In reply to Chris Wilson from comment #10) > commit 7fa28e146994da1e8a4124623d7da97b798ea520 (HEAD -> > drm-intel-next-queued, drm-intel/for-linux-next, > drm-intel/drm-intel-next-queued) > Author: Chris Wilson <chris(a)chris-wilson.co.uk> > Date: Mon Nov 19 15:41:53 2018 +0000 > > drm/i915: Write GPU relocs harder with gen3 > > Under moderate amounts of GPU stress, we can observe on Bearlake and > Pineview (later gen3 models) that we execute the following batch buffer > before the write into the batch is coherent. Adding extra (tested with > upto 32x) MI_FLUSH to either the invalidation, flush or both phases does > not solve the incoherency issue with the relocations, but emitting the > MI_STORE_DWORD_IMM twice does. So be it. > > Fixes: 7dd4f6729f92 ("drm/i915: Async GPU relocation processing") > Testcase: igt/gem_tiled_fence_blits # blb/pnv > Signed-off-by: Chris Wilson <chris(a)chris-wilson.co.uk> > Cc: Joonas Lahtinen <joonas.lahtinen(a)linux.intel.com> > Reviewed-by: Joonas Lahtinen <joonas.lahtinen(a)linux.intel.com> > Link: > https://patchwork.freedesktop.org/patch/msgid/20181119154153.15327-1- > chris(a)chris-wilson.co.uk Oddly-enough, this was not sufficient to fix the issue, but it stopped failing after drmtip_176 (https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_176/fi-gdg-551/igt@gem_tile…), so closing! -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 108763] [CI] Make IGT_runner exit with an error code != 0 when aborting
by bugzilla-daemon＠freedesktop.org 04 Jan '19

04 Jan '19

https://bugs.freedesktop.org/show_bug.cgi?id=108763 Martin Peres <martin.peres(a)free.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Martin Peres <martin.peres(a)free.fr> --- (In reply to Chris Wilson from comment #3) > commit 68264891ceee34195839d82d4d87cbae08ef2431 (origin/master, origin/HEAD) > Author: Petri Latvala <petri.latvala(a)intel.com> > Date: Fri Nov 16 16:32:52 2018 +0200 > > runner: Exit with a nonzero status if aborting > > Signed-off-by: Petri Latvala <petri.latvala(a)intel.com> > Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler(a)intel.com> Thanks! -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 109049] [CI][BAT] igt@amdgpu/amd_prime@amd-to-i915 - fail - Failed assertion: r == 0, Last errno: 28, No space left on device
by bugzilla-daemon＠freedesktop.org 04 Jan '19

04 Jan '19

https://bugs.freedesktop.org/show_bug.cgi?id=109049 Bug ID: 109049 Summary: [CI][BAT] igt@amdgpu/amd_prime@amd-to-i915 - fail - Failed assertion: r == 0, Last errno: 28, No space left on device Product: DRI Version: XOrg git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: martin.peres(a)free.fr https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5311/fi-kbl-8809g/igt@amdgp… Starting subtest: amd-to-i915 (amd_prime:4058) CRITICAL: Test assertion failure function amd_to_i915, file ../tests/amdgpu/amd_prime.c:358: (amd_prime:4058) CRITICAL: Failed assertion: r == 0 (amd_prime:4058) CRITICAL: Last errno: 28, No space left on device (amd_prime:4058) CRITICAL: error: -28 != 0 Subtest amd-to-i915 failed. -- You are receiving this mail because: You are the assignee for the bug.

1 9

[PATCH] drm/tegra: hdmi: Fix audio to work with any pixel clock rate
by Alban Bedel 04 Jan '19

04 Jan '19

The audio setting implementation was limited to a few specific pixel clocks. This prevented HDMI audio from working on several test devices as they need a pixel clock that is not supported by this implementation. Fix this by implementing the algorithm provided in the TRM using fixed point arithmetic. This allows the driver to cope with any sane pixel clock rate. Signed-off-by: Alban Bedel <alban.bedel(a)avionic-design.de> --- drivers/gpu/drm/tegra/hdmi.c | 163 ++++++++++++++----------------------------- 1 file changed, 54 insertions(+), 109 deletions(-) diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c index cda0491ed6bf..b6078d6604b1 100644 --- a/drivers/gpu/drm/tegra/hdmi.c +++ b/drivers/gpu/drm/tegra/hdmi.c @@ -14,6 +14,7 @@ #include <linux/pm_runtime.h> #include <linux/regulator/consumer.h> #include <linux/reset.h> +#include <asm/div64.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_crtc.h> @@ -112,68 +113,11 @@ static inline void tegra_hdmi_writel(struct tegra_hdmi *hdmi, u32 value, } struct tegra_hdmi_audio_config { - unsigned int pclk; unsigned int n; unsigned int cts; unsigned int aval; }; -static const struct tegra_hdmi_audio_config tegra_hdmi_audio_32k[] = { - { 25200000, 4096, 25200, 24000 }, - { 27000000, 4096, 27000, 24000 }, - { 74250000, 4096, 74250, 24000 }, - { 148500000, 4096, 148500, 24000 }, - { 0, 0, 0, 0 }, -}; - -static const struct tegra_hdmi_audio_config tegra_hdmi_audio_44_1k[] = { - { 25200000, 5880, 26250, 25000 }, - { 27000000, 5880, 28125, 25000 }, - { 74250000, 4704, 61875, 20000 }, - { 148500000, 4704, 123750, 20000 }, - { 0, 0, 0, 0 }, -}; - -static const struct tegra_hdmi_audio_config tegra_hdmi_audio_48k[] = { - { 25200000, 6144, 25200, 24000 }, - { 27000000, 6144, 27000, 24000 }, - { 74250000, 6144, 74250, 24000 }, - { 148500000, 6144, 148500, 24000 }, - { 0, 0, 0, 0 }, -}; - -static const struct tegra_hdmi_audio_config tegra_hdmi_audio_88_2k[] = { - { 25200000, 11760, 26250, 25000 }, - { 27000000, 11760, 28125, 25000 }, - { 74250000, 9408, 61875, 20000 }, - { 148500000, 9408, 123750, 20000 }, - { 0, 0, 0, 0 }, -}; - -static const struct tegra_hdmi_audio_config tegra_hdmi_audio_96k[] = { - { 25200000, 12288, 25200, 24000 }, - { 27000000, 12288, 27000, 24000 }, - { 74250000, 12288, 74250, 24000 }, - { 148500000, 12288, 148500, 24000 }, - { 0, 0, 0, 0 }, -}; - -static const struct tegra_hdmi_audio_config tegra_hdmi_audio_176_4k[] = { - { 25200000, 23520, 26250, 25000 }, - { 27000000, 23520, 28125, 25000 }, - { 74250000, 18816, 61875, 20000 }, - { 148500000, 18816, 123750, 20000 }, - { 0, 0, 0, 0 }, -}; - -static const struct tegra_hdmi_audio_config tegra_hdmi_audio_192k[] = { - { 25200000, 24576, 25200, 24000 }, - { 27000000, 24576, 27000, 24000 }, - { 74250000, 24576, 74250, 24000 }, - { 148500000, 24576, 148500, 24000 }, - { 0, 0, 0, 0 }, -}; - static const struct tmds_config tegra20_tmds_config[] = { { /* slow pixel clock modes */ .pclk = 27000000, @@ -411,52 +355,49 @@ static const struct tmds_config tegra124_tmds_config[] = { }, }; -static const struct tegra_hdmi_audio_config * -tegra_hdmi_get_audio_config(unsigned int sample_rate, unsigned int pclk) +static int +tegra_hdmi_get_audio_config(unsigned int audio_freq, unsigned int pix_clock, + struct tegra_hdmi_audio_config *config) { - const struct tegra_hdmi_audio_config *table; - - switch (sample_rate) { - case 32000: - table = tegra_hdmi_audio_32k; - break; - - case 44100: - table = tegra_hdmi_audio_44_1k; - break; - - case 48000: - table = tegra_hdmi_audio_48k; - break; - - case 88200: - table = tegra_hdmi_audio_88_2k; - break; - - case 96000: - table = tegra_hdmi_audio_96k; - break; - - case 176400: - table = tegra_hdmi_audio_176_4k; - break; - - case 192000: - table = tegra_hdmi_audio_192k; - break; - - default: - return NULL; - } - - while (table->pclk) { - if (table->pclk == pclk) - return table; - - table++; + const int afreq = 128 * audio_freq; + const int min_n = afreq / 1500; + const int max_n = afreq / 300; + const int ideal_n = afreq / 1000; + int64_t min_err = (uint64_t)-1 >> 1; + int n; + + config->n = -1; + + for (n = min_n; n <= max_n; n++) { + uint64_t cts_f, aval_f; + int64_t cts, err; + + /* compute aval in 48.16 fixed point */ + aval_f = ((int64_t)24000000 << 16) * n; + do_div(aval_f, afreq); + /* It should round without any rest */ + if (aval_f & 0xFFFF) + continue; + + /* Compute cts in 48.16 fixed point */ + cts_f = ((int64_t)pix_clock << 16) * n; + do_div(cts_f, afreq); + /* Round it to the nearest integer */ + cts = (cts_f & ~0xFFFF) + ((cts_f & BIT(15)) << 1); + + /* Compute the absolute error */ + err = abs((int64_t)cts_f - cts); + if (err < min_err || + (err == min_err && + abs(n - ideal_n) < abs(config->n - ideal_n))) { + config->n = n; + config->cts = cts >> 16; + config->aval = aval_f >> 16; + min_err = err; + } } - return NULL; + return config->n != -1 ? 0 : -EINVAL; } static void tegra_hdmi_setup_audio_fs_tables(struct tegra_hdmi *hdmi) @@ -512,8 +453,9 @@ static void tegra_hdmi_write_aval(struct tegra_hdmi *hdmi, u32 value) static int tegra_hdmi_setup_audio(struct tegra_hdmi *hdmi) { - const struct tegra_hdmi_audio_config *config; + struct tegra_hdmi_audio_config config; u32 source, value; + int err; switch (hdmi->audio_source) { case HDA: @@ -588,25 +530,28 @@ static int tegra_hdmi_setup_audio(struct tegra_hdmi *hdmi) tegra_hdmi_writel(hdmi, value, HDMI_NV_PDISP_SOR_AUDIO_SPARE0); } - config = tegra_hdmi_get_audio_config(hdmi->audio_sample_rate, - hdmi->pixel_clock); - if (!config) { + err = tegra_hdmi_get_audio_config(hdmi->audio_sample_rate, + hdmi->pixel_clock, &config); + if (err) { dev_err(hdmi->dev, "cannot set audio to %u Hz at %u Hz pixel clock\n", hdmi->audio_sample_rate, hdmi->pixel_clock); - return -EINVAL; + return err; } + dev_dbg(hdmi->dev, "audio: pixclk=%d, n=%d, cts=%d, aval=%d\n", + hdmi->pixel_clock, config.n, config.cts, config.aval); + tegra_hdmi_writel(hdmi, 0, HDMI_NV_PDISP_HDMI_ACR_CTRL); value = AUDIO_N_RESETF | AUDIO_N_GENERATE_ALTERNATE | - AUDIO_N_VALUE(config->n - 1); + AUDIO_N_VALUE(config.n - 1); tegra_hdmi_writel(hdmi, value, HDMI_NV_PDISP_AUDIO_N); - tegra_hdmi_writel(hdmi, ACR_SUBPACK_N(config->n) | ACR_ENABLE, + tegra_hdmi_writel(hdmi, ACR_SUBPACK_N(config.n) | ACR_ENABLE, HDMI_NV_PDISP_HDMI_ACR_0441_SUBPACK_HIGH); - tegra_hdmi_writel(hdmi, ACR_SUBPACK_CTS(config->cts), + tegra_hdmi_writel(hdmi, ACR_SUBPACK_CTS(config.cts), HDMI_NV_PDISP_HDMI_ACR_0441_SUBPACK_LOW); value = SPARE_HW_CTS | SPARE_FORCE_SW_CTS | SPARE_CTS_RESET_VAL(1); @@ -617,7 +562,7 @@ static int tegra_hdmi_setup_audio(struct tegra_hdmi *hdmi) tegra_hdmi_writel(hdmi, value, HDMI_NV_PDISP_AUDIO_N); if (hdmi->config->has_hda) - tegra_hdmi_write_aval(hdmi, config->aval); + tegra_hdmi_write_aval(hdmi, config.aval); tegra_hdmi_setup_audio_fs_tables(hdmi); -- 2.11.0

2 1

WARNING: lock held when returning to user space in set_property_atomic
by syzbot 04 Jan '19

04 Jan '19

Hello, syzbot found the following crash on: HEAD commit: 903b77c63167 Merge tag 'linux-kselftest-4.21-rc1' of git:/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=12d0f553400000 kernel config: https://syzkaller.appspot.com/x/.config?x=53a2f2aa0b1f7606 dashboard link: https://syzkaller.appspot.com/bug?extid=6ea337c427f5083ebdf2 compiler: gcc (GCC) 8.0.1 20180413 (experimental) syz repro: https://syzkaller.appspot.com/x/repro.syz?x=120d906f400000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1024673b400000 IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+6ea337c427f5083ebdf2(a)syzkaller.appspotmail.com RBP: 00007ffe369ca7a0 R08: 0000000000000001 R09: 00000000004009ce R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000005 R13: ffffffffffffffff R14: 0000000000000000 R15: 0000000000000000 ================================================ WARNING: lock held when returning to user space! 4.20.0+ #174 Not tainted ------------------------------------------------ syz-executor556/8153 is leaving the kernel with locks still held! 1 lock held by syz-executor556/8153: #0: 000000005100c85c (crtc_ww_class_acquire){+.+.}, at: set_property_atomic+0xb3/0x330 drivers/gpu/drm/drm_mode_object.c:462 --- This bug is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this bug report. See: https://goo.gl/tpsmEJ#bug-status-tracking for how to communicate with syzbot. syzbot can test patches for this bug, for details see: https://goo.gl/tpsmEJ#testing-patches

4 3

[radeon-alex:amd-18.50 3/3] fs/btrfs/super.c:2373:1: error: directive in argument list
by kbuild test robot 04 Jan '19

04 Jan '19

tree: git://people.freedesktop.org/~agd5f/linux.git amd-18.50 head: 6b02d4906a8c5b3e4a268516057e5b77bbc5f559 commit: 6b02d4906a8c5b3e4a268516057e5b77bbc5f559 [3/3] drm/amdgpu/nbio7.4: add hw bug workaround for vega20 config: x86_64-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: git checkout 6b02d4906a8c5b3e4a268516057e5b77bbc5f559 # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): >> sound/core/seq/seq_clientmgr.c:1104:24: warning: incorrect type in return expression (different base types) sound/core/seq/seq_clientmgr.c:1104:24: expected restricted __poll_t sound/core/seq/seq_clientmgr.c:1104:24: got int sound/core/seq/seq_clientmgr.c:693:9: warning: context imbalance in 'deliver_to_subscribers' - different lock contexts for basic block -- >> fs/btrfs/super.c:2373:1: error: directive in argument list fs/btrfs/super.c:2375:1: error: directive in argument list fs/btrfs/super.c:2376:1: error: directive in argument list fs/btrfs/super.c:2378:1: error: directive in argument list fs/btrfs/super.c:2379:1: error: directive in argument list fs/btrfs/super.c:2381:1: error: directive in argument list fs/btrfs/super.c:2382:1: error: directive in argument list fs/btrfs/super.c:2384:1: error: directive in argument list fs/btrfs/super.c:2318:24: error: incompatible types in comparison expression (different address spaces) -- >> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.c:55:15: warning: symbol 'vchiq_dbg_dir' was not declared. Should it be static? >> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.c:56:15: warning: symbol 'vchiq_dbg_clients' was not declared. Should it be static? -- drivers/infiniband/hw/i40iw/i40iw_hw.c:483:20: warning: incorrect type in assignment (different base types) drivers/infiniband/hw/i40iw/i40iw_hw.c:483:20: expected unsigned short [usertype] port drivers/infiniband/hw/i40iw/i40iw_hw.c:483:20: got restricted __le16 [usertype] drivers/infiniband/hw/i40iw/i40iw_hw.c:529:33: warning: incorrect type in assignment (different base types) drivers/infiniband/hw/i40iw/i40iw_hw.c:529:33: expected unsigned short [usertype] arp_index drivers/infiniband/hw/i40iw/i40iw_hw.c:529:33: got restricted __le16 [usertype] drivers/infiniband/hw/i40iw/i40iw_hw.c:595:31: warning: incorrect type in assignment (different base types) drivers/infiniband/hw/i40iw/i40iw_hw.c:595:31: expected unsigned short [usertype] vlan_id drivers/infiniband/hw/i40iw/i40iw_hw.c:595:31: got restricted __le16 [usertype] drivers/infiniband/hw/i40iw/i40iw_hw.c:603:22: warning: incorrect type in assignment (different base types) drivers/infiniband/hw/i40iw/i40iw_hw.c:603:22: expected unsigned int [usertype] qp_num drivers/infiniband/hw/i40iw/i40iw_hw.c:603:22: got restricted __le32 [usertype] drivers/infiniband/hw/i40iw/i40iw_hw.c:604:25: warning: incorrect type in assignment (different base types) drivers/infiniband/hw/i40iw/i40iw_hw.c:604:25: expected unsigned short [usertype] dest_port drivers/infiniband/hw/i40iw/i40iw_hw.c:604:25: got restricted __le16 [usertype] drivers/infiniband/hw/i40iw/i40iw_hw.c:605:26: warning: incorrect type in assignment (different base types) drivers/infiniband/hw/i40iw/i40iw_hw.c:605:26: expected unsigned int drivers/infiniband/hw/i40iw/i40iw_hw.c:605:26: got restricted __le32 [usertype] drivers/infiniband/hw/i40iw/i40iw_hw.c:606:26: warning: incorrect type in assignment (different base types) drivers/infiniband/hw/i40iw/i40iw_hw.c:606:26: expected unsigned int drivers/infiniband/hw/i40iw/i40iw_hw.c:606:26: got restricted __le32 [usertype] drivers/infiniband/hw/i40iw/i40iw_hw.c:607:26: warning: incorrect type in assignment (different base types) drivers/infiniband/hw/i40iw/i40iw_hw.c:607:26: expected unsigned int drivers/infiniband/hw/i40iw/i40iw_hw.c:607:26: got restricted __le32 [usertype] drivers/infiniband/hw/i40iw/i40iw_hw.c:608:26: warning: incorrect type in assignment (different base types) drivers/infiniband/hw/i40iw/i40iw_hw.c:608:26: expected unsigned int drivers/infiniband/hw/i40iw/i40iw_hw.c:608:26: got restricted __le32 [usertype] drivers/infiniband/hw/i40iw/i40iw_hw.c:610:32: warning: incorrect type in assignment (different base types) drivers/infiniband/hw/i40iw/i40iw_hw.c:610:32: expected unsigned short [usertype] src_port drivers/infiniband/hw/i40iw/i40iw_hw.c:610:32: got restricted __le16 [usertype] drivers/infiniband/hw/i40iw/i40iw_hw.c:611:33: warning: incorrect type in assignment (different base types) drivers/infiniband/hw/i40iw/i40iw_hw.c:611:33: expected unsigned int drivers/infiniband/hw/i40iw/i40iw_hw.c:611:33: got restricted __le32 [usertype] drivers/infiniband/hw/i40iw/i40iw_hw.c:612:33: warning: incorrect type in assignment (different base types) drivers/infiniband/hw/i40iw/i40iw_hw.c:612:33: expected unsigned int drivers/infiniband/hw/i40iw/i40iw_hw.c:612:33: got restricted __le32 [usertype] drivers/infiniband/hw/i40iw/i40iw_hw.c:613:33: warning: incorrect type in assignment (different base types) drivers/infiniband/hw/i40iw/i40iw_hw.c:613:33: expected unsigned int drivers/infiniband/hw/i40iw/i40iw_hw.c:613:33: got restricted __le32 [usertype] drivers/infiniband/hw/i40iw/i40iw_hw.c:614:33: warning: incorrect type in assignment (different base types) drivers/infiniband/hw/i40iw/i40iw_hw.c:614:33: expected unsigned int drivers/infiniband/hw/i40iw/i40iw_hw.c:614:33: got restricted __le32 [usertype] >> include/linux/spinlock.h:365:9: warning: context imbalance in 'i40iw_manage_apbvt' - unexpected unlock -- sound/pci/hda/patch_ca0132.c:2467:43: warning: incorrect type in argument 3 (different base types) sound/pci/hda/patch_ca0132.c:2467:43: expected unsigned int format sound/pci/hda/patch_ca0132.c:2467:43: got restricted snd_pcm_format_t [usertype] >> sound/pci/hda/patch_ca0132.c:5519:22: warning: Using plain integer as NULL pointer sound/pci/hda/patch_ca0132.c:5520:22: warning: Using plain integer as NULL pointer sound/pci/hda/patch_ca0132.c:6533:25: warning: incorrect type in argument 3 (different base types) sound/pci/hda/patch_ca0132.c:6533:25: expected unsigned int format sound/pci/hda/patch_ca0132.c:6533:25: got restricted snd_pcm_format_t [usertype] -- >> drivers/media/pci/saa7164/saa7164-vbi.c:632:24: warning: incorrect type in return expression (different base types) drivers/media/pci/saa7164/saa7164-vbi.c:632:24: expected restricted __poll_t drivers/media/pci/saa7164/saa7164-vbi.c:632:24: got int drivers/media/pci/saa7164/saa7164-vbi.c:637:40: warning: incorrect type in return expression (different base types) drivers/media/pci/saa7164/saa7164-vbi.c:637:40: expected restricted __poll_t drivers/media/pci/saa7164/saa7164-vbi.c:637:40: got int drivers/media/pci/saa7164/saa7164-vbi.c:647:40: warning: incorrect type in return expression (different base types) drivers/media/pci/saa7164/saa7164-vbi.c:647:40: expected restricted __poll_t drivers/media/pci/saa7164/saa7164-vbi.c:647:40: got int -- >> drivers/gpu/drm/i2c/tda9950.c:79:20: warning: Variable length array is used. -- >> drivers/nvmem/rave-sp-eeprom.c:100:16: warning: Variable length array is used. drivers/nvmem/rave-sp-eeprom.c:288:40: warning: Using plain integer as NULL pointer -- >> drivers/media/platform/s3c-camif/camif-capture.c:602:21: warning: incorrect type in assignment (different base types) drivers/media/platform/s3c-camif/camif-capture.c:602:21: expected restricted __poll_t [usertype] ret drivers/media/platform/s3c-camif/camif-capture.c:602:21: got int -- include/kcl/kcl_drm_global.h:46:30: warning: no newline at end of file drivers/gpu/drm/amd/amdgpu/amdgpu.h:854:1: error: expected ; at end of declaration drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:108:5: warning: symbol 'amdgpu_exp_hw_support' was not declared. Should it be static? >> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:508:5: warning: symbol 'priv_cp_queues' was not declared. Should it be static? >> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:516:6: warning: symbol 'keep_idle_process_evicted' was not declared. Should it be static? >> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:520:5: warning: symbol 'cma_enable' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:577:5: warning: symbol 'sched_policy' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:587:5: warning: symbol 'hws_max_conc_proc' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:598:5: warning: symbol 'cwsr_enable' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:607:5: warning: symbol 'max_num_of_queues_per_device' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:617:5: warning: symbol 'send_sigterm' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:629:5: warning: symbol 'debug_largebar' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:640:5: warning: symbol 'ignore_crat' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:651:5: warning: symbol 'noretry' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:661:5: warning: symbol 'halt_if_hws_hang' was not declared. Should it be static? In file included from drivers/gpu/drm/amd/amdgpu/../backport/include/kcl/kcl_amdgpu.h:5:0, from drivers/gpu/drm/amd/amdgpu/../backport/backport.h:12, from <command-line>:0: drivers/gpu/drm/amd/amdgpu/amdgpu.h:854:1: warning: no semicolon at end of struct or union }; ^ -- include/kcl/kcl_drm_global.h:46:30: warning: no newline at end of file drivers/gpu/drm/amd/amdgpu/amdgpu.h:854:1: error: expected ; at end of declaration >> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:3275:1: error: directive in argument list drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:3277:1: error: directive in argument list In file included from drivers/gpu/drm/amd/amdgpu/../backport/include/kcl/kcl_amdgpu.h:5:0, from drivers/gpu/drm/amd/amdgpu/../backport/backport.h:12, from <command-line>:0: drivers/gpu/drm/amd/amdgpu/amdgpu.h:854:1: warning: no semicolon at end of struct or union }; ^ .. vim +2373 fs/btrfs/super.c a9218f6b Chris Mason 2008-03-24 2369 f5c29bd9 Liu Bo 2017-11-02 2370 static void __init btrfs_print_mod_info(void) 85965600 David Sterba 2013-04-30 2371 { 62e85577 Jeff Mahoney 2016-09-20 2372 pr_info("Btrfs loaded, crc32c=%s" 85965600 David Sterba 2013-04-30 @2373 #ifdef CONFIG_BTRFS_DEBUG 85965600 David Sterba 2013-04-30 2374 ", debug=on" 85965600 David Sterba 2013-04-30 2375 #endif 79556c3d Stefan Behrens 2013-09-03 2376 #ifdef CONFIG_BTRFS_ASSERT 79556c3d Stefan Behrens 2013-09-03 2377 ", assert=on" 79556c3d Stefan Behrens 2013-09-03 2378 #endif 85965600 David Sterba 2013-04-30 2379 #ifdef CONFIG_BTRFS_FS_CHECK_INTEGRITY 85965600 David Sterba 2013-04-30 2380 ", integrity-checker=on" 85965600 David Sterba 2013-04-30 2381 #endif fb592373 Josef Bacik 2017-09-29 2382 #ifdef CONFIG_BTRFS_FS_REF_VERIFY fb592373 Josef Bacik 2017-09-29 2383 ", ref-verify=on" fb592373 Josef Bacik 2017-09-29 2384 #endif 5f9e1059 Jeff Mahoney 2015-09-16 2385 "\n", 9678c543 Nikolay Borisov 2018-01-08 2386 crc32c_impl()); 85965600 David Sterba 2013-04-30 2387 } 85965600 David Sterba 2013-04-30 2388 :::::: The code at line 2373 was first introduced by commit :::::: 85965600f50b2e57746363d0ace4ab6b2bcb9c27 btrfs: show compiled-in config features at module load time :::::: TO: David Sterba <dsterba(a)suse.cz> :::::: CC: Josef Bacik <jbacik(a)fusionio.com> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[PATCH] drm/bridge: sii902x: add sampling edge
by Tomi Valkeinen 03 Jan '19

03 Jan '19

The driver always sets InputBusFmt:EDGE to 0 (falling edge). Add drm_bridge_timings's sampling_edge to reflect that the bridge samples on falling edges. Signed-off-by: Tomi Valkeinen <tomi.valkeinen(a)ti.com> --- NOTE: This needs Laurent's "drm: Clarify definition of the DRM_BUS_FLAG_(PIXDATA|SYNC)_* macros" drivers/gpu/drm/bridge/sii902x.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c index bfa902013aa4..799581be98dc 100644 --- a/drivers/gpu/drm/bridge/sii902x.c +++ b/drivers/gpu/drm/bridge/sii902x.c @@ -459,6 +459,12 @@ static int sii902x_i2c_bypass_deselect(struct i2c_mux_core *mux, u32 chan_id) return 0; } +static const struct drm_bridge_timings default_sii902x_timings = { + .sampling_edge = DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE + | DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE + | DRM_BUS_FLAG_DE_HIGH, +}; + static int sii902x_probe(struct i2c_client *client, const struct i2c_device_id *id) { @@ -529,6 +535,7 @@ static int sii902x_probe(struct i2c_client *client, sii902x->bridge.funcs = &sii902x_bridge_funcs; sii902x->bridge.of_node = dev->of_node; + sii902x->bridge.timings = &default_sii902x_timings; drm_bridge_add(&sii902x->bridge); i2c_set_clientdata(client, sii902x); -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

2 2

[PATCH] drm/amdgpu_vm: fix boolean expressions
by Gustavo A. R. Silva 03 Jan '19

03 Jan '19

Fix boolean expressions by using logical AND operator '&&' instead of bitwise operator '&'. This issue was detected with the help of Coccinelle. Fixes: c8c5e569c5b0 ("drm/amdgpu: Consolidate visible vs. real vram check v2.") Cc: stable(a)vger.kernel.org Signed-off-by: Gustavo A. R. Silva <gustavo(a)embeddedor.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index e73d152659a2..4cc0d1079935 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c @@ -3006,7 +3006,7 @@ int amdgpu_vm_init(struct amdgpu_device *adev, struct amdgpu_vm *vm, } DRM_DEBUG_DRIVER("VM update mode is %s\n", vm->use_cpu_for_update ? "CPU" : "SDMA"); - WARN_ONCE((vm->use_cpu_for_update & !amdgpu_gmc_vram_full_visible(&adev->gmc)), + WARN_ONCE((vm->use_cpu_for_update && !amdgpu_gmc_vram_full_visible(&adev->gmc)), "CPU update of VM recommended only for large BAR system\n"); vm->last_update = NULL; @@ -3136,7 +3136,7 @@ int amdgpu_vm_make_compute(struct amdgpu_device *adev, struct amdgpu_vm *vm, uns vm->pte_support_ats = pte_support_ats; DRM_DEBUG_DRIVER("VM update mode is %s\n", vm->use_cpu_for_update ? "CPU" : "SDMA"); - WARN_ONCE((vm->use_cpu_for_update & !amdgpu_gmc_vram_full_visible(&adev->gmc)), + WARN_ONCE((vm->use_cpu_for_update && !amdgpu_gmc_vram_full_visible(&adev->gmc)), "CPU update of VM recommended only for large BAR system\n"); if (vm->pasid) { -- 2.20.1

2 2

[BUG/REGRESSION] Radeon HDMI casuses oops on Acube Sam460ex amcc 460ex power board
by Julian Margetson 03 Jan '19

03 Jan '19

Kernels 4.03 and 4.04 oops with HDMI connection on Acube Sam460ex amcc 460ex powerpc board. 016a255b7835ee7e49a3eba3c14ba0bc0221a4f8 is the first bad commit commit 016a255b7835ee7e49a3eba3c14ba0bc0221a4f8 Author: Alex Deucher <alexander.deucher(a)amd.com> Date: Tue Apr 7 09:52:42 2015 -0400 drm/radeon: only mark audio as connected if the monitor supports it (v3) commit 0f55db36d49d45b80eff0c0a2a498766016f458b upstream. Otherwise the driver may try and send audio which may confuse the monitor. v2: set pin to NULL if no audio v3: avoid crash with analog encoders Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> :040000 040000 de0366a6790f5c91d175bcb89cb34956bbe72b26 bbdb5734961f824558152c7c34a840c78bc3a9a9 M drivers [ 2.587570] Linux agpgart interface v0.103 [ 2.591997] [drm] Initialized drm 1.1.0 20060810 [ 2.596892] [drm] radeon kernel modesetting enabled. [ 2.602989] [drm] initializing kernel modesetting (VERDE 0x1002:0x683F 0x1545:0x7750). [ 2.611161] [drm] register mmio base: 0xe90000000 [ 2.615935] [drm] register mmio size: 262144 [ 2.952043] ATOM BIOS: C44501 [ 2.955323] radeon 0001:81:00.0: VRAM: 1024M 0x0000000000000000 - 0x000000003FFFFFFF (1024M used) [ 2.964253] radeon 0001:81:00.0: GTT: 1024M 0x0000000040000000 - 0x000000007FFFFFFF [ 2.971938] [drm] Detected VRAM RAM=1024M, BAR=256M [ 2.976840] [drm] RAM width 128bits DDR [ 2.980898] [TTM] Zone kernel: Available graphics memory: 379358 kiB [ 2.987383] [TTM] Zone highmem: Available graphics memory: 1034718 kiB [ 2.993934] [TTM] Initializing pool allocator [ 2.998331] [TTM] Initializing DMA pool allocator [ 3.003153] [drm] radeon: 1024M of VRAM memory ready [ 3.008162] [drm] radeon: 1024M of GTT memory ready. [ 3.013203] [drm] Loading verde Microcode [ 3.017266] [drm] Internal thermal controller with fan control [ 3.023437] [drm] probing gen 2 caps for device aaa1:bed1 = 18cc41/0 [ 3.077284] [drm] radeon: dpm initialized [ 3.081503] [drm] GART: num cpu pages 262144, num gpu pages 262144 [ 3.093142] [drm] probing gen 2 caps for device aaa1:bed1 = 18cc41/0 [ 3.125984] [drm] PCIE GART of 1024M enabled (table at 0x0000000000277000). [ 3.133327] radeon 0001:81:00.0: WB enabled [ 3.137565] radeon 0001:81:00.0: fence driver on ring 0 use gpu addr 0x0000000040000c00 and cpu addr 0xffc01c00 [ 3.147697] radeon 0001:81:00.0: fence driver on ring 1 use gpu addr 0x0000000040000c04 and cpu addr 0xffc01c04 [ 3.157827] radeon 0001:81:00.0: fence driver on ring 2 use gpu addr 0x0000000040000c08 and cpu addr 0xffc01c08 [ 3.167957] radeon 0001:81:00.0: fence driver on ring 3 use gpu addr 0x0000000040000c0c and cpu addr 0xffc01c0c [ 3.178078] radeon 0001:81:00.0: fence driver on ring 4 use gpu addr 0x0000000040000c10 and cpu addr 0xffc01c10 [ 3.209673] radeon 0001:81:00.0: fence driver on ring 5 use gpu addr 0x0000000000075a18 and cpu addr 0xf90b5a18 [ 3.219822] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [ 3.226457] [drm] Driver supports precise vblank timestamp query. [ 3.232584] radeon 0001:81:00.0: radeon: MSI limited to 32-bit [ 3.238466] ppc4xx_setup_msi_irqs: fail allocating msi interrupt [ 3.244586] [drm] radeon: irq initialized. [ 4.006339] [drm:r600_ring_test] *ERROR* radeon: ring 0 test failed (scratch(0x850C)=0xCAFEDEAD) [ 4.015198] radeon 0001:81:00.0: disabling GPU acceleration [ 4.220071] [drm] Radeon Display Connectors [ 4.224651] [drm] Connector 0: [ 4.227787] [drm] HDMI-A-1 [ 4.230754] [drm] HPD4 [ 4.233328] [drm] DDC: 0x6570 0x6570 0x6574 0x6574 0x6578 0x6578 0x657c 0x657c [ 4.240806] [drm] Encoders: [ 4.243815] [drm] DFP1: INTERNAL_UNIPHY2 [ 4.248131] [drm] Connector 1: [ 4.251227] [drm] DVI-I-1 [ 4.254051] [drm] HPD2 [ 4.256608] [drm] DDC: 0x6560 0x6560 0x6564 0x6564 0x6568 0x6568 0x656c 0x656c [ 4.264034] [drm] Encoders: [ 4.267021] [drm] DFP2: INTERNAL_UNIPHY [ 4.271223] [drm] CRT1: INTERNAL_KLDSCP_DAC1 [ 4.390562] [drm] fb mappable at 0x80478000 [ 4.394789] [drm] vram apper at 0x80000000 [ 4.398905] [drm] size 8294400 [ 4.401978] [drm] fb depth is 24 [ 4.405225] [drm] pitch is 7680 [ 4.700581] Console: switching to colour frame buffer device 240x67 [ 4.779669] radeon 0001:81:00.0: fb0: radeondrmfb frame buffer device [ 4.786489] radeon 0001:81:00.0: registered panic notifier [ 4.796803] [drm] Initialized radeon 2.41.0 20080528 for 0001:81:00.0 on minor 0 [ 31.191562] Unable to handle kernel paging request for data at address 0x00000008 [ 31.258832] Faulting instruction address: 0xc04a51bc [ 34.049506] Oops: Kernel access of bad area, sig: 11 [#1] [ 34.055246] PREEMPT Canyonlands [ 34.058586] Modules linked in: [ 34.061830] CPU: 0 PID: 1998 Comm: Xorg Not tainted 4.0.3-Sam460ex #2 [ 34.068633] task: edee4c60 ti: ede8a000 task.ti: ede8a000 [ 34.074334] NIP: c04a51bc LR: c04a546c CTR: c03e5050 [ 34.079578] REGS: ede8bc30 TRAP: 0300 Not tainted (4.0.3-Sam460ex) [ 34.086381] MSR: 00029000 <CE,EE,ME> CR: 20004422 XER: 00000000 [ 34.092944] DEAR: 00000008 ESR: 00000000 GPR00: c04a5438 ede8bce0 edee4c60 eea84000 00000000 00000000 c0710000 00000000 GPR08: 00000000 00000000 eeac0400 ede8bce0 20004444 b7a55afc b80efab0 b80ee530 GPR16: 00000000 ffffffff 6f23c730 ede8be18 c03add44 eeac0578 00000001 00004000 GPR24: 00004000 c0719b98 fffffff2 00000001 eeb61200 eea84000 eea8df00 00000000 [ 34.127485] NIP [c04a51bc] radeon_audio_enable+0x4/0x18 [ 34.133000] LR [c04a546c] radeon_audio_detect+0xd4/0x104 [ 34.138604] Call Trace: [ 34.141185] [ede8bce0] [c04a5438] radeon_audio_detect+0xa0/0x104 (unreliable) [ 34.148771] [ede8bd00] [c03e6958] radeon_dvi_detect+0x390/0x3b4 [ 34.155046] [ede8bd30] [c0391cec] drm_helper_probe_single_connector_modes_merge_bits+0xf4/0x448 [ 34.164253] [ede8bd70] [c03ade28] drm_mode_getconnector+0xe4/0x334 [ 34.170796] [ede8be10] [c03a0be8] drm_ioctl+0x348/0x464 [ 34.176343] [ede8bed0] [c00ce2e8] do_vfs_ioctl+0x52c/0x6e8 [ 34.182158] [ede8bf20] [c00ce4e4] SyS_ioctl+0x40/0x68 [ 34.187515] [ede8bf40] [c000ab1c] ret_from_syscall+0x0/0x3c [ 34.193417] --- interrupt: c01 at 0x6fb001dc [ 34.193417] LR = 0x6fb00100 [ 34.201216] Instruction dump: [ 34.204368] 8129012c 806a0018 2f890000 419e0018 81290004 2f890000 419e000c 7d2903a6 [ 34.212674] 4e800420 38600000 4e800020 81231cd8 <81290008> 2f890000 4d9e0020 7d2903a6 [ 34.376219] ---[ end trace 803e15e46b991816 ]--- [ 34.380843] * Starting Mount filesystems on boot[ OK ] *

6 26

[Bug 109122] blank screen on rx580 starting with kernel 4.19.9
by bugzilla-daemon＠freedesktop.org 03 Jan '19

03 Jan '19

https://bugs.freedesktop.org/show_bug.cgi?id=109122 Bug ID: 109122 Summary: blank screen on rx580 starting with kernel 4.19.9 Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: critical Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: velemas(a)gmail.com After upgrading to kernel 4.19.9 in Arch Linux I have a blank screen. The system is unusable. My system is Asus ROG GL702ZC with RX 580: lspci output: description: VGA compatible controller product: Ellesmere [Radeon RX 470/480/570/570X/580/580X] vendor: Advanced Micro Devices, Inc. [AMD/ATI] physical id: 0 bus info: pci@0000:0c:00.0 version: c1 width: 64 bits clock: 33MHz capabilities: vga_controller bus_master cap_list rom configuration: driver=amdgpu latency=0 dmesg: [drm] initializing kernel modesetting (POLARIS10 0x1002:0x67DF 0x1043:0x1A60 0xC1). The culprit is https://github.com/torvalds/linux/commit/07e3a1cfb0568b6d8d7862077029af96af… Reverting it fixed the issue. I also tried 4.20-rc7. There is no issue there. But 4.19.11 still has it. Setting amdgpu.dc=0 also helps with 4.19.9 - 4.19.11 Related https://bugs.archlinux.org/task/61117 -- You are receiving this mail because: You are the assignee for the bug.

1 6

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2019