dri-devel August 2019

dri-devel@lists.freedesktop.org

318 participants
2338 discussions

[Bug 111479] too much clutter
by bugzilla-daemon＠freedesktop.org 24 Aug '19

24 Aug '19

1 0

Re: next/master build: 218 builds: 4 failed, 214 passed, 10 errors, 786 warnings (next-20190823)
by Stephen Rothwell 24 Aug '19

24 Aug '19

Hi all, On Fri, 23 Aug 2019 17:00:39 -0700 (PDT) "kernelci.org bot" <bot(a)kernelci.org> wrote: > > 2 drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:8: error: implicit declaration of function 'dma_set_max_seg_size'; did you mean 'drm_rect_adjust_size'? [-Werror=implicit-function-declaration] > 2 drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:52: error: implicit declaration of function 'DMA_BIT_MASK'; did you mean 'BIT_MASK'? [-Werror=implicit-function-declaration] > 1 drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:8: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] > 1 drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:8: error: implicit declaration of function 'dma_set_max_seg_size' [-Werror,-Wimplicit-function-declaration] > 1 drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:52: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] > 1 drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:52: error: implicit declaration of function 'DMA_BIT_MASK' [-Werror,-Wimplicit-function-declaration] Caused by commit 070955558e82 ("drm/mediatek: set DMA max segment size") (from the drm-fixes tree) which should have included linux/dma-mapping.h -- Cheers, Stephen Rothwell

2 2

[PATCH v8 0/5] DMA-BUF Heaps (destaging ION)
by John Stultz 23 Aug '19

23 Aug '19

Here is yet another pass at the dma-buf heaps patchset Andrew and I have been working on which tries to destage a fair chunk of ION functionality. The patchset implements per-heap devices which can be opened directly and then an ioctl is used to allocate a dmabuf from the heap. The interface is similar, but much simpler then IONs, only providing an ALLOC ioctl. Also, I've provided relatively simple system and cma heaps. I've booted and tested these patches with AOSP on the HiKey960 using the kernel tree here: https://git.linaro.org/people/john.stultz/android-dev.git/log/?h=dev/dma-bu… And the userspace changes here: https://android-review.googlesource.com/c/device/linaro/hikey/+/909436 Compared to ION, this patchset is missing the system-contig, carveout and chunk heaps, as I don't have a device that uses those, so I'm unable to do much useful validation there. Additionally we have no upstream users of chunk or carveout, and the system-contig has been deprecated in the common/andoid-* kernels, so this should be ok. I've also removed the stats accounting, since any such accounting should be implemented by dma-buf core or the heaps themselves. Most of the changes in this revision are adddressing the more concrete feedback from Christoph (many thanks!). Though I'm not sure if some of the less specific feedback was completely resolved in discussion last time around. Please let me know! New in v8: * Make struct dma_heap_ops consts (Suggested by Christoph) * Add flush_kernel_vmap_range/invalidate_kernel_vmap_range calls (suggested by Christoph) * Condense dma_heap_buffer and heap_helper_buffer (suggested by Christoph) * Get rid of needless struct system_heap (suggested by Christoph) * Fix indentation by using shorter argument names (suggested by Christoph) * Remove unused private_flags value * Add forgotten include file to fix build issue on x86 * Checkpatch whitespace fixups Thoughts and feedback would be greatly appreciated! thanks -john Cc: Laura Abbott <labbott(a)redhat.com> Cc: Benjamin Gaignard <benjamin.gaignard(a)linaro.org> Cc: Sumit Semwal <sumit.semwal(a)linaro.org> Cc: Liam Mark <lmark(a)codeaurora.org> Cc: Pratik Patel <pratikp(a)codeaurora.org> Cc: Brian Starkey <Brian.Starkey(a)arm.com> Cc: Vincent Donnefort <Vincent.Donnefort(a)arm.com> Cc: Sudipto Paul <Sudipto.Paul(a)arm.com> Cc: Andrew F. Davis <afd(a)ti.com> Cc: Christoph Hellwig <hch(a)infradead.org> Cc: Chenbo Feng <fengc(a)google.com> Cc: Alistair Strachan <astrachan(a)google.com> Cc: Hridya Valsaraju <hridya(a)google.com> Cc: dri-devel(a)lists.freedesktop.org Andrew F. Davis (1): dma-buf: Add dma-buf heaps framework John Stultz (4): dma-buf: heaps: Add heap helpers dma-buf: heaps: Add system heap to dmabuf heaps dma-buf: heaps: Add CMA heap to dmabuf heaps kselftests: Add dma-heap test MAINTAINERS | 18 ++ drivers/dma-buf/Kconfig | 11 + drivers/dma-buf/Makefile | 2 + drivers/dma-buf/dma-heap.c | 250 ++++++++++++++++ drivers/dma-buf/heaps/Kconfig | 14 + drivers/dma-buf/heaps/Makefile | 4 + drivers/dma-buf/heaps/cma_heap.c | 164 +++++++++++ drivers/dma-buf/heaps/heap-helpers.c | 269 ++++++++++++++++++ drivers/dma-buf/heaps/heap-helpers.h | 55 ++++ drivers/dma-buf/heaps/system_heap.c | 122 ++++++++ include/linux/dma-heap.h | 59 ++++ include/uapi/linux/dma-heap.h | 55 ++++ tools/testing/selftests/dmabuf-heaps/Makefile | 9 + .../selftests/dmabuf-heaps/dmabuf-heap.c | 230 +++++++++++++++ 14 files changed, 1262 insertions(+) create mode 100644 drivers/dma-buf/dma-heap.c create mode 100644 drivers/dma-buf/heaps/Kconfig create mode 100644 drivers/dma-buf/heaps/Makefile create mode 100644 drivers/dma-buf/heaps/cma_heap.c create mode 100644 drivers/dma-buf/heaps/heap-helpers.c create mode 100644 drivers/dma-buf/heaps/heap-helpers.h create mode 100644 drivers/dma-buf/heaps/system_heap.c create mode 100644 include/linux/dma-heap.h create mode 100644 include/uapi/linux/dma-heap.h create mode 100644 tools/testing/selftests/dmabuf-heaps/Makefile create mode 100644 tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c -- 2.17.1

1 5

[PATCH v4] drm/i915: Call dma_set_max_seg_size() in i915_driver_hw_probe()
by Lyude Paul 23 Aug '19

23 Aug '19

Currently, we don't call dma_set_max_seg_size() for i915 because we intentionally do not limit the segment length that the device supports. However, this results in a warning being emitted if we try to map anything larger than SZ_64K on a kernel with CONFIG_DMA_API_DEBUG_SG enabled: [ 7.751926] DMA-API: i915 0000:00:02.0: mapping sg segment longer than device claims to support [len=98304] [max=65536] [ 7.751934] WARNING: CPU: 5 PID: 474 at kernel/dma/debug.c:1220 debug_dma_map_sg+0x20f/0x340 This was originally brought up on https://bugs.freedesktop.org/show_bug.cgi?id=108517 , and the consensus there was it wasn't really useful to set a limit (and that dma-debug isn't really all that useful for i915 in the first place). Unfortunately though, CONFIG_DMA_API_DEBUG_SG is enabled in the debug configs for various distro kernels. Since a WARN_ON() will disable automatic problem reporting (and cause any CI with said option enabled to start complaining), we really should just fix the problem. Note that as me and Chris Wilson discussed, the other solution for this would be to make DMA-API not make such assumptions when a driver hasn't explicitly set a maximum segment size. But, taking a look at the commit which originally introduced this behavior, commit 78c47830a5cb ("dma-debug: check scatterlist segments"), there is an explicit mention of this assumption and how it applies to devices with no segment size: Conversely, devices which are less limited than the rather conservative defaults, or indeed have no limitations at all (e.g. GPUs with their own internal MMU), should be encouraged to set appropriate dma_parms, as they may get more efficient DMA mapping performance out of it. So unless there's any concerns (I'm open to discussion!), let's just follow suite and call dma_set_max_seg_size() with UINT_MAX as our limit to silence any warnings. Changes since v3: * Drop patch for enabling CONFIG_DMA_API_DEBUG_SG in CI. It looks like just turning it on causes the kernel to spit out bogus WARN_ONs() during some igt tests which would otherwise require teaching igt to disable the various DMA-API debugging options causing this. This is too much work to be worth it, since DMA-API debugging is useless for us. So, we'll just settle with this single patch to squelch WARN_ONs() during driver load for users that have CONFIG_DMA_API_DEBUG_SG turned on for some reason. * Move dma_set_max_seg_size() call into i915_driver_hw_probe() - Chris Wilson Signed-off-by: Lyude Paul <lyude(a)redhat.com> Reviewed-by: Chris Wilson <chris(a)chris-wilson.co.uk> Cc: <stable(a)vger.kernel.org> # v4.18+ --- drivers/gpu/drm/i915/i915_drv.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index b5b2a64753e6..020696726f9e 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -1279,6 +1279,12 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv) pci_set_master(pdev); + /* + * We don't have a max segment size, so set it to the max so sg's + * debugging layer doesn't complain + */ + dma_set_max_seg_size(&pdev->dev, UINT_MAX); + /* overlay on gen2 is broken and can't address above 1G */ if (IS_GEN(dev_priv, 2)) { ret = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(30)); -- 2.21.0

1 0

[pull] amdgpu drm-next-5.4
by Alex Deucher 23 Aug '19

23 Aug '19

Hi Dave, Daniel, A few new bits for 5.4, mostly ongoing new asic support. This is pretty much it for 5.4. We have a few patches for display enablement of renoir which should be out next week (just wrapping up IP review). The following changes since commit e7f7287bf5f746d29f3607178851246a005dd398: Merge tag 'drm-next-5.4-2019-08-09' of git://people.freedesktop.org/~agd5f/linux into drm-next (2019-08-12 14:20:21 +1000) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux tags/drm-next-5.4-2019-08-23 for you to fetch changes up to b4d857ded1c50fb2bd1168d6f80ae81397ae468b: drm/amd/display: 3.2.48 (2019-08-23 11:46:12 -0500) ---------------------------------------------------------------- drm-next-5.4-2019-08-23: amdgpu: - Enable power features on Navi12 - Enable power features on Arcturus - RAS updates - Initial Renoir APU support - Enable power featyres on Renoir - DC gamma fixes - DCN2 fixes - GPU reset support for Picasso - Misc cleanups and fixes scheduler: - Possible race fix ---------------------------------------------------------------- Aaron Liu (23): drm/amdgpu: fix no interrupt issue for renoir emu drm/amdgpu: enable dce virtual ip module for Renoir drm/amdgpu: add asic funcs for renoir drm/amdgpu: set rlc funcs for renoir drm/amdgpu: add psp_v12_0 for renoir (v2) drm/amdgpu: enable clock gating for renoir drm/amdgpu: enable power gating for renoir drm/amdgpu: update lbpw for renoir drm/amdgpu: set fw default loading by psp for renoir drm/amd/powerplay: add smu12_driver_if.h (v3) drm/amdgpu/powerplay: add initial renoir_ppt.c for renoir (v3) drm/amdgpu/powerplay: add smu_v12_0.c & smu_v12_0.h for renoir drm/amdgpu/powerplay: add smu ip block for renoir (v2) drm/amdgpu/powerplay: add power up/down SDMA interfaces for renoir drm/amd/powerplay: udpate smu_v12_0_check_fw_version (v2) drm/amdgpu: add set_gfx_cgpg implement (v2) drm/amdgpu: add and enable gfxoff feature drm/amd/powerplay: fix checking gfxoff status for rn drm/amd/powerplay: using valid mapping check for rn drm/amd/powerplay: add smu tables for rn drm/amd/powerplay: init smu tables for rn drm/amd/powerplay: add DPMCLOCKS table implementation drm/amdgpu: update gc/sdma goldensetting for rn Ahmad Othman (1): drm/amd/display: Refactoring VTEM Ahzo (1): drm/amd/powerplay/smu7: enforce minimal VBITimeout (v2) Alex Deucher (11): drm/amdgpu: add navi14 PCI ID drm/amd/display: use kvmalloc for dc_state (v2) drm/amdgpu: flag renoir as experimental for now drm/amdgpu/gfx9: update pg_flags after determining if gfx off is possible drm/amdgpu/powerplay: silence a warning in smu_v11_0_setup_pptable drm/amdgpu/powerplay: Add smu_v12_0_ppsmc.h (v2) drm/amdgpu/powerplay/smu7: enable mclk switching if monitors are synced drm/amdgpu/powerplay/vega10: enable mclk switching if monitors are synced drm/amd/display: update bw_calcs to take pipe sync into account (v3) drm/amdgpu/display: add flag for multi-display mclk switching drm/amdgpu: set adev->num_vmhubs for gmc6,7,8 Andrey Grodzovsky (6): dmr/amdgpu: Fix compile error with CONFIG_DRM_AMDGPU_GART_DEBUGFS drm/amd/powerplay: Fix meaning of 0x1E PPSMC_MSG drm/amd/powerplay: add mode2 reset callback for pp_smu_mgr drm/amd/powerpay: Implement mode2 reset callback for SMU10 drm/amd/poweplay: Add amd_pm_funcs callback for mode 2 drm/amdgpu: Use new mode2 reset interface for RV. Anthony Koo (5): drm/amd/display: fix issue where 252-255 values are clipped drm/amd/display: 3.2.45 drm/amd/display: 3.2.46 drm/amd/display: 3.2.47 drm/amd/display: 3.2.48 Aric Cyr (2): drm/amd/display: 3.2.43 drm/amd/display: 3.2.44 Bayan Zabihiyan (3): drm/amd/display: Fix frames_to_insert math drm/amd/display: add Cursor Degamma logic for DCN2 drm/amd/display: Expose OTG_V_TOTAL_MID for HW Diags Charlene Liu (4): drm/amd/display: wake up ogam mem pwr before programming ocsc drm/amd/display: enable dcn_mem_pwr as golden setting updates drm/amd/display: support spdif drm/amd/display: set av_mute in hw_init for HDMI Chengming Gui (2): drm/amd/powerplay: remove redundancy debug log about smu unsupported features drm/amd/powerplay: add arcturus_is_dpm_running function for arcturus Christian König (2): drm/scheduler: use job count instead of peek drm/amdgpu: fix dma_fence_wait without reference Christoph Hellwig (4): drm/radeon: handle PCIe root ports with addressing limitations drm/amdgpu: handle PCIe root ports with addressing limitations drm/radeon: simplify and cleanup setting the dma mask drm/amdgpu: simplify and cleanup setting the dma mask Christophe JAILLET (2): drm/amd/display: Fix a typo - dce_aduio_mask --> dce_audio_mask drm/amdgpu: Fix a typo in the include header guard of 'navi12_ip_offset.h' Colin Ian King (4): drm/amd/powerplay: remove redundant duplicated return check drm/amdgpu/powerplay: fix spelling mistake "unsuported" -> "unsupported" drm/amdgpu/powerplay: remove redundant assignment to variable baco_state drm/amd/display: fix a potential null pointer dereference David Francis (7): drm/amd/display: Remove drm_dsc_dc.c Revert "drm/amd/display: skip dsc config for navi10 bring up" Revert "drm/amd/display: navi10 bring up skip dsc encoder config" Revert "drm/amd/display: add global master update lock for DCN2" Revert "drm/amd/display: Fix underscan not using proper scaling" drm/amd/display: Enable SST DSC in DM drm/amd/display: MST topology debugfs David Galiffi (1): drm/amd/display: Synchronous DisplayPort Link Training Derek Lai (1): drm/amd/display: Use res_cap to acquire i2c instead of pipe count Dmytro Laktyushkin (10): drm/amd/display: make firmware info only load once during dc_bios create drm/amd/display: update optc odm interface for more than 2 opps drm/amd/display: fix dcn20 global sync dml param extraction drm/amd/display: fix calc_pll_max_vco_construct drm/amd/display: re structure odm to allow 4 to 1 support drm/amd/display: fix dp stream enable drm/amd/display: fix odm pipe copy drm/amd/display: fix dcn20 odm dpp programming drm/amd/display: fix odm stream release drm/amd/display: fix odm validation Eric Yang (1): drm/amd/display: Enable type C hotplug Evan Quan (6): drm/amd/powerplay: update Arcturus smc fw and driver interface header drm/amd/powerplay: expose supported clock domains only through sysfs drm/amd/powerplay: get bootup fclk value drm/amd/powerplay: set Arcturus default fclk as bootup value on dpm disabled drm/amd/powerplay: correct SW smu11 thermal range settings drm/amd/powerplay: correct typo Feifei Xu (1): drm/amdgpu: Set no-retry as default. Frank.Min (4): drm/amdgpu: disable agp for sriov drm/amdgpu: unity mc base address for arcturus amd/amdgpu: add Arcturus vf DID support amd/amdkfd: add Arcturus vf DID support Gang Ba (1): drm/amd/amdgpu: Update VM function pointer Guchun Chen (2): drm/amdgpu: add check to avoid array bound issue drm/amdgpu: correct ras error count type Huang Rui (16): drm/amdgpu: add renoir header files (v2) drm/amdgpu: add renoir asic_type enum drm/amdgpu: add renoir support for gpu_info and ip block setting drm/amdgpu: add soc15 common ip block support for renoir drm/amdgpu: add gmc v9 supports for renoir drm/amdgpu: set fw load type for renoir drm/amdgpu: add gfx support for renoir drm/amdgpu: add sdma support for renoir drm/amdgpu: set ip blocks for renoir drm/amdgpu: add renoir pci id drm/amdgpu: add gfx golden settings for renoir (v2) drm/amdgpu: add sdma golden settings for renoir drm/amdgpu: use direct loading on renoir vcn for the moment drm/amdgpu: skip mec2 jump table loading for renoir drm/amdgpu: skip dpm init for renoir drm/amd/powerplay: powerup sdma/vcn for all apu series Ilya Bakoulin (4): drm/amd/display: Update DML parameters drm/amd/display: HUBP/HUBBUB register programming fixes drm/amd/display: Fix type of ODMCombineType field drm/amd/display: set Hratio and VRatio in dml Jaehyun Chung (3): drm/amd/display: Add work-around option to skip DCN20 clock updates drm/amd/display: Add VM page fault handle implementation drm/amd/display: Enable HW rotation Joseph Gravenor (1): drm/amd/display: Implement voltage limitation stub Joshua Aberback (1): drm/amd/display: Properly read LVTMA_PWRSEQ_CNTL Josip Pavic (1): drm/amd/display: load iram for abm 2.3 Julian Parkin (4): drm/amd/display: Improve sharing of HUBBUB register lists drm/amd/display: Remove duplicate interface for programming FB drm/amd/display: Remove redundant definition of dwb_source enums drm/amd/display: Delete dead code in command_table_helper Jun Lei (6): drm/amd/display: fixup DPP programming sequence drm/amd/display: wait for pending complete when enabling a plane drm/amd/display: clean up DML for DCN2x drm/amd/display: fix pipe selection logic in validate drm/amd/display: fix DML not calculating delivery time drm/amd/display: revert wait in pipelock Kenneth Feng (2): drm/amd/powerplay: change smu_read_sensor sequence in smu drm/amd/amdgpu: disable MMHUB PG for navi10 Kent Russell (2): drm/powerplay: Fix Vega20 Average Power value v4 drm/powerplay: Fix Vega20 power reading again Kevin Wang (7): drm/amd/powerplay: fix message of SetHardMinByFreq failed when feature is disabled drm/amdgpu: fix typo error amdgput -> amdgpu drm/amdgpu: use exiting amdgpu_ctx_total_num_entities function drm/amd/powerplay: add smu_smc_read_sensor support for arcturus drm/amd/powerplay: fix variable type errors in smu_v11_0_setup_pptable drm/amd/powerplay: remove duplicate macro smu_get_uclk_dpm_states in amdgpu_smu.h drm/amd/powerpaly: fix navi series custom peak level value error Le Ma (13): drm/amdgpu: add gfx clock gating for Arcturus drm/amdgpu: enable gfx clock gating for Arcturus drm/amdgpu: add hdp clock gating for Arcturus drm/amdgpu: enable hdp clock gating for Arcturus drm/amdgpu: support sdma clock gating for more instances drm/amdgpu: add sdma clock gating for Arcturus drm/amdgpu: enable sdma clock gating for Arcturus drm/amdgpu: split athub clock gating from mmhub drm/amdgpu: add GFX_CP_LS flag to Arcturus drm/amdgpu: increase CGCG gfx idle threshold for Arcturus drm/amdgpu: add mmhub clock gating for Arcturus drm/amdgpu: enable mmhub clock gating for Arcturus drm/amdgpu/powerplay: update Arcturus smu version in new place Leo Li (1): drm/amd/display: Load NV12 SOC BB from firmware Leo Liu (4): drm/amdgpu: enable Renoir VCN firmware loading drm/amdgpu: enable Doorbell support for Renoir (v2) drm/amdgpu: add VCN2.0 to Renoir IP blocks drm/amdgpu/powerplay: add Renoir VCN power management Lewis Huang (1): drm/amd/display: reprogram VM config when system resume Marek Olšák (1): Revert "drm/amdgpu: fix transform feedback GDS hang on gfx10 (v2)" Martin Leung (4): drm/amd/display: Make init_hw and init_pipes generic for seamless boot drm/amd/display: fix dcn-specific clk_mgr init_clocks drm/amd/display: enabling seamless boot sequence for dcn2 drm/amd/display: cleaned up coding error in init_hw Michael Strauss (1): drm/amd/display: Enable MPO with pre-blend color processing (RGB) Michel Dänzer (1): drm/amdgpu: Update pitch on page flips without DC as well Nathan Chancellor (1): drm/amd/display: Fix 32-bit divide error in wait_for_alt_mode Nicholas Kazlauskas (6): drm/amd/display: Register VUPDATE_NO_LOCK interrupts for DCN2 drm/amd/display: Calculate bpc based on max_requested_bpc drm/amd/display: Check return code for CRC drm_crtc_vblank_get drm/amd/display: Use connector list for finding DPRX CRC aux drm/amd/display: Split out DC programming for CRC capture drm/amd/display: Lock the CRTC when setting CRC source Nicolai Hähnle (1): drm/amdgpu: prevent memory leaks in AMDGPU_CS ioctl Nikola Cornij (7): drm/amd/display: Change DSC policy from slices per column to minimum slice height drm/amd/display: Set DSC before DIG front-end is connected to its back-end drm/amd/display: Remove 4:2:2 DSC support drm/amd/display: Correct DSC PPS log drm/amd/display: Add and refine DSC logs in enable sequence drm/amd/display: Zero-out dsc init regs drm/amd/display: Fix number of slices not being checked for dsc Oak Zeng (2): drm/amdgpu: Export function to flush TLB of specific vm hub drm/amdkfd/gfx10: Calling amdgpu functions to invalidate TLB Pierre-Eric Pelloux-Prayer (1): drm/amdgpu: fix gfx9 soft recovery Prike Liang (15): drm/amdgpu: enable gfx clock gating for rn drm/amdgpu: enable mmhub clock gating for rn drm/amdgpu: enable sdma clock gating for rn drm/amdgpu: enable BIF clock gating for rn drm/amdgpu: enable HDP clock gating for rn drm/amdgpu: enable rom clock gating for rn drm/amdgpu: enable vcn clock gating for rn drm/amdgpu: enable IH clock gating for rn drm/amdgpu: enable athub clock gating for rn drm/amdgpu: enable DF clock gating for rn drm/amdgpu/mmhub1: set mmhub clock gating for rn drm/amdgpu/sdma4: set sdma clock gating for rn drm/amdgpu: enable SDMA power gating for rn drm/amd/powerplay: enable renoir dpm feature drm/amd/powerplay: Disable renoir smu feature retrieve for the moment Qingqing Zhuo (3): drm/amd/display: Add enum for H-timing divider mode drm/amd/display: refactor Device ID for external chips drm/amd/display: remove unused function Stephen Rothwell (1): drm/amdgpu: MODULE_FIRMWARE requires linux/module.h Su Sung Chung (2): drm/amd/display: refactor gpio to allocate hw_container in constructor drm/amd/display: fix audio endpoint not getting disabled issue Tao Zhou (6): drm/amdgpu: add sub block parameter in ras inject command drm/amdgpu: add amdgpu_mmhub_funcs definition drm/amdgpu: support mmhub ras in amdgpu ras drm/amdgpu: create mmhub ras framework drm/amdgpu: remove ras block's feature status info in sysfs drm/amdgpu: implement querying ras error count for mmhub Thong Thai (2): Revert "drm/amdgpu: use direct loading on renoir vcn for the moment" drm/amdgpu: enable VCN DPG for Renoir Tianci.Yin (1): drm/amdgpu/psp: move TMR to cpu invisible vram region Vitaly Prosyak (3): drm/amd/display: Add 22, 24, and 26 degamma drm/amd/display: Add HLG support in color module drm/amd/display: Check if set_blank_data_double_buffer exists before call Wenjing Liu (3): drm/amd/display: reset drr programming on pipe reset drm/amd/display: reset hdmi tmds rate and data scramble on pipe reset drm/amd/display: check hpd before retry verify link cap Wyatt Wood (4): drm/amd/display: Add Logging for Gamma Related information (1/2) drm/amd/display: Add Logging for Gamma Related information (2/2) drm/amd/display: add null checks before logging drm/amd/display: Add Logging for Gamma Related information Xiaojie Yuan (15): drm/amdgpu: enable gfx clock gatings for navi12 drm/amdgpu: enable hdp clock gating for navi12 drm/amdgpu/sdma5: set sdma clock gating for navi12 drm/amdgpu: enable sdma clock gating for navi12 drm/amdgpu/mmhub2: set clock gating for navi12 drm/amdgpu: enable mmhub clock gating for navi12 drm/amdgpu: enable ih clock gating for navi12 drm/amdgpu/athub2: set clock gating for navi12 drm/amdgpu: enable athub clock gating for navi12 drm/amdgpu: enable vcn clock gating for navi12 drm/amdgpu: remove special autoload handling for navi12 drm/amdgpu: fix debug level for ppt offset/size drm/amdgpu: add firmware header printing for psp fw loading (v2) drm/amdgpu: remove redundant argument for psp_funcs::cmd_submit callback drm/amdgpu/sdma5: fix number of sdma5 trap irq types for navi1x Yogesh Mohan Marimuthu (1): drm/amd/display: fix trigger not generated for freesync Yong Zhao (5): drm/amdgpu: Add printing for RW extracted from VM_L2_PROTECTION_FAULT_STATUS drm/amdgpu: Add more page fault info printing for GFX10 drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0 for GFX10 drm/amdkfd: Fill amdgpu_task_info for KFD VMs drm/amdkfd: Fill the name field in node topology with asic name v2 Yongqiang Sun (2): drm/amd/display: Add PIXEL_RATE control regs for more instances drm/amd/display: Add DFS reference clock field YueHaibing (5): drm/amdgpu: remove set but not used variable 'psp_enabled' drm/amdgpu: remove duplicated include from gfx_v9_0.c drm/amd/display: remove duplicated include from dc_link.c drm/amdkfd: remove set but not used variable 'pdd' drm/amdkfd: Make deallocate_hiq_sdma_mqd static Zi Yu Liao (2): drm/amd/display: fix MPO HUBP underflow with Scatter Gather drm/amd/display: fix stuck test pattern on right half of display hersen wu (1): drm/amd/display: flicking observed while installing driver on Navi10 CF tiancyin (2): drm/amd/powerplay: re-define smu interface version for smu v11 drm/amd/powerplay: update smu11_driver_if_navi10.h yanyan kang (1): drm/amd/display: audio cannot switch to internal when display turns off drivers/gpu/drm/amd/amdgpu/Makefile | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c | 41 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 12 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 9 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 46 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 13 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 11 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gds.h | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 8 + drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 9 +- drivers/gpu/drm/amd/amdgpu/amdgpu_mmhub.h | 31 + drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 5 +- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 26 +- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 83 +- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 7 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 47 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 8 + drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 7 + drivers/gpu/drm/amd/amdgpu/athub_v1_0.c | 103 +++ drivers/gpu/drm/amd/amdgpu/athub_v1_0.h | 30 + drivers/gpu/drm/amd/amdgpu/athub_v2_0.c | 1 + drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 4 + drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 4 + drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 4 + drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 4 + drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 1 + drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 17 +- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 82 +- drivers/gpu/drm/amd/amdgpu/gfxhub_v2_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 70 +- drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 23 +- drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 28 +- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 28 +- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 253 +++--- drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 120 ++- drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.h | 2 + drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c | 3 +- drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c | 125 +++ drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.h | 3 + drivers/gpu/drm/amd/amdgpu/nbio_v7_0.c | 21 + drivers/gpu/drm/amd/amdgpu/nv.c | 22 +- drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 1 - drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 1 - drivers/gpu/drm/amd/amdgpu/psp_v12_0.c | 565 ++++++++++++++ drivers/gpu/drm/amd/amdgpu/psp_v12_0.h | 30 + drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 1 - drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 130 ++-- drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 4 +- drivers/gpu/drm/amd/amdgpu/soc15.c | 97 ++- drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 2 +- drivers/gpu/drm/amd/amdgpu/vega10_reg_init.c | 4 + drivers/gpu/drm/amd/amdkfd/kfd_device.c | 19 + .../gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 3 +- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 1 + drivers/gpu/drm/amd/amdkfd/kfd_process.c | 13 +- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 16 +- drivers/gpu/drm/amd/amdkfd/kfd_topology.h | 4 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 79 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 138 +++- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.h | 6 + .../drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 24 + .../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 4 +- drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 3 +- drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 3 +- .../dc/bios/dce110/command_table_helper_dce110.c | 36 +- .../dc/bios/dce112/command_table_helper2_dce112.c | 36 +- .../dc/bios/dce112/command_table_helper_dce112.c | 36 +- drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c | 33 +- drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.c | 10 +- .../amd/display/dc/clk_mgr/dce100/dce_clk_mgr.c | 17 +- .../drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr.c | 12 +- .../amd/display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c | 136 +++- drivers/gpu/drm/amd/display/dc/core/dc.c | 89 ++- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 180 ++--- drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c | 2 +- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 372 +++++++-- drivers/gpu/drm/amd/display/dc/core/dc_link_hwss.c | 179 +++-- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 277 +++---- drivers/gpu/drm/amd/display/dc/dc.h | 14 +- drivers/gpu/drm/amd/display/dc/dc_bios_types.h | 5 +- drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 3 + drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 5 +- drivers/gpu/drm/amd/display/dc/dc_link.h | 10 + drivers/gpu/drm/amd/display/dc/dce/dce_audio.c | 6 +- drivers/gpu/drm/amd/display/dc/dce/dce_audio.h | 6 +- .../gpu/drm/amd/display/dc/dce/dce_clock_source.c | 36 +- drivers/gpu/drm/amd/display/dc/dce/dce_hwseq.h | 68 +- drivers/gpu/drm/amd/display/dc/dce/dce_i2c_hw.c | 16 +- .../drm/amd/display/dc/dce/dce_stream_encoder.c | 31 + .../drm/amd/display/dc/dce100/dce100_resource.c | 6 +- .../amd/display/dc/dce110/dce110_hw_sequencer.c | 67 +- .../amd/display/dc/dce110/dce110_hw_sequencer.h | 10 +- .../drm/amd/display/dc/dce110/dce110_resource.c | 6 +- .../drm/amd/display/dc/dce112/dce112_resource.c | 2 +- .../drm/amd/display/dc/dce120/dce120_resource.c | 2 +- .../gpu/drm/amd/display/dc/dce80/dce80_resource.c | 14 +- .../gpu/drm/amd/display/dc/dcn10/dcn10_cm_common.c | 7 +- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c | 16 +- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.h | 2 +- .../gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c | 4 +- .../gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.h | 8 +- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c | 2 +- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.h | 26 +- .../drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 352 +++++++-- .../drm/amd/display/dc/dcn10/dcn10_link_encoder.c | 72 +- .../drm/amd/display/dc/dcn10/dcn10_link_encoder.h | 3 + drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mpc.c | 19 + drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mpc.h | 4 + drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c | 25 +- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.h | 14 +- .../gpu/drm/amd/display/dc/dcn10/dcn10_resource.c | 10 +- .../amd/display/dc/dcn10/dcn10_stream_encoder.c | 26 + .../amd/display/dc/dcn10/dcn10_stream_encoder.h | 6 + drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dccg.c | 31 +- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dccg.h | 2 +- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dpp.c | 26 +- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dpp.h | 21 +- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dsc.c | 122 +-- .../gpu/drm/amd/display/dc/dcn20/dcn20_hubbub.c | 88 ++- .../gpu/drm/amd/display/dc/dcn20/dcn20_hubbub.h | 16 +- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hubp.c | 96 +-- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hubp.h | 18 +- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 561 ++++++------- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.h | 2 +- .../drm/amd/display/dc/dcn20/dcn20_link_encoder.c | 1 + drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c | 6 +- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.h | 6 +- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_opp.c | 1 - drivers/gpu/drm/amd/display/dc/dcn20/dcn20_optc.c | 95 +-- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_optc.h | 7 +- .../gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 746 +++++++++++------- .../amd/display/dc/dcn20/dcn20_stream_encoder.c | 37 +- .../display/dc/dml/dcn20/display_mode_vba_20v2.c | 27 + .../drm/amd/display/dc/dml/display_mode_enums.h | 22 +- .../drm/amd/display/dc/dml/display_mode_structs.h | 3 + .../gpu/drm/amd/display/dc/dml/display_mode_vba.c | 13 + .../gpu/drm/amd/display/dc/dml/display_mode_vba.h | 18 + drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 71 +- drivers/gpu/drm/amd/display/dc/dsc/drm_dsc_dc.c | 453 ----------- .../amd/display/dc/gpio/dce110/hw_factory_dce110.c | 18 +- .../amd/display/dc/gpio/dce120/hw_factory_dce120.c | 14 +- .../amd/display/dc/gpio/dce80/hw_factory_dce80.c | 14 +- .../amd/display/dc/gpio/dcn10/hw_factory_dcn10.c | 12 +- .../amd/display/dc/gpio/dcn20/hw_factory_dcn20.c | 12 +- .../display/dc/gpio/diagnostics/hw_factory_diag.c | 9 +- drivers/gpu/drm/amd/display/dc/gpio/gpio_base.c | 74 +- drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c | 51 +- drivers/gpu/drm/amd/display/dc/gpio/gpio_service.h | 6 +- drivers/gpu/drm/amd/display/dc/gpio/hw_ddc.c | 26 +- drivers/gpu/drm/amd/display/dc/gpio/hw_ddc.h | 5 +- drivers/gpu/drm/amd/display/dc/gpio/hw_factory.h | 48 +- drivers/gpu/drm/amd/display/dc/gpio/hw_generic.c | 32 +- drivers/gpu/drm/amd/display/dc/gpio/hw_generic.h | 6 +- drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c | 31 +- drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.h | 5 +- drivers/gpu/drm/amd/display/dc/inc/core_types.h | 11 +- drivers/gpu/drm/amd/display/dc/inc/dc_link_dp.h | 11 +- .../drm/amd/display/dc/inc/hw/clk_mgr_internal.h | 12 +- drivers/gpu/drm/amd/display/dc/inc/hw/dccg.h | 3 +- drivers/gpu/drm/amd/display/dc/inc/hw/dchubbub.h | 6 + drivers/gpu/drm/amd/display/dc/inc/hw/dpp.h | 2 +- drivers/gpu/drm/amd/display/dc/inc/hw/dsc.h | 4 +- drivers/gpu/drm/amd/display/dc/inc/hw/dwb.h | 12 - drivers/gpu/drm/amd/display/dc/inc/hw/gpio.h | 10 + drivers/gpu/drm/amd/display/dc/inc/hw/hubp.h | 11 +- .../gpu/drm/amd/display/dc/inc/hw/link_encoder.h | 3 + drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h | 7 + drivers/gpu/drm/amd/display/dc/inc/hw/opp.h | 5 - .../gpu/drm/amd/display/dc/inc/hw/stream_encoder.h | 20 +- .../drm/amd/display/dc/inc/hw/timing_generator.h | 15 +- drivers/gpu/drm/amd/display/dc/inc/hw_sequencer.h | 40 +- drivers/gpu/drm/amd/display/dc/inc/link_hwss.h | 2 - drivers/gpu/drm/amd/display/dc/inc/resource.h | 3 - .../amd/display/dc/irq/dcn20/irq_service_dcn20.c | 28 +- .../display/dc/virtual/virtual_stream_encoder.c | 5 + .../drm/amd/display/include/ddc_service_types.h | 10 +- .../gpu/drm/amd/display/include/gpio_interface.h | 9 + .../gpu/drm/amd/display/include/logger_interface.h | 2 + drivers/gpu/drm/amd/display/include/logger_types.h | 7 + .../drm/amd/display/modules/color/color_gamma.c | 224 ++++-- .../drm/amd/display/modules/color/color_gamma.h | 1 + .../drm/amd/display/modules/freesync/freesync.c | 303 ++----- .../gpu/drm/amd/display/modules/inc/mod_freesync.h | 2 + .../drm/amd/display/modules/inc/mod_info_packet.h | 2 +- .../amd/display/modules/info_packet/info_packet.c | 88 +++ .../drm/amd/display/modules/power/power_helpers.c | 121 ++- drivers/gpu/drm/amd/include/amd_shared.h | 1 + .../include/asic_reg/mmhub/mmhub_9_4_0_offset.h | 21 + .../include/asic_reg/mmhub/mmhub_9_4_0_sh_mask.h | 222 ++++++ .../drm/amd/include/asic_reg/mp/mp_12_0_0_offset.h | 336 ++++++++ .../amd/include/asic_reg/mp/mp_12_0_0_sh_mask.h | 866 +++++++++++++++++++++ drivers/gpu/drm/amd/include/kgd_pp_interface.h | 1 + drivers/gpu/drm/amd/include/navi12_ip_offset.h | 4 +- drivers/gpu/drm/amd/powerplay/Makefile | 2 +- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 21 + drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 38 +- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 43 +- drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 7 + drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 12 +- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 3 +- drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 6 +- drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 29 +- drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 9 + drivers/gpu/drm/amd/powerplay/inc/rv_ppsmc.h | 2 +- .../gpu/drm/amd/powerplay/inc/smu11_driver_if.h | 4 +- .../amd/powerplay/inc/smu11_driver_if_arcturus.h | 17 +- .../drm/amd/powerplay/inc/smu11_driver_if_navi10.h | 29 +- .../gpu/drm/amd/powerplay/inc/smu12_driver_if.h | 217 ++++++ drivers/gpu/drm/amd/powerplay/inc/smu_types.h | 44 ++ drivers/gpu/drm/amd/powerplay/inc/smu_v11_0.h | 12 + drivers/gpu/drm/amd/powerplay/inc/smu_v12_0.h | 42 + .../gpu/drm/amd/powerplay/inc/smu_v12_0_ppsmc.h | 106 +++ drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 19 +- drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 173 ++++ drivers/gpu/drm/amd/powerplay/renoir_ppt.h | 28 + drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 120 +-- drivers/gpu/drm/amd/powerplay/smu_v12_0.c | 350 +++++++++ drivers/gpu/drm/amd/powerplay/vega20_ppt.c | 37 +- drivers/gpu/drm/radeon/radeon.h | 1 - drivers/gpu/drm/radeon/radeon_device.c | 21 +- drivers/gpu/drm/radeon/radeon_ttm.c | 2 +- drivers/gpu/drm/scheduler/sched_entity.c | 4 +- include/drm/amd_asic_type.h | 1 + 229 files changed, 8051 insertions(+), 3441 deletions(-) create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_mmhub.h create mode 100644 drivers/gpu/drm/amd/amdgpu/athub_v1_0.c create mode 100644 drivers/gpu/drm/amd/amdgpu/athub_v1_0.h create mode 100644 drivers/gpu/drm/amd/amdgpu/psp_v12_0.c create mode 100644 drivers/gpu/drm/amd/amdgpu/psp_v12_0.h delete mode 100644 drivers/gpu/drm/amd/display/dc/dsc/drm_dsc_dc.c create mode 100644 drivers/gpu/drm/amd/include/asic_reg/mp/mp_12_0_0_offset.h create mode 100644 drivers/gpu/drm/amd/include/asic_reg/mp/mp_12_0_0_sh_mask.h create mode 100644 drivers/gpu/drm/amd/powerplay/inc/smu12_driver_if.h create mode 100644 drivers/gpu/drm/amd/powerplay/inc/smu_v12_0.h create mode 100644 drivers/gpu/drm/amd/powerplay/inc/smu_v12_0_ppsmc.h create mode 100644 drivers/gpu/drm/amd/powerplay/renoir_ppt.c create mode 100644 drivers/gpu/drm/amd/powerplay/renoir_ppt.h create mode 100644 drivers/gpu/drm/amd/powerplay/smu_v12_0.c

1 0

[PATCH v2 1/2] drm/i915: Call dma_set_max_seg_size() in i915_ggtt_probe_hw()
by Lyude Paul 23 Aug '19

23 Aug '19

Currently, we don't call dma_set_max_seg_size() for i915 because we intentionally do not limit the segment length that the device supports. However, this results in a warning being emitted if we try to map anything larger than SZ_64K on a kernel with CONFIG_DMA_API_DEBUG_SG enabled: [ 7.751926] DMA-API: i915 0000:00:02.0: mapping sg segment longer than device claims to support [len=98304] [max=65536] [ 7.751934] WARNING: CPU: 5 PID: 474 at kernel/dma/debug.c:1220 debug_dma_map_sg+0x20f/0x340 This was originally brought up on https://bugs.freedesktop.org/show_bug.cgi?id=108517 , and the consensus there was it wasn't really useful to set a limit (and that dma-debug isn't really all that useful for i915 in the first place). Unfortunately though, CONFIG_DMA_API_DEBUG_SG is enabled in the debug configs for various distro kernels. Since a WARN_ON() will disable automatic problem reporting (and cause any CI with said option enabled to start complaining), we really should just fix the problem. Note that as me and Chris Wilson discussed, the other solution for this would be to make DMA-API not make such assumptions when a driver hasn't explicitly set a maximum segment size. But, taking a look at the commit which originally introduced this behavior, commit 78c47830a5cb ("dma-debug: check scatterlist segments"), there is an explicit mention of this assumption and how it applies to devices with no segment size: Conversely, devices which are less limited than the rather conservative defaults, or indeed have no limitations at all (e.g. GPUs with their own internal MMU), should be encouraged to set appropriate dma_parms, as they may get more efficient DMA mapping performance out of it. So unless there's any concerns (I'm open to discussion!), let's just follow suite and call dma_set_max_seg_size() with UINT_MAX as our limit to silence any warnings. Signed-off-by: Lyude Paul <lyude(a)redhat.com> Cc: Chris Wilson <chris(a)chris-wilson.co.uk> Cc: <stable(a)vger.kernel.org> # v4.18+ --- drivers/gpu/drm/i915/i915_gem_gtt.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index 0b81e0b64393..a1475039d182 100644 --- a/drivers/gpu/drm/i915/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c @@ -3152,6 +3152,11 @@ static int ggtt_probe_hw(struct i915_ggtt *ggtt, struct intel_gt *gt) if (ret) return ret; + /* We don't have a max segment size, so set it to the max so sg's + * debugging layer doesn't complain + */ + dma_set_max_seg_size(ggtt->vm.dma, UINT_MAX); + if ((ggtt->vm.total - 1) >> 32) { DRM_ERROR("We never expected a Global GTT with more than 32bits" " of address space! Found %lldM!\n", -- 2.21.0

2 4

[PATCH v14 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework
by Brendan Higgins 23 Aug '19

23 Aug '19

## TL;DR This revision addresses comments from Shuah by removing two macros that were causing checkpatch errors. No API or major structual changes have been made since v13. ## Background This patch set proposes KUnit, a lightweight unit testing and mocking framework for the Linux kernel. Unlike Autotest and kselftest, KUnit is a true unit testing framework; it does not require installing the kernel on a test machine or in a VM (however, KUnit still allows you to run tests on test machines or in VMs if you want[1]) and does not require tests to be written in userspace running on a host kernel. Additionally, KUnit is fast: From invocation to completion KUnit can run several dozen tests in about a second. Currently, the entire KUnit test suite for KUnit runs in under a second from the initial invocation (build time excluded). KUnit is heavily inspired by JUnit, Python's unittest.mock, and Googletest/Googlemock for C++. KUnit provides facilities for defining unit test cases, grouping related test cases into test suites, providing common infrastructure for running tests, mocking, spying, and much more. ### What's so special about unit testing? A unit test is supposed to test a single unit of code in isolation, hence the name. There should be no dependencies outside the control of the test; this means no external dependencies, which makes tests orders of magnitudes faster. Likewise, since there are no external dependencies, there are no hoops to jump through to run the tests. Additionally, this makes unit tests deterministic: a failing unit test always indicates a problem. Finally, because unit tests necessarily have finer granularity, they are able to test all code paths easily solving the classic problem of difficulty in exercising error handling code. ### Is KUnit trying to replace other testing frameworks for the kernel? No. Most existing tests for the Linux kernel are end-to-end tests, which have their place. A well tested system has lots of unit tests, a reasonable number of integration tests, and some end-to-end tests. KUnit is just trying to address the unit test space which is currently not being addressed. ### More information on KUnit There is a bunch of documentation near the end of this patch set that describes how to use KUnit and best practices for writing unit tests. For convenience I am hosting the compiled docs here[2]. Additionally for convenience, I have applied these patches to a branch[3]. The repo may be cloned with: git clone https://kunit.googlesource.com/linux This patchset is on the kunit/rfc/v5.3/v14 branch. ## Changes Since Last Version - Removed to macros which helped define expectation and assertion macros; these values are now just copied and pasted. Change was made to fix checkpatch error, as suggested by Shuah. [1] https://google.github.io/kunit-docs/third_party/kernel/docs/usage.html#kuni… [2] https://google.github.io/kunit-docs/third_party/kernel/docs/ [3] https://kunit.googlesource.com/linux/+/kunit/rfc/v5.3/v14 -- 2.23.0.rc1.153.gdeed80330f-goog

2 33

[PATCH] drm: Add LTTPR defines for DP 1.4
by Siqueira, Rodrigo 23 Aug '19

23 Aug '19

DP 1.4 specification defines Link Training Tunable PHY Repeater (LTTPR) which is required to add support for systems with Thunderbolt or other repeater devices. Cc: Abdoulaye Berthe <Abdoulaye.Berthe(a)amd.com> Cc: Harry Wentland <harry.wentland(a)amd.com> Cc: Leo Li <sunpeng.li(a)amd.com> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira(a)amd.com> Signed-off-by: Abdoulaye Berthe <Abdoulaye.Berthe(a)amd.com> --- include/drm/drm_dp_helper.h | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 8364502f92cf..8336d960da7f 100644 --- a/include/drm/drm_dp_helper.h +++ b/include/drm/drm_dp_helper.h @@ -134,6 +134,32 @@ #define DP_SUPPORTED_LINK_RATES 0x010 /* eDP 1.4 */ # define DP_MAX_SUPPORTED_RATES 8 /* 16-bit little-endian */ +/** Link Training (LT)-tunable Physical Repeaters - DP 1.4 **/ +#define DP_LTTPR_REV 0xf0000 +#define DP_LTTPR_MAX_LINK_RATE 0xf0001 +#define DP_LTTPR_REPEATER_CNT 0xf0002 +#define DP_LTTPR_REPEATER_MODE 0xf0003 +#define DP_LTTPR_MAX_LANE_CNT 0xf0004 +#define DP_LTTPR_EXTENDED_WAIT_TIMEOUT 0xf0005 +#define DP_LTTPR_TRAINING_PATTERN_SET_REPEATER1 0xf0010 +#define DP_LTTPR_TRAINING_LANE0_SET_REPEATER1 0xf0011 +#define DP_LTTPR_TRAINING_LANE1_SET_REPEATER1 0xf0012 +#define DP_LTTPR_TRAINING_LANE2_SET_REPEATER1 0xf0013 +#define DP_LTTPR_TRAINING_LANE3_SET_REPEATER1 0xf0014 +#define DP_LTTPR_TRAINING_AUX_RD_INTERVAL_REPEATER1 0xf0020 +#define DP_LTTPR_TRANSMITTER_CAPABILITY_REPEATER1 0xf0021 +#define DP_LTTPR_LANE0_1_STATUS_REPEATER1 0xf0030 +#define DP_LTTPR_LANE2_3_STATUS_REPEATER1 0xf0031 +#define DP_LTTPR_LANE_ALIGN_STATUS_UPDATED_REPEATER1 0xf0032 +#define DP_LTTPR_ADJUST_REQUEST_LANE0_1_REPEATER1 0xf0033 +#define DP_LTTPR_ADJUST_REQUEST_LANE2_3_REPEATER1 0xf0034 +#define DP_LTTPR_SYMBOL_ERROR_COUNT_LANE0_REPEATER1 0xf0035 +#define DP_LTTPR_SYMBOL_ERROR_COUNT_LANE1_REPEATER1 0xf0037 +#define DP_LTTPR_SYMBOL_ERROR_COUNT_LANE2_REPEATER1 0xf0039 +#define DP_LTTPR_SYMBOL_ERROR_COUNT_LANE3_REPEATER1 0xf003b +#define DP_REPEATER_CONFIGURATION_AND_STATUS_OFFSET 0x50 +#define DP_LTTPR_FEC_STATUS_REPEATER1 0xf0290 + /* Multiple stream transport */ #define DP_FAUX_CAP 0x020 /* 1.2 */ # define DP_FAUX_CAP_1 (1 << 0) -- 2.23.0

2 2

[PATCH v3] drm/panfrost: Add errata descriptions from kbase
by Alyssa Rosenzweig 23 Aug '19

23 Aug '19

While newer kbase include only the numbers of errata, older kbase releases included one-line descriptions for each errata, which is useful for those working on the driver. Import these descriptions. Most are from kbase verbatim; a few I edited for clarity. v2: Wrote a description for the workaround of an issue whose cause is still unknown (Stephen). Errata which pertain to newer models unsupported by the mainline driver, for which Arm has not yet released errata information, have been removed from the issue list as the kernel need not concern itself with these. v3: Readded errata not yet handled, adding descriptions based on the workarounds in the latest kbase release. Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig(a)collabora.com> --- drivers/gpu/drm/panfrost/panfrost_issues.h | 81 ++++++++++++++++++++++ 1 file changed, 81 insertions(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_issues.h b/drivers/gpu/drm/panfrost/panfrost_issues.h index cec6dcdad..8e59d765b 100644 --- a/drivers/gpu/drm/panfrost/panfrost_issues.h +++ b/drivers/gpu/drm/panfrost/panfrost_issues.h @@ -13,37 +13,118 @@ * to care about. */ enum panfrost_hw_issue { + /* Need way to guarantee that all previously-translated memory accesses + * are commited */ HW_ISSUE_6367, + + /* On job complete with non-done the cache is not flushed */ HW_ISSUE_6787, + + /* Write of PRFCNT_CONFIG_MODE_MANUAL to PRFCNT_CONFIG causes a + * instrumentation dump if PRFCNT_TILER_EN is enabled */ HW_ISSUE_8186, + + /* TIB: Reports faults from a vtile which has not yet been allocated */ HW_ISSUE_8245, + + /* uTLB deadlock could occur when writing to an invalid page at the + * same time as access to a valid page in the same uTLB cache line ( == + * 4 PTEs == 16K block of mapping) */ HW_ISSUE_8316, + + /* HT: TERMINATE for RUN command ignored if previous LOAD_DESCRIPTOR is + * still executing */ HW_ISSUE_8394, + + /* CSE: Sends a TERMINATED response for a task that should not be + * terminated */ HW_ISSUE_8401, + + /* Repeatedly Soft-stopping a job chain consisting of (Vertex Shader, + * Cache Flush, Tiler) jobs causes DATA_INVALID_FAULT on tiler job. */ HW_ISSUE_8408, + + /* Disable the Pause Buffer in the LS pipe. */ HW_ISSUE_8443, + + /* Change in RMUs in use causes problems related with the core's SDC */ HW_ISSUE_8987, + + /* Compute endpoint has a 4-deep queue of tasks, meaning a soft stop + * won't complete until all 4 tasks have completed */ HW_ISSUE_9435, + + /* HT: Tiler returns TERMINATED for non-terminated command */ HW_ISSUE_9510, + + /* Occasionally the GPU will issue multiple page faults for the same + * address before the MMU page table has been read by the GPU */ HW_ISSUE_9630, + + /* RA DCD load request to SDC returns invalid load ignore causing + * colour buffer mismatch */ HW_ISSUE_10327, + + /* MMU TLB invalidation hazards */ HW_ISSUE_10649, + + /* Missing cache flush in multi core-group configuration */ HW_ISSUE_10676, + + /* Chicken bit on T72X for a hardware workaround in compiler */ HW_ISSUE_10797, + + /* Soft-stopping fragment jobs might fail with TILE_RANGE_FAULT */ HW_ISSUE_10817, + + /* Intermittent missing interrupt on job completion */ HW_ISSUE_10883, + + /* Soft-stopping fragment jobs might fail with TILE_RANGE_ERROR + * (similar to issue 10817) and can use #10817 workaround */ HW_ISSUE_10959, + + /* Soft-stopped fragment shader job can restart with out-of-bound + * restart index */ HW_ISSUE_10969, + + /* Race condition can cause tile list corruption */ HW_ISSUE_11020, + + /* Write buffer can cause tile list corruption */ HW_ISSUE_11024, + + /* Pause buffer can cause a fragment job hang */ HW_ISSUE_11035, + + /* Dynamic Core Scaling not supported due to errata */ HW_ISSUE_11056, + + /* Clear encoder state for a hard stopped fragment job which is AFBC + * encoded by soft resetting the GPU. Only for T76X r0p0, r0p1 and + * r0p1_50rel0 */ HW_ISSUE_T76X_3542, + + /* Keep tiler module clock on to prevent GPU stall */ HW_ISSUE_T76X_3953, + + /* Must ensure L2 is not transitioning when we reset. Workaround with a + * busy wait until L2 completes transition; ensure there is a maximum + * loop count as she may never complete her transition. (On chips + * without this errata, it's totally okay if L2 transitions.) */ HW_ISSUE_TMIX_8463, + + /* Don't set SC_LS_ATTR_CHECK_DISABLE/SC_LS_ALLOW_ATTR_TYPES */ GPUCORE_1619, + + /* When a hard-stop follows close after a soft-stop, the completion + * code for the terminated job may be incorrectly set to STOPPED */ HW_ISSUE_TMIX_8438, + + /* "Protected mode" is buggy on Mali-G31 some Bifrost chips, so the + * kernel must fiddle with L2 caches to prevent data leakage */ HW_ISSUE_TGOX_R1_1234, + HW_ISSUE_END }; -- 2.23.0.rc1

2 1

(no subject)
by Rob Herring 23 Aug '19

23 Aug '19

Subject: [PATCH v2 0/8] panfrost: Locking and runtime PM fixes With further testing of recent changes with lockdep and other locking checks enabled, we've found several bugs in the shrinker code and one sleep while atomic in panfrost_gem_open(). This series addresses those issues. Delaying the unmapping of pages turns out to be a bad idea. Instead we need to rework panfrost_mmu_unmap() to not do a runtime PM resume which takes several locks and causes more lockdep warnings. Unfortunately, there initially appeared to be some mismatches between the runtime PM state and the h/w. The result is several fixes to the runtime PM initialization and handling in jobs. With this, the changes to panfrost_mmu_unmap() are working correctly. v2: - Drop already applied 'drm/panfrost: Fix sleeping while atomic in panfrost_gem_open' - Runtime PM clean-ups - Keep panfrost_gem_purge and use mutex_trylock there - Rework panfrost_mmu_unmap runtime PM Rob Rob Herring (8): drm/panfrost: Fix possible suspend in panfrost_remove drm/panfrost: Rework runtime PM initialization drm/panfrost: Hold runtime PM reference until jobs complete drm/shmem: Do dma_unmap_sg before purging pages drm/shmem: Use mutex_trylock in drm_gem_shmem_purge drm/panfrost: Use mutex_trylock in panfrost_gem_purge drm/panfrost: Rework page table flushing and runtime PM interaction drm/panfrost: Remove unnecessary flushing from tlb_inv_context drivers/gpu/drm/drm_gem_shmem_helper.c | 13 ++++- drivers/gpu/drm/panfrost/panfrost_device.c | 9 ---- drivers/gpu/drm/panfrost/panfrost_drv.c | 16 ++++--- .../gpu/drm/panfrost/panfrost_gem_shrinker.c | 11 +++-- drivers/gpu/drm/panfrost/panfrost_job.c | 16 ++++--- drivers/gpu/drm/panfrost/panfrost_mmu.c | 47 +++++++++---------- include/drm/drm_gem_shmem_helper.h | 2 +- 7 files changed, 59 insertions(+), 55 deletions(-) -- 2.20.1

3 29

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel August 2019