dri-devel August 2019

dri-devel@lists.freedesktop.org

318 participants
2338 discussions

[PATCH] [v8,2/2] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel
by Jerry Han 03 Aug '19

03 Aug '19

Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel. V8: - Modify communication address V7: - Add the information of the reviewer - Remove unnecessary delays, The udelay_range code gracefully returns without hitting the scheduler on a delay of 0. (Derek) - Merge the same data structures, like display_mode and off_cmds (Derek) - Optimize the processing of results returned by devm_gpiod_get_optional (Derek) V6: - Add the information of the reviewer (Sam) - Delete unnecessary header files #include <linux/fb.h> (Sam) - The config DRM_PANEL_BOE_HIMAX8279D appears twice. Drop one of them (Sam) - ADD static, set_gpios function is not used outside this module (Sam) V5: - Added changelog V4: - Frefix all function maes with boe_ (Sam) - Fsed "enable_gpio" replace "reset_gpio", Make it look clearer (Sam) - Sort include lines alphabetically (Sam) - Fixed entries in the makefile must be sorted alphabetically (Sam) - Add send_mipi_cmds function to avoid duplicating the code (Sam) - Add the necessary delay(reset_delay_t5) between reset and sending the initialization command (Rock wang) V3: - Remove unnecessary delays in sending initialization commands (Jitao Shi) V2: - Use SPDX identifier (Sam) - Use necessary header files replace drmP.h (Sam) - Delete unnecessary header files #include <linux/err.h> (Sam) - Specifies a GPIOs array to control the reset timing, instead of reading "dsi-reset-sequence" data from DTS (Sam) - Delete backlight_disable() function when already disabled (Sam) - Use devm_of_find_backlight() replace of_find_backlight_by_node() (Sam) - Move the necessary data in the DTS to the current file, like porch, display_mode and Init code etc. (Sam) - Add compatible device "boe,himax8279d10p" (Sam) Signed-off-by: Jerry Han <jerry.han.hq(a)gmail.com> Reviewed-by: Sam Ravnborg <sam(a)ravnborg.org> Reviewed-by: Derek Basehore <dbasehore(a)chromium.org> Cc: Jitao Shi <jitao.shi(a)mediatek.com> Cc: Rock wang <rock_wang(a)himax.com.cn> --- MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-boe-himax8279d.c | 1050 ++++++++++++++++++ 4 files changed, 1068 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-boe-himax8279d.c diff --git a/MAINTAINERS b/MAINTAINERS index f8e63bcc4c1c..267468ca72bb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4816,6 +4816,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc S: Maintained F: drivers/gpu/drm/bochs/ +DRM DRIVER FOR BOE HIMAX8279D PANELS +M: Jerry Han <hanxu5(a)huaqin.corp-partner.google.com> +S: Maintained +F: drivers/gpu/drm/panel/panel-boe-himax8279d.c +F: Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt + DRM DRIVER FOR FARADAY TVE200 TV ENCODER M: Linus Walleij <linus.walleij(a)linaro.org> T: git git://anongit.freedesktop.org/drm/drm-misc diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index f53f817356db..fe2f87cc6627 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -17,6 +17,17 @@ config DRM_PANEL_ARM_VERSATILE reference designs. The panel is detected using special registers in the Versatile family syscon registers. +config DRM_PANEL_BOE_HIMAX8279D + tristate "Boe Himax8279d panel" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y here if you want to enable support for Boe Himax8279d + TFT-LCD modules. The panel has a 1200x1920 resolution and uses + 24 bit RGB per pixel. It provides a MIPI DSI interface to + the host and has a built-in LED backlight. + config DRM_PANEL_LVDS tristate "Generic LVDS panel driver" depends on OF diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index 7834947a53b0..c4814b6f069e 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_DRM_PANEL_ARM_VERSATILE) += panel-arm-versatile.o +obj-$(CONFIG_DRM_PANEL_BOE_HIMAX8279D) += panel-boe-himax8279d.o obj-$(CONFIG_DRM_PANEL_LVDS) += panel-lvds.o obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) += panel-ilitek-ili9322.o diff --git a/drivers/gpu/drm/panel/panel-boe-himax8279d.c b/drivers/gpu/drm/panel/panel-boe-himax8279d.c new file mode 100644 index 000000000000..9c8ece4fa30a --- /dev/null +++ b/drivers/gpu/drm/panel/panel-boe-himax8279d.c @@ -0,0 +1,1050 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2019, Huaqin Telecom Technology Co., Ltd + * + * Author: Jerry Han <jerry.han.hq(a)gmail.com> + * + */ + +#include <linux/backlight.h> +#include <linux/delay.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/of_device.h> + +#include <linux/gpio/consumer.h> +#include <linux/regulator/consumer.h> + +#include <drm/drm_device.h> +#include <drm/drm_mipi_dsi.h> +#include <drm/drm_modes.h> +#include <drm/drm_panel.h> +#include <drm/drm_print.h> + +#include <video/mipi_display.h> + +struct panel_cmd { + size_t len; + const char *data; +}; + +#define _INIT_CMD(...) { \ + .len = sizeof((char[]){__VA_ARGS__}), \ + .data = (char[]){__VA_ARGS__} } + +struct panel_desc { + const struct drm_display_mode *display_mode; + unsigned int bpc; + unsigned int width_mm; + unsigned int height_mm; + + unsigned int delay_t1; + unsigned int reset_delay_t2; + unsigned int reset_delay_t3; + unsigned int reset_delay_t4; + unsigned int reset_delay_t5; + + unsigned long mode_flags; + enum mipi_dsi_pixel_format format; + unsigned int lanes; + const struct panel_cmd *on_cmds; + const struct panel_cmd *off_cmds; +}; + +struct panel_info { + struct drm_panel base; + struct mipi_dsi_device *link; + const struct panel_desc *desc; + + struct backlight_device *backlight; + struct gpio_desc *enable_gpio; + struct gpio_desc *pp33_gpio; + struct gpio_desc *pp18_gpio; + + bool prepared; + bool enabled; +}; + +static inline struct panel_info *to_panel_info(struct drm_panel *panel) +{ + return container_of(panel, struct panel_info, base); +} + +static void set_gpios(struct panel_info *pinfo, int enable) +{ + gpiod_set_value(pinfo->enable_gpio, enable); + gpiod_set_value(pinfo->pp33_gpio, enable); + gpiod_set_value(pinfo->pp18_gpio, enable); +} + +static int send_mipi_cmds(struct drm_panel *panel, const struct panel_cmd *cmds) +{ + struct panel_info *pinfo = to_panel_info(panel); + unsigned int i = 0; + int err; + + if (!cmds) + return -EFAULT; + + for (i = 0; cmds[i].len != 0; i++) { + const struct panel_cmd *cmd = &cmds[i]; + + if (cmd->len == 2) + err = mipi_dsi_dcs_write(pinfo->link, + cmd->data[1], NULL, 0); + else + err = mipi_dsi_dcs_write(pinfo->link, + cmd->data[1], cmd->data + 2, + cmd->len - 2); + + if (err < 0) + return err; + + usleep_range((cmd->data[0]) * 1000, + (1 + cmd->data[0]) * 1000); + } + + return 0; +} + +static int boe_panel_disable(struct drm_panel *panel) +{ + struct panel_info *pinfo = to_panel_info(panel); + + backlight_disable(pinfo->backlight); + + pinfo->enabled = false; + + return 0; +} + +static int boe_panel_unprepare(struct drm_panel *panel) +{ + struct panel_info *pinfo = to_panel_info(panel); + int err; + + if (!pinfo->prepared) + return 0; + + /* send off code */ + err = send_mipi_cmds(panel, pinfo->desc->off_cmds); + if (err < 0) { + DRM_DEV_ERROR(panel->dev, + "failed to send DCS Off Code: %d\n", err); + goto poweroff; + } + + set_gpios(pinfo, 0); + + pinfo->prepared = false; + + return 0; + +poweroff: + set_gpios(pinfo, 0); + return err; +} + +static int boe_panel_prepare(struct drm_panel *panel) +{ + struct panel_info *pinfo = to_panel_info(panel); + const struct panel_desc *desc = pinfo->desc; + int err; + + if (pinfo->prepared) + return 0; + + gpiod_set_value(pinfo->pp18_gpio, 1); + /* T1 (> 5ms) */ + usleep_range(desc->delay_t1, 1000 + desc->delay_t1); + gpiod_set_value(pinfo->pp33_gpio, 1); + + /* reset sequence */ + usleep_range(desc->reset_delay_t2, 1000 + desc->reset_delay_t2); + + gpiod_set_value(pinfo->enable_gpio, 1); + usleep_range(desc->reset_delay_t3, 1000 + desc->reset_delay_t3); + gpiod_set_value(pinfo->enable_gpio, 0); + + usleep_range(desc->reset_delay_t4, 1000 + desc->reset_delay_t4); + gpiod_set_value(pinfo->enable_gpio, 1); + + usleep_range(desc->reset_delay_t5, 1000 + desc->reset_delay_t5); + + /* send init code */ + err = send_mipi_cmds(panel, pinfo->desc->on_cmds); + if (err < 0) { + DRM_DEV_ERROR(panel->dev, + "failed to send DCS Init Code: %d\n", err); + goto poweroff; + } + + pinfo->prepared = true; + + return 0; + +poweroff: + set_gpios(pinfo, 0); + return err; +} + +static int boe_panel_enable(struct drm_panel *panel) +{ + struct panel_info *pinfo = to_panel_info(panel); + int ret; + + if (pinfo->enabled) + return 0; + + ret = backlight_enable(pinfo->backlight); + if (ret) { + DRM_DEV_ERROR(panel->drm->dev, + "Failed to enable backlight %d\n", ret); + return ret; + } + + pinfo->enabled = true; + + return 0; +} + +static int boe_panel_get_modes(struct drm_panel *panel) +{ + struct panel_info *pinfo = to_panel_info(panel); + const struct drm_display_mode *m = pinfo->desc->display_mode; + struct drm_display_mode *mode; + + mode = drm_mode_duplicate(panel->drm, m); + if (!mode) { + DRM_DEV_ERROR(panel->drm->dev, "failed to add mode %ux%u@%u\n", + m->hdisplay, m->vdisplay, m->vrefresh); + return -ENOMEM; + } + + drm_mode_set_name(mode); + + drm_mode_probed_add(panel->connector, mode); + + panel->connector->display_info.width_mm = pinfo->desc->width_mm; + panel->connector->display_info.height_mm = pinfo->desc->height_mm; + panel->connector->display_info.bpc = pinfo->desc->bpc; + + return 1; +} + +static const struct drm_panel_funcs panel_funcs = { + .disable = boe_panel_disable, + .unprepare = boe_panel_unprepare, + .prepare = boe_panel_prepare, + .enable = boe_panel_enable, + .get_modes = boe_panel_get_modes, +}; + +static const struct drm_display_mode default_display_mode = { + .clock = 159420, + .hdisplay = 1200, + .hsync_start = 1200 + 80, + .hsync_end = 1200 + 80 + 60, + .htotal = 1200 + 80 + 60 + 24, + .vdisplay = 1920, + .vsync_start = 1920 + 10, + .vsync_end = 1920 + 10 + 14, + .vtotal = 1920 + 10 + 14 + 4, + .vrefresh = 60, +}; + +static const struct panel_cmd default_off_cmds[] = { + _INIT_CMD(0x00, 0x28), + _INIT_CMD(0x01, 0x10), + + {}, +}; + +/* 8 inch */ +static const struct panel_cmd boe_himax8279d8p_on_cmds[] = { + _INIT_CMD(0x22, 0x10), + _INIT_CMD(0x00, 0xB0, 0x05), + _INIT_CMD(0x00, 0xB1, 0xE5), + _INIT_CMD(0x00, 0xB3, 0x52), + _INIT_CMD(0x00, 0xB0, 0x00), + _INIT_CMD(0x00, 0xB3, 0x88), + _INIT_CMD(0x00, 0xB0, 0x04), + _INIT_CMD(0x00, 0xB8, 0x00), + _INIT_CMD(0x00, 0xB0, 0x00), + _INIT_CMD(0x00, 0xB2, 0x50), + _INIT_CMD(0x00, 0xB6, 0x03), + _INIT_CMD(0x00, 0xBA, 0x8B), + _INIT_CMD(0x00, 0xBF, 0x15), + _INIT_CMD(0x00, 0xC0, 0x0F), + _INIT_CMD(0x00, 0xC2, 0x0C), + _INIT_CMD(0x00, 0xC3, 0x02), + _INIT_CMD(0x00, 0xC4, 0x0C), + _INIT_CMD(0x00, 0xC5, 0x02), + _INIT_CMD(0x00, 0xB0, 0x01), + _INIT_CMD(0x00, 0xE0, 0x26), + _INIT_CMD(0x00, 0xE1, 0x26), + _INIT_CMD(0x00, 0xDC, 0x00), + _INIT_CMD(0x00, 0xDD, 0x00), + _INIT_CMD(0x00, 0xCC, 0x26), + _INIT_CMD(0x00, 0xCD, 0x26), + _INIT_CMD(0x00, 0xC8, 0x00), + _INIT_CMD(0x00, 0xC9, 0x00), + _INIT_CMD(0x00, 0xD2, 0x04), + _INIT_CMD(0x00, 0xD3, 0x04), + _INIT_CMD(0x00, 0xE6, 0x03), + _INIT_CMD(0x00, 0xE7, 0x03), + _INIT_CMD(0x00, 0xC4, 0x08), + _INIT_CMD(0x00, 0xC5, 0x08), + _INIT_CMD(0x00, 0xD8, 0x07), + _INIT_CMD(0x00, 0xD9, 0x07), + _INIT_CMD(0x00, 0xC2, 0x06), + _INIT_CMD(0x00, 0xC3, 0x06), + _INIT_CMD(0x00, 0xD6, 0x05), + _INIT_CMD(0x00, 0xD7, 0x05), + _INIT_CMD(0x00, 0xC0, 0x0C), + _INIT_CMD(0x00, 0xC1, 0x0C), + _INIT_CMD(0x00, 0xD4, 0x0B), + _INIT_CMD(0x00, 0xD5, 0x0B), + _INIT_CMD(0x00, 0xCA, 0x0A), + _INIT_CMD(0x00, 0xCB, 0x0A), + _INIT_CMD(0x00, 0xDE, 0x09), + _INIT_CMD(0x00, 0xDF, 0x09), + _INIT_CMD(0x00, 0xC6, 0x26), + _INIT_CMD(0x00, 0xC7, 0x26), + _INIT_CMD(0x00, 0xCE, 0x00), + _INIT_CMD(0x00, 0xCF, 0x00), + _INIT_CMD(0x00, 0xDA, 0x26), + _INIT_CMD(0x00, 0xDB, 0x26), + _INIT_CMD(0x00, 0xE2, 0x00), + _INIT_CMD(0x00, 0xE3, 0x00), + _INIT_CMD(0x00, 0xB0, 0x02), + _INIT_CMD(0x00, 0xC0, 0x00), + _INIT_CMD(0x00, 0xC1, 0x07), + _INIT_CMD(0x00, 0xC2, 0x0D), + _INIT_CMD(0x00, 0xC3, 0x18), + _INIT_CMD(0x00, 0xC4, 0x27), + _INIT_CMD(0x00, 0xC5, 0x28), + _INIT_CMD(0x00, 0xC6, 0x30), + _INIT_CMD(0x00, 0xC7, 0x2E), + _INIT_CMD(0x00, 0xC8, 0x2F), + _INIT_CMD(0x00, 0xC9, 0x1A), + _INIT_CMD(0x00, 0xCA, 0x20), + _INIT_CMD(0x00, 0xCB, 0x29), + _INIT_CMD(0x00, 0xCC, 0x26), + _INIT_CMD(0x00, 0xCD, 0x32), + _INIT_CMD(0x00, 0xCE, 0x33), + _INIT_CMD(0x00, 0xCF, 0x31), + _INIT_CMD(0x00, 0xD0, 0x06), + _INIT_CMD(0x00, 0xD2, 0x00), + _INIT_CMD(0x00, 0xD3, 0x07), + _INIT_CMD(0x00, 0xD4, 0x12), + _INIT_CMD(0x00, 0xD5, 0x26), + _INIT_CMD(0x00, 0xD6, 0x3D), + _INIT_CMD(0x00, 0xD7, 0x3F), + _INIT_CMD(0x00, 0xD8, 0x3F), + _INIT_CMD(0x00, 0xD9, 0x3F), + _INIT_CMD(0x00, 0xDA, 0x3F), + _INIT_CMD(0x00, 0xDB, 0x3F), + _INIT_CMD(0x00, 0xDC, 0x3F), + _INIT_CMD(0x00, 0xDD, 0x3F), + _INIT_CMD(0x00, 0xDE, 0x3F), + _INIT_CMD(0x00, 0xDF, 0x3A), + _INIT_CMD(0x00, 0xE0, 0x37), + _INIT_CMD(0x00, 0xE1, 0x35), + _INIT_CMD(0x00, 0xE2, 0x07), + _INIT_CMD(0x00, 0xB0, 0x03), + _INIT_CMD(0x00, 0xC8, 0x0B), + _INIT_CMD(0x00, 0xC9, 0x07), + _INIT_CMD(0x00, 0xC3, 0x00), + _INIT_CMD(0x00, 0xE7, 0x00), + _INIT_CMD(0x00, 0xC5, 0x2A), + _INIT_CMD(0x00, 0xDE, 0x2A), + _INIT_CMD(0x00, 0xCA, 0x43), + _INIT_CMD(0x00, 0xC9, 0x07), + _INIT_CMD(0x00, 0xE4, 0xC0), + _INIT_CMD(0x00, 0xE5, 0x0D), + _INIT_CMD(0x00, 0xCB, 0x00), + _INIT_CMD(0x00, 0xB0, 0x06), + _INIT_CMD(0x00, 0xB8, 0xA5), + _INIT_CMD(0x00, 0xC0, 0xA5), + _INIT_CMD(0x00, 0xC7, 0x0F), + _INIT_CMD(0x00, 0xD5, 0x32), + _INIT_CMD(0x00, 0xB8, 0x00), + _INIT_CMD(0x00, 0xC0, 0x00), + _INIT_CMD(0x00, 0xBC, 0x00), + _INIT_CMD(0x00, 0xB0, 0x07), + _INIT_CMD(0x00, 0xB1, 0x00), + _INIT_CMD(0x00, 0xB2, 0x09), + _INIT_CMD(0x00, 0xB3, 0x19), + _INIT_CMD(0x00, 0xB4, 0x2F), + _INIT_CMD(0x00, 0xB5, 0x44), + _INIT_CMD(0x00, 0xB6, 0x52), + _INIT_CMD(0x00, 0xB7, 0x6A), + _INIT_CMD(0x00, 0xB8, 0x8A), + _INIT_CMD(0x00, 0xB9, 0xCA), + _INIT_CMD(0x00, 0xBA, 0x0C), + _INIT_CMD(0x05, 0xBB, 0x87), + _INIT_CMD(0x00, 0xBC, 0x06), + _INIT_CMD(0x00, 0xBD, 0x0A), + _INIT_CMD(0x00, 0xBE, 0x9B), + _INIT_CMD(0x00, 0xBF, 0x0C), + _INIT_CMD(0x00, 0xC0, 0x3D), + _INIT_CMD(0x00, 0xC1, 0x71), + _INIT_CMD(0x00, 0xC2, 0x90), + _INIT_CMD(0x00, 0xC3, 0xA0), + _INIT_CMD(0x00, 0xC4, 0xA8), + _INIT_CMD(0x00, 0xC5, 0xB1), + _INIT_CMD(0x00, 0xC6, 0xBB), + _INIT_CMD(0x00, 0xC7, 0xC0), + _INIT_CMD(0x00, 0xC8, 0xC4), + _INIT_CMD(0x00, 0xC9, 0x00), + _INIT_CMD(0x00, 0xCA, 0x00), + _INIT_CMD(0x00, 0xCB, 0x16), + _INIT_CMD(0x00, 0xCC, 0xAF), + _INIT_CMD(0x00, 0xCD, 0xFF), + _INIT_CMD(0x00, 0xCE, 0xFF), + _INIT_CMD(0x00, 0xB0, 0x08), + _INIT_CMD(0x00, 0xB1, 0x04), + _INIT_CMD(0x00, 0xB2, 0x08), + _INIT_CMD(0x00, 0xB3, 0x19), + _INIT_CMD(0x00, 0xB4, 0x31), + _INIT_CMD(0x00, 0xB5, 0x46), + _INIT_CMD(0x00, 0xB6, 0x55), + _INIT_CMD(0x00, 0xB7, 0x6E), + _INIT_CMD(0x00, 0xB8, 0x92), + _INIT_CMD(0x00, 0xB9, 0xD4), + _INIT_CMD(0x00, 0xBA, 0x1B), + _INIT_CMD(0x05, 0xBB, 0x9B), + _INIT_CMD(0x00, 0xBC, 0x28), + _INIT_CMD(0x00, 0xBD, 0x2D), + _INIT_CMD(0x00, 0xBE, 0xC3), + _INIT_CMD(0x00, 0xBF, 0x2F), + _INIT_CMD(0x00, 0xC0, 0x62), + _INIT_CMD(0x00, 0xC1, 0x99), + _INIT_CMD(0x00, 0xC2, 0xAB), + _INIT_CMD(0x00, 0xC3, 0xBF), + _INIT_CMD(0x00, 0xC4, 0xCF), + _INIT_CMD(0x00, 0xC5, 0xDF), + _INIT_CMD(0x00, 0xC6, 0xF0), + _INIT_CMD(0x00, 0xC7, 0xF9), + _INIT_CMD(0x00, 0xC8, 0xFC), + _INIT_CMD(0x00, 0xC9, 0x00), + _INIT_CMD(0x00, 0xCA, 0x00), + _INIT_CMD(0x00, 0xCB, 0x16), + _INIT_CMD(0x00, 0xCC, 0xAF), + _INIT_CMD(0x00, 0xCD, 0xFF), + _INIT_CMD(0x00, 0xCE, 0xFF), + _INIT_CMD(0x00, 0xB0, 0x09), + _INIT_CMD(0x00, 0xB1, 0x04), + _INIT_CMD(0x00, 0xB2, 0x05), + _INIT_CMD(0x00, 0xB3, 0x17), + _INIT_CMD(0x00, 0xB4, 0x2E), + _INIT_CMD(0x00, 0xB5, 0x42), + _INIT_CMD(0x00, 0xB6, 0x51), + _INIT_CMD(0x00, 0xB7, 0x69), + _INIT_CMD(0x00, 0xB8, 0x88), + _INIT_CMD(0x00, 0xB9, 0xC9), + _INIT_CMD(0x00, 0xBA, 0x0C), + _INIT_CMD(0x05, 0xBB, 0x86), + _INIT_CMD(0x00, 0xBC, 0x03), + _INIT_CMD(0x00, 0xBD, 0x08), + _INIT_CMD(0x00, 0xBE, 0x95), + _INIT_CMD(0x00, 0xBF, 0x05), + _INIT_CMD(0x00, 0xC0, 0x35), + _INIT_CMD(0x00, 0xC1, 0x62), + _INIT_CMD(0x00, 0xC2, 0x81), + _INIT_CMD(0x00, 0xC3, 0x96), + _INIT_CMD(0x00, 0xC4, 0x9E), + _INIT_CMD(0x00, 0xC5, 0xA5), + _INIT_CMD(0x00, 0xC6, 0xAD), + _INIT_CMD(0x00, 0xC7, 0xB1), + _INIT_CMD(0x00, 0xC8, 0xB4), + _INIT_CMD(0x00, 0xC9, 0x00), + _INIT_CMD(0x00, 0xCA, 0x00), + _INIT_CMD(0x00, 0xCB, 0x16), + _INIT_CMD(0x00, 0xCC, 0xAF), + _INIT_CMD(0x00, 0xCD, 0xFF), + _INIT_CMD(0x00, 0xCE, 0xFF), + _INIT_CMD(0x00, 0xB0, 0x0A), + _INIT_CMD(0x00, 0xB1, 0x00), + _INIT_CMD(0x00, 0xB2, 0x09), + _INIT_CMD(0x00, 0xB3, 0x19), + _INIT_CMD(0x00, 0xB4, 0x2F), + _INIT_CMD(0x00, 0xB5, 0x44), + _INIT_CMD(0x00, 0xB6, 0x52), + _INIT_CMD(0x00, 0xB7, 0x6A), + _INIT_CMD(0x00, 0xB8, 0x8A), + _INIT_CMD(0x00, 0xB9, 0xCA), + _INIT_CMD(0x00, 0xBA, 0x0C), + _INIT_CMD(0x05, 0xBB, 0x87), + _INIT_CMD(0x00, 0xBC, 0x06), + _INIT_CMD(0x00, 0xBD, 0x0A), + _INIT_CMD(0x00, 0xBE, 0x9B), + _INIT_CMD(0x00, 0xBF, 0x0C), + _INIT_CMD(0x00, 0xC0, 0x3D), + _INIT_CMD(0x00, 0xC1, 0x71), + _INIT_CMD(0x00, 0xC2, 0x90), + _INIT_CMD(0x00, 0xC3, 0xA0), + _INIT_CMD(0x00, 0xC4, 0xA8), + _INIT_CMD(0x00, 0xC5, 0xB1), + _INIT_CMD(0x00, 0xC6, 0xBB), + _INIT_CMD(0x00, 0xC7, 0xC0), + _INIT_CMD(0x00, 0xC8, 0xC4), + _INIT_CMD(0x00, 0xC9, 0x00), + _INIT_CMD(0x00, 0xCA, 0x00), + _INIT_CMD(0x00, 0xCB, 0x16), + _INIT_CMD(0x00, 0xCC, 0xAF), + _INIT_CMD(0x00, 0xCD, 0xFF), + _INIT_CMD(0x00, 0xCE, 0xFF), + _INIT_CMD(0x00, 0xB0, 0x0B), + _INIT_CMD(0x00, 0xB1, 0x04), + _INIT_CMD(0x00, 0xB2, 0x08), + _INIT_CMD(0x00, 0xB3, 0x19), + _INIT_CMD(0x00, 0xB4, 0x31), + _INIT_CMD(0x00, 0xB5, 0x46), + _INIT_CMD(0x00, 0xB6, 0x55), + _INIT_CMD(0x00, 0xB7, 0x6E), + _INIT_CMD(0x00, 0xB8, 0x92), + _INIT_CMD(0x00, 0xB9, 0xD4), + _INIT_CMD(0x00, 0xBA, 0x1B), + _INIT_CMD(0x05, 0xBB, 0x9B), + _INIT_CMD(0x00, 0xBC, 0x28), + _INIT_CMD(0x00, 0xBD, 0x2D), + _INIT_CMD(0x00, 0xBE, 0xC3), + _INIT_CMD(0x00, 0xBF, 0x2F), + _INIT_CMD(0x00, 0xC0, 0x62), + _INIT_CMD(0x00, 0xC1, 0x99), + _INIT_CMD(0x00, 0xC2, 0xAB), + _INIT_CMD(0x00, 0xC3, 0xBF), + _INIT_CMD(0x00, 0xC4, 0xCF), + _INIT_CMD(0x00, 0xC5, 0xDF), + _INIT_CMD(0x00, 0xC6, 0xF0), + _INIT_CMD(0x00, 0xC7, 0xF9), + _INIT_CMD(0x00, 0xC8, 0xFC), + _INIT_CMD(0x00, 0xC9, 0x00), + _INIT_CMD(0x00, 0xCA, 0x00), + _INIT_CMD(0x00, 0xCB, 0x16), + _INIT_CMD(0x00, 0xCC, 0xAF), + _INIT_CMD(0x00, 0xCD, 0xFF), + _INIT_CMD(0x00, 0xCE, 0xFF), + _INIT_CMD(0x00, 0xB0, 0x0C), + _INIT_CMD(0x00, 0xB1, 0x04), + _INIT_CMD(0x00, 0xB2, 0x05), + _INIT_CMD(0x00, 0xB3, 0x17), + _INIT_CMD(0x00, 0xB4, 0x2E), + _INIT_CMD(0x00, 0xB5, 0x42), + _INIT_CMD(0x00, 0xB6, 0x51), + _INIT_CMD(0x00, 0xB7, 0x69), + _INIT_CMD(0x00, 0xB8, 0x88), + _INIT_CMD(0x00, 0xB9, 0xC9), + _INIT_CMD(0x00, 0xBA, 0x0C), + _INIT_CMD(0x05, 0xBB, 0x86), + _INIT_CMD(0x00, 0xBC, 0x03), + _INIT_CMD(0x00, 0xBD, 0x08), + _INIT_CMD(0x00, 0xBE, 0x95), + _INIT_CMD(0x00, 0xBF, 0x05), + _INIT_CMD(0x00, 0xC0, 0x35), + _INIT_CMD(0x00, 0xC1, 0x62), + _INIT_CMD(0x00, 0xC2, 0x81), + _INIT_CMD(0x00, 0xC3, 0x96), + _INIT_CMD(0x00, 0xC4, 0x9E), + _INIT_CMD(0x00, 0xC5, 0xA5), + _INIT_CMD(0x00, 0xC6, 0xAD), + _INIT_CMD(0x00, 0xC7, 0xB1), + _INIT_CMD(0x00, 0xC8, 0xB4), + _INIT_CMD(0x00, 0xC9, 0x00), + _INIT_CMD(0x00, 0xCA, 0x00), + _INIT_CMD(0x00, 0xCB, 0x16), + _INIT_CMD(0x00, 0xCC, 0xAF), + _INIT_CMD(0x00, 0xCD, 0xFF), + _INIT_CMD(0x64, 0xCE, 0xFF), + _INIT_CMD(0x00, 0xB0, 0x00), + _INIT_CMD(0x00, 0xB3, 0x08), + _INIT_CMD(0x00, 0xB0, 0x04), + _INIT_CMD(0x0A, 0xB8, 0x68), + _INIT_CMD(0x78, 0x11), + _INIT_CMD(0x14, 0x29), + + {}, +}; + +static const struct panel_desc boe_himax8279d8p_panel_desc = { + .display_mode = &default_display_mode, + .bpc = 8, + .width_mm = 107, + .height_mm = 172, + .delay_t1 = 5000, + .reset_delay_t2 = 14000, + .reset_delay_t3 = 1000, + .reset_delay_t4 = 1000, + .reset_delay_t5 = 5000, + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | + MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM, + .format = MIPI_DSI_FMT_RGB888, + .lanes = 4, + .on_cmds = boe_himax8279d8p_on_cmds, + .off_cmds = default_off_cmds, +}; + +/* 10 inch */ +static const struct panel_cmd boe_himax8279d10p_on_cmds[] = { + _INIT_CMD(0x00, 0xB0, 0x05), + _INIT_CMD(0x00, 0xB1, 0xE5), + _INIT_CMD(0x00, 0xB3, 0x52), + _INIT_CMD(0x00, 0xB0, 0x00), + _INIT_CMD(0x00, 0xB3, 0x88), + _INIT_CMD(0x00, 0xB0, 0x04), + _INIT_CMD(0x00, 0xB8, 0x00), + _INIT_CMD(0x00, 0xB0, 0x00), + _INIT_CMD(0x00, 0xB2, 0x50), + _INIT_CMD(0x00, 0xB6, 0x03), + _INIT_CMD(0x00, 0xBA, 0x8B), + _INIT_CMD(0x00, 0xBF, 0x1A), + _INIT_CMD(0x00, 0xC0, 0x0F), + _INIT_CMD(0x00, 0xC2, 0x0C), + _INIT_CMD(0x00, 0xC3, 0x02), + _INIT_CMD(0x00, 0xC4, 0x0C), + _INIT_CMD(0x00, 0xC5, 0x02), + _INIT_CMD(0x00, 0xB0, 0x01), + _INIT_CMD(0x00, 0xE0, 0x26), + _INIT_CMD(0x00, 0xE1, 0x26), + _INIT_CMD(0x00, 0xDC, 0x00), + _INIT_CMD(0x00, 0xDD, 0x00), + _INIT_CMD(0x00, 0xCC, 0x26), + _INIT_CMD(0x00, 0xCD, 0x26), + _INIT_CMD(0x00, 0xC8, 0x00), + _INIT_CMD(0x00, 0xC9, 0x00), + _INIT_CMD(0x00, 0xD2, 0x04), + _INIT_CMD(0x00, 0xD3, 0x04), + _INIT_CMD(0x00, 0xE6, 0x03), + _INIT_CMD(0x00, 0xE7, 0x03), + _INIT_CMD(0x00, 0xC4, 0x08), + _INIT_CMD(0x00, 0xC5, 0x08), + _INIT_CMD(0x00, 0xD8, 0x07), + _INIT_CMD(0x00, 0xD9, 0x07), + _INIT_CMD(0x00, 0xC2, 0x06), + _INIT_CMD(0x00, 0xC3, 0x06), + _INIT_CMD(0x00, 0xD6, 0x05), + _INIT_CMD(0x00, 0xD7, 0x05), + _INIT_CMD(0x00, 0xC0, 0x0C), + _INIT_CMD(0x00, 0xC1, 0x0C), + _INIT_CMD(0x00, 0xD4, 0x0B), + _INIT_CMD(0x00, 0xD5, 0x0B), + _INIT_CMD(0x00, 0xCA, 0x0A), + _INIT_CMD(0x00, 0xCB, 0x0A), + _INIT_CMD(0x00, 0xDE, 0x09), + _INIT_CMD(0x00, 0xDF, 0x09), + _INIT_CMD(0x00, 0xC6, 0x26), + _INIT_CMD(0x00, 0xC7, 0x26), + _INIT_CMD(0x00, 0xCE, 0x00), + _INIT_CMD(0x00, 0xCF, 0x00), + _INIT_CMD(0x00, 0xDA, 0x26), + _INIT_CMD(0x00, 0xDB, 0x26), + _INIT_CMD(0x00, 0xE2, 0x00), + _INIT_CMD(0x00, 0xE3, 0x00), + _INIT_CMD(0x00, 0xB0, 0x02), + _INIT_CMD(0x00, 0xC0, 0x00), + _INIT_CMD(0x00, 0xC1, 0x07), + _INIT_CMD(0x00, 0xC2, 0x0D), + _INIT_CMD(0x00, 0xC3, 0x18), + _INIT_CMD(0x00, 0xC4, 0x27), + _INIT_CMD(0x00, 0xC5, 0x28), + _INIT_CMD(0x00, 0xC6, 0x30), + _INIT_CMD(0x00, 0xC7, 0x2E), + _INIT_CMD(0x00, 0xC8, 0x2F), + _INIT_CMD(0x00, 0xC9, 0x1A), + _INIT_CMD(0x00, 0xCA, 0x20), + _INIT_CMD(0x00, 0xCB, 0x29), + _INIT_CMD(0x00, 0xCC, 0x26), + _INIT_CMD(0x00, 0xCD, 0x32), + _INIT_CMD(0x00, 0xCE, 0x33), + _INIT_CMD(0x00, 0xCF, 0x31), + _INIT_CMD(0x00, 0xD0, 0x06), + _INIT_CMD(0x00, 0xD2, 0x00), + _INIT_CMD(0x00, 0xD3, 0x07), + _INIT_CMD(0x00, 0xD4, 0x12), + _INIT_CMD(0x00, 0xD5, 0x26), + _INIT_CMD(0x00, 0xD6, 0x3D), + _INIT_CMD(0x00, 0xD7, 0x3F), + _INIT_CMD(0x00, 0xD8, 0x3F), + _INIT_CMD(0x00, 0xD9, 0x3F), + _INIT_CMD(0x00, 0xDA, 0x3F), + _INIT_CMD(0x00, 0xDB, 0x3F), + _INIT_CMD(0x00, 0xDC, 0x3F), + _INIT_CMD(0x00, 0xDD, 0x3F), + _INIT_CMD(0x00, 0xDE, 0x3F), + _INIT_CMD(0x00, 0xDF, 0x3A), + _INIT_CMD(0x00, 0xE0, 0x37), + _INIT_CMD(0x00, 0xE1, 0x35), + _INIT_CMD(0x00, 0xE2, 0x07), + _INIT_CMD(0x00, 0xB0, 0x03), + _INIT_CMD(0x00, 0xC8, 0x0B), + _INIT_CMD(0x00, 0xC9, 0x07), + _INIT_CMD(0x00, 0xC3, 0x00), + _INIT_CMD(0x00, 0xE7, 0x00), + _INIT_CMD(0x00, 0xC5, 0x2A), + _INIT_CMD(0x00, 0xDE, 0x2A), + _INIT_CMD(0x00, 0xCA, 0x43), + _INIT_CMD(0x00, 0xC9, 0x07), + _INIT_CMD(0x00, 0xE4, 0xC0), + _INIT_CMD(0x00, 0xE5, 0x0D), + _INIT_CMD(0x00, 0xCB, 0x00), + _INIT_CMD(0x00, 0xB0, 0x06), + _INIT_CMD(0x00, 0xB8, 0xA5), + _INIT_CMD(0x00, 0xC0, 0xA5), + _INIT_CMD(0x00, 0xC7, 0x0F), + _INIT_CMD(0x00, 0xD5, 0x32), + _INIT_CMD(0x00, 0xB8, 0x00), + _INIT_CMD(0x00, 0xC0, 0x00), + _INIT_CMD(0x00, 0xBC, 0x00), + _INIT_CMD(0x00, 0xB0, 0x07), + _INIT_CMD(0x00, 0xB1, 0x00), + _INIT_CMD(0x00, 0xB2, 0x09), + _INIT_CMD(0x00, 0xB3, 0x19), + _INIT_CMD(0x00, 0xB4, 0x2F), + _INIT_CMD(0x00, 0xB5, 0x44), + _INIT_CMD(0x00, 0xB6, 0x52), + _INIT_CMD(0x00, 0xB7, 0x6A), + _INIT_CMD(0x00, 0xB8, 0x8A), + _INIT_CMD(0x00, 0xB9, 0xCA), + _INIT_CMD(0x00, 0xBA, 0x0C), + _INIT_CMD(0x00, 0xBB, 0x87), + _INIT_CMD(0x00, 0xBC, 0x06), + _INIT_CMD(0x00, 0xBD, 0x0A), + _INIT_CMD(0x00, 0xBE, 0x9B), + _INIT_CMD(0x00, 0xBF, 0x0C), + _INIT_CMD(0x00, 0xC0, 0x3D), + _INIT_CMD(0x00, 0xC1, 0x71), + _INIT_CMD(0x00, 0xC2, 0x90), + _INIT_CMD(0x00, 0xC3, 0xA0), + _INIT_CMD(0x00, 0xC4, 0xA8), + _INIT_CMD(0x00, 0xC5, 0xB1), + _INIT_CMD(0x00, 0xC6, 0xBB), + _INIT_CMD(0x00, 0xC7, 0xC0), + _INIT_CMD(0x00, 0xC8, 0xC4), + _INIT_CMD(0x00, 0xC9, 0x00), + _INIT_CMD(0x00, 0xCA, 0x00), + _INIT_CMD(0x00, 0xCB, 0x16), + _INIT_CMD(0x00, 0xCC, 0xAF), + _INIT_CMD(0x00, 0xCD, 0xFF), + _INIT_CMD(0x00, 0xCE, 0xFF), + _INIT_CMD(0x00, 0xB0, 0x08), + _INIT_CMD(0x00, 0xB1, 0x04), + _INIT_CMD(0x00, 0xB2, 0x08), + _INIT_CMD(0x00, 0xB3, 0x19), + _INIT_CMD(0x00, 0xB4, 0x31), + _INIT_CMD(0x00, 0xB5, 0x46), + _INIT_CMD(0x00, 0xB6, 0x55), + _INIT_CMD(0x00, 0xB7, 0x6E), + _INIT_CMD(0x00, 0xB8, 0x92), + _INIT_CMD(0x00, 0xB9, 0xD4), + _INIT_CMD(0x00, 0xBA, 0x1B), + _INIT_CMD(0x00, 0xBB, 0x9B), + _INIT_CMD(0x00, 0xBC, 0x28), + _INIT_CMD(0x00, 0xBD, 0x2D), + _INIT_CMD(0x00, 0xBE, 0xC3), + _INIT_CMD(0x00, 0xBF, 0x2F), + _INIT_CMD(0x00, 0xC0, 0x62), + _INIT_CMD(0x00, 0xC1, 0x99), + _INIT_CMD(0x00, 0xC2, 0xAB), + _INIT_CMD(0x00, 0xC3, 0xBF), + _INIT_CMD(0x00, 0xC4, 0xCF), + _INIT_CMD(0x00, 0xC5, 0xDF), + _INIT_CMD(0x00, 0xC6, 0xF0), + _INIT_CMD(0x00, 0xC7, 0xF9), + _INIT_CMD(0x00, 0xC8, 0xFC), + _INIT_CMD(0x00, 0xC9, 0x00), + _INIT_CMD(0x00, 0xCA, 0x00), + _INIT_CMD(0x00, 0xCB, 0x16), + _INIT_CMD(0x00, 0xCC, 0xAF), + _INIT_CMD(0x00, 0xCD, 0xFF), + _INIT_CMD(0x00, 0xCE, 0xFF), + _INIT_CMD(0x00, 0xB0, 0x09), + _INIT_CMD(0x00, 0xB1, 0x04), + _INIT_CMD(0x00, 0xB2, 0x05), + _INIT_CMD(0x00, 0xB3, 0x17), + _INIT_CMD(0x00, 0xB4, 0x2E), + _INIT_CMD(0x00, 0xB5, 0x42), + _INIT_CMD(0x00, 0xB6, 0x51), + _INIT_CMD(0x00, 0xB7, 0x69), + _INIT_CMD(0x00, 0xB8, 0x88), + _INIT_CMD(0x00, 0xB9, 0xC9), + _INIT_CMD(0x00, 0xBA, 0x0C), + _INIT_CMD(0x00, 0xBB, 0x86), + _INIT_CMD(0x00, 0xBC, 0x03), + _INIT_CMD(0x00, 0xBD, 0x08), + _INIT_CMD(0x00, 0xBE, 0x95), + _INIT_CMD(0x00, 0xBF, 0x05), + _INIT_CMD(0x00, 0xC0, 0x35), + _INIT_CMD(0x00, 0xC1, 0x62), + _INIT_CMD(0x00, 0xC2, 0x81), + _INIT_CMD(0x00, 0xC3, 0x96), + _INIT_CMD(0x00, 0xC4, 0x9E), + _INIT_CMD(0x00, 0xC5, 0xA5), + _INIT_CMD(0x00, 0xC6, 0xAD), + _INIT_CMD(0x00, 0xC7, 0xB1), + _INIT_CMD(0x00, 0xC8, 0xB4), + _INIT_CMD(0x00, 0xC9, 0x00), + _INIT_CMD(0x00, 0xCA, 0x00), + _INIT_CMD(0x00, 0xCB, 0x16), + _INIT_CMD(0x00, 0xCC, 0xAF), + _INIT_CMD(0x00, 0xCD, 0xFF), + _INIT_CMD(0x00, 0xCE, 0xFF), + _INIT_CMD(0x00, 0xB0, 0x0A), + _INIT_CMD(0x00, 0xB1, 0x00), + _INIT_CMD(0x00, 0xB2, 0x09), + _INIT_CMD(0x00, 0xB3, 0x19), + _INIT_CMD(0x00, 0xB4, 0x2F), + _INIT_CMD(0x00, 0xB5, 0x44), + _INIT_CMD(0x00, 0xB6, 0x52), + _INIT_CMD(0x00, 0xB7, 0x6A), + _INIT_CMD(0x00, 0xB8, 0x8A), + _INIT_CMD(0x00, 0xB9, 0xCA), + _INIT_CMD(0x00, 0xBA, 0x0C), + _INIT_CMD(0x00, 0xBB, 0x87), + _INIT_CMD(0x00, 0xBC, 0x06), + _INIT_CMD(0x00, 0xBD, 0x0A), + _INIT_CMD(0x00, 0xBE, 0x9B), + _INIT_CMD(0x00, 0xBF, 0x0C), + _INIT_CMD(0x00, 0xC0, 0x3D), + _INIT_CMD(0x00, 0xC1, 0x71), + _INIT_CMD(0x00, 0xC2, 0x90), + _INIT_CMD(0x00, 0xC3, 0xA0), + _INIT_CMD(0x00, 0xC4, 0xA8), + _INIT_CMD(0x00, 0xC5, 0xB1), + _INIT_CMD(0x00, 0xC6, 0xBB), + _INIT_CMD(0x00, 0xC7, 0xC0), + _INIT_CMD(0x00, 0xC8, 0xC4), + _INIT_CMD(0x00, 0xC9, 0x00), + _INIT_CMD(0x00, 0xCA, 0x00), + _INIT_CMD(0x00, 0xCB, 0x16), + _INIT_CMD(0x00, 0xCC, 0xAF), + _INIT_CMD(0x00, 0xCD, 0xFF), + _INIT_CMD(0x00, 0xCE, 0xFF), + _INIT_CMD(0x00, 0xB0, 0x0B), + _INIT_CMD(0x00, 0xB1, 0x04), + _INIT_CMD(0x00, 0xB2, 0x08), + _INIT_CMD(0x00, 0xB3, 0x19), + _INIT_CMD(0x00, 0xB4, 0x31), + _INIT_CMD(0x00, 0xB5, 0x46), + _INIT_CMD(0x00, 0xB6, 0x55), + _INIT_CMD(0x00, 0xB7, 0x6E), + _INIT_CMD(0x00, 0xB8, 0x92), + _INIT_CMD(0x00, 0xB9, 0xD4), + _INIT_CMD(0x00, 0xBA, 0x1B), + _INIT_CMD(0x00, 0xBB, 0x9B), + _INIT_CMD(0x00, 0xBC, 0x28), + _INIT_CMD(0x00, 0xBD, 0x2D), + _INIT_CMD(0x00, 0xBE, 0xC3), + _INIT_CMD(0x00, 0xBF, 0x2F), + _INIT_CMD(0x00, 0xC0, 0x62), + _INIT_CMD(0x00, 0xC1, 0x99), + _INIT_CMD(0x00, 0xC2, 0xAB), + _INIT_CMD(0x00, 0xC3, 0xBF), + _INIT_CMD(0x00, 0xC4, 0xCF), + _INIT_CMD(0x00, 0xC5, 0xDF), + _INIT_CMD(0x00, 0xC6, 0xF0), + _INIT_CMD(0x00, 0xC7, 0xF9), + _INIT_CMD(0x00, 0xC8, 0xFC), + _INIT_CMD(0x00, 0xC9, 0x00), + _INIT_CMD(0x00, 0xCA, 0x00), + _INIT_CMD(0x00, 0xCB, 0x16), + _INIT_CMD(0x00, 0xCC, 0xAF), + _INIT_CMD(0x00, 0xCD, 0xFF), + _INIT_CMD(0x00, 0xCE, 0xFF), + _INIT_CMD(0x00, 0xB0, 0x0C), + _INIT_CMD(0x00, 0xB1, 0x04), + _INIT_CMD(0x00, 0xB2, 0x05), + _INIT_CMD(0x00, 0xB3, 0x17), + _INIT_CMD(0x00, 0xB4, 0x2E), + _INIT_CMD(0x00, 0xB5, 0x42), + _INIT_CMD(0x00, 0xB6, 0x51), + _INIT_CMD(0x00, 0xB7, 0x69), + _INIT_CMD(0x00, 0xB8, 0x88), + _INIT_CMD(0x00, 0xB9, 0xC9), + _INIT_CMD(0x00, 0xBA, 0x0C), + _INIT_CMD(0x00, 0xBB, 0x86), + _INIT_CMD(0x00, 0xBC, 0x03), + _INIT_CMD(0x00, 0xBD, 0x08), + _INIT_CMD(0x00, 0xBE, 0x95), + _INIT_CMD(0x00, 0xBF, 0x05), + _INIT_CMD(0x00, 0xC0, 0x35), + _INIT_CMD(0x00, 0xC1, 0x62), + _INIT_CMD(0x00, 0xC2, 0x81), + _INIT_CMD(0x00, 0xC3, 0x96), + _INIT_CMD(0x00, 0xC4, 0x9E), + _INIT_CMD(0x00, 0xC5, 0xA5), + _INIT_CMD(0x00, 0xC6, 0xAD), + _INIT_CMD(0x00, 0xC7, 0xB1), + _INIT_CMD(0x00, 0xC8, 0xB4), + _INIT_CMD(0x00, 0xC9, 0x00), + _INIT_CMD(0x00, 0xCA, 0x00), + _INIT_CMD(0x00, 0xCB, 0x16), + _INIT_CMD(0x00, 0xCC, 0xAF), + _INIT_CMD(0x00, 0xCD, 0xFF), + _INIT_CMD(0x00, 0xCE, 0xFF), + _INIT_CMD(0x00, 0xB0, 0x00), + _INIT_CMD(0x00, 0xB3, 0x08), + _INIT_CMD(0x00, 0xB0, 0x04), + _INIT_CMD(0x64, 0xB8, 0x68), + + {}, +}; + +static const struct panel_desc boe_himax8279d10p_panel_desc = { + .display_mode = &default_display_mode, + .bpc = 8, + .width_mm = 135, + .height_mm = 216, + .delay_t1 = 5000, + .reset_delay_t2 = 14000, + .reset_delay_t3 = 1000, + .reset_delay_t4 = 1000, + .reset_delay_t5 = 5000, + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | + MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM, + .format = MIPI_DSI_FMT_RGB888, + .lanes = 4, + .on_cmds = boe_himax8279d10p_on_cmds, + .off_cmds = default_off_cmds, +}; + +static const struct of_device_id panel_of_match[] = { + { .compatible = "boe,himax8279d8p", + .data = &boe_himax8279d8p_panel_desc + }, { .compatible = "boe,himax8279d10p", + .data = &boe_himax8279d10p_panel_desc + }, { + /* sentinel */ + } +}; +MODULE_DEVICE_TABLE(of, panel_of_match); + +static int panel_add(struct panel_info *pinfo) +{ + struct device *dev = &pinfo->link->dev; + int ret; + + pinfo->pp18_gpio = devm_gpiod_get_optional(dev, "pp18", GPIOD_OUT_HIGH); + if (IS_ERR(pinfo->pp18_gpio)) { + ret = PTR_ERR(pinfo->pp18_gpio); + if (ret != -EPROBE_DEFER) + DRM_DEV_ERROR(dev, "failed to get pp18 gpio: %d\n", + ret); + return ret; + } + + pinfo->pp33_gpio = devm_gpiod_get_optional(dev, "pp33", GPIOD_OUT_HIGH); + if (IS_ERR(pinfo->pp33_gpio)) { + ret = PTR_ERR(pinfo->pp33_gpio); + if (ret != -EPROBE_DEFER) + DRM_DEV_ERROR(dev, "failed to get pp33 gpio: %d\n", + ret); + return ret; + } + + pinfo->enable_gpio = devm_gpiod_get_optional(dev, "enable", + GPIOD_OUT_HIGH); + if (IS_ERR(pinfo->enable_gpio)) { + ret = PTR_ERR(pinfo->enable_gpio); + if (ret != -EPROBE_DEFER) + DRM_DEV_ERROR(dev, "failed to get enable gpio: %d\n", + ret); + return ret; + } + + pinfo->backlight = devm_of_find_backlight(dev); + if (IS_ERR(pinfo->backlight)) + return PTR_ERR(pinfo->backlight); + + drm_panel_init(&pinfo->base); + pinfo->base.funcs = &panel_funcs; + pinfo->base.dev = &pinfo->link->dev; + + ret = drm_panel_add(&pinfo->base); + if (ret < 0) + return ret; + + return 0; +} + +static void panel_del(struct panel_info *pinfo) +{ + if (pinfo->base.dev) + drm_panel_remove(&pinfo->base); +} + +static int panel_probe(struct mipi_dsi_device *dsi) +{ + struct panel_info *pinfo; + const struct panel_desc *desc; + int err; + + pinfo = devm_kzalloc(&dsi->dev, sizeof(*pinfo), GFP_KERNEL); + if (!pinfo) + return -ENOMEM; + + desc = of_device_get_match_data(&dsi->dev); + dsi->mode_flags = desc->mode_flags; + dsi->format = desc->format; + dsi->lanes = desc->lanes; + pinfo->desc = desc; + + pinfo->link = dsi; + mipi_dsi_set_drvdata(dsi, pinfo); + + err = panel_add(pinfo); + if (err < 0) + return err; + + return mipi_dsi_attach(dsi); +} + +static int panel_remove(struct mipi_dsi_device *dsi) +{ + struct panel_info *pinfo = mipi_dsi_get_drvdata(dsi); + int err; + + err = boe_panel_unprepare(&pinfo->base); + if (err < 0) + DRM_DEV_ERROR(&dsi->dev, "failed to unprepare panel: %d\n", + err); + + err = boe_panel_disable(&pinfo->base); + if (err < 0) + DRM_DEV_ERROR(&dsi->dev, "failed to disable panel: %d\n", err); + + err = mipi_dsi_detach(dsi); + if (err < 0) + DRM_DEV_ERROR(&dsi->dev, "failed to detach from DSI host: %d\n", + err); + + drm_panel_detach(&pinfo->base); + panel_del(pinfo); + + return 0; +} + +static void panel_shutdown(struct mipi_dsi_device *dsi) +{ + struct panel_info *pinfo = mipi_dsi_get_drvdata(dsi); + + boe_panel_disable(&pinfo->base); + boe_panel_unprepare(&pinfo->base); +} + +static struct mipi_dsi_driver panel_driver = { + .driver = { + .name = "panel-boe-himax8279d", + .of_match_table = panel_of_match, + }, + .probe = panel_probe, + .remove = panel_remove, + .shutdown = panel_shutdown, +}; +module_mipi_dsi_driver(panel_driver); + +MODULE_AUTHOR("Jerry Han <jerry.han.hq(a)gmail.com>"); +MODULE_DESCRIPTION("Boe Himax8279d driver"); +MODULE_LICENSE("GPL v2"); -- 2.17.1

3 6

[PATCH] video: fbdev: omapfb_main: Mark expected switch fall-throughs
by Gustavo A. R. Silva 03 Aug '19

03 Aug '19

Mark switch cases where we are expecting to fall through. This patch fixes the following warning (Building: omap1_defconfig arm): drivers/video/fbdev/omap/omapfb_main.c:449:23: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/video/fbdev/omap/omapfb_main.c:1549:6: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/video/fbdev/omap/omapfb_main.c:1547:3: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/video/fbdev/omap/omapfb_main.c:1545:3: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/video/fbdev/omap/omapfb_main.c:1543:3: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/video/fbdev/omap/omapfb_main.c:1540:6: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/video/fbdev/omap/omapfb_main.c:1538:3: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/video/fbdev/omap/omapfb_main.c:1535:3: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Gustavo A. R. Silva <gustavo(a)embeddedor.com> --- drivers/video/fbdev/omap/omapfb_main.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c index 90eca64e3144..702cca59bda1 100644 --- a/drivers/video/fbdev/omap/omapfb_main.c +++ b/drivers/video/fbdev/omap/omapfb_main.c @@ -447,6 +447,7 @@ static int set_color_mode(struct omapfb_plane_struct *plane, return 0; case 12: var->bits_per_pixel = 16; + /* fall through */ case 16: if (plane->fbdev->panel->bpp == 12) plane->color_mode = OMAPFB_COLOR_RGB444; @@ -1534,20 +1535,27 @@ static void omapfb_free_resources(struct omapfb_device *fbdev, int state) case OMAPFB_ACTIVE: for (i = 0; i < fbdev->mem_desc.region_cnt; i++) unregister_framebuffer(fbdev->fb_info[i]); + /* fall through */ case 7: omapfb_unregister_sysfs(fbdev); + /* fall through */ case 6: if (fbdev->panel->disable) fbdev->panel->disable(fbdev->panel); + /* fall through */ case 5: omapfb_set_update_mode(fbdev, OMAPFB_UPDATE_DISABLED); + /* fall through */ case 4: planes_cleanup(fbdev); + /* fall through */ case 3: ctrl_cleanup(fbdev); + /* fall through */ case 2: if (fbdev->panel->cleanup) fbdev->panel->cleanup(fbdev->panel); + /* fall through */ case 1: dev_set_drvdata(fbdev->dev, NULL); kfree(fbdev); -- 2.22.0

2 1

[PATCH 00/34] put_user_pages(): miscellaneous call sites
by john.hubbard＠gmail.com 02 Aug '19

02 Aug '19

From: John Hubbard <jhubbard(a)nvidia.com> Hi, These are best characterized as miscellaneous conversions: many (not all) call sites that don't involve biovec or iov_iter, nor mm/. It also leaves out a few call sites that require some more work. These are mostly pretty simple ones. It's probably best to send all of these via Andrew's -mm tree, assuming that there are no significant merge conflicts with ongoing work in other trees (which I doubt, given that these are small changes). These patches apply to the latest linux.git. Patch #1 is also already in Andrew's tree, but given the broad non-linux-mm Cc list, I thought it would be more convenient to just include that patch here, so that people can use linux.git as the base--even though these are probably destined for linux-mm. This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder versions"). That commit has an extensive description of the problem and the planned steps to solve it, but the highlites are: 1) Provide put_user_page*() routines, intended to be used for releasing pages that were pinned via get_user_pages*(). 2) Convert all of the call sites for get_user_pages*(), to invoke put_user_page*(), instead of put_page(). This involves dozens of call sites, and will take some time. 3) After (2) is complete, use get_user_pages*() and put_user_page*() to implement tracking of these pages. This tracking will be separate from the existing struct page refcounting. 4) Use the tracking and identification of these pages, to implement special handling (especially in writeback paths) when the pages are backed by a filesystem. And a few references, also from that commit: [1] https://lwn.net/Articles/774411/ : "DMA and get_user_pages()" [2] https://lwn.net/Articles/753027/ : "The Trouble with get_user_pages()" Ira Weiny (1): fs/binfmt_elf: convert put_page() to put_user_page*() John Hubbard (33): mm/gup: add make_dirty arg to put_user_pages_dirty_lock() net/rds: convert put_page() to put_user_page*() net/ceph: convert put_page() to put_user_page*() x86/kvm: convert put_page() to put_user_page*() drm/etnaviv: convert release_pages() to put_user_pages() drm/i915: convert put_page() to put_user_page*() drm/radeon: convert put_page() to put_user_page*() media/ivtv: convert put_page() to put_user_page*() media/v4l2-core/mm: convert put_page() to put_user_page*() genwqe: convert put_page() to put_user_page*() scif: convert put_page() to put_user_page*() vmci: convert put_page() to put_user_page*() rapidio: convert put_page() to put_user_page*() oradax: convert put_page() to put_user_page*() staging/vc04_services: convert put_page() to put_user_page*() drivers/tee: convert put_page() to put_user_page*() vfio: convert put_page() to put_user_page*() fbdev/pvr2fb: convert put_page() to put_user_page*() fsl_hypervisor: convert put_page() to put_user_page*() xen: convert put_page() to put_user_page*() fs/exec.c: convert put_page() to put_user_page*() orangefs: convert put_page() to put_user_page*() uprobes: convert put_page() to put_user_page*() futex: convert put_page() to put_user_page*() mm/frame_vector.c: convert put_page() to put_user_page*() mm/gup_benchmark.c: convert put_page() to put_user_page*() mm/memory.c: convert put_page() to put_user_page*() mm/madvise.c: convert put_page() to put_user_page*() mm/process_vm_access.c: convert put_page() to put_user_page*() crypt: convert put_page() to put_user_page*() nfs: convert put_page() to put_user_page*() goldfish_pipe: convert put_page() to put_user_page*() kernel/events/core.c: convert put_page() to put_user_page*() arch/x86/kvm/svm.c | 4 +- crypto/af_alg.c | 7 +- drivers/gpu/drm/etnaviv/etnaviv_gem.c | 4 +- drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 9 +- drivers/gpu/drm/radeon/radeon_ttm.c | 2 +- drivers/infiniband/core/umem.c | 5 +- drivers/infiniband/hw/hfi1/user_pages.c | 5 +- drivers/infiniband/hw/qib/qib_user_pages.c | 5 +- drivers/infiniband/hw/usnic/usnic_uiom.c | 5 +- drivers/infiniband/sw/siw/siw_mem.c | 10 +- drivers/media/pci/ivtv/ivtv-udma.c | 14 +-- drivers/media/pci/ivtv/ivtv-yuv.c | 10 +- drivers/media/v4l2-core/videobuf-dma-sg.c | 3 +- drivers/misc/genwqe/card_utils.c | 17 +-- drivers/misc/mic/scif/scif_rma.c | 17 ++- drivers/misc/vmw_vmci/vmci_context.c | 2 +- drivers/misc/vmw_vmci/vmci_queue_pair.c | 11 +- drivers/platform/goldfish/goldfish_pipe.c | 9 +- drivers/rapidio/devices/rio_mport_cdev.c | 9 +- drivers/sbus/char/oradax.c | 2 +- .../interface/vchiq_arm/vchiq_2835_arm.c | 10 +- drivers/tee/tee_shm.c | 10 +- drivers/vfio/vfio_iommu_type1.c | 8 +- drivers/video/fbdev/pvr2fb.c | 3 +- drivers/virt/fsl_hypervisor.c | 7 +- drivers/xen/gntdev.c | 5 +- drivers/xen/privcmd.c | 7 +- fs/binfmt_elf.c | 2 +- fs/binfmt_elf_fdpic.c | 2 +- fs/exec.c | 2 +- fs/nfs/direct.c | 4 +- fs/orangefs/orangefs-bufmap.c | 7 +- include/linux/mm.h | 5 +- kernel/events/core.c | 2 +- kernel/events/uprobes.c | 6 +- kernel/futex.c | 10 +- mm/frame_vector.c | 4 +- mm/gup.c | 115 ++++++++---------- mm/gup_benchmark.c | 2 +- mm/madvise.c | 2 +- mm/memory.c | 2 +- mm/process_vm_access.c | 18 +-- net/ceph/pagevec.c | 8 +- net/rds/info.c | 5 +- net/rds/message.c | 2 +- net/rds/rdma.c | 15 ++- virt/kvm/kvm_main.c | 4 +- 47 files changed, 151 insertions(+), 266 deletions(-) -- 2.22.0

3 5

[PATCH AUTOSEL 4.14 11/30] drm/msm: stop abusing dma_map/unmap for cache
by Sasha Levin 02 Aug '19

02 Aug '19

From: Rob Clark <robdclark(a)chromium.org> [ Upstream commit 0036bc73ccbe7e600a3468bf8e8879b122252274 ] Recently splats like this started showing up: WARNING: CPU: 4 PID: 251 at drivers/iommu/dma-iommu.c:451 __iommu_dma_unmap+0xb8/0xc0 Modules linked in: ath10k_snoc ath10k_core fuse msm ath mac80211 uvcvideo cfg80211 videobuf2_vmalloc videobuf2_memops vide CPU: 4 PID: 251 Comm: kworker/u16:4 Tainted: G W 5.2.0-rc5-next-20190619+ #2317 Hardware name: LENOVO 81JL/LNVNB161216, BIOS 9UCN23WW(V1.06) 10/25/2018 Workqueue: msm msm_gem_free_work [msm] pstate: 80c00005 (Nzcv daif +PAN +UAO) pc : __iommu_dma_unmap+0xb8/0xc0 lr : __iommu_dma_unmap+0x54/0xc0 sp : ffff0000119abce0 x29: ffff0000119abce0 x28: 0000000000000000 x27: ffff8001f9946648 x26: ffff8001ec271068 x25: 0000000000000000 x24: ffff8001ea3580a8 x23: ffff8001f95ba010 x22: ffff80018e83ba88 x21: ffff8001e548f000 x20: fffffffffffff000 x19: 0000000000001000 x18: 00000000c00001fe x17: 0000000000000000 x16: 0000000000000000 x15: ffff000015b70068 x14: 0000000000000005 x13: 0003142cc1be1768 x12: 0000000000000001 x11: ffff8001f6de9100 x10: 0000000000000009 x9 : ffff000015b78000 x8 : 0000000000000000 x7 : 0000000000000001 x6 : fffffffffffff000 x5 : 0000000000000fff x4 : ffff00001065dbc8 x3 : 000000000000000d x2 : 0000000000001000 x1 : fffffffffffff000 x0 : 0000000000000000 Call trace: __iommu_dma_unmap+0xb8/0xc0 iommu_dma_unmap_sg+0x98/0xb8 put_pages+0x5c/0xf0 [msm] msm_gem_free_work+0x10c/0x150 [msm] process_one_work+0x1e0/0x330 worker_thread+0x40/0x438 kthread+0x12c/0x130 ret_from_fork+0x10/0x18 ---[ end trace afc0dc5ab81a06bf ]--- Not quite sure what triggered that, but we really shouldn't be abusing dma_{map,unmap}_sg() for cache maint. Cc: Stephen Boyd <sboyd(a)kernel.org> Tested-by: Stephen Boyd <swboyd(a)chromium.org> Reviewed-by: Jordan Crouse <jcrouse(a)codeaurora.org> Signed-off-by: Rob Clark <robdclark(a)chromium.org> Signed-off-by: Sean Paul <seanpaul(a)chromium.org> Link: https://patchwork.freedesktop.org/patch/msgid/20190630124735.27786-1-robdcl… Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/msm/msm_gem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index f2df718af370d..3a91ccd92c473 100644 --- a/drivers/gpu/drm/msm/msm_gem.c +++ b/drivers/gpu/drm/msm/msm_gem.c @@ -108,7 +108,7 @@ static struct page **get_pages(struct drm_gem_object *obj) * because display controller, GPU, etc. are not coherent: */ if (msm_obj->flags & (MSM_BO_WC|MSM_BO_UNCACHED)) - dma_map_sg(dev->dev, msm_obj->sgt->sgl, + dma_sync_sg_for_device(dev->dev, msm_obj->sgt->sgl, msm_obj->sgt->nents, DMA_BIDIRECTIONAL); } @@ -138,7 +138,7 @@ static void put_pages(struct drm_gem_object *obj) * GPU, etc. are not coherent: */ if (msm_obj->flags & (MSM_BO_WC|MSM_BO_UNCACHED)) - dma_unmap_sg(obj->dev->dev, msm_obj->sgt->sgl, + dma_sync_sg_for_cpu(obj->dev->dev, msm_obj->sgt->sgl, msm_obj->sgt->nents, DMA_BIDIRECTIONAL); -- 2.20.1

2 1

Re: [PATCH] drm/syncobj: remove boring message
by Koenig, Christian 02 Aug '19

02 Aug '19

Am 02.08.2019 18:28 schrieb Jason Ekstrand <jason(a)jlekstrand.net>: On Thu, Aug 1, 2019 at 9:05 AM Koenig, Christian <Christian.Koenig(a)amd.com<mailto:Christian.Koenig@amd.com>> wrote: Am 01.08.19 um 15:45 schrieb Lionel Landwerlin: > Just had a few exchanges with Chris about this. > Chris suggests that if we're about to add a point to the timeline in > an unordered fashion, actually better not add it at all. > > What's your take on this? That is a clear NAK. See not adding a point at all means we lose some synchronization and that is not something we can do here. In other words syncing to much if userspace does something nasty is ok and defensive programmed, but not syncing at all could have unforeseen consequences. So if process A signals 7, process B detects that and signals 3 and then process A tries to insert something which waits on 7 and signals 8, what happens? My understanding is that it "breaks" the timeline and so, from the perspective of process A, its signal operation on 7 is gone and it's attempt to wait on 7 will either -EINVAL because the kernel can't find the time point or else just sit there. Am I understanding this correctly? Nope, what happens is that we note the largest signaled seqno and wait for everything without returning an error. For example if we have signaled 7 and then 3 then any waiting for 7 we would wait for both 3 and 7. If so, it sounds more like an attack vector than defensive programming to me. Yeah, completely agree. That's why I also rejected the idea to return an error on wait. Yes, more syncornization is generally better than less. However, if you're screwing up your syncronization from userspace and getting wrong rendering results, that's your fault. If you're causing your compositor to suddenly start seeing -EINVAL which gets turned into VK_ERROR_DEVICE_LOST, that's a lot worse IMO. I'm not saying that we shouldn't try to be robust in this case; I'm just concerned that the suggest solution isn't. Completely agree as well. The key point is we need to find a balance between keeping things working and signaling that something is wrong. I mean the two options we have is to either ignore such errors and do the most defensive thing we can. And the current solution is already pretty good at that. Or we can signal those errors but risk that it can be used for a deny of service. Regards, Christian. --Jason Another idea would be to add the fence, but also set an error flag and deny any further signaling on that syncobj. Regards, Christian. > I'm fine with this, but rather than add another variant of add_point() > maybe we change change the existing. > > Thanks, > > -Lionel > > On 29/07/2019 11:20, Chunming Zhou wrote: >> It is normal that binary syncobj replaces the underlying fence. >> >> Signed-off-by: Chunming Zhou <david1.zhou(a)amd.com<mailto:david1.zhou@amd.com>> >> --- >> drivers/gpu/drm/drm_syncobj.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_syncobj.c >> b/drivers/gpu/drm/drm_syncobj.c >> index 929f7c64f9a2..bc7ec1679e4d 100644 >> --- a/drivers/gpu/drm/drm_syncobj.c >> +++ b/drivers/gpu/drm/drm_syncobj.c >> @@ -151,9 +151,6 @@ void drm_syncobj_add_point(struct drm_syncobj >> *syncobj, >> spin_lock(&syncobj->lock); >> prev = drm_syncobj_fence_get(syncobj); >> - /* You are adding an unorder point to timeline, which could >> cause payload returned from query_ioctl is 0! */ >> - if (prev && prev->seqno >= point) >> - DRM_ERROR("You are adding an unorder point to timeline!\n"); >> dma_fence_chain_init(chain, prev, fence, point); >> rcu_assign_pointer(syncobj->fence, &chain->base); > > _______________________________________________ dri-devel mailing list dri-devel(a)lists.freedesktop.org<mailto:dri-devel@lists.freedesktop.org> https://lists.freedesktop.org/mailman/listinfo/dri-devel

2 1

[PATCH] drm/syncobj: remove boring message
by Chunming Zhou 02 Aug '19

02 Aug '19

It is normal that binary syncobj replaces the underlying fence. Signed-off-by: Chunming Zhou <david1.zhou(a)amd.com> --- drivers/gpu/drm/drm_syncobj.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index 929f7c64f9a2..bc7ec1679e4d 100644 --- a/drivers/gpu/drm/drm_syncobj.c +++ b/drivers/gpu/drm/drm_syncobj.c @@ -151,9 +151,6 @@ void drm_syncobj_add_point(struct drm_syncobj *syncobj, spin_lock(&syncobj->lock); prev = drm_syncobj_fence_get(syncobj); - /* You are adding an unorder point to timeline, which could cause payload returned from query_ioctl is 0! */ - if (prev && prev->seqno >= point) - DRM_ERROR("You are adding an unorder point to timeline!\n"); dma_fence_chain_init(chain, prev, fence, point); rcu_assign_pointer(syncobj->fence, &chain->base); -- 2.17.1

6 9

[Bug 111243] Installation of 19.20 Fails
by bugzilla-daemon＠freedesktop.org 02 Aug '19

02 Aug '19

https://bugs.freedesktop.org/show_bug.cgi?id=111243 Bug ID: 111243 Summary: Installation of 19.20 Fails Product: DRI Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu-pro Assignee: dri-devel(a)lists.freedesktop.org Reporter: Jacque8080(a)gmail.com Created attachment 144899 --> https://bugs.freedesktop.org/attachment.cgi?id=144899&action=edit Logs Recommended by AMD deb [ trusted=yes ] file:/var/opt/amdgpu-pro-local/ ./ Get:1 file:/var/opt/amdgpu-pro-local ./ InRelease Ign:1 file:/var/opt/amdgpu-pro-local ./ InRelease Get:2 file:/var/opt/amdgpu-pro-local ./ Release [816 B] Get:2 file:/var/opt/amdgpu-pro-local ./ Release [816 B] Get:3 file:/var/opt/amdgpu-pro-local ./ Release.gpg Ign:3 file:/var/opt/amdgpu-pro-local ./ Release.gpg Hit:4 http://repo.steampowered.com/steam precise InRelease Hit:5 http://us.archive.ubuntu.com/ubuntu bionic InRelease Get:6 http://us.archive.ubuntu.com/ubuntu bionic-updates InRelease [88.7 kB] Get:7 http://security.ubuntu.com/ubuntu bionic-security InRelease [88.7 kB] Hit:8 http://ppa.launchpad.net/teejee2008/ppa/ubuntu bionic InRelease Get:9 http://us.archive.ubuntu.com/ubuntu bionic-backports InRelease [74.6 kB] Fetched 252 kB in 1s (294 kB/s) Reading package lists... Done Reading package lists... Done Building dependency tree Reading state information... Done amdgpu-pro-pin is already the newest version (19.20-812932). Selected version '19.20-812932' (localhost [all]) for 'amdgpu-pro-pin' 0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded. 3 not fully installed or removed. After this operation, 0 B of additional disk space will be used. Setting up libgl1-amdgpu-pro-ext-hwe:amd64 (19.20-812932) ... ln: failed to create symbolic link '/opt/amdgpu-pro/lib/xorg/modules/extensions/libglx.so': File e xists dpkg: error processing package libgl1-amdgpu-pro-ext-hwe:amd64 (--configure): installed libgl1-amdgpu-pro-ext-hwe:amd64 package post-installation script subprocess returned er ror exit status 1 dpkg: dependency problems prevent configuration of amdgpu-pro-hwe: amdgpu-pro-hwe depends on libgl1-amdgpu-pro-ext-hwe (= 19.20-812932); however: Package libgl1-amdgpu-pro-ext-hwe:amd64 is not configured yet. dpkg: error processing package amdgpu-pro-hwe (--configure): dependency problems - leaving unconfigured dpkg: dependency problems prevent configuration of amdgpu-pro-lib32: amdgpu-pro-lib32 depends on amdgpu-pro (= 19.20-812932) | amdgpu-pro-hwe (= 19.20-812932); howeve r: Package amdgpu-pro is not installed. Package amdgpu-pro-hwe is not configured yet. dpkg: error processing package amdgpu-pro-lib32 (--configure): dependency problems - leaving unconfigured No apport report written because the error message indicates its a followup error from a previous failure. No apport report written because the error message indicates its a followup error from a p revious failure. Errors were encountered while processing: libgl1-amdgpu-pro-ext-hwe:amd64 amdgpu-pro-hwe amdgpu-pro-lib32 E: Sub-process /usr/bin/dpkg returned an error code (1) -- You are receiving this mail because: You are the assignee for the bug.

1 4

[PATCH v1 0/11] drm: header maintenance
by Sam Ravnborg 02 Aug '19

02 Aug '19

First patch from Jani fixes so drm_print.h is self-contained. Next two patches are trivial removal of uapi dependencies. ati_pcigart is fixed to drop use of drm_os_linux.h drm_vblank is likewise fixed to drop use of drm_os_linux.h This was a non-trivial conversion, *review requested!* The remaining patches are preparation for and removal of uapi/drm/drmh from drm_file.h. There were a few files where we had to push include of drm/drm.h out to to have a clean build. CK Hu - please let me apply the mediatek patch to drm-misc-next, as it is required for the final patch. Or push it to drm-misc-next yourself. Sam Jani Nikula (1): drm/panel: make drm_panel.h self-contained Sam Ravnborg (10): drm: drop uapi dependency from drm_print.h drm: drop uapi dependency from drm_vblank.h drm/ati_pcigart: drop dependency on drm_os_linux.h drm/vblank: drop use of DRM_WAIT_ON() drm: direct include of drm.h in drm_gem.c drm: direct include of drm.h in drm_gem_shmem_helper.c drm: direct include of drm.h in drm_prime.c drm: direct include of drm.h in drm_syncobj.c drm/mediatek: direct include of drm.h in mtk_drm_gem.c drm: drop uapi dependency from drm_file.h drivers/gpu/drm/ati_pcigart.c | 10 ++++++---- drivers/gpu/drm/drm_gem.c | 1 + drivers/gpu/drm/drm_gem_shmem_helper.c | 1 + drivers/gpu/drm/drm_prime.c | 1 + drivers/gpu/drm/drm_syncobj.c | 1 + drivers/gpu/drm/drm_vblank.c | 29 ++++++++++++++++++++--------- drivers/gpu/drm/mediatek/mtk_drm_gem.c | 1 + include/drm/drm_file.h | 4 +--- include/drm/drm_panel.h | 1 + include/drm/drm_print.h | 4 +--- include/drm/drm_vblank.h | 1 - 11 files changed, 34 insertions(+), 20 deletions(-)

6 37

[GIT PULL] exynos-drm-fixes
by Inki Dae 02 Aug '19

02 Aug '19

Hi Dave, Just two fixups which fixes undefined reference error with NOMMU configuration and potential infinite issue of scaler module, and two trivial cleanups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit f8981e0309e9004c6e86d218049045700c79d740: Merge tag 'msm-fixes-2019_08_01' of https://gitlab.freedesktop.org/drm/msm into drm-fixes (2019-08-02 10:17:25 +1000) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos tags/exynos-drm-fixes-for-v5.3-rc3 for you to fetch changes up to 1bbbab097a05276e312dd2462791d32b21ceb1ee: drm/exynos: fix missing decrement of retry counter (2019-08-02 16:50:18 +0900) ---------------------------------------------------------------- - Two cleanup patches . use dev_get_drvdata for readability instead of platform_get_drvdata . remove redundant assignment to node. - Two fixup patches . fix undefined reference to 'vmf_insert_mixed' with NOMMU configuration. . fix potential infinite spin issue by decrementing 'retry' variable in scaler_reset function of exynos_drm_scaler.c ---------------------------------------------------------------- Arnd Bergmann (1): drm/exynos: add CONFIG_MMU dependency Colin Ian King (2): drm/exynos: remove redundant assignment to pointer 'node' drm/exynos: fix missing decrement of retry counter Fuqian Huang (1): drm/exynos: using dev_get_drvdata directly drivers/gpu/drm/exynos/Kconfig | 1 + drivers/gpu/drm/exynos/exynos_drm_fimc.c | 2 +- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 2 +- drivers/gpu/drm/exynos/exynos_drm_scaler.c | 4 ++-- 5 files changed, 6 insertions(+), 5 deletions(-)

2 1

[PULL] drm-misc-fixes
by Maarten Lankhorst 02 Aug '19

02 Aug '19

Hey, Bit late, but fixes for v5.3-rc3. :) drm-misc-fixes-2019-08-02: drm-misc-fixes for v5.3-rc3: - Fix some build errors in drm/bridge. - Do not build i810 on CONFIG_PREEMPTION. - Fix cache sync on arm in vgem. - Allow mapping fb in drm_client only when required, and use it to fix bochs fbdev. The following changes since commit 609488bc979f99f805f34e9a32c1e3b71179d10b: Linux 5.3-rc2 (2019-07-28 12:47:02 -0700) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-fixes-2019-08-02 for you to fetch changes up to 58540594570778fd149cd8c9b2bff61f2cefa8c9: drm/bochs: Use shadow buffer for bochs framebuffer console (2019-08-01 15:01:42 +0200) ---------------------------------------------------------------- drm-misc-fixes for v5.3-rc3: - Fix some build errors in drm/bridge. - Do not build i810 on CONFIG_PREEMPTION. - Fix cache sync on arm in vgem. - Allow mapping fb in drm_client only when required, and use it to fix bochs fbdev. ---------------------------------------------------------------- Maarten Lankhorst (1): Merge tag 'v5.3-rc2' into drm-misc-fixes Rob Clark (1): drm/vgem: fix cache synchronization on arm/arm64 Thomas Gleixner (1): drm/i810: Use CONFIG_PREEMPTION Thomas Zimmermann (4): drm/client: Support unmapping of DRM client buffers drm/fb-helper: Map DRM client buffer only when required drm/fb-helper: Instanciate shadow FB if configured in device's mode_config drm/bochs: Use shadow buffer for bochs framebuffer console YueHaibing (2): drm/bridge: lvds-encoder: Fix build error while CONFIG_DRM_KMS_HELPER=m drm/bridge: tc358764: Fix build error drivers/gpu/drm/Kconfig | 2 +- drivers/gpu/drm/bochs/bochs_kms.c | 1 + drivers/gpu/drm/bridge/Kconfig | 4 +- drivers/gpu/drm/drm_client.c | 60 ++++++++++++++---- drivers/gpu/drm/drm_fb_helper.c | 51 +++++++++++---- drivers/gpu/drm/vgem/vgem_drv.c | 130 ++++++++++++++++++++++++-------------- include/drm/drm_client.h | 2 + include/drm/drm_mode_config.h | 7 ++ 8 files changed, 186 insertions(+), 71 deletions(-)

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel August 2019