dri-devel August 2019

dri-devel@lists.freedesktop.org

318 participants
2338 discussions

[PATCH v5 00/25] drm: Kirin driver cleanups to prep for Kirin960 support
by John Stultz 07 Apr '20

07 Apr '20

Sending this out again (apologies!), to address a few issues Sam found. This patchset contains one fix (in the front, so its easier to eventually backport), and a series of changes from YiPing to refactor the kirin drm driver so that it can be used on both kirin620 based devices (like the original HiKey board) as well as kirin960 based devices (like the HiKey960 board). The full kirin960 drm support is still being refactored, but as this base kirin rework was getting to be substantial, I wanted to send out the first chunk, so that the review burden wasn't overwhelming. The full HiKey960 patch stack can be found here: https://git.linaro.org/people/john.stultz/android-dev.git/log/?h=dev/hikey9… thanks -john New in v5: * Whitespace changes and few logic simplifications to get checkpatch.pl --strict to pass, as noted by Sam * Fix for one of my patches which broke building the kirin driver as a module. Again noted by Sam. Cc: Rongrong Zou <zourongrong(a)gmail.com> Cc: Xinliang Liu <z.liuxinliang(a)hisilicon.com> Cc: David Airlie <airlied(a)linux.ie> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: dri-devel <dri-devel(a)lists.freedesktop.org> Cc: Sam Ravnborg <sam(a)ravnborg.org> Da Lv (1): drm: kirin: Fix for hikey620 display offset problem John Stultz (3): drm: kirin: Remove HISI_KIRIN_DW_DSI config option drm: kirin: Remove unreachable return drm: kirin: Move workqueue to ade_hw_ctx structure Xu YiPing (21): drm: kirin: Remove uncessary parameter indirection drm: kirin: Remove out_format from ade_crtc drm: kirin: Rename ade_plane to kirin_plane drm: kirin: Rename ade_crtc to kirin_crtc drm: kirin: Dynamically allocate the hw_ctx drm: kirin: Move request irq handle in ade hw ctx alloc drm: kirin: Move kirin_crtc, kirin_plane, kirin_format to kirin_drm_drv.h drm: kirin: Reanme dc_ops to kirin_drm_data drm: kirin: Move ade crtc/plane help functions to driver_data drm: kirin: Move channel formats to driver data drm: kirin: Move mode config function to driver_data drm: kirin: Move plane number and primay plane in driver data drm: kirin: Move config max_width and max_height to driver data drm: kirin: Move drm driver to driver data drm: kirin: Add register connect helper functions in drm init drm: kirin: Rename plane_init and crtc_init drm: kirin: Fix dev->driver_data setting drm: kirin: Make driver_data variable non-global drm: kirin: Add alloc_hw_ctx/clean_hw_ctx ops in driver data drm: kirin: Pass driver data to crtc init and plane init drm: kirin: Move ade drm init to kirin drm drv drivers/gpu/drm/hisilicon/kirin/Kconfig | 10 +- drivers/gpu/drm/hisilicon/kirin/Makefile | 3 +- .../gpu/drm/hisilicon/kirin/kirin_ade_reg.h | 1 + .../gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 351 +++++++----------- .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 250 +++++++++---- .../gpu/drm/hisilicon/kirin/kirin_drm_drv.h | 48 ++- 6 files changed, 367 insertions(+), 296 deletions(-) -- 2.17.1

3 28

[PATCH] RFC: drm/atomic-helpers: remove legacy_cursor_update hacks
by Daniel Vetter 06 Mar '20

06 Mar '20

The stuff never really worked, and leads to lots of fun because it out-of-order frees atomic states. Which upsets KASAN, among other things. For async updates we now have a more solid solution with the ->atomic_async_check and ->atomic_async_commit hooks. Support for that for msm and vc4 landed. nouveau and i915 have their own commit routines, doing something similar. For everyone else it's probably better to remove the use-after-free bug, and encourage folks to use the async support instead. The affected drivers which register a legacy cursor plane and don't either use the new async stuff or their own commit routine are: amdgpu, atmel, mediatek, qxl, rockchip, sti, sun4i, tegra, virtio, and vmwgfx. Inspired by an amdgpu bug report. References: https://bugzilla.kernel.org/show_bug.cgi?id=199425 Cc: mikita.lipski(a)amd.com Cc: Michel Dänzer <michel(a)daenzer.net> Cc: harry.wentland(a)amd.com Signed-off-by: Daniel Vetter <daniel.vetter(a)intel.com> --- drivers/gpu/drm/drm_atomic_helper.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 130da5195f3b..5a576cdf26dd 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -1330,13 +1330,6 @@ drm_atomic_helper_wait_for_vblanks(struct drm_device *dev, int i, ret; unsigned crtc_mask = 0; - /* - * Legacy cursor ioctls are completely unsynced, and userspace - * relies on that (by doing tons of cursor updates). - */ - if (old_state->legacy_cursor_update) - return; - for_each_oldnew_crtc_in_state(old_state, crtc, old_crtc_state, new_crtc_state, i) { if (!new_crtc_state->active) continue; @@ -1884,12 +1877,6 @@ int drm_atomic_helper_setup_commit(struct drm_atomic_state *state, continue; } - /* Legacy cursor updates are fully unsynced. */ - if (state->legacy_cursor_update) { - complete_all(&commit->flip_done); - continue; - } - if (!new_crtc_state->event) { commit->event = kzalloc(sizeof(*commit->event), GFP_KERNEL); -- 2.18.0.rc2

1 1

[Bug 196247] New: AMD FirePro W5130M (Dell 3510 notebook) - radeon driver - ring 0 stalled
by bugzilla-daemon＠bugzilla.kernel.org 28 Feb '20

28 Feb '20

https://bugzilla.kernel.org/show_bug.cgi?id=196247 Bug ID: 196247 Summary: AMD FirePro W5130M (Dell 3510 notebook) - radeon driver - ring 0 stalled Product: Drivers Version: 2.5 Kernel Version: 4.10. Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: high Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: mat42x(a)yahoo.de Regression: No Created attachment 257289 --> https://bugzilla.kernel.org/attachment.cgi?id=257289&action=edit dmesg output Hardware: Dell 3510 notebook (i5 CPU - HD 530) & Discrete AMD Radeon FirePro W5130M GPU. The discrete AMD GPU has no connections to any monitor. Steps to reproduce: $ DRI_PRIME=1 glmark2 ======================================================= glmark2 2014.03+git20150611.fa71af2d ======================================================= OpenGL Information GL_VENDOR: X.Org GL_RENDERER: Gallium 0.4 on AMD CAPE VERDE (DRM 2.49.0 / 4.10.0-26-generic, LLVM 4.0.0) GL_VERSION: 3.0 Mesa 17.1.2 ======================================================= [build] use-vbo=false:radeon: The kernel rejected CS, see dmesg for more information (-16). radeon: The kernel rejected CS, see dmesg for more information (-16). radeon: The kernel rejected CS, see dmesg for more information (-16). FPS: 10 FrameTime: 100.000 ms radeon: Failed to allocate virtual address for buffer: radeon: size : 65536 bytes radeon: alignment : 4096 bytes radeon: domains : 4 radeon: va : 0x0000000001070000 radeon: Failed to deallocate virtual address for buffer: radeon: size : 65536 bytes radeon: va : 0x1070000 radeon: Failed to allocate virtual address for buffer: radeon: size : 65536 bytes radeon: alignment : 4096 bytes radeon: domains : 4 radeon: va : 0x0000000001070000 radeon: Failed to deallocate virtual address for buffer: radeon: size : 65536 bytes radeon: va : 0x1070000 radeonsi: Failed to create a context. Segmentation fault (core dumped) -- You are receiving this mail because: You are watching the assignee of the bug.

1 10

[Bug 202799] New: amd/dc: right monitor sometimes never comes back up on dual-display setup after locking session
by bugzilla-daemon＠bugzilla.kernel.org 15 Feb '20

15 Feb '20

https://bugzilla.kernel.org/show_bug.cgi?id=202799 Bug ID: 202799 Summary: amd/dc: right monitor sometimes never comes back up on dual-display setup after locking session Product: Drivers Version: 2.5 Kernel Version: 5.0 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: libcg(a)protonmail.com Regression: No Created attachment 281547 --> https://bugzilla.kernel.org/attachment.cgi?id=281547&action=edit xrandr --props output - linux 5.0 (4.20 also had the same issue) - xf86-video-amdgpu 18.1.0 - GNOME 3.30 Left screen is a Dell U2412M (1920x1200), right screen is a Dell P2715Q (4K monitor set at 2560x1440, primary). GPU is RX 580. Steps to reproduce: - Lock session, screens turn off - After a while, press a key to turn the screens back on again - When the left screen lights up first, the system only displays an image on the left screen. The right screen lights up afterwards but goes back to sleep because it's getting no signal, although xrandr still recognizes it. I need to manually turn off the right screen and back on again to get it to reconfigure. When using `amdgpu.dc=0`, this issue disappears. -- You are receiving this mail because: You are watching the assignee of the bug.

1 11

[PATCH] drm/atmel-hlcdc: set layer REP bit to enable replication logic
by Joshua.Henderson＠microchip.com 13 Feb '20

13 Feb '20

This bit enables replication logic to expand an RGB color less than 24 bits, to 24 bits, which is used internally for all formats. Otherwise, the least significant bits are always set to zero and the color may not be what is expected. Signed-off-by: Joshua Henderson <joshua.henderson(a)microchip.com> --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c index eb7c4cf..6f6cf61 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c @@ -389,7 +389,7 @@ atmel_hlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane, atmel_hlcdc_layer_write_cfg(&plane->layer, ATMEL_HLCDC_LAYER_DMA_CFG, cfg); - cfg = ATMEL_HLCDC_LAYER_DMA; + cfg = ATMEL_HLCDC_LAYER_DMA | ATMEL_HLCDC_LAYER_REP; if (plane->base.type != DRM_PLANE_TYPE_PRIMARY) { cfg |= ATMEL_HLCDC_LAYER_OVR | ATMEL_HLCDC_LAYER_ITER2BL | -- 2.7.4

4 4

[PATCH 0/2] drm/omap: dmm_tiler: Small fixes for i878 workaround
by Peter Ujfalusi 11 Feb '20

11 Feb '20

Hi, two small correction on the use of DMAengine API, no functional changes - Use dmaengine_prep_dma_memcpy() to prepare the memcpy - do not call dma_async_issue_pending() as it is redundant Regards, Peter --- Peter Ujfalusi (2): drm/omap: dmm_tiler: Use dmaengine_prep_dma_memcpy() for i878 workaround drm/omap: dmm_tiler: Remove the dma_async_issue_pending() call drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

3 5

[Bug 203525] New: brightness with function buttons Acer Aspire A315-41 notebook with AMD Ryzen 5 2500U
by bugzilla-daemon＠bugzilla.kernel.org 01 Feb '20

01 Feb '20

https://bugzilla.kernel.org/show_bug.cgi?id=203525 Bug ID: 203525 Summary: brightness with function buttons Acer Aspire A315-41 notebook with AMD Ryzen 5 2500U Product: Drivers Version: 2.5 Kernel Version: 4.19.37 5.0.11 5.1 Hardware: x86-64 OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: erikjohansson(a)flashbox.5july.org Regression: No I got an Acer Aspire A315-41 notebook with AMD Ryzen 5 2500U and i have had problems with brightness not working out of the box (OTB) if i used function buttons. The thing is that i found that it started to work with linux-4.19.37 (fixed) but it didn't work with linux-4.19.35 (broken). It works from 4.19.37 but it doesn't work in later kernel series such as linux-5.0.11 or linux-5.1 and i think the fix should also be in newer kernels. I started to bisect but linux-4.19.36 doesn't boot with my hardware and after many bisect skip and compiling i gave up. Do anyone know what commit that could have fixed it? Or why 4.19.36 won't boot on my hardware (if there was some known regression) so i can perform an bisect. -- You are receiving this mail because: You are watching the assignee of the bug.

1 8

[Bug 58981] New: Bisected regression; boot failure with Radeon 9250 PCI 256MB + KMS
by bugzilla-daemon＠bugzilla.kernel.org 28 Jan '20

28 Jan '20

https://bugzilla.kernel.org/show_bug.cgi?id=58981 Summary: Bisected regression; boot failure with Radeon 9250 PCI 256MB + KMS Product: Drivers Version: 2.5 Kernel Version: 2.6.35,3.2.45,3.10-rc2 Platform: All OS/Version: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) AssignedTo: drivers_video-dri(a)kernel-bugs.osdl.org ReportedBy: jdietrch(a)fastmail.fm Regression: Yes I have a Radeon 9250 PCI 256MB video card in my machine. I discovered that this machine would not boot with 3.2.45 when KMS was enabled by default in the kernel config. Immediately after the grub menu, the screen would go black and nothing more would happen. Or sometimes columns of character-sized "marks" would appear on the screen. In either case, though, the machine would not boot. So I went back to 2.6.33 and found that booting with KMS did work just fine there. So I used git bisect to find where the problem arose, and that pointed to this commit which was merged for 2.6.35: commit 6b8b1786a8c29ce6e32298b93ac8d4a18a2b11c4 Author: Jerome Glisse <jglisse(a)redhat.com> Date: Wed Apr 7 10:21:31 2010 +0000 drm/radeon/kms: enable use of unmappable VRAM V2 I confirmed this result of git bisect by checking out 2.6.35 final and reverting that one commit, and the resulting kernel booted fine with KMS enabled by default. I also tried 3.10-rc2 and that booted fine when I added radeon.modeset=0 to the kernel commandline. I will attach files with dmesg output and lspci. Please let me know if there is anything else I can do. I'll be happy to test a proposed fix if that would be helpful. Thank you, James Dietrich -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.

1 6

[PATCH] drm/crc: Actually allow to change the crc source
by Daniel Vetter 28 Jan '20

28 Jan '20

Oops. Fixes: 9edbf1fa600a ("drm: Add API for capturing frame CRCs") Cc: Tomeu Vizoso <tomeu.vizoso(a)collabora.com> Cc: Emil Velikov <emil.velikov(a)collabora.com> Cc: Benjamin Gaignard <benjamin.gaignard(a)linaro.org> Signed-off-by: Daniel Vetter <daniel.vetter(a)intel.com> --- drivers/gpu/drm/drm_debugfs_crc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_debugfs_crc.c b/drivers/gpu/drm/drm_debugfs_crc.c index be1b7ba92ffe..6fe693ee15f9 100644 --- a/drivers/gpu/drm/drm_debugfs_crc.c +++ b/drivers/gpu/drm/drm_debugfs_crc.c @@ -369,7 +369,7 @@ void drm_debugfs_crtc_crc_add(struct drm_crtc *crtc) crc_ent = debugfs_create_dir("crc", crtc->debugfs_entry); - debugfs_create_file("control", S_IRUGO, crc_ent, crtc, + debugfs_create_file("control", S_IRUGO | S_IWUSR, crc_ent, crtc, &drm_crtc_crc_control_fops); debugfs_create_file("data", S_IRUGO, crc_ent, crtc, &drm_crtc_crc_data_fops); -- 2.23.0.rc1

2 2

[PATCH v3] libdrm: modetest: Allow selecting modes by index
by John Stultz 21 Jan '20

21 Jan '20

Often there are many similar modes, which cannot be selected via modetest due to its simple string matching. This change adds a mode index in the display output, which can then be used to specify a specific modeline to be set. Cc: Ilia Mirkin <imirkin(a)alum.mit.edu> Cc: Rob Clark <robdclark(a)chromium.org> Cc: Bjorn Andersson <bjorn.andersson(a)linaro.org> Cc: Sumit Semwal <sumit.semwal(a)linaro.org> Reviewed-by: Ilia Mirkin <imirkin(a)alum.mit.edu> Signed-off-by: John Stultz <john.stultz(a)linaro.org> --- v2: Reworked mode_str check per Ilia's suggestion v3: Added index < 0 check per Ilia's suggestion --- tests/modetest/modetest.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index 9c85c07b..5e1b623a 100644 --- a/tests/modetest/modetest.c +++ b/tests/modetest/modetest.c @@ -204,9 +204,10 @@ static void dump_encoders(struct device *dev) printf("\n"); } -static void dump_mode(drmModeModeInfo *mode) +static void dump_mode(drmModeModeInfo *mode, int index) { - printf(" %s %d %d %d %d %d %d %d %d %d %d", + printf(" #%i %s %d %d %d %d %d %d %d %d %d %d", + index, mode->name, mode->vrefresh, mode->hdisplay, @@ -443,10 +444,10 @@ static void dump_connectors(struct device *dev) if (connector->count_modes) { printf(" modes:\n"); - printf("\tname refresh (Hz) hdisp hss hse htot vdisp " + printf("\tindex name refresh (Hz) hdisp hss hse htot vdisp " "vss vse vtot)\n"); for (j = 0; j < connector->count_modes; j++) - dump_mode(&connector->modes[j]); + dump_mode(&connector->modes[j], j); } if (_connector->props) { @@ -478,7 +479,7 @@ static void dump_crtcs(struct device *dev) crtc->buffer_id, crtc->x, crtc->y, crtc->width, crtc->height); - dump_mode(&crtc->mode); + dump_mode(&crtc->mode, 0); if (_crtc->props) { printf(" props:\n"); @@ -829,6 +830,16 @@ connector_find_mode(struct device *dev, uint32_t con_id, const char *mode_str, if (!connector || !connector->count_modes) return NULL; + /* Pick by Index */ + if (mode_str[0] == '#') { + int index = atoi(mode_str + 1); + + if (index >= connector->count_modes || index < 0) + return NULL; + return &connector->modes[index]; + } + + /* Pick by Name */ for (i = 0; i < connector->count_modes; i++) { mode = &connector->modes[i]; if (!strcmp(mode->name, mode_str)) { @@ -1752,7 +1763,7 @@ static void usage(char *name) fprintf(stderr, "\n Test options:\n\n"); fprintf(stderr, "\t-P <plane_id>@<crtc_id>:<w>x<h>[+<x>+<y>][*<scale>][@<format>]\tset a plane\n"); - fprintf(stderr, "\t-s <connector_id>[,<connector_id>][@<crtc_id>]:<mode>[-<vrefresh>][@<format>]\tset a mode\n"); + fprintf(stderr, "\t-s <connector_id>[,<connector_id>][@<crtc_id>]:[#<mode index>]<mode>[-<vrefresh>][@<format>]\tset a mode\n"); fprintf(stderr, "\t-C\ttest hw cursor\n"); fprintf(stderr, "\t-v\ttest vsynced page flipping\n"); fprintf(stderr, "\t-w <obj_id>:<prop_name>:<value>\tset property\n"); -- 2.17.1

2 1

← Newer
1
2
3
4
5
6
7
8
9
...
234
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel August 2019