dri-devel September 2019

dri-devel@lists.freedesktop.org

315 participants
2278 discussions

[PATCH v8 0/4] Panel rotation patches
by Derek Basehore 08 Oct '19

08 Oct '19

This adds the plumbing for reading panel rotation from the devicetree and sets up adding a panel property for the panel orientation on Mediatek SoCs when a rotation is present. v8 changes: -added reviewed-by tags -fixed conflict with i915 patch that recently landed -Added additional documentation v7 changes: -forgot to add static inline v6 changes: -added enum declaration to drm_panel.h header v5 changes: -rebased v4 changes: -fixed some changes made to the i915 driver -clarified comments on of orientation helper v3 changes: -changed from attach/detach callbacks to directly setting fixed panel values in drm_panel_attach -removed update to Documentation -added separate function for quirked panel orientation property init v2 changes: fixed build errors in i915 Derek Basehore (4): drm/panel: Add helper for reading DT rotation drm/panel: set display info in panel attach drm/connector: Split out orientation quirk detection drm/mtk: add panel orientation property drivers/gpu/drm/drm_connector.c | 45 ++++++++++++++----- drivers/gpu/drm/drm_panel.c | 70 ++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_dp.c | 4 +- drivers/gpu/drm/i915/vlv_dsi.c | 5 +-- drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++ include/drm/drm_connector.h | 2 + include/drm/drm_panel.h | 21 +++++++++ 7 files changed, 138 insertions(+), 17 deletions(-) -- 2.22.0.410.gd8fdbe21b5-goog

4 14

[PATCH] drm: damage_helper: Fix race checking plane->state->fb
by Sean Paul 08 Oct '19

08 Oct '19

From: Sean Paul <seanpaul(a)chromium.org> Since the dirtyfb ioctl doesn't give us any hints as to which plane is scanning out the fb it's marking as damaged, we need to loop through planes to find it. Currently we just reach into plane state and check, but that can race with another commit changing the fb out from under us. This patch locks the plane before checking the fb and will release the lock if the plane is not displaying the dirty fb. Fixes: b9fc5e01d1ce ("drm: Add helper to implement legacy dirtyfb") Cc: Rob Clark <robdclark(a)gmail.com> Cc: Deepak Rawat <drawat(a)vmware.com> Cc: Daniel Vetter <daniel.vetter(a)ffwll.ch> Cc: Thomas Hellstrom <thellstrom(a)vmware.com> Cc: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> Cc: Maxime Ripard <maxime.ripard(a)bootlin.com> Cc: Sean Paul <sean(a)poorly.run> Cc: David Airlie <airlied(a)linux.ie> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: dri-devel(a)lists.freedesktop.org Cc: <stable(a)vger.kernel.org> # v5.0+ Reported-by: Daniel Vetter <daniel(a)ffwll.ch> Signed-off-by: Sean Paul <seanpaul(a)chromium.org> --- drivers/gpu/drm/drm_damage_helper.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_damage_helper.c b/drivers/gpu/drm/drm_damage_helper.c index 8230dac01a89..3a4126dc2520 100644 --- a/drivers/gpu/drm/drm_damage_helper.c +++ b/drivers/gpu/drm/drm_damage_helper.c @@ -212,8 +212,14 @@ int drm_atomic_helper_dirtyfb(struct drm_framebuffer *fb, drm_for_each_plane(plane, fb->dev) { struct drm_plane_state *plane_state; - if (plane->state->fb != fb) + ret = drm_modeset_lock(&plane->mutex, state->acquire_ctx); + if (ret) + goto out; + + if (plane->state->fb != fb) { + drm_modeset_unlock(&plane->mutex); continue; + } plane_state = drm_atomic_get_plane_state(state, plane); if (IS_ERR(plane_state)) { -- Sean Paul, Software Engineer, Google / Chromium OS

3 4

[PATCH 1/5] backlight: pwm_bl: fix cie1913 comments and constant
by Rasmus Villemoes 08 Oct '19

08 Oct '19

The "break-even" point for the two formulas is L==8, which is also what the code actually implements. [Incidentally, at that point one has Y=0.008856, not 0.08856]. Moreover, all the sources I can find say the linear factor is 903.3 rather than 902.3, which makes sense since then the formulas agree at L==8, both yielding the 0.008856 figure to four significant digits. Signed-off-by: Rasmus Villemoes <linux(a)rasmusvillemoes.dk> --- drivers/video/backlight/pwm_bl.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c index 2201b8c78641..be36be1cacb7 100644 --- a/drivers/video/backlight/pwm_bl.c +++ b/drivers/video/backlight/pwm_bl.c @@ -155,8 +155,8 @@ static const struct backlight_ops pwm_backlight_ops = { * * The CIE 1931 lightness formula is what actually describes how we perceive * light: - * Y = (L* / 902.3) if L* ≤ 0.08856 - * Y = ((L* + 16) / 116)^3 if L* > 0.08856 + * Y = (L* / 903.3) if L* ≤ 8 + * Y = ((L* + 16) / 116)^3 if L* > 8 * * Where Y is the luminance, the amount of light coming out of the screen, and * is a number between 0.0 and 1.0; and L* is the lightness, how bright a human @@ -169,9 +169,15 @@ static u64 cie1931(unsigned int lightness, unsigned int scale) { u64 retval; + /* + * @lightness is given as a number between 0 and 1, expressed + * as a fixed-point number in scale @scale. Convert to a + * percentage, still expressed as a fixed-point number, so the + * above formulas can be applied. + */ lightness *= 100; if (lightness <= (8 * scale)) { - retval = DIV_ROUND_CLOSEST_ULL(lightness * 10, 9023); + retval = DIV_ROUND_CLOSEST_ULL(lightness * 10, 9033); } else { retval = int_pow((lightness + (16 * scale)) / 116, 3); retval = DIV_ROUND_CLOSEST_ULL(retval, (scale * scale)); -- 2.20.1

2 13

[PATCH v2 0/3] Rate-limit shadow-FB-to-console-update to screen refresh
by Thomas Zimmermann 08 Oct '19

08 Oct '19

A full-screen memcpy() moves the console's shadow buffer to hardware; with possibly significant runtime overhead. [1] The console's dirty worker now waits for the vblank to rate limit the output frequency. Screen output can pile up while waiting and there's a chance that multiple screen updates can be handled with a single memcpy(). Note that this has no effect on tearing: while the dirty worker updates the hardware buffer, new data can still arrive in the shadow buffer. This can create a tearing effcet, even though console output is synchronized to vblank. The patchset adds vblank support to mgag200, because the problem was first reported with Matrox hardware. v2: * remove locking from fbdev patch * use constants fro mgag200 register names and fields * double-check that VLINE irq is active on mgag200 * only signal vblank on CRTC 0 of mgag200 * coding-style fixes [1] https://lists.freedesktop.org/archives/dri-devel/2019-July/228663.html Thomas Zimmermann (3): drm/fb-helper: Synchronize dirty worker with vblank drm/mgag200: Rename constant MGAREG_Status to MGAREG_STATUS drm/mgag200: Add vblank support drivers/gpu/drm/drm_fb_helper.c | 10 +++++ drivers/gpu/drm/mgag200/mgag200_drv.c | 1 + drivers/gpu/drm/mgag200/mgag200_drv.h | 1 + drivers/gpu/drm/mgag200/mgag200_main.c | 40 +++++++++++++++++++ drivers/gpu/drm/mgag200/mgag200_mode.c | 53 ++++++++++++++++++++++---- drivers/gpu/drm/mgag200/mgag200_reg.h | 7 +++- 6 files changed, 104 insertions(+), 8 deletions(-) -- 2.23.0

3 9

[PATCH] drm: include: fix W=1 warnings in struct drm_dsc_config
by Benjamin Gaignard 08 Oct '19

08 Oct '19

Change scale_increment_interval and nfl_bpg_offset fields to u32 to avoid W=1 warnings because we are testing them against 65535. Signed-off-by: Benjamin Gaignard <benjamin.gaignard(a)st.com> --- include/drm/drm_dsc.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/drm/drm_dsc.h b/include/drm/drm_dsc.h index 887954cbfc60..e495024e901c 100644 --- a/include/drm/drm_dsc.h +++ b/include/drm/drm_dsc.h @@ -207,11 +207,13 @@ struct drm_dsc_config { * Number of group times between incrementing the scale factor value * used at the beginning of a slice. */ - u16 scale_increment_interval; + u32 scale_increment_interval; + /** * @nfl_bpg_offset: Non first line BPG offset to be used */ - u16 nfl_bpg_offset; + + u32 nfl_bpg_offset; /** * @slice_bpg_offset: BPG offset used to enforce slice bit */ -- 2.15.0

7 15

[PATCH v2 0/4] drm/panel: Extend panels to report their types
by Laurent Pinchart 08 Oct '19

08 Oct '19

Hello, This series is the second version of a previously unnamed series that contained [PATCH 1/2] drm/panel: Add and fill drm_panel type field [PATCH 2/2] drm/bridge: panel: Use drm_panel.type instead of explicit connector_type The purpose of the change is to allow panels to report their type, in order to create drm_connector instances with appropriate types in the upper layers. Patch 1/4 fixes two panel drivers to add missing drm_panel_init() calls. Patch 2/4 then refactors the panel drivers to initialise the dev and funcs field through the drm_panel_init() function instead of doing so manually. In patch 3/4 the drm_panel structure receives a new connector_type field to report its type, set through drm_panel_init(), and all connector drivers are updated accordingly. The panel-simple driver however only reports the LVDS connector type for known-to-be-LVDS panels, while all other leave the field initialised to 0, corresponding to DRM_MODE_CONNECTOR_Unknown. Panels supported by that driver will need to be reviewed one by one and their type updated. This was done to avoid reporting an incorrect type, allowing upper layers to catch DRM_MODE_CONNECTOR_Unknown and WARN() to trigger an update of the corresponding panel. Patch 4/4 finally modifies drm_panel_bridge_add() and its devm_ counterpart to replace the connector type argument with the type reported by the panel. This can't unfortunately be forced upon all drivers as several of them hardcode a DRM_MODE_CONNECTOR_Unknown type, and would then change the connector type reported to userspace, leading to possible breakages. A new function, drm_panel_bridge_add_typed(), is added with the existing behaviour of drm_panel_bridge_add() to create a panel bridge with a forced connector type, and drivers are switched to using that function. They should then be switched back one by one to drm_panel_bridge_add() after careful review (and clever handling of the connector type change issue). The drm_panel_bridge_add_typed() function is marked as deprecated and should not be used in new code. The patches are available at git://linuxtv.org/pinchartl/media.git omapdrm/panels Laurent Pinchart (4): drm/panel: Add missing drm_panel_init() in panel drivers drm/panel: Initialise panel dev and funcs through drm_panel_init() drm/panel: Add and fill drm_panel type field drm/bridge: panel: Infer connector type from panel by default .../gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 3 +- drivers/gpu/drm/bridge/cdns-dsi.c | 3 +- drivers/gpu/drm/bridge/lvds-encoder.c | 3 +- drivers/gpu/drm/bridge/panel.c | 69 ++++++++++++++++--- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 3 +- drivers/gpu/drm/drm_panel.c | 14 +++- drivers/gpu/drm/ingenic/ingenic-drm.c | 4 +- drivers/gpu/drm/mcde/mcde_dsi.c | 4 +- drivers/gpu/drm/panel/panel-arm-versatile.c | 5 +- .../drm/panel/panel-feiyang-fy07024di26a30d.c | 5 +- drivers/gpu/drm/panel/panel-ilitek-ili9322.c | 5 +- drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 5 +- drivers/gpu/drm/panel/panel-innolux-p079zca.c | 5 +- .../gpu/drm/panel/panel-jdi-lt070me05000.c | 5 +- .../drm/panel/panel-kingdisplay-kd097d04.c | 5 +- drivers/gpu/drm/panel/panel-lg-lb035q02.c | 5 +- drivers/gpu/drm/panel/panel-lg-lg4573.c | 5 +- drivers/gpu/drm/panel/panel-lvds.c | 5 +- drivers/gpu/drm/panel/panel-nec-nl8048hl11.c | 5 +- drivers/gpu/drm/panel/panel-novatek-nt39016.c | 5 +- .../drm/panel/panel-olimex-lcd-olinuxino.c | 5 +- .../gpu/drm/panel/panel-orisetech-otm8009a.c | 5 +- .../drm/panel/panel-osd-osd101t2587-53ts.c | 5 +- .../drm/panel/panel-panasonic-vvx10f034n00.c | 5 +- .../drm/panel/panel-raspberrypi-touchscreen.c | 4 +- drivers/gpu/drm/panel/panel-raydium-rm67191.c | 5 +- drivers/gpu/drm/panel/panel-raydium-rm68200.c | 5 +- .../drm/panel/panel-rocktech-jh057n00900.c | 5 +- drivers/gpu/drm/panel/panel-ronbo-rb070d30.c | 5 +- drivers/gpu/drm/panel/panel-samsung-ld9040.c | 5 +- drivers/gpu/drm/panel/panel-samsung-s6d16d0.c | 5 +- drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c | 5 +- .../gpu/drm/panel/panel-samsung-s6e63j0x03.c | 5 +- drivers/gpu/drm/panel/panel-samsung-s6e63m0.c | 5 +- drivers/gpu/drm/panel/panel-samsung-s6e8aa0.c | 5 +- drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 5 +- .../gpu/drm/panel/panel-sharp-lq101r1sx01.c | 5 +- .../gpu/drm/panel/panel-sharp-ls037v7dw01.c | 5 +- .../gpu/drm/panel/panel-sharp-ls043t1le01.c | 5 +- drivers/gpu/drm/panel/panel-simple.c | 28 +++++++- drivers/gpu/drm/panel/panel-sitronix-st7701.c | 5 +- .../gpu/drm/panel/panel-sitronix-st7789v.c | 4 +- drivers/gpu/drm/panel/panel-sony-acx565akm.c | 5 +- drivers/gpu/drm/panel/panel-tpo-td028ttec1.c | 5 +- drivers/gpu/drm/panel/panel-tpo-td043mtea1.c | 5 +- drivers/gpu/drm/panel/panel-tpo-tpg110.c | 5 +- drivers/gpu/drm/panel/panel-truly-nt35597.c | 5 +- drivers/gpu/drm/pl111/pl111_drv.c | 4 +- drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 4 +- drivers/gpu/drm/rockchip/rockchip_rgb.c | 3 +- drivers/gpu/drm/stm/ltdc.c | 4 +- drivers/gpu/drm/tilcdc/tilcdc_external.c | 4 +- drivers/gpu/drm/tve200/tve200_drv.c | 4 +- drivers/gpu/drm/vc4/vc4_dpi.c | 3 +- drivers/gpu/drm/vc4/vc4_dsi.c | 4 +- include/drm/drm_bridge.h | 11 +-- include/drm/drm_panel.h | 13 +++- 57 files changed, 217 insertions(+), 156 deletions(-) -- Regards, Laurent Pinchart

7 15

[PATCH v18 00/19] kunit: introduce KUnit, the Linux kernel unit testing framework
by Brendan Higgins 07 Oct '19

07 Oct '19

## TL;DR This revision addresses comments from Linus[1] and Randy[2], by moving top level `kunit/` directory to `lib/kunit/` and likewise moves top level Kconfig entry under lib/Kconfig.debug, so the KUnit submenu now shows up under the "Kernel Hacking" menu. As a consequence of this, I rewrote patch 06/18 (kbuild: enable building KUnit) - now 06/19 (lib: enable building KUnit in lib/), and now needs to be re-acked/reviewed. ## Background This patch set proposes KUnit, a lightweight unit testing and mocking framework for the Linux kernel. Unlike Autotest and kselftest, KUnit is a true unit testing framework; it does not require installing the kernel on a test machine or in a VM (however, KUnit still allows you to run tests on test machines or in VMs if you want[3]) and does not require tests to be written in userspace running on a host kernel. Additionally, KUnit is fast: From invocation to completion KUnit can run several dozen tests in about a second. Currently, the entire KUnit test suite for KUnit runs in under a second from the initial invocation (build time excluded). KUnit is heavily inspired by JUnit, Python's unittest.mock, and Googletest/Googlemock for C++. KUnit provides facilities for defining unit test cases, grouping related test cases into test suites, providing common infrastructure for running tests, mocking, spying, and much more. ### What's so special about unit testing? A unit test is supposed to test a single unit of code in isolation, hence the name. There should be no dependencies outside the control of the test; this means no external dependencies, which makes tests orders of magnitudes faster. Likewise, since there are no external dependencies, there are no hoops to jump through to run the tests. Additionally, this makes unit tests deterministic: a failing unit test always indicates a problem. Finally, because unit tests necessarily have finer granularity, they are able to test all code paths easily solving the classic problem of difficulty in exercising error handling code. ### Is KUnit trying to replace other testing frameworks for the kernel? No. Most existing tests for the Linux kernel are end-to-end tests, which have their place. A well tested system has lots of unit tests, a reasonable number of integration tests, and some end-to-end tests. KUnit is just trying to address the unit test space which is currently not being addressed. ### More information on KUnit There is a bunch of documentation near the end of this patch set that describes how to use KUnit and best practices for writing unit tests. For convenience I am hosting the compiled docs here[4]. Additionally for convenience, I have applied these patches to a branch[5]. The repo may be cloned with: git clone https://kunit.googlesource.com/linux This patchset is on the kunit/initial/v5.3/v18 branch. ## History since v15 ### v18 - Addrssed comments on 07/19 (kunit: test: add initial tests) from Randy Dunlap by removing redundant dependencies from Kconfig entries. ### v17 - Addressed comments on 06/19 (lib: enable building KUnit in lib/) from Stephen Boyd by moving KUnit submenu ahead of Runtime Testing submenu. ### v16 - Addressed comments from Linus Torvalds by moving all kunit/ paths to lib/kunit/. - Addressed comments by Randy Dunlap by moving KUnit Kconfig under lib/Kconfig.debug so the KUnit submenu shows up under the "Kernel Hacking" menu. [1] https://www.lkml.org/lkml/2019/9/20/696 [2] https://www.lkml.org/lkml/2019/9/20/738 [3] https://google.github.io/kunit-docs/third_party/kernel/docs/usage.html#kuni… [4] https://google.github.io/kunit-docs/third_party/kernel/docs/ [5] https://kunit.googlesource.com/linux/+/kunit/initial/v5.3/v18 --- Avinash Kondareddy (1): kunit: test: add tests for KUnit managed resources Brendan Higgins (16): kunit: test: add KUnit test runner core kunit: test: add test resource management API kunit: test: add string_stream a std::stream like string builder kunit: test: add assertion printing library kunit: test: add the concept of expectations lib: enable building KUnit in lib/ kunit: test: add initial tests objtool: add kunit_try_catch_throw to the noreturn list kunit: test: add support for test abort kunit: test: add tests for kunit test abort kunit: test: add the concept of assertions kunit: defconfig: add defconfigs for building KUnit tests Documentation: kunit: add documentation for KUnit MAINTAINERS: add entry for KUnit the unit testing framework MAINTAINERS: add proc sysctl KUnit test to PROC SYSCTL section kunit: fix failure to build without printk Felix Guo (1): kunit: tool: add Python wrappers for running KUnit tests Iurii Zaikin (1): kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec() Documentation/dev-tools/index.rst | 1 + Documentation/dev-tools/kunit/api/index.rst | 16 + Documentation/dev-tools/kunit/api/test.rst | 11 + Documentation/dev-tools/kunit/faq.rst | 62 + Documentation/dev-tools/kunit/index.rst | 79 + Documentation/dev-tools/kunit/start.rst | 180 ++ Documentation/dev-tools/kunit/usage.rst | 576 +++++++ MAINTAINERS | 13 + arch/um/configs/kunit_defconfig | 3 + include/kunit/assert.h | 356 ++++ include/kunit/string-stream.h | 51 + include/kunit/test.h | 1490 +++++++++++++++++ include/kunit/try-catch.h | 75 + kernel/Makefile | 2 + kernel/sysctl-test.c | 392 +++++ lib/Kconfig.debug | 13 + lib/Makefile | 2 + lib/kunit/Kconfig | 36 + lib/kunit/Makefile | 9 + lib/kunit/assert.c | 141 ++ lib/kunit/example-test.c | 88 + lib/kunit/string-stream-test.c | 52 + lib/kunit/string-stream.c | 217 +++ lib/kunit/test-test.c | 331 ++++ lib/kunit/test.c | 478 ++++++ lib/kunit/try-catch.c | 118 ++ tools/objtool/check.c | 1 + tools/testing/kunit/.gitignore | 3 + tools/testing/kunit/configs/all_tests.config | 3 + tools/testing/kunit/kunit.py | 136 ++ tools/testing/kunit/kunit_config.py | 66 + tools/testing/kunit/kunit_kernel.py | 149 ++ tools/testing/kunit/kunit_parser.py | 310 ++++ tools/testing/kunit/kunit_tool_test.py | 206 +++ .../test_is_test_passed-all_passed.log | 32 + .../test_data/test_is_test_passed-crash.log | 69 + .../test_data/test_is_test_passed-failure.log | 36 + .../test_is_test_passed-no_tests_run.log | 75 + .../test_output_isolated_correctly.log | 106 ++ .../test_data/test_read_from_file.kconfig | 17 + 40 files changed, 6001 insertions(+) create mode 100644 Documentation/dev-tools/kunit/api/index.rst create mode 100644 Documentation/dev-tools/kunit/api/test.rst create mode 100644 Documentation/dev-tools/kunit/faq.rst create mode 100644 Documentation/dev-tools/kunit/index.rst create mode 100644 Documentation/dev-tools/kunit/start.rst create mode 100644 Documentation/dev-tools/kunit/usage.rst create mode 100644 arch/um/configs/kunit_defconfig create mode 100644 include/kunit/assert.h create mode 100644 include/kunit/string-stream.h create mode 100644 include/kunit/test.h create mode 100644 include/kunit/try-catch.h create mode 100644 kernel/sysctl-test.c create mode 100644 lib/kunit/Kconfig create mode 100644 lib/kunit/Makefile create mode 100644 lib/kunit/assert.c create mode 100644 lib/kunit/example-test.c create mode 100644 lib/kunit/string-stream-test.c create mode 100644 lib/kunit/string-stream.c create mode 100644 lib/kunit/test-test.c create mode 100644 lib/kunit/test.c create mode 100644 lib/kunit/try-catch.c create mode 100644 tools/testing/kunit/.gitignore create mode 100644 tools/testing/kunit/configs/all_tests.config create mode 100755 tools/testing/kunit/kunit.py create mode 100644 tools/testing/kunit/kunit_config.py create mode 100644 tools/testing/kunit/kunit_kernel.py create mode 100644 tools/testing/kunit/kunit_parser.py create mode 100755 tools/testing/kunit/kunit_tool_test.py create mode 100644 tools/testing/kunit/test_data/test_is_test_passed-all_passed.log create mode 100644 tools/testing/kunit/test_data/test_is_test_passed-crash.log create mode 100644 tools/testing/kunit/test_data/test_is_test_passed-failure.log create mode 100644 tools/testing/kunit/test_data/test_is_test_passed-no_tests_run.log create mode 100644 tools/testing/kunit/test_data/test_output_isolated_correctly.log create mode 100644 tools/testing/kunit/test_data/test_read_from_file.kconfig -- 2.23.0.351.gc4317032e6-goog

7 46

[PATCH] backlight: lm3630a: fix module aliases
by Andreas Kemnade 05 Oct '19

05 Oct '19

Devicetree aliases are missing, so that module autoloading does not work properly. Signed-off-by: Andreas Kemnade <andreas(a)kemnade.info> --- drivers/video/backlight/lm3630a_bl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c index 3b45a1733198..9d67c07db2f2 100644 --- a/drivers/video/backlight/lm3630a_bl.c +++ b/drivers/video/backlight/lm3630a_bl.c @@ -617,12 +617,14 @@ static const struct i2c_device_id lm3630a_id[] = { {} }; +MODULE_DEVICE_TABLE(i2c, lm3630a_id); + static const struct of_device_id lm3630a_match_table[] = { { .compatible = "ti,lm3630a", }, { }, }; -MODULE_DEVICE_TABLE(i2c, lm3630a_id); +MODULE_DEVICE_TABLE(of, lm3630a_match_table); static struct i2c_driver lm3630a_i2c_driver = { .driver = { -- 2.11.0

2 2

[PATCH 00/11] Add support for software nodes to gpiolib
by Dmitry Torokhov 04 Oct '19

04 Oct '19

This series attempts to add support for software nodes to gpiolib, using software node references that were introduced recently. This allows us to convert more drivers to the generic device properties and drop support for custom platform data: static const struct software_node gpio_bank_b_node = { |-------.name = "B", }; static const struct property_entry simone_key_enter_props[] = { |-------PROPERTY_ENTRY_U32("linux,code", KEY_ENTER), |-------PROPERTY_ENTRY_STRING("label", "enter"), |-------PROPERTY_ENTRY_REF("gpios", &gpio_bank_b_node, 123, GPIO_ACTIVE_LOW), |-------{ } }; If we agree in principle, I would like to have the very first 3 patches in an immutable branch off maybe -rc8 so that it can be pulled into individual subsystems so that patches switching various drivers to fwnode_gpiod_get_index() could be applied. Thanks, Dmitry Dmitry Torokhov (11): gpiolib: of: add a fallback for wlf,reset GPIO name gpiolib: introduce devm_fwnode_gpiod_get_index() gpiolib: introduce fwnode_gpiod_get_index() net: phylink: switch to using fwnode_gpiod_get_index() net: mdio: switch to using fwnode_gpiod_get_index() drm/bridge: ti-tfp410: switch to using fwnode_gpiod_get_index() gpliolib: make fwnode_get_named_gpiod() static gpiolib: of: tease apart of_find_gpio() gpiolib: of: tease apart acpi_find_gpio() gpiolib: consolidate fwnode GPIO lookups gpiolib: add support for software nodes drivers/gpio/Makefile | 1 + drivers/gpio/gpiolib-acpi.c | 153 ++++++++++++++---------- drivers/gpio/gpiolib-acpi.h | 21 ++-- drivers/gpio/gpiolib-devres.c | 33 ++---- drivers/gpio/gpiolib-of.c | 159 ++++++++++++++----------- drivers/gpio/gpiolib-of.h | 26 ++-- drivers/gpio/gpiolib-swnode.c | 92 +++++++++++++++ drivers/gpio/gpiolib-swnode.h | 13 ++ drivers/gpio/gpiolib.c | 184 ++++++++++++++++------------- drivers/gpu/drm/bridge/ti-tfp410.c | 4 +- drivers/net/phy/mdio_bus.c | 4 +- drivers/net/phy/phylink.c | 4 +- include/linux/gpio/consumer.h | 53 ++++++--- 13 files changed, 471 insertions(+), 276 deletions(-) create mode 100644 drivers/gpio/gpiolib-swnode.c create mode 100644 drivers/gpio/gpiolib-swnode.h -- 2.23.0.162.g0b9fbb3734-goog

5 9

drm_sched with panfrost crash on T820
by Neil Armstrong 04 Oct '19

04 Oct '19

Hi Christian, In v5.3, running dEQP triggers the following kernel crash : [ 20.224982] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000038 [...] [ 20.291064] Hardware name: Khadas VIM2 (DT) [ 20.295217] Workqueue: events drm_sched_job_timedout [...] [ 20.304867] pc : drm_sched_increase_karma+0x5c/0xf0 [ 20.309696] lr : drm_sched_increase_karma+0x44/0xf0 [...] [ 20.396720] Call trace: [ 20.399138] drm_sched_increase_karma+0x5c/0xf0 [ 20.403623] panfrost_job_timedout+0x12c/0x1e0 [ 20.408021] drm_sched_job_timedout+0x48/0xa0 [ 20.412336] process_one_work+0x1e0/0x320 [ 20.416300] worker_thread+0x40/0x450 [ 20.419924] kthread+0x124/0x128 [ 20.423116] ret_from_fork+0x10/0x18 [ 20.426653] Code: f9400001 540001c0 f9400a83 f9402402 (f9401c64) [ 20.432690] ---[ end trace bd02f890139096a7 ]--- Which never happens, at all, on v5.2. I did a (very) long (7 days, ~100runs) bisect run using our LAVA lab (thanks tomeu !), but bisecting was not easy since the bad commit landed on drm-misc-next after v5.1-rc6, and then v5.2-rc1 was backmerged into drm-misc-next at: [1] 374ed5429346 Merge drm/drm-next into drm-misc-next Thus bisecting between [1] ang v5.2-rc1 leads to commit based on v5.2-rc1... where panfrost was not enabled in the Khadas VIM2 DT. Anyway, I managed to identify 3 possibly breaking commits : [2] 290764af7e36 drm/sched: Keep s_fence->parent pointer [3] 5918045c4ed4 drm/scheduler: rework job destruction [4] a5343b8a2ca5 drm/scheduler: Add flag to hint the release of guilty job. But [1] and [2] doesn't crash the same way : [ 16.257912] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000060 [...] [ 16.308307] CPU: 4 PID: 80 Comm: kworker/4:1 Not tainted 5.1.0-rc2-01185-g290764af7e36-dirty #378 [ 16.317099] Hardware name: Khadas VIM2 (DT) [...]) [ 16.330907] pc : refcount_sub_and_test_checked+0x4/0xb0 [ 16.336078] lr : refcount_dec_and_test_checked+0x14/0x20 [...] [ 16.423533] Process kworker/4:1 (pid: 80, stack limit = 0x(____ptrval____)) [ 16.430431] Call trace: [ 16.432851] refcount_sub_and_test_checked+0x4/0xb0 [ 16.437681] drm_sched_job_cleanup+0x24/0x58 [ 16.441908] panfrost_job_free+0x14/0x28 [ 16.445787] drm_sched_job_timedout+0x6c/0xa0 [ 16.450102] process_one_work+0x1e0/0x320 [ 16.454067] worker_thread+0x40/0x450 [ 16.457690] kthread+0x124/0x128 [ 16.460882] ret_from_fork+0x10/0x18 [ 16.464421] Code: 52800000 d65f03c0 d503201f aa0103e3 (b9400021) [ 16.470456] ---[ end trace 39a67412ee1b64b5 ]--- and [3] fails like on v5.3 (in drm_sched_increase_karma): [ 33.830080] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000038 [...] [ 33.871946] Internal error: Oops: 96000004 [#1] PREEMPT SMP [ 33.877450] Modules linked in: [ 33.880474] CPU: 6 PID: 81 Comm: kworker/6:1 Not tainted 5.1.0-rc2-01186-ga5343b8a2ca5-dirty #380 [ 33.889265] Hardware name: Khadas VIM2 (DT) [ 33.893419] Workqueue: events drm_sched_job_timedout [...] [ 33.903069] pc : drm_sched_increase_karma+0x5c/0xf0 [ 33.907898] lr : drm_sched_increase_karma+0x44/0xf0 [...] [ 33.994924] Process kworker/6:1 (pid: 81, stack limit = 0x(____ptrval____)) [ 34.001822] Call trace: [ 34.004242] drm_sched_increase_karma+0x5c/0xf0 [ 34.008726] panfrost_job_timedout+0x12c/0x1e0 [ 34.013122] drm_sched_job_timedout+0x48/0xa0 [ 34.017438] process_one_work+0x1e0/0x320 [ 34.021402] worker_thread+0x40/0x450 [ 34.025026] kthread+0x124/0x128 [ 34.028218] ret_from_fork+0x10/0x18 [ 34.031755] Code: f9400001 540001c0 f9400a83 f9402402 (f9401c64) [ 34.037792] ---[ end trace be3fd6f77f4df267 ]--- When I revert [3] on [1], i get the same crash as [2], meaning the commit [3] masks the failure [2] introduced. Do you know how to solve this ? Thanks, Neil

5 20

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2019