dri-devel September 2019

dri-devel@lists.freedesktop.org

315 participants
2278 discussions

[PATCH 1/2] drm/ttm: also export ttm_bo_vm_fault
by Christian König 02 Oct '19

02 Oct '19

That is needed by at least a cleanup in radeon. Signed-off-by: Christian König <christian.koenig(a)amd.com> --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 3 ++- include/drm/ttm/ttm_bo_api.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/ttm/ttm_bo_vm.c index cb3120cd5aa1..525046bbcb6b 100644 --- a/drivers/gpu/drm/ttm/ttm_bo_vm.c +++ b/drivers/gpu/drm/ttm/ttm_bo_vm.c @@ -316,7 +316,7 @@ vm_fault_t ttm_bo_vm_fault_reserved(struct vm_fault *vmf, } EXPORT_SYMBOL(ttm_bo_vm_fault_reserved); -static vm_fault_t ttm_bo_vm_fault(struct vm_fault *vmf) +vm_fault_t ttm_bo_vm_fault(struct vm_fault *vmf) { struct vm_area_struct *vma = vmf->vma; pgprot_t prot; @@ -336,6 +336,7 @@ static vm_fault_t ttm_bo_vm_fault(struct vm_fault *vmf) return ret; } +EXPORT_SYMBOL(ttm_bo_vm_fault); void ttm_bo_vm_open(struct vm_area_struct *vma) { diff --git a/include/drm/ttm/ttm_bo_api.h b/include/drm/ttm/ttm_bo_api.h index 851260cbbb2f..dad41cf5cd64 100644 --- a/include/drm/ttm/ttm_bo_api.h +++ b/include/drm/ttm/ttm_bo_api.h @@ -796,6 +796,8 @@ vm_fault_t ttm_bo_vm_fault_reserved(struct vm_fault *vmf, pgprot_t prot, pgoff_t num_prefault); +vm_fault_t ttm_bo_vm_fault(struct vm_fault *vmf); + void ttm_bo_vm_open(struct vm_area_struct *vma); void ttm_bo_vm_close(struct vm_area_struct *vma); -- 2.14.1

2 4

[Bug 110968] Allow ubuntu users to install on other ubuntu versions
by bugzilla-daemon＠freedesktop.org 02 Oct '19

02 Oct '19

https://bugs.freedesktop.org/show_bug.cgi?id=110968 Bug ID: 110968 Summary: Allow ubuntu users to install on other ubuntu versions Product: DRI Version: unspecified Hardware: Other OS: All Status: NEW Severity: blocker Priority: medium Component: DRM/AMDgpu-pro Assignee: dri-devel(a)lists.freedesktop.org Reporter: ashark(a)linuxcomp.ru 19.20-812932 release for Ubuntu In amdgpu-core package there is a preinst script which checks a distribution version. If it is not Ubuntu, it allows installation with warning. But if it detects it is another version of Ubuntu, it declines installation. Why not just let users to install and just warn them that they are using unsupported version? Anyway, users may modify a package with my script, that I attached to this bug report: https://bugs.freedesktop.org/show_bug.cgi?id=110795 Also installation denial of this single package causes a big trouble for those who tried to use installer script. You can see in that bug report that another user was in situation with a lot of broken packages. I also was in such situation and did not know how to recover from that state. Later I have prepared a script to remove everything from amdgpu-pro (also attached there). But really, if you still want to stop ubuntu users, then why do not edit installer, so it goes to install only amdgpu-core first (without its dependencies), and only after that it goes to install all other packages that are returned by build_package_list? Or just make distribution check in installer script rather than in package scriptlet. -- You are receiving this mail because: You are the assignee for the bug.

1 7

[Bug 109440] Radeon RX 580 fails to initialize
by bugzilla-daemon＠freedesktop.org 02 Oct '19

02 Oct '19

https://bugs.freedesktop.org/show_bug.cgi?id=109440 Bug ID: 109440 Summary: Radeon RX 580 fails to initialize Product: DRI Version: XOrg git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: blocker Priority: medium Component: DRM/AMDgpu-pro Assignee: dri-devel(a)lists.freedesktop.org Reporter: bogdan.mustiata(a)gmail.com Created attachment 143204 --> https://bugs.freedesktop.org/attachment.cgi?id=143204&action=edit all logs Setup: Lenovo X230 laptop with an integrated graphic card, the RX 580 is connected via a gdc beast using an express card connector. Drivers: latest at current date: amdgpu-pro-18.50-708488-ubuntu-18.04 Kernel: Linux germanium 4.18.0-13-generic #14~18.04.1-Ubuntu SMP Thu Dec 6 14:09:52 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux It seems the dkms fails to build on ubuntu, and the system goes to a blank screen after loading. I can still switch to a terminal (that's how I obtained the logs). The kernel crashes, and when trying to reboot it even kernel panics. The system will never boot to an UI again unless I uninstall the amdgpu pro drivers, even if at boot time the external graphic card is not connected anymore. (expresscard is unplugged from laptop) I attached the logs. I was not able to install the amdgpu-pro-18.50 on any kernel version, they all fail to compile the dkms driver (I went from 4.15 and up to 4.20, using ukuu, and for 4.15 I also tried the one from the supported ubuntu). amdgpu-pro-18.40 builds on 4.15, but fails to load the firmware. There is no stacktrace just smu failed to load firmware. -- You are receiving this mail because: You are the assignee for the bug.

1 6

[Bug 111402] amdgpu-pro-install fails to install on openSUSE Leap 15.1 due to insufficient checks of $ID [PATCH included]
by bugzilla-daemon＠freedesktop.org 02 Oct '19

02 Oct '19

https://bugs.freedesktop.org/show_bug.cgi?id=111402 Bug ID: 111402 Summary: amdgpu-pro-install fails to install on openSUSE Leap 15.1 due to insufficient checks of $ID [PATCH included] Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu-pro Assignee: dri-devel(a)lists.freedesktop.org Reporter: public_timo.s(a)silentcreek.de Created attachment 145064 --> https://bugs.freedesktop.org/attachment.cgi?id=145064&action=edit Simple fix that allows installing on openSUSE Leap 15.1 Hi, I downloaded the latest amdgpu-pro-19.30-844693-sle-15.tar.xz package from amd.com and tried to install it on openSUSE Leap 15.1 following the docs [1]. The command $ ./amdgpu-pro-install --opencl=legacy --headless failed with the following error: tee: /etc/yum.repos.d/amdgpu-pro-local.repo: No such file or directory So, the installer seems to mistake my system for a RHEL/CentOS-based OS. Looking at the code, I noticed the script gets the $ID from /etc/os-release which in my case looks like this: NAME="openSUSE Leap" VERSION="15.1 " ID="opensuse-leap" [...] The function yum_repo() in the script does not properly check the $ID, however. It only matches against the strings 'sles', 'sled' and 'opensuse', but not 'opensuse-leap'. This is contrary to the function os_release() which matches opensuse-leap as well (with a wildcard). So, the solution to the issue is a simple wildcard. I'm attaching a patch that allowed me to run the installer on openSUSE Leap 15.1. Regards, Timo [1] https://amdgpu-install.readthedocs.io/en/latest/install-installing.html -- You are receiving this mail because: You are the assignee for the bug.

1 2

[Bug 110188] AMD graphics card driver cannot be installed on Fedora 29
by bugzilla-daemon＠freedesktop.org 02 Oct '19

02 Oct '19

https://bugs.freedesktop.org/show_bug.cgi?id=110188 Bug ID: 110188 Summary: AMD graphics card driver cannot be installed on Fedora 29 Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: All Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: xieqiao(a)yahoo.com The lastest Radeon™ Software for Linux® Driver for RHEL 7.6 / CentOS 7.6 cannot be installed on my Fedora 29 with both Radeon RX480 and Radeon VII. I need to have at least one GPU (e.g. RX480) being recognized by Fedora 29. I'm quite frustrated. I just want to install AMD driver, and it turned out to be a subscription problem, which simply does not working after trying various menthods. Registering to: subscription.rhsm.redhat.com:443/subscription Username: xxxxx Password: module 'os' has no attribute 'errno' It seems Password cannot be typed So I have no choice but to mount the downloaded rhel 7 and done everything accordingly step by step without errors. https://access.redhat.com/solutions/1355683 https://amdgpu-install.readthedocs.io/en/latest/install-prereq.html But when I execute $ ./amdgpu-install -y, there still remains the same prompt: "No match for argument: amdgpu-dkms No match for argument: amdgpu" -- You are receiving this mail because: You are the assignee for the bug.

1 5

[Bug 110926] on Centos 6.10
by bugzilla-daemon＠freedesktop.org 02 Oct '19

02 Oct '19

https://bugs.freedesktop.org/show_bug.cgi?id=110926 Bug ID: 110926 Summary: on Centos 6.10 Product: DRI Version: XOrg git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: blocker Priority: medium Component: DRM/AMDgpu-pro Assignee: dri-devel(a)lists.freedesktop.org Reporter: wilhelm.horrix(a)gmail.com Created attachment 144566 --> https://bugs.freedesktop.org/attachment.cgi?id=144566&action=edit X- server won't start 1.) The pre-install script looks for '/boot/SystemMap-' 2.) Xorg.0.log excerpt [ 27.790] (II) LoadModule: "amdgpu" [ 27.790] (II) Loading /opt/amdgpu/lib64/xorg/modules/drivers/amdgpu_drv.so [ 27.790] (II) Module amdgpu: vendor="X.Org Foundation" [ 27.790] compiled for 1.17.4, module version = 18.1.99 [ 27.790] Module class: X.Org Video Driver [ 27.790] ABI class: X.Org Video Driver, version 19.0 [ 27.790] (II) AMDGPU: Driver for AMD Radeon: All GPUs supported by the amdgpu kernel driver [ 27.790] (++) using VT number 1 [ 27.792] (II) AMDGPU(0): [KMS] drm report modesetting isn't supported. [ 27.792] (EE) Screen 0 deleted because of no matching config section. [ 27.792] (II) UnloadModule: "amdgpu" [ 27.792] (EE) Device(s) detected, but none match those in the config file. [ 27.792] (EE) Fatal server error: [ 27.792] (EE) no screens found(EE) [ 27.792] (EE) -- You are receiving this mail because: You are the assignee for the bug.

1 1

[Bug 91749] Tonga IH ring misaligned
by bugzilla-daemon＠freedesktop.org 02 Oct '19

02 Oct '19

https://bugs.freedesktop.org/show_bug.cgi?id=91749 Bug ID: 91749 Summary: Tonga IH ring misaligned Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: jay(a)jcornwall.me >From amdgpu_ih.c: adev->irq.ih.ring = kzalloc(adev->irq.ih.ring_size + 8, GFP_KERNEL); if (adev->irq.ih.ring == NULL) return -ENOMEM; adev->irq.ih.rb_dma_addr = pci_map_single(adev->pdev, (void *)adev->irq.ih.ring, adev->irq.ih.ring_size, PCI_DMA_BIDIRECTIONAL); The Tonga IH_RB_BASE register requires 256B alignment. kzalloc does not guarantee this, e.g.: adev->irq.ih.ring: 0xFFFF880835B22148 adev->irq.ih.rb_dma_addr: 0x835B22148 IH_RB_BASE: 0835b221 This causes amdgpu_ih_decode_iv to read ahead of the last written IV, missing it, when this misalignment occurs. -- You are receiving this mail because: You are the assignee for the bug.

1 3

[PATCH v2 0/9] drm/print: add and use drm_debug_enabled()
by Jani Nikula 02 Oct '19

02 Oct '19

Hi all, v2 of [1], a little refactoring around drm_debug access to abstract it better. There shouldn't be any functional changes. I'd appreciate acks for merging the lot via drm-misc. If there are any objections to that, we'll need to postpone the last patch until everything has been merged and converted in drm-next. BR, Jani. Cc: Eric Engestrom <eric.engestrom(a)intel.com> Cc: Alex Deucher <alexander.deucher(a)amd.com> Cc: Christian König <christian.koenig(a)amd.com> Cc: David (ChunMing) Zhou <David1.Zhou(a)amd.com> Cc: amd-gfx(a)lists.freedesktop.org Cc: Ben Skeggs <bskeggs(a)redhat.com> Cc: nouveau(a)lists.freedesktop.org Cc: Rob Clark <robdclark(a)gmail.com> Cc: Sean Paul <sean(a)poorly.run> Cc: linux-arm-msm(a)vger.kernel.org Cc: freedreno(a)lists.freedesktop.org Cc: Francisco Jerez <currojerez(a)riseup.net> Cc: Lucas Stach <l.stach(a)pengutronix.de> Cc: Russell King <linux+etnaviv(a)armlinux.org.uk> Cc: Christian Gmeiner <christian.gmeiner(a)gmail.com> Cc: etnaviv(a)lists.freedesktop.org [1] http://mid.mail-archive.com/cover.1568375189.git.jani.nikula@intel.com Jani Nikula (9): drm/print: move drm_debug variable to drm_print.[ch] drm/print: add drm_debug_enabled() drm/etnaviv: use drm_debug_enabled() to check for debug categories drm/i2c/sil164: use drm_debug_enabled() to check for debug categories drm/i915: use drm_debug_enabled() to check for debug categories drm/msm: use drm_debug_enabled() to check for debug categories drm/nouveau: use drm_debug_enabled() to check for debug categories drm/amdgpu: use drm_debug_enabled() to check for debug categories drm/print: rename drm_debug to __drm_debug to discourage use drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c | 4 ++-- drivers/gpu/drm/drm_atomic_uapi.c | 2 +- drivers/gpu/drm/drm_dp_mst_topology.c | 6 ++--- drivers/gpu/drm/drm_drv.c | 17 --------------- drivers/gpu/drm/drm_edid.c | 2 +- drivers/gpu/drm/drm_edid_load.c | 2 +- drivers/gpu/drm/drm_mipi_dbi.c | 4 ++-- drivers/gpu/drm/drm_print.c | 23 ++++++++++++++++++-- drivers/gpu/drm/drm_vblank.c | 6 ++--- drivers/gpu/drm/etnaviv/etnaviv_buffer.c | 8 +++---- drivers/gpu/drm/i2c/sil164_drv.c | 2 +- drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- drivers/gpu/drm/i915/i915_drv.c | 2 +- drivers/gpu/drm/i915/i915_gem.h | 2 +- drivers/gpu/drm/i915/i915_utils.c | 2 +- drivers/gpu/drm/i915/intel_pm.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 4 ++-- drivers/gpu/drm/nouveau/dispnv50/disp.h | 4 ++-- drivers/gpu/drm/nouveau/nouveau_drv.h | 4 ++-- include/drm/drm_drv.h | 2 -- include/drm/drm_print.h | 8 +++++++ 22 files changed, 60 insertions(+), 52 deletions(-) -- 2.20.1

4 21

[PATCH] drm/amd/display: memory leak
by Navid Emamdoost 02 Oct '19

02 Oct '19

In dcn*_clock_source_create when dcn20_clk_src_construct fails allocated clk_src needs release. Signed-off-by: Navid Emamdoost <navid.emamdoost(a)gmail.com> --- drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 3 ++- drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 1 + 7 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c index 6248c8455314..21de230b303a 100644 --- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c +++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c @@ -667,7 +667,8 @@ struct clock_source *dce100_clock_source_create( clk_src->base.dp_clk_src = dp_clk_src; return &clk_src->base; } - + + kfree(clk_src); BREAK_TO_DEBUGGER(); return NULL; } diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c index 764329264c3b..0cb83b0e0e1e 100644 --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c @@ -714,6 +714,7 @@ struct clock_source *dce110_clock_source_create( return &clk_src->base; } + kfree(clk_src); BREAK_TO_DEBUGGER(); return NULL; } diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c index c6136e0ed1a4..147d77173e2b 100644 --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c @@ -687,6 +687,7 @@ struct clock_source *dce112_clock_source_create( return &clk_src->base; } + kfree(clk_src); BREAK_TO_DEBUGGER(); return NULL; } diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c index 4a6ba3173a5a..0b5eeff17d00 100644 --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c @@ -500,6 +500,7 @@ static struct clock_source *dce120_clock_source_create( return &clk_src->base; } + kfree(clk_src); BREAK_TO_DEBUGGER(); return NULL; } diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c index 860a524ebcfa..952440893fbb 100644 --- a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c +++ b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c @@ -701,6 +701,7 @@ struct clock_source *dce80_clock_source_create( return &clk_src->base; } + kfree(clk_src); BREAK_TO_DEBUGGER(); return NULL; } diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c index a12530a3ab9c..3f25e8da5396 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c @@ -786,6 +786,7 @@ struct clock_source *dcn10_clock_source_create( return &clk_src->base; } + kfree(clk_src); BREAK_TO_DEBUGGER(); return NULL; } diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c index b949e202d6cb..418fdcf1f492 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c +++ b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c @@ -955,6 +955,7 @@ struct clock_source *dcn20_clock_source_create( return &clk_src->base; } + kfree(clk_src) BREAK_TO_DEBUGGER(); return NULL; } -- 2.17.1

2 2

[PATCH] drm/amdgpu: Initialize variable before use
by Siqueira, Rodrigo 02 Oct '19

02 Oct '19

The 'debug_data' variable gets printed in debug statements without a prior initialization in the function hubbub1_verify_allow_pstate_change_high, as reported when building with gcc 9.1.0: warning: ‘debug_data’ may be used uninitialized in this function [-Wmaybe-uninitialized] 290 | printk##once(KERN_##level "[" DRM_NAME "] " fmt, ##__VA_ARGS__) | ^~~~~~ dc/dcn10/dcn10_hubbub.c:134:15: note: ‘debug_data’ was declared here 134 | unsigned int debug_data; Note that initialize debug_data with 0, in this case, is safe because we have a loop in a few lines below that will initialize this variable with the proper value. Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira(a)amd.com> --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c index a780057e2dbc..b6967a7e6c7b 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c @@ -133,7 +133,7 @@ bool hubbub1_verify_allow_pstate_change_high( static unsigned int max_sampled_pstate_wait_us; /* data collection */ static bool forced_pstate_allow; /* help with revert wa */ - unsigned int debug_data; + unsigned int debug_data = 0; unsigned int i; if (forced_pstate_allow) { -- 2.23.0

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2019