dri-devel December 2020

dri-devel@lists.freedesktop.org

278 participants
659 discussions

[PATCH] drm/qxl: Use managed mode-config init
by Tian Tao 07 Jan '21

07 Jan '21

Using drmm_mode_config_init() sets up managed release of modesetting resources. Signed-off-by: Tian Tao <tiantao6(a)hisilicon.com> --- drivers/gpu/drm/qxl/qxl_display.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c index 012bce0..38d6b59 100644 --- a/drivers/gpu/drm/qxl/qxl_display.c +++ b/drivers/gpu/drm/qxl/qxl_display.c @@ -1195,7 +1195,9 @@ int qxl_modeset_init(struct qxl_device *qdev) … [View More]

2 1

[PATCH] drm/pci: Use pcim_enable_device()
by Tian Tao 07 Jan '21

07 Jan '21

Using the managed function simplifies the error handling. After unloading the driver, the PCI device should now get disabled as well. Signed-off-by: Tian Tao <tiantao6(a)hisilicon.com> --- drivers/gpu/drm/drm_pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c index 6dba4b8..0616172 100644 --- a/drivers/gpu/drm/drm_pci.c +++ b/drivers/gpu/drm/drm_pci.c @@ -207,7 +207,7 @@ static int drm_get_pci_dev(struct … [View More]

2 1

[PATCH v3 0/8] drm: Support short-term vmap via vmap_local
by Thomas Zimmermann 07 Jan '21

07 Jan '21

(was: drm/vram-helper: Lock GEM BOs while they are mapped) GEM VRAM helpers used to pin the BO in their implementation of vmap, so that they could not be relocated. In recent discussions, [1][2] it became clear that this is incorrect for in-kernel use cases, such as fbdev emulation; which should rather depend on the reservation lock to prevent relocation. This patchset addresses the issue by introducing the new interfaces vmap_local and vunmap_local throughout dma-buf and GEM. It further adds … [View More]support to DRM's CMA, SHMEM and VRAM helpers and finally converts fbdev emulation to the new interface. Patches 1 and 2 prepare the ast cursor code for the later changes. Patches 3 and 4 add the vmap_local infrastructure throughout dma-buf, GEM and PRIME. Patches 5 to 7 add implementations of vmap_local to DRM's various GEM helper libraries. Due to the simple nature of these libraries, existing vmap code can be reused easily. Several drivers are updateed as well to use the new interfaces. Patch 8 converts generic fbdev emulation to use vmap_local. Only DRM drivers that use GEM helpers currently use fbdev emulation, so patches 5 to 7 covered all necessary instances. I smoke-tested the patchset with ast (VRAM helpers), mgag200 (SHMEM) and vc4 (CMA). I also tested with a version of radeon (raw TTM) that has been converted to generic fbdev emulation. v3: * rewrite patchset around vmap_local v2: * make importers acquire resv locks by themselves * document dma-buf vamp/vunmap ops [1] https://patchwork.freedesktop.org/patch/400054/?series=83765&rev=1 [2] https://patchwork.freedesktop.org/patch/405407/?series=84401&rev=2 Thomas Zimmermann (8): drm/ast: Don't pin cursor source BO explicitly during update drm/ast: Only map cursor BOs during updates dma-buf: Add vmap_local and vnumap_local operations drm/gem: Create infrastructure for GEM vmap_local drm/cma-helper: Provide a vmap function for short-term mappings drm/shmem-helper: Provide a vmap function for short-term mappings drm/vram-helper: Provide a vmap function for short-term mappings drm/fb-helper: Move BO locking from DRM client to fbdev damage worker drivers/dma-buf/dma-buf.c | 80 ++++++++++++++ drivers/gpu/drm/ast/ast_cursor.c | 70 +++++++----- drivers/gpu/drm/ast/ast_drv.h | 2 - drivers/gpu/drm/drm_client.c | 91 ++++++++++++++++ drivers/gpu/drm/drm_fb_helper.c | 41 +++---- drivers/gpu/drm/drm_gem.c | 28 +++++ drivers/gpu/drm/drm_gem_cma_helper.c | 35 ++++++ drivers/gpu/drm/drm_gem_shmem_helper.c | 71 ++++++++++++- drivers/gpu/drm/drm_gem_vram_helper.c | 142 ++++++++++++++++--------- drivers/gpu/drm/drm_internal.h | 2 + drivers/gpu/drm/drm_prime.c | 39 +++++++ drivers/gpu/drm/mgag200/mgag200_mode.c | 16 ++- drivers/gpu/drm/tiny/cirrus.c | 10 +- drivers/gpu/drm/tiny/gm12u320.c | 14 ++- drivers/gpu/drm/udl/udl_modeset.c | 18 ++-- drivers/gpu/drm/vboxvideo/vbox_mode.c | 15 +-- drivers/gpu/drm/vc4/vc4_bo.c | 13 +++ drivers/gpu/drm/vc4/vc4_drv.h | 1 + drivers/gpu/drm/virtio/virtgpu_prime.c | 2 + include/drm/drm_client.h | 4 + include/drm/drm_gem.h | 20 ++++ include/drm/drm_gem_cma_helper.h | 1 + include/drm/drm_gem_shmem_helper.h | 2 + include/drm/drm_gem_vram_helper.h | 2 + include/drm/drm_prime.h | 2 + include/linux/dma-buf.h | 34 ++++++ 26 files changed, 635 insertions(+), 120 deletions(-) -- 2.29.2 [View Less]

2 25

[PATCH] drm/i915/dsi: Use unconditional msleep for the panel_on_delay when there is no reset-deassert MIPI-sequence
by Hans de Goede 07 Jan '21

07 Jan '21

Commit 25b4620ee822 ("drm/i915/dsi: Skip delays for v3 VBTs in vid-mode") added an intel_dsi_msleep() helper which skips sleeping if the MIPI-sequences have a version of 3 or newer and the panel is in vid-mode; and it moved a bunch of msleep-s over to this new helper. This was based on my reading of the big comment around line 730 which starts with "Panel enable/disable sequences from the VBT spec.", where the "v3 video mode seq" column does not have any wait t# entries. Given that this code … [View More]

2 3

[PULL] drm-misc-next
by Maarten Lankhorst 07 Jan '21

07 Jan '21

drm-misc-next-2020-12-17: drm-misc-next for v5.12: UAPI Changes: - Not necessarily one, but we document that userspace needs to force probe connectors. Cross-subsystem Changes: - Require FB_ATY_CT for aty on sparc64. - video: Fix documentation, and a few compiler warnings. - Add devicetree bindings for DP connectors. - dma-buf: Update kernel-doc, and add might_lock for resv objects in begin/end_cpu_access. Core Changes: - ttm: Warn when releasing a pinned bo. - ttm: Cleanup bo size handling. … [View More]- cma-helper: Remove prime infix, and implement mmap as GEM CMA functions. - Split drm_prime_sg_to_page_addr_arrays into 2 functions. - Add a new api to install irq using devm. - Update panel kerneldoc to inline style. - Add DP support to drm/bridge. - Assorted small fixes to ttm, fb-helper, scheduler. - Add atomic_commit_setup function callback. - Automatically use the atomic gamma_set, instead of forcing drivers to declare the default atomic version. - Allow using degamma for legacy gamma if gamma is not available. - Clarify that primary/cursor planes are not tied to 1 crtc (depending on possible_crtcs). - ttm: Cleanup the lru handler. Driver Changes: - Add pm support to ingenic. - Assorted small fixes in radeon, via, rockchip, omap2fb, kmb, gma500, nouveau, virtio, hisilicon, ingenic, s6e63m0 panel, ast, udlfb. - Add BOE NV110WTM-N61, ys57pss36bh5gq, Khadas TS050 panels. - Stop using pages with drm_prime_sg_to_page_addr_arrays, and switch all callers to use ttm_sg_tt_init. - Cleanup compiler and docbook warnings in a lot of fbdev devices. - Use the drmm_vram_helper in hisilicon. - Add support for BCM2711 DSI1 in vc4. - Add support for 8-bit delta RGB panels to ingenic. - Add documentation on how to test vkms. - Convert vc4 to atomic helpers. - Use degamma instead of gamma table in omap, to add support for CTM and color encoding/range properties. - Rework omap DSI code, and merge all omapdrm modules now that the last omap panel is now a drm panel. - More refactoring of omap dsi code. - Enable 10/12 bpc outputs in vc4. The following changes since commit 5fbd41d3bf123af6a135bdea564087ec0f563eb0: Merge tag 'drm-misc-next-2020-11-27-1' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2020-12-15 10:21:48 +0100) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-next-2020-12-17 for you to fetch changes up to c545781e1c55ab680dcc49c37212d5327b9d6812: dma-buf: doc polish for pin/unpin (2020-12-16 11:28:34 +0100) ---------------------------------------------------------------- drm-misc-next for v5.12: UAPI Changes: - Not necessarily one, but we document that userspace needs to force probe connectors. Cross-subsystem Changes: - Require FB_ATY_CT for aty on sparc64. - video: Fix documentation, and a few compiler warnings. - Add devicetree bindings for DP connectors. - dma-buf: Update kernel-doc, and add might_lock for resv objects in begin/end_cpu_access. Core Changes: - ttm: Warn when releasing a pinned bo. - ttm: Cleanup bo size handling. - cma-helper: Remove prime infix, and implement mmap as GEM CMA functions. - Split drm_prime_sg_to_page_addr_arrays into 2 functions. - Add a new api to install irq using devm. - Update panel kerneldoc to inline style. - Add DP support to drm/bridge. - Assorted small fixes to ttm, fb-helper, scheduler. - Add atomic_commit_setup function callback. - Automatically use the atomic gamma_set, instead of forcing drivers to declare the default atomic version. - Allow using degamma for legacy gamma if gamma is not available. - Clarify that primary/cursor planes are not tied to 1 crtc (depending on possible_crtcs). - ttm: Cleanup the lru handler. Driver Changes: - Add pm support to ingenic. - Assorted small fixes in radeon, via, rockchip, omap2fb, kmb, gma500, nouveau, virtio, hisilicon, ingenic, s6e63m0 panel, ast, udlfb. - Add BOE NV110WTM-N61, ys57pss36bh5gq, Khadas TS050 panels. - Stop using pages with drm_prime_sg_to_page_addr_arrays, and switch all callers to use ttm_sg_tt_init. - Cleanup compiler and docbook warnings in a lot of fbdev devices. - Use the drmm_vram_helper in hisilicon. - Add support for BCM2711 DSI1 in vc4. - Add support for 8-bit delta RGB panels to ingenic. - Add documentation on how to test vkms. - Convert vc4 to atomic helpers. - Use degamma instead of gamma table in omap, to add support for CTM and color encoding/range properties. - Rework omap DSI code, and merge all omapdrm modules now that the last omap panel is now a drm panel. - More refactoring of omap dsi code. - Enable 10/12 bpc outputs in vc4. ---------------------------------------------------------------- Arnd Bergmann (1): drm/kmb: fix array bounds warning Bernard Zhao (1): via/via_irq: use __func__ to replace string function name Christian König (13): drm/radeon: fix check order in radeon_bo_move drm/radeon: stop using pages with drm_prime_sg_to_page_addr_arrays v2 drm/amdgpu: stop using pages with drm_prime_sg_to_page_addr_arrays drm/nouveau: stop using pages with drm_prime_sg_to_page_addr_arrays v2 drm/vmwgfx: switch to ttm_sg_tt_init drm/qxl: switch to ttm_sg_tt_init drm/ttm: nuke ttm_dma_tt_init drm/prime: split array import functions v4 drm/ttm/drivers: remove unecessary ttm_module.h include v2 drm/ttm: stop destroying pinned ghost object drm/ttm: cleanup BO size handling v3 drm/ttm: use pin_count more extensively drm/ttm: cleanup LRU handling further Chuhong Yuan (1): drm/fb-helper: Add missed unlocks in setcmap_legacy() Dafna Hirschfeld (2): drm/rockchip: for error print, use the correct device pointer drm/rockchip: fix typo in Kconfig 's/HDMI/dsi/' Dan Carpenter (3): drm/kmb: Remove an unnecessary NULL check gma500: clean up error handling in init drm/panel: khadas: Fix error code in khadas_ts050_panel_add() Daniel Vetter (9): drm/ttm: Warn on pinning without holding a reference drm/nouveau: Drop mutex_lock_nested for atomic dma-buf: Fix kerneldoc formatting drm/vkms: Unset preferred_depth drm/amdkfd: fix ttm size refactor fallout dma-buf: Remove kmap kerneldoc vestiges dma-buf: some kerneldoc formatting fixes dma-buf: begin/end_cpu might lock the dma_resv lock dma-buf: doc polish for pin/unpin Dave Stevenson (4): drm/vc4: dsi: Correct DSI register definition drm/vc4: dsi: Add support for DSI0 dt-bindings: Add compatible for BCM2711 DSI1 drm/vc4: dsi: Add configuration for BCM2711 DSI1 Douglas Anderson (7): drm: panel: simple: Fixup the struct panel_desc kernel doc drm: panel: simple: Defer unprepare delay till next prepare to shorten it drm: panel: simple: Allow specifying the delay from prepare to enable dt-bindings: dt-bindings: display: simple: Add BOE NV110WTM-N61 drm: panel: simple: Add BOE NV110WTM-N61 drm: panel: Fully transition panel_desc kerneldoc to inline style drm: panel: add flags to BOE NV110WTM-N61 Guido Günther (6): drm/panel: st7703: Use dev_err_probe drm/panel: mantix: Tweak init sequence drm/panel: mantix: Allow to specify default mode for different panels drm/panel: mantix: Support panel from Shenzhen Yashi Changhua Intelligent Technology Co dt-bindings: vendor-prefixes: Add ys vendor prefix dt-bindings: display: mantix: Add compatible for panel from YS Gurchetan Singh (3): drm/virtio: virtio_{blah} --> virtio_gpu_{blah} drm/virtio: rework virtio_fence_signaled drm/virtio: consider dma-fence context when signaling Jialin Zhang (1): drm/gma500: Fix error return code in psb_driver_load() Jonathan Liu (1): drm/rockchip: dw_hdmi: fix incorrect clock in vpll clock error message Jyri Sarha (2): drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix drm/omap: Enable COLOR_ENCODING and COLOR_RANGE properties for planes Krzysztof Kozlowski (1): drm/ingenic: depend on COMMON_CLK to fix compile tests Laurent Pinchart (1): drm: Remove drmm_add_final_kfree() declaration from public headers Linus Walleij (2): dt-bindings: display: mcde: Convert to YAML schema drm/panel: s6e63m0: Fix init sequence again Luben Tuikov (4): drm/scheduler: "node" --> "list" gpu/drm: ring_mirror_list --> pending_list drm/scheduler: Essentialize the job done callback drm/sched: Add missing structure comment Maarten Lankhorst (1): Merge drm/drm-next into drm-misc-next Maxime Ripard (20): drm/vc4: hdmi: Don't poll for the infoframes status on setup drm/vc4: drv: Remove the DSI pointer in vc4_drv drm/vc4: dsi: Use snprintf for the PHY clocks instead of an array drm/vc4: dsi: Introduce a variant structure drm: Introduce an atomic_commit_setup function drm: Document use-after-free gotcha with private objects drm/vc4: Simplify a bit the global atomic_check drm/vc4: kms: Wait on previous FIFO users before a commit drm/vc4: kms: Remove unassigned_channels from the HVS state drm/vc4: kms: Remove async modeset semaphore drm/vc4: kms: Convert to atomic helpers drm/vc4: hvs: Align the HVS atomic hooks to the new API drm/vc4: Pass the atomic state to encoder hooks drm/vc4: hdmi: Take into account the clock doubling flag in atomic_check drm/vc4: hdmi: Don't access the connector state in reset if kmalloc fails drm/vc4: hdmi: Create a custom connector state drm/vc4: hdmi: Store pixel frequency in the connector state drm/vc4: hdmi: Use the connector state pixel rate for the PHY drm/vc4: hdmi: Limit the BCM2711 to the max without scrambling drm/vc4: hdmi: Enable 10/12 bpc output Neil Armstrong (2): dt-bindings: panel-simple-dsi: add Khadas TS050 panel bindings drm: panel: add Khadas TS050 panel driver Nirmoy Das (1): drm/amdgpu: clean up bo in vce and vcn test Paul Cercueil (4): drm/ingenic: Add basic PM support drm/ingenic: Compute timings according to adjusted_mode->crtc_* drm/ingenic: Properly compute timings when using a 3x8-bit panel drm/ingenic: Add support for serial 8-bit delta-RGB panels Randy Dunlap (1): fbdev: aty: SPARC64 requires FB_ATY_CT Sam Ravnborg (35): video: Fix kernel-doc warnings in of_display_timing + of_videomode video: fbcon: Fix warnings by using pr_debug() in fbcon video: fbdev: s1d13xxxfb: Fix kernel-doc and set but not used warnings video: fbdev: aty: Delete unused variable in radeon_monitor video: fbdev: aty: Fix set but not used warnings video: fbdev: aty: Fix set but not used warnings in mach64_ct video: fbdev: sis: Fix defined but not used warnings video: fbdev: sis: Fix defined but not used warning of SiS_TVDelay video: fbdev: sis: Fix set but not used warnings in init.c video: fbdev: sis: Fix set but not used warnings in sis_main video: fbdev: via: Fix set but not used warning for mode_crt_table video: fbdev: tdfx: Fix set but not used warning in att_outb() video: fbdev: riva: Fix kernel-doc and set but not used warnings video: fbdev: pm2fb: Fix kernel-doc warnings video: fbdev: tgafb: Fix kernel-doc and set but not used warnings video: fbdev: mx3fb: Fix kernel-doc, set but not used and string warnings video: fbdev: sstfb: Updated logging to fix set but not used warnings video: fbdev: neofb: Fix set but not used warning for CursorMem video: fbdev: nvidia: Fix set but not used warnings video: fbdev: omapfb: Fix set but not used warnings in dsi video: fbdev: s3c-fb: Fix kernel-doc and set but not used warnings video: fbdev: uvesafb: Fix string related warnings video: fbdev: cirrusfb: Fix kernel-doc and set but not used warnings video: fbdev: hgafb: Fix kernel-doc warnings video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core video: fbdev: uvesafb: Fix set but not used warning video: fbdev: sparc drivers: fix kernel-doc warnings for blank_mode video: fbdev: mmp: Fix kernel-doc warning for lcd_spi_write video: fbdev: wmt_ge_rops: Fix function not declared warnings video: fbdev: goldfishfb: Fix defined but not used warning video: fbdev: gbefb: Fix set but not used warning video: fbdev: efifb: Fix set but not used warning for screen_pitch video: fbdev: controlfb: Fix set but not used warnings video: fbdev: sis: Drop useless call to SiS_GetResInfo() Sebastian Reichel (49): Revert "drm/omap: dss: Remove unused omap_dss_device operations" drm/omap: drop unused dsi.configure_pins drm/omap: dsi: use MIPI_DSI_FMT_* instead of OMAP_DSS_DSI_FMT_* drm/omap: constify write buffers drm/omap: dsi: add generic transfer function drm/omap: panel-dsi-cm: convert to transfer API drm/omap: dsi: unexport specific data transfer functions drm/omap: dsi: drop virtual channel logic drm/omap: dsi: simplify write function drm/omap: dsi: simplify read functions drm/omap: dsi: switch dsi_vc_send_long/short to mipi_dsi_msg drm/omap: dsi: introduce mipi_dsi_host drm/omap: panel-dsi-cm: use DSI helpers drm/omap: dsi: request VC via mipi_dsi_attach drm/omap: panel-dsi-cm: drop hardcoded VC drm/omap: panel-dsi-cm: use common MIPI DCS 1.3 defines drm/omap: dsi: drop unused memory_read() drm/omap: dsi: drop unused get_te() drm/omap: dsi: drop unused enable_te() drm/omap: dsi: drop useless sync() drm/omap: dsi: use pixel-format and mode from attach drm/omap: panel-dsi-cm: use bulk regulator API drm/omap: dsi: lp/hs switching support for transfer() drm/omap: dsi: move TE GPIO handling into core drm/omap: dsi: drop custom enable_te() API drm/omap: dsi: do bus locking in host driver drm/omap: dsi: untangle ulps ops from enable/disable drm/omap: dsi: do ULPS in host driver drm/omap: dsi: move panel refresh function to host drm/omap: dsi: Reverse direction of the DSS device enable/disable operations drm/omap: dsi: drop custom panel capability support drm/omap: dsi: convert to drm_panel drm/omap: drop omapdss-boot-init drm/omap: dsi: implement check timings drm/omap: panel-dsi-cm: use DEVICE_ATTR_RO drm/omap: panel-dsi-cm: support unbinding drm/omap: panel-dsi-cm: fix remove() drm/omap: remove global dss_device variable drm/panel: Move OMAP's DSI command mode panel driver drm/omap: dsi: Register a drm_bridge drm/omap: remove legacy DSS device operations drm/omap: remove unused omap_connector drm/omap: simplify omap_display_id drm/omap: drop unused DSS next pointer drm/omap: drop DSS ops_flags drm/omap: drop dssdev display field drm/omap: simplify DSI manual update code drm/omap: dsi: simplify pin config ARM: omap2plus_defconfig: Update for moved DSI command mode panel Simon Ser (5): drm: document that user-space should force-probe connectors drm: fix typos in plane and CRTC overviews drm: rework description of primary and cursor planes drm: validate possible_crtcs for primary and cursor planes drm: require a non_NULL drm_crtc.primary Sumera Priyadarsini (1): drm/vkms: Add setup and testing information Thomas Zimmermann (4): drm/cma-helper: Remove prime infix from GEM object functions drm/cma-helper: Implement mmap as GEM CMA object functions drm/ast: Don't pin cursor source BO explicitly during update drm/ast: Only map cursor BOs during updates Tian Tao (11): drm/hisilicon: Code refactoring for hibmc_drm_drv drm/irq: Add the new api to install irq drm/hisilicon: Use the new api devm_drm_irq_install drm/hisilicon: Use managed VRAM-helper initialization drm/hisilicon: Delete the entire file hibmc_ttm.c drm/drv: switch to using devm_add_action_or_reset() drm/hisilicon: Use managed mode-config init drm/hisilicon: Delete unused local parameters drm/drv: Remove invalid assignments drm/hisilicon: Fix use-after-free drm/hisilicon: Fix rmmod hibmc_drm failed Tom Rix (1): omapfb: fbcon: remove trailing semicolon in macro definition Tomi Valkeinen (41): dt-bindings: dp-connector: add binding for DisplayPort connector drm/bridge: display-connector: add DP support drm: automatic legacy gamma support drm: add legacy support for using degamma for gamma drm/omap: use degamma property for gamma table drm/omap: rearrange includes in omapdss.h drm/omap: squash omapdrm sub-modules into one drm/omap: remove unused display.c drm/omap: drop unused owner field drm/omap: remove dispc_ops drm/omap: remove dss_mgr_ops drm/panel: panel-dsi-cm: use MIPI_DCS_GET_ERROR_COUNT_ON_DSI drm/panel: panel-dsi-cm: cleanup tear enable ARM: dts: omap5: add address-cells & size-cells to dsi drm/omap: pll: fix iteration loop check drm/omap: dsi: set trans_mode according to client mode_flags drm/panel: panel-dsi-cm: set column & page at setup drm/omap: dsi: send nop instead of page & column drm/omap: dsi: simplify VC handling drm/omap: dsi: drop useless channel checks drm/omap: dsi: cleanup dispc channel usage drm/omap: dsi: rename 'channel' to 'vc' drm/omap: dsi: pass vc and channel to various functions drm/omap: dsi: untangle vc & channel drm/omap: dsi: skip dsi_vc_enable_hs when already in correct mode drm/omap: dsi: enable HS before sending the frame drm/omap: dsi: use separate VCs for cmd and video drm/panel: panel-dsi-cm: remove extra 'if' drm/panel: panel-dsi-cm: add panel database to driver drm/panel: panel-dsi-cm: drop unneeded includes drm/omap: dsi: move structs & defines to dsi.h drm/omap: dsi: move enable/disable to bridge enable/disable drm/omap: dsi: display_enable cleanup drm/omap: dsi: display_disable cleanup drm/omap: dsi: rename dsi_display_* functions drm/omap: dsi: cleanup initial vc setup drm/omap: dsi: split video mode enable/disable into separate func drm/omap: dsi: fix and cleanup ddr_clk_always_on drm/omap: dsi: remove ulps support drm/omap: dsi: fix DCS_CMD_ENABLE drm/omap: dsi: allow DSI commands to be sent early Zheng Yongjun (1): drm/omap: Delete useless kfree code Zqiang (1): udlfb: Fix memory leak in dlfb_usb_probe .../bindings/display/brcm,bcm2835-dsi0.yaml | 1 + .../bindings/display/connector/dp-connector.yaml | 56 + .../display/panel/mantix,mlaf057we51-x.yaml | 1 + .../bindings/display/panel/panel-simple-dsi.yaml | 2 + .../bindings/display/panel/panel-simple.yaml | 2 + .../devicetree/bindings/display/ste,mcde.txt | 104 -- .../devicetree/bindings/display/ste,mcde.yaml | 169 ++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + Documentation/driver-api/dma-buf.rst | 2 +- Documentation/gpu/vkms.rst | 70 + arch/arm/boot/dts/omap5.dtsi | 6 + arch/arm/configs/omap2plus_defconfig | 2 +- drivers/dma-buf/dma-buf.c | 74 +- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 16 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 9 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 +- drivers/gpu/drm/amd/amdgpu/mes_v10_1.c | 2 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 1 - drivers/gpu/drm/arm/malidp_crtc.c | 1 - drivers/gpu/drm/armada/armada_crtc.c | 1 - drivers/gpu/drm/ast/ast_cursor.c | 55 +- drivers/gpu/drm/ast/ast_drv.h | 2 - drivers/gpu/drm/ast/ast_mode.c | 1 - drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 1 - drivers/gpu/drm/bridge/display-connector.c | 46 +- drivers/gpu/drm/drm_atomic_helper.c | 79 +- drivers/gpu/drm/drm_color_mgmt.c | 125 +- drivers/gpu/drm/drm_crtc.c | 5 +- drivers/gpu/drm/drm_drv.c | 9 +- drivers/gpu/drm/drm_fb_helper.c | 20 +- drivers/gpu/drm/drm_file.c | 3 +- drivers/gpu/drm/drm_gem_cma_helper.c | 141 +- drivers/gpu/drm/drm_irq.c | 32 + drivers/gpu/drm/drm_mode_config.c | 19 + drivers/gpu/drm/drm_plane.c | 18 +- drivers/gpu/drm/drm_prime.c | 64 +- drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 3 +- drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 22 +- drivers/gpu/drm/gma500/psb_drv.c | 2 + drivers/gpu/drm/hisilicon/hibmc/Makefile | 2 +- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 2 +- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 83 +- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 10 +- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 2 +- drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c | 61 - drivers/gpu/drm/i915/display/intel_display.c | 1 - drivers/gpu/drm/ingenic/Kconfig | 1 + drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 60 +- drivers/gpu/drm/ingenic/ingenic-drm.h | 14 + drivers/gpu/drm/kmb/kmb_drv.c | 2 +- drivers/gpu/drm/kmb/kmb_plane.c | 3 + drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 1 - drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +- drivers/gpu/drm/msm/msm_gem.c | 2 +- drivers/gpu/drm/nouveau/dispnv50/head.c | 2 - drivers/gpu/drm/nouveau/nouveau_bo.c | 20 +- drivers/gpu/drm/nouveau/nouveau_display.c | 8 +- drivers/gpu/drm/nouveau/nouveau_drv.h | 1 - drivers/gpu/drm/nouveau/nouveau_prime.c | 4 +- drivers/gpu/drm/nouveau/nouveau_sgdma.c | 2 +- drivers/gpu/drm/nouveau/nv17_fence.c | 2 +- drivers/gpu/drm/nouveau/nv50_fence.c | 2 +- drivers/gpu/drm/omapdrm/Kconfig | 120 +- drivers/gpu/drm/omapdrm/Makefile | 19 +- drivers/gpu/drm/omapdrm/displays/Kconfig | 10 - drivers/gpu/drm/omapdrm/displays/Makefile | 2 - drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 1385 -------------- drivers/gpu/drm/omapdrm/dss/Kconfig | 135 -- drivers/gpu/drm/omapdrm/dss/Makefile | 20 - drivers/gpu/drm/omapdrm/dss/base.c | 87 +- drivers/gpu/drm/omapdrm/dss/dispc.c | 202 +- drivers/gpu/drm/omapdrm/dss/display.c | 60 - drivers/gpu/drm/omapdrm/dss/dpi.c | 1 - drivers/gpu/drm/omapdrm/dss/dsi.c | 1949 ++++++++------------ drivers/gpu/drm/omapdrm/dss/dsi.h | 456 +++++ drivers/gpu/drm/omapdrm/dss/dss.c | 28 +- drivers/gpu/drm/omapdrm/dss/dss.h | 72 +- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 1 - drivers/gpu/drm/omapdrm/dss/hdmi5.c | 1 - drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c | 229 --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 347 +--- drivers/gpu/drm/omapdrm/dss/output.c | 57 +- drivers/gpu/drm/omapdrm/dss/pll.c | 6 + drivers/gpu/drm/omapdrm/dss/sdi.c | 1 - drivers/gpu/drm/omapdrm/dss/venc.c | 2 - drivers/gpu/drm/omapdrm/omap_connector.c | 157 -- drivers/gpu/drm/omapdrm/omap_connector.h | 28 - drivers/gpu/drm/omapdrm/omap_crtc.c | 153 +- drivers/gpu/drm/omapdrm/omap_crtc.h | 2 - drivers/gpu/drm/omapdrm/omap_drv.c | 73 +- drivers/gpu/drm/omapdrm/omap_drv.h | 3 +- drivers/gpu/drm/omapdrm/omap_encoder.c | 59 +- drivers/gpu/drm/omapdrm/omap_gem.c | 3 +- drivers/gpu/drm/omapdrm/omap_irq.c | 34 +- drivers/gpu/drm/omapdrm/omap_plane.c | 41 +- drivers/gpu/drm/omapdrm/tcm-sita.c | 1 - drivers/gpu/drm/panel/Kconfig | 20 + drivers/gpu/drm/panel/Makefile | 2 + drivers/gpu/drm/panel/panel-dsi-cm.c | 665 +++++++ drivers/gpu/drm/panel/panel-khadas-ts050.c | 870 +++++++++ drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 39 +- drivers/gpu/drm/panel/panel-samsung-s6e63m0.c | 42 +- drivers/gpu/drm/panel/panel-simple.c | 221 ++- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 24 +- drivers/gpu/drm/pl111/pl111_drv.c | 2 +- drivers/gpu/drm/qxl/qxl_drv.h | 1 - drivers/gpu/drm/qxl/qxl_object.h | 2 +- drivers/gpu/drm/qxl/qxl_release.c | 2 +- drivers/gpu/drm/qxl/qxl_ttm.c | 3 +- drivers/gpu/drm/radeon/radeon.h | 1 - drivers/gpu/drm/radeon/radeon_cs.c | 3 +- drivers/gpu/drm/radeon/radeon_object.c | 13 +- drivers/gpu/drm/radeon/radeon_object.h | 4 +- drivers/gpu/drm/radeon/radeon_prime.c | 4 +- drivers/gpu/drm/radeon/radeon_trace.h | 2 +- drivers/gpu/drm/radeon/radeon_ttm.c | 67 +- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 1 - drivers/gpu/drm/rockchip/Kconfig | 2 +- drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 2 +- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 - drivers/gpu/drm/scheduler/sched_main.c | 120 +- drivers/gpu/drm/stm/ltdc.c | 1 - drivers/gpu/drm/ttm/ttm_agp_backend.c | 1 - drivers/gpu/drm/ttm/ttm_bo.c | 103 +- drivers/gpu/drm/ttm/ttm_bo_util.c | 16 +- drivers/gpu/drm/ttm/ttm_bo_vm.c | 7 +- drivers/gpu/drm/ttm/ttm_execbuf_util.c | 4 +- drivers/gpu/drm/ttm/ttm_memory.c | 3 +- drivers/gpu/drm/ttm/ttm_module.c | 3 +- {include => drivers/gpu}/drm/ttm/ttm_module.h | 0 drivers/gpu/drm/ttm/ttm_range_manager.c | 1 - drivers/gpu/drm/ttm/ttm_tt.c | 15 +- drivers/gpu/drm/vc4/vc4_bo.c | 6 +- drivers/gpu/drm/vc4/vc4_crtc.c | 38 +- drivers/gpu/drm/vc4/vc4_drv.h | 22 +- drivers/gpu/drm/vc4/vc4_dsi.c | 111 +- drivers/gpu/drm/vc4/vc4_hdmi.c | 165 +- drivers/gpu/drm/vc4/vc4_hdmi.h | 23 +- drivers/gpu/drm/vc4/vc4_hdmi_phy.c | 8 +- drivers/gpu/drm/vc4/vc4_hdmi_regs.h | 9 + drivers/gpu/drm/vc4/vc4_hvs.c | 18 +- drivers/gpu/drm/vc4/vc4_kms.c | 248 ++- drivers/gpu/drm/vc4/vc4_txp.c | 11 +- drivers/gpu/drm/vgem/vgem_drv.c | 3 +- drivers/gpu/drm/via/via_irq.c | 2 +- drivers/gpu/drm/virtio/virtgpu_debugfs.c | 24 +- drivers/gpu/drm/virtio/virtgpu_drv.h | 1 + drivers/gpu/drm/virtio/virtgpu_fence.c | 81 +- drivers/gpu/drm/vkms/vkms_drv.c | 5 +- drivers/gpu/drm/vmwgfx/ttm_object.c | 1 - drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 4 +- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 6 +- drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 1 - drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 1 - drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 4 +- drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 6 +- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_page_dirty.c | 8 +- drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_shader.c | 3 +- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 4 +- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 7 +- drivers/gpu/drm/vmwgfx/vmwgfx_thp.c | 1 - drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 4 +- drivers/gpu/drm/xen/xen_drm_front_gem.c | 4 +- drivers/video/fbdev/Kconfig | 2 +- drivers/video/fbdev/aty/atyfb_base.c | 11 +- drivers/video/fbdev/aty/mach64_ct.c | 15 +- drivers/video/fbdev/aty/radeon_monitor.c | 4 +- drivers/video/fbdev/bw2.c | 2 +- drivers/video/fbdev/cg3.c | 2 +- drivers/video/fbdev/cg6.c | 2 +- drivers/video/fbdev/cirrusfb.c | 20 +- drivers/video/fbdev/controlfb.c | 4 +- drivers/video/fbdev/core/fb_notify.c | 7 + drivers/video/fbdev/core/fbcon.c | 25 +- drivers/video/fbdev/core/fbmon.c | 2 +- drivers/video/fbdev/efifb.c | 3 +- drivers/video/fbdev/ffb.c | 2 +- drivers/video/fbdev/gbefb.c | 4 +- drivers/video/fbdev/goldfishfb.c | 2 + drivers/video/fbdev/hgafb.c | 10 +- drivers/video/fbdev/leo.c | 2 +- drivers/video/fbdev/mmp/hw/mmp_spi.c | 2 +- drivers/video/fbdev/mx3fb.c | 13 +- drivers/video/fbdev/neofb.c | 4 - drivers/video/fbdev/nvidia/nv_setup.c | 7 +- .../video/fbdev/omap2/omapfb/dss/dispc-compat.c | 2 +- drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 14 +- drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c | 4 +- drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 4 +- drivers/video/fbdev/p9100.c | 2 +- drivers/video/fbdev/pm2fb.c | 8 +- drivers/video/fbdev/riva/fbdev.c | 9 +- drivers/video/fbdev/riva/riva_hw.c | 28 +- drivers/video/fbdev/s1d13xxxfb.c | 3 +- drivers/video/fbdev/s3c-fb.c | 11 +- drivers/video/fbdev/sis/init.c | 33 +- drivers/video/fbdev/sis/oem310.h | 2 + drivers/video/fbdev/sis/sis.h | 1 - drivers/video/fbdev/sis/sis_main.c | 9 +- drivers/video/fbdev/sstfb.c | 2 +- drivers/video/fbdev/tcx.c | 2 +- drivers/video/fbdev/tdfxfb.c | 4 +- drivers/video/fbdev/tgafb.c | 7 +- drivers/video/fbdev/udlfb.c | 1 + drivers/video/fbdev/uvesafb.c | 6 +- drivers/video/fbdev/via/lcd.c | 4 +- drivers/video/fbdev/wmt_ge_rops.c | 1 + drivers/video/of_display_timing.c | 1 + drivers/video/of_videomode.c | 6 +- include/drm/drm_atomic.h | 20 + include/drm/drm_atomic_helper.h | 4 - include/drm/drm_gem_cma_helper.h | 14 +- include/drm/drm_irq.h | 2 +- include/drm/drm_managed.h | 2 - include/drm/drm_modeset_helper_vtables.h | 21 + include/drm/drm_prime.h | 7 +- include/drm/gpu_scheduler.h | 14 +- include/drm/ttm/ttm_bo_api.h | 13 +- include/drm/ttm/ttm_bo_driver.h | 6 +- include/drm/ttm/ttm_resource.h | 1 - include/drm/ttm/ttm_tt.h | 2 - include/linux/dma-buf-map.h | 2 +- include/linux/dma-buf.h | 39 +- include/uapi/drm/drm_mode.h | 13 +- include/video/sstfb.h | 4 +- 241 files changed, 5365 insertions(+), 5451 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/connector/dp-connector.yaml delete mode 100644 Documentation/devicetree/bindings/display/ste,mcde.txt create mode 100644 Documentation/devicetree/bindings/display/ste,mcde.yaml delete mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c delete mode 100644 drivers/gpu/drm/omapdrm/displays/Kconfig delete mode 100644 drivers/gpu/drm/omapdrm/displays/Makefile delete mode 100644 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c delete mode 100644 drivers/gpu/drm/omapdrm/dss/Kconfig delete mode 100644 drivers/gpu/drm/omapdrm/dss/Makefile delete mode 100644 drivers/gpu/drm/omapdrm/dss/display.c create mode 100644 drivers/gpu/drm/omapdrm/dss/dsi.h delete mode 100644 drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c delete mode 100644 drivers/gpu/drm/omapdrm/omap_connector.c delete mode 100644 drivers/gpu/drm/omapdrm/omap_connector.h create mode 100644 drivers/gpu/drm/panel/panel-dsi-cm.c create mode 100644 drivers/gpu/drm/panel/panel-khadas-ts050.c rename {include => drivers/gpu}/drm/ttm/ttm_module.h (100%) [View Less]

2 1

[PATCH] drm/stm: Remove usage of drm_display_mode_to_videomode()
by Marek Vasut 07 Jan '21

07 Jan '21

There is not much value in the extra conversion step, the calculations required for the LTDC IP are different than what is used in the drm_display_mode_to_videomode(), so just do the right ones in the LTDC driver right away. Signed-off-by: Marek Vasut <marex(a)denx.de> Cc: Alexandre Torgue <alexandre.torgue(a)st.com> Cc: Antonio Borneo <antonio.borneo(a)st.com> Cc: Benjamin Gaignard <benjamin.gaignard(a)st.com> Cc: Maxime Coquelin <mcoquelin.stm32(a)gmail.com> Cc: … [View More]Philippe Cornu <philippe.cornu(a)st.com> Cc: Sam Ravnborg <sam(a)ravnborg.org> Cc: Vincent Abriou <vincent.abriou(a)st.com> Cc: Yannick Fertre <yannick.fertre(a)st.com> Cc: linux-arm-kernel(a)lists.infradead.org Cc: linux-stm32(a)st-md-mailman.stormreply.com To: dri-devel(a)lists.freedesktop.org --- drivers/gpu/drm/stm/ltdc.c | 33 +++++++++++++++++---------------- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index 22c7e9fa5ab7..e8fc8fc50d94 100644 --- a/drivers/gpu/drm/stm/ltdc.c +++ b/drivers/gpu/drm/stm/ltdc.c @@ -545,7 +545,6 @@ static void ltdc_crtc_mode_set_nofb(struct drm_crtc *crtc) struct ltdc_device *ldev = crtc_to_ltdc(crtc); struct drm_device *ddev = crtc->dev; struct drm_display_mode *mode = &crtc->state->adjusted_mode; - struct videomode vm; u32 bus_flags = 0; u32 hsync, vsync, accum_hbp, accum_vbp, accum_act_w, accum_act_h; u32 total_width, total_height; @@ -565,31 +564,33 @@ static void ltdc_crtc_mode_set_nofb(struct drm_crtc *crtc) } } - drm_display_mode_to_videomode(mode, &vm); - DRM_DEBUG_DRIVER("CRTC:%d mode:%s\n", crtc->base.id, mode->name); - DRM_DEBUG_DRIVER("Video mode: %dx%d", vm.hactive, vm.vactive); + DRM_DEBUG_DRIVER("Video mode: %dx%d", mode->hdisplay, mode->vdisplay); DRM_DEBUG_DRIVER(" hfp %d hbp %d hsl %d vfp %d vbp %d vsl %d\n", - vm.hfront_porch, vm.hback_porch, vm.hsync_len, - vm.vfront_porch, vm.vback_porch, vm.vsync_len); + mode->hsync_start - mode->hdisplay, + mode->htotal - mode->hsync_end, + mode->hsync_end - mode->hsync_start, + mode->vsync_start - mode->vdisplay, + mode->vtotal - mode->vsync_end, + mode->vsync_end - mode->vsync_start); /* Convert video timings to ltdc timings */ - hsync = vm.hsync_len - 1; - vsync = vm.vsync_len - 1; - accum_hbp = hsync + vm.hback_porch; - accum_vbp = vsync + vm.vback_porch; - accum_act_w = accum_hbp + vm.hactive; - accum_act_h = accum_vbp + vm.vactive; - total_width = accum_act_w + vm.hfront_porch; - total_height = accum_act_h + vm.vfront_porch; + hsync = mode->hsync_end - mode->hsync_start - 1; + vsync = mode->vsync_end - mode->vsync_start - 1; + accum_hbp = mode->htotal - mode->hsync_start - 1; + accum_vbp = mode->vtotal - mode->vsync_start - 1; + accum_act_w = accum_hbp + mode->hdisplay; + accum_act_h = accum_vbp + mode->vdisplay; + total_width = mode->htotal - 1; + total_height = mode->vtotal - 1; /* Configures the HS, VS, DE and PC polarities. Default Active Low */ val = 0; - if (vm.flags & DISPLAY_FLAGS_HSYNC_HIGH) + if (mode->flags & DRM_MODE_FLAG_PHSYNC) val |= GCR_HSPOL; - if (vm.flags & DISPLAY_FLAGS_VSYNC_HIGH) + if (mode->flags & DRM_MODE_FLAG_PVSYNC) val |= GCR_VSPOL; if (bus_flags & DRM_BUS_FLAG_DE_LOW) -- 2.29.2 [View Less]

2 1

[PATCH V2] drm/stm: Fix bus_flags handling
by Marek Vasut 07 Jan '21

07 Jan '21

The drm_display_mode_to_videomode() does not populate DISPLAY_FLAGS_DE_LOW or DISPLAY_FLAGS_PIXDATA_NEGEDGE flags in struct videomode. Therefore, no matter what polarity the next bridge or display might require, these flags are never set, and thus the LTDC GCR_DEPOL and GCR_PCPOL bits are never set, and the LTDC behaves as if both DISPLAY_FLAGS_PIXDATA_POSEDGE and DISPLAY_FLAGS_DE_HIGH were always set. The fix for this problem is taken almost verbatim from MXSFB driver. In case there is a … [View More]bridge attached to the LTDC, the bridge might have extra polarity requirements, so extract bus_flags from the bridge and use them for LTDC configuration. Otherwise, extract bus_flags from the connector, which is the display. Fixes: b759012c5fa7 ("drm/stm: Add STM32 LTDC driver") Signed-off-by: Marek Vasut <marex(a)denx.de> Cc: Alexandre Torgue <alexandre.torgue(a)st.com> Cc: Antonio Borneo <antonio.borneo(a)st.com> Cc: Benjamin Gaignard <benjamin.gaignard(a)st.com> Cc: Maxime Coquelin <mcoquelin.stm32(a)gmail.com> Cc: Philippe Cornu <philippe.cornu(a)st.com> Cc: Sam Ravnborg <sam(a)ravnborg.org> Cc: Vincent Abriou <vincent.abriou(a)st.com> Cc: Yannick Fertre <yannick.fertre(a)st.com> Cc: linux-arm-kernel(a)lists.infradead.org Cc: linux-stm32(a)st-md-mailman.stormreply.com To: dri-devel(a)lists.freedesktop.org --- V2: Check if ldev->bridge->timings is non-NULL before accessing it --- drivers/gpu/drm/stm/ltdc.c | 22 ++++++++++++++++++++-- drivers/gpu/drm/stm/ltdc.h | 2 ++ 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index 1c9f18b4adfc..22c7e9fa5ab7 100644 --- a/drivers/gpu/drm/stm/ltdc.c +++ b/drivers/gpu/drm/stm/ltdc.c @@ -546,11 +546,17 @@ static void ltdc_crtc_mode_set_nofb(struct drm_crtc *crtc) struct drm_device *ddev = crtc->dev; struct drm_display_mode *mode = &crtc->state->adjusted_mode; struct videomode vm; + u32 bus_flags = 0; u32 hsync, vsync, accum_hbp, accum_vbp, accum_act_w, accum_act_h; u32 total_width, total_height; u32 val; int ret; + if (ldev->bridge && ldev->bridge->timings) + bus_flags = ldev->bridge->timings->input_bus_flags; + else if (ldev->connector) + bus_flags = ldev->connector->display_info.bus_flags; + if (!pm_runtime_active(ddev->dev)) { ret = pm_runtime_get_sync(ddev->dev); if (ret) { @@ -586,10 +592,10 @@ static void ltdc_crtc_mode_set_nofb(struct drm_crtc *crtc) if (vm.flags & DISPLAY_FLAGS_VSYNC_HIGH) val |= GCR_VSPOL; - if (vm.flags & DISPLAY_FLAGS_DE_LOW) + if (bus_flags & DRM_BUS_FLAG_DE_LOW) val |= GCR_DEPOL; - if (vm.flags & DISPLAY_FLAGS_PIXDATA_NEGEDGE) + if (bus_flags & DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE) val |= GCR_PCPOL; reg_update_bits(ldev->regs, LTDC_GCR, @@ -1098,6 +1104,8 @@ static const struct drm_encoder_helper_funcs ltdc_encoder_helper_funcs = { static int ltdc_encoder_init(struct drm_device *ddev, struct drm_bridge *bridge) { + struct ltdc_device *ldev = ddev->dev_private; + struct drm_connector_list_iter iter; struct drm_encoder *encoder; int ret; @@ -1119,6 +1127,16 @@ static int ltdc_encoder_init(struct drm_device *ddev, struct drm_bridge *bridge) return -EINVAL; } + ldev->bridge = bridge; + + /* + * Get hold of the connector. This is a bit of a hack, until the bridge + * API gives us bus flags and formats. + */ + drm_connector_list_iter_begin(ddev, &iter); + ldev->connector = drm_connector_list_iter_next(&iter); + drm_connector_list_iter_end(&iter); + DRM_DEBUG_DRIVER("Bridge encoder:%d created\n", encoder->base.id); return 0; diff --git a/drivers/gpu/drm/stm/ltdc.h b/drivers/gpu/drm/stm/ltdc.h index f153b908c70e..d0d2c81de29a 100644 --- a/drivers/gpu/drm/stm/ltdc.h +++ b/drivers/gpu/drm/stm/ltdc.h @@ -38,6 +38,8 @@ struct ltdc_device { u32 irq_status; struct fps_info plane_fpsi[LTDC_MAX_LAYER]; struct drm_atomic_state *suspend_state; + struct drm_bridge *bridge; + struct drm_connector *connector; }; int ltdc_load(struct drm_device *ddev); -- 2.29.2 [View Less]

2 1

[PATCH] drm/panel: feiyang-fy07024di26a30d: cleanup if panel attaching failed
by Icenowy Zheng 07 Jan '21

07 Jan '21

Attaching the panel can fail, so cleanup work is necessary, otherwise a pointer to freed struct drm_panel* will remain in drm_panel code. Do the cleanup if panel attaching failed. Fixes: 69dc678abc2b ("drm/panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel") Signed-off-by: Icenowy Zheng <icenowy(a)aosc.io> --- drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-feiyang-… [View More]

2 3

[PATCH v7 0/8] mainline Plymovent M2M and BAS board
by Oleksij Rempel 07 Jan '21

07 Jan '21

changes v7: - panel-simple.yaml: fix comments and part order - panel-simple.yaml: invent a product description for the Kyocera tcg070wvlq panel changes v6: - do more panel-simple.yaml related cleanups changes v5: - rebase against latest shawngup/for-next - add patch to fix checkpatch warning on PLYM2M dts changes v4: - add PLYBAS board - PLYM2M: add touchscreen node - PLYM2M: add rename led nodes to led-x changes v3: - use old style copyright text changes v2: - fsl.yaml: reorder ply,plym2m … [View More]

3 12

[Bug 210201] New: [amdpgu] crash when playing after suspend/resume
by bugzilla-daemon＠bugzilla.kernel.org 06 Jan '21

06 Jan '21

https://bugzilla.kernel.org/show_bug.cgi?id=210201 Bug ID: 210201 Summary: [amdpgu] crash when playing after suspend/resume Product: Drivers Version: 2.5 Kernel Version: 5.9.8, 5.6.19, 5.8.18 Hardware: x86-64 OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.… [View More]org Reporter: arturbac.ab(a)gmail.com Regression: No Created attachment 293669 --> https://bugzilla.kernel.org/attachment.cgi?id=293669&action=edit Full dmesg after video crash When i play vulkan games, like Kerbal Space Program, ReadDeadRedemption2(via Proton) after i return from suspend, after runing them after 30min - 1h graphics driver crashes. OS: Gentoo Kernel: x86_64 Linux 5.9.8 Resolution: 7680x2160 (2 monitors attached 4K free sync) DE: KDE 5.75.0 / Plasma 5.20.3 WM: KWin GTK Theme: Adwaita [GTK2/3] CPU: AMD Ryzen 9 3900X 12-Core @ 24x 3.8GHz GPU: AMD Radeon RX 5700 XT (NAVI10, DRM 3.39.0, 5.9.8, LLVM 10.0.1) Mesa 20.2.2 RAM: 32038MiB Full dmesg attached. [104307.850190] amdgpu 0000:0f:00.0: amdgpu: ring gfx_0.0.0 uses VM inv eng 0 on hub 0 [104307.850192] amdgpu 0000:0f:00.0: amdgpu: ring comp_1.0.0 uses VM inv eng 1 on hub 0 [104307.850194] amdgpu 0000:0f:00.0: amdgpu: ring comp_1.1.0 uses VM inv eng 4 on hub 0 [104307.850195] amdgpu 0000:0f:00.0: amdgpu: ring comp_1.2.0 uses VM inv eng 5 on hub 0 [104307.850196] amdgpu 0000:0f:00.0: amdgpu: ring comp_1.3.0 uses VM inv eng 6 on hub 0 [104307.850198] amdgpu 0000:0f:00.0: amdgpu: ring comp_1.0.1 uses VM inv eng 7 on hub 0 [104307.850199] amdgpu 0000:0f:00.0: amdgpu: ring comp_1.1.1 uses VM inv eng 8 on hub 0 [104307.850201] amdgpu 0000:0f:00.0: amdgpu: ring comp_1.2.1 uses VM inv eng 9 on hub 0 [104307.850202] amdgpu 0000:0f:00.0: amdgpu: ring comp_1.3.1 uses VM inv eng 10 on hub 0 [104307.850203] amdgpu 0000:0f:00.0: amdgpu: ring kiq_2.1.0 uses VM inv eng 11 on hub 0 [104307.850205] amdgpu 0000:0f:00.0: amdgpu: ring sdma0 uses VM inv eng 12 on hub 0 [104307.850206] amdgpu 0000:0f:00.0: amdgpu: ring sdma1 uses VM inv eng 13 on hub 0 [104307.850208] amdgpu 0000:0f:00.0: amdgpu: ring vcn_dec uses VM inv eng 0 on hub 1 [104307.850209] amdgpu 0000:0f:00.0: amdgpu: ring vcn_enc0 uses VM inv eng 1 on hub 1 [104307.850210] amdgpu 0000:0f:00.0: amdgpu: ring vcn_enc1 uses VM inv eng 4 on hub 1 [104307.850212] amdgpu 0000:0f:00.0: amdgpu: ring jpeg_dec uses VM inv eng 5 on hub 1 [104307.852128] [drm] recover vram bo from shadow start [104307.872340] [drm] recover vram bo from shadow done [104307.872342] [drm] Skip scheduling IBs! [104307.872343] [drm] Skip scheduling IBs! [104307.872357] [drm] Skip scheduling IBs! [104307.872362] amdgpu 0000:0f:00.0: amdgpu: GPU reset(2) succeeded! [104307.872373] [drm] Skip scheduling IBs! [repeated many times...] [104307.872440] [drm] Skip scheduling IBs! [104314.769174] [drm:amdgpu_gem_va_ioctl [amdgpu]] *ERROR* Couldn't update BO_VA (-16) [104314.795600] [drm:amdgpu_gem_va_ioctl [amdgpu]] *ERROR* Couldn't update BO_VA (-16) [104314.847946] amdgpu 0000:0f:00.0: amdgpu: failed to clear page tables on GEM object close (-16) [repeated many times...] [104315.300254] amdgpu 0000:0f:00.0: amdgpu: failed to clear page tables on GEM object close (-16) [104325.487235] GpuWatchdog[731778]: segfault at 0 ip 00007f9be2bf92dd sp 00007f9bd77ed670 error 6 in libcef.so[7f9bdee73000+69a4000] [104325.488266] Code: 00 79 09 48 8b 7d a0 e8 21 80 c1 02 41 8b 85 00 01 00 00 85 c0 0f 84 ab 00 00 00 49 8b 45 00 4c 89 ef be 01 00 00 00 ff 50 58 <c7> 04 25 00 00 00 00 37 13 00 00 c6 05 c1 a5 37 03 01 80 bd 7f ff [104335.590624] GpuWatchdog[731809]: segfault at 0 ip 00007f494f6142dd sp 00007f4944208670 error 6 in libcef.so[7f494b88e000+69a4000] [104335.590631] Code: 00 79 09 48 8b 7d a0 e8 21 80 c1 02 41 8b 85 00 01 00 00 85 c0 0f 84 ab 00 00 00 49 8b 45 00 4c 89 ef be 01 00 00 00 ff 50 58 <c7> 04 25 00 00 00 00 37 13 00 00 c6 05 c1 a5 37 03 01 80 bd 7f ff [104345.690401] GpuWatchdog[731833]: segfault at 0 ip 00007fcbb4c722dd sp 00007fcba9866670 error 6 in libcef.so[7fcbb0eec000+69a4000] [104345.692176] Code: 00 79 09 48 8b 7d a0 e8 21 80 c1 02 41 8b 85 00 01 00 00 85 c0 0f 84 ab 00 00 00 49 8b 45 00 4c 89 ef be 01 00 00 00 ff 50 58 <c7> 04 25 00 00 00 00 37 13 00 00 c6 05 c1 a5 37 03 01 80 bd 7f ff -- You are receiving this mail because: You are watching the assignee of the bug. [View Less]

1 2

← Newer
1
...
14
15
16
17
18
19
20
...
66
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel December 2020