dri-devel February 2020

dri-devel@lists.freedesktop.org

302 participants
679 discussions

[PATCH resend 0/1] drm: Add DRM_MODE_TYPE_USERDEF flag to probed modes
by Hans de Goede 17 May '20

17 May '20

Hi All, I'm resending this patch since the discussion on it has fallen silent for a while now. Last time I posted it, the discussion seemed to be heading towards agreement that this is the right thing to do, but I never got an ack or some such. See here for the discussion from last time: https://patchwork.freedesktop.org/patch/340140/ Regards, Hans

3 7

[Bug 206247] New: 5.4.x: WARNING: CPU: 1 PID: 561 at drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c:1464 dcn_bw_update_from_pplib+0xa5/0x2e0 [amdgpu]
by bugzilla-daemon＠bugzilla.kernel.org 17 May '20

17 May '20

https://bugzilla.kernel.org/show_bug.cgi?id=206247 Bug ID: 206247 Summary: 5.4.x: WARNING: CPU: 1 PID: 561 at drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_cal cs.c:1464 dcn_bw_update_from_pplib+0xa5/0x2e0 [amdgpu] Product: Drivers Version: 2.5 Kernel Version: 5.4.x Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: udovdh(a)xs4all.nl Regression: No [ 35.250541] ------------[ cut here ]------------ [ 35.278240] WARNING: CPU: 1 PID: 561 at drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c:1464 dcn_bw_update_from_pplib+0xa5/0x2e0 [amdgpu] [ 35.357964] Modules linked in: amdgpu(+) gpu_sched hid_generic aesni_intel ttm sr_mod cdrom usbhid i2c_dev autofs4 [ 35.419996] CPU: 1 PID: 561 Comm: systemd-udevd Not tainted 5.4.13 #13 [ 35.459106] Hardware name: Gigabyte Technology Co., Ltd. X570 AORUS PRO/X570 AORUS PRO, BIOS F11 12/06/2019 [ 35.517545] RIP: 0010:dcn_bw_update_from_pplib+0xa5/0x2e0 [amdgpu] [ 35.554572] Code: 0c 24 85 c9 74 24 8d 71 ff 48 8d 44 24 04 48 8d 54 f4 0c eb 0d 48 83 c0 08 48 39 d0 0f 84 2a 01 00 00 44 8b 00 45 85 c0 75 eb <0f> 0b e8 84 9e 93 e7 4c 89 e2 be 04 00 00 00 4c 89 ef e8 54 59 fe [ 35.667119] RSP: 0018:ffffa45ac04fb6c0 EFLAGS: 00010246 [ 35.698421] RAX: ffffa45ac04fb6c4 RBX: ffff9f808a330000 RCX: 0000000000000004 [ 35.741178] RDX: ffffa45ac04fb6e4 RSI: 0000000000000003 RDI: ffffffffa8deae51 [ 35.783937] RBP: ffffa45ac04fb800 R08: 0000000000000000 R09: 00000000000003c5 [ 35.826696] R10: 0000000000000002 R11: 00000000000000f0 R12: ffffa45ac04fb750 [ 35.869455] R13: ffff9f80865a8400 R14: 0000000000000001 R15: 000000000000000a [ 35.912212] FS: 00007f1f6579a940(0000) GS:ffff9f809ee40000(0000) knlGS:0000000000000000 [ 35.960700] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 35.995125] CR2: 000055fb7c7b9e98 CR3: 0000000409b72000 CR4: 00000000003406e0 [ 36.037884] Call Trace: [ 36.052577] dcn10_create_resource_pool+0x82d/0xb30 [amdgpu] [ 36.086480] ? __kmalloc+0xeb/0xf0 [ 36.106891] dc_create_resource_pool+0xbe/0x130 [amdgpu] [ 36.138767] dc_create+0x213/0x6b0 [amdgpu] [ 36.163871] amdgpu_dm_init+0x138/0x1c0 [amdgpu] [ 36.191574] ? phm_wait_for_register_unequal.part.0+0x4a/0x80 [amdgpu] [ 36.230741] dm_hw_init+0x9/0x20 [amdgpu] [ 36.254801] amdgpu_device_init.cold+0x119b/0x1344 [amdgpu] [ 36.288230] amdgpu_driver_load_kms+0x41/0xc0 [amdgpu] [ 36.319020] drm_dev_register+0x10c/0x150 [ 36.343071] amdgpu_pci_probe+0xcd/0x130 [amdgpu] [ 36.371257] ? pci_match_device+0xd2/0x100 [ 36.395787] pci_device_probe+0xc9/0x140 [ 36.419277] really_probe+0x142/0x3b0 [ 36.441204] device_driver_attach+0x4e/0x60 [ 36.466254] __driver_attach+0x85/0x140 [ 36.489221] ? device_driver_attach+0x60/0x60 [ 36.515314] bus_for_each_dev+0x73/0xb0 [ 36.538283] bus_add_driver+0x13f/0x1e0 [ 36.561249] driver_register+0x67/0xb0 [ 36.583694] ? 0xffffffffc0389000 [ 36.603540] do_one_initcall+0x47/0x16f [ 36.626507] ? ___cache_free+0x2c/0x1f0 [ 36.649475] do_init_module+0x51/0x200 [ 36.671921] load_module+0x24b6/0x26e0 [ 36.694370] ? vfs_read+0xee/0x120 [ 36.714733] ? __do_sys_finit_module+0xaa/0x110 [ 36.741866] __do_sys_finit_module+0xaa/0x110 [ 36.767960] do_syscall_64+0x63/0x410 [ 36.789886] entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 36.820144] RIP: 0033:0x7f1f667401ad [ 36.841551] Code: 00 c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d ab 5c 0c 00 f7 d8 64 89 01 48 [ 36.954097] RSP: 002b:00007fffc9e46388 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 [ 36.999461] RAX: ffffffffffffffda RBX: 000055fb7c7ef480 RCX: 00007f1f667401ad [ 37.042217] RDX: 0000000000000000 RSI: 000055fb7c7e2aa0 RDI: 000000000000000f [ 37.084976] RBP: 0000000000020000 R08: 0000000000000000 R09: 0000000000000007 [ 37.127736] R10: 000000000000000f R11: 0000000000000246 R12: 000055fb7c7e2aa0 [ 37.170493] R13: 0000000000000000 R14: 000055fb7c7e7c40 R15: 000055fb7c7ef480 [ 37.213251] ---[ end trace fdc62e5509be6ed6 ]--- This bootuip message has been shown for quite a while -- You are receiving this mail because: You are watching the assignee of the bug.

1 3

[PATCH v2 00/10] drivers, provide a way to add sysfs groups easily
by Greg Kroah-Hartman 14 May '20

14 May '20

This patch originally started out just as a way for platform drivers to easily add a sysfs group in a race-free way, but thanks to Dmitry's patch, this series now is for all drivers in the kernel (hey, a unified driver model works!!!) I've only converted a few platform drivers here in this series to show how it works, but other busses can be converted after the first patch goes into the tree. Here's the original 00 message, for people to get an idea of what is going on here: If a platform driver wants to add a sysfs group, it has to do so in a racy way, adding it after the driver is bound. To resolve this issue, have the platform driver core do this for the driver, making the individual drivers logic smaller and simpler, and solving the race at the same time. All of these patches depend on the first patch. I'll take the first one through my driver-core tree, and any subsystem maintainer can either ack their individul patch and I will be glad to also merge it, or they can wait until after 5.4-rc1 when the core patch hits Linus's tree and then take it, it's up to them. Thank to Richard Gong for the idea and the testing of the platform driver patch and to Dmitry Torokhov for rewriting the first patch to work well for all busses. ----- V2 - work for all busses and not just platform drivers. Dmitry Torokhov (1): driver core: add dev_groups to all drivers Greg Kroah-Hartman (9): uio: uio_fsl_elbc_gpcm: convert platform driver to use dev_groups input: keyboard: gpio_keys: convert platform driver to use dev_groups input: axp20x-pek: convert platform driver to use dev_groups firmware: arm_scpi: convert platform driver to use dev_groups olpc: x01: convert platform driver to use dev_groups platform: x86: hp-wmi: convert platform driver to use dev_groups video: fbdev: wm8505fb: convert platform driver to use dev_groups video: fbdev: w100fb: convert platform driver to use dev_groups video: fbdev: sm501fb: convert platform driver to use dev_groups arch/x86/platform/olpc/olpc-xo1-sci.c | 17 ++++------ drivers/base/dd.c | 14 ++++++++ drivers/firmware/arm_scpi.c | 5 +-- drivers/input/keyboard/gpio_keys.c | 13 ++------ drivers/input/misc/axp20x-pek.c | 15 ++------- drivers/platform/x86/hp-wmi.c | 47 +++++++-------------------- drivers/uio/uio_fsl_elbc_gpcm.c | 23 +++++-------- drivers/video/fbdev/sm501fb.c | 37 +++++---------------- drivers/video/fbdev/w100fb.c | 23 ++++++------- drivers/video/fbdev/wm8505fb.c | 13 ++++---- include/linux/device.h | 3 ++ 11 files changed, 76 insertions(+), 134 deletions(-) -- 2.22.0

4 13

[PATCH 1/4] drm/mst: Don't do atomic checks over disabled managers
by José Roberto de Souza 13 May '20

13 May '20

When a main MST port is disconnected drivers should call drm_dp_mst_topology_mgr_set_mst() disabling the MST manager, this function will set manager mst_primary to NULL and it will cause the crash bellow on the next atomic check when trying to access mst_primary->port. As there is no use in running checks over managers that are not active this patch will skip it. [ 305.616450] [drm:drm_dp_mst_atomic_check] [MST PORT:00000000cc2049e9] releases all VCPI slots [ 305.625085] [drm:drm_dp_mst_atomic_check] [MST PORT:00000000020ab43e] releases all VCPI slots [ 305.633729] [drm:drm_dp_mst_atomic_check] [MST MGR:00000000cdd467d4] mst state 00000000b67672eb VCPI avail=63 used=0 [ 305.644405] BUG: kernel NULL pointer dereference, address: 0000000000000030 [ 305.651448] #PF: supervisor read access in kernel mode [ 305.656640] #PF: error_code(0x0000) - not-present page [ 305.661807] PGD 0 P4D 0 [ 305.664396] Oops: 0000 [#1] PREEMPT SMP NOPTI [ 305.668789] CPU: 3 PID: 183 Comm: kworker/3:2 Not tainted 5.5.0-rc6+ #1404 [ 305.675703] Hardware name: Intel Corporation Ice Lake Client Platform/IceLake U DDR4 SODIMM PD RVP TLC, BIOS ICLSFWR1.R00.3201.A00.1905140358 05/14/2019 [ 305.689425] Workqueue: events drm_dp_delayed_destroy_work [ 305.694874] RIP: 0010:drm_dp_mst_atomic_check+0x138/0x2c0 [ 305.700306] Code: 00 00 00 41 29 d9 41 89 d8 4c 89 fa 4c 89 f1 48 c7 c6 b0 b1 34 82 bf 10 00 00 00 45 31 ed e8 3f 99 02 00 4d 8b bf 80 04 00 00 <49> 8b 47 30 49 8d 5f 30 4c 8d 60 e8 48 39 c3 74 35 49 8b 7c 24 28 [ 305.719169] RSP: 0018:ffffc90001687b58 EFLAGS: 00010246 [ 305.724434] RAX: 0000000000000000 RBX: 000000000000003f RCX: 0000000000000000 [ 305.731611] RDX: 0000000000000000 RSI: ffff88849fba8cb8 RDI: 00000000ffffffff [ 305.738785] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000001 [ 305.745962] R10: ffffc900016879a0 R11: ffffc900016879a5 R12: 0000000000000000 [ 305.753139] R13: 0000000000000000 R14: ffff8884905c9bc0 R15: 0000000000000000 [ 305.760315] FS: 0000000000000000(0000) GS:ffff88849fb80000(0000) knlGS:0000000000000000 [ 305.768452] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 305.774263] CR2: 0000000000000030 CR3: 0000000005610006 CR4: 0000000000760ee0 [ 305.781441] PKRU: 55555554 [ 305.784228] Call Trace: [ 305.786739] intel_atomic_check+0xb2e/0x2560 [i915] [ 305.791678] ? printk+0x53/0x6a [ 305.794856] ? drm_atomic_check_only+0x3e/0x810 [ 305.799417] ? __drm_dbg+0x82/0x90 [ 305.802848] drm_atomic_check_only+0x56a/0x810 [ 305.807322] drm_atomic_commit+0xe/0x50 [ 305.811185] drm_client_modeset_commit_atomic+0x1e2/0x250 [ 305.816619] drm_client_modeset_commit_force+0x4d/0x180 [ 305.821921] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0 [ 305.827963] drm_fb_helper_set_par+0x2b/0x40 [ 305.832265] drm_fb_helper_hotplug_event.part.0+0xb2/0xd0 [ 305.837755] drm_kms_helper_hotplug_event+0x21/0x30 [ 305.842694] process_one_work+0x25b/0x5b0 [ 305.846735] worker_thread+0x4b/0x3b0 [ 305.850439] kthread+0x100/0x140 [ 305.853690] ? process_one_work+0x5b0/0x5b0 [ 305.857901] ? kthread_park+0x80/0x80 [ 305.861588] ret_from_fork+0x24/0x50 [ 305.865202] Modules linked in: snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic i915 btusb btrtl btbcm btintel bluetooth prime_numbers snd_hda_intel snd_intel_dspcfg snd_hda_codec e1000e snd_hwdep snd_hda_core thunderbolt mei_hdcp mei_me asix cdc_ether x86_pkg_temp_thermal r8152 mei coretemp usbnet snd_pcm mii crct10dif_pclmul ptp crc32_pclmul ecdh_generic ghash_clmulni_intel pps_core ecc i2c_i801 intel_lpss_pci [ 305.903096] CR2: 0000000000000030 [ 305.906431] ---[ end trace 70ee364eed801cb0 ]--- [ 305.940816] RIP: 0010:drm_dp_mst_atomic_check+0x138/0x2c0 [ 305.946261] Code: 00 00 00 41 29 d9 41 89 d8 4c 89 fa 4c 89 f1 48 c7 c6 b0 b1 34 82 bf 10 00 00 00 45 31 ed e8 3f 99 02 00 4d 8b bf 80 04 00 00 <49> 8b 47 30 49 8d 5f 30 4c 8d 60 e8 48 39 c3 74 35 49 8b 7c 24 28 [ 305.965125] RSP: 0018:ffffc90001687b58 EFLAGS: 00010246 [ 305.970382] RAX: 0000000000000000 RBX: 000000000000003f RCX: 0000000000000000 [ 305.977571] RDX: 0000000000000000 RSI: ffff88849fba8cb8 RDI: 00000000ffffffff [ 305.984747] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000001 [ 305.991921] R10: ffffc900016879a0 R11: ffffc900016879a5 R12: 0000000000000000 [ 305.999099] R13: 0000000000000000 R14: ffff8884905c9bc0 R15: 0000000000000000 [ 306.006271] FS: 0000000000000000(0000) GS:ffff88849fb80000(0000) knlGS:0000000000000000 [ 306.014407] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 306.020185] CR2: 0000000000000030 CR3: 000000048b3aa003 CR4: 0000000000760ee0 [ 306.027404] PKRU: 55555554 [ 306.030127] BUG: sleeping function called from invalid context at include/linux/percpu-rwsem.h:38 [ 306.039049] in_atomic(): 0, irqs_disabled(): 1, non_block: 0, pid: 183, name: kworker/3:2 [ 306.047272] INFO: lockdep is turned off. [ 306.051217] irq event stamp: 77505 [ 306.054647] hardirqs last enabled at (77505): [<ffffffff81a0c147>] _raw_spin_unlock_irqrestore+0x47/0x60 [ 306.064270] hardirqs last disabled at (77504): [<ffffffff81a0bedf>] _raw_spin_lock_irqsave+0xf/0x50 [ 306.073404] softirqs last enabled at (77402): [<ffffffff81e00389>] __do_softirq+0x389/0x47f [ 306.081885] softirqs last disabled at (77395): [<ffffffff810b83a9>] irq_exit+0xa9/0xc0 [ 306.089859] CPU: 3 PID: 183 Comm: kworker/3:2 Tainted: G D 5.5.0-rc6+ #1404 [ 306.098167] Hardware name: Intel Corporation Ice Lake Client Platform/IceLake U DDR4 SODIMM PD RVP TLC, BIOS ICLSFWR1.R00.3201.A00.1905140358 05/14/2019 [ 306.111882] Workqueue: events drm_dp_delayed_destroy_work [ 306.117314] Call Trace: [ 306.119780] dump_stack+0x71/0xa0 [ 306.123135] ___might_sleep.cold+0xf7/0x10b [ 306.127399] exit_signals+0x2b/0x360 [ 306.131014] do_exit+0xa7/0xc70 [ 306.134189] ? kthread+0x100/0x140 [ 306.137615] rewind_stack_do_exit+0x17/0x20 Fixes: cd82d82cbc04 ("drm/dp_mst: Add branch bandwidth validation to MST atomic check") Cc: Mikita Lipski <mikita.lipski(a)amd.com> Cc: Alex Deucher <alexander.deucher(a)amd.com> Cc: Lyude Paul <lyude(a)redhat.com> Signed-off-by: José Roberto de Souza <jose.souza(a)intel.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 4b74193b89ce..38bf111e5f9b 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_dp_mst_topology.c @@ -5034,6 +5034,9 @@ int drm_dp_mst_atomic_check(struct drm_atomic_state *state) int i, ret = 0; for_each_new_mst_mgr_in_state(state, mgr, mst_state, i) { + if (!mgr->mst_state) + continue; + ret = drm_dp_mst_atomic_check_vcpi_alloc_limit(mgr, mst_state); if (ret) break; -- 2.25.0

8 18

[Bug 201505] New: Resume from suspend does not power up the display
by bugzilla-daemon＠bugzilla.kernel.org 11 May '20

11 May '20

https://bugzilla.kernel.org/show_bug.cgi?id=201505 Bug ID: 201505 Summary: Resume from suspend does not power up the display Product: Drivers Version: 2.5 Kernel Version: 4.19 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: 0xe2.0x9a.0x9b(a)gmail.com Regression: No Resuming the machine from suspend-to-ram no longer restores power to the display attached to an AMD GPU in Linux 4.19 (assuming the display has switched to sleep mode by itself because the computer hasn't been in use for a while). If the display is still powered on when resuming, it ends up blank. Linux 4.18 did not contain this bug. Kernel: 4.19 Module: amdgpu GPU: R9 390 -- You are receiving this mail because: You are watching the assignee of the bug.

1 6

[PATCH 1/3] drm/atomic: Take the atomic toys away from X
by Daniel Vetter 08 May '20

08 May '20

The -modesetting ddx has a totally broken idea of how atomic works: - doesn't disable old connectors, assuming they get auto-disable like with the legacy setcrtc - assumes ASYNC_FLIP is wired through for the atomic ioctl - not a single call to TEST_ONLY Iow the implementation is a 1:1 translation of legacy ioctls to atomic, which is a) broken b) pointless. We already have bugs in both i915 and amdgpu-DC where this prevents us from enabling neat features. If anyone ever cares about atomic in X we can easily add a new atomic level (req->value == 2) for X to get back the shiny toys. Since these broken versions of -modesetting have been shipping, there's really no other way to get out of this bind. References: https://gitlab.freedesktop.org/xorg/xserver/issues/629 References: https://gitlab.freedesktop.org/xorg/xserver/merge_requests/180 Cc: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> Cc: Michel Dänzer <michel(a)daenzer.net> Cc: Alex Deucher <alexdeucher(a)gmail.com> Cc: Adam Jackson <ajax(a)redhat.com> Cc: Sean Paul <sean(a)poorly.run> Cc: David Airlie <airlied(a)linux.ie> Cc: stable(a)vger.kernel.org Signed-off-by: Daniel Vetter <daniel.vetter(a)intel.com> --- drivers/gpu/drm/drm_ioctl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index 2c120c58f72d..1cb7b4c3c87c 100644 --- a/drivers/gpu/drm/drm_ioctl.c +++ b/drivers/gpu/drm/drm_ioctl.c @@ -334,6 +334,9 @@ drm_setclientcap(struct drm_device *dev, void *data, struct drm_file *file_priv) file_priv->universal_planes = req->value; break; case DRM_CLIENT_CAP_ATOMIC: + /* The modesetting DDX has a totally broken idea of atomic. */ + if (strstr(current->comm, "X")) + return -EOPNOTSUPP; if (!drm_core_check_feature(dev, DRIVER_ATOMIC)) return -EOPNOTSUPP; if (req->value > 1) -- 2.23.0

8 15

[v2] arm64: dts: sc7180: add dsi controller and phy entries for idp dts
by Harigovindan P 06 May '20

06 May '20

Adding dsi controller and phy entries for idp dt. Signed-off-by: Harigovindan P <harigovi(a)codeaurora.org> --- Changes in v1: - Added dsi controller and dsi phy entries for idp dts Changes in v2: - Adding dependency patchwork series - Removing suspend configuration - Adding blank before curly brace This patch depends on following patchwork series: https://patchwork.kernel.org/patch/11364687/ https://patchwork.kernel.org/patch/11366303/ arch/arm64/boot/dts/qcom/sc7180-idp.dts | 55 +++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts index 388f50ad4fde..6ccf8c3603ab 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts @@ -7,6 +7,7 @@ /dts-v1/; +#include <dt-bindings/gpio/gpio.h> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> #include "sc7180.dtsi" #include "pm6150.dtsi" @@ -232,6 +233,49 @@ vreg_bob: bob { }; }; +&dsi0 { + status = "okay"; + + vdda-supply = <&vreg_l3c_1p2>; + + panel@0 { + compatible = "visionox,rm69299-1080p-display"; + reg = <0>; + + vdda-supply = <&vreg_l8c_1p8>; + vdd3p3-supply = <&vreg_l18a_2p8>; + + pinctrl-names = "default"; + pinctrl-0 = <&disp_pins>; + + reset-gpios = <&pm6150l_gpio 3 GPIO_ACTIVE_HIGH>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + port@0 { + reg = <0>; + panel0_in: endpoint { + remote-endpoint = <&dsi0_out>; + }; + }; + }; + }; + + ports { + port@1 { + endpoint { + remote-endpoint = <&panel0_in>; + data-lanes = <0 1 2 3>; + }; + }; + }; +}; + +&dsi_phy { + status = "okay"; +}; + &qspi { status = "okay"; pinctrl-names = "default"; @@ -289,6 +333,17 @@ &usb_1_qmpphy { /* PINCTRL - additions to nodes defined in sc7180.dtsi */ +&pm6150l_gpio { + disp_pins: disp-pins { + pins = "gpio3"; + function = "func1"; + qcom,drive-strength = <2>; + power-source = <0>; + bias-disable; + output-low; + }; +}; + &qspi_clk { pinconf { pins = "gpio63"; -- 2.25.0

2 2

[PATCH v7 0/2] Add initial support for slimport anx7625
by Xin Ji 30 Apr '20

30 Apr '20

Hi all, The following series add initial support for the Slimport ANX7625 transmitter, a ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable device. This is the initial version, any mistakes, please let me know, I will fix it in the next series. Thanks, Xin Xin Ji (2): dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver .../bindings/display/bridge/anx7625.yaml | 91 + drivers/gpu/drm/bridge/Makefile | 2 +- drivers/gpu/drm/bridge/analogix/Kconfig | 6 + drivers/gpu/drm/bridge/analogix/Makefile | 1 + drivers/gpu/drm/bridge/analogix/anx7625.c | 2172 ++++++++++++++++++++ drivers/gpu/drm/bridge/analogix/anx7625.h | 410 ++++ 6 files changed, 2681 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.yaml create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.c create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.h -- 2.7.4

4 14

[PATCH v2] drm/panel: simple: Support reset GPIOs
by Miquel Raynal 29 Apr '20

29 Apr '20

The panel common bindings provide a gpios-reset property. Let's support it in the simple driver. Two fields are added to the panel description structure: the time to assert the reset and the time to wait right after before starting to interact with it in any manner. In case these default values are not filled but the GPIO is present in the DT, default values are applied. Signed-off-by: Miquel Raynal <miquel.raynal(a)bootlin.com> --- Changes since v1: * Add two parameters in the panel description structure. * Ensure the reset is asserted the right amount of time and the deasserted before continuing if a reset GPIO is given. drivers/gpu/drm/panel/panel-simple.c | 32 +++++++++++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 28fa6ba7b767..ac6f6b5d200d 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -38,6 +38,9 @@ #include <drm/drm_mipi_dsi.h> #include <drm/drm_panel.h> +#define MIN_DEFAULT_RESET_US 10 +#define MIN_DEFAULT_WAIT_US 10 + /** * @modes: Pointer to array of fixed modes appropriate for this panel. If * only one mode then this can just be the address of this the mode. @@ -94,6 +97,10 @@ struct panel_desc { u32 bus_format; u32 bus_flags; + + /* Minimum reset duration and wait period after it in us */ + u32 reset_time; + u32 reset_wait; }; struct panel_simple { @@ -109,6 +116,7 @@ struct panel_simple { struct i2c_adapter *ddc; struct gpio_desc *enable_gpio; + struct gpio_desc *reset_gpio; struct drm_display_mode override_mode; }; @@ -432,12 +440,34 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) if (IS_ERR(panel->supply)) return PTR_ERR(panel->supply); + panel->reset_gpio = devm_gpiod_get_optional(dev, "reset", + GPIOD_OUT_HIGH); + if (IS_ERR(panel->reset_gpio)) { + err = PTR_ERR(panel->reset_gpio); + if (err != -EPROBE_DEFER) + dev_err(dev, "failed to request reset pin: %d\n", err); + return err; + } else if (panel->reset_gpio) { + u32 reset_time = panel->desc->reset_time; + u32 reset_wait = panel->desc->reset_wait; + + if (!reset_time) + reset_time = MIN_DEFAULT_RESET_US; + + if (!reset_wait) + reset_wait = MIN_DEFAULT_WAIT_US; + + usleep_range(reset_time, 2 * reset_time); + gpiod_set_value_cansleep(panel->reset_gpio, 0); + usleep_range(reset_wait, 2 * reset_wait); + } + panel->enable_gpio = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW); if (IS_ERR(panel->enable_gpio)) { err = PTR_ERR(panel->enable_gpio); if (err != -EPROBE_DEFER) - dev_err(dev, "failed to request GPIO: %d\n", err); + dev_err(dev, "failed to request enable pin: %d\n", err); return err; } -- 2.20.1

3 3

[PATCH] backlight: lp855x: Ensure regulators are disabled on probe failure
by Jon Hunter 28 Apr '20

28 Apr '20

If probing the LP885x backlight fails after the regulators have been enabled, then the following warning is seen when releasing the regulators ... WARNING: CPU: 1 PID: 289 at drivers/regulator/core.c:2051 _regulator_put.part.28+0x158/0x160 Modules linked in: tegra_xudc lp855x_bl(+) host1x pwm_tegra ip_tables x_tables ipv6 nf_defrag_ipv6 CPU: 1 PID: 289 Comm: systemd-udevd Not tainted 5.6.0-rc2-next-20200224 #1 Hardware name: NVIDIA Jetson TX1 Developer Kit (DT) ... Call trace: _regulator_put.part.28+0x158/0x160 regulator_put+0x34/0x50 devm_regulator_release+0x10/0x18 release_nodes+0x12c/0x230 devres_release_all+0x34/0x50 really_probe+0x1c0/0x370 driver_probe_device+0x58/0x100 device_driver_attach+0x6c/0x78 __driver_attach+0xb0/0xf0 bus_for_each_dev+0x68/0xc8 driver_attach+0x20/0x28 bus_add_driver+0x160/0x1f0 driver_register+0x60/0x110 i2c_register_driver+0x40/0x80 lp855x_driver_init+0x20/0x1000 [lp855x_bl] do_one_initcall+0x58/0x1a0 do_init_module+0x54/0x1d0 load_module+0x1d80/0x21c8 __do_sys_finit_module+0xe8/0x100 __arm64_sys_finit_module+0x18/0x20 el0_svc_common.constprop.3+0xb0/0x168 do_el0_svc+0x20/0x98 el0_sync_handler+0xf4/0x1b0 el0_sync+0x140/0x180 Fix this by ensuring that the regulators are disabled, if enabled, on probe failure. Finally, ensure that the vddio regulator is disabled in the driver remove handler. Signed-off-by: Jon Hunter <jonathanh(a)nvidia.com> --- drivers/video/backlight/lp855x_bl.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c index f68920131a4a..e94932c69f54 100644 --- a/drivers/video/backlight/lp855x_bl.c +++ b/drivers/video/backlight/lp855x_bl.c @@ -456,7 +456,7 @@ static int lp855x_probe(struct i2c_client *cl, const struct i2c_device_id *id) ret = regulator_enable(lp->enable); if (ret < 0) { dev_err(lp->dev, "failed to enable vddio: %d\n", ret); - return ret; + goto disable_supply; } /* @@ -471,24 +471,34 @@ static int lp855x_probe(struct i2c_client *cl, const struct i2c_device_id *id) ret = lp855x_configure(lp); if (ret) { dev_err(lp->dev, "device config err: %d", ret); - return ret; + goto disable_vddio; } ret = lp855x_backlight_register(lp); if (ret) { dev_err(lp->dev, "failed to register backlight. err: %d\n", ret); - return ret; + goto disable_vddio; } ret = sysfs_create_group(&lp->dev->kobj, &lp855x_attr_group); if (ret) { dev_err(lp->dev, "failed to register sysfs. err: %d\n", ret); - return ret; + goto disable_vddio; } backlight_update_status(lp->bl); + return 0; + +disable_vddio: + if (lp->enable) + regulator_disable(lp->enable); +disable_supply: + if (lp->supply) + regulator_disable(lp->supply); + + return ret; } static int lp855x_remove(struct i2c_client *cl) @@ -497,6 +507,8 @@ static int lp855x_remove(struct i2c_client *cl) lp->bl->props.brightness = 0; backlight_update_status(lp->bl); + if (lp->enable) + regulator_disable(lp->enable); if (lp->supply) regulator_disable(lp->supply); sysfs_remove_group(&lp->dev->kobj, &lp855x_attr_group); -- 2.17.1

3 5

← Newer
1
...
7
8
9
10
11
12
13
...
68
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel February 2020