dri-devel June 2020

dri-devel@lists.freedesktop.org

315 participants
731 discussions

[PATCH AUTOSEL 5.7 014/388] backlight: lp855x: Ensure regulators are disabled on probe failure
by Sasha Levin 18 Jun '20

18 Jun '20

From: Jon Hunter <jonathanh(a)nvidia.com> [ Upstream commit d8207c155a7c6015eb7f43739baa7dfb1fa638af ] If probing the LP885x backlight fails after the regulators have been enabled, then the following warning is seen when releasing the regulators ... WARNING: CPU: 1 PID: 289 at drivers/regulator/core.c:2051 _regulator_put.part.28+0x158/0x160 Modules linked in: tegra_xudc lp855x_bl(+) host1x pwm_tegra ip_tables x_tables ipv6 nf_defrag_ipv6 CPU: 1 PID: 289 Comm: systemd-udevd Not tainted 5.6.0-rc2-next-20200224 #1 Hardware name: NVIDIA Jetson TX1 Developer Kit (DT) ... Call trace: _regulator_put.part.28+0x158/0x160 regulator_put+0x34/0x50 devm_regulator_release+0x10/0x18 release_nodes+0x12c/0x230 devres_release_all+0x34/0x50 really_probe+0x1c0/0x370 driver_probe_device+0x58/0x100 device_driver_attach+0x6c/0x78 __driver_attach+0xb0/0xf0 bus_for_each_dev+0x68/0xc8 driver_attach+0x20/0x28 bus_add_driver+0x160/0x1f0 driver_register+0x60/0x110 i2c_register_driver+0x40/0x80 lp855x_driver_init+0x20/0x1000 [lp855x_bl] do_one_initcall+0x58/0x1a0 do_init_module+0x54/0x1d0 load_module+0x1d80/0x21c8 __do_sys_finit_module+0xe8/0x100 __arm64_sys_finit_module+0x18/0x20 el0_svc_common.constprop.3+0xb0/0x168 do_el0_svc+0x20/0x98 el0_sync_handler+0xf4/0x1b0 el0_sync+0x140/0x180 Fix this by ensuring that the regulators are disabled, if enabled, on probe failure. Finally, ensure that the vddio regulator is disabled in the driver remove handler. Signed-off-by: Jon Hunter <jonathanh(a)nvidia.com> Reviewed-by: Daniel Thompson <daniel.thompson(a)linaro.org> Signed-off-by: Lee Jones <lee.jones(a)linaro.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/video/backlight/lp855x_bl.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c index f68920131a4a..e94932c69f54 100644 --- a/drivers/video/backlight/lp855x_bl.c +++ b/drivers/video/backlight/lp855x_bl.c @@ -456,7 +456,7 @@ static int lp855x_probe(struct i2c_client *cl, const struct i2c_device_id *id) ret = regulator_enable(lp->enable); if (ret < 0) { dev_err(lp->dev, "failed to enable vddio: %d\n", ret); - return ret; + goto disable_supply; } /* @@ -471,24 +471,34 @@ static int lp855x_probe(struct i2c_client *cl, const struct i2c_device_id *id) ret = lp855x_configure(lp); if (ret) { dev_err(lp->dev, "device config err: %d", ret); - return ret; + goto disable_vddio; } ret = lp855x_backlight_register(lp); if (ret) { dev_err(lp->dev, "failed to register backlight. err: %d\n", ret); - return ret; + goto disable_vddio; } ret = sysfs_create_group(&lp->dev->kobj, &lp855x_attr_group); if (ret) { dev_err(lp->dev, "failed to register sysfs. err: %d\n", ret); - return ret; + goto disable_vddio; } backlight_update_status(lp->bl); + return 0; + +disable_vddio: + if (lp->enable) + regulator_disable(lp->enable); +disable_supply: + if (lp->supply) + regulator_disable(lp->supply); + + return ret; } static int lp855x_remove(struct i2c_client *cl) @@ -497,6 +507,8 @@ static int lp855x_remove(struct i2c_client *cl) lp->bl->props.brightness = 0; backlight_update_status(lp->bl); + if (lp->enable) + regulator_disable(lp->enable); if (lp->supply) regulator_disable(lp->supply); sysfs_remove_group(&lp->dev->kobj, &lp855x_attr_group); -- 2.25.1

1 0

[radeon-alex:drm-next 319/414] drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1817:28: sparse: sparse: cast to restricted __le32
by kernel test robot 18 Jun '20

18 Jun '20

tree: git://people.freedesktop.org/~agd5f/linux.git drm-next head: f59073f6df9b07d94917221486cf5929efa6b315 commit: a5cc9a9321cb7c32ed9d8f6f82e82376bcc04f81 [319/414] drm/amd/powerplay: update powerplay table for sienna_cichlid config: i386-randconfig-s001-20200617 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-rc1-6-g78f577f8-dirty git checkout a5cc9a9321cb7c32ed9d8f6f82e82376bcc04f81 # save the attached .config to linux build tree make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> sparse warnings: (new ones prefixed by >>) drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1367:52: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] MinClock @@ got restricted __le16 [usertype] @@ drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1367:52: sparse: expected unsigned short [usertype] MinClock drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1367:52: sparse: got restricted __le16 [usertype] drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1371:52: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] MaxClock @@ got restricted __le16 [usertype] @@ drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1371:52: sparse: expected unsigned short [usertype] MaxClock drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1371:52: sparse: got restricted __le16 [usertype] drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1375:51: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] MinUclk @@ got restricted __le16 [usertype] @@ drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1375:51: sparse: expected unsigned short [usertype] MinUclk drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1375:51: sparse: got restricted __le16 [usertype] drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1379:51: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] MaxUclk @@ got restricted __le16 [usertype] @@ drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1379:51: sparse: expected unsigned short [usertype] MaxUclk drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1379:51: sparse: got restricted __le16 [usertype] drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1388:52: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] MinClock @@ got restricted __le16 [usertype] @@ drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1388:52: sparse: expected unsigned short [usertype] MinClock drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1388:52: sparse: got restricted __le16 [usertype] drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1392:52: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] MaxClock @@ got restricted __le16 [usertype] @@ drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1392:52: sparse: expected unsigned short [usertype] MaxClock drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1392:52: sparse: got restricted __le16 [usertype] drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1396:51: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] MinUclk @@ got restricted __le16 [usertype] @@ drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1396:51: sparse: expected unsigned short [usertype] MinUclk drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1396:51: sparse: got restricted __le16 [usertype] drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1400:51: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] MaxUclk @@ got restricted __le16 [usertype] @@ drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1400:51: sparse: expected unsigned short [usertype] MaxUclk drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1400:51: sparse: got restricted __le16 [usertype] drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1726:5: sparse: sparse: symbol 'sienna_cichlid_get_dpm_ultimate_freq' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1742:5: sparse: sparse: symbol 'sienna_cichlid_set_soft_freq_limited_range' was not declared. Should it be static? >> drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1817:28: sparse: sparse: cast to restricted __le32 vim +1817 drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c 1800 1801 static uint32_t sienna_cichlid_get_max_power_limit(struct smu_context *smu) { 1802 uint32_t od_limit, max_power_limit; 1803 struct smu_11_0_7_powerplay_table *powerplay_table = NULL; 1804 struct smu_table_context *table_context = &smu->smu_table; 1805 powerplay_table = table_context->power_play_table; 1806 1807 max_power_limit = smu_get_pptable_power_limit(smu); 1808 1809 if (!max_power_limit) { 1810 // If we couldn't get the table limit, fall back on first-read value 1811 if (!smu->default_power_limit) 1812 smu->default_power_limit = smu->power_limit; 1813 max_power_limit = smu->default_power_limit; 1814 } 1815 1816 if (smu->od_enabled) { > 1817 od_limit = le32_to_cpu(powerplay_table->overdrive_table.max[SMU_11_0_7_ODSETTING_POWERPERCENTAGE]); 1818 1819 pr_debug("ODSETTING_POWERPERCENTAGE: %d (default: %d)\n", od_limit, smu->default_power_limit); 1820 1821 max_power_limit *= (100 + od_limit); 1822 max_power_limit /= 100; 1823 } 1824 1825 return max_power_limit; 1826 } 1827 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 0

[PATCH v3 0/3] 180 degrees rotation support for NVIDIA Tegra DRM
by Dmitry Osipenko 17 Jun '20

17 Jun '20

Hello! This series adds 180° display plane rotation support to the NVIDIA Tegra DRM driver which is needed for devices that have display panel physically mounted upside-down, like Nexus 7 tablet device for example [1]. Since DRM panel rotation is a new thing for a userspace, currently only Opentegra Xorg driver [2] and a recent Weston [3] have support for the rotated display panels, but this is more than good enough for the starter. [1] https://patchwork.ozlabs.org/project/linux-tegra/patch/20200607154327.18589… [2] https://github.com/grate-driver/xf86-video-opentegra/commit/28eb20a3959bbe5… [3] https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/315 Changelog: v3: - Factored out the panel patches into standalone series [4] because this series doesn't have hard dependency on the panel patches and it should be nicer to review and apply the properly grouped patches. - The DRM_MODE_ROTATE_180 now isn't passed to drm_rotation_simplify(), like it was suggested by Ville Syrjälä in the comment to v2. - Added clarifying comment for the tegra_fb_is_bottom_up() in the code. [4] https://lore.kernel.org/lkml/20200617231842.30671-1-digetx@gmail.com/T/#t Dmitry Osipenko (3): drm/tegra: plane: Rename bottom_up to reflect_y drm/tegra: plane: Support horizontal reflection drm/tegra: plane: Support 180° rotation drivers/gpu/drm/tegra/dc.c | 46 ++++++++++++++++++++++++++++------- drivers/gpu/drm/tegra/dc.h | 3 ++- drivers/gpu/drm/tegra/plane.c | 3 ++- drivers/gpu/drm/tegra/plane.h | 3 ++- 4 files changed, 43 insertions(+), 12 deletions(-) -- 2.26.0

1 3

[PATCH v3 0/5] dt-bindings: display: ti,tfp410.txt: convert to yaml
by Ricardo Cañuelo 17 Jun '20

17 Jun '20

This series converts the DT binding for the TI TFP410 DPI-to-DVI encoder to json-schema. This also fixes a minor bug in the ti-tfp410 driver that would cause a wrong calculation of the setup and hold times when the de-skew feature is enabled. The retrieval of the de-skew value from the DT has also been updated to reflect the binding changes. Changes in v3: - ti,tfp410.yaml - Original translation to yaml separated into its own commit with no additional changes (Laurent Pinchart). - Redefinition of ti,deskew property in its own commit (Laurent). - Removal of unnecessary text (Laurent). - New conditional constraint for ti,deskew (Laurent). - "ports" node set as optional (Rob Herring). - dove-sbc-a510.dts: removed. This comes from Rob's suggestion that the "ports" node should be optional instead of defining empty port nodes in DTs files. - ti-tfp410.c - Original changes split into two commits. The first one changes the datatype and retrieval of the deskew property. The second one fixes the calculation of hold and setup times (Laurent). The bindings have been tested with: make dt_binding_check ARCH=<arch> DT_SCHEMA_FILES=<...ti,tfp410.yaml> make dtbs_check ARCH=<arch> DT_SCHEMA_FILES=<...ti,tfp410.yaml> for <arch> = arm and arm64. This uncovered a number of dts files that use the TFP410 but not through I2C and don't define the ti,deskew property. These should be fixed at some point. Ricardo Cañuelo (5): dt-bindings: display: ti,tfp410.txt: convert to yaml dt-bindings: display: ti,tfp410.yaml: Redefine ti,deskew property drm/bridge: tfp410: fix de-skew value retrieval from DT drm/bridge: tfp410: Fix setup and hold time calculation dt-bindings: display: ti,tfp410.yaml: make the ports node optional .../bindings/display/bridge/ti,tfp410.txt | 66 --------- .../bindings/display/bridge/ti,tfp410.yaml | 130 ++++++++++++++++++ drivers/gpu/drm/bridge/ti-tfp410.c | 10 +- 3 files changed, 135 insertions(+), 71 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/bridge/ti,tfp410.txt create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml -- 2.18.0

3 12

[pull] amdgpu, amdkfd drm-fixes-5.8
by Alex Deucher 17 Jun '20

17 Jun '20

Hi Dave, Daniel, Fixes for 5.8. The following changes since commit 8d286e2ff4400d313955b4203fc640ca6fd9228b: Merge tag 'drm-intel-next-fixes-2020-06-04' of git://anongit.freedesktop.org/drm/drm-intel into drm-next (2020-06-08 11:59:57 +1000) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux tags/amd-drm-fixes-5.8-2020-06-17 for you to fetch changes up to da9cebe16930f0273278fe893f2809450c61ae41: drm/amdgpu: fix documentation around busy_percentage (2020-06-17 17:42:43 -0400) ---------------------------------------------------------------- amd-drm-fixes-5.8-2020-06-17: amdgpu: - Fix kvfree/kfree mixup - Fix hawaii device id in powertune configuration - Display FP fixes - Documentation fixes amdkfd: - devcgroup check fix ---------------------------------------------------------------- Alex Deucher (2): drm/amdgpu/pm: update comment to clarify Overdrive interfaces drm/amdgpu: fix documentation around busy_percentage Denis Efremov (2): drm/amd/display: Use kvfree() to free coeff in build_regamma() drm/amd/display: Use kfree() to free rgb_user in calculate_user_regamma_ramp() Lorenz Brun (1): drm/amdkfd: Use correct major in devcgroup check Rodrigo Siqueira (1): drm/amd/display: Rework dsc to isolate FPU operations Sandeep Raghuraman (1): drm/amdgpu: Replace invalid device ID with a valid device ID Documentation/gpu/amdgpu.rst | 9 +- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 4 +- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 3 +- drivers/gpu/drm/amd/display/dc/dsc/Makefile | 2 - drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 18 +-- drivers/gpu/drm/amd/display/dc/dsc/rc_calc.c | 151 ++++++++++++++++++++- drivers/gpu/drm/amd/display/dc/dsc/rc_calc.h | 5 +- drivers/gpu/drm/amd/display/dc/dsc/rc_calc_dpi.c | 27 +--- .../drm/amd/display/modules/color/color_gamma.c | 4 +- drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c | 2 +- 10 files changed, 166 insertions(+), 59 deletions(-)

1 0

[PATCH][next] drm/i915/query: Use struct_size() helper
by Gustavo A. R. Silva 17 Jun '20

17 Jun '20

Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. This code was detected with the help of Coccinelle and, audited and fixed manually. Signed-off-by: Gustavo A. R. Silva <gustavoars(a)kernel.org> --- drivers/gpu/drm/i915/i915_query.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_query.c b/drivers/gpu/drm/i915/i915_query.c index e75c528ebbe0..c1ebda9b5627 100644 --- a/drivers/gpu/drm/i915/i915_query.c +++ b/drivers/gpu/drm/i915/i915_query.c @@ -109,8 +109,7 @@ query_engine_info(struct drm_i915_private *i915, for_each_uabi_engine(engine, i915) num_uabi_engines++; - len = sizeof(struct drm_i915_query_engine_info) + - num_uabi_engines * sizeof(struct drm_i915_engine_info); + len = struct_size(query_ptr, engines, num_uabi_engines); ret = copy_query_item(&query, sizeof(query), len, query_item); if (ret != 0) -- 2.27.0

1 0

[PATCH] gpu: ipu-v3: image-convert: Wait for channels before disabling
by Steve Longerbeam 17 Jun '20

17 Jun '20

Call ipu_idmac_wait_busy() on each idmac channel to busy wait for the channel to be idle before disabling. Otherwise it was found that a conversion would stall after the completion of a tile and the start of the next tile. Fixes: 0537db801bb01 ("gpu: ipu-v3: image-convert: reconfigure IC per tile") Signed-off-by: Steve Longerbeam <slongerbeam(a)gmail.com> --- drivers/gpu/ipu-v3/ipu-image-convert.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-image-convert.c b/drivers/gpu/ipu-v3/ipu-image-convert.c index eeca50d9a1ee..f0938015d2fd 100644 --- a/drivers/gpu/ipu-v3/ipu-image-convert.c +++ b/drivers/gpu/ipu-v3/ipu-image-convert.c @@ -1251,6 +1251,19 @@ static int get_run_count(struct ipu_image_convert_ctx *ctx, return count; } +static void stop_channel(struct ipu_image_convert_chan *chan, + struct ipuv3_channel *channel) +{ + struct ipu_image_convert_priv *priv = chan->priv; + int ret; + + ret = ipu_idmac_wait_busy(channel, 1); + if (ret == -ETIMEDOUT) + dev_warn(priv->ipu->dev, "IDMAC timeout\n"); + + ipu_idmac_disable_channel(channel); +} + static void convert_stop(struct ipu_image_convert_run *run) { struct ipu_image_convert_ctx *ctx = run->ctx; @@ -1262,12 +1275,12 @@ static void convert_stop(struct ipu_image_convert_run *run) /* disable IC tasks and the channels */ ipu_ic_task_disable(chan->ic); - ipu_idmac_disable_channel(chan->in_chan); - ipu_idmac_disable_channel(chan->out_chan); + stop_channel(chan, chan->in_chan); + stop_channel(chan, chan->out_chan); if (ipu_rot_mode_is_irt(ctx->rot_mode)) { - ipu_idmac_disable_channel(chan->rotation_in_chan); - ipu_idmac_disable_channel(chan->rotation_out_chan); + stop_channel(chan, chan->rotation_in_chan); + stop_channel(chan, chan->rotation_out_chan); ipu_idmac_unlink(chan->out_chan, chan->rotation_in_chan); } -- 2.17.1

1 1

[PATCH v6 0/5] iommu/arm-smmu: Split pagetable support for arm-smmu-v2
by Jordan Crouse 17 Jun '20

17 Jun '20

This is another iteration for the split pagetable support based on the suggestions from Robin and Will [1]. Background: In order to support per-context pagetables the GPU needs to enable split tables so that we can store global buffers in the TTBR1 space leaving the GPU free to program the TTBR0 register with the address of a context specific pagetable. If the DOMAIN_ATTR_SPLIT_TABLES attribute is set on the domain before attaching, the context bank assigned to the domain will be programmed to allow translations in the TTBR1 space. Translations in the TTBR0 region will be disallowed because, as Robin pointe out, having a un-programmed TTBR0 register is dangerous. The driver can determine if TTBR1 was successfully programmed by querying DOMAIN_ATTR_SPLIT_TABLES after attaching. The domain geometry will also be updated to reflect the virtual address space for the TTBR1 range. Upcoming changes will allow auxiliary domains to be attached to the device which will enable and program TTBR0. This patchset is based on top of linux-next-20200409 Change log: v6: Cleanups for the arm-smmu TTBR1 patch from Will Deacon v4: Only program TTBR1 when split pagetables are requested. TTBR0 will be enabled later when an auxiliary domain is attached v3: Remove the implementation specific and make split pagetable support part of the generic configuration [1] https://lists.linuxfoundation.org/pipermail/iommu/2020-January/041373.html Jordan Crouse (5): iommu: Add DOMAIN_ATTR_SPLIT_TABLES iommu/arm-smmu: Add support for TTBR1 drm/msm: Attach the IOMMU device during initialization drm/msm: Refactor address space initialization drm/msm/a6xx: Support split pagetables drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 16 ++++++++ drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 1 + drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 1 + drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 1 + drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 51 ++++++++++++++++++++++++ drivers/gpu/drm/msm/adreno/adreno_gpu.c | 23 ++++++++--- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 8 ++++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 +++------ drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 18 ++++----- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 4 -- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 18 ++++----- drivers/gpu/drm/msm/msm_drv.h | 8 +--- drivers/gpu/drm/msm/msm_gem_vma.c | 36 +++-------------- drivers/gpu/drm/msm/msm_gpu.c | 49 +---------------------- drivers/gpu/drm/msm/msm_gpu.h | 4 +- drivers/gpu/drm/msm/msm_gpummu.c | 6 --- drivers/gpu/drm/msm/msm_iommu.c | 18 +++++---- drivers/gpu/drm/msm/msm_mmu.h | 1 - drivers/iommu/arm-smmu.c | 48 ++++++++++++++++++---- drivers/iommu/arm-smmu.h | 24 ++++++++--- include/linux/iommu.h | 2 + 21 files changed, 200 insertions(+), 155 deletions(-) -- 2.17.1

2 5

[PATCH v3 000/105] drm/vc4: Support BCM2711 Display Pipeline
by Maxime Ripard 17 Jun '20

17 Jun '20

Hi everyone, Here's a (pretty long) series to introduce support in the VC4 DRM driver for the display pipeline found in the BCM2711 (and thus the RaspberryPi 4). The main differences are that there's two HDMI controllers and that there's more pixelvalve now. Those pixelvalve come with a mux in the HVS that still have only 3 FIFOs. Both of those differences are breaking a bunch of expectations in the driver, so we first need a good bunch of cleanup and reworks to introduce support for the new controllers. Similarly, the HDMI controller has all its registers shuffled and split in multiple controllers now, so we need a bunch of changes to support this as well. Only the HDMI support is enabled for now (even though the DPI output has been tested too). This is based on the firmware clocks series sent separately: https://lore.kernel.org/lkml/cover.662a8d401787ef33780d91252a352de91dc4be10… Let me know if you have any comments Maxime Cc: bcm-kernel-feedback-list(a)broadcom.com Cc: devicetree(a)vger.kernel.org Cc: Kamal Dasu <kdasu.kdev(a)gmail.com> Cc: linux-clk(a)vger.kernel.org Cc: Michael Turquette <mturquette(a)baylibre.com> Cc: Philipp Zabel <p.zabel(a)pengutronix.de> Cc: Rob Herring <robh+dt(a)kernel.org> Cc: Stephen Boyd <sboyd(a)kernel.org> Changes from v2: - Rebased on top of next-20200526 - Split the firmware clock series away - Removed the stuck pixel (with all the subsequent pixels being shifted by one - Fixed the writeback issue too. - Fix the dual output - Fixed the return value of phy_get_cp_current - Enhanced the comment on the reset delay - Increase the max width and height - Made a proper Kconfig option for the DVP clock driver - Fixed the alsa card name collision Changes from v1: - Rebased on top of 5.7-rc1 - Run checkpatch - Added audio support - Fixed some HDMI timeouts - Swiched to clk_hw_register_gate_parent_data - Reorder Kconfig symbols in drivers/i2c/busses - Make the firmware clocks a child of the firmware node - Switch DVP clock driver to clk_hw interface - constify raspberrypi_clk_data in raspberrypi_clock_property - Don't mark firmware clocks as IGNORE_UNUSED - Change from reset_ms to reset_us in reset-simple, and add a bit more comments - Remove generic clk patch to test if a NULL pointer is returned - Removed misleading message in the is_prepared renaming patch commit message - Constify HDMI controller variants - Fix a bug in the allocation size of the clk data array - Added a mention in the DT binding conversion patches about the breakage - Merged a few fixes from kbuild - Fixed a few bisection and CEC build issues - Collected Acked-by and Reviewed-by - Change Dave email address to raspberrypi.com Dave Stevenson (6): drm/vc4: Add support for the BCM2711 HVS5 drm/vc4: plane: Improve LBM usage drm/vc4: hdmi: Use reg-names to retrieve the HDMI audio registers drm/vc4: hdmi: Reset audio infoframe on encoder_enable if previously streaming drm/vc4: hdmi: Set the b-frame marker to the match ALSA's default. drm/vc4: hdmi: Add audio-related callbacks Maxime Ripard (99): reset: Move reset-simple header out of drivers/reset reset: simple: Add reset callback dt-bindings: clock: Add BCM2711 DVP binding clk: bcm: Add BCM2711 DVP driver ARM: dts: bcm2711: Add HDMI DVP dt-bindings: display: Convert VC4 bindings to schemas dt-bindings: display: vc4: dpi: Add missing clock-names property dt-bindings: display: vc4: dsi: Add missing clock properties dt-bindings: display: vc4: hdmi: Add missing clock-names property dt-bindings: display: vc4: Document BCM2711 VC5 drm/vc4: drv: Add include guards drm/vc4: drv: Support BCM2711 dt-bindings: display: Add support for the BCM2711 HVS drm/vc4: hvs: Boost the core clock during modeset drm/vc4: plane: Move planes creation to its own function drm/vc4: plane: Move additional planes creation to driver drm/vc4: plane: Register all the planes at once drm/vc4: plane: Create overlays for any CRTC drm/vc4: plane: Create more planes drm/vc4: crtc: Rename SoC data structures drm/vc4: crtc: Switch to of_device_get_match_data drm/vc4: crtc: Move crtc state to common header drm/vc4: crtc: Deal with different number of pixel per clock drm/vc4: crtc: Use a shared interrupt drm/vc4: crtc: Turn static const variable into a define drm/vc4: crtc: Restrict HACT_ACT setup to DSI drm/vc4: crtc: Move the cob allocation outside of bind drm/vc4: crtc: Rename HVS channel to output drm/vc4: crtc: Use local chan variable drm/vc4: crtc: Enable and disable the PV in atomic_enable / disable drm/vc4: crtc: Assign output to channel automatically drm/vc4: crtc: Add FIFO depth to vc4_crtc_data drm/vc4: crtc: Add function to compute FIFO level bits drm/vc4: crtc: Rename HDMI encoder type to HDMI0 drm/vc4: crtc: Add HDMI1 encoder type drm/vc4: crtc: Remove redundant call to drm_crtc_enable_color_mgmt drm/vc4: crtc: Disable color management for HVS5 drm/vc4: crtc: Turn pixelvalve reset into a function drm/vc4: crtc: Move HVS mode config to HVS file drm/vc4: crtc: Move PV dump to config_pv drm/vc4: crtc: Move HVS init and close to a function drm/vc4: crtc: Move the HVS gamma LUT setup to our init function drm/vc4: hvs: Make sure our channel is reset drm/vc4: hvs: Remove mode_set_nofb drm/vc4: crtc: Remove mode_set_nofb drm/vc4: crtc: Remove redundant pixelvalve reset drm/vc4: crtc: Move HVS channel init before the PV initialisation drm/vc4: encoder: Add finer-grained encoder callbacks drm/vc4: crtc: Add a delay after disabling the PixelValve output drm/vc4: crtc: Clear the PixelValve FIFO on disable drm/vc4: crtc: Clear the PixelValve FIFO during configuration drm/vc4: hvs: Make the stop_channel function public drm/vc4: hvs: Introduce a function to get the assigned FIFO drm/vc4: crtc: Move the CRTC disable out drm/vc4: drv: Disable the CRTC at boot time dt-bindings: display: vc4: pv: Add BCM2711 pixel valves drm/vc4: crtc: Add BCM2711 pixelvalves drm/vc4: crtc: Make state functions public drm/vc4: crtc: Split CRTC data in two drm/vc4: crtc: Only access the PixelValve registers if we have to drm/vc4: crtc: Move the CRTC initialisation to a separate function drm/vc4: crtc: Change the HVS5 test for of_device_is_compatible drm/vc4: crtc: Move the txp_armed function to the TXP drm/vc4: txp: Turn the TXP into a CRTC of its own drm/vc4: crtc: Remove the feed_txp tests drm/vc4: hdmi: Use debugfs private field drm/vc4: hdmi: Move structure to header drm/vc4: hdmi: rework connectors and encoders drm/vc4: hdmi: Remove DDC argument to connector_init drm/vc4: hdmi: Rename hdmi to vc4_hdmi drm/vc4: hdmi: Move accessors to vc4_hdmi drm/vc4: hdmi: Use local vc4_hdmi directly drm/vc4: hdmi: Add container_of macros for encoders and connectors drm/vc4: hdmi: Pass vc4_hdmi to CEC code drm/vc4: hdmi: Remove vc4_dev hdmi pointer drm/vc4: hdmi: Remove vc4_hdmi_connector drm/vc4: hdmi: Introduce resource init and variant drm/vc4: hdmi: Implement a register layout abstraction drm/vc4: hdmi: Add reset callback drm/vc4: hdmi: Add PHY init and disable function drm/vc4: hdmi: Add PHY RNG enable / disable function drm/vc4: hdmi: Add a CSC setup callback drm/vc4: hdmi: Store the encoder type in the variant structure drm/vc4: hdmi: Deal with multiple debugfs files drm/vc4: hdmi: Move CEC init to its own function drm/vc4: hdmi: Add CEC support flag drm/vc4: hdmi: Remove unused CEC_CLOCK_DIV define drm/vc4: hdmi: Rename drm_encoder pointer in mode_valid drm/vc4: hdmi: Adjust HSM clock rate depending on pixel rate drm/vc4: hdmi: Use clk_set_min_rate instead drm/vc4: hdmi: Deal with multiple ALSA cards drm/vc4: hdmi: Remove register dumps in enable drm/vc4: hdmi: Always recenter the HDMI FIFO drm/vc4: hdmi: Implement finer-grained hooks drm/vc4: hdmi: Do the VID_CTL configuration at once drm/vc4: hdmi: Switch to blank pixels when disabled drm/vc4: hdmi: Support the BCM2711 HDMI controllers dt-bindings: display: vc4: hdmi: Add BCM2711 HDMI controllers bindings ARM: dts: bcm2711: Enable the display pipeline Documentation/devicetree/bindings/clock/brcm,bcm2711-dvp.yaml | 47 ++- Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt | 174 +-------- Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml | 109 +++++- Documentation/devicetree/bindings/display/brcm,bcm2835-dpi.yaml | 72 +++- Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml | 84 ++++- Documentation/devicetree/bindings/display/brcm,bcm2835-hdmi.yaml | 80 ++++- Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml | 53 ++- Documentation/devicetree/bindings/display/brcm,bcm2835-pixelvalve0.yaml | 45 ++- Documentation/devicetree/bindings/display/brcm,bcm2835-txp.yaml | 37 ++- Documentation/devicetree/bindings/display/brcm,bcm2835-v3d.yaml | 42 ++- Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml | 35 ++- Documentation/devicetree/bindings/display/brcm,bcm2835-vec.yaml | 44 ++- MAINTAINERS | 2 +- arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 46 ++- arch/arm/boot/dts/bcm2711.dtsi | 130 +++++- drivers/clk/bcm/Kconfig | 11 +- drivers/clk/bcm/Makefile | 1 +- drivers/clk/bcm/clk-bcm2711-dvp.c | 127 ++++++- drivers/gpu/drm/vc4/Makefile | 1 +- drivers/gpu/drm/vc4/vc4_crtc.c | 776 ++++++++++++++--------------------- drivers/gpu/drm/vc4/vc4_drv.c | 9 +- drivers/gpu/drm/vc4/vc4_drv.h | 105 ++++- drivers/gpu/drm/vc4/vc4_hdmi.c | 1610 ++++++++++++++++++++++++++++++++++++++++++------------------------------ drivers/gpu/drm/vc4/vc4_hdmi.h | 183 ++++++++- drivers/gpu/drm/vc4/vc4_hdmi_phy.c | 520 +++++++++++++++++++++++- drivers/gpu/drm/vc4/vc4_hdmi_regs.h | 451 ++++++++++++++++++++- drivers/gpu/drm/vc4/vc4_hvs.c | 362 +++++++++++++++- drivers/gpu/drm/vc4/vc4_kms.c | 191 ++++++++- drivers/gpu/drm/vc4/vc4_plane.c | 271 +++++++++--- drivers/gpu/drm/vc4/vc4_regs.h | 176 +++----- drivers/gpu/drm/vc4/vc4_txp.c | 109 ++++- drivers/reset/reset-simple.c | 23 +- drivers/reset/reset-simple.h | 41 +-- drivers/reset/reset-socfpga.c | 3 +- drivers/reset/reset-sunxi.c | 3 +- drivers/reset/reset-uniphier-glue.c | 3 +- include/linux/reset/reset-simple.h | 48 ++- 37 files changed, 4510 insertions(+), 1514 deletions(-) create mode 100644 Documentation/devicetree/bindings/clock/brcm,bcm2711-dvp.yaml delete mode 100644 Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2835-dpi.yaml create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2835-hdmi.yaml create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2835-pixelvalve0.yaml create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2835-txp.yaml create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2835-v3d.yaml create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2835-vec.yaml create mode 100644 drivers/clk/bcm/clk-bcm2711-dvp.c create mode 100644 drivers/gpu/drm/vc4/vc4_hdmi.h create mode 100644 drivers/gpu/drm/vc4/vc4_hdmi_phy.c create mode 100644 drivers/gpu/drm/vc4/vc4_hdmi_regs.h delete mode 100644 drivers/reset/reset-simple.h create mode 100644 include/linux/reset/reset-simple.h base-commit: ec9e6942c9f16390e530c2aea2a565f95fe6e929 -- git-series 0.9.1

9 150

[radeon-alex:drm-next 317/414] drivers/gpu/drm/amd/amdgpu/../powerplay/arcturus_ppt.c:2480:28: sparse: sparse: cast to restricted __le32
by kernel test robot 17 Jun '20

17 Jun '20

tree: git://people.freedesktop.org/~agd5f/linux.git drm-next head: f59073f6df9b07d94917221486cf5929efa6b315 commit: 00e86cf4bb21d5904053da0c2327dbcfa21f22ca [317/414] drm/amd/powerplay: move powerplay table operation out of smu_v11_0.c config: i386-randconfig-s001-20200617 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-rc1-6-g78f577f8-dirty git checkout 00e86cf4bb21d5904053da0c2327dbcfa21f22ca # save the attached .config to linux build tree make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> sparse warnings: (new ones prefixed by >>) >> drivers/gpu/drm/amd/amdgpu/../powerplay/arcturus_ppt.c:2480:28: sparse: sparse: cast to restricted __le32 -- drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1495:52: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] MinClock @@ got restricted __le16 [usertype] @@ drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1495:52: sparse: expected unsigned short [usertype] MinClock drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1495:52: sparse: got restricted __le16 [usertype] drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1499:52: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] MaxClock @@ got restricted __le16 [usertype] @@ drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1499:52: sparse: expected unsigned short [usertype] MaxClock drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1499:52: sparse: got restricted __le16 [usertype] drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1503:51: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] MinUclk @@ got restricted __le16 [usertype] @@ drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1503:51: sparse: expected unsigned short [usertype] MinUclk drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1503:51: sparse: got restricted __le16 [usertype] drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1507:51: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] MaxUclk @@ got restricted __le16 [usertype] @@ drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1507:51: sparse: expected unsigned short [usertype] MaxUclk drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1507:51: sparse: got restricted __le16 [usertype] drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1516:52: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] MinClock @@ got restricted __le16 [usertype] @@ drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1516:52: sparse: expected unsigned short [usertype] MinClock drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1516:52: sparse: got restricted __le16 [usertype] drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1520:52: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] MaxClock @@ got restricted __le16 [usertype] @@ drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1520:52: sparse: expected unsigned short [usertype] MaxClock drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1520:52: sparse: got restricted __le16 [usertype] drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1524:51: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] MinUclk @@ got restricted __le16 [usertype] @@ drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1524:51: sparse: expected unsigned short [usertype] MinUclk drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1524:51: sparse: got restricted __le16 [usertype] drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1528:51: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] MaxUclk @@ got restricted __le16 [usertype] @@ drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1528:51: sparse: expected unsigned short [usertype] MaxUclk drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1528:51: sparse: got restricted __le16 [usertype] >> drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:2323:28: sparse: sparse: cast to restricted __le32 vim +2480 drivers/gpu/drm/amd/amdgpu/../powerplay/arcturus_ppt.c 2463 2464 static uint32_t atcturus_get_max_power_limit(struct smu_context *smu) { 2465 uint32_t od_limit, max_power_limit; 2466 struct smu_11_0_powerplay_table *powerplay_table = NULL; 2467 struct smu_table_context *table_context = &smu->smu_table; 2468 powerplay_table = table_context->power_play_table; 2469 2470 max_power_limit = smu_get_pptable_power_limit(smu); 2471 2472 if (!max_power_limit) { 2473 // If we couldn't get the table limit, fall back on first-read value 2474 if (!smu->default_power_limit) 2475 smu->default_power_limit = smu->power_limit; 2476 max_power_limit = smu->default_power_limit; 2477 } 2478 2479 if (smu->od_enabled) { > 2480 od_limit = le32_to_cpu(powerplay_table->overdrive_table.max[SMU_11_0_ODSETTING_POWERPERCENTAGE]); 2481 2482 pr_debug("ODSETTING_POWERPERCENTAGE: %d (default: %d)\n", od_limit, smu->default_power_limit); 2483 2484 max_power_limit *= (100 + od_limit); 2485 max_power_limit /= 100; 2486 } 2487 2488 return max_power_limit; 2489 } 2490 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 0

← Newer
1
...
43
44
45
46
47
48
49
...
74
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel June 2020