dri-devel January 2021

dri-devel@lists.freedesktop.org

322 participants
737 discussions

[RFC] drm/connector: Set the default callback function for drm_connector_funcs
by Tian Tao 08 Jan '21

08 Jan '21

The member functions of drm_connector_funcs are not specific to each manufacturer's driver, so drm_connector_funcs is allowed to use default values, which prevents all drivers from setting the same member functions for drm_connector_funcs. Signed-off-by: Tian Tao <tiantao6(a)hisilicon.com> --- drivers/gpu/drm/drm_connector.c | 7 ++++++- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 1 - include/drm/drm_connector.h | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index 98b6ec4..356d8a3 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -25,6 +25,7 @@ #include <drm/drm_encoder.h> #include <drm/drm_utils.h> #include <drm/drm_print.h> +#include <drm/drm_probe_helper.h> #include <drm/drm_drv.h> #include <drm/drm_file.h> #include <drm/drm_sysfs.h> @@ -216,7 +217,7 @@ void drm_connector_free_work_fn(struct work_struct *work) */ int drm_connector_init(struct drm_device *dev, struct drm_connector *connector, - const struct drm_connector_funcs *funcs, + struct drm_connector_funcs *funcs, int connector_type) { struct drm_mode_config *config = &dev->mode_config; @@ -228,6 +229,10 @@ int drm_connector_init(struct drm_device *dev, (!funcs->atomic_destroy_state || !funcs->atomic_duplicate_state)); + if (!funcs->fill_modes) + funcs->fill_modes = &drm_helper_probe_single_connector_modes; + + ret = __drm_mode_object_add(dev, &connector->base, DRM_MODE_OBJECT_CONNECTOR, false, drm_connector_free); diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c index c76f996..7d3b662 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c @@ -64,7 +64,6 @@ static const struct drm_connector_helper_funcs }; static const struct drm_connector_funcs hibmc_connector_funcs = { - .fill_modes = drm_helper_probe_single_connector_modes, .destroy = hibmc_connector_destroy, .reset = drm_atomic_helper_connector_reset, .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index 1922b27..4810583 100644 --- a/include/drm/drm_connector.h +++ b/include/drm/drm_connector.h @@ -1561,7 +1561,7 @@ struct drm_connector { int drm_connector_init(struct drm_device *dev, struct drm_connector *connector, - const struct drm_connector_funcs *funcs, + struct drm_connector_funcs *funcs, int connector_type); int drm_connector_init_with_ddc(struct drm_device *dev, struct drm_connector *connector, -- 2.7.4

4 3

Re: linux-next: Tree for Jan 7 (drivers/gpu/drm/imx/parallel-display.o)
by Randy Dunlap 08 Jan '21

08 Jan '21

On 1/6/21 7:01 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20210106: > on x86_64: ld: drivers/gpu/drm/imx/parallel-display.o: in function `imx_pd_connector_get_modes': parallel-display.c:(.text+0x8d): undefined reference to `of_get_drm_display_mode' Full randconfig file is attached. -- ~Randy Reported-by: Randy Dunlap <rdunlap(a)infradead.org>

3 2

[PULL] drm-misc-fixes
by Thomas Zimmermann 08 Jan '21

08 Jan '21

Hi Dave and Daniel, sorry for being a bit late. Here's this week's PR for drm-misc-fixes. Best regards Thomas drm-misc-fixes-2021-01-08: * dma-buf: fix a use-after-free * radeon: don't init the TTM page pool manually * ttm: unexport ttm_pool_{init,fini}() The following changes since commit e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62: Linux 5.11-rc2 (2021-01-03 15:55:30 -0800) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-fixes-2021-01-08 for you to fetch changes up to a73858ef4d5e1d425e171f0f6a52864176a6a979: drm/ttm: unexport ttm_pool_init/fini (2021-01-07 14:25:43 +0100) ---------------------------------------------------------------- * dma-buf: fix a use-after-free * radeon: don't init the TTM page pool manually * ttm: unexport ttm_pool_{init,fini}() ---------------------------------------------------------------- Charan Teja Reddy (1): dmabuf: fix use-after-free of dmabuf's file->f_inode Christian König (2): drm/radeon: stop re-init the TTM page pool drm/ttm: unexport ttm_pool_init/fini drivers/dma-buf/dma-buf.c | 21 +++++++++++++++++---- drivers/gpu/drm/radeon/radeon_ttm.c | 3 --- drivers/gpu/drm/ttm/ttm_pool.c | 2 -- 3 files changed, 17 insertions(+), 9 deletions(-) -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer

2 1

[PATCH v2 -next] video: fbdev: pxa3xx_gcu: convert comma to semicolon
by Zheng Yongjun 08 Jan '21

08 Jan '21

Replace a comma between expression statements by a semicolon. Signed-off-by: Zheng Yongjun <zhengyongjun3(a)huawei.com> --- drivers/video/fbdev/pxa3xx-gcu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c index 4279e13a3b58..1d26be9d1f2d 100644 --- a/drivers/video/fbdev/pxa3xx-gcu.c +++ b/drivers/video/fbdev/pxa3xx-gcu.c @@ -594,8 +594,8 @@ static int pxa3xx_gcu_probe(struct platform_device *pdev) * container_of(). This isn't really necessary as we have a fixed minor * number anyway, but this is to avoid statics. */ - priv->misc_dev.minor = PXA3XX_GCU_MINOR, - priv->misc_dev.name = DRV_NAME, + priv->misc_dev.minor = PXA3XX_GCU_MINOR; + priv->misc_dev.name = DRV_NAME; priv->misc_dev.fops = &pxa3xx_gcu_miscdev_fops; /* handle IO resources */ -- 2.22.0

1 0

[pull] drm/msm: drm-msm-fixes-2021-01-07
by Rob Clark 08 Jan '21

08 Jan '21

Hi Dave, A few misc fixes The following changes since commit e319a1b956f785f618611857cd946dca2bb68542: drm/msm: add IOMMU_SUPPORT dependency (2020-12-05 08:25:52 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/drm/msm.git drm-msm-fixes-2021-01-07 for you to fetch changes up to 00fd44a1a4700718d5d962432b55c09820f7e709: drm/msm: Only enable A6xx LLCC code on A6xx (2021-01-07 09:23:05 -0800) ---------------------------------------------------------------- Craig Tatlor (1): drm/msm: Call msm_init_vram before binding the gpu Iskren Chernev (3): drm/msm: Fix null dereference in _msm_gem_new drm/msm: Ensure get_pages is called when locked drm/msm: Add modparam to allow vram carveout Konrad Dybcio (1): drm/msm: Only enable A6xx LLCC code on A6xx Kuogee Hsieh (1): drm/msm/dp: postpone irq_hpd event during connection pending state Rob Clark (1): drm/msm: Fix WARN_ON() splat in _free_object() drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 6 ++++-- drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 6 ++++-- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 6 ++++-- drivers/gpu/drm/msm/adreno/adreno_device.c | 4 ++++ drivers/gpu/drm/msm/adreno/adreno_gpu.c | 21 ++++++++++++--------- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 6 ++++++ drivers/gpu/drm/msm/dp/dp_display.c | 7 +++++++ drivers/gpu/drm/msm/dp/dp_panel.c | 12 +++++++++--- drivers/gpu/drm/msm/msm_drv.c | 8 ++++---- drivers/gpu/drm/msm/msm_gem.c | 13 +++++++++---- 10 files changed, 63 insertions(+), 26 deletions(-)

2 1

[PATCH] dt-bindings: bcm2835-vec: Add power-domains property
by Stefan Wahren 08 Jan '21

08 Jan '21

Adding the missing property power-domains to the bcm2835-vec schema to fix the following dtbs_check issue: vec@7e806000: 'power-domains' does not match any of the regexes: ... Signed-off-by: Stefan Wahren <stefan.wahren(a)i2se.com> --- Documentation/devicetree/bindings/display/brcm,bcm2835-vec.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2835-vec.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2835-vec.yaml index d900cc5..071a43d 100644 --- a/Documentation/devicetree/bindings/display/brcm,bcm2835-vec.yaml +++ b/Documentation/devicetree/bindings/display/brcm,bcm2835-vec.yaml @@ -22,6 +22,9 @@ properties: interrupts: maxItems: 1 + power-domains: + maxItems: 1 + required: - compatible - reg -- 2.7.4

4 4

Re: [PATCH 2/4] PCI: Add pci_rebar_bytes_to_size()
by Bjorn Helgaas 08 Jan '21

08 Jan '21

On Thu, Jan 07, 2021 at 11:31:36PM +0000, Darren Salt wrote: > I demand that Bjorn Helgaas may or may not have written... ? > >> +static inline int pci_rebar_bytes_to_size(u64 bytes) > >> +{ > >> + bytes = roundup_pow_of_two(bytes); > >> + return max(ilog2(bytes), 20) - 20; > > > This isn't returning a "size", is it? It looks like it's returning the > > log2 of the number of MB the BAR will be, i.e., the encoding used by the > > Resizable BAR Control register "BAR Size" field. Needs a brief comment to > > that effect and/or a different function name. > > Given that, it seems to me that pci_rebar_size_to_bytes should be similarly > commented and/or renamed. Makes sense. Something like this is sufficient: return 1ULL << (size + 20); /* Convert PCI_REBAR_CTRL "BAR Size" */

1 0

[PATCH v6 0/4] drm/panfrost: Add support for mt8183 GPU
by Nicolas Boichat 07 Jan '21

07 Jan '21

Hi! Follow-up on the v5 [1], things have gotten significantly better in the last 9 months, thanks to the efforts on Bifrost support by the Collabora team (and probably others I'm not aware of). I've been testing this series on a MT8183/kukui device, with a chromeos-5.10 kernel [2], and got basic Chromium OS UI up with mesa 20.3.2 (lots of artifacts though). devfreq is currently not supported, as we'll need: - Clock core support for switching the GPU core clock (see 2/4). - Platform-specific handling of the 2-regulator (see 3/4). Since the latter is easy to detect, patch 3/4 just disables devfreq if the more than one regulator is specified in the compatible matching table. [1] https://patchwork.kernel.org/project/linux-mediatek/cover/20200306041345.25… [2] https://crrev.com/c/2608070 Changes in v6: - Rebased, actually tested with recent mesa driver. Nicolas Boichat (4): dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 arm64: dts: mt8183: Add node for the Mali GPU drm/panfrost: devfreq: Disable devfreq when num_supplies > 1 drm/panfrost: Add mt8183-mali compatible string .../bindings/gpu/arm,mali-bifrost.yaml | 25 +++++ arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 6 + .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 6 + arch/arm64/boot/dts/mediatek/mt8183.dtsi | 105 ++++++++++++++++++ drivers/gpu/drm/panfrost/panfrost_devfreq.c | 9 ++ drivers/gpu/drm/panfrost/panfrost_drv.c | 10 ++ 6 files changed, 161 insertions(+) -- 2.29.2.729.g45daf8777d-goog

3 8

[PATCH] drm/mediatek: dsi: Fix EoTp flag
by Jitao Shi 07 Jan '21

07 Jan '21

SoC will transmit the EoTp (End of Transmission packet) when MIPI_DSI_MODE_EOT_PACKET flag is set. Enabling EoTp will make the line time larger, so the hfp and hbp should be reduced to keep line time. Signed-off-by: Jitao Shi <jitao.shi(a)mediatek.com> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index 65fd99c528af..8c70ec39bfe1 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -401,8 +401,11 @@ static void mtk_dsi_rxtx_control(struct mtk_dsi *dsi) break; } - tmp_reg |= (dsi->mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) << 6; - tmp_reg |= (dsi->mode_flags & MIPI_DSI_MODE_EOT_PACKET) >> 3; + if (dsi->mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) + tmp_reg |= HSTX_CKLP_EN; + + if (!(dsi->mode_flags & MIPI_DSI_MODE_EOT_PACKET)) + tmp_reg |= DIS_EOT; writel(tmp_reg, dsi->regs + DSI_TXRX_CTRL); } @@ -478,6 +481,7 @@ static void mtk_dsi_config_vdo_timing(struct mtk_dsi *dsi) timing->da_hs_zero + timing->da_hs_exit + 3; delta = dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST ? 18 : 12; + delta += dsi->mode_flags & MIPI_DSI_MODE_EOT_PACKET ? 2 : 0; horizontal_frontporch_byte = vm->hfront_porch * dsi_tmp_buf_bpp; horizontal_front_back_byte = horizontal_frontporch_byte + horizontal_backporch_byte; -- 2.25.1

2 1

[Patch] fbcon: i want fbcon soft scrollback feature come back
by xuhuijie 07 Jan '21

07 Jan '21

This commit 50145474f6ef(fbcon: remove soft scrollback code) remove soft scrollback in fbcon. So the shift+PageDown and shift+PageUp is missing. But PageUp is a vary important feature when system panic or reset. I can get log by PageUp before, but now there is no way to get. Especially on the server system, we always use bmc to control computer. So I hope the community can add this feature back.

3 2

← Newer
1
...
61
62
63
64
65
66
67
...
74
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2021