dri-devel January 2021

dri-devel@lists.freedesktop.org

322 participants
737 discussions

[PATCH] drm: Check actual format for legacy pageflip.
by Bas Nieuwenhuizen 07 Jan '21

07 Jan '21

With modifiers one can actually have different format_info structs for the same format, which now matters for AMDGPU since we convert implicit modifiers to explicit modifiers with multiple planes. I checked other drivers and it doesn't look like they end up triggering this case so I think this is safe to relax. Signed-off-by: Bas Nieuwenhuizen <bas(a)basnieuwenhuizen.nl> Fixes: 816853f9dc40 ("drm/amd/display: Set new format info for converted metadata.") --- drivers/gpu/drm/drm_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index e6231947f987..f5085990cfac 100644 --- a/drivers/gpu/drm/drm_plane.c +++ b/drivers/gpu/drm/drm_plane.c @@ -1163,7 +1163,7 @@ int drm_mode_page_flip_ioctl(struct drm_device *dev, if (ret) goto out; - if (old_fb->format != fb->format) { + if (old_fb->format->format != fb->format->format) { DRM_DEBUG_KMS("Page flip is not allowed to change frame buffer format.\n"); ret = -EINVAL; goto out; -- 2.29.2

7 14

[PATCH 1/3] dma-buf: system_heap: Make sure to return an error if we abort
by John Stultz 07 Jan '21

07 Jan '21

If we abort from the allocation due to a fatal_signal_pending(), be sure we report an error so any return code paths don't trip over the fact that the allocation didn't succeed. Cc: Sumit Semwal <sumit.semwal(a)linaro.org> Cc: Liam Mark <lmark(a)codeaurora.org> Cc: Laura Abbott <labbott(a)kernel.org> Cc: Brian Starkey <Brian.Starkey(a)arm.com> Cc: Hridya Valsaraju <hridya(a)google.com> Cc: Suren Baghdasaryan <surenb(a)google.com> Cc: Sandeep Patil <sspatil(a)google.com> Cc: Daniel Mentz <danielmentz(a)google.com> Cc: Chris Goldsworthy <cgoldswo(a)codeaurora.org> Cc: Ørjan Eide <orjan.eide(a)arm.com> Cc: Robin Murphy <robin.murphy(a)arm.com> Cc: Ezequiel Garcia <ezequiel(a)collabora.com> Cc: Simon Ser <contact(a)emersion.fr> Cc: James Jones <jajones(a)nvidia.com> Cc: linux-media(a)vger.kernel.org Cc: dri-devel(a)lists.freedesktop.org Suggested-by: Suren Baghdasaryan <surenb(a)google.com> Signed-off-by: John Stultz <john.stultz(a)linaro.org> --- drivers/dma-buf/heaps/system_heap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma-buf/heaps/system_heap.c b/drivers/dma-buf/heaps/system_heap.c index 17e0e9a68baf..405351aad2a8 100644 --- a/drivers/dma-buf/heaps/system_heap.c +++ b/drivers/dma-buf/heaps/system_heap.c @@ -363,8 +363,10 @@ static int system_heap_allocate(struct dma_heap *heap, * Avoid trying to allocate memory if the process * has been killed by SIGKILL */ - if (fatal_signal_pending(current)) + if (fatal_signal_pending(current)) { + ret = -EINTR; goto free_buffer; + } page = alloc_largest_available(size_remaining, max_order); if (!page) -- 2.17.1

1 2

[PATCH 0/4] A PCI quirk for resizable BAR 0 on Navi10
by Nirmoy Das 07 Jan '21

07 Jan '21

Hi Bjorn, I cleaned up the patch series[1] that Christian sent earlier to fix wrongly exported resizable bar capability dword by VBIOS of RX 5600 XT Pulse card. I didn't split #2 patch instead merged amdgpu changes of #2 patch to #3 patch and removed changes related to pci_rebar_size_to_bytes() as it isn't needed anymore. Apart from that I clean up rest of the patches as you suggested. Please let me know if I missed something. Regards, Nirmoy [1] https://www.spinics.net/lists/linux-pci/msg103422.html -- 2.29.2

3 8

[PATCH] drm/mipi-dbi: Switch to new kerneldoc syntax for named variable macro argument
by Jonathan Neuschäfer 07 Jan '21

07 Jan '21

The syntax without dots is available since commit 43756e347f21 ("scripts/kernel-doc: Add support for named variable macro arguments"). The same HTML output is produced with and without this patch. Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- include/drm/drm_mipi_dbi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_mipi_dbi.h b/include/drm/drm_mipi_dbi.h index c2827ceaba0d2..f543d6e3e822c 100644 --- a/include/drm/drm_mipi_dbi.h +++ b/include/drm/drm_mipi_dbi.h @@ -172,7 +172,7 @@ int mipi_dbi_buf_copy(void *dst, struct drm_framebuffer *fb, * mipi_dbi_command - MIPI DCS command with optional parameter(s) * @dbi: MIPI DBI structure * @cmd: Command - * @seq...: Optional parameter(s) + * @seq: Optional parameter(s) * * Send MIPI DCS command to the controller. Use mipi_dbi_command_read() for * get/read. -- 2.29.2

2 1

[PATCH v2] drm/amdgpu: Do not change amdgpu framebuffer format during page flip
by Zhan Liu 07 Jan '21

07 Jan '21

[Why] Driver cannot change amdgpu framebuffer (afb) format while doing page flip. Force system doing so will cause ioctl error, and result in breaking several functionalities including FreeSync. If afb format is forced to change during page flip, following message will appear in dmesg.log: "[drm:drm_mode_page_flip_ioctl [drm]] Page flip is not allowed to change frame buffer format." [How] Do not change afb format while doing page flip. It is okay to check whether afb format is valid here, however, forcing afb format change shouldn't happen here. Signed-off-by: Zhan Liu <zhan.liu(a)amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Thanks Nick and Bas. Here is my second patch for review. diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c index a638709e9c92..8a12e27ff4ec 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c @@ -832,7 +832,8 @@ static int convert_tiling_flags_to_modifier(struct amdgpu_framebuffer *afb) if (!format_info) return -EINVAL; - afb->base.format = format_info; + if (!afb->base.format) + afb->base.format = format_info; } } -- 2.25.1

5 4

[PATCH] drm/qxl: Use managed mode-config init
by Tian Tao 07 Jan '21

07 Jan '21

Using drmm_mode_config_init() sets up managed release of modesetting resources. Signed-off-by: Tian Tao <tiantao6(a)hisilicon.com> --- drivers/gpu/drm/qxl/qxl_display.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c index 012bce0..38d6b59 100644 --- a/drivers/gpu/drm/qxl/qxl_display.c +++ b/drivers/gpu/drm/qxl/qxl_display.c @@ -1195,7 +1195,9 @@ int qxl_modeset_init(struct qxl_device *qdev) int i; int ret; - drm_mode_config_init(&qdev->ddev); + ret = drmm_mode_config_init(&qdev->ddev); + if (ret) + return ret; ret = qxl_create_monitors_object(qdev); if (ret) @@ -1228,5 +1230,4 @@ int qxl_modeset_init(struct qxl_device *qdev) void qxl_modeset_fini(struct qxl_device *qdev) { qxl_destroy_monitors_object(qdev); - drm_mode_config_cleanup(&qdev->ddev); } -- 2.7.4

2 1

[PATCH] drm/pci: Use pcim_enable_device()
by Tian Tao 07 Jan '21

07 Jan '21

Using the managed function simplifies the error handling. After unloading the driver, the PCI device should now get disabled as well. Signed-off-by: Tian Tao <tiantao6(a)hisilicon.com> --- drivers/gpu/drm/drm_pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c index 6dba4b8..0616172 100644 --- a/drivers/gpu/drm/drm_pci.c +++ b/drivers/gpu/drm/drm_pci.c @@ -207,7 +207,7 @@ static int drm_get_pci_dev(struct pci_dev *pdev, if (IS_ERR(dev)) return PTR_ERR(dev); - ret = pci_enable_device(pdev); + ret = pcim_enable_device(pdev); if (ret) goto err_free; @@ -234,7 +234,6 @@ static int drm_get_pci_dev(struct pci_dev *pdev, err_agp: drm_pci_agp_destroy(dev); - pci_disable_device(pdev); err_free: drm_dev_put(dev); return ret; -- 2.7.4

2 1

[GIT PULL FOR v5.12] R-Car DU and misc other changes
by Laurent Pinchart 07 Jan '21

07 Jan '21

Hi Dave and Daniel, The following changes since commit 5b2fc08c455bbf749489254a81baeffdf4c0a693: Merge tag 'amd-drm-fixes-5.11-2020-12-23' of git://people.freedesktop.org/~agd5f/linux into drm-next (2020-12-24 10:31:16 +1000) are available in the Git repository at: git://linuxtv.org/pinchartl/media.git tags/du-next-20210105 for you to fetch changes up to 3fc5a284213d5fca1c0807ea8725355d39808930: drm: bridge: adv7511: Remove redundant null check before clk_disable_unprepare (2021-01-05 07:20:42 +0200) ---------------------------------------------------------------- - Add default modes for connectors in unknown state - R-Car DU conversion to DRM-managed API - R-Car DU miscellaneous fixes - Miscellaneous bridge and bridge bindings fixes - Assorted misc driver cleanups - Constify drm_driver for PCI devices ---------------------------------------------------------------- Fabrizio Castro (1): dt-bindings: display: bridge: renesas,lvds: RZ/G2E needs renesas,companion too Laurent Pinchart (20): dt-bindings: display: bridge: thc63lvd1024: Document dual-output mode drm: Add default modes for connectors in unknown state drm: rcar-du: Fix crash when using LVDS1 clock for CRTC drm: rcar-du: Release vsp device reference in all error paths drm: rcar-du: Drop unneeded encoder cleanup in error path drm: rcar-du: Use DRM-managed allocation for VSP planes drm: rcar-du: Use DRM-managed allocation for encoders drm: rcar-du: Embed drm_device in rcar_du_device drm: rcar-du: Replace dev_private with container_of drm: rcar-du: Skip encoder allocation for LVDS1 in dual-link mode drm: rcar-du: Drop local encoder variable drm: rcar-du: Fix leak of CMM platform device reference drm: arc: Remove unnecessary drm_plane_cleanup() wrapper drm: sti: Remove unnecessary drm_plane_cleanup() wrapper drm: vc4: Remove unnecessary drm_plane_cleanup() wrapper drm: zte: Remove unnecessary drm_plane_cleanup() wrapper drm: Don't export the drm_gem_dumb_destroy() function drm: Move legacy device list out of drm_driver drm: Use a const drm_driver for legacy PCI devices drm: Constify drm_driver in drivers that don't modify it Mark Brown (1): drm/bridge: thc63lvd1024: Fix regulator_get_optional() misuse Qinglang Miao (1): drm: rcar-du: Fix PM reference leak in rcar_cmm_enable() Wang Xiaojun (1): drm: rcar-du: Fix the return check of of_parse_phandle and of_find_device_by_node Xu Wang (2): drm: bridge: dw-hdmi: Remove redundant null check before clk_disable_unprepare drm: bridge: adv7511: Remove redundant null check before clk_disable_unprepare .../bindings/display/bridge/renesas,lvds.yaml | 6 +- .../display/bridge/thine,thc63lvd1024.yaml | 16 ++-- drivers/gpu/drm/arc/arcpgu_crtc.c | 9 +- drivers/gpu/drm/arc/arcpgu_drv.c | 2 +- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 6 +- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6 +- drivers/gpu/drm/bridge/thc63lvd1024.c | 2 +- drivers/gpu/drm/drm_drv.c | 4 - drivers/gpu/drm/drm_dumb_buffers.c | 8 +- drivers/gpu/drm/drm_gem.c | 12 +-- drivers/gpu/drm/drm_internal.h | 3 + drivers/gpu/drm/drm_pci.c | 33 +++++--- drivers/gpu/drm/drm_probe_helper.c | 3 +- drivers/gpu/drm/kmb/kmb_drv.c | 2 +- drivers/gpu/drm/rcar-du/rcar_cmm.c | 2 +- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 12 +-- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 33 +++----- drivers/gpu/drm/rcar-du/rcar_du_drv.h | 16 ++-- drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 98 +++++++++++----------- drivers/gpu/drm/rcar-du/rcar_du_encoder.h | 2 - drivers/gpu/drm/rcar-du/rcar_du_kms.c | 42 +++++++--- drivers/gpu/drm/rcar-du/rcar_du_plane.c | 8 +- drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 28 +++++-- drivers/gpu/drm/rcar-du/rcar_du_writeback.c | 2 +- drivers/gpu/drm/sti/sti_cursor.c | 9 +- drivers/gpu/drm/sti/sti_gdp.c | 9 +- drivers/gpu/drm/sti/sti_hqvdp.c | 9 +- drivers/gpu/drm/tdfx/tdfx_drv.c | 2 +- drivers/gpu/drm/vc4/vc4_plane.c | 7 +- drivers/gpu/drm/zte/zx_plane.c | 7 +- include/drm/drm_device.h | 14 +--- include/drm/drm_drv.h | 2 - include/drm/drm_gem.h | 3 - include/drm/drm_legacy.h | 10 ++- include/drm/drm_modeset_helper_vtables.h | 8 +- 35 files changed, 209 insertions(+), 226 deletions(-) -- Regards, Laurent Pinchart

2 1

[Patch] fbcon: i want fbcon soft scrollback feature come back
by xuhuijie 07 Jan '21

07 Jan '21

1 0

[PATCH v3 0/8] drm: Support short-term vmap via vmap_local
by Thomas Zimmermann 07 Jan '21

07 Jan '21

(was: drm/vram-helper: Lock GEM BOs while they are mapped) GEM VRAM helpers used to pin the BO in their implementation of vmap, so that they could not be relocated. In recent discussions, [1][2] it became clear that this is incorrect for in-kernel use cases, such as fbdev emulation; which should rather depend on the reservation lock to prevent relocation. This patchset addresses the issue by introducing the new interfaces vmap_local and vunmap_local throughout dma-buf and GEM. It further adds support to DRM's CMA, SHMEM and VRAM helpers and finally converts fbdev emulation to the new interface. Patches 1 and 2 prepare the ast cursor code for the later changes. Patches 3 and 4 add the vmap_local infrastructure throughout dma-buf, GEM and PRIME. Patches 5 to 7 add implementations of vmap_local to DRM's various GEM helper libraries. Due to the simple nature of these libraries, existing vmap code can be reused easily. Several drivers are updateed as well to use the new interfaces. Patch 8 converts generic fbdev emulation to use vmap_local. Only DRM drivers that use GEM helpers currently use fbdev emulation, so patches 5 to 7 covered all necessary instances. I smoke-tested the patchset with ast (VRAM helpers), mgag200 (SHMEM) and vc4 (CMA). I also tested with a version of radeon (raw TTM) that has been converted to generic fbdev emulation. v3: * rewrite patchset around vmap_local v2: * make importers acquire resv locks by themselves * document dma-buf vamp/vunmap ops [1] https://patchwork.freedesktop.org/patch/400054/?series=83765&rev=1 [2] https://patchwork.freedesktop.org/patch/405407/?series=84401&rev=2 Thomas Zimmermann (8): drm/ast: Don't pin cursor source BO explicitly during update drm/ast: Only map cursor BOs during updates dma-buf: Add vmap_local and vnumap_local operations drm/gem: Create infrastructure for GEM vmap_local drm/cma-helper: Provide a vmap function for short-term mappings drm/shmem-helper: Provide a vmap function for short-term mappings drm/vram-helper: Provide a vmap function for short-term mappings drm/fb-helper: Move BO locking from DRM client to fbdev damage worker drivers/dma-buf/dma-buf.c | 80 ++++++++++++++ drivers/gpu/drm/ast/ast_cursor.c | 70 +++++++----- drivers/gpu/drm/ast/ast_drv.h | 2 - drivers/gpu/drm/drm_client.c | 91 ++++++++++++++++ drivers/gpu/drm/drm_fb_helper.c | 41 +++---- drivers/gpu/drm/drm_gem.c | 28 +++++ drivers/gpu/drm/drm_gem_cma_helper.c | 35 ++++++ drivers/gpu/drm/drm_gem_shmem_helper.c | 71 ++++++++++++- drivers/gpu/drm/drm_gem_vram_helper.c | 142 ++++++++++++++++--------- drivers/gpu/drm/drm_internal.h | 2 + drivers/gpu/drm/drm_prime.c | 39 +++++++ drivers/gpu/drm/mgag200/mgag200_mode.c | 16 ++- drivers/gpu/drm/tiny/cirrus.c | 10 +- drivers/gpu/drm/tiny/gm12u320.c | 14 ++- drivers/gpu/drm/udl/udl_modeset.c | 18 ++-- drivers/gpu/drm/vboxvideo/vbox_mode.c | 15 +-- drivers/gpu/drm/vc4/vc4_bo.c | 13 +++ drivers/gpu/drm/vc4/vc4_drv.h | 1 + drivers/gpu/drm/virtio/virtgpu_prime.c | 2 + include/drm/drm_client.h | 4 + include/drm/drm_gem.h | 20 ++++ include/drm/drm_gem_cma_helper.h | 1 + include/drm/drm_gem_shmem_helper.h | 2 + include/drm/drm_gem_vram_helper.h | 2 + include/drm/drm_prime.h | 2 + include/linux/dma-buf.h | 34 ++++++ 26 files changed, 635 insertions(+), 120 deletions(-) -- 2.29.2

2 25

← Newer
1
...
62
63
64
65
66
67
68
...
74
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2021