dri-devel October 2021

dri-devel@lists.freedesktop.org

347 participants
825 discussions

[PATCH] drm/prime: Fix use after free in mmap with drm_gem_ttm_mmap
by Anand K Mistry 03 Nov '21

03 Nov '21

drm_gem_ttm_mmap() drops a reference to the gem object on success. If the gem object's refcount == 1 on entry to drm_gem_prime_mmap(), that drop will free the gem object, and the subsequent drm_gem_object_get() will be a UAF. Fix by grabbing a reference before calling the mmap helper. This issue was forseen when the reference dropping was adding in commit 9786b65bc61ac ("drm/ttm: fix mmap refcounting"): "For that to work properly the drm_gem_object_get() call in drm_gem_ttm_mmap() must be moved so it happens before calling obj->funcs->mmap(), otherwise the gem refcount would go down to zero." Signed-off-by: Anand K Mistry <amistry(a)google.com> --- drivers/gpu/drm/drm_prime.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c index 2a54f86856af..e1854fd24bb0 100644 --- a/drivers/gpu/drm/drm_prime.c +++ b/drivers/gpu/drm/drm_prime.c @@ -719,11 +719,13 @@ int drm_gem_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma) if (obj->funcs && obj->funcs->mmap) { vma->vm_ops = obj->funcs->vm_ops; + drm_gem_object_get(obj); ret = obj->funcs->mmap(obj, vma); - if (ret) + if (ret) { + drm_gem_object_put(obj); return ret; + } vma->vm_private_data = obj; - drm_gem_object_get(obj); return 0; } -- 2.33.0.800.g4c38ced690-goog

3 3

[PATCH v1] media: mtk-vcodec: Align width and height to 64
by Yunfei Dong 03 Nov '21

03 Nov '21

User get width and height are 64 align when set format. Need to make sure all is 64 align when use width and height to calculate buffer size. Signed-off-by: Yunfei Dong <yunfei.dong(a)mediatek.com> --- drivers/media/platform/mtk-vcodec/vdec/vdec_h264_req_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/mtk-vcodec/vdec/vdec_h264_req_if.c b/drivers/media/platform/mtk-vcodec/vdec/vdec_h264_req_if.c index 946c23088308..28c17204f9a1 100644 --- a/drivers/media/platform/mtk-vcodec/vdec/vdec_h264_req_if.c +++ b/drivers/media/platform/mtk-vcodec/vdec/vdec_h264_req_if.c @@ -562,8 +562,8 @@ static void get_pic_info(struct vdec_h264_slice_inst *inst, { struct mtk_vcodec_ctx *ctx = inst->ctx; - ctx->picinfo.buf_w = (ctx->picinfo.pic_w + 15) & 0xFFFFFFF0; - ctx->picinfo.buf_h = (ctx->picinfo.pic_h + 31) & 0xFFFFFFE0; + ctx->picinfo.buf_w = ALIGN(ctx->picinfo.pic_w, 64); + ctx->picinfo.buf_h = ALIGN(ctx->picinfo.pic_h, 64); ctx->picinfo.fb_sz[0] = ctx->picinfo.buf_w * ctx->picinfo.buf_h; ctx->picinfo.fb_sz[1] = ctx->picinfo.fb_sz[0] >> 1; inst->vsi_ctx.dec.cap_num_planes = -- 2.25.1

3 2

[PATCH 0/4] Unregister mst connectors when hotplug
by Wayne Lin 02 Nov '21

02 Nov '21

By patches below, we change to clean up resources of a mst connector and put port's malloc_kref when we start to destroy a connector. * 09b974e8983 drm/amd/amdgpu_dm/mst: Remove ->destroy_connector() callback * 72dc0f51591 drm/dp_mst: Remove drm_dp_mst_topology_cbs.destroy_connector However, find out that mst connectors won't reach connector destroy flow after hot unplug and hence will cause no more resources for new added connectors. Thus, this patch set is trying to solve observed registration/unregistration problem of mst connectors. Wayne Lin (4): drm/dp_mst: Put malloc_kref of vcpi pointing port when disable MST drm/dp_mst: Only create connector for connected end device drm/dp_mst: Put connector of disconnected end device when handling CSN drm/dp_mst: Release disconnected connectors when resume drivers/gpu/drm/drm_dp_mst_topology.c | 39 ++++++++++++++++++++++++--- 1 file changed, 36 insertions(+), 3 deletions(-) -- 2.17.1

3 25

[Bug 204987] New: general protection fault in amdgpu_dm_atomic_commit_tail (Vega64)
by bugzilla-daemon＠bugzilla.kernel.org 02 Nov '21

02 Nov '21

https://bugzilla.kernel.org/show_bug.cgi?id=204987 Bug ID: 204987 Summary: general protection fault in amdgpu_dm_atomic_commit_tail (Vega64) Product: Drivers Version: 2.5 Kernel Version: 5.3.1 Hardware: x86-64 OS: Linux Tree: Mainline Status: NEW Severity: high Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: steinex(a)nognu.de Regression: No drm.debug=0x54 log uploaded here due to attachment size limit: https://nognu.de/p/1569355650 This is on 5.3.1 with this patch series applied: https://patchwork.freedesktop.org/series/64505/ It happens between ~5 and ~45 minutes after the system is booted into X. There is no obvious pattern what triggers it. -- You are receiving this mail because: You are watching the assignee of the bug.

1 7

[PATCH] drm/sun4i: fix unmet dependency on RESET_CONTROLLER for PHY_SUN6I_MIPI_DPHY
by Julian Braha 02 Nov '21

02 Nov '21

When PHY_SUN6I_MIPI_DPHY is selected, and RESET_CONTROLLER is not selected, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for PHY_SUN6I_MIPI_DPHY Depends on [n]: (ARCH_SUNXI [=n] || COMPILE_TEST [=y]) && HAS_IOMEM [=y] && COMMON_CLK [=y] && RESET_CONTROLLER [=n] Selected by [y]: - DRM_SUN6I_DSI [=y] && HAS_IOMEM [=y] && DRM_SUN4I [=y] This is because DRM_SUN6I_DSI selects PHY_SUN6I_MIPI_DPHY without selecting or depending on RESET_CONTROLLER, despite PHY_SUN6I_MIPI_DPHY depending on RESET_CONTROLLER. These unmet dependency bugs were detected by Kismet, a static analysis tool for Kconfig. Please advise if this is not the appropriate solution. Signed-off-by: Julian Braha <julianbraha(a)gmail.com> --- drivers/gpu/drm/sun4i/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/sun4i/Kconfig b/drivers/gpu/drm/sun4i/Kconfig index 5755f0432e77..3f70a14a3c94 100644 --- a/drivers/gpu/drm/sun4i/Kconfig +++ b/drivers/gpu/drm/sun4i/Kconfig @@ -46,6 +46,7 @@ config DRM_SUN6I_DSI default MACH_SUN8I select CRC_CCITT select DRM_MIPI_DSI + select RESET_CONTROLLER select PHY_SUN6I_MIPI_DPHY help Choose this option if you want have an Allwinner SoC with -- 2.30.2

2 1

amdgpu on Ryzen 5600G -- 'purple' background [WAS: Re: amdgpu "Fatal error during GPU init"; Ryzen 5600G integrated GPU + kernel 5.14.13}
by PGNet Dev 02 Nov '21

02 Nov '21

Now I'm just guessing. TBH, I've no idea what's causing this reproducible 'purple' background with `amdgpu` on Ryzen 5XXXG. All I can definitively say is that it's real, reproducible, seen elsewhere in the wild for radeon/amd Possibly related to driver defaulting to HDMI YCbCr color, rather than RGB. I'll add more info as requested when someone with better knowledge of what's needed chimes in. For now, here's the last bits of info I've found. This issue https://community.amd.com/t5/drivers-software/purple-ish-desktop-screen-aft… suggests in 2019, Microsoft fixed driver for this purple-hue issue on Ryzen https://support.microsoft.com/en-ca/help/4505903/windows-10-update-kb4505903 Seems like this had to do with the driver selecting YCbCr for HDMI rather than RGB ... Here, Setting the amdgpu HDMI Pixel Format on Linux https://www.wezm.net/v2/posts/2020/linux-amdgpu-pixel-format/ mentions "... I looked for a way to change the pixel format output from the HDMI port of my RX560 graphics card. Turns out this is super easy on Windows, but the amdgpu driver on Linux does not support changing it. ..." and refers to an EDID hack/fix https://www.wezm.net/v2/posts/2020/linux-amdgpu-pixel-format/#the-fix More digging led to AMDGPU fails to properly parse EDID information from display, causing weird resolution setting issues https://gitlab.freedesktop.org/drm/amd/-/issues/1589 with a familiar 'purple' display, https://gitlab.freedesktop.org/drm/amd/uploads/2e2b485aed26d77a9066ca9ea516… and points to an amd issue "Created 3 years ago", no color format choice in amdgpu https://gitlab.freedesktop.org/drm/amd/-/issues/476#note_852860 and finally, a patch [PATCH] drm/amdgpu/dc: Pixel encoding DRM property and module parameter https://www.spinics.net/lists/amd-gfx/msg53281.html which suggests adding pixel_encoding=rgb checking hwinfo --gfxcard | egrep "Model|SysFS ID" SysFS ID: /devices/pci0000:00/0000:00:08.1/0000:30:00.0 Model: "ATI VGA compatible controller" SysFS ID: /devices/pci0000:00/0000:00:01.1/0000:10:00.0 Model: "nVidia GP108 [GeForce GT 1030]" ls -ald /sys/class/drm/card* | grep 30: lrwxrwxrwx 1 root root 0 Oct 30 09:56 /sys/class/drm/card0 -> ../../devices/pci0000:00/0000:00:08.1/0000:30:00.0/drm/card0/ lrwxrwxrwx 1 root root 0 Oct 30 09:56 /sys/class/drm/card0-DP-1 -> ../../devices/pci0000:00/0000:00:08.1/0000:30:00.0/drm/card0/card0-DP-1/ lrwxrwxrwx 1 root root 0 Oct 30 09:56 /sys/class/drm/card0-HDMI-A-1 -> ../../devices/pci0000:00/0000:00:08.1/0000:30:00.0/drm/card0/card0-HDMI-A-1/ lrwxrwxrwx 1 root root 0 Oct 30 09:56 /sys/class/drm/card0-HDMI-A-2 -> ../../devices/pci0000:00/0000:00:08.1/0000:30:00.0/drm/card0/card0-HDMI-A-2/ ( why are there *2* HDMI for card0, when only 1 phy output? ) next, added to kernel cmdline video=HDMI-A-1:2560x1440@60:pixel_encoding=rgb video=HDMI-A-2:2560x1440@60:pixel_encoding=rgb and, for good measure, cat /etc/modprobe.d/amdgpu.conf re-gen'd initrd, and rebooted. STILL getting the purple screen :-/ dmesg, after boot completion, dmesg | grep encod ... [ 1.650090] amdgpu: unknown parameter 'pixel_encoding' ignored ... Paying close(r) attention, screen output after grub-select starts out with black-as-usual background, but switches to purple immediately after: dmesg ... >> [ 1.268709] systemd[1]: Starting dracut initqueue hook... ... where, dmesg | egrep -i "atpx|vga|drm|amdgpu|initqueue" [ 0.329804] ACPI BIOS Error (bug): Failure creating named object [\_SB.PCI0.GPP0.VGA], AE_ALREADY_EXISTS (20210604/dswload2-326) [ 0.351328] pci 0000:10:00.0: vgaarb: VGA device added: decodes=io+mem,owns=none,locks=none [ 0.351328] pci 0000:30:00.0: vgaarb: setting as boot VGA device [ 0.351328] pci 0000:30:00.0: vgaarb: VGA device added: decodes=io+mem,owns=io+mem,locks=none [ 0.351328] pci 0000:10:00.0: vgaarb: bridge control possible [ 0.351328] pci 0000:30:00.0: vgaarb: bridge control possible [ 0.351328] vgaarb: loaded [ 0.410851] fb0: EFI VGA frame buffer device [ 1.264753] ACPI: video: Video Device [VGA] (multi-head: yes rom: no post: no) [ 1.265256] ACPI: video: Video Device [VGA1] (multi-head: yes rom: no post: no) [ 1.268709] systemd[1]: Starting dracut initqueue hook... [ 1.650090] amdgpu: unknown parameter 'pixel_encoding' ignored [ 1.650094] amdgpu: unknown parameter 'modeset' ignored [ 1.650416] [drm] amdgpu kernel modesetting enabled. [ 1.650432] vga_switcheroo: detected switching method \_SB_.PCI0.GP17.VGA_.ATPX handle [ 1.650720] ATPX version 1, functions 0x00000001 [ 1.650751] ATPX Hybrid Graphics [ 1.656232] amdgpu: Virtual CRAT table created for CPU [ 1.656240] amdgpu: Topology: Add CPU node [ 1.656299] fb0: switching to amdgpudrmfb from EFI VGA [ 1.656413] amdgpu 0000:30:00.0: vgaarb: deactivate vga console [ 1.656503] [drm] initializing kernel modesetting (RENOIR 0x1002:0x1638 0x1002:0x1636 0xC9). [ 1.656516] amdgpu 0000:30:00.0: amdgpu: Trusted Memory Zone (TMZ) feature enabled [ 1.656548] [drm] register mmio base: 0xFCB00000 [ 1.656548] [drm] register mmio size: 524288 [ 1.656550] [drm] PCIE atomic ops is not supported [ 1.657578] [drm] add ip block number 0 <soc15_common> [ 1.657579] [drm] add ip block number 1 <gmc_v9_0> [ 1.657581] [drm] add ip block number 2 <vega10_ih> [ 1.657581] [drm] add ip block number 3 <psp> [ 1.657582] [drm] add ip block number 4 <smu> [ 1.657583] [drm] add ip block number 5 <gfx_v9_0> [ 1.657584] [drm] add ip block number 6 <sdma_v4_0> [ 1.657585] [drm] add ip block number 7 <dm> [ 1.657586] [drm] add ip block number 8 <vcn_v2_0> [ 1.657587] [drm] add ip block number 9 <jpeg_v2_0> [ 1.663332] [drm] BIOS signature incorrect 0 0 [ 1.663360] amdgpu 0000:30:00.0: amdgpu: Fetched VBIOS from ROM BAR [ 1.663363] amdgpu: ATOM BIOS: 113-CEZANNE-018 [ 1.664115] [drm] VCN decode is enabled in VM mode [ 1.664117] [drm] VCN encode is enabled in VM mode [ 1.664118] [drm] JPEG decode is enabled in VM mode [ 1.664147] [drm] vm size is 262144 GB, 4 levels, block size is 9-bit, fragment size is 9-bit [ 1.664153] amdgpu 0000:30:00.0: amdgpu: VRAM: 512M 0x000000F400000000 - 0x000000F41FFFFFFF (512M used) [ 1.664155] amdgpu 0000:30:00.0: amdgpu: GART: 1024M 0x0000000000000000 - 0x000000003FFFFFFF [ 1.664156] amdgpu 0000:30:00.0: amdgpu: AGP: 267419648M 0x000000F800000000 - 0x0000FFFFFFFFFFFF [ 1.664161] [drm] Detected VRAM RAM=512M, BAR=512M [ 1.664162] [drm] RAM width 128bits DDR4 [ 1.664200] [drm] amdgpu: 512M of VRAM memory ready [ 1.664201] [drm] amdgpu: 3072M of GTT memory ready. [ 1.664206] [drm] GART: num cpu pages 262144, num gpu pages 262144 [ 1.664285] [drm] PCIE GART of 1024M enabled. [ 1.664286] [drm] PTB located at 0x000000F400900000 [ 1.668403] amdgpu 0000:30:00.0: amdgpu: PSP runtime database doesn't exist [ 1.684148] [drm] Loading DMUB firmware via PSP: version=0x01010019 [ 1.699355] [drm] Found VCN firmware Version ENC: 1.14 DEC: 5 VEP: 0 Revision: 20 [ 1.699368] amdgpu 0000:30:00.0: amdgpu: Will use PSP to load VCN firmware [ 2.119364] nvidia 0000:10:00.0: vgaarb: changed VGA decodes: olddecodes=io+mem,decodes=none:owns=none [ 2.371596] [drm] [nvidia-drm] [GPU ID 0x00001000] Loading driver [ 2.425174] [drm] reserve 0x400000 from 0xf41f800000 for PSP TMR [ 2.506778] amdgpu 0000:30:00.0: amdgpu: RAS: optional ras ta ucode is not available [ 2.515189] amdgpu 0000:30:00.0: amdgpu: RAP: optional rap ta ucode is not available [ 2.515191] amdgpu 0000:30:00.0: amdgpu: SECUREDISPLAY: securedisplay ta ucode is not available [ 2.515540] amdgpu 0000:30:00.0: amdgpu: SMU is initialized successfully! [ 2.516855] [drm] kiq ring mec 2 pipe 1 q 0 [ 2.517561] [drm] Display Core initialized with v3.2.141! [ 2.517981] [drm] DMUB hardware initialized: version=0x01010019 [ 2.577117] [drm] VCN decode and encode initialized successfully(under DPG Mode). [ 2.577132] [drm] JPEG decode initialized successfully. [ 2.578072] kfd kfd: amdgpu: Allocated 3969056 bytes on gart [ 2.707339] amdgpu: HMM registered 512MB device memory [ 2.707361] amdgpu: SRAT table not found [ 2.707361] amdgpu: Virtual CRAT table created for GPU [ 2.708098] amdgpu: Topology: Add dGPU node [0x1638:0x1002] [ 2.708103] kfd kfd: amdgpu: added device 1002:1638 [ 2.708170] amdgpu 0000:30:00.0: amdgpu: SE 1, SH per SE 2, CU per SH 18, active_cu_number 27 [ 2.709057] [drm] fb mappable at 0x90CD2000 [ 2.709059] [drm] vram apper at 0x90000000 [ 2.709059] [drm] size 14745600 [ 2.709059] [drm] fb depth is 24 [ 2.709060] [drm] pitch is 10240 [ 2.896150] fbcon: amdgpu (fb0) is primary device [ 3.000331] amdgpu 0000:30:00.0: [drm] fb0: amdgpu frame buffer device [ 3.009001] amdgpu 0000:30:00.0: amdgpu: ring gfx uses VM inv eng 0 on hub 0 [ 3.009004] amdgpu 0000:30:00.0: amdgpu: ring comp_1.0.0 uses VM inv eng 1 on hub 0 [ 3.009006] amdgpu 0000:30:00.0: amdgpu: ring comp_1.1.0 uses VM inv eng 4 on hub 0 [ 3.009006] amdgpu 0000:30:00.0: amdgpu: ring comp_1.2.0 uses VM inv eng 5 on hub 0 [ 3.009007] amdgpu 0000:30:00.0: amdgpu: ring comp_1.3.0 uses VM inv eng 6 on hub 0 [ 3.009008] amdgpu 0000:30:00.0: amdgpu: ring comp_1.0.1 uses VM inv eng 7 on hub 0 [ 3.009009] amdgpu 0000:30:00.0: amdgpu: ring comp_1.1.1 uses VM inv eng 8 on hub 0 [ 3.009010] amdgpu 0000:30:00.0: amdgpu: ring comp_1.2.1 uses VM inv eng 9 on hub 0 [ 3.009010] amdgpu 0000:30:00.0: amdgpu: ring comp_1.3.1 uses VM inv eng 10 on hub 0 [ 3.009011] amdgpu 0000:30:00.0: amdgpu: ring kiq_2.1.0 uses VM inv eng 11 on hub 0 [ 3.009012] amdgpu 0000:30:00.0: amdgpu: ring sdma0 uses VM inv eng 0 on hub 1 [ 3.009013] amdgpu 0000:30:00.0: amdgpu: ring vcn_dec uses VM inv eng 1 on hub 1 [ 3.009014] amdgpu 0000:30:00.0: amdgpu: ring vcn_enc0 uses VM inv eng 4 on hub 1 [ 3.009015] amdgpu 0000:30:00.0: amdgpu: ring vcn_enc1 uses VM inv eng 5 on hub 1 [ 3.009016] amdgpu 0000:30:00.0: amdgpu: ring jpeg_dec uses VM inv eng 6 on hub 1 [ 3.155840] [drm] Initialized nvidia-drm 0.0.0 20160202 for 0000:10:00.0 on minor 1 [ 3.156216] [drm] Initialized amdgpu 3.42.0 20150101 for 0000:30:00.0 on minor 0 [ 4.598742] systemd[1]: Finished dracut initqueue hook. [ 5.043799] systemd[1]: dracut-initqueue.service: Deactivated successfully. [ 5.043873] systemd[1]: Stopped dracut initqueue hook. [ 10.007951] systemd[1]: Starting Load Kernel Module drm... [ 10.170619] systemd[1]: modprobe(a)drm.service: Deactivated successfully. [ 10.170718] systemd[1]: Finished Load Kernel Module drm. [ 13.750415] snd_hda_intel 0000:10:00.1: Handle vga_switcheroo audio client [ 13.750632] snd_hda_intel 0000:30:00.1: Handle vga_switcheroo audio client [ 13.879276] snd_hda_intel 0000:30:00.1: bound 0000:30:00.0 (ops amdgpu_dm_audio_component_bind_ops [amdgpu]) Is that kernel/modconfig config incorrect? Not relevant to the problem? Something else(where) needed?

1 1

[PATCH v2 0/2] Add a drm.disable_native_drivers command line option
by Javier Martinez Canillas 02 Nov '21

02 Nov '21

This patch-series add a drm.disable_native_drivers option that can be used to prevent native DRM drivers to be probed. That way, the simpledrm driver won't be removed which can be useful to troubleshoot DRM drivers problems. Patch #1 is just a small preparatory patch that moves the logic to remove the conflicting fbdev frame buffer to a helper function. Patch #2 adds the new kernel command line option and if set, prevents the drm_aperture_remove_conflicting_framebuffers() function to succeed. This is a v2 that addresses the issues pointed out by Thomas and Neal. Best regards, Javier Changes in v2: - Rename command line parameter to drm.disable_native_drivers. - Return -EBUSY instead of -EINVAL when the function fails. - Invert the parameter logic and make it false by default. Javier Martinez Canillas (2): drm/aperture: Move conflicting fbdev frame buffer removal to a helper drm/aperture: Prevent conflicting framebuffers removal if option is set drivers/gpu/drm/drm_aperture.c | 54 ++++++++++++++++++++++++++-------- 1 file changed, 42 insertions(+), 12 deletions(-) -- 2.31.1

2 3

[PATCH v3 00/34] component: Make into an aggregate bus
by Stephen Boyd 01 Nov '21

01 Nov '21

This series is from discussion we had on reordering the device lists for drm shutdown paths[1]. I've introduced an 'aggregate' bus that we put the aggregate device onto and then we probe the aggregate device once all the components are probed and call component_add(). The probe/remove hooks are where the bind/unbind calls go, and then a shutdown hook is added that can be used to shutdown the drm display pipeline at the right time. This works for me on my sc7180 board. I no longer get a warning from i2c at shutdown that we're trying to make an i2c transaction after the i2c bus has been shutdown. There's more work to do on the msm drm driver to extract component device resources like clks, regulators, etc. out of the component bind function into the driver probe but I wanted to move everything over now in other component drivers before tackling that problem. Tested-by tags would be appreciated, and Acked-by/Reviewed-by tags too. I sent this to gregkh which may be incorrect but I don't know what better tree to send it all through. Maybe drm? Changes since v2 (https://lore.kernel.org/r/20211006193819.2654854-1-swboyd@chromium.org): - Picked up acks - Fixed build warnings/errors - Reworked patch series to rename 'master' in a different patch Changes since v1 (https://lore.kernel.org/r/20210520002519.3538432-1-swboyd@chromium.org): - Use devlink to connect components to the aggregate device - Don't set the registering device as a parent of the aggregate device - New patch for bind_component/unbind_component ops that takes the aggregate device - Convert all drivers in the tree to use the aggregate driver approach - Allow one aggregate driver to be used for multiple aggregate devices [1] https://lore.kernel.org/r/20210508074118.1621729-1-swboyd@chromium.org Stephen Boyd (34): component: Introduce struct aggregate_device component: Remove most references to 'master' component: Introduce the aggregate bus_type component: Move struct aggregate_device out to header file component: Add {bind,unbind}_component() ops that take aggregate device drm/of: Add a drm_of_aggregate_probe() API drm/msm: Migrate to aggregate driver drm/komeda: Migrate to aggregate driver drm/arm/hdlcd: Migrate to aggregate driver drm/malidp: Migrate to aggregate driver drm/armada: Migrate to aggregate driver drm/etnaviv: Migrate to aggregate driver drm/kirin: Migrate to aggregate driver drm/exynos: Migrate to aggregate driver drm/imx: Migrate to aggregate driver drm/ingenic: Migrate to aggregate driver drm/mcde: Migrate to aggregate driver drm/mediatek: Migrate to aggregate driver drm/meson: Migrate to aggregate driver drm/omap: Migrate to aggregate driver drm/rockchip: Migrate to aggregate driver drm/sti: Migrate to aggregate driver drm/sun4i: Migrate to aggregate driver drm/tilcdc: Migrate to aggregate driver drm/vc4: Migrate to aggregate driver drm/zte: Migrate to aggregate driver iommu/mtk: Migrate to aggregate driver mei: Migrate to aggregate driver power: supply: ab8500: Migrate to aggregate driver fbdev: omap2: Migrate to aggregate driver sound: hdac: Migrate to aggregate driver ASoC: codecs: wcd938x: Migrate to aggregate driver component: Get rid of drm_of_component_probe() component: Remove component_master_ops and friends drivers/base/component.c | 540 ++++++++++-------- .../gpu/drm/arm/display/komeda/komeda_drv.c | 20 +- drivers/gpu/drm/arm/hdlcd_drv.c | 21 +- drivers/gpu/drm/arm/malidp_drv.c | 21 +- drivers/gpu/drm/armada/armada_drv.c | 23 +- drivers/gpu/drm/drm_drv.c | 2 +- drivers/gpu/drm/drm_of.c | 18 +- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 20 +- drivers/gpu/drm/exynos/exynos_drm_drv.c | 21 +- .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 20 +- drivers/gpu/drm/imx/imx-drm-core.c | 20 +- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 25 +- drivers/gpu/drm/mcde/mcde_drv.c | 23 +- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 20 +- drivers/gpu/drm/meson/meson_drv.c | 21 +- drivers/gpu/drm/msm/msm_drv.c | 46 +- drivers/gpu/drm/omapdrm/dss/dss.c | 17 +- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 20 +- drivers/gpu/drm/sti/sti_drv.c | 20 +- drivers/gpu/drm/sun4i/sun4i_drv.c | 26 +- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 28 +- drivers/gpu/drm/vc4/vc4_drv.c | 20 +- drivers/gpu/drm/zte/zx_drm_drv.c | 20 +- drivers/iommu/mtk_iommu.c | 14 +- drivers/iommu/mtk_iommu.h | 6 +- drivers/iommu/mtk_iommu_v1.c | 14 +- drivers/misc/mei/hdcp/mei_hdcp.c | 22 +- drivers/power/supply/ab8500_charger.c | 22 +- drivers/video/fbdev/omap2/omapfb/dss/dss.c | 20 +- include/drm/drm_of.h | 10 +- include/linux/component.h | 92 ++- sound/hda/hdac_component.c | 21 +- sound/soc/codecs/wcd938x.c | 20 +- 33 files changed, 767 insertions(+), 486 deletions(-) Cc: Arnd Bergmann <arnd(a)arndb.de> Cc: Benjamin Gaignard <benjamin.gaignard(a)linaro.org> Cc: Chen Feng <puck.chen(a)hisilicon.com> Cc: Chen-Yu Tsai <wens(a)csie.org> Cc: Christian Gmeiner <christian.gmeiner(a)gmail.com> Cc: Chun-Kuang Hu <chunkuang.hu(a)kernel.org> Cc: Daniel Vetter <daniel.vetter(a)ffwll.ch> Cc: Emma Anholt <emma(a)anholt.net> Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: "Heiko Stübner" <heiko(a)sntech.de> Cc: Inki Dae <inki.dae(a)samsung.com> Cc: James Qian Wang (Arm Technology China) <james.qian.wang(a)arm.com> Cc: Jaroslav Kysela <perex(a)perex.cz> Cc: Joerg Roedel <joro(a)8bytes.org> Cc: John Stultz <john.stultz(a)linaro.org> Cc: Joonyoung Shim <jy0922.shim(a)samsung.com> Cc: Jyri Sarha <jyri.sarha(a)iki.fi> Cc: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> Cc: Kyungmin Park <kyungmin.park(a)samsung.com> Cc: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> Cc: <linux-fbdev(a)vger.kernel.org> Cc: <linux-omap(a)vger.kernel.org> Cc: <linux-pm(a)vger.kernel.org> Cc: Linus Walleij <linus.walleij(a)linaro.org> Cc: Liviu Dudau <liviu.dudau(a)arm.com> Cc: Lucas Stach <l.stach(a)pengutronix.de> Cc: Mark Brown <broonie(a)kernel.org> Cc: Maxime Ripard <mripard(a)kernel.org> Cc: Neil Armstrong <narmstrong(a)baylibre.com> Cc: Paul Cercueil <paul(a)crapouillou.net> Cc: Philipp Zabel <p.zabel(a)pengutronix.de> Cc: "Rafael J. Wysocki" <rafael(a)kernel.org> Cc: Rob Clark <robdclark(a)gmail.com> Cc: Russell King <linux(a)armlinux.org.uk> Cc: Russell King <linux+etnaviv(a)armlinux.org.uk> Cc: Russell King <rmk+kernel(a)arm.linux.org.uk> Cc: Sandy Huang <hjc(a)rock-chips.com> Cc: Saravana Kannan <saravanak(a)google.com> Cc: Sebastian Reichel <sre(a)kernel.org> Cc: Seung-Woo Kim <sw0312.kim(a)samsung.com> Cc: Takashi Iwai <tiwai(a)suse.com> Cc: Tian Tao <tiantao6(a)hisilicon.com> Cc: Tomas Winkler <tomas.winkler(a)intel.com> Cc: Tomi Valkeinen <tomba(a)kernel.org> Cc: Will Deacon <will(a)kernel.org> Cc: Xinliang Liu <xinliang.liu(a)linaro.org> Cc: Xinwei Kong <kong.kongxinwei(a)hisilicon.com> Cc: Yong Wu <yong.wu(a)mediatek.com> base-commit: e4e737bb5c170df6135a127739a9e6148ee3da82 -- https://chromeos.dev

3 39

[PATCH] drm/msm/dsi: set default num_data_lanes
by Philip Chen 01 Nov '21

01 Nov '21

If "data_lanes" property of the dsi output endpoint is missing in the DT, num_data_lanes would be 0 by default, which could cause dsi_host_attach() to fail if dsi->lanes is set to a non-zero value by the bridge driver. According to the binding document of msm dsi controller, the input/output endpoint of the controller is expected to have 4 lanes. So let's set num_data_lanes to 4 by default. Signed-off-by: Philip Chen <philipchen(a)chromium.org> --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index c86b5090fae6..a32eb33dfc14 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -1696,6 +1696,8 @@ static int dsi_host_parse_lane_data(struct msm_dsi_host *msm_host, if (!prop) { DRM_DEV_DEBUG(dev, "failed to find data lane mapping, using default\n"); + /* Set the number of date lanes to 4 by default. */ + msm_host->num_data_lanes = 4; return 0; } -- 2.33.1.1089.g2158813163f-goog

4 3

Lockdep spalt on killing a processes
by Christian König 01 Nov '21

01 Nov '21

Hey, Andrey. while investigating some memory management problems I've got the logdep splat below. Looks like something is wrong with drm_sched_entity_kill_jobs_cb(), can you investigate? Thanks, Christian. [11176.741052] ============================================ [11176.741056] WARNING: possible recursive locking detected [11176.741060] 5.15.0-rc1-00031-g9d546d600800 #171 Not tainted [11176.741066] -------------------------------------------- [11176.741070] swapper/12/0 is trying to acquire lock: [11176.741074] ffff9c337ed175a8 (&fence->lock){-.-.}-{3:3}, at: dma_fence_signal+0x28/0x80 [11176.741088] but task is already holding lock: [11176.741092] ffff9c337ed172a8 (&fence->lock){-.-.}-{3:3}, at: dma_fence_signal+0x28/0x80 [11176.741100] other info that might help us debug this: [11176.741104] Possible unsafe locking scenario: [11176.741108] CPU0 [11176.741110] ---- [11176.741113] lock(&fence->lock); [11176.741118] lock(&fence->lock); [11176.741122] *** DEADLOCK *** [11176.741125] May be due to missing lock nesting notation [11176.741128] 2 locks held by swapper/12/0: [11176.741133] #0: ffff9c339c30f768 (&ring->fence_drv.lock){-.-.}-{3:3}, at: dma_fence_signal+0x28/0x80 [11176.741142] #1: ffff9c337ed172a8 (&fence->lock){-.-.}-{3:3}, at: dma_fence_signal+0x28/0x80 [11176.741151] stack backtrace: [11176.741155] CPU: 12 PID: 0 Comm: swapper/12 Not tainted 5.15.0-rc1-00031-g9d546d600800 #171 [11176.741160] Hardware name: System manufacturer System Product Name/PRIME X399-A, BIOS 0808 10/12/2018 [11176.741165] Call Trace: [11176.741169] <IRQ> [11176.741173] dump_stack_lvl+0x5b/0x74 [11176.741181] dump_stack+0x10/0x12 [11176.741186] __lock_acquire.cold+0x208/0x2df [11176.741197] lock_acquire+0xc6/0x2d0 [11176.741204] ? dma_fence_signal+0x28/0x80 [11176.741212] _raw_spin_lock_irqsave+0x4d/0x70 [11176.741219] ? dma_fence_signal+0x28/0x80 [11176.741225] dma_fence_signal+0x28/0x80 [11176.741230] drm_sched_fence_finished+0x12/0x20 [gpu_sched] [11176.741240] drm_sched_entity_kill_jobs_cb+0x1c/0x50 [gpu_sched] [11176.741248] dma_fence_signal_timestamp_locked+0xac/0x1a0 [11176.741254] dma_fence_signal+0x3b/0x80 [11176.741260] drm_sched_fence_finished+0x12/0x20 [gpu_sched] [11176.741268] drm_sched_job_done.isra.0+0x7f/0x1a0 [gpu_sched] [11176.741277] drm_sched_job_done_cb+0x12/0x20 [gpu_sched] [11176.741284] dma_fence_signal_timestamp_locked+0xac/0x1a0 [11176.741290] dma_fence_signal+0x3b/0x80 [11176.741296] amdgpu_fence_process+0xd1/0x140 [amdgpu] [11176.741504] sdma_v4_0_process_trap_irq+0x8c/0xb0 [amdgpu] [11176.741731] amdgpu_irq_dispatch+0xce/0x250 [amdgpu] [11176.741954] amdgpu_ih_process+0x81/0x100 [amdgpu] [11176.742174] amdgpu_irq_handler+0x26/0xa0 [amdgpu] [11176.742393] __handle_irq_event_percpu+0x4f/0x2c0 [11176.742402] handle_irq_event_percpu+0x33/0x80 [11176.742408] handle_irq_event+0x39/0x60 [11176.742414] handle_edge_irq+0x93/0x1d0 [11176.742419] __common_interrupt+0x50/0xe0 [11176.742426] common_interrupt+0x80/0x90 [11176.742431] </IRQ> [11176.742436] asm_common_interrupt+0x1e/0x40 [11176.742442] RIP: 0010:cpuidle_enter_state+0xff/0x470 [11176.742449] Code: 0f a3 05 04 54 24 01 0f 82 70 02 00 00 31 ff e8 37 5d 6f ff 80 7d d7 00 0f 85 e9 01 00 00 e8 58 a2 7f ff fb 66 0f 1f 44 00 00 <45> 85 ff 0f 88 01 01 00 00 49 63 c7 4c 2b 75 c8 48 8d 14 40 48 8d [11176.742455] RSP: 0018:ffffb6970021fe48 EFLAGS: 00000202 [11176.742461] RAX: 000000000059be25 RBX: 0000000000000002 RCX: 0000000000000000 [11176.742465] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffffffff9efeed78 [11176.742470] RBP: ffffb6970021fe80 R08: 0000000000000001 R09: 0000000000000001 [11176.742473] R10: 0000000000000001 R11: 0000000000000001 R12: ffff9c3350b0e800 [11176.742477] R13: ffffffffa00e9680 R14: 00000a2a49ada060 R15: 0000000000000002 [11176.742483] ? cpuidle_enter_state+0xf8/0x470 [11176.742489] ? cpuidle_enter_state+0xf8/0x470 [11176.742495] cpuidle_enter+0x2e/0x40 [11176.742500] call_cpuidle+0x23/0x40 [11176.742506] do_idle+0x201/0x280 [11176.742512] cpu_startup_entry+0x20/0x30 [11176.742517] start_secondary+0x11f/0x160 [11176.742523] secondary_startup_64_no_verify+0xb0/0xbb

4 18

← Newer
1
...
16
17
18
19
20
21
22
...
83
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel October 2021