dri-devel October 2021

dri-devel@lists.freedesktop.org

347 participants
825 discussions

[PATCH v2] drm/hyperv: Fix double mouse pointers
by Dexuan Cui 07 Oct '21

07 Oct '21

Hyper-V supports a hardware cursor feature. It is not used by Linux VM, but the Hyper-V host still draws a point as an extra mouse pointer, which is unwanted, especially when Xorg is running. The hyperv_fb driver uses synthvid_send_ptr() to hide the unwanted pointer. When the hyperv_drm driver was developed, the function synthvid_send_ptr() was not copied from the hyperv_fb driver. Fix the issue by adding the function into hyperv_drm. Fixes: 76c56a5affeb ("drm/hyperv: Add DRM driver for hyperv synthetic video device") Signed-off-by: Dexuan Cui <decui(a)microsoft.com> Reviewed-by: Haiyang Zhang <haiyangz(a)microsoft.com> Reviewed-by: Deepak Rawat <drawat.floss(a)gmail.com> --- Changes in v2: Renamed hyperv_send_ptr() to hyperv_hide_hw_ptr(). Improved the comments and the git commit message. Added Reviewed-by's from Haiyang and Deepak. drivers/gpu/drm/hyperv/hyperv_drm.h | 1 + drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 1 + drivers/gpu/drm/hyperv/hyperv_drm_proto.c | 54 ++++++++++++++++++++- 3 files changed, 55 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/hyperv/hyperv_drm.h b/drivers/gpu/drm/hyperv/hyperv_drm.h index 886add4f9cd0..d2d8582b36df 100644 --- a/drivers/gpu/drm/hyperv/hyperv_drm.h +++ b/drivers/gpu/drm/hyperv/hyperv_drm.h @@ -46,6 +46,7 @@ int hyperv_mode_config_init(struct hyperv_drm_device *hv); int hyperv_update_vram_location(struct hv_device *hdev, phys_addr_t vram_pp); int hyperv_update_situation(struct hv_device *hdev, u8 active, u32 bpp, u32 w, u32 h, u32 pitch); +int hyperv_hide_hw_ptr(struct hv_device *hdev); int hyperv_update_dirt(struct hv_device *hdev, struct drm_rect *rect); int hyperv_connect_vsp(struct hv_device *hdev); diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c index 3aaee4730ec6..5f01ca817517 100644 --- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c +++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c @@ -101,6 +101,7 @@ static void hyperv_pipe_enable(struct drm_simple_display_pipe *pipe, struct hyperv_drm_device *hv = to_hv(pipe->crtc.dev); struct drm_shadow_plane_state *shadow_plane_state = to_drm_shadow_plane_state(plane_state); + hyperv_hide_hw_ptr(hv->hdev); hyperv_update_situation(hv->hdev, 1, hv->screen_depth, crtc_state->mode.hdisplay, crtc_state->mode.vdisplay, diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_proto.c b/drivers/gpu/drm/hyperv/hyperv_drm_proto.c index 6d4bdccfbd1a..c0155c6271bf 100644 --- a/drivers/gpu/drm/hyperv/hyperv_drm_proto.c +++ b/drivers/gpu/drm/hyperv/hyperv_drm_proto.c @@ -299,6 +299,55 @@ int hyperv_update_situation(struct hv_device *hdev, u8 active, u32 bpp, return 0; } +/* + * Hyper-V supports a hardware cursor feature. It's not used by Linux VM, + * but the Hyper-V host still draws a point as an extra mouse pointer, + * which is unwanted, especially when Xorg is running. + * + * The hyperv_fb driver uses synthvid_send_ptr() to hide the unwanted + * pointer, by setting msg.ptr_pos.is_visible = 1 and setting the + * msg.ptr_shape.data. Note: setting msg.ptr_pos.is_visible to 0 doesn't + * work in tests. + * + * Copy synthvid_send_ptr() to hyperv_drm and rename it to + * hyperv_hide_hw_ptr(). Note: hyperv_hide_hw_ptr() is also called in the + * handler of the SYNTHVID_FEATURE_CHANGE event, otherwise the host still + * draws an extra unwanted mouse pointer after the VM Connection window is + * closed and reopened. + */ +int hyperv_hide_hw_ptr(struct hv_device *hdev) +{ + struct synthvid_msg msg; + + memset(&msg, 0, sizeof(struct synthvid_msg)); + msg.vid_hdr.type = SYNTHVID_POINTER_POSITION; + msg.vid_hdr.size = sizeof(struct synthvid_msg_hdr) + + sizeof(struct synthvid_pointer_position); + msg.ptr_pos.is_visible = 1; + msg.ptr_pos.video_output = 0; + msg.ptr_pos.image_x = 0; + msg.ptr_pos.image_y = 0; + hyperv_sendpacket(hdev, &msg); + + memset(&msg, 0, sizeof(struct synthvid_msg)); + msg.vid_hdr.type = SYNTHVID_POINTER_SHAPE; + msg.vid_hdr.size = sizeof(struct synthvid_msg_hdr) + + sizeof(struct synthvid_pointer_shape); + msg.ptr_shape.part_idx = SYNTHVID_CURSOR_COMPLETE; + msg.ptr_shape.is_argb = 1; + msg.ptr_shape.width = 1; + msg.ptr_shape.height = 1; + msg.ptr_shape.hot_x = 0; + msg.ptr_shape.hot_y = 0; + msg.ptr_shape.data[0] = 0; + msg.ptr_shape.data[1] = 1; + msg.ptr_shape.data[2] = 1; + msg.ptr_shape.data[3] = 1; + hyperv_sendpacket(hdev, &msg); + + return 0; +} + int hyperv_update_dirt(struct hv_device *hdev, struct drm_rect *rect) { struct hyperv_drm_device *hv = hv_get_drvdata(hdev); @@ -392,8 +441,11 @@ static void hyperv_receive_sub(struct hv_device *hdev) return; } - if (msg->vid_hdr.type == SYNTHVID_FEATURE_CHANGE) + if (msg->vid_hdr.type == SYNTHVID_FEATURE_CHANGE) { hv->dirt_needed = msg->feature_chg.is_dirt_needed; + if (hv->dirt_needed) + hyperv_hide_hw_ptr(hv->hdev); + } } static void hyperv_receive(void *ctx) -- 2.25.1

2 2

[PATCH RFC] drm: introduce DRM_MODE_FB_PERSIST
by Simon Ser 07 Oct '21

07 Oct '21

This new ADDFB2 flag allows callers to mark a framebuffer as "persistent", and no longer have RMFB semantics when the DRM file is closed. [1]: https://lore.kernel.org/dri-devel/YTJypepF1Hpc2YYT@reader/ Signed-off-by: Simon Ser <contact(a)emersion.fr> Cc: Hans de Goede <hdegoede(a)redhat.com> Cc: Dennis Filder <d.filder(a)web.de> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: Pekka Paalanen <ppaalanen(a)gmail.com> --- I'm not sure this is enough, but posting this to get initial feedback and allow to start e.g. Plymouth experiments. I'll follow up with an IGT test soon. drivers/gpu/drm/drm_framebuffer.c | 6 ++++-- include/uapi/drm/drm_mode.h | 15 +++++++++++++++ 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c index 07f5abc875e9..9b398838e1f4 100644 --- a/drivers/gpu/drm/drm_framebuffer.c +++ b/drivers/gpu/drm/drm_framebuffer.c @@ -292,7 +292,8 @@ drm_internal_framebuffer_create(struct drm_device *dev, struct drm_framebuffer *fb; int ret; - if (r->flags & ~(DRM_MODE_FB_INTERLACED | DRM_MODE_FB_MODIFIERS)) { + if (r->flags & ~(DRM_MODE_FB_INTERLACED | DRM_MODE_FB_MODIFIERS | + DRM_MODE_FB_PERSIST)) { DRM_DEBUG_KMS("bad framebuffer flags 0x%08x\n", r->flags); return ERR_PTR(-EINVAL); } @@ -789,7 +790,8 @@ void drm_fb_release(struct drm_file *priv) * at it any more. */ list_for_each_entry_safe(fb, tfb, &priv->fbs, filp_head) { - if (drm_framebuffer_read_refcount(fb) > 1) { + if (drm_framebuffer_read_refcount(fb) > 1 && + !(fb->flags & DRM_MODE_FB_PERSIST)) { list_move_tail(&fb->filp_head, &arg.fbs); } else { list_del_init(&fb->filp_head); diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h index e1e351682872..c7a7089ec31e 100644 --- a/include/uapi/drm/drm_mode.h +++ b/include/uapi/drm/drm_mode.h @@ -662,6 +662,21 @@ struct drm_mode_fb_cmd { #define DRM_MODE_FB_INTERLACED (1<<0) /* for interlaced framebuffers */ #define DRM_MODE_FB_MODIFIERS (1<<1) /* enables ->modifer[] */ +/** + * DRM_MODE_FB_PERSIST + * + * DRM framebuffers are normally implicitly removed when their owner closes the + * DRM FD. Passing this flag will make the framebuffer persistent: it will not + * be implicitly removed. This is useful to implement flicker-free transitions + * between two processes. + * + * This flag doesn't change the behavior of &DRM_IOCTL_MODE_RMFB. + * + * User-space should ensure the framebuffer doesn't expose any sensitive user + * information: persistent framebuffers can be read back by the next DRM + * master. + */ +#define DRM_MODE_FB_PERSIST (1 << 2) struct drm_mode_fb_cmd2 { __u32 fb_id; -- 2.33.0

4 4

[bisected] suspend broken by DRM fbdev name change on i915 IVB
by Johannes Stezenbach 07 Oct '21

07 Oct '21

Hi, yesterday I updated the kernel from 5.13.7 to 5.14.9 and found it broke suspend-to-RAM. The machine displays a few messages on text console after resume but hangs when switching to X11. The hardware: Asus P8H77-V with Intel Core i5-3550 CPU, display connected via DP. DP1 connected primary 1920x1200+0+0 (normal left inverted right x axis y axis) 520mm x 320mm 1920x1200 59.95*+ I bisected it and the offending commit is the totally unlikely and innocent looking commit b3484d2b03e4c940a9598aa841a52d69729c582a Author: Javier Martinez Canillas <javierm(a)redhat.com> Date: Tue May 25 17:13:13 2021 +0200 drm/fb-helper: improve DRM fbdev emulation device names Now I'm running 5.14.9 with this commit reverted and suspend works. In /var/log/kern.log I found this on suspend: [ 34.002252][ T3455] ------------[ cut here ]------------ [ 34.002256][ T3455] i915 0000:00:02.0: drm_WARN_ON((intel_de_read(dev_priv, intel_dp->output_reg) & (1 << 31)) == 0) [ 34.002274][ T3455] WARNING: CPU: 0 PID: 3455 at drivers/gpu/drm/i915/display/g4x_dp.c:431 intel_dp_link_down.isra.0+0x2e7/0x390 [ 34.002285][ T3455] Modules linked in: kvm_intel kvm irqbypass ehci_pci xhci_pci ehci_hcd xhci_hcd [ 34.002304][ T3455] CPU: 0 PID: 3455 Comm: kworker/u8:27 Not tainted 5.14.9 #29 [ 34.002309][ T3455] Hardware name: System manufacturer System Product Name/P8H77-V, BIOS 1905 10/27/2014 [ 34.002312][ T3455] Workqueue: events_unbound async_run_entry_fn [ 34.002320][ T3455] RIP: 0010:intel_dp_link_down.isra.0+0x2e7/0x390 [ 34.002326][ T3455] Code: 4c 8b 67 50 4d 85 e4 75 03 4c 8b 27 e8 d2 19 05 00 48 c7 c1 e8 53 8c 88 4c 89 e2 48 c7 c7 7b 83 89 88 48 89 c6 e8 d1 d0 52 00 <0f> 0b 48 83 c4 08 5b 5d 41 5c 41 5d 41 5e 41 5f c3 49 8b 7d 08 4c [ 34.002330][ T3455] RSP: 0018:ffffaa1dc1be3a88 EFLAGS: 00010282 [ 34.002335][ T3455] RAX: 0000000000000000 RBX: ffffa15a45f28000 RCX: 0000000000000000 [ 34.002338][ T3455] RDX: 0000000000000001 RSI: ffffffff8714af2f RDI: ffffffff8714af2f [ 34.002341][ T3455] RBP: 0000000080180344 R08: 00000007eab15173 R09: 0000000000000001 [ 34.002344][ T3455] R10: 0000000000080000 R11: 0000000000000000 R12: ffffa15a40f87180 [ 34.002347][ T3455] R13: ffffa15a464e0000 R14: ffffa15a593c6000 R15: 0000000000000001 [ 34.002350][ T3455] FS: 0000000000000000(0000) GS:ffffa15d4f800000(0000) knlGS:0000000000000000 [ 34.002354][ T3455] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 34.002357][ T3455] CR2: 000056000d53cf60 CR3: 000000015fa2a006 CR4: 00000000001706f0 [ 34.002361][ T3455] Call Trace: [ 34.002373][ T3455] g4x_post_disable_dp+0x2e/0x110 [ 34.002380][ T3455] intel_encoders_post_disable+0x73/0x80 [ 34.002391][ T3455] ilk_crtc_disable+0x96/0x3a0 [ 34.002402][ T3455] intel_old_crtc_state_disables+0x5c/0x110 [ 34.002412][ T3455] intel_atomic_commit_tail+0xdcc/0x1410 [ 34.002434][ T3455] intel_atomic_commit+0x332/0x3b0 [ 34.002443][ T3455] drm_atomic_helper_disable_all+0x175/0x190 [ 34.002453][ T3455] drm_atomic_helper_suspend+0xa6/0x200 [ 34.002474][ T3455] intel_display_suspend+0x23/0x50 [ 34.002480][ T3455] i915_drm_suspend+0x42/0xe0 [ 34.002488][ T3455] pci_pm_suspend+0x74/0x160 [ 34.002496][ T3455] ? pci_pm_freeze+0xb0/0xb0 [ 34.002500][ T3455] dpm_run_callback+0x6f/0x170 [ 34.002512][ T3455] __device_suspend+0x110/0x4b0 [ 34.002521][ T3455] async_suspend+0x1b/0x90 [ 34.002529][ T3455] async_run_entry_fn+0x2e/0x110 [ 34.002535][ T3455] process_one_work+0x2c9/0x550 [ 34.002551][ T3455] worker_thread+0x4f/0x3e0 [ 34.002556][ T3455] ? rescuer_thread+0x340/0x340 [ 34.002563][ T3455] kthread+0x14a/0x170 [ 34.002569][ T3455] ? set_kthread_struct+0x40/0x40 [ 34.002578][ T3455] ret_from_fork+0x22/0x30 [ 34.002600][ T3455] ---[ end trace 2058ff589e8cbd78 ]--- and after resume: [ 44.513409][ C0] i915 0000:00:02.0: [drm] *ERROR* uncleared pch fifo underrun on pch transcoder A [ 44.514557][ C0] i915 0000:00:02.0: [drm] *ERROR* PCH transcoder A FIFO underrun [ 54.997256][ T3520] [drm:drm_atomic_helper_wait_for_flip_done] *ERROR* [CRTC:45:pipe A] flip_done timed out Scratching my head about it I found one hint in /usr/lib/pm-utils/sleep.d/98video-quirk-db-handler: using_kms() { grep -q -E '(nouveau|drm)fb' /proc/fb; } So the ABI change in /proc/fb causes the pm-utils scripts to skip the --quirk-no-chvt and apply other quirks, /var/log/pm-suspend.log says: Running hook /usr/lib/pm-utils/sleep.d/98video-quirk-db-handler suspend suspend: No quirk database entry for this system, using default. /usr/lib/pm-utils/sleep.d/98video-quirk-db-handler suspend suspend: success. Running hook /usr/lib/pm-utils/sleep.d/98video-quirk-db-handler resume suspend: Saving last known working quirks: --quirk-vbe-post --quirk-dpms-on --quirk-dpms-suspend --quirk-vbestate-restore --quirk-vbemode-restore --quirk-vga-mode-3 /usr/lib/pm-utils/sleep.d/98video-quirk-db-handler resume suspend: success. whereas in the normal case it's Running hook /usr/lib/pm-utils/sleep.d/98video-quirk-db-handler suspend suspend: Kernel modesetting video driver detected, not using quirks. /usr/lib/pm-utils/sleep.d/98video-quirk-db-handler suspend suspend: success. Running hook /usr/lib/pm-utils/sleep.d/98video-quirk-db-handler resume suspend: /usr/lib/pm-utils/sleep.d/98video-quirk-db-handler resume suspend: success. Johannes

3 3

[PATCH v7 0/2] Add p2p via dmabuf to habanalabs
by Oded Gabbay 07 Oct '21

07 Oct '21

Hi, I'm sending v7 after the latest review from Jason. All the changes are detailed in the commit messages. Dave, I'll appreciate if you can also a-b this patchset. Thanks, Oded Oded Gabbay (1): habanalabs: define uAPI to export FD for DMA-BUF Tomer Tayar (1): habanalabs: add support for dma-buf exporter drivers/misc/habanalabs/Kconfig | 1 + drivers/misc/habanalabs/common/habanalabs.h | 22 + drivers/misc/habanalabs/common/memory.c | 514 +++++++++++++++++++- drivers/misc/habanalabs/gaudi/gaudi.c | 1 + drivers/misc/habanalabs/goya/goya.c | 1 + include/uapi/misc/habanalabs.h | 28 +- 6 files changed, 563 insertions(+), 4 deletions(-) -- 2.17.1

1 3

[PATCH v3] drm/plane-helper: fix uninitialized variable reference
by Alex Xu (Hello71) 07 Oct '21

07 Oct '21

drivers/gpu/drm/drm_plane_helper.c: In function 'drm_primary_helper_update': drivers/gpu/drm/drm_plane_helper.c:113:32: error: 'visible' is used uninitialized [-Werror=uninitialized] 113 | struct drm_plane_state plane_state = { | ^~~~~~~~~~~ drivers/gpu/drm/drm_plane_helper.c:178:14: note: 'visible' was declared here 178 | bool visible; | ^~~~~~~ cc1: all warnings being treated as errors visible is an output, not an input. in practice this use might turn out OK but it's still UB. Fixes: df86af9133 ("drm/plane-helper: Add drm_plane_helper_check_state()") Reviewed-by: Simon Ser <contact(a)emersion.fr> Signed-off-by: Alex Xu (Hello71) <alex_y_xu(a)yahoo.ca> --- drivers/gpu/drm/drm_plane_helper.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/drm_plane_helper.c b/drivers/gpu/drm/drm_plane_helper.c index 5b2d0ca03705..838b32b70bce 100644 --- a/drivers/gpu/drm/drm_plane_helper.c +++ b/drivers/gpu/drm/drm_plane_helper.c @@ -123,7 +123,6 @@ static int drm_plane_helper_check_update(struct drm_plane *plane, .crtc_w = drm_rect_width(dst), .crtc_h = drm_rect_height(dst), .rotation = rotation, - .visible = *visible, }; struct drm_crtc_state crtc_state = { .crtc = crtc, -- 2.33.0

2 1

[PATCH] drm/i915: Free the returned object of acpi_evaluate_dsm()
by Zenghui Yu 07 Oct '21

07 Oct '21

As per the comment on top of acpi_evaluate_dsm(): | * Evaluate device's _DSM method with specified GUID, revision id and | * function number. Caller needs to free the returned object. We should free the returned object of acpi_evaluate_dsm() to avoid memory leakage. Otherwise the kmemleak splat will be triggered at boot time (if we compile kernel with CONFIG_DEBUG_TEST_DRIVER_REMOVE=y). Fixes: 8e55f99c510f ("drm/i915: Invoke another _DSM to enable MUX on HP Workstation laptops") Cc: Kai-Heng Feng <kai.heng.feng(a)canonical.com> Signed-off-by: Zenghui Yu <yuzenghui(a)huawei.com> --- drivers/gpu/drm/i915/display/intel_acpi.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c index 7cfe91fc05f2..68abeaf2d7d4 100644 --- a/drivers/gpu/drm/i915/display/intel_acpi.c +++ b/drivers/gpu/drm/i915/display/intel_acpi.c @@ -186,13 +186,16 @@ void intel_dsm_get_bios_data_funcs_supported(struct drm_i915_private *i915) { struct pci_dev *pdev = to_pci_dev(i915->drm.dev); acpi_handle dhandle; + union acpi_object *obj; dhandle = ACPI_HANDLE(&pdev->dev); if (!dhandle) return; - acpi_evaluate_dsm(dhandle, &intel_dsm_guid2, INTEL_DSM_REVISION_ID, - INTEL_DSM_FN_GET_BIOS_DATA_FUNCS_SUPPORTED, NULL); + obj = acpi_evaluate_dsm(dhandle, &intel_dsm_guid2, INTEL_DSM_REVISION_ID, + INTEL_DSM_FN_GET_BIOS_DATA_FUNCS_SUPPORTED, NULL); + if (obj) + ACPI_FREE(obj); } /* -- 2.19.1

2 2

[PULL] drm-intel-fixes
by Jani Nikula 07 Oct '21

07 Oct '21

Hi Dave & Daniel - drm-intel-fixes-2021-10-07: drm/i915 fixes for v5.15-rc5: - Fix RKL HDMI audio - Fix runtime pm imbalance on i915_gem_shrink() error path - Fix Type-C port access before hw/sw state sync - Fix VBT backlight struct version/size check - Fix VT-d async flip on SKL/BXT with plane stretch workaround BR, Jani. The following changes since commit 9e1ff307c779ce1f0f810c7ecce3d95bbae40896: Linux 5.15-rc4 (2021-10-03 14:08:47 -0700) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2021-10-07 for you to fetch changes up to b2d73debfdc16b742e64948dc4461876af3f8c10: drm/i915: Extend the async flip VT-d w/a to skl/bxt (2021-10-05 11:52:48 +0300) ---------------------------------------------------------------- drm/i915 fixes for v5.15-rc5: - Fix RKL HDMI audio - Fix runtime pm imbalance on i915_gem_shrink() error path - Fix Type-C port access before hw/sw state sync - Fix VBT backlight struct version/size check - Fix VT-d async flip on SKL/BXT with plane stretch workaround ---------------------------------------------------------------- Imre Deak (1): drm/i915/tc: Fix TypeC port init/resume time sanitization Kai-Heng Feng (1): drm/i915/audio: Use BIOS provided value for RKL HDA link Lukasz Majczak (1): drm/i915/bdb: Fix version check Maarten Lankhorst (1): drm/i915: Fix runtime pm handling in i915_gem_shrink Ville Syrjälä (1): drm/i915: Extend the async flip VT-d w/a to skl/bxt drivers/gpu/drm/i915/display/icl_dsi.c | 10 ++++++++-- drivers/gpu/drm/i915/display/intel_audio.c | 5 +++-- drivers/gpu/drm/i915/display/intel_bios.c | 22 ++++++++++++++++------ drivers/gpu/drm/i915/display/intel_ddi.c | 8 +++++++- drivers/gpu/drm/i915/display/intel_display.c | 20 +++++--------------- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 5 +++++ drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 7 +++++-- drivers/gpu/drm/i915/i915_reg.h | 5 +++++ drivers/gpu/drm/i915/intel_pm.c | 12 ++++++++++++ 9 files changed, 66 insertions(+), 28 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center

1 0

[PATCH v2 0/4] drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers
by Lyude Paul 07 Oct '21

07 Oct '21

When I originally moved all of the VESA backlight code in i915 into DRM helpers, one of the things I didn't have the hardware or time for testing was machines that used a combination of PWM and DPCD in order to control their backlights. This has since then caused some breakages and resulted in us disabling DPCD backlight support on such machines. This works fine, unless you have a machine that actually needs this functionality for backlight controls to work at all. Additionally, we will need to support PWM for when we start adding support for VESA's product (as in the product of multiplication) control mode for better brightness ranges. So - let's finally finish up implementing basic support for these types of backlights to solve these problems in our DP helpers, along with implementing support for this in i915. And since digging into this issue solved the last questions we really had about probing backlights in i915 for the most part, let's update some of the comments around that as well! Changes: * Fixup docs * Add patch to stop us from breaking nouveau Lyude Paul (4): drm/i915: Add support for panels with VESA backlights with PWM enable/disable drm/nouveau/kms/nv50-: Explicitly check DPCD backlights for aux enable/brightness drm/dp, drm/i915: Add support for VESA backlights using PWM for brightness control drm/i915: Clarify probing order in intel_dp_aux_init_backlight_funcs() drivers/gpu/drm/drm_dp_helper.c | 75 +++++++++++------ .../drm/i915/display/intel_dp_aux_backlight.c | 80 ++++++++++++++----- drivers/gpu/drm/nouveau/nouveau_backlight.c | 5 +- include/drm/drm_dp_helper.h | 7 +- 4 files changed, 122 insertions(+), 45 deletions(-) -- 2.31.1

2 8

[tegra-drm:drm/tegra/for-next 5/12] drivers/gpu/host1x/job.c:141:30: warning: variable 'domain' set but not used
by kernel test robot 07 Oct '21

07 Oct '21

tree: git://anongit.freedesktop.org/tegra/linux.git drm/tegra/for-next head: 29e08b1e60b429c2bb30a1578db4a2db354d8a36 commit: df77f99c7c11f1cfc37ba071e7efa3ad0d46d986 [5/12] drm/tegra: Implement correct DMA-BUF semantics config: arm-randconfig-c002-20211004 (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git remote add tegra-drm git://anongit.freedesktop.org/tegra/linux.git git fetch --no-tags tegra-drm drm/tegra/for-next git checkout df77f99c7c11f1cfc37ba071e7efa3ad0d46d986 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> All warnings (new ones prefixed by >>): drivers/gpu/host1x/job.c: In function 'pin_job': >> drivers/gpu/host1x/job.c:141:30: warning: variable 'domain' set but not used [-Wunused-but-set-variable] 141 | struct iommu_domain *domain; | ^~~~~~ vim +/domain +141 drivers/gpu/host1x/job.c e902585fc8b639f1 Mikko Perttunen 2021-06-10 134 404bfb78daf3beda Mikko Perttunen 2016-12-14 135 static unsigned int pin_job(struct host1x *host, struct host1x_job *job) 6579324a41cc4140 Terje Bergstrom 2013-03-22 136 { df77f99c7c11f1cf Thierry Reding 2021-09-09 137 unsigned long mask = HOST1X_RELOC_READ | HOST1X_RELOC_WRITE; af1cbfb9bf0fe079 Thierry Reding 2019-10-28 138 struct host1x_client *client = job->client; af1cbfb9bf0fe079 Thierry Reding 2019-10-28 139 struct device *dev = client->dev; fd323e9ef0a19112 Dmitry Osipenko 2020-06-29 140 struct host1x_job_gather *g; 273da5a046965ccf Thierry Reding 2020-02-04 @141 struct iommu_domain *domain; 6579324a41cc4140 Terje Bergstrom 2013-03-22 142 unsigned int i; 404bfb78daf3beda Mikko Perttunen 2016-12-14 143 int err; 6579324a41cc4140 Terje Bergstrom 2013-03-22 144 273da5a046965ccf Thierry Reding 2020-02-04 145 domain = iommu_get_domain_for_dev(dev); 6579324a41cc4140 Terje Bergstrom 2013-03-22 146 job->num_unpins = 0; 6579324a41cc4140 Terje Bergstrom 2013-03-22 147 6579324a41cc4140 Terje Bergstrom 2013-03-22 148 for (i = 0; i < job->num_relocs; i++) { 06490bb99e1840ab Thierry Reding 2018-05-16 149 struct host1x_reloc *reloc = &job->relocs[i]; df77f99c7c11f1cf Thierry Reding 2021-09-09 150 enum dma_data_direction direction; df77f99c7c11f1cf Thierry Reding 2021-09-09 151 struct host1x_bo_mapping *map; df77f99c7c11f1cf Thierry Reding 2021-09-09 152 struct host1x_bo *bo; 6579324a41cc4140 Terje Bergstrom 2013-03-22 153 961e3beae3b29ae9 Thierry Reding 2014-06-10 154 reloc->target.bo = host1x_bo_get(reloc->target.bo); 404bfb78daf3beda Mikko Perttunen 2016-12-14 155 if (!reloc->target.bo) { 404bfb78daf3beda Mikko Perttunen 2016-12-14 156 err = -EINVAL; 6579324a41cc4140 Terje Bergstrom 2013-03-22 157 goto unpin; 404bfb78daf3beda Mikko Perttunen 2016-12-14 158 } 6579324a41cc4140 Terje Bergstrom 2013-03-22 159 df77f99c7c11f1cf Thierry Reding 2021-09-09 160 bo = reloc->target.bo; af1cbfb9bf0fe079 Thierry Reding 2019-10-28 161 af1cbfb9bf0fe079 Thierry Reding 2019-10-28 162 switch (reloc->flags & mask) { af1cbfb9bf0fe079 Thierry Reding 2019-10-28 163 case HOST1X_RELOC_READ: df77f99c7c11f1cf Thierry Reding 2021-09-09 164 direction = DMA_TO_DEVICE; af1cbfb9bf0fe079 Thierry Reding 2019-10-28 165 break; af1cbfb9bf0fe079 Thierry Reding 2019-10-28 166 af1cbfb9bf0fe079 Thierry Reding 2019-10-28 167 case HOST1X_RELOC_WRITE: df77f99c7c11f1cf Thierry Reding 2021-09-09 168 direction = DMA_FROM_DEVICE; af1cbfb9bf0fe079 Thierry Reding 2019-10-28 169 break; af1cbfb9bf0fe079 Thierry Reding 2019-10-28 170 af1cbfb9bf0fe079 Thierry Reding 2019-10-28 171 case HOST1X_RELOC_READ | HOST1X_RELOC_WRITE: df77f99c7c11f1cf Thierry Reding 2021-09-09 172 direction = DMA_BIDIRECTIONAL; af1cbfb9bf0fe079 Thierry Reding 2019-10-28 173 break; af1cbfb9bf0fe079 Thierry Reding 2019-10-28 174 af1cbfb9bf0fe079 Thierry Reding 2019-10-28 175 default: af1cbfb9bf0fe079 Thierry Reding 2019-10-28 176 err = -EINVAL; af1cbfb9bf0fe079 Thierry Reding 2019-10-28 177 goto unpin; af1cbfb9bf0fe079 Thierry Reding 2019-10-28 178 } af1cbfb9bf0fe079 Thierry Reding 2019-10-28 179 df77f99c7c11f1cf Thierry Reding 2021-09-09 180 map = host1x_bo_pin(dev, bo, direction); df77f99c7c11f1cf Thierry Reding 2021-09-09 181 if (IS_ERR(map)) { df77f99c7c11f1cf Thierry Reding 2021-09-09 182 err = PTR_ERR(map); af1cbfb9bf0fe079 Thierry Reding 2019-10-28 183 goto unpin; df77f99c7c11f1cf Thierry Reding 2021-09-09 184 } af1cbfb9bf0fe079 Thierry Reding 2019-10-28 185 df77f99c7c11f1cf Thierry Reding 2021-09-09 186 /* df77f99c7c11f1cf Thierry Reding 2021-09-09 187 * host1x clients are generally not able to do scatter-gather themselves, so fail df77f99c7c11f1cf Thierry Reding 2021-09-09 188 * if the buffer is discontiguous and we fail to map its SG table to a single df77f99c7c11f1cf Thierry Reding 2021-09-09 189 * contiguous chunk of I/O virtual memory. df77f99c7c11f1cf Thierry Reding 2021-09-09 190 */ df77f99c7c11f1cf Thierry Reding 2021-09-09 191 if (map->chunks > 1) { df77f99c7c11f1cf Thierry Reding 2021-09-09 192 err = -EINVAL; df77f99c7c11f1cf Thierry Reding 2021-09-09 193 goto unpin; af1cbfb9bf0fe079 Thierry Reding 2019-10-28 194 } af1cbfb9bf0fe079 Thierry Reding 2019-10-28 195 df77f99c7c11f1cf Thierry Reding 2021-09-09 196 job->addr_phys[job->num_unpins] = map->phys; df77f99c7c11f1cf Thierry Reding 2021-09-09 197 job->unpins[job->num_unpins].map = map; 6579324a41cc4140 Terje Bergstrom 2013-03-22 198 job->num_unpins++; 6579324a41cc4140 Terje Bergstrom 2013-03-22 199 } 6579324a41cc4140 Terje Bergstrom 2013-03-22 200 26c8de5e5dea6f42 Dmitry Osipenko 2020-06-29 201 /* 26c8de5e5dea6f42 Dmitry Osipenko 2020-06-29 202 * We will copy gathers BO content later, so there is no need to 26c8de5e5dea6f42 Dmitry Osipenko 2020-06-29 203 * hold and pin them. 26c8de5e5dea6f42 Dmitry Osipenko 2020-06-29 204 */ 0fddaa85d6614046 Mikko Perttunen 2021-06-10 205 if (job->enable_firewall) 26c8de5e5dea6f42 Dmitry Osipenko 2020-06-29 206 return 0; 26c8de5e5dea6f42 Dmitry Osipenko 2020-06-29 207 e902585fc8b639f1 Mikko Perttunen 2021-06-10 208 for (i = 0; i < job->num_cmds; i++) { df77f99c7c11f1cf Thierry Reding 2021-09-09 209 struct host1x_bo_mapping *map; 404bfb78daf3beda Mikko Perttunen 2016-12-14 210 size_t gather_size = 0; 404bfb78daf3beda Mikko Perttunen 2016-12-14 211 struct scatterlist *sg; 404bfb78daf3beda Mikko Perttunen 2016-12-14 212 unsigned long shift; 404bfb78daf3beda Mikko Perttunen 2016-12-14 213 struct iova *alloc; 404bfb78daf3beda Mikko Perttunen 2016-12-14 214 unsigned int j; 6579324a41cc4140 Terje Bergstrom 2013-03-22 215 e902585fc8b639f1 Mikko Perttunen 2021-06-10 216 if (job->cmds[i].is_wait) e902585fc8b639f1 Mikko Perttunen 2021-06-10 217 continue; e902585fc8b639f1 Mikko Perttunen 2021-06-10 218 e902585fc8b639f1 Mikko Perttunen 2021-06-10 219 g = &job->cmds[i].gather; e902585fc8b639f1 Mikko Perttunen 2021-06-10 220 6579324a41cc4140 Terje Bergstrom 2013-03-22 221 g->bo = host1x_bo_get(g->bo); 404bfb78daf3beda Mikko Perttunen 2016-12-14 222 if (!g->bo) { 404bfb78daf3beda Mikko Perttunen 2016-12-14 223 err = -EINVAL; 6579324a41cc4140 Terje Bergstrom 2013-03-22 224 goto unpin; 404bfb78daf3beda Mikko Perttunen 2016-12-14 225 } 6579324a41cc4140 Terje Bergstrom 2013-03-22 226 df77f99c7c11f1cf Thierry Reding 2021-09-09 227 map = host1x_bo_pin(host->dev, g->bo, DMA_TO_DEVICE); df77f99c7c11f1cf Thierry Reding 2021-09-09 228 if (IS_ERR(map)) { df77f99c7c11f1cf Thierry Reding 2021-09-09 229 err = PTR_ERR(map); df77f99c7c11f1cf Thierry Reding 2021-09-09 230 goto unpin; 80327ce3d4edaa9a Thierry Reding 2019-10-28 231 } 404bfb78daf3beda Mikko Perttunen 2016-12-14 232 26c8de5e5dea6f42 Dmitry Osipenko 2020-06-29 233 if (host->domain) { df77f99c7c11f1cf Thierry Reding 2021-09-09 234 for_each_sgtable_sg(map->sgt, sg, j) 404bfb78daf3beda Mikko Perttunen 2016-12-14 235 gather_size += sg->length; df77f99c7c11f1cf Thierry Reding 2021-09-09 236 404bfb78daf3beda Mikko Perttunen 2016-12-14 237 gather_size = iova_align(&host->iova, gather_size); 404bfb78daf3beda Mikko Perttunen 2016-12-14 238 404bfb78daf3beda Mikko Perttunen 2016-12-14 239 shift = iova_shift(&host->iova); 404bfb78daf3beda Mikko Perttunen 2016-12-14 240 alloc = alloc_iova(&host->iova, gather_size >> shift, 404bfb78daf3beda Mikko Perttunen 2016-12-14 241 host->iova_end >> shift, true); 404bfb78daf3beda Mikko Perttunen 2016-12-14 242 if (!alloc) { 404bfb78daf3beda Mikko Perttunen 2016-12-14 243 err = -ENOMEM; fd323e9ef0a19112 Dmitry Osipenko 2020-06-29 244 goto put; 404bfb78daf3beda Mikko Perttunen 2016-12-14 245 } 404bfb78daf3beda Mikko Perttunen 2016-12-14 246 df77f99c7c11f1cf Thierry Reding 2021-09-09 247 err = iommu_map_sgtable(host->domain, iova_dma_addr(&host->iova, alloc), df77f99c7c11f1cf Thierry Reding 2021-09-09 248 map->sgt, IOMMU_READ); 404bfb78daf3beda Mikko Perttunen 2016-12-14 249 if (err == 0) { 404bfb78daf3beda Mikko Perttunen 2016-12-14 250 __free_iova(&host->iova, alloc); 404bfb78daf3beda Mikko Perttunen 2016-12-14 251 err = -EINVAL; fd323e9ef0a19112 Dmitry Osipenko 2020-06-29 252 goto put; 404bfb78daf3beda Mikko Perttunen 2016-12-14 253 } 6579324a41cc4140 Terje Bergstrom 2013-03-22 254 df77f99c7c11f1cf Thierry Reding 2021-09-09 255 map->phys = iova_dma_addr(&host->iova, alloc); df77f99c7c11f1cf Thierry Reding 2021-09-09 256 map->size = gather_size; 404bfb78daf3beda Mikko Perttunen 2016-12-14 257 } 404bfb78daf3beda Mikko Perttunen 2016-12-14 258 df77f99c7c11f1cf Thierry Reding 2021-09-09 259 job->addr_phys[job->num_unpins] = map->phys; df77f99c7c11f1cf Thierry Reding 2021-09-09 260 job->unpins[job->num_unpins].map = map; 6579324a41cc4140 Terje Bergstrom 2013-03-22 261 job->num_unpins++; df77f99c7c11f1cf Thierry Reding 2021-09-09 262 df77f99c7c11f1cf Thierry Reding 2021-09-09 263 job->gather_addr_phys[i] = map->phys; 6579324a41cc4140 Terje Bergstrom 2013-03-22 264 } 6579324a41cc4140 Terje Bergstrom 2013-03-22 265 404bfb78daf3beda Mikko Perttunen 2016-12-14 266 return 0; 6579324a41cc4140 Terje Bergstrom 2013-03-22 267 fd323e9ef0a19112 Dmitry Osipenko 2020-06-29 268 put: fd323e9ef0a19112 Dmitry Osipenko 2020-06-29 269 host1x_bo_put(g->bo); 6579324a41cc4140 Terje Bergstrom 2013-03-22 270 unpin: 6579324a41cc4140 Terje Bergstrom 2013-03-22 271 host1x_job_unpin(job); 404bfb78daf3beda Mikko Perttunen 2016-12-14 272 return err; 6579324a41cc4140 Terje Bergstrom 2013-03-22 273 } 6579324a41cc4140 Terje Bergstrom 2013-03-22 274 :::::: The code at line 141 was first introduced by commit :::::: 273da5a046965ccf0ec79eb63f2d5173467e20fa drm/tegra: Reuse IOVA mapping where possible :::::: TO: Thierry Reding <treding(a)nvidia.com> :::::: CC: Thierry Reding <treding(a)nvidia.com> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 0

[GIT PULL FOR v5.16] R-Car DU & other misc enhancements
by Laurent Pinchart 07 Oct '21

07 Oct '21

Hi Dave and Daniel, The following changes since commit 1e3944578b749449bd7fa6bf0bae4c3d3f5f1733: Merge tag 'amd-drm-next-5.16-2021-09-27' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2021-09-28 17:08:26 +1000) are available in the Git repository at: git://linuxtv.org/pinchartl/media.git tags/du-next-20211007 for you to fetch changes up to b291fdcf51140fef69a9734caaca704d010dd02f: drm: rcar-du: Add r8a779a0 device support (2021-10-07 05:59:54 +0300) ---------------------------------------------------------------- R-Car DU improvements & enhancements to misc drivers Most notably, - Non-contiguous buffer import support for rcar-du - r8a779a0 support preparation for rcar-du - COMPILE_TEST fixes for omapdrm and sti ---------------------------------------------------------------- Cai Huoqing (2): drm/shmobile: Make use of the helper function devm_platform_ioremap_resource() drm: rcar-du: Make use of the helper function devm_platform_ioremap_resource() Kieran Bingham (6): dt-bindings: display: renesas,du: Provide bindings for r8a779a0 drm: rcar-du: Sort the DU outputs drm: rcar-du: Only initialise TVM_TVSYNC mode when supported drm: rcar-du: Fix DIDSR field name drm: rcar-du: Split CRTC IRQ and Clock features drm: rcar-du: Add r8a779a0 device support Laurent Pinchart (9): drm: rcar-du: Don't create encoder for unconnected LVDS outputs drm: rcar-du: Improve kernel log messages when initializing encoders drm: rcar-du: Set the DMA coherent mask for the DU device drm: rcar-du: Allow importing non-contiguous dma-buf with VSP drm: property: Replace strncpy() with strscpy_pad() drm/omap: Use correct printk format specifiers for size_t drm/omap: Cast pointer to integer without generating warning drm/omap: Depend on CONFIG_OF drm/sti: Use correct printk format specifiers for size_t .../devicetree/bindings/display/renesas,du.yaml | 51 ++++++++++ drivers/gpu/drm/drm_property.c | 9 +- drivers/gpu/drm/omapdrm/Kconfig | 2 +- drivers/gpu/drm/omapdrm/dss/dsi.c | 4 +- drivers/gpu/drm/omapdrm/omap_drv.c | 2 +- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 9 +- drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 11 --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 108 +++++++++++++++++---- drivers/gpu/drm/rcar-du/rcar_du_drv.h | 26 ++++- drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 28 ++++-- drivers/gpu/drm/rcar-du/rcar_du_group.c | 6 +- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 50 +++++++++- drivers/gpu/drm/rcar-du/rcar_du_kms.h | 7 ++ drivers/gpu/drm/rcar-du/rcar_du_regs.h | 9 +- drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 36 ++++++- drivers/gpu/drm/rcar-du/rcar_lvds.c | 15 ++- drivers/gpu/drm/rcar-du/rcar_lvds.h | 5 + drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 +- drivers/gpu/drm/sti/sti_hqvdp.c | 4 +- 19 files changed, 308 insertions(+), 78 deletions(-) -- Regards, Laurent Pinchart

1 0

← Newer
1
...
66
67
68
69
70
71
72
...
83
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel October 2021