dri-devel October 2021

dri-devel@lists.freedesktop.org

347 participants
825 discussions

[RFC] drm/msm/dp: Add typec_mux implementation
by Bjorn Andersson 05 Oct '21

05 Oct '21

Implement a typec_mux in order to allow a Type-C controller to signal the connection and attention of DisplayPort to the related USB-C port. The remains of support for something along this lines was left in the dp_display as the driver was upstreamed, so these are reused with minimal modifications necessary. When operating in this mode, HPD interrupts has still been observed in the ISR so, in line with the downstream kernel, these are ignored. Signed-off-by: Bjorn Andersson <bjorn.andersson(a)linaro.org> --- This applies on top of https://lore.kernel.org/linux-arm-msm/20211001180058.1021913-1-bjorn.anders… drivers/gpu/drm/msm/Kconfig | 1 + drivers/gpu/drm/msm/dp/dp_display.c | 52 ++++++++++++++++----------- drivers/gpu/drm/msm/dp/dp_hpd.c | 54 +++++++++++++++++++++++++++++ 3 files changed, 87 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig index 5879f67bc88c..4e4b98c448cb 100644 --- a/drivers/gpu/drm/msm/Kconfig +++ b/drivers/gpu/drm/msm/Kconfig @@ -9,6 +9,7 @@ config DRM_MSM depends on QCOM_OCMEM || QCOM_OCMEM=n depends on QCOM_LLCC || QCOM_LLCC=n depends on QCOM_COMMAND_DB || QCOM_COMMAND_DB=n + depends on TYPEC || TYPEC=n select IOMMU_IO_PGTABLE select QCOM_MDT_LOADER if ARCH_QCOM select REGULATOR diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 56a79aeffed4..e863f537047a 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -85,6 +85,8 @@ struct dp_display_private { bool hpd_irq_on; bool audio_supported; + bool use_hw_hpd; + struct platform_device *pdev; struct dentry *root; @@ -466,11 +468,10 @@ static int dp_display_handle_irq_hpd(struct dp_display_private *dp) return 0; } -static int dp_display_usbpd_attention_cb(struct device *dev) +static int dp_display_usbpd_attention(struct dp_display_private *dp) { int rc = 0; u32 sink_request; - struct dp_display_private *dp = dev_get_dp_display_private(dev); /* check for any test request issued by sink */ rc = dp_link_process_request(dp->link); @@ -690,7 +691,7 @@ static int dp_irq_hpd_handle(struct dp_display_private *dp, u32 data) return 0; } - ret = dp_display_usbpd_attention_cb(&dp->pdev->dev); + ret = dp_display_usbpd_attention(dp); if (ret == -ECONNRESET) { /* cable unplugged */ dp->core_initialized = false; } @@ -709,6 +710,13 @@ static void dp_display_deinit_sub_modules(struct dp_display_private *dp) dp_audio_put(dp->audio); } +static int dp_display_usbpd_attention_cb(struct device *dev) +{ + struct dp_display_private *dp = dev_get_dp_display_private(dev); + + return dp_irq_hpd_handle(dp, 0); +} + static int dp_init_sub_modules(struct dp_display_private *dp) { int rc = 0; @@ -731,6 +739,8 @@ static int dp_init_sub_modules(struct dp_display_private *dp) goto error; } + dp->use_hw_hpd = !of_property_read_bool(dev->of_node, "mode-switch"); + dp->parser = dp_parser_get(dp->pdev); if (IS_ERR(dp->parser)) { rc = PTR_ERR(dp->parser); @@ -1135,27 +1145,29 @@ static irqreturn_t dp_display_irq_handler(int irq, void *dev_id) return IRQ_NONE; } - hpd_isr_status = dp_catalog_hpd_get_intr_status(dp->catalog); + if (dp->use_hw_hpd) { + hpd_isr_status = dp_catalog_hpd_get_intr_status(dp->catalog); - DRM_DEBUG_DP("hpd isr status=%#x\n", hpd_isr_status); - if (hpd_isr_status & 0x0F) { - /* hpd related interrupts */ - if (hpd_isr_status & DP_DP_HPD_PLUG_INT_MASK) - dp_add_event(dp, EV_HPD_PLUG_INT, 0, 0); + DRM_DEBUG_DP("hpd isr status=%#x\n", hpd_isr_status); + if (hpd_isr_status & 0x0F) { + /* hpd related interrupts */ + if (hpd_isr_status & DP_DP_HPD_PLUG_INT_MASK) + dp_add_event(dp, EV_HPD_PLUG_INT, 0, 0); - if (hpd_isr_status & DP_DP_IRQ_HPD_INT_MASK) { - /* stop sentinel connect pending checking */ - dp_del_event(dp, EV_CONNECT_PENDING_TIMEOUT); - dp_add_event(dp, EV_IRQ_HPD_INT, 0, 0); - } + if (hpd_isr_status & DP_DP_IRQ_HPD_INT_MASK) { + /* stop sentinel connect pending checking */ + dp_del_event(dp, EV_CONNECT_PENDING_TIMEOUT); + dp_add_event(dp, EV_IRQ_HPD_INT, 0, 0); + } - if (hpd_isr_status & DP_DP_HPD_REPLUG_INT_MASK) { - dp_add_event(dp, EV_HPD_UNPLUG_INT, 0, 0); - dp_add_event(dp, EV_HPD_PLUG_INT, 0, 3); - } + if (hpd_isr_status & DP_DP_HPD_REPLUG_INT_MASK) { + dp_add_event(dp, EV_HPD_UNPLUG_INT, 0, 0); + dp_add_event(dp, EV_HPD_PLUG_INT, 0, 3); + } - if (hpd_isr_status & DP_DP_HPD_UNPLUG_INT_MASK) - dp_add_event(dp, EV_HPD_UNPLUG_INT, 0, 0); + if (hpd_isr_status & DP_DP_HPD_UNPLUG_INT_MASK) + dp_add_event(dp, EV_HPD_UNPLUG_INT, 0, 0); + } } /* DP controller isr */ diff --git a/drivers/gpu/drm/msm/dp/dp_hpd.c b/drivers/gpu/drm/msm/dp/dp_hpd.c index e1c90fa47411..2a7ed9b8354e 100644 --- a/drivers/gpu/drm/msm/dp/dp_hpd.c +++ b/drivers/gpu/drm/msm/dp/dp_hpd.c @@ -7,6 +7,9 @@ #include <linux/slab.h> #include <linux/device.h> +#include <linux/usb/typec_altmode.h> +#include <linux/usb/typec_dp.h> +#include <linux/usb/typec_mux.h> #include "dp_hpd.h" @@ -22,6 +25,8 @@ struct dp_hpd_private { struct device *dev; struct dp_usbpd_cb *dp_cb; struct dp_usbpd dp_usbpd; + struct typec_mux *mux; + bool connected; }; int dp_hpd_connect(struct dp_usbpd *dp_usbpd, bool hpd) @@ -47,9 +52,45 @@ int dp_hpd_connect(struct dp_usbpd *dp_usbpd, bool hpd) return rc; } +static int dp_hpd_mux_set(struct typec_mux *mux, struct typec_mux_state *state) +{ + struct dp_hpd_private *dp_hpd = typec_mux_get_drvdata(mux); + struct dp_usbpd *usbpd = &dp_hpd->dp_usbpd; + struct typec_displayport_data *dp_data = state->data; + int pin_assign = 0; + + if (dp_data) { + pin_assign = DP_CONF_GET_PIN_ASSIGN(dp_data->conf); + usbpd->hpd_high = !!(dp_data->status & DP_STATUS_HPD_STATE); + usbpd->hpd_irq = !!(dp_data->status & DP_STATUS_IRQ_HPD); + usbpd->multi_func = pin_assign == DP_PIN_ASSIGN_C || DP_PIN_ASSIGN_E; + } + + if (!pin_assign) { + if (dp_hpd->connected) { + dp_hpd->connected = false; + dp_hpd->dp_cb->disconnect(dp_hpd->dev); + } + } else if (!dp_hpd->connected) { + dp_hpd->connected = true; + dp_hpd->dp_cb->configure(dp_hpd->dev); + } else { + dp_hpd->dp_cb->attention(dp_hpd->dev); + } + + return 0; +} + +static void dp_hpd_unregister_typec_mux(void *data) +{ + typec_mux_unregister(data); +} + struct dp_usbpd *dp_hpd_get(struct device *dev, struct dp_usbpd_cb *cb) { + struct typec_mux_desc mux_desc = {}; struct dp_hpd_private *dp_hpd; + int rc; if (!cb) { pr_err("invalid cb data\n"); @@ -65,5 +106,18 @@ struct dp_usbpd *dp_hpd_get(struct device *dev, struct dp_usbpd_cb *cb) dp_hpd->dp_usbpd.connect = dp_hpd_connect; + mux_desc.fwnode = dev->fwnode; + mux_desc.set = dp_hpd_mux_set; + mux_desc.drvdata = dp_hpd; + dp_hpd->mux = typec_mux_register(dev, &mux_desc); + if (IS_ERR(dp_hpd->mux)) { + dev_err(dev, "unable to register typec mux\n"); + return ERR_CAST(dp_hpd->mux); + } + + rc = devm_add_action_or_reset(dev, dp_hpd_unregister_typec_mux, dp_hpd->mux); + if (rc) + return ERR_PTR(rc); + return &dp_hpd->dp_usbpd; } -- 2.29.2

1 0

linux-next: manual merge of the drm-msm tree with the drm tree
by Stephen Rothwell 05 Oct '21

05 Oct '21

Hi all, Today's linux-next merge of the drm-msm tree got a conflict in: drivers/gpu/drm/msm/msm_gem_submit.c between commit: 0e10e9a1db23 ("drm/sched: drop entity parameter from drm_sched_push_job") from the drm tree and commit: 68002469e571 ("drm/msm: One sched entity per process per priority") from the drm-msm tree. The conflict was this: /* The scheduler owns a ref now: */ msm_gem_submit_get(submit); <<<<<<< HEAD drm_sched_entity_push_job(&submit->base); ======= drm_sched_entity_push_job(&submit->base, queue->entity); >>>>>>> drm-msm/msm-next args->fence = submit->fence_id; I fixed it up (I just used the HEAD version) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts. -- Cheers, Stephen Rothwell

1 0

[Bug 206349] New: WARNING: dcn20_validate_bandwidth+0x87/0x9e [ amdgpu on 5700 XT ]
by bugzilla-daemon＠bugzilla.kernel.org 05 Oct '21

05 Oct '21

https://bugzilla.kernel.org/show_bug.cgi?id=206349 Bug ID: 206349 Summary: WARNING: dcn20_validate_bandwidth+0x87/0x9e [ amdgpu on 5700 XT ] Product: Drivers Version: 2.5 Kernel Version: 5.5.0 Hardware: x86-64 OS: Linux Tree: Mainline Status: NEW Severity: low Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: doublej472(a)gmail.com Regression: No Created attachment 287027 --> https://bugzilla.kernel.org/attachment.cgi?id=287027&action=edit dmesg warnings from amdgpu I've been seeing this warning pop up in my dmesg for a while from amdgpu, all relating to dcn20_validate_bandwidth. I'm not sure if it's affecting my machine in a significant manner, but it keeps showing up. [ 8236.203353] arch-desktop kernel: ------------[ cut here ]------------ [ 8236.203403] arch-desktop kernel: WARNING: CPU: 9 PID: 555 at drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:2959 dcn20_validate_bandwidth+0x87/0x9e [amdgpu] [ 8236.203405] arch-desktop kernel: Modules linked in: bridge stp llc bcache crc64 raid1 snd_usb_audio snd_usbmidi_lib kvm_amd snd_rawmidi kvm amdgpu gpu_sched k10temp ttm sch_fq_codel efivarfs [ 8236.203414] arch-desktop kernel: CPU: 9 PID: 555 Comm: Xorg Not tainted 5.5.0-gentoo #1 [ 8236.203415] arch-desktop kernel: Hardware name: System manufacturer System Product Name/PRIME X370-PRO, BIOS 5220 09/12/2019 [ 8236.203451] arch-desktop kernel: RIP: 0010:dcn20_validate_bandwidth+0x87/0x9e [amdgpu] [ 8236.203453] arch-desktop kernel: Code: 00 00 01 eb 29 31 d2 f2 0f 11 85 70 21 00 00 48 89 ee e8 e9 f7 ff ff 89 c2 22 85 b8 1d 00 00 74 09 c6 85 b8 1d 00 00 00 eb 04 <0f> 0b 89 d0 f2 0f 10 1c 24 f2 0f 11 9d 70 21 00 00 48 83 c4 10 5d [ 8236.203455] arch-desktop kernel: RSP: 0018:ffff8e9800c9fa80 EFLAGS: 00010246 [ 8236.203457] arch-desktop kernel: RAX: 0000000000000000 RBX: ffff8b19d3f6b900 RCX: 0000000000215f49 [ 8236.203458] arch-desktop kernel: RDX: 0000000000000001 RSI: 0000000000215f09 RDI: 000000000002e300 [ 8236.203460] arch-desktop kernel: RBP: ffff8b17ee190000 R08: ffff8b1b7b406840 R09: ffffffffc0345b6b [ 8236.203461] arch-desktop kernel: R10: ffff8b1b66e6a000 R11: ffff8b1b66e6a000 R12: 0000000000000000 [ 8236.203462] arch-desktop kernel: R13: 0000000000000000 R14: ffff8b17ee190000 R15: 0000000000000002 [ 8236.203464] arch-desktop kernel: FS: 00007ff890a4e980(0000) GS:ffff8b1b7ea40000(0000) knlGS:0000000000000000 [ 8236.203465] arch-desktop kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 8236.203467] arch-desktop kernel: CR2: 00005620d7c8eef0 CR3: 00000007e2886000 CR4: 0000000000340ee0 [ 8236.203468] arch-desktop kernel: Call Trace: [ 8236.203504] arch-desktop kernel: dc_validate_global_state+0x1b6/0x1d7 [amdgpu] [ 8236.203549] arch-desktop kernel: amdgpu_dm_atomic_check+0x52a/0x666 [amdgpu] [ 8236.203556] arch-desktop kernel: drm_atomic_check_only+0x586/0x62e [ 8236.203559] arch-desktop kernel: ? drm_atomic_set_crtc_for_connector+0xd9/0xe1 [ 8236.203562] arch-desktop kernel: drm_atomic_commit+0xe/0x44 [ 8236.203565] arch-desktop kernel: drm_atomic_helper_set_config+0x50/0x66 [ 8236.203569] arch-desktop kernel: drm_mode_setcrtc+0x221/0x5dc [ 8236.203574] arch-desktop kernel: ? drm_mode_getcrtc+0x145/0x145 [ 8236.203576] arch-desktop kernel: drm_ioctl_kernel+0x8d/0xe1 [ 8236.203579] arch-desktop kernel: drm_ioctl+0x1f9/0x2d3 [ 8236.203582] arch-desktop kernel: ? drm_mode_getcrtc+0x145/0x145 [ 8236.203613] arch-desktop kernel: amdgpu_drm_ioctl+0x45/0x71 [amdgpu] [ 8236.203617] arch-desktop kernel: vfs_ioctl+0x19/0x26 [ 8236.203620] arch-desktop kernel: do_vfs_ioctl+0x574/0x59e [ 8236.203623] arch-desktop kernel: ksys_ioctl+0x49/0x68 [ 8236.203626] arch-desktop kernel: __x64_sys_ioctl+0x11/0x14 [ 8236.203629] arch-desktop kernel: do_syscall_64+0x48/0x55 [ 8236.203632] arch-desktop kernel: entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 8236.203634] arch-desktop kernel: RIP: 0033:0x7ff890d0b5c7 [ 8236.203636] arch-desktop kernel: Code: 00 00 00 75 0c 48 c7 c0 ff ff ff ff 48 83 c4 18 c3 e8 0d c8 01 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 99 e8 0c 00 f7 d8 64 89 01 48 [ 8236.203638] arch-desktop kernel: RSP: 002b:00007ffea4921a48 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 [ 8236.203639] arch-desktop kernel: RAX: ffffffffffffffda RBX: 00007ffea4921a80 RCX: 00007ff890d0b5c7 [ 8236.203641] arch-desktop kernel: RDX: 00007ffea4921a80 RSI: 00000000c06864a2 RDI: 000000000000000c [ 8236.203642] arch-desktop kernel: RBP: 00000000c06864a2 R08: 0000000000000000 R09: 0000000000000000 [ 8236.203643] arch-desktop kernel: R10: 0000000000000000 R11: 0000000000000246 R12: 00005620d7fe1e70 [ 8236.203644] arch-desktop kernel: R13: 000000000000000c R14: 00005620d8e342f0 R15: 00005620d6dc2040 [ 8236.203649] arch-desktop kernel: ---[ end trace 82184d8b2d613936 ]--- I've attached a few more warnings to this bug report. I'm not sure what causes this warning. It *might* happen whenever the GPU is being used, if I leave the machine alone it tends to not show. It could be related to waking up my monitor? (Attached to a DisplayPort cable, running at 1920x1080 @ 144 Hz, if that matters) My system is running on an ASUS PRIME X370-PRO motherboard with a ryzen 3900x, 32GB of ram, and a 5700 XT GPU (on a PCIe 3.0 x16 link). Please let me know if you need more info! -- You are receiving this mail because: You are watching the assignee of the bug.

1 1

[PATCH V4 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select
by Marek Vasut 05 Oct '21

05 Oct '21

Decoder input LVDS format is a property of the decoder chip or even its strapping. Add DT property data-mapping the same way lvds-panel does, to define the LVDS data mapping. Signed-off-by: Marek Vasut <marex(a)denx.de> Cc: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> Cc: Rob Herring <robh+dt(a)kernel.org> Cc: Sam Ravnborg <sam(a)ravnborg.org> Cc: devicetree(a)vger.kernel.org To: dri-devel(a)lists.freedesktop.org --- V2: - Use allOf - Move the data-mapping to endpoint V3: - Rebase on V2 submitted a while ago, reinstate changelog - Drop the allOf and un-rebase on previous pclk patch V4: - port@1, remove $ref: /schemas/graph.yaml#/properties/port and add $ref: /schemas/graph.yaml#/$defs/port-base --- .../bindings/display/bridge/lvds-codec.yaml | 33 ++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml index 304a1367faaa7..c0400c60f272a 100644 --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml @@ -55,11 +55,26 @@ properties: For LVDS decoders, port 0 is the LVDS input port@1: - $ref: /schemas/graph.yaml#/properties/port + $ref: /schemas/graph.yaml#/$defs/port-base description: | For LVDS encoders, port 1 is the LVDS output For LVDS decoders, port 1 is the parallel output + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-mapping: + enum: + - jeida-18 + - jeida-24 + - vesa-24 + description: | + The color signals mapping order. See details in + Documentation/devicetree/bindings/display/panel/lvds.yaml + required: - port@0 - port@1 @@ -71,6 +86,22 @@ properties: power-supply: true +if: + not: + properties: + compatible: + contains: + const: lvds-decoder +then: + properties: + ports: + properties: + port@1: + properties: + endpoint: + properties: + data-mapping: false + required: - compatible - ports -- 2.30.2

3 6

[Bug 213201] New: [KAVERI] memory leak - unreferenced object 0xffff8881700cf988 (size 56)
by bugzilla-daemon＠bugzilla.kernel.org 04 Oct '21

04 Oct '21

https://bugzilla.kernel.org/show_bug.cgi?id=213201 Bug ID: 213201 Summary: [KAVERI] memory leak - unreferenced object 0xffff8881700cf988 (size 56) Product: Drivers Version: 2.5 Kernel Version: 5.13-rc3 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: erhard_f(a)mailbox.org CC: daniel(a)ffwll.ch Regression: No Created attachment 296967 --> https://bugzilla.kernel.org/attachment.cgi?id=296967&action=edit kernel dmesg (5.13-rc3, AMD A10 PRO-7800B) Get this shortly after booting kernel 5.13-rc3. Looks like amdgpu is involved: unreferenced object 0xffff8881700cf988 (size 56): comm "systemd-udevd", pid 216, jiffies 4294885043 (age 1739.830s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 0d 01 70 00 00 00 00 00 ..........p..... 7b 98 01 00 00 c9 ff ff 00 00 00 00 00 00 00 00 {............... backtrace: [<00000000f3e5fc85>] kmem_cache_alloc+0x10a/0x1e4 [<00000000fff767c3>] acpi_ps_alloc_op+0x4e/0xdc [<00000000445cacf1>] acpi_ps_create_op+0x24e/0x473 [<000000003452a27a>] acpi_ps_parse_loop+0x25e/0xa39 [<000000004e3469e0>] acpi_ps_parse_aml+0xf3/0x450 [<00000000be1f7fd0>] acpi_ps_execute_method+0x278/0x2bb [<000000004564e9a8>] acpi_ns_evaluate+0x34f/0x45d [<0000000072f73c39>] acpi_evaluate_object+0x201/0x3b5 [<0000000036379e33>] amdgpu_atcs_call+0x11d/0x19b [amdgpu] [<00000000829cc77d>] amdgpu_acpi_init+0xf3/0x7b8 [amdgpu] [<00000000671194bb>] amdgpu_driver_load_kms+0x1e5/0x354 [amdgpu] [<000000005ad1722a>] amdgpu_pci_probe+0x150/0x1d2 [amdgpu] [<00000000e32ddc8a>] pci_device_probe+0xf3/0x17e [<00000000f74eb70d>] really_probe+0x215/0x539 [<00000000af9fda84>] driver_probe_device+0x9d/0xd6 [<00000000bc527018>] device_driver_attach+0x66/0x8a unreferenced object 0xffff8881700ceb30 (size 56): comm "systemd-udevd", pid 216, jiffies 4294885043 (age 1739.834s) hex dump (first 32 bytes): 88 f9 0c 70 81 88 ff ff 0d 01 2d 00 00 00 00 00 ...p......-..... 7c 98 01 00 00 c9 ff ff 00 00 00 00 00 00 00 00 |............... backtrace: [<00000000f3e5fc85>] kmem_cache_alloc+0x10a/0x1e4 [<00000000fff767c3>] acpi_ps_alloc_op+0x4e/0xdc [<00000000445cacf1>] acpi_ps_create_op+0x24e/0x473 [<000000003452a27a>] acpi_ps_parse_loop+0x25e/0xa39 [<000000004e3469e0>] acpi_ps_parse_aml+0xf3/0x450 [<00000000be1f7fd0>] acpi_ps_execute_method+0x278/0x2bb [<000000004564e9a8>] acpi_ns_evaluate+0x34f/0x45d [<0000000072f73c39>] acpi_evaluate_object+0x201/0x3b5 [<0000000036379e33>] amdgpu_atcs_call+0x11d/0x19b [amdgpu] [<00000000829cc77d>] amdgpu_acpi_init+0xf3/0x7b8 [amdgpu] [<00000000671194bb>] amdgpu_driver_load_kms+0x1e5/0x354 [amdgpu] [<000000005ad1722a>] amdgpu_pci_probe+0x150/0x1d2 [amdgpu] [<00000000e32ddc8a>] pci_device_probe+0xf3/0x17e [<00000000f74eb70d>] really_probe+0x215/0x539 [<00000000af9fda84>] driver_probe_device+0x9d/0xd6 [<00000000bc527018>] device_driver_attach+0x66/0x8a # inxi -bZ System: Host: yea Kernel: 5.13.0-rc3-bdver3 x86_64 bits: 64 Console: tty 1 Distro: Gentoo Base System release 2.7 Machine: Type: Desktop Mobo: ASRock model: FM2A88M Pro3+ serial: N/A UEFI: American Megatrends v: P2.60 date: 01/11/2016 CPU: Info: Quad Core AMD A10 PRO-7800B R7 12 Compute Cores 4C+8G [MCP] speed: 1897 MHz min/max: 1400/3500 MHz Graphics: Device-1: Advanced Micro Devices [AMD/ATI] Kaveri [Radeon R7 Graphics] driver: amdgpu v: kernel Display: server: X.org 1.20.11 driver: amdgpu,ati unloaded: fbdev,modesetting tty: 211x54 Message: Advanced graphics data unavailable in console for root. Network: Device-1: Realtek RTL8111/8168/8411 PCI Express Gigabit Ethernet driver: r8169 # lspci -s 00:01.0 -vv 00:01.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Kaveri [Radeon R7 Graphics] (prog-if 00 [VGA controller]) Subsystem: ASRock Incorporation Kaveri [Radeon R7 Graphics] Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+ Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0, Cache Line Size: 64 bytes Interrupt: pin A routed to IRQ 56 IOMMU group: 0 Region 0: Memory at c0000000 (64-bit, prefetchable) [size=256M] Region 2: Memory at d0000000 (64-bit, prefetchable) [size=8M] Region 4: I/O ports at f000 [size=256] Region 5: Memory at feb00000 (32-bit, non-prefetchable) [size=256K] Expansion ROM at 000c0000 [disabled] [size=128K] Capabilities: [48] Vendor Specific Information: Len=08 <?> Capabilities: [50] Power Management version 3 Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0-,D1+,D2+,D3hot+,D3cold-) Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- Capabilities: [58] Express (v2) Root Complex Integrated Endpoint, MSI 00 DevCap: MaxPayload 256 bytes, PhantFunc 0 ExtTag+ RBE+ FLReset- DevCtl: CorrErr- NonFatalErr- FatalErr- UnsupReq- RlxdOrd+ ExtTag+ PhantFunc- AuxPwr- NoSnoop+ MaxPayload 256 bytes, MaxReadReq 512 bytes DevSta: CorrErr- NonFatalErr- FatalErr- UnsupReq- AuxPwr- TransPend- DevCap2: Completion Timeout: Not Supported, TimeoutDis- NROPrPrP- LTR- 10BitTagComp- 10BitTagReq- OBFF Not Supported, ExtFmt+ EETLPPrefix+, MaxEETLPPrefixes 1 EmergencyPowerReduction Not Supported, EmergencyPowerReductionInit- FRS- AtomicOpsCap: 32bit- 64bit- 128bitCAS- DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR- OBFF Disabled, AtomicOpsCtl: ReqEn- Capabilities: [a0] MSI: Enable+ Count=1/1 Maskable- 64bit+ Address: 00000000fee02004 Data: 0029 Capabilities: [100 v1] Vendor Specific Information: ID=0001 Rev=1 Len=010 <?> Capabilities: [270 v1] Secondary PCI Express LnkCtl3: LnkEquIntrruptEn- PerformEqu- LaneErrStat: 0 Capabilities: [2b0 v1] Address Translation Service (ATS) ATSCap: Invalidate Queue Depth: 00 ATSCtl: Enable+, Smallest Translation Unit: 00 Capabilities: [2c0 v1] Page Request Interface (PRI) PRICtl: Enable- Reset- PRISta: RF- UPRGI- Stopped+ Page Request Capacity: 00000020, Page Request Allocation: 00000000 Capabilities: [2d0 v1] Process Address Space ID (PASID) PASIDCap: Exec- Priv-, Max PASID Width: 10 PASIDCtl: Enable- Exec- Priv- Kernel driver in use: amdgpu Kernel modules: amdgpu -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

1 14

[PATCH] drm/msm: potential error pointer dereference in init()
by Dan Carpenter 04 Oct '21

04 Oct '21

The msm_iommu_new() returns error pointers on failure so check for that to avoid an Oops. Fixes: ccac7ce373c1 ("drm/msm: Refactor address space initialization") Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c index ae48f41821cf..ad247c06e198 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c @@ -908,6 +908,10 @@ static int _dpu_kms_mmu_init(struct dpu_kms *dpu_kms) return 0; mmu = msm_iommu_new(dpu_kms->dev->dev, domain); + if (IS_ERR(mmu)) { + iommu_domain_free(domain); + return PTR_ERR(mmu); + } aspace = msm_gem_address_space_create(mmu, "dpu1", 0x1000, 0x100000000 - 0x1000); -- 2.20.1

3 2

[PATCH] drm/msm: Fix potential Oops in a6xx_gmu_rpmh_init()
by Dan Carpenter 04 Oct '21

04 Oct '21

There are two problems here: 1) The "seqptr" is used uninitalized when we free it at the end. 2) The a6xx_gmu_get_mmio() function returns error pointers. It never returns true. Fixes: 64245fc55172 ("drm/msm/a6xx: use AOP-initialized PDC for a650") Fixes: f8fc924e088e ("drm/msm/a6xx: Fix PDC register overlap") Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c index a7c58018959f..3bd6e579ea89 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c @@ -512,11 +512,11 @@ static void a6xx_gmu_rpmh_init(struct a6xx_gmu *gmu) struct adreno_gpu *adreno_gpu = &a6xx_gpu->base; struct platform_device *pdev = to_platform_device(gmu->dev); void __iomem *pdcptr = a6xx_gmu_get_mmio(pdev, "gmu_pdc"); - void __iomem *seqptr; + void __iomem *seqptr = NULL; uint32_t pdc_address_offset; bool pdc_in_aop = false; - if (!pdcptr) + if (IS_ERR(pdcptr)) goto err; if (adreno_is_a650(adreno_gpu) || adreno_is_a660_family(adreno_gpu)) @@ -528,7 +528,7 @@ static void a6xx_gmu_rpmh_init(struct a6xx_gmu *gmu) if (!pdc_in_aop) { seqptr = a6xx_gmu_get_mmio(pdev, "gmu_pdc_seq"); - if (!seqptr) + if (IS_ERR(seqptr)) goto err; } -- 2.20.1

2 1

[PATCH i-g-t v12 00/15] Introduce PXP Test
by Alan Previn 04 Oct '21

04 Oct '21

This series adds gem_pxp tests for the new PXP subsystem currently being reviewed at https://patchwork.freedesktop.org/series/90503/. This series currently includes 4 groups of tests addressing the features and restrictions described by Daniele's series : 1. test i915 interfaces for allocation of protected bo's and contexts and enforcement of UAPI rule disallowing the modification of parameters after it's been created. 2. verify PXP subsystem protected sessions generate encrypted content on protected output buffers and decrypt protected inputs buffers. 3. verify i915 PXP auto-teardown succeeds on suspend-resume cycles and gem-exec of stale protected assets fail. Ensure protected-contexts adhere to stricter invalidation enforcement upon teardown event. 4. Ensure that display plane decryption works as expected with protected buffers. NOTE: This series is on the tenth revision. All R-v-b's have been received except UAPI patch which will be dropped at merge time (after kernel patches gets merged and igt's drm UAPI gets sync'd). Changes from prior rev1 to now: v12: - Rebase on latest igt and updated the UAPI changes to align with commits from kernel side. v11: - When detecting hw support, retry pxp context creation multiple times a timeout as per HW SLA. - initialize bo or ctx handles to zero before calling creation ioctl wrapper. v10: - In patch #2, reuse existing gem_create_ext wrapper. - In patch #10, kernel side changed the debugfs file name (but no difference in behavior / usage). - Removed patch #14 from Rev9 as decision on kernel side was to drop the usage of RESET_STATS IOCTL to track invalidated pxp contexts. v9: - Remove patch #2 from rev7 as it was duplicating an existing ioctl wrapper helper - Fix the false-negative warnings when triggering auto-suspend-resume (remove checking if we are suspending after the system has already resumed). v8: - Nothing - mistaken detection from patchwork v7: - In prior rev, Patches #11->13 was testing expected results from calling gem_execbuf with stale pxp-context, pxp-buffer or combinations of them (including an opt-out usage). All of them used a single suspend-resume power state cycles to trigger the PXP teardown event. These patches have been combined into patch #14 that continues to carry the prior rev Rvb. - In its place, the new patches of #11->#13 do the identical set of tests as before (results from gem_execbuf with various combinations of stale pxp context and buffer), but this time using a debugfs file handle that triggers the same code path taken when the HW triggers the pxp teardown. That said, the code is nearly identical as v6 but I did not keep the Rvb's. - In patch #15, RESET_STAT now reports invalidated / banned pxp contexts via the existing batch_active's lost count. v6: - Addressed rev5 review comments for patch #1, #7, #14 and #17. - For #17, I'm using Rodrigo's Rv-b because offline discussions concluded that we couldn't use those test sequences with HDCP and so it was removed it. - Added Rv-b into all patches that received it. - Modified the test requirement from a list of device ids to checking if runtime PXP interface succeeds due to kernel's build config dependency. v5: - Addressed all rev4 review comments. No changes to overall flow and logic compared to the last rev. v4: - Addressed all rev3 review comments. NOTE: that all test cases and code logic are the same but a decent amount of refactoring has occured due to address v3 comments to break out subtests into separate functions while combining certain checks into the same function to reduce test time by minimizing number of suspend-resume power cycles. v3: - Addressed all rev2 review comments. - In line with one of the rev2 comments, a thorough fixup of all line-breaks in function calls was made for a more consistent styling. - Rebased on igt upstream repo and updated to latest kernel UAPI that added GEM_CREATE_EXT. v2: - Addressed all rev1 review comments except these: 1.Chris Wilson : "...have the caller do 1-3 once for its protected context. Call it something like intel_bb_enable_pxp(), intel_bb_set_pxp if it should be reversible.". - This couldn't be implemented because [1] HW needs different instruction sequences for enabling/disabling PXP depending on the engine class and [2] the pair of "pxp-enable" and "pxp- disable" instructions need to be contained within the same batch that is dispatched to the hardware. That said, implementing internal intel_batchbuffer funtionality for this would conflict with how rendercopy_gen9 uses batch buffer memory by repositioing the pointer and consuming unused portions of the batch buffer as 3d state offsets that batchbuffer has no visibility. - Added these additional subtests: 1. verify that buffer sharing works across testing pxp context. 2. verify teardown bans contexts via DRM_IOCTL_I915_GET_RESET_STAT. 3. verify display plane decryption of protected buffers. Alan Previn (14): i915_drm.h sync Add basic PXP testing of buffer and context alloc Perform a regular 3d copy as a control checkpoint Add PXP attribute support in batchbuffer and buffer_ops libs Add MI_SET_APPID instruction definition Enable protected session cmd in gen12_render_copyfunc Add subtest to copy raw source to protected dest Add test where both src and dest are protected Verify PXP teardown occurred through suspend-resume Verify execbuf fails with stale PXP context after teardown Verify execbuf fails with stale PXP buffer after teardown Verify execbuf ok with stale PXP buf in opt-out use Verify execution behavior with stale PXP assets through suspend-resume Verify protected surfaces are dma buffer sharable Karthik B S (1): tests/i915_pxp: CRC validation for display tests. include/drm-uapi/i915_drm.h | 94 +++ lib/intel_batchbuffer.c | 23 +- lib/intel_batchbuffer.h | 31 + lib/intel_bufops.h | 15 + lib/intel_reg.h | 8 + lib/rendercopy_gen9.c | 57 ++ tests/i915/gem_pxp.c | 1283 +++++++++++++++++++++++++++++++++++ tests/meson.build | 1 + 8 files changed, 1511 insertions(+), 1 deletion(-) create mode 100644 tests/i915/gem_pxp.c -- 2.25.1

1 0

[PULL] drm-intel-next
by Rodrigo Vivi 04 Oct '21

04 Oct '21

Hi Dave and Daniel, Here goes an accumulated pull request. A special highlight to the ADL-P (XE_LPD) and DG2 display support preparation and on a big clean-up in the display portion of the driver. Here goes drm-intel-next-2021-10-04: Cross-subsystem Changes: - fbdev/efifb: Release PCI device's runtime PM ref during FB destr\ oy (Imre) i915 Core Driver Changes: - Only access SFC_DONE in media when not fused off for graphics 12 and newer. - Double Memory latency values from pcode for DG2 (Matt Roper) - ADL-S PCI ID update (Tejas) - New DG1 PCI ID (Jose) - Fix regression with uncore refactoring (Dave) i915 Display Changes: - ADL-P display (XE_LPD) fixes and updates (Ankit, Jani, Matt Roper, Anusham, Jose, Imre, Vandita) - DG2 display fixes (Ankit, Jani) - Expand PCH_CNP tweaked display workaround to all newer displays (Anshuman) - General display simplifications and clean-ups (Jani, Swati, Jose, Ville) - PSR Clean-ups, dropping support for BDW/HSD and enable PSR2 selective fetch by default (Jose, Gwan-gyeong) - Nuke ORIGIN_GTT (Jose) - Return proper DPRX link training result (Lee) - FBC related refactor and fixes (Ville) - Yet another attempt to solve the fast+narrow vs slow+wide eDP link training (Kai-Heng) - DP 2.0 preparation work (Jani) - Silence __iomem sparse warn (Ville) - Clean up DPLL stuff (Ville) - Fix various dp/edp max rates (Matt Atwood, Animesh, Jani) - Remove VBT ddi_port_info caching (Jani) - DSI driver improvements (Lee) - HDCP fixes (Juston) - Associate ACPI connector nodes with connector entries (Heikki) - Add support for out-of-bound hotplug events (Hans) - VESA vendor block and drm/i915 MSO use of it (Jani) - Fixes for bigjoiner (Ville) - Update memory bandwidth parameters (RK) - DMC related fixes (Chris, Jose) - HDR related fixes and improvements (Tejas) - g4x/vlv/chv CxSR/wm fixes/cleanups (Ville) - Use BIOS provided value for RKL Audio's HDA link (Kai-Heng) - Fix the dsc check while selecting min_cdclk (Vandita) - Split and constify vtable (Dave) - Add ww context to intel_dpt_pin (Maarten) - Fix bdb version check (Lukasz) - DP per-lane drive settings prep work and other DP fixes (Ville) Thanks, Rodrigo. The following changes since commit 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f: Linux 5.15-rc1 (2021-09-12 16:28:37 -0700) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-next-2021-10-04 for you to fetch changes up to 104c1b3d6fb6a794babd5e2ffd6a5183b5a3d6c7: drm/i915: Allow per-lane drive settings with LTTPRs (2021-10-04 13:04:36 +0300) ---------------------------------------------------------------- Cross-subsystem Changes: - fbdev/efifb: Release PCI device's runtime PM ref during FB destr\ oy (Imre) i915 Core Driver Changes: - Only access SFC_DONE in media when not fused off for graphics 12 and newer. - Double Memory latency values from pcode for DG2 (Matt Roper) - ADL-S PCI ID update (Tejas) - New DG1 PCI ID (Jose) - Fix regression with uncore refactoring (Dave) i915 Display Changes: - ADL-P display (XE_LPD) fixes and updates (Ankit, Jani, Matt Roper, Anusham, Jose, Imre, Vandita) - DG2 display fixes (Ankit, Jani) - Expand PCH_CNP tweaked display workaround to all newer displays (Anshuman) - General display simplifications and clean-ups (Jani, Swati, Jose, Ville) - PSR Clean-ups, dropping support for BDW/HSD and enable PSR2 selective fetch by default (Jose, Gwan-gyeong) - Nuke ORIGIN_GTT (Jose) - Return proper DPRX link training result (Lee) - FBC related refactor and fixes (Ville) - Yet another attempt to solve the fast+narrow vs slow+wide eDP link training (Kai-Heng) - DP 2.0 preparation work (Jani) - Silence __iomem sparse warn (Ville) - Clean up DPLL stuff (Ville) - Fix various dp/edp max rates (Matt Atwood, Animesh, Jani) - Remove VBT ddi_port_info caching (Jani) - DSI driver improvements (Lee) - HDCP fixes (Juston) - Associate ACPI connector nodes with connector entries (Heikki) - Add support for out-of-bound hotplug events (Hans) - VESA vendor block and drm/i915 MSO use of it (Jani) - Fixes for bigjoiner (Ville) - Update memory bandwidth parameters (RK) - DMC related fixes (Chris, Jose) - HDR related fixes and improvements (Tejas) - g4x/vlv/chv CxSR/wm fixes/cleanups (Ville) - Use BIOS provided value for RKL Audio's HDA link (Kai-Heng) - Fix the dsc check while selecting min_cdclk (Vandita) - Split and constify vtable (Dave) - Add ww context to intel_dpt_pin (Maarten) - Fix bdb version check (Lukasz) - DP per-lane drive settings prep work and other DP fixes (Ville) ---------------------------------------------------------------- Animesh Manna (3): drm/i915/dg2: UHBR tables added for pll programming drm/i915/dp: fix EHL/JSL max source rates calculation drm/i915/dp: fix for ADL_P/S dp/edp max source rates Ankit Nautiyal (2): drm/i915/display: Fix the 12 BPC bits for PIPE_MISC reg drm/i915/dg2: Configure PCON in DP pre-enable path Anshuman Gupta (1): drm/i915: Tweaked Wa_14010685332 for all PCHs Anusha Srivatsa (1): drm/i915/dmc: Update to DMC v2.12 Chris Wilson (1): drm/i915: Free all DMC payloads Dave Airlie (25): drm/i915/uncore: split the fw get function into separate vfunc drm/i915/pm: drop get_fifo_size vfunc. drm/i915: make update_wm take a dev_priv. drm/i915/wm: provide wrappers around watermark vfuncs calls (v3) drm/i915: add wrappers around cdclk vtable funcs. drm/i915/display: add intel_fdi_link_train wrapper. drm/i915: split clock gating init from display vtable drm/i915: split watermark vfuncs from display vtable. drm/i915: split color functions from display vtable drm/i915: split audio functions from display vtable drm/i915: split cdclk functions from display vtable. drm/i915: split irq hotplug function from display vtable drm/i915: split fdi link training from display vtable. drm/i915: split the dpll clock compute out from display vtable. drm/i915: constify fdi link training vtable drm/i915: constify hotplug function vtable. drm/i915: constify color function vtable. drm/i915: constify the audio function vtable drm/i915: constify the dpll clock vtable drm/i915: constify the cdclk vtable drm/i915: drop unused function ptr and comments. drm/i915: constify display function vtable drm/i915: constify clock gating init vtable. drm/i915: constify display wm vtable drm/i915: fix regression with uncore refactoring. Gwan-gyeong Mun (1): drm/i915/display/psr: Do full fetch when handling multi-planar formats Hans de Goede (1): drm/i915/dp: Add support for out-of-bound hotplug events Heikki Krogerus (1): drm/i915: Associate ACPI connector nodes with connector entries (v2) Imre Deak (19): fbdev/efifb: Release PCI device's runtime PM ref during FB destroy drm/i915: Use tile block based dimensions for CCS origin x, y check drm/i915/adlp: Require always a power-of-two sized CCS surface stride drm/i915/adlp: Assert that VMAs in DPT start at 0 drm/i915: Follow a new->old platform check order in intel_fb_stride_alignment drm/i915/adlp: Add support for remapping CCS FBs drm/i915/tc: Fix TypeC port init/resume time sanitization drm/i915/adlp/tc: Fix PHY connected check for Thunderbolt mode drm/i915/tc: Remove waiting for PHY complete during releasing ownership drm/i915/tc: Check for DP-alt, legacy sinks before taking PHY ownership drm/i915/tc: Add/use helpers to retrieve TypeC port properties drm/i915/tc: Don't keep legacy TypeC ports in connected state w/o a sink drm/i915/tc: Add a mode for the TypeC PHY's disconnected state drm/i915/tc: Refactor TC-cold block/unblock helpers drm/i915/tc: Avoid using legacy AUX PW in TBT mode drm/i915/icl/tc: Remove the ICL special casing during TC-cold blocking drm/i915/tc: Fix TypeC PHY connect/disconnect logic on ADL-P drm/i915/tc: Drop extra TC cold blocking from intel_tc_port_connected() drm/i915/tc: Fix system hang on ADL-P during TypeC PHY disconnect Jani Nikula (81): drm/i915/edp: fix eDP MSO pipe sanity checks for ADL-P drm/i915/mst: use intel_de_rmw() to simplify VC payload alloc set/clear drm/i915/dp: pass crtc_state to intel_ddi_dp_level() drm/i915/dg2: use existing mechanisms for SNPS PHY translations drm/i915/dg2: add SNPS PHY translations for UHBR link rates Merge drm/drm-next into drm-intel-next drm/i915/dp: remove superfluous EXPORT_SYMBOL() drm/i915/irq: reduce inlines to reduce header dependencies drm/i915: intel_runtime_pm.h does not actually need intel_display.h drm/i915/pm: use forward declaration to remove an include drm/i915/panel: move intel_panel_use_ssc() out of headers drm/i915/fdi: move intel_fdi_link_freq() to intel_fdi.[ch] drm/i915/dp: use actual link rate values in struct link_config_limits drm/i915/dp: read sink UHBR rates drm/i915/dg2: add TRANS_DP2_CTL register definition drm/i915/dg2: add TRANS_DP2_VFREQHIGH and TRANS_DP2_VFREQLOW drm/i915/dg2: add DG2 UHBR source rates drm/i915/dp: add max data rate calculation for UHBR rates drm/i915/fdi: make intel_fdi_link_freq() return int drm/i915/display: split out dpt out of intel_display.c drm/i915: add HAS_ASYNC_FLIPS feature macro drm/i915/fb: move intel_tile_width_bytes() to intel_fb.c drm/i915/fb: move intel_fb_align_height() to intel_fb.c drm/i915/fb: move intel_surf_alignment() to intel_fb.c drm/i915/fb: move user framebuffer stuff to intel_fb.c drm/i915/backlight: extract backlight code to a separate file drm/i915/backlight: mass rename functions to have intel_backlight_ prefix drm/i915/panel: mass rename functions to have intel_panel_ prefix drm/i915/snps: constify struct intel_mpllb_state arrays harder drm/i915/fdi: move intel_update_fdi_pll_freq to intel_fdi.c drm/i915/fdi: move fdi bc bifurcation functions to intel_fdi.c drm/i915/fdi: move more FDI stuff to FDI link train hooks drm/i915/fdi: move fdi mphy reset and programming to intel_fdi.c drm/i915/fdi: convert BUG()'s to MISSING_CASE() drm/i915: remove unused i915->active_pipes drm/i915/dp: fix DG2 max source rate check drm/i915/debugfs: clean up LPSP status drm/i915/debugfs: clean up LPSP capable drm/i915/dp: fix TGL and ICL max source rates drm/i915/dp: fix DG1 and RKL max source rates drm/i915/bios: use hdmi level shift directly from child data drm/i915/bios: use max tmds clock directly from child data drm/i915/bios: use dp max link rate directly from child data drm/i915/bios: use alternate aux channel directly from child data drm/i915/bios: move ddc pin mapping code next to ddc pin sanitize drm/i915/bios: use ddc pin directly from child data drm/i915/bios: get rid of vbt ddi_port_info drm/displayid: re-align data block macros drm/displayid: add DisplayID v2.0 data blocks and primary use cases drm/edid: abstract OUI conversion to 24-bit int drm/edid: parse the DisplayID v2.0 VESA vendor block for MSO drm/i915/edp: postpone MSO init until after EDID read drm/i915/edp: use MSO pixel overlap from DisplayID data drm/dp: add DP 2.0 UHBR link rate and bw code conversions drm/dp: use more of the extended receiver cap drm/dp: add LTTPR DP 2.0 DPCD addresses drm/dp: add helper for extracting adjust 128b/132b TX FFE preset drm/i915/dg2: add DG2+ TRANS_DDI_FUNC_CTL DP 2.0 128b/132b mode drm/i915/dp: add helper for checking for UHBR link rate drm/i915/dp: use 128b/132b TPS2 for UHBR+ link rates drm/i915/dp: select 128b/132b channel encoding for UHBR rates drm/i915/dg2: configure TRANS_DP2_CTL for DP 2.0 drm/i915/dp: add HAS_DP20 macro drm/i915/dg2: use 128b/132b transcoder DDI mode drm/i915/dg2: configure TRANS_DP2_VFREQ{HIGH,LOW} for 128b/132b drm/i915/fdi: move fdi modeset asserts to intel_fdi.c drm/i915/pps: move pps (panel) modeset asserts to intel_pps.c drm/i915/dpll: move dpll modeset asserts to intel_dpll.c drm/i915/dsi: move dsi pll modeset asserts to vlv_dsi_pll.c drm/i915/dsi: pass struct mipi_dsi_packet pointer, not the entire struct drm/i915/dsi: fuse dsi_send_pkt_payld() and add_payld_to_queue() drm/i915/dsi: return -EBUSY instead of -1 drm/i915/hdmi: return -EINVAL instead of -1 drm/i915/drv: return -EIO instead of -1 drm/i915/dram: return -EINVAL instead of -1 drm/i915/fdi: use -EAGAIN instead of local special return value drm/i915/hdmi: convert intel_hdmi_to_dev to intel_hdmi_to_i915 drm/i915/debugfs: register LPSP capability on all platforms drm/i915/display: stop returning errors from debugfs registration drm/i915/debugfs: pass intel_connector to intel_connector_debugfs_add() drm/i915/reg: add AUD_TCA_DP_2DOT0_CTRL registers José Roberto de Souza (24): drm/i915/display: Fix sel fetch plane offset calculation drm/i915: Nuke ORIGIN_GTT drm/i915/display: Drop PSR support from HSW and BDW drm/i915/display: Move DRRS code its own file drm/i915/display: Renaming DRRS functions to intel_drrs_*() drm/i915/display: Some code improvements and code style fixes for DRRS drm/i915/display: Share code between intel_drrs_flush and intel_drrs_invalidate drm/i915/display: Prepare DRRS for frontbuffer rendering drop drm/i915/dg1: Add new PCI id drm/i915/display/adlp: Fix PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR calculation drm/i915/display: Wait at least 2 frames before selective update drm/i915/display: Workaround cursor left overs with PSR2 selective fetch enabled drm/i915/display/psr: Use drm damage helpers to calculate plane damaged area drm/i915/display/adlp: Add new PSR2 workarounds drm/i915/display/dmc: Set DC_STATE_DEBUG_MASK_CORES after firmware load drm/i915/display: Match PSR2 selective fetch sequences with specification drm/i915/display: Only keep PSR enabled if there is active planes drm/i915/display/psr: Handle plane and pipe restrictions at every page flip drm/i915/display: Drop unnecessary frontbuffer flushes drm/i915/display: Handle frontbuffer rendering when PSR2 selective fetch is enabled drm/i915/display: Fix glitches when moving cursor with PSR2 selective fetch enabled drm/i915/display/adlp: Optimize PSR2 power-savings in corner cases drm/i915/display/adlp: Allow PSR2 to be enabled drm/i915/display: Enable PSR2 selective fetch by default Juston Li (3): drm/i915/hdcp: update cp_irq_count_cached in intel_dp_hdcp2_read_msg() drm/i915/hdcp: read RxInfo once when reading RepeaterAuth_Send_ReceiverID_List drm/i915/hdcp: reuse rx_info for mst stream type1 capability check Kai-Heng Feng (2): drm/i915/dp: Use max params for panels < eDP 1.4 drm/i915/audio: Use BIOS provided value for RKL HDA link Lee Shawn C (6): drm/i915/dp: return proper DPRX link training result drm/i915/dsi: wait for header and payload credit available drm/i915/dsi: refine send MIPI DCS command sequence drm/i915: Get proper min cdclk if vDSC enabled drm/i915/dsi: Retrieve max brightness level from VBT drm/i915/dsi: Read/write proper brightness value via MIPI DCS command Lukasz Majczak (1): drm/i915/bdb: Fix version check Maarten Lankhorst (1): drm/i915: Add ww context to intel_dpt_pin, v2. Matt Atwood (1): drm/i915/dp: Fix eDP max rate for display 11+ Matt Roper (3): drm/i915: Only access SFC_DONE when media domain is not fused off drm/i915/adl_p: Also disable underrun recovery with MSO drm/i915/dg2: Memory latency values from pcode must be doubled Radhakrishna Sripada (1): drm/i915: Update memory bandwidth parameters Rodrigo Vivi (2): Merge tag 'drm-misc-intel-oob-hotplug-v1' of git://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux into drm-intel-next Merge drm/drm-next into drm-intel-next Swati Sharma (1): drm/i915/dp: Drop redundant debug print Tejas Upadhyay (3): drm/i915/adl_s: Update ADL-S PCI IDs drm/i915/display: Add HDR mode helper function drm/i915/gen11: Disable cursor clock gating in HDR mode Vandita Kulkarni (4): drm/i915/display: Update small joiner ram size drm/i915/dsi/xelpd: Add WA to program LP to HS wakeup guardband drm/i915/dsi/xelpd: Enable mipi dsi support. drm/i915/display: Fix the dsc check while selecting min_cdclk Ville Syrjälä (63): drm/i915/fbc: Rewrite the FBC tiling check a bit drm/i915/fbc: Extract intel_fbc_update() drm/i915/fbc: Move the "recompress on activate" to a central place drm/i915/fbc: Polish the skl+ FBC stride override handling drm/i915: Silence __iomem sparse warn drm/i915: Set output_types to EDP for vlv/chv DPLL forcing drm/i915: Clean up gen2 DPLL readout drm/i915: Extract ilk_update_pll_dividers() drm/i915: Constify struct dpll all over drm/i915: Clean dpll calling convention drm/i915: Clean up variable names in old dpll functions drm/i915: Remove the 'reg' local variable drm/i915: Program DPLL P1 dividers consistently drm/i915: Call {vlv,chv}_prepare_pll() from {vlv,chv}_enable_pll() drm/i915: Reuse ilk_needs_fb_cb_tune() for the reduced clock as well drm/i915: Fold i9xx_set_pll_dividers() into i9xx_enable_pll() drm/i915: Fold ibx_pch_dpll_prepare() into ibx_pch_dpll_enable() drm/i915: Nuke intel_prepare_shared_dpll() drm/i915: Extract intel_dp_need_bigjoiner() drm/i915: Flatten hsw_crtc_compute_clock() drm/i915: s/pipe/transcoder/ when dealing with PIPECONF/TRANSCONF drm/i915: Introduce with_intel_display_power_if_enabled() drm/i915: Adjust intel_dsc_power_domain() calling convention drm/i915: Extract hsw_panel_transcoders() drm/i915: s/crtc_state/new_crtc_state/ etc. drm/i915: Use u8 consistently for active_planes bitmask drm/i915: Fix g4x cxsr enable condition drm/i915: Apply WaUse32BppForSRWM to elk as well as ctg drm/i915: Fix HPLL watermark readout for g4x drm/i915/fbc: Rework cfb stride/size calculations drm/i915/fbc: Align FBC segments to 512B on glk+ drm/i915/fbc: Implement Wa_16011863758 for icl+ drm/i915/fbc: Allow higher compression limits on FBC1 drm/i915: Extract intel_panel_mode_valid() drm/i915: Use intel_panel_mode_valid() for DSI/LVDS/(s)DVO drm/i915: Reject modes that don't match fixed_mode vrefresh drm/i915: Introduce intel_panel_compute_config() drm/i915: Reject user modes that don't match fixed mode's refresh rate drm/i915: Drop pointless fixed_mode checks from dsi code drm/i915: Enable TPS3/4 on all platforms that support them drm/i915/fbc: Allow FBC with Yf tiling drm/i915: Pimp HSW+ transcoder state readout drm/i915: Configure TRANSCONF just the once with bigjoiner drm/i915: Clear leftover DP vswing/preemphasis values before modeset drm/i915: Call intel_ddi_init_dp_buf_reg() earlier drm/i915: Remove DP_PORT_EN stuff from link training code drm/i915: Nuke local copies/pointers of intel_dp->DP drm/i915: s/ddi_translations/trans/ drm/i915: Use standard form -EDEADLK check drm/i915: Adjust intel_crtc_compute_config() debug message drm/i915: Move WaPruneModeWithIncorrectHsyncOffset into intel_mode_valid() drm/i915: Stop force enabling pipe bottom color gammma/csc drm/i915: Fix DP clock recovery "voltage_tries" handling drm/i915: Introduce has_iboost() drm/i915: Introduce has_buf_trans_select() drm/i915: Generalize .set_signal_levels() drm/i915: Nuke useless .set_signal_levels() wrappers drm/i915: De-wrapper bxt_ddi_phy_set_signal_levels() drm/i915: Hoover the level>=n_entries WARN into intel_ddi_level() drm/i915: Nuke intel_ddi_hdmi_num_entries() drm/i915: Pass the lane to intel_ddi_level() drm/i915: Prepare link training for per-lane drive settings drm/i915: Allow per-lane drive settings with LTTPRs Documentation/gpu/i915.rst | 25 +- drivers/gpu/drm/drm_connector.c | 79 + drivers/gpu/drm/drm_crtc_internal.h | 2 + drivers/gpu/drm/drm_dp_helper.c | 42 +- drivers/gpu/drm/drm_edid.c | 89 +- drivers/gpu/drm/drm_sysfs.c | 87 +- drivers/gpu/drm/i915/Makefile | 3 + drivers/gpu/drm/i915/display/g4x_dp.c | 86 +- drivers/gpu/drm/i915/display/icl_dsi.c | 161 +- drivers/gpu/drm/i915/display/intel_acpi.c | 46 + drivers/gpu/drm/i915/display/intel_acpi.h | 3 + drivers/gpu/drm/i915/display/intel_audio.c | 48 +- drivers/gpu/drm/i915/display/intel_backlight.c | 1776 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_backlight.h | 52 + drivers/gpu/drm/i915/display/intel_bios.c | 397 +++-- drivers/gpu/drm/i915/display/intel_bw.c | 19 +- drivers/gpu/drm/i915/display/intel_cdclk.c | 345 ++-- drivers/gpu/drm/i915/display/intel_cdclk.h | 4 +- drivers/gpu/drm/i915/display/intel_color.c | 140 +- drivers/gpu/drm/i915/display/intel_connector.c | 6 +- drivers/gpu/drm/i915/display/intel_crt.c | 4 +- drivers/gpu/drm/i915/display/intel_cursor.c | 9 +- drivers/gpu/drm/i915/display/intel_ddi.c | 479 +++-- drivers/gpu/drm/i915/display/intel_ddi.h | 7 +- drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c | 670 +++---- drivers/gpu/drm/i915/display/intel_ddi_buf_trans.h | 11 +- drivers/gpu/drm/i915/display/intel_display.c | 1713 +++++------------- drivers/gpu/drm/i915/display/intel_display.h | 32 +- .../gpu/drm/i915/display/intel_display_debugfs.c | 121 +- .../gpu/drm/i915/display/intel_display_debugfs.h | 10 +- drivers/gpu/drm/i915/display/intel_display_power.c | 9 +- drivers/gpu/drm/i915/display/intel_display_power.h | 4 + drivers/gpu/drm/i915/display/intel_display_types.h | 41 +- drivers/gpu/drm/i915/display/intel_dmc.c | 25 +- drivers/gpu/drm/i915/display/intel_dp.c | 753 +++----- drivers/gpu/drm/i915/display/intel_dp.h | 22 +- drivers/gpu/drm/i915/display/intel_dp_aux.c | 6 +- .../gpu/drm/i915/display/intel_dp_aux_backlight.c | 12 +- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 78 +- .../gpu/drm/i915/display/intel_dp_link_training.c | 159 +- drivers/gpu/drm/i915/display/intel_dp_mst.c | 30 +- drivers/gpu/drm/i915/display/intel_dpio_phy.c | 28 +- drivers/gpu/drm/i915/display/intel_dpio_phy.h | 5 +- drivers/gpu/drm/i915/display/intel_dpll.c | 672 +++---- drivers/gpu/drm/i915/display/intel_dpll.h | 26 +- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 46 +- drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 11 - drivers/gpu/drm/i915/display/intel_dpt.c | 239 +++ drivers/gpu/drm/i915/display/intel_dpt.h | 19 + drivers/gpu/drm/i915/display/intel_drrs.c | 437 +++++ drivers/gpu/drm/i915/display/intel_drrs.h | 36 + drivers/gpu/drm/i915/display/intel_dsi.c | 16 +- drivers/gpu/drm/i915/display/intel_dsi.h | 3 + .../gpu/drm/i915/display/intel_dsi_dcs_backlight.c | 33 +- drivers/gpu/drm/i915/display/intel_dvo.c | 24 +- drivers/gpu/drm/i915/display/intel_fb.c | 606 ++++++- drivers/gpu/drm/i915/display/intel_fb.h | 20 +- drivers/gpu/drm/i915/display/intel_fbc.c | 292 ++-- drivers/gpu/drm/i915/display/intel_fbc.h | 2 +- drivers/gpu/drm/i915/display/intel_fbdev.c | 3 +- drivers/gpu/drm/i915/display/intel_fdi.c | 321 +++- drivers/gpu/drm/i915/display/intel_fdi.h | 17 +- drivers/gpu/drm/i915/display/intel_frontbuffer.c | 5 +- drivers/gpu/drm/i915/display/intel_frontbuffer.h | 4 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 64 +- drivers/gpu/drm/i915/display/intel_hdmi.c | 20 +- drivers/gpu/drm/i915/display/intel_hotplug.c | 4 +- drivers/gpu/drm/i915/display/intel_lvds.c | 33 +- drivers/gpu/drm/i915/display/intel_opregion.c | 5 +- drivers/gpu/drm/i915/display/intel_panel.c | 1835 +------------------- drivers/gpu/drm/i915/display/intel_panel.h | 48 +- drivers/gpu/drm/i915/display/intel_pps.c | 59 + drivers/gpu/drm/i915/display/intel_pps.h | 3 + drivers/gpu/drm/i915/display/intel_psr.c | 476 ++--- drivers/gpu/drm/i915/display/intel_psr.h | 13 +- drivers/gpu/drm/i915/display/intel_sdvo.c | 19 +- drivers/gpu/drm/i915/display/intel_snps_phy.c | 225 ++- drivers/gpu/drm/i915/display/intel_snps_phy.h | 4 +- drivers/gpu/drm/i915/display/intel_tc.c | 290 ++-- drivers/gpu/drm/i915/display/intel_tc.h | 6 +- drivers/gpu/drm/i915/display/intel_tv.c | 2 +- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 5 + drivers/gpu/drm/i915/display/intel_vdsc.c | 77 +- drivers/gpu/drm/i915/display/intel_vdsc.h | 6 +- drivers/gpu/drm/i915/display/skl_universal_plane.c | 9 +- drivers/gpu/drm/i915/display/vlv_dsi.c | 51 +- drivers/gpu/drm/i915/display/vlv_dsi_pll.c | 23 + drivers/gpu/drm/i915/gt/intel_ggtt.c | 29 +- drivers/gpu/drm/i915/i915_drv.c | 7 +- drivers/gpu/drm/i915/i915_drv.h | 161 +- drivers/gpu/drm/i915/i915_irq.c | 94 +- drivers/gpu/drm/i915/i915_irq.h | 51 +- drivers/gpu/drm/i915/i915_params.h | 2 +- drivers/gpu/drm/i915/i915_pci.c | 4 +- drivers/gpu/drm/i915/i915_reg.h | 77 +- drivers/gpu/drm/i915/i915_vma_types.h | 7 +- drivers/gpu/drm/i915/intel_dram.c | 4 +- drivers/gpu/drm/i915/intel_pm.c | 290 ++-- drivers/gpu/drm/i915/intel_pm.h | 3 +- drivers/gpu/drm/i915/intel_runtime_pm.h | 2 - drivers/gpu/drm/i915/intel_uncore.c | 72 +- drivers/gpu/drm/i915/intel_uncore.h | 7 +- drivers/usb/typec/altmodes/Kconfig | 1 + drivers/usb/typec/altmodes/displayport.c | 58 +- drivers/video/fbdev/efifb.c | 21 +- include/drm/drm_connector.h | 37 + include/drm/drm_displayid.h | 101 +- include/drm/drm_dp_helper.h | 6 + include/drm/i915_pciids.h | 8 +- 109 files changed, 8213 insertions(+), 6576 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_backlight.c create mode 100644 drivers/gpu/drm/i915/display/intel_backlight.h create mode 100644 drivers/gpu/drm/i915/display/intel_dpt.c create mode 100644 drivers/gpu/drm/i915/display/intel_dpt.h create mode 100644 drivers/gpu/drm/i915/display/intel_drrs.c create mode 100644 drivers/gpu/drm/i915/display/intel_drrs.h

1 0

[PATCH 00/10] drm: Add privacy-screen class and connector properties
by Hans de Goede 04 Oct '21

04 Oct '21

Hi all, Here is a new version of my privacy-screen series, addressing the (few) review-remarks from the version posted on September 6th. This new version contains the following changes: - drm: Add privacy-screen class (v4) - Make drm_privacy_screen_set_sw_state() skip calling out to the hw if hw_state == new_sw_state - drm/privacy-screen: Add notifier support (v2) - Drop WARN_ON(mutex_is_locked(&priv->lock)) check in drm_privacy_screen_call_notifier_chain() it may be locked by another thread, which would lead to a false-positive triggering of the check (change requested by Lyude) - drm/connector: Add a drm_connector privacy-screen helper functions (v2) - Do not update connector->state->privacy_screen_sw_state on atomic-commits (change requested by Ville) - Change drm_connector_update_privacy_screen() to take drm_connector_state as argument instead of a full drm_atomic_state. This allows the helper to be called by drivers when they are enabling crtcs/encoders/connectors. - platform/x86: thinkpad_acpi: Register a privacy-screen device (v3) - On receiving a TP_HKEY_EV_PRIVACYGUARD_TOGGLE event only call drm_privacy_screen_call_notifier_chain() if the privacy-screen state has actually changed - drm/i915: Add intel_modeset_probe_defer() helper - New patch in this version of the series (change requested by Jani) - drm/i915: Add privacy-screen support (v2) - Call drm_connector_update_privacy_screen() from intel_enable_ddi_dp() / intel_ddi_update_pipe_dp() instead of adding a for_each_new_connector_in_state() loop to intel_atomic_commit_tail() (change requested by Ville) - Move the probe-deferral check to the intel_modeset_probe_defer() helper (change requested by Jani) With these changes I believe that this series now is fully ready for merging, but the last 2 patches need to be (re)reviewed. Here is some more info from the previous cover-letters: The first userspace consumer of the new properties is now fully ready for merging (it is just waiting for the kernel bits to land first): - https://gitlab.gnome.org/GNOME/gsettings-desktop-schemas/-/merge_requests/49 - https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1952 - https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1032 The new API works as designed and add the following features to GNOME: 1. Showing an OSD notification when the privacy-screen is toggled on/off through hotkeys handled by the embedded-controller 2. Allowing control of the privacy-screen from the GNOME control-panel, including the on/off slider shown there updating to match the hw-setting when the setting is changed with the control-panel open. 3. Restoring the last user-setting at login This series consists of a number of different parts: 1. A new version of Rajat's privacy-screen connector properties patch, this adds new userspace API in the form of new properties 2. Since on most devices the privacy screen is actually controlled by some vendor specific ACPI/WMI interface which has a driver under drivers/platform/x86, we need some "glue" code to make this functionality available to KMS drivers. Patches 2-4 add a new privacy-screen class for this, which allows non KMS drivers (and possibly KMS drivers too) to register a privacy-screen device and also adds an interface for KMS drivers to get access to the privacy-screen associated with a specific connector. This is modelled similar to how we deal with e.g. PWMs and GPIOs in the kernel, including separate includes for consumers and providers(drivers). 3. Some drm_connector helper functions to keep the actual changes needed for this in individual KMS drivers as small as possible (patch 5). 4. Make the thinkpad_acpi code register a privacy-screen device on ThinkPads with a privacy-screen (patches 6-8) 5. Make the i915 driver export the privacy-screen functionality through the connector properties on the eDP connector. I believe that it would be best to merge the entire series, including the thinkpad_acpi changes through drm-misc in one go. As the pdx86 subsys maintainer I hereby give my ack for merging the thinkpad_acpi changes through drm-misc. There is one small caveat with this series, which it is good to be aware of. The i915 driver will now return -EPROBE_DEFER on Thinkpads with an eprivacy screen, until the thinkpad_acpi driver is loaded. This means that initrd generation tools will need to be updated to include thinkpad_acpi when the i915 driver is added to the initrd. Without this the loading of the i915 driver will be delayed to after the switch to real rootfs. Regards, Hans Hans de Goede (9): drm: Add privacy-screen class (v4) drm/privacy-screen: Add X86 specific arch init code drm/privacy-screen: Add notifier support (v2) drm/connector: Add a drm_connector privacy-screen helper functions (v2) platform/x86: thinkpad_acpi: Add hotkey_notify_extended_hotkey() helper platform/x86: thinkpad_acpi: Get privacy-screen / lcdshadow ACPI handles only once platform/x86: thinkpad_acpi: Register a privacy-screen device drm/i915: Add intel_modeset_probe_defer() helper drm/i915: Add privacy-screen support (v2) Rajat Jain (1): drm/connector: Add support for privacy-screen properties (v4) Documentation/gpu/drm-kms-helpers.rst | 15 + Documentation/gpu/drm-kms.rst | 2 + MAINTAINERS | 8 + drivers/gpu/drm/Kconfig | 4 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_atomic_uapi.c | 4 + drivers/gpu/drm/drm_connector.c | 203 ++++++++ drivers/gpu/drm/drm_drv.c | 4 + drivers/gpu/drm/drm_privacy_screen.c | 467 +++++++++++++++++++ drivers/gpu/drm/drm_privacy_screen_x86.c | 86 ++++ drivers/gpu/drm/i915/display/intel_atomic.c | 1 + drivers/gpu/drm/i915/display/intel_ddi.c | 3 + drivers/gpu/drm/i915/display/intel_display.c | 23 + drivers/gpu/drm/i915/display/intel_display.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 10 + drivers/gpu/drm/i915/i915_pci.c | 9 +- drivers/platform/x86/Kconfig | 2 + drivers/platform/x86/thinkpad_acpi.c | 137 ++++-- include/drm/drm_connector.h | 55 +++ include/drm/drm_privacy_screen_consumer.h | 65 +++ include/drm/drm_privacy_screen_driver.h | 84 ++++ include/drm/drm_privacy_screen_machine.h | 46 ++ 22 files changed, 1181 insertions(+), 49 deletions(-) create mode 100644 drivers/gpu/drm/drm_privacy_screen.c create mode 100644 drivers/gpu/drm/drm_privacy_screen_x86.c create mode 100644 include/drm/drm_privacy_screen_consumer.h create mode 100644 include/drm/drm_privacy_screen_driver.h create mode 100644 include/drm/drm_privacy_screen_machine.h -- 2.31.1

2 16

← Newer
1
...
72
73
74
75
76
77
78
...
83
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel October 2021